testaro 14.2.6 → 14.4.0

package/testaro/miniText.js

@@ -30,7 +30,11 @@ exports.reporter = async (page, withItems) => {
         if (pixels < 11) {
           textParent.childNodes.forEach(node => {
             if (node.nodeType === 3 && compact(node.textContent)) {
-              miniTexts.push(compact(node.textContent));
+              miniTexts.push({
+                tagName: textParent.tagName,
+                id: textParent.id || '',
+                text: compact(node.textContent)
+              });
             }
           });
         }
@@ -49,12 +53,14 @@ exports.reporter = async (page, withItems) => {
         issueID: 'miniText',
         what: 'Text font is smaller than 11 pixels',
         ordinalSeverity: 2,
+        tagName: text.tagName,
+        id: text.id,
         location: {
           doc: '',
           type: '',
           spec: ''
         },
-        excerpt: text
+        excerpt: text.text
       });
     });
   }
@@ -62,7 +68,10 @@ exports.reporter = async (page, withItems) => {
     standardInstances.push({
       issueID: 'miniText',
       what: 'Texts have fonts smaller than 11 pixels',
+      count: data.total,
       ordinalSeverity: 2,
+      tagName: '',
+      id: '',
       location: {
         doc: '',
         type: '',

package/testaro/motion.js

@@ -98,6 +98,13 @@ exports.reporter = async (page, withItems, delay = 2500, interval = 2500, count
       pixelChanges.reduce((count, change) => count + (change ? 1 : 0), 0) / pixelChanges.length, 2
     );
     // Return the result.
+    const rawCount = 2 * (meanLocalRatio - 1)
+    + maxLocalRatio - 1
+    + globalRatio - 1
+    + meanPixelChange / 10000
+    + maxPixelChange / 25000
+    + 3 * changeFrequency;
+    const count = rawCount ? Math.round(rawCount) : 0;
     return {
       data: {
         bytes,
@@ -112,20 +119,17 @@ exports.reporter = async (page, withItems, delay = 2500, interval = 2500, count
       },
       totals: [
         0,
-        0, 
-        2 * (meanLocalRatio - 1)
-        + maxLocalRatio - 1
-        + globalRatio - 1
-        + meanPixelChange / 10000
-        + maxPixelChange / 25000
-        + 3 * changeFrequency
-        || 0,
+        0,
+        count,
         0
       ],
-      standardInstances: globalRatio > 1 ? [{
+      standardInstances: count ? [{
         issueID: 'motion',
         what: 'Content moves or changes without user request',
+        count,
         ordinalSeverity: 2,
+        tagName: '',
+        id: '',
         location: {
           doc: '',
           type: '',

package/testaro/nonTable.js

@@ -13,7 +13,10 @@ exports.reporter = async (page, withItems) => {
     const compact = string => string.replace(/[\t\n]/g, '').replace(/\s{2,}/g, ' ').trim();
     // Adds the first 100 characters of the code of a pseudotable to the array of pseudotable texts.
     const addBad = table => {
-      badTableTexts.push(compact(table.outerHTML).slice(0, 100));
+      badTableTexts.push({
+        id: table.id,
+        text: compact(table.outerHTML).slice(0, 100)
+      });
     };
     // FUNCTION DEFINITIONS END
     // For each table on the page:
@@ -63,17 +66,19 @@ exports.reporter = async (page, withItems) => {
   const standardInstances = [];
   if (withItems) {
     data.items = badTableTexts;
-    data.items.forEach(text => {
+    data.items.forEach(item => {
       standardInstances.push({
         issueID: 'nonTable',
         what: 'Table is misused to arrange content',
         ordinalSeverity: 0,
+        tagName: 'TABLE',
+        id: item.id,
         location: {
           doc: '',
           type: '',
           spec: ''
         },
-        excerpt: text
+        excerpt: item.text
       });
     });
   }
@@ -81,7 +86,10 @@ exports.reporter = async (page, withItems) => {
     standardInstances.push({
       issueID: 'nonTable',
       what: 'Tables are misused to arrange content',
-      ordinalSeverity: 2,
+      count: data.total,
+      ordinalSeverity: 0,
+      tagName: 'TABLE',
+      id: '',
       location: {
         doc: '',
         type: '',

package/testaro/radioSet.js

@@ -74,6 +74,7 @@ exports.reporter = async (page, withItems) => {
       totals.total = allRadios.length;
       totals.inSet = setRadios.length;
       totals.percent = totals.total ? Math.floor(100 * totals.inSet / totals.total) : 'N.A.';
+      const loneRadios = totals.total - totals.inSet;
       // If itemization is required:
       const standardInstances = [];
       if (withItems) {
@@ -81,26 +82,34 @@ exports.reporter = async (page, withItems) => {
         const nonSetRadios = allRadios.filter(radio => ! setRadios.includes(radio));
         const items = data.items;
         items.inSet = setRadios.map(radio => textOf(radio));
-        items.notInSet = nonSetRadios.map(radio => textOf(radio));
-        items.notInSet.forEach(text => {
+        items.notInSet = nonSetRadios.map(radio => ({
+          id: radio.id,
+          text: textOf(radio)
+        }));
+        items.notInSet.forEach(item => {
           standardInstances.push({
             issueID: 'radioSet',
-            what: 'Radio button and others with its name are not grouped in their own fieldset with a legend',
+            what: 'Radio button and its peers are not in a fieldset with a legend',
             ordinalSeverity: 2,
+            tagName: 'INPUT',
+            id: item.id,
             location: {
               doc: '',
               type: '',
               spec: ''
             },
-            excerpt: text
+            excerpt: item.text
           });
         });
       }
-      else if (totals.total - totals.inSet > 0) {
+      else if (loneRadios > 0) {
         standardInstances.push({
           issueID: 'radioSet',
           what: 'Radio buttons are not validly grouped in fieldsets with legends',
+          count: loneRadios,
           ordinalSeverity: 2,
+          tagName: 'INPUT',
+          id: '',
           location: {
             doc: '',
             type: '',
@@ -111,7 +120,7 @@ exports.reporter = async (page, withItems) => {
       }
       return {
         data,
-        totals: [0, 0, totals.total - totals.inSet, 0],
+        totals: [0, 0, loneRadios, 0],
         standardInstances
       };
     }

package/testaro/role.js

@@ -15,6 +15,7 @@ exports.reporter = async page => await page.$eval('body', body => {
 
   // CONSTANTS
 
+  // All roles implicit in HTML elements.
   const badRoles = new Set([
     'article',
     'banner',
@@ -52,7 +53,7 @@ exports.reporter = async page => await page.$eval('body', body => {
     'term',
     'textbox'
   ]);
-  // All non-abstract roles
+  // All non-abstract roles.
   const goodRoles = new Set([
     'alert',
     'alertdialog',
@@ -410,7 +411,7 @@ exports.reporter = async page => await page.$eval('body', body => {
 
   // OPERATION
 
-  // Remove the deprecated roles from the non-abstract roles.
+  // Remove the element-implicit roles from the non-abstract roles.
   goodRoles.forEach(role => {
     if (badRoles.has(role)) {
       goodRoles.delete(role);
@@ -481,12 +482,16 @@ exports.reporter = async page => await page.$eval('body', body => {
   const standardInstances = [];
   Object.keys(data.tagNames).forEach(tagName => {
     Object.keys(data.tagNames[tagName]).forEach(role => {
-      let count = data.tagNames[tagName][role].redundant;
-      if (count) {
+      const pairTotals = data.tagNames[tagName][role];
+      const redCount = pairTotals.redundant;
+      if (redCount) {
         standardInstances.push({
-          issueID: 'role',
-          what: `Elements ${tagName} have redundant explicit role ${role} (count: ${count})`,
+          issueID: 'role-redundant',
+          what: `${tagName} elements have redundant explicit role ${role} (count: ${redCount})`,
+          count: redCount,
           ordinalSeverity: 1,
+          tagName,
+          id: '',
           location: {
             doc: '',
             type: '',
@@ -495,12 +500,16 @@ exports.reporter = async page => await page.$eval('body', body => {
           excerpt: ''
         });
       }
-      count = data.tagNames[tagName][role].bad;
-      if (count) {
+      const badCount = pairTotals.bad;
+      if (badCount) {
         standardInstances.push({
-          issueID: 'role',
-          what: `Elements ${tagName} have invalid or native-replaceable explicit role ${role} (count: ${count})`,
+          issueID: 'role-bad',
+          what:
+          `${tagName} elements have invalid or native-replaceable explicit role ${role} (count: ${badCount})`,
+          count: badCount,
           ordinalSeverity: 3,
+          tagName,
+          id: '',
           location: {
             doc: '',
             type: '',

package/testaro/styleDiff.js

@@ -155,15 +155,15 @@ exports.reporter = async (page, withItems) => {
     const totals = [0, 0, 0, 0];
     const standardInstances = [];
     const elementData = {
-      adjacentLink: [0, 'In-line links'],
-      listLink: [1, 'Links in columns'],
-      button: [2, 'Buttons'],
-      h1: [3, 'Level-1 headings'],
-      h2: [3, 'Level-2 headings'],
-      h3: [3, 'Level-3 headings'],
-      h4: [3, 'Level-4 headings'],
-      h5: [3, 'Level-5 headings'],
-      h6: [3, 'Level-6 headings'],
+      adjacentLink: [0, 'In-line links', 'A'],
+      listLink: [1, 'Links in columns', 'A'],
+      button: [2, 'Buttons', 'BUTTON'],
+      h1: [3, 'Level-1 headings', 'H1'],
+      h2: [3, 'Level-2 headings', 'H2'],
+      h3: [3, 'Level-3 headings', 'H3'],
+      h4: [3, 'Level-4 headings', 'H4'],
+      h5: [3, 'Level-5 headings', 'H5'],
+      h6: [3, 'Level-6 headings', 'H6'],
     };
     Object.keys(elementData).forEach(elementName => {
       const elementTotal = data.totals[elementName];
@@ -171,11 +171,15 @@ exports.reporter = async (page, withItems) => {
         const currentData = elementData[elementName];
         const severity = currentData[0];
         const elementSubtotals = elementTotal.subtotals;
-        totals[severity] += elementSubtotals.length - 1;
+        const extraCount = elementSubtotals.length - 1;
+        totals[severity] += extraCount;
         standardInstances.push({
           issueID: 'styleDiff',
           what: `${currentData[1]} have ${elementSubtotals.length} different styles`,
+          count: extraCount,
           ordinalSeverity: severity,
+          tagName: currentData[2],
+          id: '',
           location: {
             doc: '',
             type: '',

package/testaro/tabNav.js

@@ -220,7 +220,10 @@ exports.reporter = async (page, withItems) => {
         if (withItems) {
           let found = true;
           // Initialize a report on the element.
-          itemData.tagName = await page.evaluate(element => element.tagName, currentTab)
+          const moreItemData = await page.evaluate(element => ({
+            tagName: element.tagName,
+            id: element.id
+          }), currentTab)
           .catch(error => {
             console.log(`ERROR: could not get tag name (${error.message})`);
             found = false;
@@ -228,6 +231,8 @@ exports.reporter = async (page, withItems) => {
             return 'ERROR: not found';
           });
           if (found) {
+            itemData.tagName = moreItemData.tagName;
+            itemData.id = moreItemData.id;
             itemData.text = await allText(page, currentTab);
             itemData.navigationErrors = [];
           }
@@ -335,14 +340,18 @@ exports.reporter = async (page, withItems) => {
     data.tabElements.incorrect.forEach(item => {
       standardInstances.push({
         issueID: 'tabNav',
-        what: `Element ${item.tagName} has a tab role but has nonstandard navigation`,
+        what:
+        `${item.tagName} element responds nonstandardly to ${item.navigationErrors.join(', ')}`,
+        count: item.navigationErrors.length,
         ordinalSeverity: 1,
+        tagName: item.tagName,
+        id: item.id,
         location: {
           doc: '',
           type: '',
           spec: ''
         },
-        excerpt: `${item.tagName}: ${item.text}`
+        excerpt: item.text
       });
     });
   }
@@ -350,7 +359,10 @@ exports.reporter = async (page, withItems) => {
     standardInstances.push({
       issueID: 'tabNav',
       what: 'Tablists have nonstandard navigation',
-      ordinalSeverity: 2,
+      count: data.totals.navigations.all.incorrect,
+      ordinalSeverity: 1,
+      tagName: '',
+      id: '',
       location: {
         doc: '',
         type: '',

package/testaro/titledEl.js

@@ -16,6 +16,7 @@ exports.reporter = async (page, withItems) => {
       // FUNCTION DEFINITION END
       return badTitleElements.map(element => ({
         tagName: element.tagName,
+        id: element.id,
         text: compact(element.textContent),
         title: compact(element.title)
       }));
@@ -30,8 +31,10 @@ exports.reporter = async (page, withItems) => {
     badTitleElements.forEach(element => {
       standardInstances.push({
         issueID: 'titledEl',
-        what: `Element ${element.tagName} has a title attribute`,
+        what: `${element.tagName} element has a title attribute`,
         ordinalSeverity: 2,
+        tagName: element.tagName,
+        id: element.id,
         location: {
           doc: '',
           type: '',
@@ -45,7 +48,10 @@ exports.reporter = async (page, withItems) => {
     standardInstances.push({
       issueID: 'titledEl',
       what: 'Ineligible elements have title attributes',
+      count: data.total,
       ordinalSeverity: 2,
+      tagName: '',
+      id: '',
       location: {
         doc: '',
         type: '',

package/testaro/zIndex.js

@@ -51,18 +51,18 @@ exports.reporter = async (page, withItems) => {
   const standardInstances = [];
   if (data.items) {
     data.items.forEach(item => {
-      const itemID = item.id ? ` (ID ${item.id})` : '';
-      const which = `${item.tagName}${itemID}`;
       standardInstances.push({
         issueID: 'zIndex',
-        what: `Element ${item.tagName} has a non-default Z index`,
+        what: `${item.tagName} element has a non-default Z index`,
         ordinalSeverity: 0,
+        tagName: item.tagName,
+        id: item.id,
         location: {
           doc: '',
           type: '',
           spec: ''
         },
-        excerpt: `${which}: ${item.text}`
+        excerpt: item.text
       });
     });
   }
@@ -70,7 +70,10 @@ exports.reporter = async (page, withItems) => {
     standardInstances.push({
       issueID: 'zIndex',
       what: 'Elements have non-default Z indexes',
+      count: data.totals.total,
       ordinalSeverity: 0,
+      tagName: '',
+      id: '',
       location: {
         doc: '',
         type: '',

package/tests/ibm.js

@@ -87,7 +87,7 @@ const trimReport = (report, withItems, rules) => {
   }
   return data;
 };
-// Performs an IBM test and returns the result.
+// Performs the IBM tests and returns the result.
 const doTest = async (content, withItems, timeLimit, rules) => {
   // Conduct the test and get the result.
   let report;