testaro 14.2.0 → 14.2.2

package/actSpecs.js

@@ -214,7 +214,6 @@ exports.actSpecs = {
     tenon: [
       'Perform Tenon tests',
       {
-        tenonData: [true, 'object', '', 'object with accessToken and requestIDs properties'],
         id: [true, 'string', 'hasLength', 'ID of the requested test instance']
       }
     ],
@@ -223,13 +222,13 @@ exports.actSpecs = {
       {
         withItems: [true, 'boolean', '', 'itemize'],
         rules: [false, 'array', 'areStrings', 'IDs of rules to include if array starts with y or exclude if with n, if not all evaluative rules'],
-        args: [false, 'object', '', 'extra args (object with rule properties and arrays of argument values as values ({focInd: [false, 250], hover: [-1], motion: [2500, 2500, 5]} by default'],
+        args: [false, 'object', 'areArrays', 'extra args (object with rule properties and arrays of argument values as values ({focInd: [false, 250], hover: [-1], motion: [2500, 2500, 5]} by default'],
       }
     ],
     wave: [
       'Perform WAVE tests',
       {
-        reportType: [true, 'number', '', 'WAVE report type']
+        reportType: [true, 'number', '', 'WAVE report type (1, 2, 3, or 4)']
       }
     ]
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "14.2.0",
+  "version": "14.2.2",
   "description": "Automation of accessibility testing",
   "main": "index.js",
   "scripts": {

package/run.js

@@ -107,6 +107,8 @@ const isFocusable = string => ['a', 'button', 'input', 'select'].includes(string
 const areNumbers = array => array.every(element => typeof element === 'number');
 // Returns whether all elements of an array are strings.
 const areStrings = array => array.every(element => typeof element === 'string');
+// Returns whether all properties of an object have array values.
+const areArrays = object => Object.values(object).every(value => Array.isArray(value));
 // Returns whether a variable has a specified type.
 const hasType = (variable, type) => {
   if (type === 'string') {
@@ -155,6 +157,9 @@ const hasSubtype = (variable, subtype) => {
     else if (subtype === 'areStrings') {
       return areStrings(variable);
     }
+    else if (subtype === 'areArrays') {
+      return areArrays(variable);
+    }
     else if (subtype === 'isState') {
       return isState(variable);
     }

package/standardize.js

@@ -107,18 +107,6 @@ const doNuVal = (result, standardResult, docType) => {
 const doQualWeb = (result, standardResult, ruleClassName) => {
   if (result.modules && result.modules[ruleClassName]) {
     const ruleClass = result.modules[ruleClassName];
-    if (ruleClass.metadata && ruleClass.modules) {
-      const {modules} = ruleClass;
-      const ruleTotals = modules['act-rules'] && modules['act-rules'].metadata;
-      const techniqueTotals = modules['wcag-techniques'] && modules['wcag-techniques'].metadata;
-      const practiceTotals = modules['best-practices'] && modules['best-practices'].metadata;
-      standardResult.totals = [
-        practiceTotals.warning + techniqueTotals.warning,
-        practiceTotals.failed + ruleTotals.warning,
-        techniqueTotals.failed,
-        ruleTotals.failed
-      ];
-    }
     const severities = {
       'best-practices': {
         warning: 0,
@@ -140,7 +128,7 @@ const doQualWeb = (result, standardResult, ruleClassName) => {
           const instance = {
             issueID: rule,
             what: ruleResult.description,
-            ordinalSeverity: severities[ruleClass][item.verdict],
+            ordinalSeverity: severities[ruleClassName][item.verdict],
             location: {
               doc: 'dom',
               type: 'selector',
@@ -149,6 +137,7 @@ const doQualWeb = (result, standardResult, ruleClassName) => {
             excerpt: cap(element.htmlCode)
           };
           standardResult.instances.push(instance);
+          standardResult.totals[instance.ordinalSeverity]++;
         });
       });
     });
@@ -158,7 +147,7 @@ const doQualWeb = (result, standardResult, ruleClassName) => {
 const doWAVE = (result, standardResult, categoryName) => {
   if (result.categories && result.categories[categoryName]) {
     const category = result.categories[categoryName];
-    const ordinalSeverity = categoryName === 'alert' ? 0 : 1;
+    const ordinalSeverity = categoryName === 'alert' ? 0 : 3;
     Object.keys(category.items).forEach(rule => {
       category.items[rule].selectors.forEach(selector => {
         const instance = {
@@ -181,12 +170,12 @@ const doWAVE = (result, standardResult, categoryName) => {
 const convert = (testName, result, standardResult) => {
   // alfa
   if (testName === 'alfa' && result.totals) {
-    standardResult.totals = [result.totals.warnings, result.totals.failures];
+    standardResult.totals = [result.totals.warnings, 0, 0, result.totals.failures];
     result.items.forEach(item => {
       const instance = {
         issueID: item.rule.ruleID,
         what: item.rule.ruleSummary,
-        ordinalSeverity: ['cantTell', 'failed'].indexOf(item.verdict),
+        ordinalSeverity: ['cantTell', '', '', 'failed'].indexOf(item.verdict),
         location: {
           doc: 'dom',
           type: 'xpath',
@@ -238,7 +227,9 @@ const convert = (testName, result, standardResult) => {
     const {instances} = standardResult;
     standardResult.totals = [
       instances.filter(instance => instance.ordinalSeverity === 0).length,
-      instances.filter(instance => instance.ordinalSeverity === 1).length
+      0,
+      0,
+      instances.filter(instance => instance.ordinalSeverity === 3).length
     ];
   }
   // ibm
@@ -248,7 +239,7 @@ const convert = (testName, result, standardResult) => {
       const instance = {
         issueID: item.ruleId,
         what: item.message,
-        ordinalSeverity: ['recommendation', 'violation'].indexOf(item.level),
+        ordinalSeverity: ['', 'recommendation', '', 'violation'].indexOf(item.level),
         location: {
           doc: 'dom',
           type: 'xpath',
@@ -270,8 +261,9 @@ const convert = (testName, result, standardResult) => {
     const {instances} = standardResult;
     standardResult.totals = [
       instances.filter(instance => instance.ordinalSeverity === 0).length,
-      instances.filter(instance => instance.ordinalSeverity === 1).length,
-      instances.filter(instance => instance.ordinalSeverity === 2).length
+      0,
+      instances.filter(instance => instance.ordinalSeverity === 2).length,
+      instances.filter(instance => instance.ordinalSeverity === 3).length,
     ];
   }
   // qualWeb
@@ -284,7 +276,7 @@ const convert = (testName, result, standardResult) => {
       || result.modules['best-practices']
     )
   ) {
-    standardResult.totals = [0, 0, 0, 0, 0, 0];
+    standardResult.totals = [0, 0, 0, 0];
     if (result.modules['act-rules']) {
       doQualWeb(result, standardResult, 'act-rules');
     }
@@ -325,7 +317,7 @@ const convert = (testName, result, standardResult) => {
     rules.forEach(rule => {
       const ruleResult = result.rules[rule];
       standardResult.totals.forEach((total, index) => {
-        standardResult.totals[index] += ruleResult.totals[index];
+        standardResult.totals[index] += ruleResult.totals[index] || 0;
       });
       standardResult.instances.push(... ruleResult.standardInstances);
     });
@@ -343,7 +335,10 @@ const convert = (testName, result, standardResult) => {
   ) {
     const {categories} = result;
     standardResult.totals = [
-      categories.alert.count || 0, (categories.error.count || 0) + (categories.contrast.count || 0)
+      categories.alert.count || 0,
+      0,
+      0,
+      (categories.error.count || 0) + (categories.contrast.count || 0)
     ];
     ['error', 'contrast', 'alert'].forEach(categoryName => {
       doWAVE(result, standardResult, categoryName);

package/testaro/filter.js

@@ -43,7 +43,7 @@ exports.reporter = async (page, withItems) => {
     }
     return data;
   }, withItems);
-  const totals = [0, data.totals.impactedElements, data.totals.styledElements, 0, 0];
+  const totals = [0, data.totals.impactedElements, data.totals.styledElements, 0];
   const standardInstances = [];
   if (data.items) {
     data.items.forEach(item => {

package/testaro/radioSet.js

@@ -86,7 +86,7 @@ exports.reporter = async (page, withItems) => {
           standardInstances.push({
             issueID: 'radioSet',
             what: 'Radio button and others with its name are not grouped in their own fieldset with a legend',
-            ordinalSeverity: 0,
+            ordinalSeverity: 2,
             location: {
               doc: '',
               type: '',
@@ -100,7 +100,7 @@ exports.reporter = async (page, withItems) => {
         standardInstances.push({
           issueID: 'radioSet',
           what: 'Radio buttons are not validly grouped in fieldsets with legends',
-          ordinalSeverity: 1,
+          ordinalSeverity: 2,
           location: {
             doc: '',
             type: '',
@@ -111,7 +111,7 @@ exports.reporter = async (page, withItems) => {
       }
       return {
         data,
-        totals: [0, totals.total - totals.inSet, 0, 0],
+        totals: [0, 0, totals.total - totals.inSet, 0],
         standardInstances
       };
     }

package/tests/testaro.js

@@ -29,7 +29,6 @@ const evalRules = {
   role: 'invalid, inadvised, and redundant explicit roles',
   styleDiff: 'style inconsistencies',
   tabNav: 'nonstandard keyboard navigation between elements with the tab role',
-  title: 'missing page title',
   titledEl: 'title attributes on inappropriate elements',
   zIndex: 'non-default Z indexes'
 };