tessera-learn 0.2.1 → 0.2.2

package/src/runtime/adapters/index.ts

@@ -19,27 +19,6 @@ export class LMSAdapterError extends Error {
   }
 }
 
-function missingApiError(
-  standard: 'scorm12' | 'scorm2004' | 'cmi5',
-): LMSAdapterError {
-  const label =
-    standard === 'scorm12'
-      ? 'SCORM 1.2'
-      : standard === 'scorm2004'
-        ? 'SCORM 2004'
-        : 'cmi5';
-  const detail =
-    standard === 'cmi5'
-      ? 'No cmi5 launch parameters (fetch / endpoint / activityId / actor) on the URL.'
-      : `No ${label} API object found in the window.parent or window.opener chain.`;
-  return new LMSAdapterError(
-    standard,
-    `Tessera: this course is configured for ${label} but ${detail} ` +
-      `The course must be launched from an LMS that provides the ${label} runtime. ` +
-      `If you are testing locally, run \`npm run dev\` instead, or set export.standard to "web".`,
-  );
-}
-
 export interface CreateAdapterOptions {
   /**
    * When true, a missing LMS API falls back to `WebAdapter` with a console
@@ -49,44 +28,68 @@ export interface CreateAdapterOptions {
   allowFallback?: boolean;
 }
 
-/**
- * Select the appropriate persistence adapter based on course config.
- *
- * In production builds, an LMS-configured course (scorm12/scorm2004/cmi5)
- * will throw `LMSAdapterError` if the matching LMS API isn't reachable —
- * we fail loud so a misconfigured launch is visible immediately rather
- * than silently losing tracking to localStorage.
- *
- * In dev mode, missing APIs warn and fall back to `WebAdapter` so authors
- * can still iterate locally.
- */
 type LMSStandard = 'scorm12' | 'scorm2004' | 'cmi5';
 
-/** Per-standard LMS detection. `detect` returns an adapter when the LMS runtime is reachable, else null. */
+/** Per-standard LMS wiring: `detect` returns an adapter when the LMS runtime is reachable, else null. Labels are the single source for the dev warning and production error. */
 const LMS_ADAPTERS: Record<
   LMSStandard,
-  { detect: () => PersistenceAdapter | null; label: string }
+  {
+    detect: () => PersistenceAdapter | null;
+    warnLabel: string;
+    name: string;
+    missingDetail: string;
+  }
 > = {
   scorm12: {
     detect: () => {
       const api = findSCORM12API();
       return api ? new SCORM12Adapter(api) : null;
     },
-    label: 'SCORM 1.2 API',
+    warnLabel: 'SCORM 1.2 API',
+    name: 'SCORM 1.2',
+    missingDetail:
+      'No SCORM 1.2 API object found in the window.parent or window.opener chain.',
   },
   scorm2004: {
     detect: () => {
       const api = findSCORM2004API();
       return api ? new SCORM2004Adapter(api) : null;
     },
-    label: 'SCORM 2004 API',
+    warnLabel: 'SCORM 2004 API',
+    name: 'SCORM 2004',
+    missingDetail:
+      'No SCORM 2004 API object found in the window.parent or window.opener chain.',
   },
   cmi5: {
     detect: () => (hasCMI5LaunchParams() ? new CMI5Adapter() : null),
-    label: 'cmi5 launch parameters',
+    warnLabel: 'cmi5 launch parameters',
+    name: 'cmi5',
+    missingDetail:
+      'No cmi5 launch parameters (fetch / endpoint / activityId / actor) on the URL.',
   },
 };
 
+function missingApiError(standard: LMSStandard): LMSAdapterError {
+  const { name, missingDetail } = LMS_ADAPTERS[standard];
+  return new LMSAdapterError(
+    standard,
+    `Tessera: this course is configured for ${name} but ${missingDetail} ` +
+      `The course must be launched from an LMS that provides the ${name} runtime. ` +
+      `If you are testing locally, run \`npm run dev\` instead, or set export.standard to "web".`,
+  );
+}
+
+/**
+ * Select the appropriate persistence adapter based on course config.
+ *
+ * In production builds, an LMS-configured course (scorm12/scorm2004/cmi5)
+ * will throw `LMSAdapterError` if the matching LMS API isn't reachable —
+ * we fail loud so a misconfigured launch is visible immediately rather
+ * than silently losing tracking to localStorage.
+ *
+ * In dev mode, missing APIs warn and fall back to `WebAdapter` so authors
+ * can still iterate locally.
+ */
 export function createAdapter(
   config: CourseConfig,
   options: CreateAdapterOptions = {},
@@ -103,7 +106,7 @@ export function createAdapter(
     if (adapter) return adapter;
     if (!allowFallback) throw missingApiError(standard);
     console.warn(
-      `Tessera (dev): ${entry.label} not found — falling back to localStorage`,
+      `Tessera (dev): ${entry.warnLabel} not found — falling back to localStorage`,
     );
   }
   return new WebAdapter(config);

package/src/runtime/adapters/scorm12.ts

@@ -29,7 +29,7 @@ const SCORM12_DIALECT: ScormDialect<SCORM12API> = {
     responseField: 'student_response',
     timestampField: 'time',
     timestamp: () => new Date().toTimeString().slice(0, 8),
-    typeValue: (t) => scorm12Type(t),
+    typeValue: scorm12Type,
     resultLabels: { correct: 'correct', incorrect: 'wrong' },
     format: SCORM12_INTERACTION_FORMAT,
   },