terser 5.31.4 → 5.31.6

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 
-## v5.31.4
+## v5.31.6
+ - Retain side effects in a `case` when the expression is a sequence (comma) expression
+
+## v5.31.5
+ - Revert v5.31.4, which created mysterious issues #1548, #1549
+
+## v5.31.4 (reverted)
  - drop_unused: drop classes which only have side effects in the `extends` part
 
 ## v5.31.3

package/dist/bundle.min.js

@@ -2,7 +2,7 @@
 typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('@jridgewell/source-map')) :
 typeof define === 'function' && define.amd ? define(['exports', '@jridgewell/source-map'], factory) :
 (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.Terser = {}, global.sourceMap));
-})(this, (function (exports, sourceMap) { 'use strict';
+}(this, (function (exports, sourceMap) { 'use strict';
 
 /***********************************************************************
 
@@ -5905,9 +5905,6 @@ var AST_Class = DEFNODE("Class", "name extends properties", function AST_Class(p
         }));
         return found;
     },
-    body_has_side_effects(compressor) {
-        return this.properties.some(prop => prop.has_side_effects(compressor));
-    },
 }, AST_Scope /* TODO a class might have a scope but it's not a scope */);
 
 var AST_ClassProperty = DEFNODE("ClassProperty", "static quote", function AST_ClassProperty(props) {
@@ -13839,7 +13836,7 @@ function is_nullish(node, compressor) {
         return any(this.definitions, compressor);
     });
     def_has_side_effects(AST_VarDef, function() {
-        return this.value;
+        return this.value != null;
     });
     def_has_side_effects(AST_TemplateSegment, return_false);
     def_has_side_effects(AST_TemplateString, function(compressor) {
@@ -14982,7 +14979,7 @@ def_drop_side_effect_free(AST_Arrow, return_null);
 def_drop_side_effect_free(AST_Class, function (compressor) {
     const with_effects = [];
 
-    if (this.is_self_referential() && this.body_has_side_effects(compressor)) {
+    if (this.is_self_referential() && this.has_side_effects(compressor)) {
         return this;
     }
 
@@ -15290,7 +15287,7 @@ AST_Scope.DEFMETHOD("drop_unused", function(compressor) {
             });
         }
         if (node === self) return;
-        if (node instanceof AST_Class && node.body_has_side_effects(compressor)) {
+        if (node instanceof AST_Class && node.has_side_effects(compressor)) {
             if (node.is_self_referential()) {
                 descend();
             } else {
@@ -19591,7 +19588,9 @@ def_optimize(AST_Switch, function(self, compressor) {
                 eliminate_branch(branch, body[body.length - 1]);
                 continue;
             }
-            if (exp instanceof AST_Node) exp = branch.expression.tail_node().evaluate(compressor);
+            if (exp instanceof AST_Node && !exp.has_side_effects(compressor)) {
+                exp = branch.expression.tail_node().evaluate(compressor);
+            }
             if (exp === value) {
                 exact_match = branch;
                 if (default_branch) {
@@ -19773,12 +19772,9 @@ def_optimize(AST_Switch, function(self, compressor) {
             break DEFAULT;
         }
 
-        let sideEffect = body.find(branch => {
-            return (
-                branch !== default_or_exact
-                && branch.expression.has_side_effects(compressor)
-            );
-        });
+        let sideEffect = body.find(
+            branch => branch !== default_or_exact && branch.expression.has_side_effects(compressor)
+        );
         // If no cases cause a side-effect, we can eliminate the switch entirely.
         if (!sideEffect) {
             return make_node(AST_BlockStatement, self, {
@@ -19886,9 +19882,10 @@ def_optimize(AST_Switch, function(self, compressor) {
                         right: branch.expression,
                     }),
                     body: consequent,
-                    alternative: null
-                })
-            ].concat(always)
+                    alternative: null,
+                }),
+                always,
+            ],
         }).optimize(compressor);
     }
     return self;
@@ -19911,13 +19908,12 @@ def_optimize(AST_Switch, function(self, compressor) {
         let pblock = make_node(AST_BlockStatement, prev, { body: pbody });
         return bblock.equivalent_to(pblock);
     }
-    function statement(expression) {
-        return make_node(AST_SimpleStatement, expression, {
-            body: expression
-        });
+    function statement(body) {
+        return make_node(AST_SimpleStatement, body, { body });
     }
     function has_nested_break(root) {
         let has_break = false;
+
         let tw = new TreeWalker(node => {
             if (has_break) return true;
             if (node instanceof AST_Lambda) return true;
@@ -32550,4 +32546,4 @@ exports._run_cli = run_cli;
 exports.minify = minify;
 exports.minify_sync = minify_sync;
 
-}));
+})));

package/lib/ast.js

@@ -2289,9 +2289,6 @@ var AST_Class = DEFNODE("Class", "name extends properties", function AST_Class(p
         }));
         return found;
     },
-    body_has_side_effects(compressor) {
-        return this.properties.some(prop => prop.has_side_effects(compressor));
-    },
 }, AST_Scope /* TODO a class might have a scope but it's not a scope */);
 
 var AST_ClassProperty = DEFNODE("ClassProperty", "static quote", function AST_ClassProperty(props) {

package/lib/compress/drop-side-effect-free.js

@@ -156,7 +156,7 @@ def_drop_side_effect_free(AST_Arrow, return_null);
 def_drop_side_effect_free(AST_Class, function (compressor) {
     const with_effects = [];
 
-    if (this.is_self_referential() && this.body_has_side_effects(compressor)) {
+    if (this.is_self_referential() && this.has_side_effects(compressor)) {
         return this;
     }
 

package/lib/compress/drop-unused.js

@@ -153,7 +153,7 @@ AST_Scope.DEFMETHOD("drop_unused", function(compressor) {
             });
         }
         if (node === self) return;
-        if (node instanceof AST_Class && node.body_has_side_effects(compressor)) {
+        if (node instanceof AST_Class && node.has_side_effects(compressor)) {
             if (node.is_self_referential()) {
                 descend();
             } else {

package/lib/compress/index.js

@@ -1233,7 +1233,9 @@ def_optimize(AST_Switch, function(self, compressor) {
                 eliminate_branch(branch, body[body.length - 1]);
                 continue;
             }
-            if (exp instanceof AST_Node) exp = branch.expression.tail_node().evaluate(compressor);
+            if (exp instanceof AST_Node && !exp.has_side_effects(compressor)) {
+                exp = branch.expression.tail_node().evaluate(compressor);
+            }
             if (exp === value) {
                 exact_match = branch;
                 if (default_branch) {
@@ -1415,12 +1417,9 @@ def_optimize(AST_Switch, function(self, compressor) {
             break DEFAULT;
         }
 
-        let sideEffect = body.find(branch => {
-            return (
-                branch !== default_or_exact
-                && branch.expression.has_side_effects(compressor)
-            );
-        });
+        let sideEffect = body.find(
+            branch => branch !== default_or_exact && branch.expression.has_side_effects(compressor)
+        );
         // If no cases cause a side-effect, we can eliminate the switch entirely.
         if (!sideEffect) {
             return make_node(AST_BlockStatement, self, {
@@ -1528,9 +1527,10 @@ def_optimize(AST_Switch, function(self, compressor) {
                         right: branch.expression,
                     }),
                     body: consequent,
-                    alternative: null
-                })
-            ].concat(always)
+                    alternative: null,
+                }),
+                always,
+            ],
         }).optimize(compressor);
     }
     return self;
@@ -1553,13 +1553,12 @@ def_optimize(AST_Switch, function(self, compressor) {
         let pblock = make_node(AST_BlockStatement, prev, { body: pbody });
         return bblock.equivalent_to(pblock);
     }
-    function statement(expression) {
-        return make_node(AST_SimpleStatement, expression, {
-            body: expression
-        });
+    function statement(body) {
+        return make_node(AST_SimpleStatement, body, { body });
     }
     function has_nested_break(root) {
         let has_break = false;
+
         let tw = new TreeWalker(node => {
             if (has_break) return true;
             if (node instanceof AST_Lambda) return true;

package/lib/compress/inference.js

@@ -424,7 +424,7 @@ export function is_nullish(node, compressor) {
         return any(this.definitions, compressor);
     });
     def_has_side_effects(AST_VarDef, function() {
-        return this.value;
+        return this.value != null;
     });
     def_has_side_effects(AST_TemplateSegment, return_false);
     def_has_side_effects(AST_TemplateString, function(compressor) {

package/package.json

@@ -4,7 +4,7 @@
   "homepage": "https://terser.org",
   "author": "Mihai Bazon <mihai.bazon@gmail.com> (http://lisperator.net/)",
   "license": "BSD-2-Clause",
-  "version": "5.31.4",
+  "version": "5.31.6",
   "engines": {
     "node": ">=10"
   },