terser 5.19.2 → 5.19.4

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## v5.19.4
+ - Prevent creating very deeply nested ternaries from a long list of `if..return`
+ - Prevent inlining classes into other functions, to avoid constructors being compared.
+
+## v5.19.3
+ - Fix side effect detection of `optional?.chains`.
+ - Add roundRect to domprops.js (#1426)
+
 ## v5.19.2
  - fix performance hit from avoiding HTML comments in the output
 

package/LICENSE

@@ -1,5 +1,3 @@
-Terser is released under the BSD license:
-
 Copyright 2012-2018 (c) Mihai Bazon <mihai.bazon@gmail.com>
 
 Redistribution and use in source and binary forms, with or without

package/bin/terser.mjs

@@ -0,0 +1,18 @@
+#!/usr/bin/env node
+
+"use strict";
+
+import "../tools/exit.cjs";
+
+import fs from "fs";
+import path from "path";
+import program from "commander";
+
+import { _run_cli as run_cli } from "../main.js";
+
+const packageJson= JSON.parse( fs.readFileSync( new URL("./package.json", import.meta.url)));
+
+run_cli({ program, packageJson, fs, path }).catch((error) => {
+    console.error(error);
+    process.exitCode = 1;
+});

package/dist/bundle.min.js

@@ -2,7 +2,7 @@
 typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports, require('@jridgewell/source-map')) :
 typeof define === 'function' && define.amd ? define(['exports', '@jridgewell/source-map'], factory) :
 (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.Terser = {}, global.sourceMap));
-})(this, (function (exports, sourceMap) { 'use strict';
+}(this, (function (exports, sourceMap) { 'use strict';
 
 /***********************************************************************
 
@@ -13690,16 +13690,27 @@ function is_nullish(node, compressor) {
         return any(this.elements, compressor);
     });
     def_has_side_effects(AST_Dot, function(compressor) {
-        if (is_nullish(this, compressor)) return false;
-        return !this.optional && this.expression.may_throw_on_access(compressor)
-            || this.expression.has_side_effects(compressor);
+        if (is_nullish(this, compressor)) {
+            return this.expression.has_side_effects(compressor);
+        }
+        if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+            return true;
+        }
+
+        return this.expression.has_side_effects(compressor);
     });
     def_has_side_effects(AST_Sub, function(compressor) {
-        if (is_nullish(this, compressor)) return false;
+        if (is_nullish(this, compressor)) {
+            return this.expression.has_side_effects(compressor);
+        }
+        if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+            return true;
+        }
 
-        return !this.optional && this.expression.may_throw_on_access(compressor)
-            || this.expression.has_side_effects(compressor)
-            || this.property.has_side_effects(compressor);
+        var property = this.property.has_side_effects(compressor);
+        if (property && this.optional) return true; // "?." is a condition
+
+        return property || this.expression.has_side_effects(compressor);
     });
     def_has_side_effects(AST_Chain, function (compressor) {
         return this.expression.has_side_effects(compressor);
@@ -15039,7 +15050,9 @@ def_drop_side_effect_free(AST_Dot, function (compressor, first_in_statement) {
     if (is_nullish_shortcircuited(this, compressor)) {
         return this.expression.drop_side_effect_free(compressor, first_in_statement);
     }
-    if (this.expression.may_throw_on_access(compressor)) return this;
+    if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+        return this;
+    }
 
     return this.expression.drop_side_effect_free(compressor, first_in_statement);
 });
@@ -15048,15 +15061,17 @@ def_drop_side_effect_free(AST_Sub, function (compressor, first_in_statement) {
     if (is_nullish_shortcircuited(this, compressor)) {
         return this.expression.drop_side_effect_free(compressor, first_in_statement);
     }
-    if (this.expression.may_throw_on_access(compressor)) return this;
+    if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+        return this;
+    }
 
-    var expression = this.expression.drop_side_effect_free(compressor, first_in_statement);
-    if (!expression)
-        return this.property.drop_side_effect_free(compressor, first_in_statement);
     var property = this.property.drop_side_effect_free(compressor);
-    if (!property)
-        return expression;
-    return make_sequence(this, [expression, property]);
+    if (property && this.optional) return this;
+
+    var expression = this.expression.drop_side_effect_free(compressor, first_in_statement);
+
+    if (expression && property) return make_sequence(this, [expression, property]);
+    return expression || property;
 });
 
 def_drop_side_effect_free(AST_Chain, function (compressor, first_in_statement) {
@@ -17147,7 +17162,11 @@ function tighten_body(statements, compressor) {
         var self = compressor.self();
         var multiple_if_returns = has_multiple_if_returns(statements);
         var in_lambda = self instanceof AST_Lambda;
-        for (var i = statements.length; --i >= 0;) {
+        // Prevent extremely deep nesting
+        // https://github.com/terser/terser/issues/1432
+        // https://github.com/webpack/webpack/issues/17548
+        const iteration_start = Math.min(statements.length, 500);
+        for (var i = iteration_start; --i >= 0;) {
             var stat = statements[i];
             var j = next_index(i);
             var next = statements[j];
@@ -17770,6 +17789,10 @@ function inline_into_symbolref(self, compressor) {
             && !fixed.may_throw(compressor);
     }
 
+    if (fixed instanceof AST_Class && def.scope !== self.scope) {
+        return self;
+    }
+
     if (single_use && (fixed instanceof AST_Lambda || fixed instanceof AST_Class)) {
         if (retain_top_func(fixed, compressor)) {
             single_use = false;
@@ -28528,6 +28551,7 @@ var domprops = [
     "rotationAngle",
     "rotationRate",
     "round",
+    "roundRect",
     "row-gap",
     "rowGap",
     "rowIndex",
@@ -30969,4 +30993,4 @@ exports._default_options = _default_options;
 exports._run_cli = run_cli;
 exports.minify = minify;
 
-}));
+})));

package/lib/compress/drop-side-effect-free.js

@@ -321,7 +321,9 @@ def_drop_side_effect_free(AST_Dot, function (compressor, first_in_statement) {
     if (is_nullish_shortcircuited(this, compressor)) {
         return this.expression.drop_side_effect_free(compressor, first_in_statement);
     }
-    if (this.expression.may_throw_on_access(compressor)) return this;
+    if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+        return this;
+    }
 
     return this.expression.drop_side_effect_free(compressor, first_in_statement);
 });
@@ -330,15 +332,17 @@ def_drop_side_effect_free(AST_Sub, function (compressor, first_in_statement) {
     if (is_nullish_shortcircuited(this, compressor)) {
         return this.expression.drop_side_effect_free(compressor, first_in_statement);
     }
-    if (this.expression.may_throw_on_access(compressor)) return this;
+    if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+        return this;
+    }
 
-    var expression = this.expression.drop_side_effect_free(compressor, first_in_statement);
-    if (!expression)
-        return this.property.drop_side_effect_free(compressor, first_in_statement);
     var property = this.property.drop_side_effect_free(compressor);
-    if (!property)
-        return expression;
-    return make_sequence(this, [expression, property]);
+    if (property && this.optional) return this;
+
+    var expression = this.expression.drop_side_effect_free(compressor, first_in_statement);
+
+    if (expression && property) return make_sequence(this, [expression, property]);
+    return expression || property;
 });
 
 def_drop_side_effect_free(AST_Chain, function (compressor, first_in_statement) {

package/lib/compress/drop-unused.js

@@ -77,10 +77,6 @@ import {
     TreeTransformer,
     TreeWalker,
     walk,
-
-    _INLINE,
-    _NOINLINE,
-    _PURE
 } from "../ast.js";
 import {
     keep_name,

package/lib/compress/index.js

@@ -137,9 +137,7 @@ import {
     walk,
     walk_abort,
 
-    _INLINE,
     _NOINLINE,
-    _PURE
 } from "../ast.js";
 import {
     defaults,

package/lib/compress/inference.js

@@ -377,16 +377,27 @@ export function is_nullish(node, compressor) {
         return any(this.elements, compressor);
     });
     def_has_side_effects(AST_Dot, function(compressor) {
-        if (is_nullish(this, compressor)) return false;
-        return !this.optional && this.expression.may_throw_on_access(compressor)
-            || this.expression.has_side_effects(compressor);
+        if (is_nullish(this, compressor)) {
+            return this.expression.has_side_effects(compressor);
+        }
+        if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+            return true;
+        }
+
+        return this.expression.has_side_effects(compressor);
     });
     def_has_side_effects(AST_Sub, function(compressor) {
-        if (is_nullish(this, compressor)) return false;
+        if (is_nullish(this, compressor)) {
+            return this.expression.has_side_effects(compressor);
+        }
+        if (!this.optional && this.expression.may_throw_on_access(compressor)) {
+            return true;
+        }
 
-        return !this.optional && this.expression.may_throw_on_access(compressor)
-            || this.expression.has_side_effects(compressor)
-            || this.property.has_side_effects(compressor);
+        var property = this.property.has_side_effects(compressor);
+        if (property && this.optional) return true; // "?." is a condition
+
+        return property || this.expression.has_side_effects(compressor);
     });
     def_has_side_effects(AST_Chain, function (compressor) {
         return this.expression.has_side_effects(compressor);

package/lib/compress/inline.js

@@ -174,6 +174,10 @@ export function inline_into_symbolref(self, compressor) {
             && !fixed.may_throw(compressor);
     }
 
+    if (fixed instanceof AST_Class && def.scope !== self.scope) {
+        return self;
+    }
+
     if (single_use && (fixed instanceof AST_Lambda || fixed instanceof AST_Class)) {
         if (retain_top_func(fixed, compressor)) {
             single_use = false;

package/lib/compress/reduce-vars.js

@@ -96,10 +96,6 @@ import {
     walk_body,
 
     TreeWalker,
-
-    _INLINE,
-    _NOINLINE,
-    _PURE
 } from "../ast.js";
 import { HOP, make_node, noop } from "../utils/index.js";
 

package/lib/compress/tighten-body.js

@@ -981,7 +981,11 @@ export function tighten_body(statements, compressor) {
         var self = compressor.self();
         var multiple_if_returns = has_multiple_if_returns(statements);
         var in_lambda = self instanceof AST_Lambda;
-        for (var i = statements.length; --i >= 0;) {
+        // Prevent extremely deep nesting
+        // https://github.com/terser/terser/issues/1432
+        // https://github.com/webpack/webpack/issues/17548
+        const iteration_start = Math.min(statements.length, 500);
+        for (var i = iteration_start; --i >= 0;) {
             var stat = statements[i];
             var j = next_index(i);
             var next = statements[j];

package/package.json

@@ -4,7 +4,7 @@
   "homepage": "https://terser.org",
   "author": "Mihai Bazon <mihai.bazon@gmail.com> (http://lisperator.net/)",
   "license": "BSD-2-Clause",
-  "version": "5.19.2",
+  "version": "5.19.4",
   "engines": {
     "node": ">=10"
   },

package/tools/domprops.js

@@ -6570,6 +6570,7 @@ export var domprops = [
     "rotationAngle",
     "rotationRate",
     "round",
+    "roundRect",
     "row-gap",
     "rowGap",
     "rowIndex",