terser 5.17.0 → 5.17.1

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## v5.17.1
+ - Fix evaluating `.length` when the source array might've been mutated
+
 ## v5.17.0
  - Drop vestigial `= undefined` default argument in IIFE calls (#1366)
  - Evaluate known arrays' `.length` property when statically determinable

package/dist/bundle.min.js

@@ -4515,11 +4515,14 @@ var AST_Destructuring = DEFNODE("Destructuring", "names is_array", function AST_
     },
     all_symbols: function() {
         var out = [];
-        this.walk(new TreeWalker(function (node) {
-            if (node instanceof AST_Symbol) {
+        walk(this, node => {
+            if (node instanceof AST_SymbolDeclaration) {
                 out.push(node);
             }
-        }));
+            if (node instanceof AST_Lambda) {
+                return true;
+            }
+        });
         return out;
     }
 });
@@ -5050,6 +5053,13 @@ var AST_VarDef = DEFNODE("VarDef", "name value", function AST_VarDef(props) {
         if (this.value) push(this.value);
         push(this.name);
     },
+    declarations_as_names() {
+        if (this.name instanceof AST_SymbolDeclaration) {
+            return [this];
+        } else {
+            return this.name.all_symbols();
+        }
+    }
 });
 
 var AST_NameMapping = DEFNODE("NameMapping", "foreign_name name", function AST_NameMapping(props) {
@@ -14496,24 +14506,16 @@ def_eval(AST_PropAccess, function (compressor, depth) {
             return obj.length;
         }
 
-        const is_spreadless_array = obj =>
+        const is_spreadless_array =
             obj instanceof AST_Array
             && obj.elements.every(el => !(el instanceof AST_Expansion));
 
         if (
-            is_spreadless_array(obj)
+            is_spreadless_array
             && obj.elements.every(el => !el.has_side_effects(compressor))
         ) {
             return obj.elements.length;
         }
-
-        let fixed;
-        if (
-            obj instanceof AST_SymbolRef
-            && is_spreadless_array((fixed = obj.definition().fixed_value()))
-        ) {
-            return fixed.elements.length;
-        }
     }
 
     if (compressor.option("unsafe")) {
@@ -16138,12 +16140,31 @@ function is_lhs_read_only(lhs) {
     return false;
 }
 
-// Remove code which we know is unreachable.
+/** var a = 1 --> var a*/
+function remove_initializers(var_statement) {
+    var decls = [];
+    var_statement.definitions.forEach(function(def) {
+        if (def.name instanceof AST_SymbolDeclaration) {
+            def.value = null;
+            decls.push(def);
+        } else {
+            def.declarations_as_names().forEach(name => {
+                decls.push(make_node(AST_VarDef, def, {
+                    name,
+                    value: null
+                }));
+            });
+        }
+    });
+    return decls.length ? make_node(AST_Var, var_statement, { definitions: decls }) : null;
+}
+
+/** Called on code which we know is unreachable, to keep elements that affect outside of it. */
 function trim_unreachable_code(compressor, stat, target) {
     walk(stat, node => {
         if (node instanceof AST_Var) {
-            node.remove_initializers();
-            target.push(node);
+            const no_initializers = remove_initializers(node);
+            if (no_initializers) target.push(no_initializers);
             return true;
         }
         if (
@@ -19373,26 +19394,6 @@ def_optimize(AST_Try, function(self, compressor) {
     return self;
 });
 
-AST_Definitions.DEFMETHOD("remove_initializers", function() {
-    var decls = [];
-    this.definitions.forEach(function(def) {
-        if (def.name instanceof AST_SymbolDeclaration) {
-            def.value = null;
-            decls.push(def);
-        } else {
-            walk(def.name, node => {
-                if (node instanceof AST_SymbolDeclaration) {
-                    decls.push(make_node(AST_VarDef, def, {
-                        name: node,
-                        value: null
-                    }));
-                }
-            });
-        }
-    });
-    this.definitions = decls;
-});
-
 AST_Definitions.DEFMETHOD("to_assignments", function(compressor) {
     var reduce_vars = compressor.option("reduce_vars");
     var assignments = [];

package/lib/ast.js

@@ -905,11 +905,14 @@ var AST_Destructuring = DEFNODE("Destructuring", "names is_array", function AST_
     },
     all_symbols: function() {
         var out = [];
-        this.walk(new TreeWalker(function (node) {
-            if (node instanceof AST_Symbol) {
+        walk(this, node => {
+            if (node instanceof AST_SymbolDeclaration) {
                 out.push(node);
             }
-        }));
+            if (node instanceof AST_Lambda) {
+                return true;
+            }
+        });
         return out;
     }
 });
@@ -1440,6 +1443,13 @@ var AST_VarDef = DEFNODE("VarDef", "name value", function AST_VarDef(props) {
         if (this.value) push(this.value);
         push(this.name);
     },
+    declarations_as_names() {
+        if (this.name instanceof AST_SymbolDeclaration) {
+            return [this];
+        } else {
+            return this.name.all_symbols();
+        }
+    }
 });
 
 var AST_NameMapping = DEFNODE("NameMapping", "foreign_name name", function AST_NameMapping(props) {

package/lib/compress/evaluate.js

@@ -359,24 +359,16 @@ def_eval(AST_PropAccess, function (compressor, depth) {
             return obj.length;
         }
 
-        const is_spreadless_array = obj =>
+        const is_spreadless_array =
             obj instanceof AST_Array
             && obj.elements.every(el => !(el instanceof AST_Expansion));
 
         if (
-            is_spreadless_array(obj)
+            is_spreadless_array
             && obj.elements.every(el => !el.has_side_effects(compressor))
         ) {
             return obj.elements.length;
         }
-
-        let fixed;
-        if (
-            obj instanceof AST_SymbolRef
-            && is_spreadless_array((fixed = obj.definition().fixed_value()))
-        ) {
-            return fixed.elements.length;
-        }
     }
 
     if (compressor.option("unsafe")) {

package/lib/compress/index.js

@@ -1545,26 +1545,6 @@ def_optimize(AST_Try, function(self, compressor) {
     return self;
 });
 
-AST_Definitions.DEFMETHOD("remove_initializers", function() {
-    var decls = [];
-    this.definitions.forEach(function(def) {
-        if (def.name instanceof AST_SymbolDeclaration) {
-            def.value = null;
-            decls.push(def);
-        } else {
-            walk(def.name, node => {
-                if (node instanceof AST_SymbolDeclaration) {
-                    decls.push(make_node(AST_VarDef, def, {
-                        name: node,
-                        value: null
-                    }));
-                }
-            });
-        }
-    });
-    this.definitions = decls;
-});
-
 AST_Definitions.DEFMETHOD("to_assignments", function(compressor) {
     var reduce_vars = compressor.option("reduce_vars");
     var assignments = [];

package/lib/compress/tighten-body.js

@@ -170,12 +170,31 @@ function is_lhs_read_only(lhs) {
     return false;
 }
 
-// Remove code which we know is unreachable.
+/** var a = 1 --> var a*/
+function remove_initializers(var_statement) {
+    var decls = [];
+    var_statement.definitions.forEach(function(def) {
+        if (def.name instanceof AST_SymbolDeclaration) {
+            def.value = null;
+            decls.push(def);
+        } else {
+            def.declarations_as_names().forEach(name => {
+                decls.push(make_node(AST_VarDef, def, {
+                    name,
+                    value: null
+                }));
+            });
+        }
+    });
+    return decls.length ? make_node(AST_Var, var_statement, { definitions: decls }) : null;
+}
+
+/** Called on code which we know is unreachable, to keep elements that affect outside of it. */
 export function trim_unreachable_code(compressor, stat, target) {
     walk(stat, node => {
         if (node instanceof AST_Var) {
-            node.remove_initializers();
-            target.push(node);
+            const no_initializers = remove_initializers(node);
+            if (no_initializers) target.push(no_initializers);
             return true;
         }
         if (

package/package.json

@@ -4,7 +4,7 @@
   "homepage": "https://terser.org",
   "author": "Mihai Bazon <mihai.bazon@gmail.com> (http://lisperator.net/)",
   "license": "BSD-2-Clause",
-  "version": "5.17.0",
+  "version": "5.17.1",
   "engines": {
     "node": ">=10"
   },