termify-agent 1.0.50 → 1.0.51

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "termify-agent",
-  "version": "1.0.50",
+  "version": "1.0.51",
   "description": "Termify Agent CLI - Connect your local terminal to Termify",
   "type": "module",
   "main": "dist/index.js",

package/scripts/postinstall.js

@@ -15,7 +15,7 @@
  */
 
 import { execSync } from 'child_process';
-import { createWriteStream, mkdirSync, chmodSync, existsSync, unlinkSync, copyFileSync, rmSync, readFileSync, readlinkSync, writeFileSync, symlinkSync, lstatSync } from 'fs';
+import { createWriteStream, mkdirSync, chmodSync, existsSync, unlinkSync, copyFileSync, rmSync, readFileSync, readlinkSync, writeFileSync, symlinkSync, lstatSync, readdirSync } from 'fs';
 import { isAbsolute, join, dirname, resolve } from 'path';
 import { homedir, platform, arch } from 'os';
 import { get } from 'https';
@@ -75,6 +75,36 @@ function resolveNodePtyDir() {
   }
 }
 
+/**
+ * Clean up node-pty build artifacts that npm can't remove from staging dirs.
+ * node-gyp creates .target.mk, Makefile, config.gypi etc. that may be owned
+ * by root (when postinstall runs with elevated privileges), causing EACCES
+ * errors during npm's post-install cleanup. We remove these build artifacts
+ * since node-pty only needs build/Release/pty.node at runtime.
+ */
+function cleanNodePtyBuildArtifacts(dir) {
+  if (!dir || !existsSync(dir)) return;
+  try {
+    // Remove node-addon-api build artifacts (*.target.mk, *.Makefile)
+    const nodeAddonApiDir = join(dir, 'node-addon-api');
+    if (existsSync(nodeAddonApiDir)) {
+      rmSync(nodeAddonApiDir, { recursive: true, force: true });
+    }
+    // Remove build directory artifacts except Release/*.node binaries
+    const buildDir = join(dir, 'build');
+    if (existsSync(buildDir)) {
+      const keepPatterns = ['Release'];
+      for (const entry of readdirSync(buildDir)) {
+        if (!keepPatterns.includes(entry)) {
+          rmSync(join(buildDir, entry), { recursive: true, force: true });
+        }
+      }
+    }
+  } catch {
+    // Best effort — if this fails, npm will just show cleanup warnings
+  }
+}
+
 /**
  * Step 1: Rebuild node-pty with improved error handling
  * For Node.js v24+, prebuilds may not be compatible, so we compile from source
@@ -90,6 +120,7 @@ function rebuildNodePty() {
   // Fast path: already works (cached or live test)
   if (testNodePty()) {
     console.log('[termify-agent] node-pty is working.');
+    cleanNodePtyBuildArtifacts(nodePtyDir);
     return true;
   }
 
@@ -111,6 +142,7 @@ function rebuildNodePty() {
 
     if (testNodePty()) {
       console.log('[termify-agent] node-pty rebuilt successfully.');
+      cleanNodePtyBuildArtifacts(nodePtyDir);
       return true;
     }
   } catch (err) {
@@ -132,6 +164,7 @@ function rebuildNodePty() {
 
     if (testNodePty()) {
       console.log('[termify-agent] node-pty rebuilt successfully from module directory.');
+      cleanNodePtyBuildArtifacts(nodePtyDir);
       return true;
     }
   } catch (err) {
@@ -151,6 +184,7 @@ function rebuildNodePty() {
 
     if (testNodePty()) {
       console.log('[termify-agent] node-pty compiled from source successfully.');
+      cleanNodePtyBuildArtifacts(nodePtyDir);
       return true;
     }
   } catch (err) {
@@ -184,12 +218,16 @@ function rebuildNodePty() {
 
     if (testNodePty()) {
       console.log('[termify-agent] node-pty reinstalled and compiled successfully.');
+      cleanNodePtyBuildArtifacts(reinstalledNodePtyDir);
       return true;
     }
   } catch (err2) {
     // Continue to error message
   }
 
+  // Fix permissions even on failure so npm can clean up staging directory
+  cleanNodePtyBuildArtifacts(nodePtyDir);
+
   console.error('[termify-agent] CRITICAL: node-pty installation failed.');
   console.error('[termify-agent] Terminal features will NOT work.');
   console.error('[termify-agent] ');