teleportxr 1.0.90 → 1.0.92

package/client/client.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const fs= require("fs");
+const path= require("path");
 const core= require("../core/core.js");
 const command= require("../protocol/command.js");
 const message= require("../protocol/message.js");
@@ -54,6 +56,9 @@ class Client {
         this.clientID=cid;
         this.origin_uid=0;
         this.handshakeMessage=new message.HandshakeMessage();
+		// The client's axes standard, learned from its Handshake. Used to pick the matching
+		// cubemap variant to stream (e.g. GlStyle -> *_ogl.ktx2). NotInitialized until handshake.
+		this.clientAxesStandard=core.AxesStandard.NotInitialized;
 		this.geometryService=new gs.GeometryService(cid);
 		// Per-client avatar negotiation state. The host application drives
 		// when (and whether) policy is sent via this service.
@@ -564,6 +569,34 @@ class Client {
 		if(sendSuccess)
 			this.geometryService.EncodedResource(uid);
 	}
+	//! For a cubemap resource, return the URL of the variant matching this client's axes
+	//! standard (e.g. /envCloudyCubemap.ktx2 -> /envCloudyCubemap_ogl.ktx2). Returns undefined
+	//! to mean "use the resource's base url" — for non-cubemaps, unknown axes standards, or
+	//! when the variant file is missing under the public path (so streaming never breaks).
+	CubemapUrlForClient(resource)
+	{
+		if(!resource || !resource.isCubemap)
+			return undefined;
+		const suffix=core.AxesStandardToCubemapSuffix(this.clientAxesStandard);
+		if(!suffix)
+			return undefined;
+		const candidate=resources.InsertCubemapAxesSuffix(resource.url, suffix);
+		if(candidate===resource.url)
+			return undefined;
+		// Only serve the variant if it actually exists; otherwise fall back to the base file.
+		if(this.scene&&this.scene.publicPath)
+		{
+			// URLs are server-relative (e.g. "/envCloudyCubemap.ktx2"); strip any scheme/host.
+			const rel=candidate.replace(/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\/[^/]*/, "");
+			const full=path.join(this.scene.publicPath, rel);
+			if(!fs.existsSync(full))
+			{
+				console.warn("Cubemap variant "+full+" not found; serving base "+resource.url+" to client "+this.clientID);
+				return undefined;
+			}
+		}
+		return candidate;
+	}
 	SendGenericResource(uid)
 	{
 		var resource=resources.GetResourceFromUid(uid);
@@ -572,9 +605,10 @@ class Client {
 			console.warn("No resource of uid ",uid," was found.")
 			return;
 		}
+		const urlOverride=this.CubemapUrlForClient(resource);
 		const MAX_BUFFER_SIZE=resource.encodedSize();;
 		const buffer = new ArrayBuffer(MAX_BUFFER_SIZE);
-		const resourceSize=resource_encoder.EncodeResource(resource,buffer);
+		const resourceSize=resource_encoder.EncodeResource(resource,buffer,urlOverride);
 		const view2 = new DataView(buffer, 0, resourceSize);
 		if(!this.webRtcConnection)
 		{
@@ -588,7 +622,7 @@ class Client {
 			return;
 		}
 		const sendSuccess = this.webRtcConnection.sendGeometry(view2);
-		console.log("[T+"+this.elapsedMsSinceStart()+"ms, conn+"+this.elapsedMsSinceConnected()+"ms] Sending resource "+uid+" "+resource.url+" to Client "+this.clientID+", size: "+resourceSize+" bytes — "+
+		console.log("[T+"+this.elapsedMsSinceStart()+"ms, conn+"+this.elapsedMsSinceConnected()+"ms] Sending resource "+uid+" "+(urlOverride||resource.url)+" to Client "+this.clientID+", size: "+resourceSize+" bytes — "+
 			(sendSuccess ? "OK" : "FAILED"));
 		if(sendSuccess)
 			this.geometryService.EncodedResource(uid);
@@ -619,6 +653,10 @@ class Client {
         }
         var handshakeMessage=new message.HandshakeMessage();
 		core.decodeFromUint8Array(handshakeMessage,data);
+		// Remember the client's axes standard so cubemaps are streamed in the matching variant.
+		this.clientAxesStandard=handshakeMessage.AxesStandard_axesStandard;
+		console.log("Client "+this.clientID+" handshake axesStandard="+this.clientAxesStandard
+			+" (cubemap suffix '"+core.AxesStandardToCubemapSuffix(this.clientAxesStandard)+"')");
         const excess		=data.length-message.HandshakeMessage.sizeof();
         const numReceived	=excess/core.UID_SIZE;
         if(numReceived!=handshakeMessage.uint64_resourceCount) {

package/core/core.js

@@ -175,12 +175,31 @@ const AxesStandard =
 	LeftHanded: 2,
 	YVertical: 4,
 	ZVertical: 8,
-	EngineeringStyle: this.ZVertical | this.RightHanded,
-	GlStyle: 16 | this.YVertical | this.RightHanded,
-	UnrealStyle: 32 | this.ZVertical | this.LeftHanded,
-	UnityStyle: 64 | this.YVertical | this.LeftHanded,
+	// NB: these must be explicit literals, not `this.ZVertical | ...`. Inside an object
+	// literal `this` is the module scope, not the object, so the bitwise expressions would
+	// silently evaluate to the wrong values (e.g. EngineeringStyle=0, GlStyle=16). The wire
+	// protocol and clients use 9 and 21, so hard-code the resolved values to match.
+	EngineeringStyle: 8 | 1,	// ZVertical | RightHanded = 9
+	GlStyle: 16 | 4 | 1,		// 16 | YVertical | RightHanded = 21
+	UnrealStyle: 32 | 8 | 2,	// 32 | ZVertical | LeftHanded = 42
+	UnityStyle: 64 | 4 | 2,		// 64 | YVertical | LeftHanded = 70
 };
 
+//! Map a client's axes standard to the filename suffix used for the matching cubemap
+//! variant. e.g. GlStyle -> "ogl", so /envCloudyCubemap.ktx2 -> /envCloudyCubemap_ogl.ktx2.
+//! Returns "" for an unknown/uninitialised standard, meaning "serve the original file".
+function AxesStandardToCubemapSuffix(axesStandard)
+{
+	switch (axesStandard)
+	{
+		case AxesStandard.GlStyle:			return "ogl";
+		case AxesStandard.EngineeringStyle:	return "eng";
+		case AxesStandard.UnrealStyle:		return "unreal";
+		case AxesStandard.UnityStyle:		return "unity";
+		default:							return "";
+	}
+}
+
 const GeometryPayloadType =
 {
 	Invalid: 0,
@@ -441,7 +460,7 @@ function put_string(dataView, byteOffset, name) {
 
 module.exports = {
 	UID_SIZE, endian, SizeOfType, encodeIntoDataView, decodeFromDataView
-	, vec4, BackgroundMode, AxesStandard, GeometryPayloadType, DisplayInfo, RenderingFeatures, LightingMode, VideoCodec
+	, vec4, BackgroundMode, AxesStandard, AxesStandardToCubemapSuffix, GeometryPayloadType, DisplayInfo, RenderingFeatures, LightingMode, VideoCodec
 	, VideoConfig, ClientDynamicLighting, encodeToUint8Array, decodeFromUint8Array
 	, generateUid, getStartTimeUnixUs, getTimestampUs,
 	unixTimeToUTCString, put_float32, put_uint16, put_int32, put_uint32

package/package.json

@@ -16,7 +16,7 @@
   },
   "name": "teleportxr",
   "description": "Teleport Spatial Server on node.js",
-  "version": "1.0.90",
+  "version": "1.0.92",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/simul/teleport-nodejs.git"

package/protocol/encoders/resource_encoder.js

@@ -13,12 +13,14 @@ function putPlaceholderSize(dataView)
 }
 
 // return the size of the encoded resource.
-function EncodeResource(res,buffer)
+// urlOverride, if supplied, is passed to the resource so it can encode a client-specific
+// url (e.g. an axes-standard cubemap variant) without mutating the shared resource.
+function EncodeResource(res,buffer,urlOverride)
 {
 	var byteOffset=0;
-	const dataView = new DataView(buffer); 
+	const dataView = new DataView(buffer);
 	byteOffset=putPlaceholderSize(dataView);
-	var t=res.encodeIntoDataView(dataView,byteOffset);
+	var t=res.encodeIntoDataView(dataView,byteOffset,urlOverride);
 	byteOffset=t;
 	t-=8;
 	// Actual size is now known: write the count of bytes that follow the

package/scene/resources.js

@@ -16,16 +16,21 @@ class Resource {
 		this.uid = uid;
 		this.url = url;
 		this.type = type;
+		// True for environment cubemaps (background/diffuse/specular). Such resources are
+		// served per-client in the variant matching the client's axes standard.
+		this.isCubemap = false;
 	}
 	encodedSize(){
 		return 500;
 	}
-	encodeIntoDataView(dataView, byteOffset) {
+	//! urlOverride, if supplied, replaces this.url for this encoding only (e.g. to send a
+	//! client-specific cubemap variant). The stored this.url is left untouched.
+	encodeIntoDataView(dataView, byteOffset, urlOverride) {
 		byteOffset = core.put_uint8(dataView, byteOffset, this.type);
 		byteOffset = core.put_uint64(dataView, byteOffset, this.uid);
-		var url = this.url;
-		if (this.url.search("://") == -1)
-			url = Resource.defaultPathRoot + this.url;
+		var url = urlOverride || this.url;
+		if (url.search("://") == -1)
+			url = Resource.defaultPathRoot + url;
 		byteOffset = core.put_string(dataView, byteOffset, url);
 		return byteOffset;
 	}
@@ -211,6 +216,28 @@ function GetOrAddTexture(url) {
 	return GetOrAddResourceFromUrl(core.GeometryPayloadType.TexturePointer, url);
 }
 
+//! Get or add a cubemap texture, flagging the resource so it is served per-client in the
+//! variant matching the client's axes standard. Returns the resource uid.
+function GetOrAddCubemap(url) {
+	const uid = GetOrAddTexture(url);
+	const res = GetResourceFromUid(uid);
+	if (res)
+		res.isCubemap = true;
+	return uid;
+}
+
+//! Insert an axes suffix before a cubemap URL's extension:
+//!   InsertCubemapAxesSuffix("/envCloudyCubemap.ktx2", "ogl") -> "/envCloudyCubemap_ogl.ktx2"
+//! Returns the url unchanged when the suffix is empty.
+function InsertCubemapAxesSuffix(url, suffix) {
+	if (!suffix || !url)
+		return url;
+	const dot = url.lastIndexOf(".");
+	if (dot < 0)
+		return url + "_" + suffix;
+	return url.substring(0, dot) + "_" + suffix + url.substring(dot);
+}
+
 //! Get or add the mesh url as a resource.
 function GetOrAddMesh(url) {
 	return GetOrAddResourceFromUrl(core.GeometryPayloadType.MeshPointer, url);
@@ -238,6 +265,8 @@ module.exports = {
 	GetOrAddResourceUidFromUrl,
 	GetResourceFromUid,
 	GetOrAddTexture,
+	GetOrAddCubemap,
+	InsertCubemapAxesSuffix,
 	GetOrAddMesh,
 	AddFontAtlas,
 	AddTextCanvas,

package/scene/scene.js

@@ -191,17 +191,19 @@ class Scene {
 			if(j.environment.background_texture)
 			{
 				this.backgroundTexturePath=j.environment.background_texture;
-				resources.GetOrAddTexture(this.backgroundTexturePath);
+				// The environment background is a cubemap; flag it so each client is served the
+				// variant matching its axes standard (falls back to the base file if absent).
+				resources.GetOrAddCubemap(this.backgroundTexturePath);
 			}
 			if(j.environment.diffuse_cubemap)
 			{
 				this.diffuseCubemapPath=j.environment.diffuse_cubemap;
-				resources.GetOrAddTexture(this.diffuseCubemapPath);
+				resources.GetOrAddCubemap(this.diffuseCubemapPath);
 			}
 			if(j.environment.specular_cubemap)
 			{
 				this.specularCubemapPath=j.environment.specular_cubemap;
-				resources.GetOrAddTexture(this.specularCubemapPath);
+				resources.GetOrAddCubemap(this.specularCubemapPath);
 			}
 		}
 		if(j.font_atlases)