technical-debt-radar 1.6.3 → 1.6.5

package/dist/index.js

@@ -15200,6 +15200,47 @@ var require_perf_pattern_detector = __commonJS({
       }
       return void 0;
     }
+    function isServiceMethodCall(callExpr) {
+      const expr = callExpr.getExpression();
+      if (!ts_morph_1.Node.isPropertyAccessExpression(expr))
+        return false;
+      const obj = expr.getExpression();
+      if (ts_morph_1.Node.isPropertyAccessExpression(obj)) {
+        const propName = obj.getName();
+        if (/Service$/i.test(propName))
+          return true;
+      }
+      if (ts_morph_1.Node.isIdentifier(obj)) {
+        const name = obj.getText();
+        if (/Service$/i.test(name))
+          return true;
+      }
+      return false;
+    }
+    var BOUNDED_QUERY_METHODS = /* @__PURE__ */ new Set([
+      "findOne",
+      "findById",
+      "findByIdAndUpdate",
+      "findByIdAndDelete",
+      "findOneAndUpdate",
+      "findOneAndDelete",
+      "findOneAndReplace",
+      "findOneAndRemove",
+      "findByPk",
+      // Sequelize
+      "findUnique",
+      "findUniqueOrThrow",
+      "findFirst",
+      "findFirstOrThrow",
+      // Prisma
+      "first",
+      // Knex
+      "get",
+      // DynamoDB
+      "getOne",
+      "getRawOne"
+      // TypeORM QueryBuilder
+    ]);
     var FIND_MANY_METHODS = /* @__PURE__ */ new Set(["findMany", "find", "getMany", "findAndCount"]);
     function detectUnboundedFindMany(sourceFile, filePath, fns, policy, violations) {
       sourceFile.forEachDescendant((node) => {
@@ -15209,6 +15250,10 @@ var require_perf_pattern_detector = __commonJS({
         if (!ts_morph_1.Node.isPropertyAccessExpression(expr))
           return;
         const methodName = expr.getName();
+        if (BOUNDED_QUERY_METHODS.has(methodName))
+          return;
+        if (isServiceMethodCall(node))
+          return;
         if (TYPEORM_QB_TERMINAL.has(methodName) && methodName !== "getCount" && methodName !== "getOne" && methodName !== "getRawOne") {
           const chain = traceQueryBuilderChain(node);
           if (chain.hasTake)
@@ -15287,6 +15332,13 @@ var require_perf_pattern_detector = __commonJS({
           entity = extractTypeORMEntity(node);
         if (!entity)
           entity = extractSequelizeEntity(node);
+        if (methodName === "find") {
+          const typeormEntity = extractTypeORMEntity(node);
+          const seqEntity = extractSequelizeEntity(node);
+          if (!typeormEntity && !seqEntity)
+            return;
+          entity = typeormEntity ?? seqEntity;
+        }
         const vol = entity ? resolveVolume(entity, policy) : void 0;
         const fn = getEnclosingFn(node, fns);
         pushIfNotNull(violations, makeViolation(shared_1.PERFORMANCE_RULES.UNBOUNDED_FIND_MANY, filePath, node.getStartLineNumber(), `${methodName}() without take/limit${vol ? ` on '${entity}' (${vol.size} volume)` : ""} \u2014 may fetch entire table`, policy, vol, fn?.name, "Add take: N or limit to bound the result set"));
@@ -15300,6 +15352,10 @@ var require_perf_pattern_detector = __commonJS({
         if (!ts_morph_1.Node.isPropertyAccessExpression(expr))
           return;
         const methodName = expr.getName();
+        if (BOUNDED_QUERY_METHODS.has(methodName))
+          return;
+        if (isServiceMethodCall(node))
+          return;
         if (TYPEORM_QB_TERMINAL.has(methodName) && methodName !== "getCount" && methodName !== "getOne" && methodName !== "getRawOne") {
           const chain = traceQueryBuilderChain(node);
           if (chain.hasWhere)
@@ -15388,6 +15444,8 @@ var require_perf_pattern_detector = __commonJS({
           entity = extractTypeORMEntity(node);
         if (!entity)
           entity = extractSequelizeEntity(node);
+        if (methodName === "find")
+          return;
         const vol = entity ? resolveVolume(entity, policy) : void 0;
         const hasCursorPagination = argsContainKey(node, "cursor");
         const hasTakePagination = argsContainKey(node, "take") || argsContainKey(node, "limit");
@@ -15876,6 +15934,9 @@ var require_perf_pattern_detector = __commonJS({
         const bodyText = fn.node.getText();
         if (!/\.(findMany|find|getMany|findAll|from)\s*\(/.test(bodyText) && !/knex\s*\(/.test(bodyText))
           continue;
+        const findCallMatches = [...bodyText.matchAll(/(\w+)\.(findMany|find|getMany|findAll|from)\s*\(/g)];
+        if (findCallMatches.length > 0 && findCallMatches.every((m) => /Service$/i.test(m[1])))
+          continue;
         if (/page|skip|offset|cursor|take|limit|per_page|pageSize/i.test(bodyText))
           continue;
         const entityMatch = bodyText.match(/(\w+)\.(findMany|find|getMany|findAll)\s*\(/);
@@ -16618,9 +16679,11 @@ var require_reliability_detector = __commonJS({
           continue;
         let unhandledAwaitCount = 0;
         let totalAwaitCount = 0;
-        fn.node.forEachDescendant((child) => {
-          if (child !== fn.node && (ts_morph_1.Node.isFunctionDeclaration(child) || ts_morph_1.Node.isMethodDeclaration(child) || ts_morph_1.Node.isArrowFunction(child) || ts_morph_1.Node.isFunctionExpression(child)))
+        fn.node.forEachDescendant((child, traversal) => {
+          if (child !== fn.node && (ts_morph_1.Node.isFunctionDeclaration(child) || ts_morph_1.Node.isMethodDeclaration(child) || ts_morph_1.Node.isArrowFunction(child) || ts_morph_1.Node.isFunctionExpression(child))) {
+            traversal.skip();
             return;
+          }
           if (!ts_morph_1.Node.isAwaitExpression(child))
             return;
           totalAwaitCount++;
@@ -17022,7 +17085,7 @@ var require_reliability_detector = __commonJS({
       });
     }
     var ROUTE_DECORATORS = /* @__PURE__ */ new Set(["Get", "Post", "Put", "Delete", "Patch", "All", "Head", "Options"]);
-    var GUARD_TODO_PATTERN = /TODO|FIXME|HACK|guard|auth|security|protected/i;
+    var GUARD_TODO_PATTERN = /\b(TODO|FIXME|HACK|XXX)\b/i;
     function detectUnguardedRouteTodo(sourceFile, filePath, fns, policy, violations) {
       if (!filePath.includes("controller"))
         return;
@@ -18710,6 +18773,12 @@ var require_dead_code_detector = __commonJS({
         if (aliasResolved)
           return aliasResolved;
       }
+      const aliasStripped = specifier.replace(/^@\//, "src/").replace(/^~\//, "src/");
+      if (aliasStripped !== specifier) {
+        const aliasResolved = resolveInProject(aliasStripped, project);
+        if (aliasResolved)
+          return aliasResolved;
+      }
       const directResolved = resolveInProject(specifier, project);
       if (directResolved)
         return directResolved;
@@ -19184,7 +19253,7 @@ var require_orchestrator = __commonJS({
       }
       const complexityViolations = complexityDeltasToViolations(complexityDeltas, filteredInput);
       const largeFileViolations = detectLargeFiles(filteredInput);
-      const violations = [
+      const rawViolations = [
         ...boundaryViolations,
         ...circularViolations,
         ...runtimeViolations,
@@ -19198,6 +19267,7 @@ var require_orchestrator = __commonJS({
         ...coverageDeltaResult?.violations ?? [],
         ...crossFileAnalysis?.violations ?? []
       ];
+      const violations = deduplicateViolations(rawViolations);
       const suspectFunctions = selectSuspectFunctions(violations, complexityDeltas, filteredInput);
       const metrics = computeMetrics(filteredInput, importGraph, violations, complexityDeltas, suspectFunctions, startMs, duplicationResult, missingTestsResult, deadCodeResult, crossFileAnalysis, coverageDeltaResult);
       return {
@@ -19209,6 +19279,87 @@ var require_orchestrator = __commonJS({
         crossFileAnalysis
       };
     }
+    var PERF_DEDUP_RULES = /* @__PURE__ */ new Set([
+      "unbounded-find-many",
+      "find-many-no-where",
+      "missing-pagination-endpoint"
+    ]);
+    function deduplicateViolations(violations) {
+      let result = violations;
+      result = deduplicateControllerService(result);
+      result = deduplicateNestedScopes(result);
+      return result;
+    }
+    function deduplicateControllerService(violations) {
+      const perfViolations = violations.filter((v) => PERF_DEDUP_RULES.has(v.ruleId));
+      if (perfViolations.length === 0)
+        return violations;
+      const serviceViolationKeys = /* @__PURE__ */ new Set();
+      for (const v of perfViolations) {
+        if (/\.service\./i.test(v.file)) {
+          serviceViolationKeys.add(v.ruleId);
+        }
+      }
+      const serviceByRuleAndDir = /* @__PURE__ */ new Map();
+      for (const v of perfViolations) {
+        if (/\.service\./i.test(v.file)) {
+          const dir = v.file.substring(0, v.file.lastIndexOf("/") + 1);
+          const key = `${v.ruleId}::${dir}`;
+          if (!serviceByRuleAndDir.has(key))
+            serviceByRuleAndDir.set(key, /* @__PURE__ */ new Set());
+          serviceByRuleAndDir.get(key).add(v.function ?? "");
+        }
+      }
+      return violations.filter((v) => {
+        if (!PERF_DEDUP_RULES.has(v.ruleId))
+          return true;
+        if (!/\.controller\./i.test(v.file))
+          return true;
+        const dir = v.file.substring(0, v.file.lastIndexOf("/") + 1);
+        const key = `${v.ruleId}::${dir}`;
+        if (serviceByRuleAndDir.has(key))
+          return false;
+        if (serviceViolationKeys.has(v.ruleId) && /\.controller\./i.test(v.file))
+          return false;
+        return true;
+      });
+    }
+    var NESTED_SCOPE_DEDUP_RULES = /* @__PURE__ */ new Set([
+      "missing-try-catch",
+      "unhandled-promise-rejection"
+    ]);
+    function deduplicateNestedScopes(violations) {
+      const groups = /* @__PURE__ */ new Map();
+      for (const v of violations) {
+        if (!NESTED_SCOPE_DEDUP_RULES.has(v.ruleId))
+          continue;
+        const key = `${v.file}::${v.ruleId}`;
+        if (!groups.has(key))
+          groups.set(key, []);
+        groups.get(key).push(v);
+      }
+      const toRemove = /* @__PURE__ */ new Set();
+      for (const [, group] of groups) {
+        if (group.length < 2)
+          continue;
+        const byFunction = /* @__PURE__ */ new Map();
+        for (const v of group) {
+          const fn = v.function ?? "";
+          if (!byFunction.has(fn))
+            byFunction.set(fn, []);
+          byFunction.get(fn).push(v);
+        }
+        for (const [, fnGroup] of byFunction) {
+          if (fnGroup.length < 2)
+            continue;
+          fnGroup.sort((a, b) => a.line - b.line);
+          for (let i = 1; i < fnGroup.length; i++) {
+            toRemove.add(fnGroup[i]);
+          }
+        }
+      }
+      return violations.filter((v) => !toRemove.has(v));
+    }
     function detectLargeFiles(input) {
       const threshold = shared_1.DEFAULT_LARGE_FILE_THRESHOLD;
       const violations = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.6.3",
+  "version": "1.6.5",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",