technical-debt-radar 1.3.3 → 1.5.0

package/dist/index.js

@@ -89,7 +89,9 @@ var require_constants = __commonJS({
       TRANSACTION_NO_TIMEOUT: "transaction-no-timeout",
       MISSING_NULL_GUARD: "missing-null-guard",
       MISSING_DTO_VALIDATION: "missing-dto-validation",
-      UNGUARDED_ROUTE_TODO: "unguarded-route-todo"
+      UNGUARDED_ROUTE_TODO: "unguarded-route-todo",
+      ERROR_LOGGED_AS_INFO: "error-logged-as-info",
+      CATCH_SWALLOWS_CONTEXT: "catch-block-swallows-error-context"
     };
     exports2.PERFORMANCE_RULES = {
       UNBOUNDED_FIND_MANY: "unbounded-find-many",
@@ -109,6 +111,7 @@ var require_constants = __commonJS({
       CODE_DUPLICATION: "code-duplication",
       MISSING_TEST_FILE: "missing-test-file",
       UNUSED_EXPORT: "unused-export",
+      DEBUG_CONSOLE_LOG: "debug-console-log-in-production",
       LOW_TEST_COVERAGE: "low-test-coverage",
       LOW_BRANCH_COVERAGE: "low-branch-coverage",
       COVERAGE_DROP: "coverage-drop"
@@ -117,7 +120,9 @@ var require_constants = __commonJS({
       LAYER_VIOLATION: "layer-boundary-violation",
       CIRCULAR_DEPENDENCY: "circular-dependency",
       MODULE_BOUNDARY: "module-boundary-violation",
-      FORBIDDEN_FRAMEWORK: "forbidden-framework-in-layer"
+      FORBIDDEN_FRAMEWORK: "forbidden-framework-in-layer",
+      PROVIDER_OUTSIDE_HOME: "provider-declared-outside-home-module",
+      SCHEMA_MULTI_MODULE: "schema-registered-in-multiple-modules"
     };
     exports2.CROSS_FILE_RULES = {
       INDIRECT_SYNC_FS: "indirect-sync-fs",
@@ -12762,12 +12767,15 @@ var require_import_graph = __commonJS({
       return specifiers;
     }
     function resolveModuleSpecifier(sourcePath, specifier, project) {
-      if (!specifier.startsWith(".") && !specifier.startsWith("/")) {
-        return void 0;
+      if (specifier.startsWith(".") || specifier.startsWith("/")) {
+        const sourceDir = posixDirname(sourcePath);
+        const resolved = posixJoinAndNormalize(sourceDir, specifier);
+        return resolveInProject(resolved, project) ?? resolved;
       }
-      const sourceDir = posixDirname(sourcePath);
-      const resolved = posixJoinAndNormalize(sourceDir, specifier);
-      return resolveInProject(resolved, project) ?? resolved;
+      const directResolved = resolveInProject(specifier, project);
+      if (directResolved)
+        return directResolved;
+      return void 0;
     }
     function resolveInProject(resolved, project) {
       const lookup = "/" + resolved;
@@ -12786,6 +12794,16 @@ var require_import_graph = __commonJS({
           return indexPath;
         }
       }
+      const suffix = "/" + resolved;
+      for (const sf of project.getSourceFiles()) {
+        const fp = sf.getFilePath();
+        if (fp.endsWith(suffix))
+          return normalizeFilePath(fp);
+        for (const ext of extensions) {
+          if (fp.endsWith(suffix + ext))
+            return normalizeFilePath(fp);
+        }
+      }
       return void 0;
     }
     function buildEdge(source, target, importType, policy) {
@@ -12876,12 +12894,22 @@ var require_boundary_checker = __commonJS({
       return /nestjs/i.test(policy.stack.framework);
     }
     var suffixPattern = (suffix) => new RegExp(`\\.${suffix}(\\.(ts|tsx|js|jsx))?$`);
-    var NESTJS_SHARED_INFRA_FOLDERS = ["guards", "decorators", "interceptors", "pipes", "filters", "middleware", "shared"];
+    var NESTJS_SHARED_INFRA_FOLDERS = ["guards", "decorators", "interceptors", "pipes", "filters", "middleware", "shared", "strategies", "common", "config"];
     function isNestJSExemptImport(sourcePath, targetPath, customSharedFolders = []) {
       const srcBase = sourcePath.replace(/\\/g, "/");
       const tgtBase = targetPath.replace(/\\/g, "/");
       if (suffixPattern("module").test(srcBase))
         return true;
+      if (suffixPattern("strategy").test(srcBase))
+        return true;
+      if (suffixPattern("guard").test(srcBase))
+        return true;
+      if (suffixPattern("interceptor").test(srcBase))
+        return true;
+      if (suffixPattern("pipe").test(srcBase))
+        return true;
+      if (suffixPattern("filter").test(srcBase))
+        return true;
       if (suffixPattern("module").test(tgtBase))
         return true;
       if (suffixPattern("entity").test(tgtBase))
@@ -12898,6 +12926,8 @@ var require_boundary_checker = __commonJS({
         return true;
       if (suffixPattern("filter").test(tgtBase))
         return true;
+      if (suffixPattern("strategy").test(tgtBase))
+        return true;
       if (/\/dto\//.test(tgtBase) || suffixPattern("dto").test(tgtBase))
         return true;
       for (const folder of NESTJS_SHARED_INFRA_FOLDERS) {
@@ -16173,6 +16203,8 @@ var require_reliability_detector = __commonJS({
         detectMissingNullGuard(sourceFile, file.path, fns, policy, violations);
         detectMissingDtoValidation(sourceFile, file.path, fns, policy, violations);
         detectUnguardedRouteTodo(sourceFile, file.path, fns, policy, violations);
+        detectCatchSwallowsContext(sourceFile, file.path, fns, policy, violations);
+        detectDebugConsoleLog(sourceFile, file.path, fns, policy, violations);
         project.removeSourceFile(sourceFile);
       }
       return applyExceptions(violations, policy);
@@ -16238,18 +16270,12 @@ var require_reliability_detector = __commonJS({
       }
       return false;
     }
-    function isNestJSInjectable(classNode) {
+    function isNestJSController(classNode) {
       return classNode.getDecorators().some((d) => {
         const name = d.getName();
-        return name === "Injectable";
+        return name === "Controller" || name === "Resolver";
       });
     }
-    function isInsideNestJSInjectable(node) {
-      const classDecl = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.ClassDeclaration);
-      if (!classDecl)
-        return false;
-      return isNestJSInjectable(classDecl);
-    }
     function fileImportsNestJS(sourceFile) {
       for (const decl of sourceFile.getImportDeclarations()) {
         const spec = decl.getModuleSpecifierValue();
@@ -16258,10 +16284,13 @@ var require_reliability_detector = __commonJS({
       }
       return false;
     }
-    function isNestJSServiceMethod(node, sourceFile) {
+    function isNestJSControllerMethod(node, sourceFile) {
       if (!fileImportsNestJS(sourceFile))
         return false;
-      if (!isInsideNestJSInjectable(node))
+      const classDecl = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.ClassDeclaration);
+      if (!classDecl)
+        return false;
+      if (!isNestJSController(classDecl))
         return false;
       const bgDecorators = /* @__PURE__ */ new Set(["Cron", "Process", "Interval", "Timeout"]);
       if (ts_morph_1.Node.isMethodDeclaration(node)) {
@@ -16269,10 +16298,8 @@ var require_reliability_detector = __commonJS({
           return false;
       }
       const fn = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.MethodDeclaration);
-      if (fn) {
-        if (fn.getDecorators().some((d) => bgDecorators.has(d.getName())))
-          return false;
-      }
+      if (fn && fn.getDecorators().some((d) => bgDecorators.has(d.getName())))
+        return false;
       return true;
     }
     function getSeverity(ruleId, policy) {
@@ -16357,7 +16384,7 @@ var require_reliability_detector = __commonJS({
           return;
         if (isBootstrapFunction(fn))
           return;
-        if (isNestJSServiceMethod(node, sourceFile))
+        if (isNestJSControllerMethod(node, sourceFile))
           return;
         if (functionHasTryCatch(fn.node))
           return;
@@ -16545,7 +16572,7 @@ var require_reliability_detector = __commonJS({
           continue;
         if (isBootstrapFunction(fn))
           continue;
-        if (isNestJSServiceMethod(fn.node, _sourceFile))
+        if (isNestJSControllerMethod(fn.node, _sourceFile))
           continue;
         let hasAwait = false;
         fn.node.forEachDescendant((child) => {
@@ -16786,6 +16813,12 @@ var require_reliability_detector = __commonJS({
         const hasContinue = /\bcontinue\b/.test(blockText);
         if (hasIncrement || hasPropertyMethodCall || hasAwaitOrDelay || hasContinue)
           return;
+        const hasConsoleLog = /\bconsole\.log\b/.test(blockText);
+        if (hasConsoleLog) {
+          const fn2 = getEnclosingFn(node, fns);
+          violations.push(makeViolation(shared_1.RELIABILITY_RULES.ERROR_LOGGED_AS_INFO, filePath, node.getStartLineNumber(), "Error logged with console.log instead of console.error \u2014 errors should route to stderr", policy, fn2?.name, "Replace console.log with console.error or use a proper logger (winston, pino)"));
+          return;
+        }
         const fn = getEnclosingFn(node, fns);
         violations.push(makeViolation(shared_1.RELIABILITY_RULES.MISSING_ERROR_LOGGING, filePath, node.getStartLineNumber(), "catch block has no error logging or reporting", policy, fn?.name, "Add logger.error(err) or re-throw the error"));
       });
@@ -16977,6 +17010,78 @@ var require_reliability_detector = __commonJS({
         violations.push(makeViolation(shared_1.RELIABILITY_RULES.UNGUARDED_ROUTE_TODO, filePath, node.getStartLineNumber(), `Route handler '${node.getName?.() ?? "anonymous"}' has TODO/FIXME comment and no @UseGuards() \u2014 unprotected endpoint`, policy, fn?.name, "Add @UseGuards(JwtAuthGuard) or appropriate guard \u2014 this route is currently unprotected"));
       });
     }
+    var DEBUG_LOG_PATTERN = /\b(RESULT|DEBUG|TEST|TODO|FIXME|HACK|XXX)\b/i;
+    var EXCLUDE_LOG_FILES = /\.(spec|test)\.(ts|js)|seed|migration|main\.(ts|js)$/;
+    function detectDebugConsoleLog(sourceFile, filePath, fns, policy, violations) {
+      if (EXCLUDE_LOG_FILES.test(filePath))
+        return;
+      sourceFile.forEachDescendant((node) => {
+        if (!ts_morph_1.Node.isCallExpression(node))
+          return;
+        const expr = node.getExpression();
+        if (!ts_morph_1.Node.isPropertyAccessExpression(expr))
+          return;
+        const obj = expr.getExpression();
+        if (!ts_morph_1.Node.isIdentifier(obj) || obj.getText() !== "console")
+          return;
+        if (expr.getName() !== "log")
+          return;
+        const args = node.getArguments();
+        const argsText = args.map((a) => a.getText()).join(" ");
+        if (!DEBUG_LOG_PATTERN.test(argsText))
+          return;
+        const catchClause = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.CatchClause);
+        if (catchClause)
+          return;
+        const fn = getEnclosingFn(node, fns);
+        violations.push({
+          category: "maintainability",
+          type: shared_1.MAINTAINABILITY_RULES.DEBUG_CONSOLE_LOG,
+          ruleId: shared_1.MAINTAINABILITY_RULES.DEBUG_CONSOLE_LOG,
+          severity: "warning",
+          source: "deterministic",
+          confidence: "high",
+          file: filePath,
+          line: node.getStartLineNumber(),
+          function: fn?.name,
+          message: `Debug console.log() in production code: ${argsText.substring(0, 60)}`,
+          suggestion: "Remove debug logging or replace with a proper logger (winston, pino)",
+          debtPoints: 1,
+          gateAction: "warn"
+        });
+      });
+    }
+    function detectCatchSwallowsContext(sourceFile, filePath, fns, policy, violations) {
+      sourceFile.forEachDescendant((node) => {
+        if (!ts_morph_1.Node.isCatchClause(node))
+          return;
+        const block = node.getBlock();
+        const errParam = node.getVariableDeclaration()?.getName();
+        if (!errParam)
+          return;
+        let throwsNew = false;
+        let referencesOriginal = false;
+        block.forEachDescendant((child) => {
+          if (ts_morph_1.Node.isThrowStatement(child)) {
+            throwsNew = true;
+            const thrownText = child.getExpression()?.getText() ?? "";
+            if (thrownText.includes(errParam)) {
+              referencesOriginal = true;
+            }
+          }
+        });
+        if (!throwsNew)
+          return;
+        if (referencesOriginal)
+          return;
+        const blockText = block.getText();
+        if (/\b(logger|console\.(?:error|warn))\b/i.test(blockText) && new RegExp(`\\b${escapeRegex(errParam)}\\b`).test(blockText)) {
+          return;
+        }
+        const fn = getEnclosingFn(node, fns);
+        violations.push(makeViolation(shared_1.RELIABILITY_RULES.CATCH_SWALLOWS_CONTEXT, filePath, node.getStartLineNumber(), `Catch block throws new error without including original '${errParam}' \u2014 error context lost`, policy, fn?.name, `Include the original error: throw new Error('message', { cause: ${errParam} }) or throw new HttpException(message, status, { cause: ${errParam} })`));
+      });
+    }
     function escapeRegex(str) {
       return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.3.3",
+  "version": "1.5.0",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",