technical-debt-radar 1.3.2 → 1.4.0

package/dist/index.js

@@ -89,7 +89,8 @@ var require_constants = __commonJS({
       TRANSACTION_NO_TIMEOUT: "transaction-no-timeout",
       MISSING_NULL_GUARD: "missing-null-guard",
       MISSING_DTO_VALIDATION: "missing-dto-validation",
-      UNGUARDED_ROUTE_TODO: "unguarded-route-todo"
+      UNGUARDED_ROUTE_TODO: "unguarded-route-todo",
+      ERROR_LOGGED_AS_INFO: "error-logged-as-info"
     };
     exports2.PERFORMANCE_RULES = {
       UNBOUNDED_FIND_MANY: "unbounded-find-many",
@@ -14517,7 +14518,7 @@ var require_perf_pattern_detector = __commonJS({
       return closest;
     }
     var VOLUME_SEVERITY = {
-      S: "info",
+      S: "warning",
       M: "warning",
       L: "critical",
       XL: "critical",
@@ -14573,16 +14574,17 @@ var require_perf_pattern_detector = __commonJS({
         candidates.add(origLower + "s");
         candidates.add(origSnaked + "s");
       }
-      for (const candidate of candidates) {
+      for (const candidate of [...candidates]) {
         const match = policy.volumes.find((v) => v.entity.toLowerCase() === candidate);
         if (match)
           return match;
       }
-      return void 0;
+      const defaultVol = policy.volumes.find((v) => v.entity.toLowerCase() === "default");
+      return defaultVol ?? void 0;
     }
     function severityForVolume(vol) {
       if (!vol)
-        return "info";
+        return "warning";
       return VOLUME_SEVERITY[vol.size];
     }
     function gateForVolume(vol) {
@@ -16237,18 +16239,12 @@ var require_reliability_detector = __commonJS({
       }
       return false;
     }
-    function isNestJSInjectable(classNode) {
+    function isNestJSController(classNode) {
       return classNode.getDecorators().some((d) => {
         const name = d.getName();
-        return name === "Injectable";
+        return name === "Controller" || name === "Resolver";
       });
     }
-    function isInsideNestJSInjectable(node) {
-      const classDecl = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.ClassDeclaration);
-      if (!classDecl)
-        return false;
-      return isNestJSInjectable(classDecl);
-    }
     function fileImportsNestJS(sourceFile) {
       for (const decl of sourceFile.getImportDeclarations()) {
         const spec = decl.getModuleSpecifierValue();
@@ -16257,10 +16253,13 @@ var require_reliability_detector = __commonJS({
       }
       return false;
     }
-    function isNestJSServiceMethod(node, sourceFile) {
+    function isNestJSControllerMethod(node, sourceFile) {
       if (!fileImportsNestJS(sourceFile))
         return false;
-      if (!isInsideNestJSInjectable(node))
+      const classDecl = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.ClassDeclaration);
+      if (!classDecl)
+        return false;
+      if (!isNestJSController(classDecl))
         return false;
       const bgDecorators = /* @__PURE__ */ new Set(["Cron", "Process", "Interval", "Timeout"]);
       if (ts_morph_1.Node.isMethodDeclaration(node)) {
@@ -16268,10 +16267,8 @@ var require_reliability_detector = __commonJS({
           return false;
       }
       const fn = node.getFirstAncestorByKind(ts_morph_1.SyntaxKind.MethodDeclaration);
-      if (fn) {
-        if (fn.getDecorators().some((d) => bgDecorators.has(d.getName())))
-          return false;
-      }
+      if (fn && fn.getDecorators().some((d) => bgDecorators.has(d.getName())))
+        return false;
       return true;
     }
     function getSeverity(ruleId, policy) {
@@ -16356,7 +16353,7 @@ var require_reliability_detector = __commonJS({
           return;
         if (isBootstrapFunction(fn))
           return;
-        if (isNestJSServiceMethod(node, sourceFile))
+        if (isNestJSControllerMethod(node, sourceFile))
           return;
         if (functionHasTryCatch(fn.node))
           return;
@@ -16544,7 +16541,7 @@ var require_reliability_detector = __commonJS({
           continue;
         if (isBootstrapFunction(fn))
           continue;
-        if (isNestJSServiceMethod(fn.node, _sourceFile))
+        if (isNestJSControllerMethod(fn.node, _sourceFile))
           continue;
         let hasAwait = false;
         fn.node.forEachDescendant((child) => {
@@ -16785,6 +16782,12 @@ var require_reliability_detector = __commonJS({
         const hasContinue = /\bcontinue\b/.test(blockText);
         if (hasIncrement || hasPropertyMethodCall || hasAwaitOrDelay || hasContinue)
           return;
+        const hasConsoleLog = /\bconsole\.log\b/.test(blockText);
+        if (hasConsoleLog) {
+          const fn2 = getEnclosingFn(node, fns);
+          violations.push(makeViolation(shared_1.RELIABILITY_RULES.ERROR_LOGGED_AS_INFO, filePath, node.getStartLineNumber(), "Error logged with console.log instead of console.error \u2014 errors should route to stderr", policy, fn2?.name, "Replace console.log with console.error or use a proper logger (winston, pino)"));
+          return;
+        }
         const fn = getEnclosingFn(node, fns);
         violations.push(makeViolation(shared_1.RELIABILITY_RULES.MISSING_ERROR_LOGGING, filePath, node.getStartLineNumber(), "catch block has no error logging or reporting", policy, fn?.name, "Add logger.error(err) or re-throw the error"));
       });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",