technical-debt-radar 1.0.4 → 1.0.6

package/dist/index.js

@@ -16578,6 +16578,31 @@ var require_reliability_detector = __commonJS({
       });
     }
     var LOGGING_PATTERNS = /\b(logger|console\.(?:error|warn)|report|sentry|bugsnag|datadog|newrelic|winston|pino|bunyan)\b/i;
+    var SAFE_FALLBACK_PATTERN = /^return\s+(true|false|null|undefined|void\s+0|0|\[\s*\]|\{\s*\})\s*;?$/;
+    function isSafeFallbackReturn(block) {
+      const statements = block.getStatements();
+      if (statements.length === 0)
+        return false;
+      let returnStatement;
+      let hasOtherSideEffects = false;
+      for (const stmt of statements) {
+        if (ts_morph_1.Node.isReturnStatement(stmt)) {
+          returnStatement = stmt;
+        } else if (ts_morph_1.Node.isVariableStatement(stmt)) {
+          continue;
+        } else {
+          hasOtherSideEffects = true;
+        }
+      }
+      if (!returnStatement || hasOtherSideEffects)
+        return false;
+      const returnText = returnStatement.getText().trim();
+      if (SAFE_FALLBACK_PATTERN.test(returnText))
+        return true;
+      if (statements.length === 1 && returnText.startsWith("return "))
+        return true;
+      return false;
+    }
     function detectMissingErrorLogging(sourceFile, filePath, fns, policy, violations) {
       sourceFile.forEachDescendant((node) => {
         if (!ts_morph_1.Node.isCatchClause(node))
@@ -16596,6 +16621,8 @@ var require_reliability_detector = __commonJS({
         });
         if (hasThrow)
           return;
+        if (isSafeFallbackReturn(block))
+          return;
         const hasIncrement = blockText.includes("++") || blockText.includes("+=");
         const hasPropertyMethodCall = /this\.\w+/.test(blockText);
         const hasAwaitOrDelay = /\bawait\b|\bsetTimeout\b|\bsleep\b|\bdelay\b/i.test(blockText);
@@ -17708,13 +17735,15 @@ var require_dead_code_detector = __commonJS({
       excludeTypes: true,
       severity: "info"
     };
-    async function detectDeadCode(input, config = {}) {
+    async function detectDeadCode(input, config = {}, projectRoot) {
       const cfg = { ...DEFAULT_CONFIG, ...config };
       if (!cfg.enabled) {
         return emptyResult();
       }
       const project = createProject(input);
       const sourceFiles = /* @__PURE__ */ new Map();
+      const effectiveRoot = projectRoot ?? input.projectRoot;
+      const { aliases } = parsePathAliases(input, effectiveRoot);
       for (const sf of project.getSourceFiles()) {
         const filePath = normalizeFilePath(sf.getFilePath());
         sourceFiles.set(filePath, sf);
@@ -17730,7 +17759,7 @@ var require_dead_code_detector = __commonJS({
       }
       const importRefs = /* @__PURE__ */ new Map();
       for (const [filePath, sf] of sourceFiles) {
-        const refs = extractImportReferences(sf, filePath, project);
+        const refs = extractImportReferences(sf, filePath, project, aliases);
         if (refs.size > 0) {
           importRefs.set(filePath, refs);
         }
@@ -17772,6 +17801,9 @@ var require_dead_code_detector = __commonJS({
             continue;
           if (cfg.excludeTypes && isTypeExport(exp.type))
             continue;
+          const sf = sourceFiles.get(filePath);
+          if (sf && exp.type === "class" && isNestJSDIRegistered(sf, exp.name))
+            continue;
           unusedExports.push({
             export: exp,
             file: filePath,
@@ -17849,7 +17881,7 @@ var require_dead_code_detector = __commonJS({
       }
       return exports3;
     }
-    function extractImportReferences(sourceFile, filePath, project) {
+    function extractImportReferences(sourceFile, filePath, project, aliases = []) {
       const refs = /* @__PURE__ */ new Map();
       function addRef(resolvedFile, name) {
         if (!refs.has(resolvedFile)) {
@@ -17859,7 +17891,7 @@ var require_dead_code_detector = __commonJS({
       }
       for (const importDecl of sourceFile.getImportDeclarations()) {
         const specifier = importDecl.getModuleSpecifierValue();
-        const resolved = resolveModuleSpecifier(filePath, specifier, project);
+        const resolved = resolveModuleSpecifier(filePath, specifier, project, aliases);
         if (!resolved)
           continue;
         const defaultImport = importDecl.getDefaultImport();
@@ -17879,7 +17911,7 @@ var require_dead_code_detector = __commonJS({
         const specifier = exportDecl.getModuleSpecifierValue();
         if (!specifier)
           continue;
-        const resolved = resolveModuleSpecifier(filePath, specifier, project);
+        const resolved = resolveModuleSpecifier(filePath, specifier, project, aliases);
         if (!resolved)
           continue;
         if (exportDecl.isNamespaceExport()) {
@@ -17900,9 +17932,7 @@ var require_dead_code_detector = __commonJS({
         if (args.length === 0 || !ts_morph_1.Node.isStringLiteral(args[0]))
           return;
         const modulePath = args[0].getLiteralValue();
-        if (!modulePath.startsWith(".") && !modulePath.startsWith("/"))
-          return;
-        const resolved = resolveModuleSpecifier(filePath, modulePath, project);
+        const resolved = resolveModuleSpecifier(filePath, modulePath, project, aliases);
         if (!resolved)
           return;
         const parent = node.getParent();
@@ -17955,6 +17985,88 @@ var require_dead_code_detector = __commonJS({
     function isTypeExport(type) {
       return type === "type" || type === "interface" || type === "enum";
     }
+    function parsePathAliases(input, projectRoot) {
+      let tsconfigContent;
+      const tsconfigFile = input.changedFiles.find((f) => f.status !== "deleted" && /tsconfig(?:\.build)?\.json$/.test(f.path));
+      if (tsconfigFile) {
+        tsconfigContent = tsconfigFile.content;
+      }
+      const root = projectRoot ?? input.projectRoot;
+      if (!tsconfigContent && root) {
+        try {
+          const fs9 = require("fs");
+          for (const name of ["tsconfig.json", "tsconfig.build.json"]) {
+            const tsconfigPath = path9.join(root, name);
+            if (fs9.existsSync(tsconfigPath)) {
+              tsconfigContent = fs9.readFileSync(tsconfigPath, "utf-8");
+              break;
+            }
+          }
+        } catch {
+        }
+      }
+      if (!tsconfigContent) {
+        return { aliases: [], baseUrl: "." };
+      }
+      try {
+        const stripped = tsconfigContent.replace(/\/\/.*$/gm, "").replace(/\/\*[\s\S]*?\*\//g, "").replace(/,\s*([}\]])/g, "$1");
+        const tsconfig = JSON.parse(stripped);
+        const compilerOptions = tsconfig.compilerOptions ?? {};
+        const rawBaseUrl = (compilerOptions.baseUrl ?? ".").replace(/\/+$/, "");
+        const baseUrl = rawBaseUrl === "" ? "." : rawBaseUrl;
+        const paths = compilerOptions.paths ?? {};
+        const aliases = [];
+        for (const [pattern, targets] of Object.entries(paths)) {
+          const prefix = pattern.replace(/\/?\*$/, "");
+          const resolvedTargets = targets.map((t) => {
+            const target = t.replace(/\/?\*$/, "");
+            if (baseUrl !== "." && !target.startsWith("/")) {
+              return posixJoinAndNormalize(baseUrl, target);
+            }
+            return target;
+          });
+          aliases.push({ prefix, targets: resolvedTargets });
+        }
+        return { aliases, baseUrl };
+      } catch {
+        return { aliases: [], baseUrl: "." };
+      }
+    }
+    function resolvePathAlias(specifier, aliases, project) {
+      for (const alias of aliases) {
+        if (alias.prefix === "" || specifier === alias.prefix || specifier.startsWith(alias.prefix + "/")) {
+          const remainder = alias.prefix === "" ? specifier : specifier.slice(alias.prefix.length).replace(/^\//, "");
+          for (const target of alias.targets) {
+            const candidate = remainder ? target ? target + "/" + remainder : remainder : target;
+            const resolved = resolveInProject(candidate, project);
+            if (resolved)
+              return resolved;
+          }
+        }
+      }
+      return void 0;
+    }
+    function isNestJSDIRegistered(sourceFile, exportName) {
+      for (const cls of sourceFile.getClasses()) {
+        const className = cls.getName();
+        if (className !== exportName)
+          continue;
+        const decorators = cls.getDecorators();
+        for (const dec of decorators) {
+          const decName = dec.getName();
+          if (decName === "Injectable" || decName === "Controller" || decName === "Guard" || decName === "Resolver" || decName === "Gateway") {
+            return true;
+          }
+        }
+        const extendsClause = cls.getExtends();
+        if (extendsClause) {
+          const extendsText = extendsClause.getText();
+          if (extendsText.includes("PassportStrategy"))
+            return true;
+        }
+      }
+      return false;
+    }
     function createProject(input) {
       const project = new ts_morph_1.Project({
         useInMemoryFileSystem: true,
@@ -17977,13 +18089,16 @@ var require_dead_code_detector = __commonJS({
       const normalized = filePath.replace(/\\/g, "/");
       return normalized.startsWith("/") ? normalized.slice(1) : normalized;
     }
-    function resolveModuleSpecifier(sourcePath, specifier, project) {
-      if (!specifier.startsWith(".") && !specifier.startsWith("/")) {
-        return void 0;
+    function resolveModuleSpecifier(sourcePath, specifier, project, aliases = []) {
+      if (specifier.startsWith(".") || specifier.startsWith("/")) {
+        const sourceDir = posixDirname(sourcePath);
+        const resolved = posixJoinAndNormalize(sourceDir, specifier);
+        return resolveInProject(resolved, project) ?? resolved;
       }
-      const sourceDir = posixDirname(sourcePath);
-      const resolved = posixJoinAndNormalize(sourceDir, specifier);
-      return resolveInProject(resolved, project) ?? resolved;
+      if (aliases.length > 0) {
+        return resolvePathAlias(specifier, aliases, project);
+      }
+      return void 0;
     }
     function resolveInProject(resolved, project) {
       const lookup = "/" + resolved;
@@ -18429,7 +18544,7 @@ var require_orchestrator = __commonJS({
         (0, reliability_detector_1.detectReliabilityIssues)(filteredInput, policy),
         (0, duplication_detector_1.detectDuplication)(filteredInput),
         projectRoot ? (0, missing_tests_detector_1.detectMissingTests)(filteredInput, projectRoot) : Promise.resolve(null),
-        (0, dead_code_detector_1.detectDeadCode)(filteredInput),
+        (0, dead_code_detector_1.detectDeadCode)(filteredInput, {}, projectRoot),
         projectRoot ? Promise.resolve((0, coverage_delta_detector_1.detectCoverageDelta)(projectRoot)) : Promise.resolve(null)
       ]);
       const runtimeViolations = runtimeResult.violations;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.0.4",
+  "version": "1.0.6",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",