technical-debt-radar 1.0.3 → 1.0.5

package/dist/index.js

@@ -12957,6 +12957,95 @@ var require_boundary_checker = __commonJS({
       }
       return violations;
     }
+    function isInConstructorShorthandParam(node) {
+      let current = node;
+      while (current) {
+        if (current.getKind() === ts_morph_1.SyntaxKind.Parameter) {
+          const paramText = current.getText();
+          if (/^\s*(private|protected|public|readonly)\s/.test(paramText)) {
+            const paramParent = current.getParent();
+            if (paramParent && paramParent.getKind() === ts_morph_1.SyntaxKind.Constructor) {
+              return true;
+            }
+          }
+          return false;
+        }
+        current = current.getParent();
+      }
+      return false;
+    }
+    function isTypePosition(node) {
+      if (isInConstructorShorthandParam(node))
+        return false;
+      const parent = node.getParent();
+      if (!parent)
+        return false;
+      const parentKind = parent.getKind();
+      if (parentKind === ts_morph_1.SyntaxKind.TypeReference || parentKind === ts_morph_1.SyntaxKind.TypeQuery || parentKind === ts_morph_1.SyntaxKind.TypeAliasDeclaration || parentKind === ts_morph_1.SyntaxKind.InterfaceDeclaration || parentKind === ts_morph_1.SyntaxKind.AsExpression || parentKind === ts_morph_1.SyntaxKind.TypeAssertionExpression || parentKind === ts_morph_1.SyntaxKind.ExpressionWithTypeArguments || parentKind === ts_morph_1.SyntaxKind.MappedType || parentKind === ts_morph_1.SyntaxKind.ConditionalType || parentKind === ts_morph_1.SyntaxKind.IntersectionType || parentKind === ts_morph_1.SyntaxKind.UnionType || parentKind === ts_morph_1.SyntaxKind.TupleType || parentKind === ts_morph_1.SyntaxKind.ArrayType || parentKind === ts_morph_1.SyntaxKind.IndexedAccessType || parentKind === ts_morph_1.SyntaxKind.TypeOperator || parentKind === ts_morph_1.SyntaxKind.ParenthesizedType) {
+        return true;
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.Parameter || parentKind === ts_morph_1.SyntaxKind.PropertyDeclaration || parentKind === ts_morph_1.SyntaxKind.PropertySignature || parentKind === ts_morph_1.SyntaxKind.VariableDeclaration || parentKind === ts_morph_1.SyntaxKind.FunctionDeclaration || parentKind === ts_morph_1.SyntaxKind.MethodDeclaration || parentKind === ts_morph_1.SyntaxKind.MethodSignature || parentKind === ts_morph_1.SyntaxKind.ArrowFunction || parentKind === ts_morph_1.SyntaxKind.GetAccessor || parentKind === ts_morph_1.SyntaxKind.SetAccessor) {
+        const colonToken = parent.getFirstChildByKind(ts_morph_1.SyntaxKind.ColonToken);
+        if (colonToken && node.getPos() > colonToken.getPos()) {
+          const equalsToken = parent.getFirstChildByKind(ts_morph_1.SyntaxKind.EqualsToken);
+          if (!equalsToken || node.getPos() < equalsToken.getPos()) {
+            return true;
+          }
+        }
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.HeritageClause) {
+        return true;
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.QualifiedName) {
+        const grandParent = parent.getParent();
+        if (grandParent && grandParent.getKind() === ts_morph_1.SyntaxKind.TypeReference) {
+          return true;
+        }
+      }
+      return false;
+    }
+    function isImplicitlyTypeOnly(decl, sourceFile) {
+      if (decl.isTypeOnly())
+        return false;
+      if (decl.getNamespaceImport())
+        return false;
+      const defaultImport = decl.getDefaultImport();
+      const namedImports = decl.getNamedImports();
+      if (!defaultImport && namedImports.length === 0)
+        return false;
+      const importedNames = [];
+      if (defaultImport) {
+        importedNames.push(defaultImport.getText());
+      }
+      for (const named of namedImports) {
+        if (named.isTypeOnly())
+          continue;
+        importedNames.push(named.getName());
+      }
+      if (importedNames.length === 0)
+        return true;
+      for (const name of importedNames) {
+        const identifiers = sourceFile.getDescendantsOfKind(ts_morph_1.SyntaxKind.Identifier).filter((id) => id.getText() === name);
+        const usages = identifiers.filter((id) => {
+          const parent = id.getParent();
+          if (!parent)
+            return false;
+          const parentKind = parent.getKind();
+          if (parentKind === ts_morph_1.SyntaxKind.ImportSpecifier || parentKind === ts_morph_1.SyntaxKind.ImportClause) {
+            return false;
+          }
+          return true;
+        });
+        if (usages.length === 0)
+          return false;
+        for (const usage of usages) {
+          if (!isTypePosition(usage)) {
+            return false;
+          }
+        }
+      }
+      return true;
+    }
     function checkCrossModuleDirectImports(input, policy, activeExceptions) {
       const violations = [];
       const hasCrossModuleDeny = policy.rules.some((r) => r.type === "deny" && /cross-module/i.test(r.description ?? "") || /cross-module/i.test(r.source));
@@ -12979,10 +13068,12 @@ var require_boundary_checker = __commonJS({
         }
         const specifiers = [];
         for (const decl of sourceFile.getImportDeclarations()) {
+          const explicitTypeOnly = decl.isTypeOnly();
+          const implicitTypeOnly = !explicitTypeOnly && isImplicitlyTypeOnly(decl, sourceFile);
           specifiers.push({
             specifier: decl.getModuleSpecifierValue(),
             line: decl.getStartLineNumber(),
-            typeOnly: decl.isTypeOnly()
+            typeOnly: explicitTypeOnly || implicitTypeOnly
           });
         }
         for (const reqSpec of extractRequireSpecifiers(sourceFile)) {
@@ -13012,24 +13103,8 @@ var require_boundary_checker = __commonJS({
             continue;
           if (!isNestJS && isFeatureModule && isNestJSExemptImport(filePath, resolvedTarget, policy.sharedInfrastructure))
             continue;
-          if (typeOnly) {
-            violations.push({
-              category: "architecture",
-              type: "module-boundary-violation",
-              ruleId: shared_1.ARCHITECTURE_RULES.MODULE_BOUNDARY,
-              severity: "warning",
-              source: "deterministic",
-              confidence: "high",
-              file: filePath,
-              line,
-              module: sourceModule,
-              message: `Cross-module type import: "${sourceModule}" \u2192 "${targetModule}" \u2014 type-only import from '${specifier}' (${filePath})`,
-              explanation: `Type-only import across modules does not create a runtime dependency, but indicates coupling. Consider moving the type to a shared contract.`,
-              debtPoints: 1,
-              gateAction: "warn"
-            });
+          if (typeOnly)
             continue;
-          }
           violations.push({
             category: "architecture",
             type: "module-boundary-violation",
@@ -16503,6 +16578,31 @@ var require_reliability_detector = __commonJS({
       });
     }
     var LOGGING_PATTERNS = /\b(logger|console\.(?:error|warn)|report|sentry|bugsnag|datadog|newrelic|winston|pino|bunyan)\b/i;
+    var SAFE_FALLBACK_PATTERN = /^return\s+(true|false|null|undefined|void\s+0|0|\[\s*\]|\{\s*\})\s*;?$/;
+    function isSafeFallbackReturn(block) {
+      const statements = block.getStatements();
+      if (statements.length === 0)
+        return false;
+      let returnStatement;
+      let hasOtherSideEffects = false;
+      for (const stmt of statements) {
+        if (ts_morph_1.Node.isReturnStatement(stmt)) {
+          returnStatement = stmt;
+        } else if (ts_morph_1.Node.isVariableStatement(stmt)) {
+          continue;
+        } else {
+          hasOtherSideEffects = true;
+        }
+      }
+      if (!returnStatement || hasOtherSideEffects)
+        return false;
+      const returnText = returnStatement.getText().trim();
+      if (SAFE_FALLBACK_PATTERN.test(returnText))
+        return true;
+      if (statements.length === 1 && returnText.startsWith("return "))
+        return true;
+      return false;
+    }
     function detectMissingErrorLogging(sourceFile, filePath, fns, policy, violations) {
       sourceFile.forEachDescendant((node) => {
         if (!ts_morph_1.Node.isCatchClause(node))
@@ -16521,6 +16621,8 @@ var require_reliability_detector = __commonJS({
         });
         if (hasThrow)
           return;
+        if (isSafeFallbackReturn(block))
+          return;
         const hasIncrement = blockText.includes("++") || blockText.includes("+=");
         const hasPropertyMethodCall = /this\.\w+/.test(blockText);
         const hasAwaitOrDelay = /\bawait\b|\bsetTimeout\b|\bsleep\b|\bdelay\b/i.test(blockText);
@@ -17640,6 +17742,7 @@ var require_dead_code_detector = __commonJS({
       }
       const project = createProject(input);
       const sourceFiles = /* @__PURE__ */ new Map();
+      const { aliases } = parsePathAliases(input);
       for (const sf of project.getSourceFiles()) {
         const filePath = normalizeFilePath(sf.getFilePath());
         sourceFiles.set(filePath, sf);
@@ -17655,7 +17758,7 @@ var require_dead_code_detector = __commonJS({
       }
       const importRefs = /* @__PURE__ */ new Map();
       for (const [filePath, sf] of sourceFiles) {
-        const refs = extractImportReferences(sf, filePath, project);
+        const refs = extractImportReferences(sf, filePath, project, aliases);
         if (refs.size > 0) {
           importRefs.set(filePath, refs);
         }
@@ -17697,6 +17800,9 @@ var require_dead_code_detector = __commonJS({
             continue;
           if (cfg.excludeTypes && isTypeExport(exp.type))
             continue;
+          const sf = sourceFiles.get(filePath);
+          if (sf && exp.type === "class" && isNestJSDIRegistered(sf, exp.name))
+            continue;
           unusedExports.push({
             export: exp,
             file: filePath,
@@ -17774,7 +17880,7 @@ var require_dead_code_detector = __commonJS({
       }
       return exports3;
     }
-    function extractImportReferences(sourceFile, filePath, project) {
+    function extractImportReferences(sourceFile, filePath, project, aliases = []) {
       const refs = /* @__PURE__ */ new Map();
       function addRef(resolvedFile, name) {
         if (!refs.has(resolvedFile)) {
@@ -17784,7 +17890,7 @@ var require_dead_code_detector = __commonJS({
       }
       for (const importDecl of sourceFile.getImportDeclarations()) {
         const specifier = importDecl.getModuleSpecifierValue();
-        const resolved = resolveModuleSpecifier(filePath, specifier, project);
+        const resolved = resolveModuleSpecifier(filePath, specifier, project, aliases);
         if (!resolved)
           continue;
         const defaultImport = importDecl.getDefaultImport();
@@ -17804,7 +17910,7 @@ var require_dead_code_detector = __commonJS({
         const specifier = exportDecl.getModuleSpecifierValue();
         if (!specifier)
           continue;
-        const resolved = resolveModuleSpecifier(filePath, specifier, project);
+        const resolved = resolveModuleSpecifier(filePath, specifier, project, aliases);
         if (!resolved)
           continue;
         if (exportDecl.isNamespaceExport()) {
@@ -17825,9 +17931,7 @@ var require_dead_code_detector = __commonJS({
         if (args.length === 0 || !ts_morph_1.Node.isStringLiteral(args[0]))
           return;
         const modulePath = args[0].getLiteralValue();
-        if (!modulePath.startsWith(".") && !modulePath.startsWith("/"))
-          return;
-        const resolved = resolveModuleSpecifier(filePath, modulePath, project);
+        const resolved = resolveModuleSpecifier(filePath, modulePath, project, aliases);
         if (!resolved)
           return;
         const parent = node.getParent();
@@ -17880,6 +17984,83 @@ var require_dead_code_detector = __commonJS({
     function isTypeExport(type) {
       return type === "type" || type === "interface" || type === "enum";
     }
+    function parsePathAliases(input) {
+      let tsconfigContent;
+      const tsconfigFile = input.changedFiles.find((f) => f.status !== "deleted" && /tsconfig(?:\.build)?\.json$/.test(f.path));
+      if (tsconfigFile) {
+        tsconfigContent = tsconfigFile.content;
+      }
+      if (!tsconfigContent && input.projectRoot) {
+        try {
+          const fs9 = require("fs");
+          const tsconfigPath = path9.join(input.projectRoot, "tsconfig.json");
+          if (fs9.existsSync(tsconfigPath)) {
+            tsconfigContent = fs9.readFileSync(tsconfigPath, "utf-8");
+          }
+        } catch {
+        }
+      }
+      if (!tsconfigContent) {
+        return { aliases: [], baseUrl: "." };
+      }
+      try {
+        const stripped = tsconfigContent.replace(/\/\/.*$/gm, "").replace(/\/\*[\s\S]*?\*\//g, "").replace(/,\s*([}\]])/g, "$1");
+        const tsconfig = JSON.parse(stripped);
+        const compilerOptions = tsconfig.compilerOptions ?? {};
+        const baseUrl = compilerOptions.baseUrl ?? ".";
+        const paths = compilerOptions.paths ?? {};
+        const aliases = [];
+        for (const [pattern, targets] of Object.entries(paths)) {
+          const prefix = pattern.replace(/\/?\*$/, "");
+          const resolvedTargets = targets.map((t) => {
+            const target = t.replace(/\/?\*$/, "");
+            if (baseUrl !== "." && !target.startsWith("/")) {
+              return posixJoinAndNormalize(baseUrl, target);
+            }
+            return target;
+          });
+          aliases.push({ prefix, targets: resolvedTargets });
+        }
+        return { aliases, baseUrl };
+      } catch {
+        return { aliases: [], baseUrl: "." };
+      }
+    }
+    function resolvePathAlias(specifier, aliases, project) {
+      for (const alias of aliases) {
+        if (alias.prefix === "" || specifier === alias.prefix || specifier.startsWith(alias.prefix + "/")) {
+          const remainder = alias.prefix === "" ? specifier : specifier.slice(alias.prefix.length).replace(/^\//, "");
+          for (const target of alias.targets) {
+            const candidate = remainder ? target ? target + "/" + remainder : remainder : target;
+            const resolved = resolveInProject(candidate, project);
+            if (resolved)
+              return resolved;
+          }
+        }
+      }
+      return void 0;
+    }
+    function isNestJSDIRegistered(sourceFile, exportName) {
+      for (const cls of sourceFile.getClasses()) {
+        const className = cls.getName();
+        if (className !== exportName)
+          continue;
+        const decorators = cls.getDecorators();
+        for (const dec of decorators) {
+          const decName = dec.getName();
+          if (decName === "Injectable" || decName === "Controller" || decName === "Guard" || decName === "Resolver" || decName === "Gateway") {
+            return true;
+          }
+        }
+        const extendsClause = cls.getExtends();
+        if (extendsClause) {
+          const extendsText = extendsClause.getText();
+          if (extendsText.includes("PassportStrategy"))
+            return true;
+        }
+      }
+      return false;
+    }
     function createProject(input) {
       const project = new ts_morph_1.Project({
         useInMemoryFileSystem: true,
@@ -17902,13 +18083,16 @@ var require_dead_code_detector = __commonJS({
       const normalized = filePath.replace(/\\/g, "/");
       return normalized.startsWith("/") ? normalized.slice(1) : normalized;
     }
-    function resolveModuleSpecifier(sourcePath, specifier, project) {
-      if (!specifier.startsWith(".") && !specifier.startsWith("/")) {
-        return void 0;
+    function resolveModuleSpecifier(sourcePath, specifier, project, aliases = []) {
+      if (specifier.startsWith(".") || specifier.startsWith("/")) {
+        const sourceDir = posixDirname(sourcePath);
+        const resolved = posixJoinAndNormalize(sourceDir, specifier);
+        return resolveInProject(resolved, project) ?? resolved;
       }
-      const sourceDir = posixDirname(sourcePath);
-      const resolved = posixJoinAndNormalize(sourceDir, specifier);
-      return resolveInProject(resolved, project) ?? resolved;
+      if (aliases.length > 0) {
+        return resolvePathAlias(specifier, aliases, project);
+      }
+      return void 0;
     }
     function resolveInProject(resolved, project) {
       const lookup = "/" + resolved;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",