technical-debt-radar 1.0.3 → 1.0.4

package/dist/index.js

@@ -12957,6 +12957,95 @@ var require_boundary_checker = __commonJS({
       }
       return violations;
     }
+    function isInConstructorShorthandParam(node) {
+      let current = node;
+      while (current) {
+        if (current.getKind() === ts_morph_1.SyntaxKind.Parameter) {
+          const paramText = current.getText();
+          if (/^\s*(private|protected|public|readonly)\s/.test(paramText)) {
+            const paramParent = current.getParent();
+            if (paramParent && paramParent.getKind() === ts_morph_1.SyntaxKind.Constructor) {
+              return true;
+            }
+          }
+          return false;
+        }
+        current = current.getParent();
+      }
+      return false;
+    }
+    function isTypePosition(node) {
+      if (isInConstructorShorthandParam(node))
+        return false;
+      const parent = node.getParent();
+      if (!parent)
+        return false;
+      const parentKind = parent.getKind();
+      if (parentKind === ts_morph_1.SyntaxKind.TypeReference || parentKind === ts_morph_1.SyntaxKind.TypeQuery || parentKind === ts_morph_1.SyntaxKind.TypeAliasDeclaration || parentKind === ts_morph_1.SyntaxKind.InterfaceDeclaration || parentKind === ts_morph_1.SyntaxKind.AsExpression || parentKind === ts_morph_1.SyntaxKind.TypeAssertionExpression || parentKind === ts_morph_1.SyntaxKind.ExpressionWithTypeArguments || parentKind === ts_morph_1.SyntaxKind.MappedType || parentKind === ts_morph_1.SyntaxKind.ConditionalType || parentKind === ts_morph_1.SyntaxKind.IntersectionType || parentKind === ts_morph_1.SyntaxKind.UnionType || parentKind === ts_morph_1.SyntaxKind.TupleType || parentKind === ts_morph_1.SyntaxKind.ArrayType || parentKind === ts_morph_1.SyntaxKind.IndexedAccessType || parentKind === ts_morph_1.SyntaxKind.TypeOperator || parentKind === ts_morph_1.SyntaxKind.ParenthesizedType) {
+        return true;
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.Parameter || parentKind === ts_morph_1.SyntaxKind.PropertyDeclaration || parentKind === ts_morph_1.SyntaxKind.PropertySignature || parentKind === ts_morph_1.SyntaxKind.VariableDeclaration || parentKind === ts_morph_1.SyntaxKind.FunctionDeclaration || parentKind === ts_morph_1.SyntaxKind.MethodDeclaration || parentKind === ts_morph_1.SyntaxKind.MethodSignature || parentKind === ts_morph_1.SyntaxKind.ArrowFunction || parentKind === ts_morph_1.SyntaxKind.GetAccessor || parentKind === ts_morph_1.SyntaxKind.SetAccessor) {
+        const colonToken = parent.getFirstChildByKind(ts_morph_1.SyntaxKind.ColonToken);
+        if (colonToken && node.getPos() > colonToken.getPos()) {
+          const equalsToken = parent.getFirstChildByKind(ts_morph_1.SyntaxKind.EqualsToken);
+          if (!equalsToken || node.getPos() < equalsToken.getPos()) {
+            return true;
+          }
+        }
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.HeritageClause) {
+        return true;
+      }
+      if (parentKind === ts_morph_1.SyntaxKind.QualifiedName) {
+        const grandParent = parent.getParent();
+        if (grandParent && grandParent.getKind() === ts_morph_1.SyntaxKind.TypeReference) {
+          return true;
+        }
+      }
+      return false;
+    }
+    function isImplicitlyTypeOnly(decl, sourceFile) {
+      if (decl.isTypeOnly())
+        return false;
+      if (decl.getNamespaceImport())
+        return false;
+      const defaultImport = decl.getDefaultImport();
+      const namedImports = decl.getNamedImports();
+      if (!defaultImport && namedImports.length === 0)
+        return false;
+      const importedNames = [];
+      if (defaultImport) {
+        importedNames.push(defaultImport.getText());
+      }
+      for (const named of namedImports) {
+        if (named.isTypeOnly())
+          continue;
+        importedNames.push(named.getName());
+      }
+      if (importedNames.length === 0)
+        return true;
+      for (const name of importedNames) {
+        const identifiers = sourceFile.getDescendantsOfKind(ts_morph_1.SyntaxKind.Identifier).filter((id) => id.getText() === name);
+        const usages = identifiers.filter((id) => {
+          const parent = id.getParent();
+          if (!parent)
+            return false;
+          const parentKind = parent.getKind();
+          if (parentKind === ts_morph_1.SyntaxKind.ImportSpecifier || parentKind === ts_morph_1.SyntaxKind.ImportClause) {
+            return false;
+          }
+          return true;
+        });
+        if (usages.length === 0)
+          return false;
+        for (const usage of usages) {
+          if (!isTypePosition(usage)) {
+            return false;
+          }
+        }
+      }
+      return true;
+    }
     function checkCrossModuleDirectImports(input, policy, activeExceptions) {
       const violations = [];
       const hasCrossModuleDeny = policy.rules.some((r) => r.type === "deny" && /cross-module/i.test(r.description ?? "") || /cross-module/i.test(r.source));
@@ -12979,10 +13068,12 @@ var require_boundary_checker = __commonJS({
         }
         const specifiers = [];
         for (const decl of sourceFile.getImportDeclarations()) {
+          const explicitTypeOnly = decl.isTypeOnly();
+          const implicitTypeOnly = !explicitTypeOnly && isImplicitlyTypeOnly(decl, sourceFile);
           specifiers.push({
             specifier: decl.getModuleSpecifierValue(),
             line: decl.getStartLineNumber(),
-            typeOnly: decl.isTypeOnly()
+            typeOnly: explicitTypeOnly || implicitTypeOnly
           });
         }
         for (const reqSpec of extractRequireSpecifiers(sourceFile)) {
@@ -13012,24 +13103,8 @@ var require_boundary_checker = __commonJS({
             continue;
           if (!isNestJS && isFeatureModule && isNestJSExemptImport(filePath, resolvedTarget, policy.sharedInfrastructure))
             continue;
-          if (typeOnly) {
-            violations.push({
-              category: "architecture",
-              type: "module-boundary-violation",
-              ruleId: shared_1.ARCHITECTURE_RULES.MODULE_BOUNDARY,
-              severity: "warning",
-              source: "deterministic",
-              confidence: "high",
-              file: filePath,
-              line,
-              module: sourceModule,
-              message: `Cross-module type import: "${sourceModule}" \u2192 "${targetModule}" \u2014 type-only import from '${specifier}' (${filePath})`,
-              explanation: `Type-only import across modules does not create a runtime dependency, but indicates coupling. Consider moving the type to a shared contract.`,
-              debtPoints: 1,
-              gateAction: "warn"
-            });
+          if (typeOnly)
             continue;
-          }
           violations.push({
             category: "architecture",
             type: "module-boundary-violation",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "technical-debt-radar",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Stop Node.js production crashes before merge. 47 detection patterns across 5 categories.",
   "bin": {
     "radar": "dist/index.js",