tdd-enforcer 0.2.6 → 0.2.8

package/engine/enforce.test.ts

@@ -1,155 +1,165 @@
-import { describe, it, expect } from "vitest";
-import { isAllowed, disallowedFiles } from "./enforce.js";
+import { describe, expect, it } from "vitest";
+import { disallowedFiles, isAllowed } from "./enforce.js";
 import type { Config } from "./types.js";
 
 const testConfig: Config = {
-  blockedInRed: ["src/**/*.ts", "lib/**/*.ts"],
-  blockedInGreen: ["tests/**/*.test.ts", "specs/**/*.spec.ts"],
-  testCommands: ["npm test"],
-  timeoutSeconds: 30,
+	blockedInRed: ["src/**/*.ts", "lib/**/*.ts"],
+	blockedInGreen: ["tests/**/*.test.ts", "specs/**/*.spec.ts"],
+	testCommands: ["npm test"],
+	timeoutSeconds: 30,
 };
 
 describe("isAllowed", () => {
-  it("allows everything in refactor phase", () => {
-    expect(isAllowed("any/file.ts", "refactor", testConfig)).toBe(true);
-    expect(isAllowed("tests/foo.test.ts", "refactor", testConfig)).toBe(true);
-  });
-
-  describe("red phase", () => {
-    it("allows free files", () => {
-      expect(isAllowed("README.md", "red", testConfig)).toBe(true);
-      expect(isAllowed("package.json", "red", testConfig)).toBe(true);
-    });
-
-    it("blocks files in blockedInRed", () => {
-      expect(isAllowed("src/main.ts", "red", testConfig)).toBe(false);
-      expect(isAllowed("lib/helper.ts", "red", testConfig)).toBe(false);
-    });
-
-    it("allows test files in red phase", () => {
-      expect(isAllowed("tests/foo.test.ts", "red", testConfig)).toBe(true);
-      expect(isAllowed("specs/api.spec.ts", "red", testConfig)).toBe(true);
-    });
-  });
-
-  describe("green phase", () => {
-    it("allows free files", () => {
-      expect(isAllowed("README.md", "green", testConfig)).toBe(true);
-    });
-
-    it("allows implementation files in green phase", () => {
-      expect(isAllowed("src/main.ts", "green", testConfig)).toBe(true);
-      expect(isAllowed("lib/helper.ts", "green", testConfig)).toBe(true);
-    });
-
-    it("blocks files in blockedInGreen", () => {
-      expect(isAllowed("tests/foo.test.ts", "green", testConfig)).toBe(false);
-      expect(isAllowed("specs/api.spec.ts", "green", testConfig)).toBe(false);
-    });
-  });
-
-  describe("negation patterns (!)", () => {
-    const exclConfig: Config = {
-      blockedInRed: ["src/**/*.ts"],
-      blockedInGreen: ["src/**/*.ts", "!**/*.test.ts"],
-      testCommands: ["npm test"],
-      timeoutSeconds: 30,
-    };
-
-    it("excludes files matching !pattern from the block", () => {
-      expect(isAllowed("src/main.test.ts", "green", exclConfig)).toBe(true);
-    });
-
-    it("still blocks files not matching the exclusion", () => {
-      expect(isAllowed("src/main.ts", "green", exclConfig)).toBe(false);
-    });
-
-    it("excludes spec files with a second !pattern", () => {
-      const multiExcl: Config = {
-        blockedInRed: [],
-        blockedInGreen: ["src/**/*.ts", "!**/*.test.ts", "!**/*.spec.ts"],
-        testCommands: [],
-        timeoutSeconds: 30,
-      };
-      expect(isAllowed("src/main.spec.ts", "green", multiExcl)).toBe(true);
-      expect(isAllowed("src/main.test.ts", "green", multiExcl)).toBe(true);
-      expect(isAllowed("src/main.ts", "green", multiExcl)).toBe(false);
-    });
-
-    it("excludes via complex glob in negation pattern", () => {
-      const complexExcl: Config = {
-        blockedInRed: [],
-        blockedInGreen: ["src/**", "!src/vendor/**"],
-        testCommands: [],
-        timeoutSeconds: 30,
-      };
-      expect(isAllowed("src/vendor/lib.js", "green", complexExcl)).toBe(true);
-      expect(isAllowed("src/app.ts", "green", complexExcl)).toBe(false);
-      expect(isAllowed("src/utils/helper.ts", "green", complexExcl)).toBe(false);
-    });
-
-    it("supports ! negation in blockedInRed as well", () => {
-      const redExcl: Config = {
-        blockedInRed: ["src/**/*.ts", "!src/**/*.test.ts"],
-        blockedInGreen: [],
-        testCommands: [],
-        timeoutSeconds: 30,
-      };
-      // test file excluded from block → allowed in red
-      expect(isAllowed("src/main.test.ts", "red", redExcl)).toBe(true);
-      // impl file still blocked
-      expect(isAllowed("src/main.ts", "red", redExcl)).toBe(false);
-      // free file unaffected
-      expect(isAllowed("README.md", "red", redExcl)).toBe(true);
-    });
-
-    it("free file with exclusions in config remains free", () => {
-      expect(isAllowed("README.md", "green", exclConfig)).toBe(true);
-    });
-
-    it("file matching !pattern alone (no positive match) is not blocked", () => {
-      // File matches the negation pattern but NOT the positive pattern.
-      // MatchPatterns returns false (no positive match), so it's not blocked.
-      expect(isAllowed("other/foo.test.ts", "green", exclConfig)).toBe(true);
-    });
-
-    it("exclusion-only patterns block nothing", () => {
-      const exclOnly: Config = {
-        blockedInRed: [],
-        blockedInGreen: ["!**/*.test.ts"],
-        testCommands: [],
-        timeoutSeconds: 30,
-      };
-      expect(isAllowed("any/file.ts", "green", exclOnly)).toBe(true);
-      expect(isAllowed("README.md", "green", exclOnly)).toBe(true);
-      expect(isAllowed("tests/foo.test.ts", "green", exclOnly)).toBe(true);
-    });
-  });
+	it("allows everything in refactor phase", () => {
+		expect(isAllowed("any/file.ts", "refactor", testConfig)).toBe(true);
+		expect(isAllowed("tests/foo.test.ts", "refactor", testConfig)).toBe(true);
+	});
+
+	describe("red phase", () => {
+		it("allows free files", () => {
+			expect(isAllowed("README.md", "red", testConfig)).toBe(true);
+			expect(isAllowed("package.json", "red", testConfig)).toBe(true);
+		});
+
+		it("blocks files in blockedInRed", () => {
+			expect(isAllowed("src/main.ts", "red", testConfig)).toBe(false);
+			expect(isAllowed("lib/helper.ts", "red", testConfig)).toBe(false);
+		});
+
+		it("allows test files in red phase", () => {
+			expect(isAllowed("tests/foo.test.ts", "red", testConfig)).toBe(true);
+			expect(isAllowed("specs/api.spec.ts", "red", testConfig)).toBe(true);
+		});
+	});
+
+	describe("green phase", () => {
+		it("allows free files", () => {
+			expect(isAllowed("README.md", "green", testConfig)).toBe(true);
+		});
+
+		it("allows implementation files in green phase", () => {
+			expect(isAllowed("src/main.ts", "green", testConfig)).toBe(true);
+			expect(isAllowed("lib/helper.ts", "green", testConfig)).toBe(true);
+		});
+
+		it("blocks files in blockedInGreen", () => {
+			expect(isAllowed("tests/foo.test.ts", "green", testConfig)).toBe(false);
+			expect(isAllowed("specs/api.spec.ts", "green", testConfig)).toBe(false);
+		});
+	});
+
+	describe("negation patterns (!)", () => {
+		const exclConfig: Config = {
+			blockedInRed: ["src/**/*.ts"],
+			blockedInGreen: ["src/**/*.ts", "!**/*.test.ts"],
+			testCommands: ["npm test"],
+			timeoutSeconds: 30,
+		};
+
+		it("excludes files matching !pattern from the block", () => {
+			expect(isAllowed("src/main.test.ts", "green", exclConfig)).toBe(true);
+		});
+
+		it("still blocks files not matching the exclusion", () => {
+			expect(isAllowed("src/main.ts", "green", exclConfig)).toBe(false);
+		});
+
+		it("excludes spec files with a second !pattern", () => {
+			const multiExcl: Config = {
+				blockedInRed: [],
+				blockedInGreen: ["src/**/*.ts", "!**/*.test.ts", "!**/*.spec.ts"],
+				testCommands: [],
+				timeoutSeconds: 30,
+			};
+			expect(isAllowed("src/main.spec.ts", "green", multiExcl)).toBe(true);
+			expect(isAllowed("src/main.test.ts", "green", multiExcl)).toBe(true);
+			expect(isAllowed("src/main.ts", "green", multiExcl)).toBe(false);
+		});
+
+		it("excludes via complex glob in negation pattern", () => {
+			const complexExcl: Config = {
+				blockedInRed: [],
+				blockedInGreen: ["src/**", "!src/vendor/**"],
+				testCommands: [],
+				timeoutSeconds: 30,
+			};
+			expect(isAllowed("src/vendor/lib.js", "green", complexExcl)).toBe(true);
+			expect(isAllowed("src/app.ts", "green", complexExcl)).toBe(false);
+			expect(isAllowed("src/utils/helper.ts", "green", complexExcl)).toBe(
+				false,
+			);
+		});
+
+		it("supports ! negation in blockedInRed as well", () => {
+			const redExcl: Config = {
+				blockedInRed: ["src/**/*.ts", "!src/**/*.test.ts"],
+				blockedInGreen: [],
+				testCommands: [],
+				timeoutSeconds: 30,
+			};
+			// test file excluded from block → allowed in red
+			expect(isAllowed("src/main.test.ts", "red", redExcl)).toBe(true);
+			// impl file still blocked
+			expect(isAllowed("src/main.ts", "red", redExcl)).toBe(false);
+			// free file unaffected
+			expect(isAllowed("README.md", "red", redExcl)).toBe(true);
+		});
+
+		it("free file with exclusions in config remains free", () => {
+			expect(isAllowed("README.md", "green", exclConfig)).toBe(true);
+		});
+
+		it("file matching !pattern alone (no positive match) is not blocked", () => {
+			// File matches the negation pattern but NOT the positive pattern.
+			// MatchPatterns returns false (no positive match), so it's not blocked.
+			expect(isAllowed("other/foo.test.ts", "green", exclConfig)).toBe(true);
+		});
+
+		it("exclusion-only patterns block nothing", () => {
+			const exclOnly: Config = {
+				blockedInRed: [],
+				blockedInGreen: ["!**/*.test.ts"],
+				testCommands: [],
+				timeoutSeconds: 30,
+			};
+			expect(isAllowed("any/file.ts", "green", exclOnly)).toBe(true);
+			expect(isAllowed("README.md", "green", exclOnly)).toBe(true);
+			expect(isAllowed("tests/foo.test.ts", "green", exclOnly)).toBe(true);
+		});
+	});
 });
 
 describe("disallowedFiles", () => {
-  it("returns empty for refactor phase", () => {
-    expect(disallowedFiles(["src/main.ts", "tests/foo.test.ts"], "refactor", testConfig)).toEqual([]);
-  });
-
-  it("returns empty when input list is empty", () => {
-    expect(disallowedFiles([], "red", testConfig)).toEqual([]);
-    expect(disallowedFiles([], "green", testConfig)).toEqual([]);
-  });
-
-  it("filters out blockedInRed files in red phase", () => {
-    const files = ["src/main.ts", "README.md", "tests/foo.test.ts"];
-    expect(disallowedFiles(files, "red", testConfig)).toEqual(["src/main.ts"]);
-  });
-
-  it("filters out blockedInGreen files in green phase", () => {
-    const files = ["tests/foo.test.ts", "README.md", "src/main.ts"];
-    expect(disallowedFiles(files, "green", testConfig)).toEqual(["tests/foo.test.ts"]);
-  });
-
-  it("allows free files in both phases", () => {
-    const free = ["README.md", "package.json", "docs/guide.md"];
-    expect(disallowedFiles(free, "red", testConfig)).toEqual([]);
-    expect(disallowedFiles(free, "green", testConfig)).toEqual([]);
-  });
+	it("returns empty for refactor phase", () => {
+		expect(
+			disallowedFiles(
+				["src/main.ts", "tests/foo.test.ts"],
+				"refactor",
+				testConfig,
+			),
+		).toEqual([]);
+	});
+
+	it("returns empty when input list is empty", () => {
+		expect(disallowedFiles([], "red", testConfig)).toEqual([]);
+		expect(disallowedFiles([], "green", testConfig)).toEqual([]);
+	});
+
+	it("filters out blockedInRed files in red phase", () => {
+		const files = ["src/main.ts", "README.md", "tests/foo.test.ts"];
+		expect(disallowedFiles(files, "red", testConfig)).toEqual(["src/main.ts"]);
+	});
+
+	it("filters out blockedInGreen files in green phase", () => {
+		const files = ["tests/foo.test.ts", "README.md", "src/main.ts"];
+		expect(disallowedFiles(files, "green", testConfig)).toEqual([
+			"tests/foo.test.ts",
+		]);
+	});
+
+	it("allows free files in both phases", () => {
+		const free = ["README.md", "package.json", "docs/guide.md"];
+		expect(disallowedFiles(free, "red", testConfig)).toEqual([]);
+		expect(disallowedFiles(free, "green", testConfig)).toEqual([]);
+	});
 });

package/engine/enforce.ts

@@ -1,5 +1,5 @@
 import picomatch from "picomatch";
-import type { Phase, Config } from "./types.js";
+import type { Config, Phase } from "./types.js";
 
 /**
  * Match a file path against a list of glob patterns with !exclusion support.
@@ -10,24 +10,24 @@ import type { Phase, Config } from "./types.js";
  * Empty pattern list = no match.
  */
 function matchPatterns(patterns: string[], filePath: string): boolean {
-  const positive: string[] = [];
-  const negative: string[] = [];
+	const positive: string[] = [];
+	const negative: string[] = [];
 
-  for (const p of patterns) {
-    if (p.startsWith("!")) {
-      negative.push(p.slice(1));
-    } else {
-      positive.push(p);
-    }
-  }
+	for (const p of patterns) {
+		if (p.startsWith("!")) {
+			negative.push(p.slice(1));
+		} else {
+			positive.push(p);
+		}
+	}
 
-  if (positive.length === 0) return false;
+	if (positive.length === 0) return false;
 
-  const matchesPositive = positive.some((p) => picomatch(p)(filePath));
-  if (!matchesPositive) return false;
+	const matchesPositive = positive.some((p) => picomatch(p)(filePath));
+	if (!matchesPositive) return false;
 
-  const matchesNegative = negative.some((p) => picomatch(p)(filePath));
-  return !matchesNegative;
+	const matchesNegative = negative.some((p) => picomatch(p)(filePath));
+	return !matchesNegative;
 }
 
 /**
@@ -39,17 +39,25 @@ function matchPatterns(patterns: string[], filePath: string): boolean {
  * - GREEN: files in blockedInGreen are blocked, everything else is free
  * - ! negation patterns exclude subsets from a block list
  */
-export function isAllowed(filePath: string, phase: Phase, config: Config): boolean {
-  if (phase === "refactor") return true;
-
-  const blocked = phase === "red" ? config.blockedInRed : config.blockedInGreen;
-  return !matchPatterns(blocked, filePath);
+export function isAllowed(
+	filePath: string,
+	phase: Phase,
+	config: Config,
+): boolean {
+	if (phase === "refactor") return true;
+
+	const blocked = phase === "red" ? config.blockedInRed : config.blockedInGreen;
+	return !matchPatterns(blocked, filePath);
 }
 
 /**
  * Filter a list of file paths to those that are disallowed in the current phase.
  */
-export function disallowedFiles(files: string[], phase: Phase, config: Config): string[] {
-  if (phase === "refactor") return [];
-  return files.filter((f) => !isAllowed(f, phase, config));
+export function disallowedFiles(
+	files: string[],
+	phase: Phase,
+	config: Config,
+): string[] {
+	if (phase === "refactor") return [];
+	return files.filter((f) => !isAllowed(f, phase, config));
 }