taxtank-core 2.1.102 → 2.1.104

package/fesm2022/taxtank-core.mjs

@@ -6736,8 +6736,11 @@ class Property extends Property$1 {
     get corelogicNextDate() {
         return this.corelogicLastRequest ? new Date(this.corelogicLastRequest.getTime() + Property.corelogicCooldown) : new Date();
     }
+    isForeign() {
+        return !this.address.country.isAustralia();
+    }
     isCorelogicAvailable() {
-        return this.address.country.isAustralia() && (this.corelogicLastRequest < new Date(Date.now() - Property.corelogicCooldown));
+        return !this.isForeign() && (this.corelogicLastRequest < new Date(Date.now() - Property.corelogicCooldown));
     }
     getGrowth() {
         return this.valuation.marketValue - this.purchasePrice;
@@ -28253,9 +28256,7 @@ class PropertyEditForm extends AbstractForm {
 
 class PropertyValuationForm extends AbstractForm {
     constructor(valuation = plainToClass(PropertyValuation, {}), property) {
-        // @TODO Vladimir test and fix
-        // const marketValue = valuation.id ? valuation.marketValue ?? property?.marketValue : 0;
-        const marketValue = valuation.marketValue ?? property?.marketValue;
+        const marketValue = property?.isForeign() && !valuation.id ? 0 : valuation.marketValue ?? property?.marketValue;
         super({
             // corelogic available only for new valuations if request cooldown has passed
             isCorelogic: new FormControl(property?.isCorelogicAvailable() && !valuation.id),
@@ -29558,6 +29559,7 @@ var MessagesEnum$1;
 class TransactionForm extends TransactionBaseForm {
     constructor(transaction, registeredForGst, allocations, controls = {}) {
         super(transaction, registeredForGst, Object.assign(controls, {
+            transactions: new UntypedFormArray([]),
             source: new UntypedFormControl(transaction.source || TransactionSourceEnum.BANK_TRANSACTION, Validators.required)
         }));
         this.includeDisabledFields = true;
@@ -29570,6 +29572,7 @@ class TransactionForm extends TransactionBaseForm {
         if (transaction.property) {
             this.get('date').addValidators(minDateValidator(transaction.property.myShare.fromDate, MessagesEnum$1.DATE_VALIDATION_ERROR));
         }
+        // property income usually comes with fees, add empty control for new transactions
         if (!transaction.id && transaction.property && !transaction.transactions.length && transaction.isCredit()) {
             this.addTransactionControl();
         }