taxtank-core 2.0.98 → 2.0.99

package/fesm2022/taxtank-core.mjs

@@ -2355,8 +2355,8 @@ class MoneyCalendarEventCollection extends CalendarEventCollection {
     get incomes() {
         return this.filter(event => event.extendedProps.chartAccounts.isIncome());
     }
-    filterByDate(dateFrom = new FinancialYear().startDate, dateTo = new FinancialYear().endDate) {
-        return this.filterByRange('date', dateFrom, dateTo);
+    filterByDate(dateFrom, dateTo) {
+        return this.filterByRange('date', dateFrom ?? new FinancialYear().startDate, dateTo ?? new FinancialYear().endDate);
     }
     getByMonth(index) {
         return new MoneyCalendarEventCollection(this.items.filter(event => event.inMonth(index)));
@@ -8668,11 +8668,11 @@ class BudgetRuleItem {
         if (rule.property) {
             transactions = transactions.filterBy('property.id', rule.property.id);
         }
-        this.forecast = rule.getCalendarEvents(false).filterByDate(dateFrom, dateTo).amount;
+        this.forecast = rule.getCalendarEvents().filterByDate(dateFrom, dateTo).amount;
         this.transactions = transactions;
         this.actual = transactions.sumBy(isGross ? 'grossAmount' : 'amount');
         this.variance = this.actual - this.forecast;
-        this.variancePercent = round(this.actual * 100 / this.forecast, 2);
+        this.variancePercent = round(this.variance * 100 / this.forecast, 2);
     }
     getSource() {
         switch (true) {
@@ -8810,6 +8810,9 @@ class BudgetRuleCollection extends Collection {
     getByMonth(index) {
         return new BudgetRuleCollection(this.items.filter(rule => rule.inMonth(index)));
     }
+    getByDate(dateFrom, dateTo) {
+        return this.filter(rule => !!rule.getCalendarEvents().filterByDate(dateFrom, dateTo).length);
+    }
     getByChartAccountsName(name) {
         const searchQuery = name.toLowerCase().trim();
         return this.filter(rule => rule.chartAccounts.name.toLowerCase().includes(searchQuery));
@@ -8857,13 +8860,13 @@ class BudgetRuleItemCollection extends Collection {
      * @TODO move to property to avoid recalculations?
      */
     getForecastByMonth(month) {
-        return this.getCalendarEvents(false).getByMonth(month).amount;
+        return this.getCalendarEvents().getByMonth(month).amount;
     }
     /**
      * @TODO move to property to avoid recalculations?
      */
     get variancePercent() {
-        return round(this.sumBy('actual') * 100 / this.sumBy('forecast'), 2);
+        return round(this.sumBy('variance') * 100 / this.sumBy('forecast'), 2);
     }
 }
 
@@ -11721,7 +11724,7 @@ class BudgetRule extends BudgetRule$1 {
     /**
      * creates recurring calendar events based on frequency
      */
-    getCalendarEvents(inCalendar = true) {
+    getCalendarEvents(inCalendar = false) {
         if (inCalendar && !this.inCalendar) {
             return new MoneyCalendarEventCollection([]);
         }
@@ -27112,11 +27115,8 @@ class TransactionBaseFilterForm extends FormGroup {
         if (value.chartAccounts) {
             rules = rules.getByChartAccountsName(value.chartAccounts);
         }
-        if (dateFrom) {
-            rules = rules.filter(rule => rule.startDate >= dateFrom);
-        }
-        if (dateTo) {
-            rules = rules.filter(rule => (rule.endDate || rule.startDate) <= dateTo);
+        if (dateFrom || dateTo) {
+            rules = rules.getByDate(dateFrom, dateTo);
         }
         if (value.properties?.length) {
             rules = rules.filterByProperties(value.properties);