taxtank-core 1.0.19 → 1.0.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taxtank-core",
-  "version": "1.0.19",
+  "version": "1.0.20",
   "private": false,
   "peerDependencies": {
     "@angular/common": "^19.0.2",

package/src/lib/collections/account-setup-item.collection.d.ts

@@ -1,10 +1,6 @@
-import { AccountSetupItem } from '../models';
+import { AccountSetupItem } from '../models/account-setup/account-setup-item';
 import { Collection } from './collection';
-import { User } from '../models';
 export declare class AccountSetupItemCollection extends Collection<AccountSetupItem> {
     constructor(items: AccountSetupItem[]);
     isCompleted(): boolean;
-    getByUser(user: User): this;
-    getScore(): number;
-    setUrlId(id: string): void;
 }

package/src/lib/collections/bank-account.collection.d.ts

@@ -31,7 +31,7 @@ export declare class BankAccountCollection extends Collection<BankAccount> {
     /**
      * Get Collection of bank accounts by tank type
      */
-    getByTankType(tankType?: TankTypeEnum): BankAccountCollection;
+    getByTankType(tankType: TankTypeEnum): BankAccountCollection;
     /**
      * Get list of all bank account properties
      */

package/src/lib/collections/subscription/service-subscription.collection.d.ts

@@ -19,6 +19,5 @@ export declare class ServiceSubscriptionCollection extends Collection<ServiceSub
     findByProduct(product: ServiceProduct): ServiceSubscription;
     filterByProduct(product: ServiceProduct): this;
     filterByRole(role: UserRolesEnum): this;
-    findByRole(role: UserRolesEnum): ServiceSubscription;
     hasPropertyTank(): boolean;
 }

package/src/lib/db/Enums/index.d.ts

@@ -10,4 +10,3 @@ export * from './subscription';
 export * from './user';
 export * from './sole';
 export * from './home-office';
-export * from './setup-item-type.enum';

package/src/lib/db/Enums/setup-item-type.enum.d.ts

@@ -1,10 +1,4 @@
 export declare enum SetupItemTypeEnum {
-    EMPLOYEE = 0,
-    WORK = 1,
-    PROPERTIES = 2,
-    PROPERTY = 3,
-    BUSINESS = 4,
-    HOLDING = 5,
-    BANK_ACCOUNTS = 6,
-    BANK_ACCOUNT = 7
+    CLIENT = 1,
+    EMPLOYEE = 2
 }

package/src/lib/db/Models/property/property.d.ts

@@ -42,5 +42,4 @@ export declare class Property extends ObservableModel {
     depreciations?: Depreciation[];
     file: File;
     corelogicLastRequest: Date;
-    get capitalCosts(): number;
 }

package/src/lib/db/Models/setup-item.d.ts

@@ -1,4 +1,4 @@
-import { SetupItemTypeEnum } from '../Enums';
+import { SetupItemTypeEnum } from '../Enums/setup-item-type.enum';
 import { UserRolesEnum } from 'taxtank-core/common';
 import { AbstractModel } from './abstract-model';
 export declare class SetupItem extends AbstractModel {
@@ -7,8 +7,5 @@ export declare class SetupItem extends AbstractModel {
     description?: string;
     url?: string;
     urlFragment?: string;
-    isRequired?: boolean;
-    order?: number;
-    score?: number;
     roles?: UserRolesEnum;
 }

package/src/lib/forms/transaction/allocation-rule-transaction.form.d.ts

@@ -16,6 +16,7 @@ export declare class AllocationRuleTransactionForm extends AbstractForm<Allocati
     get isSplit(): boolean;
     isPersonal(): boolean;
     addChildTransactionForm(): void;
+    buildTransactions(transaction: AllocationRuleTransaction): AllocationRuleTransaction[];
     submit(): AllocationRuleTransaction;
     listenEvents(): void;
     private listenChartAccountsChanges;

package/src/lib/models/account-setup/account-setup-item.d.ts

@@ -1,8 +1,15 @@
 import { SetupItem } from '../../db/Models/setup-item';
 export declare class AccountSetupItem extends SetupItem {
-    status: number;
-    get isPending(): boolean;
-    get isAchieved(): boolean;
-    get isCompleted(): boolean;
-    get isSkipped(): boolean;
+    isCompleted: boolean;
+    get isSalary(): boolean;
+    get isOtherIncome(): boolean;
+    get isProperty(): boolean;
+    get isBankFeeds(): boolean;
+    get isWorkLogbook(): boolean;
+    get isTransactionAllocate(): boolean;
+    get isSoleBusiness(): boolean;
+    get isHoldings(): boolean;
+    get isFirmDetails(): boolean;
+    get isInviteTeam(): boolean;
+    get isInviteClients(): boolean;
 }

package/src/lib/models/account-setup/account-setup-items.enum.d.ts

@@ -1,35 +1,17 @@
 /**
- * TODO remove
+ * Enum list of all possible account setup items ids. Using with [ACCOUNT_SETUP_ITEMS]{@link ACCOUNT_SETUP_ITEMS}
+ * @TODO Vik/Nikita: Do we need to generate it from backend? If some ids changed?
  */
 export declare enum AccountSetupItemsEnum {
-    FIRM_DETAILS = 9,
-    FIRM_EMPLOYEES = 10,
-    FIRM_CLIENTS = 11,
-    WORK_SALARY = 1,
-    WORK_OTHER_INCOME = 2,
-    WORK_VEHICLE_CLAIM = 5,
-    WORK_HOME_OFFICE = 13,
-    WORK_BANK_ACCOUNT = 14,
-    WORK_DEPRECIATION = 15,
+    SALARY = 1,
+    OTHER_INCOME = 2,
     PROPERTY = 3,
-    PROPERTIES = 29,
-    PROPERTIES_BANK_ACCOUNT = 30,
-    PROPERTY_CAPITAL_COST = 17,
-    PROPERTY_RENT_INCOME = 18,
-    PROPERTY_DEPRECIATION = 19,
-    PROPERTY_CO_OWNER = 20,
+    BANK_FEEDS = 4,
+    WORK_LOGBOOK = 5,
+    TRANSACTION_ALLOCATE = 6,
     SOLE_BUSINESS = 7,
-    SOLE_BUSINESSES = 33,
-    SOLE_VEHICLE_CLAIM = 12,
-    SOLE_HOME_OFFICE = 21,
-    SOLE_DEPRECIATION = 22,
-    SOLE_BANK_ACCOUNT = 23,
-    HOLDING_TRADE = 8,
-    HOLDING_INTEGRATION = 25,
-    HOLDING_REPORTS = 36,
-    BANK_CONNECTION = 4,
-    BANK_ACCOUNT = 26,
-    BANK_ALLOCATION = 6,
-    BANK_RULE = 27,
-    BANK_BORROWING_EXPENSE = 28
+    HOLDINGS = 8,
+    FIRM_DETAILS = 9,
+    INVITE_TEAM = 10,
+    INVITE_CLIENTS = 11
 }

package/src/lib/models/index.d.ts

@@ -29,4 +29,3 @@ export * from './firm';
 export * from './home-office';
 export * from './aussie';
 export * from './date-range';
-export * from './account-setup';

package/src/lib/models/user/user.d.ts

@@ -7,7 +7,7 @@ import { Phone } from '../phone/phone';
 import { ServiceSubscription } from '../service-subscription';
 import { SoleDetails } from '../sole';
 import { AppFile } from '../file';
-import { AccountSetupItem } from '../account-setup';
+import { AccountSetupItem } from '../account-setup/account-setup-item';
 import { TankTypeEnum } from '../../db/Enums/tank-type.enum';
 export declare class User extends BaseUser {
     subscriptions: ServiceSubscription[];

package/src/lib/services/account-setup/account-setup.service.d.ts

@@ -1,7 +1,8 @@
-import { Property, User } from '../../models';
-import { AllocationRuleService, BankAccountService, BankConnectionService, ClientInviteService, ClientMovementService, DepreciationService, EmployeeInviteService, EmployeeService, FirmService, HoldingTradeService, HomeOfficeClaimService, IncomeSourceService, LoanService, PropertyService, PropertyShareService, SharesightDetailsService, SoleBusinessService, TransactionAllocationService, TransactionService, UserService, VehicleClaimService } from '../http';
+import { BankAccountService, ClientInviteService, ClientMovementService, EmployeeInviteService, EmployeeService, FirmService, HoldingTradeService, IncomeSourceService, PropertyService, SoleBusinessService, TransactionAllocationService, TransactionService, UserService, VehicleClaimService } from '../http';
+import { User } from '../../models';
 import { AccountSetupItemCollection } from '../../collections';
 import { Observable } from 'rxjs';
+import { SetupItemTypeEnum } from '../../db/Enums/setup-item-type.enum';
 import { SetupItemService } from '../http/setup-item/setup-item.service';
 import * as i0 from "@angular/core";
 /**
@@ -12,15 +13,10 @@ export declare class AccountSetupService {
     private setupItemService;
     private propertyService;
     private incomeSourceService;
-    private bankConnectionService;
     private bankAccountsService;
-    private loanService;
-    private allocationRuleService;
     private transactionAllocationService;
     private vehicleClaimService;
-    private homeOfficeClaimService;
     private transactionService;
-    private depreciationService;
     private soleBusinessService;
     private holdingService;
     private userService;
@@ -29,46 +25,32 @@ export declare class AccountSetupService {
     private employeeService;
     private employeeInviteService;
     private firmService;
-    private sharesightDetailsService;
-    private propertyShareService;
     items: AccountSetupItemCollection;
     user: User;
-    constructor(setupItemService: SetupItemService, propertyService: PropertyService, incomeSourceService: IncomeSourceService, bankConnectionService: BankConnectionService, bankAccountsService: BankAccountService, loanService: LoanService, allocationRuleService: AllocationRuleService, transactionAllocationService: TransactionAllocationService, vehicleClaimService: VehicleClaimService, homeOfficeClaimService: HomeOfficeClaimService, transactionService: TransactionService, depreciationService: DepreciationService, soleBusinessService: SoleBusinessService, holdingService: HoldingTradeService, userService: UserService, clientMovementService: ClientMovementService, clientInviteService: ClientInviteService, employeeService: EmployeeService, employeeInviteService: EmployeeInviteService, firmService: FirmService, sharesightDetailsService: SharesightDetailsService, propertyShareService: PropertyShareService);
+    constructor(setupItemService: SetupItemService, propertyService: PropertyService, incomeSourceService: IncomeSourceService, bankAccountsService: BankAccountService, transactionAllocationService: TransactionAllocationService, vehicleClaimService: VehicleClaimService, transactionService: TransactionService, soleBusinessService: SoleBusinessService, holdingService: HoldingTradeService, userService: UserService, clientMovementService: ClientMovementService, clientInviteService: ClientInviteService, employeeService: EmployeeService, employeeInviteService: EmployeeInviteService, firmService: FirmService);
     /**
      * Get list of account setup items for current user/firm
      */
-    get(property?: Property): Observable<AccountSetupItemCollection>;
-    setItemsStatus(property?: Property): Observable<AccountSetupItemCollection>;
+    get(type: SetupItemTypeEnum): Observable<AccountSetupItemCollection>;
+    getClientItems$(): Observable<AccountSetupItemCollection>;
+    getFirmItems$(): Observable<AccountSetupItemCollection>;
     /**
      * Check and update isCompleted flag for passed item
      */
     private setItemStatus;
-    private getProperties;
-    private getTransactions;
-    private getCoOwners;
     /**
-     * AccountSetupItemsEnum.FIRM_CLIENTS completed when client invites sent or accepted
-     */
-    private getClients;
-    /**
-     * AccountSetupItemsEnum.FIRM_EMPLOYEES completed when employee invites sent or accepted
+     * @TODO Alex: work with collection when services refactored
+     * @TODO Vik: waiting for income sources refactoring
      */
-    private getEmployees;
+    private getIncomeSources;
     /**
-     * AccountSetupItemsEnum.FIRM_DETAILS when firm data filled
+     * Show logbook item when user has at least 1 vehicle transaction
      */
-    private getFirms;
+    private getLogbookItem;
     /**
-     * @TODO Alex: work with collection when services refactored
-     * @TODO Vik: waiting for income sources refactoring
+     * Hide bank feeds item when user has only holding tank
      */
-    private getIncomeSources;
-    private getVehicleClaims;
-    private getHomeOfficeClaims;
-    private getBankAccounts;
-    private getDepreciations;
-    private getSharesightDetails;
-    private getBorrowingExpenses;
+    private getBankFeedsItem;
     static ɵfac: i0.ɵɵFactoryDeclaration<AccountSetupService, never>;
     static ɵprov: i0.ɵɵInjectableDeclaration<AccountSetupService>;
 }

package/src/lib/services/http/firm/firm.service.d.ts

@@ -9,6 +9,10 @@ export declare class FirmService {
     firm: Firm;
     firmSubject: ReplaySubject<Firm>;
     constructor(http: HttpClient, environment: any);
+    /**
+     * Register new firm
+     * @param data: firm and firm owner data to register
+     */
     register(data: Firm): Observable<Firm>;
     get(): Observable<Firm>;
     update(firm: Firm): Observable<void>;

package/src/lib/services/http/loan/borrowing-expense/borrowing-expense.service.d.ts

@@ -2,7 +2,6 @@ import { Observable, ReplaySubject } from 'rxjs';
 import { HttpClient } from '@angular/common/http';
 import { BorrowingExpense } from '../../../../models/borrowing-expense/borrowing-expense';
 import { Loan } from '../../../../models/loan/loan';
-import { BorrowingExpenseLoan } from '../../../../models/borrowing-expense/borrowing-expense-loan';
 import * as i0 from "@angular/core";
 /**
  * @TODO Alex (TT-1777): Refactor with rest service
@@ -17,7 +16,7 @@ export declare class BorrowingExpenseService {
      * Get borrowing expenses
      */
     get(): Observable<BorrowingExpense[]>;
-    getLoanBorrowingExpenses(loan?: Loan): Observable<BorrowingExpenseLoan[]>;
+    getLoanBorrowingExpenses(loan?: Loan): Observable<any>;
     static ɵfac: i0.ɵɵFactoryDeclaration<BorrowingExpenseService, never>;
     static ɵprov: i0.ɵɵInjectableDeclaration<BorrowingExpenseService>;
 }

package/src/lib/services/http/rest/rest-old.service.d.ts

@@ -13,7 +13,6 @@ import * as i0 from "@angular/core";
  */
 export declare abstract class RestService<BaseModel, Model extends BaseModel> {
     protected environment: any;
-    private inFlight$?;
     protected toastService: ToastService;
     protected http: HttpClient;
     protected eventDispatcherService: EventDispatcherService;

package/src/lib/services/http/rest/rest.service.d.ts

@@ -19,7 +19,6 @@ import * as i0 from "@angular/core";
  */
 export declare abstract class RestService<BaseModel, Model extends AbstractModel, CollectionModel extends Collection<Model>> extends DataService<BaseModel, Model, CollectionModel> {
     protected environment: any;
-    private inFlight$?;
     /**
      * Url part for service entity API
      */

package/src/lib/services/http/setup-item/setup-item.service.d.ts

@@ -1,6 +1,6 @@
 import { AccountSetupItemCollection } from '../../../collections';
 import { SetupItem } from '../../../db/Models/setup-item';
-import { AccountSetupItem } from '../../../models';
+import { AccountSetupItem } from '../../../models/account-setup/account-setup-item';
 import { RestMethod, RestService } from '../rest';
 import * as i0 from "@angular/core";
 export declare class SetupItemService extends RestService<SetupItem, AccountSetupItem, AccountSetupItemCollection> {

package/src/lib/services/http/user/user.service.d.ts

@@ -35,7 +35,6 @@ export declare class UserService extends RestService<UserBase, User, Collection<
     updatePhoto(photo: FormData): Observable<void>;
     createBasiq(): Observable<string>;
     skipSetupItem(item: AccountSetupItem): Observable<User>;
-    restoreSetupItem(item: AccountSetupItem): Observable<User>;
     /**
      * Update cache when user's service subscription is updated
      */

package/src/lib/models/account-setup/account-setup-item-status.enum.d.ts

@@ -1,5 +0,0 @@
-export declare enum AccountSetupItemStatusEnum {
-    PENDING = 1,
-    ACHIEVED = 2,
-    SKIPPED = 3
-}

package/src/lib/models/account-setup/index.d.ts

@@ -1,3 +0,0 @@
-export * from './account-setup-item';
-export * from './account-setup-items.enum';
-export * from './account-setup-item-status.enum';