taxtank-core 0.33.5 → 0.33.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taxtank-core",
-  "version": "0.33.5",
+  "version": "0.33.7",
   "private": false,
   "peerDependencies": {
     "@angular/common": "^17.0.0",

package/src/lib/collections/bank-account.collection.d.ts

@@ -1,5 +1,4 @@
 import { Collection } from './collection';
-import { BankAccountTypeEnum } from '../db/Enums';
 import { TankTypeEnum } from '../db/Enums/tank-type.enum';
 import { BankAccount, BankAccountProperty, Property } from '../models';
 import { CollectionDictionary } from './collection-dictionary';
@@ -8,14 +7,6 @@ import { LoanCollection } from './loan';
  * Collection of bank accounts.
  */
 export declare class BankAccountCollection extends Collection<BankAccount> {
-    /**
-     * get list of bank accounts with passed types
-     */
-    getByType(types: BankAccountTypeEnum | BankAccountTypeEnum[], isExclude?: boolean): BankAccount[];
-    /**
-     * get amount of current loans
-     */
-    getCurrentLoanAmount(): number;
     /**
      * get collection filtered by property id
      */
@@ -30,23 +21,12 @@ export declare class BankAccountCollection extends Collection<BankAccount> {
      * get collection of active bank accounts
      */
     getActive(): BankAccountCollection;
-    /**
-     * Get collection of loan bank accounts
-     */
     getLoanAccounts(): BankAccountCollection;
+    getDebitAccounts(): BankAccountCollection;
     get loans(): LoanCollection;
-    getSavingsAccounts(): BankAccountCollection;
     getOpeningBalance(): number;
     get currentBalance(): number;
     get bankShortNames(): string;
-    /**
-     * Get Collection of bank accounts with property tank type
-     */
-    getPropertyBankAccounts(): BankAccountCollection;
-    /**
-     * Get Collection of bank accounts with work tank type
-     */
-    getWorkBankAccounts(): BankAccountCollection;
     /**
      * Get Collection of bank accounts by tank type
      */

package/src/lib/collections/collection-dictionary.d.ts

@@ -4,7 +4,7 @@ import { AbstractModel } from '../db/Models';
  * @TODO refactor with Map
  * List of collections grouped by passed property
  */
-export declare class CollectionDictionary<Collection extends BaseCollection<AbstractModel>> {
+export declare class CollectionDictionary<Collection extends BaseCollection<object>> {
     /**
      * List of grouped collections
      */

package/src/lib/collections/collection.d.ts

@@ -1,10 +1,9 @@
 import { CollectionDictionary } from './collection-dictionary';
-import { AbstractModel } from '../db/Models';
 import { Dictionary, FinancialYear } from '../models';
 /**
  * Base collection class. Contains common properties and methods for all collections
  */
-export declare class Collection<Model extends AbstractModel> implements Iterable<Model> {
+export declare class Collection<Model extends object> implements Iterable<Model> {
     items: Model[];
     /**
      * index of current item, used to iterate over the collection
@@ -47,13 +46,13 @@ export declare class Collection<Model extends AbstractModel> implements Iterable
      * @TODO performance check this.create performance and why we do it instead of changing collection
      */
     unshift(...items: Model[]): this;
-    remove(...items: Model[]): this;
+    remove(items: Model[], path?: string): this;
     /**
      * @TODO it's filter, not remove
      */
     removeBy(path: string, values: any): this;
     replaceBy(path: string, value: any, item: Model): this;
-    diff(items: Model[]): this;
+    diff(items: Model[], path?: string): this;
     minBy(path: string): Model;
     maxBy(path: string): Model;
     /**

package/src/lib/collections/depreciation.collection.d.ts

@@ -7,7 +7,7 @@ import { ChartAccountsCategoryEnum } from '../db/Enums';
 import { VehicleClaim } from '../models';
 export declare class DepreciationCollection extends Collection<Depreciation> {
     getSoleDepreciations(): this;
-    getNew(): this;
+    getCurrentYearBuy(): this;
     /**
      * Get total amount of all depreciations in the collection
      */

package/src/lib/collections/property/property.collection.d.ts

@@ -20,7 +20,7 @@ export declare class PropertyCollection extends Collection<Property> {
     get purchasePrice(): number;
     get growthPercent(): number;
     get marketValue(): number;
-    get marketValueGrowth(): number;
+    get sharedMarketValue(): number;
     /**
      * Get list of unique property categories from collection
      */

package/src/lib/db/Enums/bank/bank-account-type.enum.d.ts

@@ -2,6 +2,7 @@ export declare enum BankAccountTypeEnum {
     TRANSACTION = 1,
     SAVINGS = 2,
     CREDIT_CARD = 3,
+    MORTGAGE = 4,
     LOAN = 5,
     INVESTMENT = 6,
     TERM_DEPOSIT = 7,

package/src/lib/db/Models/bank/bank-account.d.ts

@@ -16,7 +16,6 @@ export declare class BankAccount extends ObservableModel {
     accountNumber?: string;
     currentBalance?: number;
     currency?: string;
-    isManual?: boolean;
     migrateFrom?: Date;
     migrateTo?: Date;
     lastTransactionDate?: Date;

package/src/lib/db/Models/transaction/transaction-base.d.ts

@@ -25,17 +25,8 @@ export declare abstract class TransactionBase extends ObservableModel {
      * @TODO remove when AllocateForm is refactored and not merging with Transaction class which cause the issue
      */
     set tankType(tankType: TankTypeEnum);
-    /**
-     * Check if current tank is Property
-     */
     isPropertyTank(): boolean;
-    /**
-     * Check if current tank is Work
-     */
     isWorkTank(): boolean;
-    /**
-     * Check if current tank is Sole
-     */
     isSoleTank(): boolean;
     isHoldingTank(): boolean;
     isOtherTank(): boolean;

package/src/lib/models/bank/bank-account.d.ts

@@ -92,4 +92,5 @@ export declare class BankAccount extends BankAccountBase {
      * Loan is paid if it has no unallocated transactions and the bank balance is $0.
      */
     isLoanPaid(taxTankBalance: number): boolean;
+    isManual(): boolean;
 }

package/src/lib/models/bank/type-loan.const.d.ts

@@ -1,5 +1,2 @@
 import { BankAccountTypeEnum } from '../../db/Enums';
-/**
- * @TODO credit card has nothing to do with loan
- */
 export declare const TYPE_LOAN: BankAccountTypeEnum[];

package/src/lib/models/depreciation/depreciation.d.ts

@@ -10,8 +10,8 @@ import { Expense } from '../../interfaces';
  * @TODO Alex: clarify grouping rules and refactor
  */
 export declare class Depreciation extends DepreciationBase implements Expense {
-    static WRITTEN_OFF_THRESHOLD: number;
-    static LOW_VALUE_POOL_THRESHOLD: number;
+    static writtenOffThreshold: number;
+    static lowValuePoolThreshold: number;
     purchaseDate: Date;
     date: Date;
     lowValuePoolDate: Date;
@@ -22,9 +22,6 @@ export declare class Depreciation extends DepreciationBase implements Expense {
     chartAccounts: ChartAccounts;
     bankTransaction: BankTransaction;
     type: DepreciationTypeEnum;
-    /**
-     * @TODO remove after ? signs removed from db models
-     */
     amount: number;
     isCapital(): boolean;
     isBorrowingExpense(): boolean;
@@ -41,10 +38,6 @@ export declare class Depreciation extends DepreciationBase implements Expense {
      * Check if depreciation chart accounts heading related to vehicles category
      */
     isVehicleDepreciation(): boolean;
-    /**
-     * Get depreciation purchase date
-     */
-    getDate(): Date;
     /**
      * @TODO Vik: Research a problem with depreciations without current year forecast
      */
@@ -52,7 +45,6 @@ export declare class Depreciation extends DepreciationBase implements Expense {
     getForecastByYear(year: number): DepreciationForecast;
     getClaimAmountByYear(year: number): number;
     getCloseBalanceByYear(year: number): number;
-    isBuildingAtCost(): boolean;
     /**
      * Create a new transaction from current depreciation
      */
@@ -66,5 +58,5 @@ export declare class Depreciation extends DepreciationBase implements Expense {
     /**
      * assets purchased in the current financial year
      */
-    isNew(): boolean;
+    isCurrentYearBuy(): boolean;
 }

package/src/lib/models/property/property.d.ts

@@ -49,7 +49,6 @@ export declare class Property extends PropertyBase {
     get forecastedRentalReturn(): number;
     get forecastedTaxPosition(): number;
     get forecastedCashPosition(): number;
-    get marketValueGrowth(): number;
     get myShare(): PropertyShare;
     get claimPercent(): number;
     get claimCoefficient(): number;

package/src/lib/models/report/index.d.ts

@@ -3,3 +3,5 @@ export * from './my-tax';
 export * from './property';
 export * from './sole';
 export * from './vehicle-expense/vehicle-expense';
+export * from './report.interface';
+export * from './reports.const';

package/src/lib/models/report/report.interface.d.ts

@@ -0,0 +1,7 @@
+import { UserRolesEnum } from 'taxtank-core/common';
+export interface IReport {
+    title: string;
+    description: string;
+    route: string;
+    roles: UserRolesEnum[];
+}

package/src/lib/models/report/reports.const.d.ts

@@ -0,0 +1,3 @@
+import { IReport } from './report.interface';
+import { Collection } from '../../collections';
+export declare const REPORTS: Collection<IReport>;

package/src/lib/models/transaction/transaction.d.ts

@@ -1,5 +1,5 @@
 import { Transaction as TransactionBase } from '../../db/Models/transaction/transaction';
-import { ChartAccountsCategoryEnum, ChartAccountsMetaFieldListEnum } from '../../db/Enums';
+import { ChartAccountsMetaFieldListEnum } from '../../db/Enums';
 import { TransactionOperationEnum } from '../../db/Enums/transaction-operation.enum';
 import { Property } from '../property';
 import { ChartAccounts } from '../chart-accounts';
@@ -43,11 +43,6 @@ export declare class Transaction extends TransactionBase implements Expense {
     isExpense(): boolean;
     isPersonal(): boolean;
     isInterest(): boolean;
-    get chartAccountsCategories(): ChartAccountsCategoryEnum[];
-    /**
-     * Get transaction date
-     */
-    getDate(): Date;
     /**
      * Check if transaction type is vehicle
      */

package/src/lib/services/http/transaction/transaction.service.d.ts

@@ -69,12 +69,6 @@ export declare class TransactionService extends RestService<TransactionBase, Tra
      * @param model
      */
     delete(model: Transaction): Observable<void>;
-    /**
-     * @TODO Alex wrong place for this logic, move to model
-     * calculate gross income amount based on transaction amount and taxes (fees)
-     * @param transaction Transaction instance for calculation
-     */
-    calculateGrossAmount(transaction: Transaction): number;
     /**
      * Listen to EventDispatcherService event related to Depreciation changing
      */