taxtank-core 0.32.41 → 0.32.44

package/fesm2022/taxtank-core.mjs

@@ -22,6 +22,7 @@ import uniq from 'lodash/uniq';
 import moment from 'moment';
 import { DateRange } from 'moment-range';
 import merge from 'lodash/merge';
+import ceil from 'lodash/ceil';
 import range from 'lodash/range';
 import { Validators, UntypedFormGroup, UntypedFormControl, UntypedFormArray, FormControl, FormArray, FormGroup } from '@angular/forms';
 import compact from 'lodash/compact';
@@ -3150,6 +3151,32 @@ var ChartAccountsValues = [
 		unitOfMeasure: "hours",
 		createdAt: "2024-01-30 15:15:00",
 		updatedAt: "2024-01-30 15:15:00"
+	},
+	{
+		id: 54,
+		chartAccounts: {
+			id: 888
+		},
+		financialYear: 2023,
+		startDate: null,
+		endDate: null,
+		value: 0.67,
+		unitOfMeasure: "hours",
+		createdAt: "2024-01-30 15:15:00",
+		updatedAt: "2024-01-30 15:15:00"
+	},
+	{
+		id: 55,
+		chartAccounts: {
+			id: 888
+		},
+		financialYear: 2024,
+		startDate: null,
+		endDate: null,
+		value: 0.67,
+		unitOfMeasure: "hours",
+		createdAt: "2024-01-30 15:15:00",
+		updatedAt: "2024-01-30 15:15:00"
 	}
 ];
 
@@ -4817,7 +4844,8 @@ class SoleInvoice extends SoleInvoice$1 {
      */
     get netPrice() {
         if (this.isTaxInclusive()) {
-            return this.price - this.GSTAmount;
+            // round up to make sure invoice is fully paid
+            return ceil(this.price - this.GSTAmount, 2);
         }
         return this.price;
     }
@@ -4826,7 +4854,8 @@ class SoleInvoice extends SoleInvoice$1 {
      */
     get grossPrice() {
         if (this.isTaxExclusive()) {
-            return this.price + this.GSTAmount;
+            // round up to make sure invoice is fully paid
+            return ceil(this.price + this.GSTAmount, 2);
         }
         return this.price;
     }
@@ -4847,13 +4876,13 @@ class SoleInvoice extends SoleInvoice$1 {
      * When tax inclusive, GST amount is included to total price
      */
     get inclusiveGSTAmount() {
-        return this.itemsCollection.gstItems.reduce((sum, item) => sum + round(item.totalPrice - (item.totalPrice / (1 + ChartAccounts.GSTRatio)), 2));
+        return this.itemsCollection.gstItems.reduce((sum, item) => sum + item.totalPrice - (item.totalPrice / (1 + ChartAccounts.GSTRatio)));
     }
     /**
      * When tax exclusive, GST amount should be added additionally to total price
      */
     get exclusiveGSTAmount() {
-        return this.itemsCollection.gstItems.reduce((sum, item) => sum + round(item.totalPrice * ChartAccounts.GSTRatio, 2));
+        return this.itemsCollection.gstItems.reduce((sum, item) => sum + item.totalPrice * ChartAccounts.GSTRatio);
     }
     isDraft() {
         return this.status === SoleInvoiceStatusesEnum.DRAFT;
@@ -5513,6 +5542,24 @@ __decorate([
     Type(() => AppFile)
 ], PropertyDocument.prototype, "file", void 0);
 
+class PropertyCategoryMovement extends PropertyCategoryMovement$1 {
+}
+__decorate([
+    Type(() => PropertyValuation)
+], PropertyCategoryMovement.prototype, "valuation", void 0);
+__decorate([
+    Type(() => PropertyCategory)
+], PropertyCategoryMovement.prototype, "propertyCategory", void 0);
+__decorate([
+    Type(() => Property)
+], PropertyCategoryMovement.prototype, "property", void 0);
+__decorate([
+    Type(() => Date)
+], PropertyCategoryMovement.prototype, "fromDate", void 0);
+__decorate([
+    Type(() => Date)
+], PropertyCategoryMovement.prototype, "toDate", void 0);
+
 class PropertyValuation extends PropertyValuation$1 {
     get financialYear() {
         return new FinancialYear(this.date).year;
@@ -5527,6 +5574,9 @@ __decorate([
 __decorate([
     Type(() => PropertyDocument)
 ], PropertyValuation.prototype, "document", void 0);
+__decorate([
+    Type(() => PropertyCategoryMovement)
+], PropertyValuation.prototype, "categoryMovement", void 0);
 
 class PropertyForecast extends PropertyForecast$1 {
     constructor() {
@@ -5580,24 +5630,6 @@ __decorate([
     Transform(({ value }) => +value)
 ], PropertyForecast.prototype, "marketValue", void 0);
 
-class PropertyCategoryMovement extends PropertyCategoryMovement$1 {
-}
-__decorate([
-    Type(() => PropertyValuation)
-], PropertyCategoryMovement.prototype, "valuation", void 0);
-__decorate([
-    Type(() => PropertyCategory)
-], PropertyCategoryMovement.prototype, "propertyCategory", void 0);
-__decorate([
-    Type(() => Property)
-], PropertyCategoryMovement.prototype, "property", void 0);
-__decorate([
-    Type(() => Date)
-], PropertyCategoryMovement.prototype, "fromDate", void 0);
-__decorate([
-    Type(() => Date)
-], PropertyCategoryMovement.prototype, "toDate", void 0);
-
 /**
  * propertySale docs - https://taxtank.atlassian.net/wiki/spaces/TAXTANK/pages/4209508353/Property+Sold+button
  */
@@ -6213,75 +6245,6 @@ __decorate([
     Type(() => ChartAccountsMetaField)
 ], TransactionMetaField.prototype, "chartAccountsMetaField", void 0);
 
-class BankTransaction extends BankTransaction$1 {
-    constructor() {
-        super(...arguments);
-        // allocated money amount for bank transaction
-        this.allocatedAmount = 0;
-    }
-    /**
-     * get allocated amount value but with +/- sign
-     */
-    get balanceAmount() {
-        return this.isCredit() ? this.allocatedAmount : -this.allocatedAmount;
-    }
-    /**
-     * check if bank transaction is debit
-     */
-    isDebit() {
-        return this.type === BankTransactionTypeEnum.DEBIT;
-    }
-    /**
-     * check if bank transaction is credit
-     */
-    isCredit() {
-        return this.type === BankTransactionTypeEnum.CREDIT;
-    }
-    /**
-     * Create Transaction instance based on Bank Transaction
-     */
-    toTransaction(isGST = false, allocations = new TransactionAllocationCollection([])) {
-        const transaction = plainToClass(Transaction, {
-            amount: this.getUnallocatedAmount(allocations),
-            description: this.description,
-            type: this.type,
-            date: this.date,
-            source: TransactionSourceEnum.BANK_TRANSACTION,
-            operation: this.operation,
-            isGST: isGST,
-        });
-        // gst should be included
-        if (isGST) {
-            transaction.amount = transaction.amount / ChartAccounts.GSTCoefficient;
-        }
-        return transaction;
-    }
-    /**
-     * Check if bank transaction is completely allocated
-     */
-    isAllocated(allocations) {
-        return (Math.abs(this.amount) - Math.abs(this.getAllocatedAmount(allocations))) <= 0.02;
-    }
-    /**
-     * Get bank transaction allocated amount
-     */
-    getAllocatedAmount(allocations) {
-        return allocations.getByBankTransactionsIds([this.id]).amount;
-    }
-    /**
-     * Get bank transaction unallocated amount
-     */
-    getUnallocatedAmount(allocations) {
-        return this.amount - this.getAllocatedAmount(allocations);
-    }
-}
-__decorate([
-    Type(() => Date)
-], BankTransaction.prototype, "date", void 0);
-__decorate([
-    Type(() => Number)
-], BankTransaction.prototype, "amount", void 0);
-
 class TransactionAllocation extends TransactionAllocation$1 {
     /**
      * Create a new instance of transaction allocation
@@ -6440,7 +6403,7 @@ class Transaction extends Transaction$1 {
      * Check if transaction is completely allocated
      */
     isAllocated(allocations) {
-        return (Math.abs(this.netAmount) - Math.abs(this.getAllocatedAmount(allocations))) <= 0.02;
+        return Math.abs(this.getAllocatedAmount(allocations)) - Math.abs(this.netAmount) >= 0;
     }
     getAllocatedAmount(allocations) {
         return allocations.filterBy('transaction.id', this.id).sumBy('amount');
@@ -8747,10 +8710,11 @@ class BankAccountCollection extends Collection {
         return new BankAccountCollection(this.items.filter((bankAccount) => bankAccount.bankAccountProperties.find((bankAccountProperty) => ids.includes(bankAccountProperty.property.id))));
     }
     /**
+     * @TODO feature functionality allow to work with shared accounts
      * get collection of active bank accounts
      */
-    getActiveBankAccounts() {
-        return new BankAccountCollection(this.items.filter((bankAccount) => bankAccount.isActive()));
+    getActive() {
+        return this.getOwn().filter((bankAccount) => bankAccount.isActive());
     }
     /**
      * get reduction of loan (reduction of principle) percentage
@@ -8846,17 +8810,12 @@ class BankAccountCollection extends Collection {
     }
     /**
      * @TODO Alex/Vik: maybe we should get it from jwtToken or think about some localStorageService?
-     * get own bankAccounts active for current financial year
      */
     getOwn() {
-        return this.filter((bankAccount) => {
-            const commencementDate = bankAccount.loan?.commencementDate;
-            const endDate = new FinancialYear().endDate;
-            return bankAccount.isOwner(+localStorage.getItem('userId')) && (!commencementDate || commencementDate <= endDate);
-        });
+        return this.filter((bankAccount) => bankAccount.isOwner(+localStorage.getItem('userId')));
     }
     getActiveLoanAccountsByProperties(ids) {
-        return this.getActiveBankAccounts().getLoanAccounts().getByPropertiesIds(ids);
+        return this.getActive().getLoanAccounts().getByPropertiesIds(ids);
     }
 }
 
@@ -8878,7 +8837,7 @@ class BankTransactionCollection extends Collection {
      * Difference between total bank transactions amount and sum of allocations for passed bank transactions
      */
     getUnallocatedAmount(allocations) {
-        return round(this.getAmount() - allocations.getByBankTransactionsIds(this.getIds()).amount, 2);
+        return this.getAmount() - allocations.getByBankTransactionsIds(this.getIds()).amount;
     }
     getAllocatedAmount(allocations) {
         return allocations.getByBankTransactionsIds(this.getIds()).amount;
@@ -9663,10 +9622,12 @@ class BankAccount extends BankAccount$1 {
         return this.loan ? this.loan.monthlyRepaymentAmount * this.getPropertyPercentage(propertyId) : 0;
     }
     /**
-     * Check if bank account is active (has 'active' status or hasn't been paid out/refinanced)
+     * Check if bank account is active for current financial year (has 'active' status or hasn't been paid out/refinanced)
      */
     isActive() {
-        return this.status === BankAccountStatusEnum.ACTIVE;
+        const commencementDate = this.loan?.commencementDate;
+        const endDate = new FinancialYear().endDate;
+        return this.status === BankAccountStatusEnum.ACTIVE && (!commencementDate || commencementDate <= endDate);
     }
     /**
      * first import (transactions) of basiq accounts
@@ -9755,6 +9716,75 @@ const BANK_ACCOUNT_TYPES = [
     { key: BankAccountTypeEnum.TRANSACTION, value: 'Transaction Accounts' },
 ];
 
+class BankTransaction extends BankTransaction$1 {
+    constructor() {
+        super(...arguments);
+        // allocated money amount for bank transaction
+        this.allocatedAmount = 0;
+    }
+    /**
+     * get allocated amount value but with +/- sign
+     */
+    get balanceAmount() {
+        return this.isCredit() ? this.allocatedAmount : -this.allocatedAmount;
+    }
+    /**
+     * check if bank transaction is debit
+     */
+    isDebit() {
+        return this.type === BankTransactionTypeEnum.DEBIT;
+    }
+    /**
+     * check if bank transaction is credit
+     */
+    isCredit() {
+        return this.type === BankTransactionTypeEnum.CREDIT;
+    }
+    /**
+     * Create Transaction instance based on Bank Transaction
+     */
+    toTransaction(isGST = false, allocations = new TransactionAllocationCollection([])) {
+        const transaction = plainToClass(Transaction, {
+            amount: this.getUnallocatedAmount(allocations),
+            description: this.description,
+            type: this.type,
+            date: this.date,
+            source: TransactionSourceEnum.BANK_TRANSACTION,
+            operation: this.operation,
+            isGST: isGST,
+        });
+        // gst should be included
+        if (isGST) {
+            transaction.amount = transaction.amount / ChartAccounts.GSTCoefficient;
+        }
+        return transaction;
+    }
+    /**
+     * Check if bank transaction is completely allocated
+     */
+    isAllocated(allocations) {
+        return Math.abs(this.getAllocatedAmount(allocations)) - Math.abs(this.amount) >= 0;
+    }
+    /**
+     * Get bank transaction allocated amount
+     */
+    getAllocatedAmount(allocations) {
+        return allocations.getByBankTransactionsIds([this.id]).amount;
+    }
+    /**
+     * Get bank transaction unallocated amount
+     */
+    getUnallocatedAmount(allocations) {
+        return this.amount - this.getAllocatedAmount(allocations);
+    }
+}
+__decorate([
+    Type(() => Date)
+], BankTransaction.prototype, "date", void 0);
+__decorate([
+    Type(() => Number)
+], BankTransaction.prototype, "amount", void 0);
+
 /**
  * bank transactions collection UI class with frontend specific data
  */
@@ -11083,6 +11113,9 @@ class BankAccountService extends RestService$1 {
         this.disabledMethods = ['post', 'putBatch', 'delete', 'deleteBatch'];
         this.listenEvents();
     }
+    getActive() {
+        return this.getBy('status', BankAccountStatusEnum.ACTIVE);
+    }
     /**
      * Listen system notifications and update cache when got basiq notification received
      */
@@ -15694,17 +15727,6 @@ var HoldingImportMessagesEnum;
 })(HoldingImportMessagesEnum || (HoldingImportMessagesEnum = {}));
 
 var HoldingTypeExchanges = [
-	{
-		id: 1,
-		code: "US",
-		name: "NYSE",
-		currency: "USD",
-		close_time: "16:00",
-		timezone: "America/New_York",
-		exchange_updated_at: "2023-04-21 11:54:56",
-		min_market_cap: 100000000,
-		min_avg_volume50d: 1000000
-	},
 	{
 		id: 2,
 		code: "AU",
@@ -15716,6 +15738,17 @@ var HoldingTypeExchanges = [
 		min_market_cap: 10000000,
 		min_avg_volume50d: 10000
 	},
+	{
+		id: 1,
+		code: "US",
+		name: "NYSE",
+		currency: "USD",
+		close_time: "16:00",
+		timezone: "America/New_York",
+		exchange_updated_at: "2023-04-21 11:54:56",
+		min_market_cap: 100000000,
+		min_avg_volume50d: 1000000
+	},
 	{
 		id: 3,
 		code: "LSE",