taxtank-core 0.28.66 → 0.28.68

package/lib/forms/address/address.form.d.ts

@@ -16,6 +16,10 @@ export declare class AddressForm extends AbstractForm<Address> implements IEvent
      * Delay before corelogic request
      */
     static searchDelay: number;
+    /**
+     * Regarding corelogic formatting, street number should not contain spaces
+     */
+    static streetNumberPattern: RegExp;
     /**
      * Manual mode flag
      */
@@ -55,4 +59,11 @@ export declare class AddressForm extends AbstractForm<Address> implements IEvent
      * When corelogic is required we have to search address even for manual address
      */
     private listenManualFieldsChanges;
+    /**
+     * Address model has common field 'address' for street name and number because Corelogic returns this data as one string,
+     * but we need separated fields in the form.
+     *
+     * Listen street and number changes and fill address with concatinated values
+     */
+    private listenStreetFieldsChanges;
 }

package/lib/models/address/address.d.ts

@@ -6,6 +6,22 @@ export declare class Address extends AddressBase {
     suggestion: string;
     type: AddressTypeEnum;
     toString(): string;
+    /**
+     * Short address string
+     * 12/23 Jackson avenue
+     */
     get name(): string;
+    /**
+     * Full address string in corelogic format
+     * 12/23 Jackson avenue Sydney QLD 1212
+     */
     get nameLong(): string;
+    /**
+     * Street number may contain digits, letters, symbols '/' and '-', but not spaces
+     */
+    get streetNumber(): string;
+    /**
+     * Street name without number
+     */
+    get street(): string;
 }

package/lib/models/address/index.d.ts

@@ -0,0 +1,3 @@
+export * from './address';
+export * from './country';
+export * from './states.enum';

package/lib/models/address/states.enum.d.ts

@@ -0,0 +1,10 @@
+export declare enum StatesEnum {
+    ACT = "ACT (The Australian Capital Territory)",
+    NSW = "NSW (New South Wales)",
+    NT = "NT (Northern Territory)",
+    SA = "SA (South Australia)",
+    TAS = "TAS (Tasmania)",
+    VIC = "VIC (Victoria)",
+    QLD = "QLD (Queensland)",
+    WA = "WA (Western Australia)"
+}

package/lib/models/bank/bank-login-data.d.ts

@@ -2,6 +2,10 @@
  * Login data object for basiq banks
  */
 export declare class BankLoginData {
+    /**
+     * External id of bankConnection is using for reconnect existing bank connection
+     */
+    id?: string;
     /**
      * Object with bank external id
      */

package/lib/models/bank/basiq/basiq-connection-data.interface.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Interface contains data required for Basiq API.
+ * Used for connect/reconnect banks
+ */
+export interface BasiqConnectionData {
+    jobId: string;
+    connectionId?: string;
+}

package/lib/models/bank/basiq/basiq-job-response.d.ts

@@ -1,5 +1,6 @@
 import { BasiqJobStep } from './basiq-job-step';
 export declare class BasiqJobResponse {
+    id: string;
     steps: BasiqJobStep[];
     getVerifyCredentialsStep(): BasiqJobStep;
 }

package/lib/models/bank/basiq/index.d.ts

@@ -1,4 +1,5 @@
 export * from './basiq-config';
+export * from './basiq-connection-data.interface';
 export * from './basiq-connections-response.interface';
 export * from './basiq-job';
 export * from './basiq-job-response';

package/lib/models/event/app-event-type.enum.d.ts

@@ -9,62 +9,63 @@ export declare enum AppEventTypeEnum {
     BASIQ_CONSENT_UPDATED = 7,
     BASIQ_CONNECTION_UPDATED = 8,
     BASIQ_JOB_CREATED = 9,
-    BASIQ_LOGIN_FINISHED = 10,
-    CLIENT_INVITE_ACCEPTED = 11,
-    CLIENT_OPEN_CHAT = 12,
-    CLIENT_TRANSFER_TO_OTHER_EMPLOYEE = 13,
-    CURRENT_USER_GET_FAILED = 14,
-    DEPRECIATION_DELETED = 15,
-    DEPRECIATIONS_CREATED = 16,
-    DEPRECIATION_UPDATED_WITH_RECEIPT = 17,
-    DEPRECIATION_UPDATED_WITH_DELETED_RECEIPT = 18,
-    DEPRECIATION_RECEIPT_CREATED = 19,
-    DEPRECIATION_RECEIPT_DELETED = 20,
-    INCOME_SOURCES_CREATED = 21,
-    INCOME_SOURCES_UPDATED = 22,
-    INCOME_SOURCES_FORECASTS_CREATED = 23,
-    INCOME_SOURCES_FORECASTS_UPDATED = 24,
-    LOAN_UPDATED = 25,
-    LOAN_PAYOUT_UPDATED = 26,
-    MESSAGE_CREATED = 27,
-    MESSAGE_FILE_CREATED = 28,
-    MESSAGE_FILE_DELETED = 29,
-    NOTIFICATION_ADDED = 30,
-    PROPERTY_DEPRECIATION_CALCULATION_UPDATED = 31,
-    PROPERTY_UPDATED = 32,
-    PROPERTY_UPDATED_WITH_DOCUMENT = 33,
-    PROPERTY_DOCUMENT_ADDED = 34,
-    PROPERTY_MOVEMENT_CREATED = 35,
-    PROPERTY_MOVEMENT_UPDATED = 36,
-    PROPERTY_MOVEMENT_DELETED = 37,
-    PROPERTY_SHARE_UPDATED = 38,
-    PROPERTY_SALE_ADDED = 39,
-    PROPERTY_SALE_DELETED = 40,
-    PROPERTY_SUBSCRIPTION_ADDED = 41,
-    PROPERTY_SUBSCRIPTION_DELETED = 42,
-    PROPERTY_VALUATION_DOCUMENT_CREATED = 43,
-    SERVICE_SUBSCRIPTION_UPDATED = 44,
-    SOLE_BUSINESS_CREATED = 45,
-    SOLE_DEPRECIATION_METHOD_UPDATED = 46,
-    SOLE_DETAILS_CREATED = 47,
-    SOLE_DETAILS_UPDATED = 48,
-    SOLE_INVOICE_PUBLISHED = 49,
-    TAX_REVIEW_UPDATED = 50,
-    TRANSACTION_CREATED = 51,
-    TRANSACTION_DELETED = 52,
-    TRANSACTION_UPDATED = 53,
-    TRANSACTION_UPDATED_WITH_RECEIPT = 54,
-    TRANSACTION_UPDATED_WITH_DELETED_RECEIPT = 55,
-    TRANSACTION_RECEIPT_CREATED = 56,
-    TRANSACTION_RECEIPT_DELETED = 57,
-    TRANSACTIONS_CREATED = 58,
-    USER_UPDATED = 59,
-    VEHICLE_CLAIM_UPDATED = 60,
-    VEHICLE_CLAIM_CREATED = 61,
-    VEHICLE_CLAIM_DETAILS_UPDATED = 62,
-    VEHICLE_CLAIM_DETAILS_CREATED = 63,
-    VEHICLE_LOGBOOK_CREATED = 64,
-    VEHICLE_LOGBOOK_UPDATED = 65,
-    VEHICLE_LOGBOOK_DELETED = 66,
-    VEHICLE_LOGBOOK_BEST_PERIOD_UPDATED = 67
+    BASIQ_LOGIN_SUCCESS = 10,
+    BASIQ_LOGIN_FAILED = 11,
+    CLIENT_INVITE_ACCEPTED = 12,
+    CLIENT_OPEN_CHAT = 13,
+    CLIENT_TRANSFER_TO_OTHER_EMPLOYEE = 14,
+    CURRENT_USER_GET_FAILED = 15,
+    DEPRECIATION_DELETED = 16,
+    DEPRECIATIONS_CREATED = 17,
+    DEPRECIATION_UPDATED_WITH_RECEIPT = 18,
+    DEPRECIATION_UPDATED_WITH_DELETED_RECEIPT = 19,
+    DEPRECIATION_RECEIPT_CREATED = 20,
+    DEPRECIATION_RECEIPT_DELETED = 21,
+    INCOME_SOURCES_CREATED = 22,
+    INCOME_SOURCES_UPDATED = 23,
+    INCOME_SOURCES_FORECASTS_CREATED = 24,
+    INCOME_SOURCES_FORECASTS_UPDATED = 25,
+    LOAN_UPDATED = 26,
+    LOAN_PAYOUT_UPDATED = 27,
+    MESSAGE_CREATED = 28,
+    MESSAGE_FILE_CREATED = 29,
+    MESSAGE_FILE_DELETED = 30,
+    NOTIFICATION_ADDED = 31,
+    PROPERTY_DEPRECIATION_CALCULATION_UPDATED = 32,
+    PROPERTY_UPDATED = 33,
+    PROPERTY_UPDATED_WITH_DOCUMENT = 34,
+    PROPERTY_DOCUMENT_ADDED = 35,
+    PROPERTY_MOVEMENT_CREATED = 36,
+    PROPERTY_MOVEMENT_UPDATED = 37,
+    PROPERTY_MOVEMENT_DELETED = 38,
+    PROPERTY_SHARE_UPDATED = 39,
+    PROPERTY_SALE_ADDED = 40,
+    PROPERTY_SALE_DELETED = 41,
+    PROPERTY_SUBSCRIPTION_ADDED = 42,
+    PROPERTY_SUBSCRIPTION_DELETED = 43,
+    PROPERTY_VALUATION_DOCUMENT_CREATED = 44,
+    SERVICE_SUBSCRIPTION_UPDATED = 45,
+    SOLE_BUSINESS_CREATED = 46,
+    SOLE_DEPRECIATION_METHOD_UPDATED = 47,
+    SOLE_DETAILS_CREATED = 48,
+    SOLE_DETAILS_UPDATED = 49,
+    SOLE_INVOICE_PUBLISHED = 50,
+    TAX_REVIEW_UPDATED = 51,
+    TRANSACTION_CREATED = 52,
+    TRANSACTION_DELETED = 53,
+    TRANSACTION_UPDATED = 54,
+    TRANSACTION_UPDATED_WITH_RECEIPT = 55,
+    TRANSACTION_UPDATED_WITH_DELETED_RECEIPT = 56,
+    TRANSACTION_RECEIPT_CREATED = 57,
+    TRANSACTION_RECEIPT_DELETED = 58,
+    TRANSACTIONS_CREATED = 59,
+    USER_UPDATED = 60,
+    VEHICLE_CLAIM_UPDATED = 61,
+    VEHICLE_CLAIM_CREATED = 62,
+    VEHICLE_CLAIM_DETAILS_UPDATED = 63,
+    VEHICLE_CLAIM_DETAILS_CREATED = 64,
+    VEHICLE_LOGBOOK_CREATED = 65,
+    VEHICLE_LOGBOOK_UPDATED = 66,
+    VEHICLE_LOGBOOK_DELETED = 67,
+    VEHICLE_LOGBOOK_BEST_PERIOD_UPDATED = 68
 }

package/lib/models/index.d.ts

@@ -1,3 +1,4 @@
+export * from './address';
 export * from './bank';
 export * from './sole';
 export * from './vehicle';

package/lib/services/http/bank/bank-connection/bank-connection.service.d.ts

@@ -20,6 +20,9 @@ export declare class BankConnectionService extends RestService<BankConnectionBas
      * Update cache when basiq accounts were retrieved or login to basic was failed to get actual connections statuses
      */
     listenNotifications(): void;
+    /**
+     * Create/reconnect bank connection when user successfully logged in to basiq
+     */
     listenBasiqLogin(): void;
     static ɵfac: i0.ɵɵFactoryDeclaration<BankConnectionService, never>;
     static ɵprov: i0.ɵɵInjectableDeclaration<BankConnectionService>;

package/lib/services/http/bank/basiq/basiq.service.d.ts

@@ -32,37 +32,32 @@ export declare class BasiqService extends RestService<BankAccountBase, BankAccou
      */
     listenEvents(): void;
     /**
-     * Create a new Bank connection based on Basiq job.
-     * Here we have nested requests because we need to get a job id before we create a bank connection.
-     * There is no way to use event dispatcher because we expect some errors from bank-connections API, but in components
-     * we interact with basiq service.
+     * Start basiq login process.
+     * Create a basiq job, which contain credentials verifying status.
+     * We can not see login result immediately, because it may take some time (average 10-20 sec)
      */
-    createConnection(loginData: BankLoginData, userId: string): Observable<BankConnection>;
-    /**
-     * Update disconnected bank connection
-     * Here we have nested requests because we need to get a job id before we create a bank connection.
-     * There is no way to use event dispatcher because we expect some errors from bank-connections API, but in components
-     * we interact with basiq service.
-     */
-    updateConnection(data: BankLoginData, userId: string, connection: BankConnection): Observable<BankConnection>;
+    login(loginData: BankLoginData, userId: string): void;
     getByConnection(connection: BankConnection): Observable<BankAccountCollection>;
     getNotImportedByConnection(savedAccounts: BankAccountCollection, connection: BankConnection): Observable<BankAccountCollection>;
     /**
-     * Get status of credentials verifying. Expected statuses: 'in-progress', 'failed' or 'success'
-     * We send this request by interval until basiq return success or failed
-     * @TODO Alex (TT-2431): check logic and try to remove subscribe, use pipes instead
-     * @TODO Alex (TT-2431): implement some limit and handle (message or something) if basiq stuck
-     * @TODO Alex (TT-2431): check logic and handle case when user cancelled loading
-     */
-    checkBankCredentials(jobId: string): void;
+    * Get status of credentials verifying. Expected statuses: 'in-progress', 'failed' or 'success'
+    * We send this request by interval until basiq return success or failed.
+    *
+    * Because of Basiq login may take a long time (10-20sec) we have to check job status until it seccess or failed.
+    *
+    * @TODO Alex (TT-2431): check logic and try to remove subscribe, use pipes instead
+    * @TODO Alex (TT-2431): implement some limit and handle (message or something) if basiq stuck
+    * @TODO Alex (TT-2431): check logic and handle case when user cancelled loading
+    */
+    private checkLoginStatus;
     /**
      * listen to notifications to update basiq accounts list
      */
     private listenNotifications;
     /**
-     * Listen Basiq job created to check its verify credentials status
+     * Start check job credential status when it created
      */
-    private listenJobs;
+    private listenJobCreated;
     static ɵfac: i0.ɵɵFactoryDeclaration<BasiqService, never>;
     static ɵprov: i0.ɵɵInjectableDeclaration<BasiqService>;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taxtank-core",
-  "version": "0.28.66",
+  "version": "0.28.68",
   "private": false,
   "peerDependencies": {
     "@angular/common": "^12.2.3 || ~13.0.0",

package/public-api.d.ts

@@ -143,8 +143,6 @@ export * from './lib/db/Enums/property/property-sale/tax-exemption-metadata.enum
  */
 export * from './lib/models';
 export * from './lib/models/account-setup/account-setup-item';
-export * from './lib/models/address/address';
-export * from './lib/models/address/country';
 export * from './lib/models/badge/badge';
 export * from './lib/models/badge/badge-color.enum';
 export * from './lib/models/borrowing-expense/borrowing-expense';