taskplane 0.28.1 → 0.28.3

package/dashboard/public/app.js

@@ -517,9 +517,11 @@ function renderSummary(batch) {
     const checkboxDone = ws.checked === ws.total && ws.total > 0;
     const pastWave = ws.waveIdx < currentWaveIdx;
     const batchDone = batch.phase === "completed";
-    // TP-178: During merging, only past waves are done; current wave is merging, future waves are pending (#493)
+    // TP-178: During merging, only past waves are truly done. The current wave's
+    // checkboxDone/allSucceeded can be true (tasks finished) but the wave itself
+    // isn't done until the merge completes. (#493)
     const isMerging = batch.phase === "merging";
-    const isDone = checkboxDone || pastWave || batchDone || ws.allSucceeded;
+    const isDone = batchDone || pastWave || (!isMerging && (checkboxDone || ws.allSucceeded));
     const isMergingWave = isMerging && ws.waveIdx === currentWaveIdx;
     const isCurrent = ws.waveIdx === currentWaveIdx && (batch.phase === "executing" || isMerging);
     const isFuture = ws.waveIdx > currentWaveIdx && (batch.phase === "executing" || isMerging);
@@ -711,7 +713,10 @@ function renderLanesTasks(batch, sessions) {
       // TP-176: Succeeded tasks always show 100% regardless of sidecar/statusData (#491).
       let progressHtml = "";
       const v2p = ls && ls._v2Progress;
-      const useV2 = v2p && v2p.total > 0 && ls.taskId === task.taskId;
+      const taskMatch = v2p && ls.taskId === task.taskId;
+      // Split V2 usage: progress needs totals > 0, but step/iter can be used whenever present
+      const useV2Progress = taskMatch && v2p.total > 0;
+      const useV2Step = taskMatch && !!v2p.currentStep;
       if (task.status === "succeeded") {
         // #491 fix: succeeded tasks always show 100%
         progressHtml = `
@@ -719,9 +724,9 @@ function renderLanesTasks(batch, sessions) {
             <div class="task-progress-bar"><div class="task-progress-fill pct-hi" style="width:100%"></div></div>
             <span class="task-progress-text">100%</span>
           </div>`;
-      } else if (sd || useV2) {
-        const displayChecked = useV2 ? v2p.checked : (sd ? sd.checked : 0);
-        const displayTotal = useV2 ? v2p.total : (sd ? sd.total : 0);
+      } else if (useV2Progress || (sd && sd.total > 0)) {
+        const displayChecked = useV2Progress ? v2p.checked : sd.checked;
+        const displayTotal = useV2Progress ? v2p.total : sd.total;
         const displayProgress = displayTotal > 0 ? Math.round((displayChecked / displayTotal) * 100) : 0;
         const fillClass = pctClass(displayProgress);
         progressHtml = `
@@ -731,20 +736,20 @@ function renderLanesTasks(batch, sessions) {
             </div>
             <span class="task-progress-text">${displayProgress}% ${displayChecked}/${displayTotal}</span>
           </div>`;
-      } else if (task.status === "pending") {
-        progressHtml = `
-          <div class="task-progress">
-            <div class="task-progress-bar"><div class="task-progress-fill pct-0" style="width:0%"></div></div>
-            <span class="task-progress-text">0%</span>
-          </div>`;
       } else if (task.status === "running") {
-        // TP-178: Show executing indicator for running tasks without sidecar data (#494)
-        // This covers non-final segment execution where the sidecar hasn't started yet.
+        // #494 fix: running tasks without meaningful totals show executing indicator
+        // This covers non-final segments, early execution before sidecar captures, and stale 0/0 data
         progressHtml = `
           <div class="task-progress">
             <div class="task-progress-bar"><div class="task-progress-fill pct-low task-progress-executing" style="width:100%"></div></div>
             <span class="task-progress-text">executing…</span>
           </div>`;
+      } else if (task.status === "pending") {
+        progressHtml = `
+          <div class="task-progress">
+            <div class="task-progress-bar"><div class="task-progress-fill pct-0" style="width:0%"></div></div>
+            <span class="task-progress-text">0%</span>
+          </div>`;
       } else {
         progressHtml = '<span style="color:var(--text-faint)">—</span>';
       }
@@ -756,10 +761,11 @@ function renderLanesTasks(batch, sessions) {
       if (task.status === "succeeded") {
         // TP-178: Succeeded tasks always show "Complete" regardless of sidecar data (#491)
         stepHtml = '<span style="color:var(--green)">Complete</span>';
-      } else if (sd || (useV2 && v2p)) {
-        const stepName = (useV2 && v2p && v2p.currentStep) ? v2p.currentStep : (sd ? sd.currentStep : "Unknown");
-        const iter = (useV2 && v2p && v2p.iteration != null) ? v2p.iteration : (sd ? sd.iteration : 0);
-        const revs = (useV2 && v2p && v2p.reviews != null) ? v2p.reviews : (sd ? sd.reviews : 0);
+      } else if (sd || useV2Step) {
+        // #488 fix: prefer V2 step name whenever present (even if totals are 0)
+        const stepName = useV2Step ? v2p.currentStep : (sd ? sd.currentStep : "Unknown");
+        const iter = (useV2Step && v2p.iteration != null) ? v2p.iteration : (sd ? sd.iteration : 0);
+        const revs = (useV2Step && v2p.reviews != null) ? v2p.reviews : (sd ? sd.reviews : 0);
         stepHtml = escapeHtml(stepName);
         if (iter > 0) stepHtml += `<span class="task-iter">i${iter}</span>`;
         if (revs > 0) stepHtml += `<span class="task-iter">r${revs}</span>`;

package/extensions/taskplane/agent-bridge-extension.ts

@@ -27,6 +27,7 @@ import { writeFileSync, readFileSync, existsSync, mkdirSync, renameSync, unlinkS
 import { join, dirname } from "path";
 import { spawn as nodeSpawn } from "child_process";
 import { resolvePiCliPath, resolveTaskplaneAgentTemplate } from "./path-resolver.ts";
+import { loadPiSettingsPackages, filterExcludedExtensions } from "./settings-loader.ts";
 import { randomBytes } from "crypto";
 import { buildExpansionRequestId, type SegmentExpansionRequest } from "./types.ts";
 
@@ -445,6 +446,27 @@ export default function (pi: ExtensionAPI) {
 			];
 			if (reviewerModel) args.push("--model", reviewerModel);
 			if (reviewerThinking) args.push("--thinking", reviewerThinking);
+
+			// TP-180: Forward user-installed extensions to reviewer agent
+			// Use TASKPLANE_STATE_ROOT (canonical project root) for settings resolution,
+			// falling back to cwd (which may be a worktree without .pi/settings.json).
+			const settingsRoot = process.env.TASKPLANE_STATE_ROOT || cwd;
+			const reviewerPackages = loadPiSettingsPackages(settingsRoot);
+			// Apply reviewer-specific exclusions from config (JSON array via env)
+			let reviewerExclusions: string[] = [];
+			try {
+				const rawExclude = process.env.TASKPLANE_REVIEWER_EXCLUDE_EXTENSIONS;
+				if (rawExclude) {
+					const parsed = JSON.parse(rawExclude);
+					if (Array.isArray(parsed)) {
+						reviewerExclusions = parsed.filter((v: unknown): v is string => typeof v === "string");
+					}
+				}
+			} catch { /* ignore malformed */ }
+			const filteredReviewerPackages = filterExcludedExtensions(reviewerPackages, reviewerExclusions);
+			for (const pkg of filteredReviewerPackages) {
+				args.push("-e", pkg);
+			}
 			const proc = nodeSpawn(process.execPath, args, {
 				shell: false,
 				cwd,

package/extensions/taskplane/config-loader.ts

@@ -1125,6 +1125,7 @@ export function toOrchestratorConfig(config: TaskplaneConfig): import("./types.t
 			verify: [...o.merge.verify],
 			order: o.merge.order,
 			timeout_minutes: o.merge.timeoutMinutes ?? 90,
+			exclude_extensions: [...(o.merge.excludeExtensions ?? [])],
 		},
 		failure: {
 			on_task_failure: o.failure.onTaskFailure,
@@ -1183,7 +1184,9 @@ export function toTaskRunnerConfig(config: TaskplaneConfig): import("./types.ts"
 			model: config.taskRunner.reviewer.model,
 			thinking: config.taskRunner.reviewer.thinking,
 			tools: config.taskRunner.reviewer.tools,
+			excludeExtensions: [...(config.taskRunner.reviewer.excludeExtensions ?? [])],
 		},
+		workerExcludeExtensions: [...(config.taskRunner.worker.excludeExtensions ?? [])],
 	};
 }
 

package/extensions/taskplane/config-schema.ts

@@ -111,6 +111,8 @@ export interface WorkerConfig {
 	thinking: string;
 	/** Optional spawn mode override for task-runner (Runtime V2 subprocess-only). */
 	spawnMode?: "subprocess";
+	/** Package specifiers to exclude from extension forwarding for worker agents (exact match). @since TP-180 */
+	excludeExtensions?: string[];
 }
 
 /** Reviewer agent configuration */
@@ -121,6 +123,8 @@ export interface ReviewerConfig {
 	tools: string;
 	/** Thinking mode for reviewer */
 	thinking: string;
+	/** Package specifiers to exclude from extension forwarding for reviewer agents (exact match). @since TP-180 */
+	excludeExtensions?: string[];
 }
 
 /** Context/resource limits for task execution */
@@ -310,6 +314,8 @@ export interface MergeConfig {
 	order: "fewest-files-first" | "sequential";
 	/** Merge-agent timeout in minutes */
 	timeoutMinutes?: number;
+	/** Package specifiers to exclude from extension forwarding for merge agents (exact match). @since TP-180 */
+	excludeExtensions?: string[];
 }
 
 /** Failure policy settings */
@@ -588,8 +594,8 @@ export const DEFAULT_TASK_RUNNER_SECTION: TaskRunnerSection = {
 	testing: { commands: {} },
 	standards: { docs: [], rules: [] },
 	standardsOverrides: {},
-	worker: { model: "", tools: "read,write,edit,bash,grep,find,ls", thinking: "" },
-	reviewer: { model: "", tools: "read,bash,grep,find,ls", thinking: "on" },
+	worker: { model: "", tools: "read,write,edit,bash,grep,find,ls", thinking: "", excludeExtensions: [] },
+	reviewer: { model: "", tools: "read,bash,grep,find,ls", thinking: "on", excludeExtensions: [] },
 	context: {
 		workerContextWindow: 0,
 		warnPercent: 85,
@@ -645,6 +651,7 @@ export const DEFAULT_ORCHESTRATOR_SECTION: OrchestratorSection = {
 		verify: [],
 		order: "fewest-files-first",
 		timeoutMinutes: 90,
+		excludeExtensions: [],
 	},
 	failure: {
 		onTaskFailure: "skip-dependents",

package/extensions/taskplane/engine.ts

@@ -6,7 +6,7 @@ import { existsSync, readdirSync, readFileSync, renameSync, unlinkSync } from "f
 import { join, resolve } from "path";
 
 import { formatDiscoveryResults, runDiscovery } from "./discovery.ts";
-import { buildReviewerEnv, computeTransitiveDependents, execLog, executeLaneV2, executeWave, killV2LaneAgents, resolveCanonicalTaskPaths } from "./execution.ts";
+import { buildReviewerEnv, buildWorkerExcludeEnv, computeTransitiveDependents, execLog, executeLaneV2, executeWave, killV2LaneAgents, resolveCanonicalTaskPaths } from "./execution.ts";
 import type { RuntimeBackend } from "./execution.ts";
 import type { MonitorUpdateCallback } from "./execution.ts";
 // classifyExit no longer called directly — Tier 0 uses exitDiagnostic.classification
@@ -1381,7 +1381,7 @@ async function attemptWorkerCrashRetry(
 				retryPauseSignal,
 				wsRoot,
 				isWsMode,
-				{ ORCH_BATCH_ID: batchState.batchId, ...buildReviewerEnv(runnerConfig?.reviewer) }, // TP-089: ensure mailbox works for retries
+				{ ORCH_BATCH_ID: batchState.batchId, ...buildReviewerEnv(runnerConfig?.reviewer), ...buildWorkerExcludeEnv(runnerConfig?.workerExcludeExtensions) }, // TP-089: ensure mailbox works for retries
 			);
 
 			const retryOutcome = retryResult.tasks[0];
@@ -1640,7 +1640,7 @@ async function attemptModelFallbackRetry(
 			// Pass TASKPLANE_MODEL_FALLBACK=1 as extra env var to signal
 			// the task-runner to use the session model instead of configured model.
 			// TP-089: Also include ORCH_BATCH_ID so mailbox steering works for retries.
-			const modelFallbackEnv = { TASKPLANE_MODEL_FALLBACK: "1", ORCH_BATCH_ID: batchState.batchId, ...buildReviewerEnv(runnerConfig?.reviewer) };
+			const modelFallbackEnv = { TASKPLANE_MODEL_FALLBACK: "1", ORCH_BATCH_ID: batchState.batchId, ...buildReviewerEnv(runnerConfig?.reviewer), ...buildWorkerExcludeEnv(runnerConfig?.workerExcludeExtensions) };
 			const retryResult = await executeLaneV2(
 				retryLane,
 				orchConfig,
@@ -1887,7 +1887,9 @@ async function attemptStaleWorktreeRecovery(
 			model: runnerConfig?.reviewer?.model || "",
 			thinking: runnerConfig?.reviewer?.thinking || "",
 			tools: runnerConfig?.reviewer?.tools || "",
+			excludeExtensions: runnerConfig?.reviewer?.excludeExtensions ?? [],
 		},
+		runnerConfig?.workerExcludeExtensions ?? [],
 	);
 
 	return retryResult;
@@ -2490,7 +2492,9 @@ export async function executeOrchBatch(
 				model: runnerConfig?.reviewer?.model || "",
 				thinking: runnerConfig?.reviewer?.thinking || "",
 				tools: runnerConfig?.reviewer?.tools || "",
+				excludeExtensions: runnerConfig?.reviewer?.excludeExtensions ?? [],
 			},
+			runnerConfig?.workerExcludeExtensions ?? [],
 		);
 
 		// ── TP-039: Tier 0 — Stale worktree recovery ────────────

package/extensions/taskplane/execution.ts

@@ -1754,7 +1754,8 @@ export async function executeWave(
 	runtimeBackend?: RuntimeBackend,
 	onSupervisorAlert?: SupervisorAlertCallback,
 	supervisorAutonomy: "interactive" | "supervised" | "autonomous" = "autonomous",
-	reviewerConfig?: { model?: string; thinking?: string; tools?: string },
+	reviewerConfig?: { model?: string; thinking?: string; tools?: string; excludeExtensions?: string[] },
+	workerExcludeExtensions?: string[],
 ): Promise<WaveExecutionResult> {
 	const startedAt = Date.now();
 	const policy = config.failure.on_task_failure;
@@ -1862,6 +1863,7 @@ export async function executeWave(
 			ORCH_BATCH_ID: batchId,
 			TASKPLANE_SUPERVISOR_AUTONOMY: supervisorAutonomy,
 			...buildReviewerEnv(reviewerConfig),
+			...buildWorkerExcludeEnv(workerExcludeExtensions),
 		}, onSupervisorAlert),
 	);
 
@@ -2503,13 +2505,44 @@ import { executeTaskV2, type LaneRunnerConfig, type LaneRunnerTaskResult } from
  *
  * @since TP-160
  */
+/**
+ * Parse a JSON string array from an env var value, returning empty array on failure.
+ * @since TP-180
+ */
+function parseJsonArrayEnv(value?: string): string[] {
+	if (!value) return [];
+	try {
+		const parsed = JSON.parse(value);
+		if (Array.isArray(parsed)) return parsed.filter((v: unknown): v is string => typeof v === "string");
+	} catch { /* ignore malformed */ }
+	return [];
+}
+
 export function buildReviewerEnv(
-	reviewerConfig?: { model?: string; thinking?: string; tools?: string } | null,
+	reviewerConfig?: { model?: string; thinking?: string; tools?: string; excludeExtensions?: string[] } | null,
 ): Record<string, string> {
 	const env: Record<string, string> = {};
 	if (reviewerConfig?.model) env.TASKPLANE_REVIEWER_MODEL = reviewerConfig.model;
 	if (reviewerConfig?.thinking) env.TASKPLANE_REVIEWER_THINKING = reviewerConfig.thinking;
 	if (reviewerConfig?.tools) env.TASKPLANE_REVIEWER_TOOLS = reviewerConfig.tools;
+	// TP-180: Forward reviewer extension exclusions as JSON array
+	if (reviewerConfig?.excludeExtensions && reviewerConfig.excludeExtensions.length > 0) {
+		env.TASKPLANE_REVIEWER_EXCLUDE_EXTENSIONS = JSON.stringify(reviewerConfig.excludeExtensions);
+	}
+	return env;
+}
+
+/**
+ * Build worker extension exclusion env vars from config.
+ * @since TP-180
+ */
+export function buildWorkerExcludeEnv(
+	workerExcludeExtensions?: string[] | null,
+): Record<string, string> {
+	const env: Record<string, string> = {};
+	if (workerExcludeExtensions && workerExcludeExtensions.length > 0) {
+		env.TASKPLANE_WORKER_EXCLUDE_EXTENSIONS = JSON.stringify(workerExcludeExtensions);
+	}
 	return env;
 }
 
@@ -2606,6 +2639,9 @@ export async function executeLaneV2(
 			reviewerModel: extraEnvVars?.TASKPLANE_REVIEWER_MODEL || "",
 			reviewerThinking: extraEnvVars?.TASKPLANE_REVIEWER_THINKING || "",
 			reviewerTools: extraEnvVars?.TASKPLANE_REVIEWER_TOOLS || "",
+			// TP-180: Extension exclusion lists from config
+			workerExcludeExtensions: parseJsonArrayEnv(extraEnvVars?.TASKPLANE_WORKER_EXCLUDE_EXTENSIONS),
+			reviewerExcludeExtensions: parseJsonArrayEnv(extraEnvVars?.TASKPLANE_REVIEWER_EXCLUDE_EXTENSIONS),
 			supervisorAutonomy,
 			projectName: config.project?.name || "project",
 			maxIterations: 20,