taskplane 0.25.2 → 0.25.4

package/extensions/taskplane/agent-bridge-extension.ts

@@ -25,7 +25,7 @@ import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
 import { Type } from "@mariozechner/pi-ai";
 import { writeFileSync, readFileSync, existsSync, mkdirSync, renameSync, unlinkSync } from "fs";
 import { join, dirname } from "path";
-import { spawn as nodeSpawn } from "child_process";
+import { spawn as nodeSpawn, spawnSync } from "child_process";
 import { randomBytes } from "crypto";
 import { buildExpansionRequestId, type SegmentExpansionRequest } from "./types.ts";
 
@@ -359,32 +359,63 @@ export default function (pi: ExtensionAPI) {
 	/**
 	 * Resolve the Pi CLI entrypoint path (same logic as agent-host.ts).
 	 */
+	let _npmRootCache: string | null = null;
+	function getNpmGlobalRoot(): string {
+		if (_npmRootCache !== null) return _npmRootCache;
+		try {
+			const result = spawnSync("npm", ["root", "-g"], { encoding: "utf-8", timeout: 5000, shell: true });
+			_npmRootCache = result.stdout?.trim() || "";
+		} catch { _npmRootCache = ""; }
+		return _npmRootCache;
+	}
+
 	function resolvePiCli(): string {
-		const relPath = join("node_modules", "@mariozechner", "pi-coding-agent", "dist", "cli.js");
+		const relPath = join("@mariozechner", "pi-coding-agent", "dist", "cli.js");
 		const candidates: string[] = [];
-		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", relPath));
+
+		// Dynamic: npm root -g (covers nvm, Homebrew, volta, and all custom prefixes)
+		const npmRoot = getNpmGlobalRoot();
+		if (npmRoot) candidates.push(join(npmRoot, relPath));
+
+		// Well-known static paths
 		const home = process.env.HOME || process.env.USERPROFILE || "";
+		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", "node_modules", relPath));
 		if (home) {
-			candidates.push(join(home, "AppData", "Roaming", "npm", relPath));
-			candidates.push(join(home, ".npm-global", "lib", relPath));
+			candidates.push(join(home, "AppData", "Roaming", "npm", "node_modules", relPath));
+			candidates.push(join(home, ".npm-global", "lib", "node_modules", relPath));
 		}
-		candidates.push(join("/usr", "local", "lib", relPath));
+		candidates.push(join("/usr", "local", "lib", "node_modules", relPath));
+		candidates.push(join("/opt", "homebrew", "lib", "node_modules", relPath));
+
 		for (const c of candidates) {
 			if (existsSync(c)) return c;
 		}
-		throw new Error("Cannot find Pi CLI entrypoint");
+		throw new Error("Cannot find Pi CLI entrypoint. Run: npm root -g to verify your npm global path.");
 	}
 
 	/**
 	 * Load the reviewer system prompt from base template + local override.
 	 */
 	function loadReviewerPrompt(): string {
-		const basePaths = [
-			process.env.APPDATA ? join(process.env.APPDATA, "npm", "node_modules", "taskplane", "templates", "agents", "task-reviewer.md") : "",
-			(process.env.HOME || process.env.USERPROFILE || "") ? join(process.env.HOME || process.env.USERPROFILE || "", "AppData", "Roaming", "npm", "node_modules", "taskplane", "templates", "agents", "task-reviewer.md") : "",
-		].filter(Boolean);
+		const relPath = join("taskplane", "templates", "agents", "task-reviewer.md");
+		const candidates: string[] = [];
+
+		// Dynamic: npm root -g
+		const npmRoot = getNpmGlobalRoot();
+		if (npmRoot) candidates.push(join(npmRoot, relPath));
+
+		// Well-known static paths
+		const home = process.env.HOME || process.env.USERPROFILE || "";
+		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", "node_modules", relPath));
+		if (home) {
+			candidates.push(join(home, "AppData", "Roaming", "npm", "node_modules", relPath));
+			candidates.push(join(home, ".npm-global", "lib", "node_modules", relPath));
+		}
+		candidates.push(join("/usr", "local", "lib", "node_modules", relPath));
+		candidates.push(join("/opt", "homebrew", "lib", "node_modules", relPath));
+
 		let basePrompt = "You are a code reviewer. Read the request and write your review to the specified output file.";
-		for (const p of basePaths) {
+		for (const p of candidates) {
 			try {
 				if (!existsSync(p)) continue;
 				const raw = readFileSync(p, "utf-8");

package/extensions/taskplane/agent-host.ts

@@ -20,7 +20,7 @@
  * @since TP-104
  */
 
-import { spawn, type ChildProcess } from "child_process";
+import { spawn, spawnSync, type ChildProcess } from "child_process";
 import {
 	readFileSync, writeFileSync, appendFileSync, mkdirSync,
 	existsSync, readdirSync, renameSync,
@@ -55,46 +55,54 @@ import { appendMailboxAuditEvent } from "./mailbox.ts";
  * with `shell: false`. This function resolves the underlying JS file.
  *
  * Resolution order:
- *   1. APPDATA/npm/node_modules/@mariozechner/pi-coding-agent/dist/cli.js
- *   2. HOME/.npm-global/lib/node_modules/...
- *   3. /usr/local/lib/node_modules/...
+ *   1. npm root -g (dynamic — covers nvm, Homebrew, volta, custom prefix)
+ *   2. APPDATA/npm/node_modules/... (Windows)
+ *   3. HOME/.npm-global/lib/node_modules/...
+ *   4. /usr/local/lib/node_modules/...
+ *   5. /opt/homebrew/lib/node_modules/... (macOS Homebrew)
  *
  * @returns Absolute path to the Pi CLI JS entrypoint
  * @throws Error if Pi CLI cannot be found
  *
  * @since TP-104
  */
+let _npmGlobalRootCache: string | null = null;
+function getNpmGlobalRoot(): string {
+	if (_npmGlobalRootCache !== null) return _npmGlobalRootCache;
+	try {
+		const result = spawnSync("npm", ["root", "-g"], { encoding: "utf-8", timeout: 5000, shell: true });
+		_npmGlobalRootCache = result.stdout?.trim() || "";
+	} catch {
+		_npmGlobalRootCache = "";
+	}
+	return _npmGlobalRootCache;
+}
+
 export function resolvePiCliPath(): string {
-	const relPath = join("node_modules", "@mariozechner", "pi-coding-agent", "dist", "cli.js");
+	const relPath = join("@mariozechner", "pi-coding-agent", "dist", "cli.js");
 	const candidates: string[] = [];
 
-	if (process.env.APPDATA) {
-		candidates.push(join(process.env.APPDATA, "npm", relPath));
-	}
+	// Dynamic first: covers nvm, Homebrew, volta, custom npm prefix
+	const npmRoot = getNpmGlobalRoot();
+	if (npmRoot) candidates.push(join(npmRoot, relPath));
+
+	// Well-known static fallbacks
 	const home = process.env.HOME || process.env.USERPROFILE || "";
+	if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", "node_modules", relPath));
 	if (home) {
-		candidates.push(join(home, "AppData", "Roaming", "npm", relPath));
-		candidates.push(join(home, ".npm-global", "lib", relPath));
+		candidates.push(join(home, "AppData", "Roaming", "npm", "node_modules", relPath));
+		candidates.push(join(home, ".npm-global", "lib", "node_modules", relPath));
 	}
-	candidates.push(join("/usr", "local", "lib", relPath));
-	candidates.push(join("/opt", "homebrew", "lib", relPath));
-
-	// Dynamic: npm root -g
-	try {
-		const { spawnSync } = require("child_process");
-		const result = spawnSync("npm", ["root", "-g"], { encoding: "utf-8", timeout: 5000, shell: true });
-		if (result.stdout?.trim()) {
-			candidates.push(join(result.stdout.trim(), "@mariozechner", "pi-coding-agent", "dist", "cli.js"));
-		}
-	} catch { /* ignore */ }
+	candidates.push(join("/usr", "local", "lib", "node_modules", relPath));
+	candidates.push(join("/opt", "homebrew", "lib", "node_modules", relPath));
 
 	for (const candidate of candidates) {
 		if (existsSync(candidate)) return candidate;
 	}
 
 	throw new Error(
-		"Cannot find Pi CLI entrypoint (cli.js). Ensure pi is installed globally. " +
-		`Searched: ${candidates.slice(0, 4).join(", ")}`,
+		"Cannot find Pi CLI entrypoint (cli.js). Ensure pi is installed globally via 'pi install'. " +
+		`npm root -g: ${npmRoot || "(not found)"}`,
 	);
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taskplane",
-  "version": "0.25.2",
+  "version": "0.25.4",
   "description": "AI agent orchestration for pi — parallel task execution with checkpoint discipline",
   "keywords": [
     "pi-package",