taskplane 0.25.1 → 0.25.3

package/extensions/taskplane/agent-bridge-extension.ts

@@ -25,7 +25,7 @@ import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
 import { Type } from "@mariozechner/pi-ai";
 import { writeFileSync, readFileSync, existsSync, mkdirSync, renameSync, unlinkSync } from "fs";
 import { join, dirname } from "path";
-import { spawn as nodeSpawn } from "child_process";
+import { spawn as nodeSpawn, spawnSync } from "child_process";
 import { randomBytes } from "crypto";
 import { buildExpansionRequestId, type SegmentExpansionRequest } from "./types.ts";
 
@@ -359,32 +359,60 @@ export default function (pi: ExtensionAPI) {
 	/**
 	 * Resolve the Pi CLI entrypoint path (same logic as agent-host.ts).
 	 */
+	function getNpmGlobalRoot(): string {
+		try {
+			const result = spawnSync("npm", ["root", "-g"], { encoding: "utf-8", timeout: 5000, shell: true });
+			return result.stdout?.trim() || "";
+		} catch { return ""; }
+	}
+
 	function resolvePiCli(): string {
-		const relPath = join("node_modules", "@mariozechner", "pi-coding-agent", "dist", "cli.js");
+		const relPath = join("@mariozechner", "pi-coding-agent", "dist", "cli.js");
 		const candidates: string[] = [];
-		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", relPath));
+
+		// Dynamic: npm root -g (covers nvm, Homebrew, volta, and all custom prefixes)
+		const npmRoot = getNpmGlobalRoot();
+		if (npmRoot) candidates.push(join(npmRoot, relPath));
+
+		// Well-known static paths
 		const home = process.env.HOME || process.env.USERPROFILE || "";
+		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", "node_modules", relPath));
 		if (home) {
-			candidates.push(join(home, "AppData", "Roaming", "npm", relPath));
-			candidates.push(join(home, ".npm-global", "lib", relPath));
+			candidates.push(join(home, "AppData", "Roaming", "npm", "node_modules", relPath));
+			candidates.push(join(home, ".npm-global", "lib", "node_modules", relPath));
 		}
-		candidates.push(join("/usr", "local", "lib", relPath));
+		candidates.push(join("/usr", "local", "lib", "node_modules", relPath));
+		candidates.push(join("/opt", "homebrew", "lib", "node_modules", relPath));
+
 		for (const c of candidates) {
 			if (existsSync(c)) return c;
 		}
-		throw new Error("Cannot find Pi CLI entrypoint");
+		throw new Error("Cannot find Pi CLI entrypoint. Run: npm root -g to verify your npm global path.");
 	}
 
 	/**
 	 * Load the reviewer system prompt from base template + local override.
 	 */
 	function loadReviewerPrompt(): string {
-		const basePaths = [
-			process.env.APPDATA ? join(process.env.APPDATA, "npm", "node_modules", "taskplane", "templates", "agents", "task-reviewer.md") : "",
-			(process.env.HOME || process.env.USERPROFILE || "") ? join(process.env.HOME || process.env.USERPROFILE || "", "AppData", "Roaming", "npm", "node_modules", "taskplane", "templates", "agents", "task-reviewer.md") : "",
-		].filter(Boolean);
+		const relPath = join("taskplane", "templates", "agents", "task-reviewer.md");
+		const candidates: string[] = [];
+
+		// Dynamic: npm root -g
+		const npmRoot = getNpmGlobalRoot();
+		if (npmRoot) candidates.push(join(npmRoot, relPath));
+
+		// Well-known static paths
+		const home = process.env.HOME || process.env.USERPROFILE || "";
+		if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", "node_modules", relPath));
+		if (home) {
+			candidates.push(join(home, "AppData", "Roaming", "npm", "node_modules", relPath));
+			candidates.push(join(home, ".npm-global", "lib", "node_modules", relPath));
+		}
+		candidates.push(join("/usr", "local", "lib", "node_modules", relPath));
+		candidates.push(join("/opt", "homebrew", "lib", "node_modules", relPath));
+
 		let basePrompt = "You are a code reviewer. Read the request and write your review to the specified output file.";
-		for (const p of basePaths) {
+		for (const p of candidates) {
 			try {
 				if (!existsSync(p)) continue;
 				const raw = readFileSync(p, "utf-8");

package/extensions/taskplane/execution.ts

@@ -2126,31 +2126,20 @@ function parseAgentFile(filePath: string): { fm: Record<string, string>; body: s
  * @since TP-117
  */
 function loadBaseAgentPrompt(agentName: string): string {
-	const relPath = join("node_modules", "taskplane", "templates", "agents", `${agentName}.md`);
-	const candidates: string[] = [];
-
-	// Global npm paths
-	const home = process.env.HOME || process.env.USERPROFILE || "";
-	if (process.env.APPDATA) candidates.push(join(process.env.APPDATA, "npm", relPath));
-	if (home) {
-		candidates.push(join(home, "AppData", "Roaming", "npm", relPath));
-		candidates.push(join(home, ".npm-global", "lib", relPath));
-	}
-	candidates.push(join("/usr", "local", "lib", relPath));
-	candidates.push(join("/opt", "homebrew", "lib", relPath));
-
-	// Dynamic: npm root -g
+	// Use the same robust resolution as resolveTaskplanePackageFile, which
+	// handles all npm setups (nvm, Homebrew, volta, Windows, etc.) via
+	// npm root -g caching and well-known fallback paths.
+	// This avoids loadBaseAgentPrompt silently returning "" (which would
+	// cause the worker to skip reviews because the review_step instructions
+	// live in the base template, not the local .pi/agents/ override).
+	const relPath = join("templates", "agents", `${agentName}.md`);
 	try {
-		const result = spawnSync("npm", ["root", "-g"], { encoding: "utf-8", timeout: 5000, shell: true });
-		if (result.stdout?.trim()) {
-			candidates.push(join(result.stdout.trim(), "taskplane", "templates", "agents", `${agentName}.md`));
+		const resolved = resolveTaskplanePackageFile(process.cwd(), relPath);
+		if (existsSync(resolved)) {
+			const def = parseAgentFile(resolved);
+			if (def?.body) return def.body;
 		}
-	} catch { /* ignore */ }
-
-	for (const p of candidates) {
-		const def = parseAgentFile(p);
-		if (def?.body) return def.body;
-	}
+	} catch { /* fall through */ }
 	return "";
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taskplane",
-  "version": "0.25.1",
+  "version": "0.25.3",
   "description": "AI agent orchestration for pi — parallel task execution with checkpoint discipline",
   "keywords": [
     "pi-package",