taskchef 7.21.2 → 7.22.0

package/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "taskchef",
-  "version": "7.21.2",
+  "version": "7.22.0",
   "description": "Dispatch work from a data-only workspace to visible Codex project tasks.",
   "author": {
     "name": "Favo Yang",

package/README.md

@@ -273,14 +273,15 @@ timeline, including clearly labeled interrupted turns.
 Task details offer infrequent administrative actions without cluttering task
 cards. Selecting **More task actions** (`…`) reveals the action list immediately
 beside the disclosure and changes it to a back/hide control. The list contains
-**Copy Task ID**, direct **Mark completed** and **Mark failed** actions for a
-`working` or `needs_input` task. The menu disclosure is the deliberate first
-step; choosing a terminal outcome submits it immediately without a second
-confirmation. There is no
+**Copy Task ID** and direct **Mark completed** and **Mark failed** actions.
+Working and needs-input tasks offer either terminal outcome; completed tasks
+offer **Mark failed**, and failed tasks offer **Mark completed**. The menu
+disclosure is the deliberate first step; choosing an outcome submits it
+immediately without a second confirmation. There is no
 free-form reason: the audit turn records a fixed summary, timestamp, dashboard
 provenance, optimistic preconditions, and a unique action ID while preserving
-every executor turn. Terminal tasks cannot be rewritten. Stale or concurrent
-changes are rejected and the dialog refreshes to the current task. A stalled
+every executor turn. Same-state terminal rewrites remain invalid. Stale or
+concurrent changes are rejected and the dialog refreshes to the current task. A stalled
 local request is aborted after a bounded wait so the dialog cannot remain
 permanently locked; retry keeps the same idempotency identity.
 

package/docs/spec.md

@@ -483,14 +483,15 @@ startup safely. Direct thread navigation
 MUST require a canonical Codex UUIDv7. Otherwise it MAY open the revalidated
 configured project. Project paths from task history MUST be matched against
 current configuration before use.
-The task-detail dashboard MAY offer manual terminal outcomes only for current
-`working` or `needs_input` tasks. It MUST permit exactly `completed` and
-`failed`, MUST NOT rewrite a terminal task, and MUST keep this infrequent
-administrative action out of list cards. A keyboard-accessible **More task
+The task-detail dashboard MAY offer manual outcomes from `working` or
+`needs_input` to either `completed` or `failed`, from `completed` to `failed`,
+and from `failed` to `completed`. It MUST reject same-state terminal
+transitions and MUST keep this infrequent administrative action out of list
+cards. A keyboard-accessible **More task
 actions** disclosure MUST reveal its action list immediately beside it and
 change from an ellipsis to an accessible back/hide control while expanded. The
-list MUST group **Copy Task ID**, **Mark completed**, and **Mark failed** for
-eligible tasks. **Archive chat** MUST remain hidden while the archive capability
+list MUST group **Copy Task ID** and each currently valid **Mark completed** or
+**Mark failed** action. **Archive chat** MUST remain hidden while the archive capability
 gate is disabled because the bundled CLI does not reliably archive desktop-app
 threads. The dormant server endpoint MUST reject requests before discovering or
 invoking the CLI. Re-enabling requires a reliable supported app-callable archive

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taskchef",
-  "version": "7.21.2",
+  "version": "7.22.0",
   "description": "A non-blocking interactive dispatcher for visible Codex tasks.",
   "license": "MIT",
   "author": "Favo Yang",

package/src/dashboard/app.js

@@ -506,7 +506,6 @@ function replaceCurrentTask(task) {
 function renderManualTransition(task) {
   const activeElement = document.activeElement;
   const focusWasInPanel = elements.manualTransitionPanel.contains?.(activeElement) ?? false;
-  const eligible = canManuallyTransitionTask(task);
   state.manualTransition = reconcileManualTransition(state.manualTransition, task);
   const pending = manualTransitionPending();
   const expanded = Boolean(state.manualTransition);
@@ -522,8 +521,8 @@ function renderManualTransition(task) {
   elements.manualTransitionPanel.hidden = state.manualTransition === null;
   elements.manualTransitionPanel.setAttribute("aria-busy", String(pending));
   elements.copyTaskId.disabled = pending || !task.id;
-  elements.markTaskCompleted.hidden = !eligible;
-  elements.markTaskFailed.hidden = !eligible;
+  elements.markTaskCompleted.hidden = !canManuallyTransitionTask(task, "completed");
+  elements.markTaskFailed.hidden = !canManuallyTransitionTask(task, "failed");
   elements.markTaskCompleted.disabled = pending;
   elements.markTaskFailed.disabled = pending;
   const archivePending = state.archivePendingThreadIds.has(task.threadId);
@@ -561,7 +560,11 @@ function renderManualTransition(task) {
 
 async function submitManualTransition(targetStatus, event) {
   const task = state.selectedTask;
-  if (!task || !canManuallyTransitionTask(task) || manualTransitionPending()) return;
+  if (
+    !task
+    || !canManuallyTransitionTask(task, targetStatus)
+    || manualTransitionPending()
+  ) return;
   const previous = state.manualTransition;
   const actionId = previous?.targetStatus === targetStatus && previous.actionId
     ? previous.actionId

package/src/dashboard/state.js

@@ -57,8 +57,15 @@ export function canArchiveTask(task) {
   return CODEX_CHAT_ARCHIVE_ENABLED && isArchiveTaskEligible(task);
 }
 
-export function canManuallyTransitionTask(task) {
-  return ["working", "needs_input"].includes(task.status);
+export function canManuallyTransitionTask(task, targetStatus = null) {
+  const targets = task.status === "completed"
+    ? ["failed"]
+    : task.status === "failed"
+      ? ["completed"]
+      : ["working", "needs_input"].includes(task.status)
+        ? ["completed", "failed"]
+        : [];
+  return targetStatus === null ? targets.length > 0 : targets.includes(targetStatus);
 }
 
 export function manualTransitionExpectedState(task) {

package/src/mcp.js

@@ -28,7 +28,7 @@ const turnProvenanceSchema = z.union([
   z.object({
     kind: z.literal("dashboard_manual"),
     actionId: z.string(),
-    fromStatus: z.enum(["working", "needs_input"]),
+    fromStatus: z.enum(["working", "needs_input", "completed", "failed"]),
     toStatus: z.enum(["completed", "failed"]),
     expectedTurnRef: z.string().nullable(),
     expectedThreadId: z.string().nullable(),

package/src/workspace.js

@@ -105,7 +105,9 @@ const MANUAL_TURN_PROVENANCE_FIELDS = new Set([
   "expectedUpdatedAt",
 ]);
 const INTERRUPTED_TURN_SUMMARY = "Turn interrupted before a terminal report.";
-const MANUAL_TRANSITION_STATUSES = new Set(["working", "needs_input"]);
+const MANUAL_TRANSITION_STATUSES = new Set([
+  "working", "needs_input", "completed", "failed",
+]);
 const MANUAL_TARGET_STATUSES = new Set(["completed", "failed"]);
 const MANUAL_TRANSITION_FIELDS = new Set([
   "actionId", "expected", "targetStatus",
@@ -1035,9 +1037,14 @@ async function validateDispatchShape(dispatch, name = "task") {
       if (provenance.expectedTurnRef !== (predecessor?.turnRef ?? null)) {
         throw new Error(`${turnName}.provenance.expectedTurnRef must match the prior turn`);
       }
+      if (!canManuallyTransition(provenance.fromStatus, provenance.toStatus)) {
+        throw new Error(`${turnName}.provenance describes an invalid manual transition`);
+      }
       const validPriorState = provenance.fromStatus === "needs_input"
         ? predecessor?.result?.status === "needs_input"
-        : predecessor === null || predecessor.result?.status === "interrupted";
+        : provenance.fromStatus === "working"
+          ? predecessor === null || predecessor.result?.status === "interrupted"
+          : predecessor?.result?.status === provenance.fromStatus;
       if (!validPriorState) {
         throw new Error(`${turnName}.provenance.fromStatus does not match the prior turn`);
       }
@@ -1048,9 +1055,9 @@ async function validateDispatchShape(dispatch, name = "task") {
       ) {
         throw new Error(`${turnName} must share its timestamp with the interrupted prior turn`);
       }
-      const expectedPriorTimestamp = provenance.fromStatus === "needs_input"
-        ? predecessor.result.updatedAt
-        : predecessor?.startedAt ?? null;
+      const expectedPriorTimestamp = provenance.fromStatus === "working"
+        ? predecessor?.startedAt ?? null
+        : predecessor.result.updatedAt;
       if (
         Date.parse(provenance.expectedUpdatedAt) < Date.parse(normalized.createdAt)
         || (
@@ -1666,6 +1673,13 @@ function manualTransitionRequestSummary(fromStatus, toStatus) {
   return `Manual dashboard transition from ${fromStatus} to ${toStatus}.`;
 }
 
+function canManuallyTransition(fromStatus, toStatus) {
+  if (!MANUAL_TRANSITION_STATUSES.has(fromStatus) || !MANUAL_TARGET_STATUSES.has(toStatus)) {
+    return false;
+  }
+  return ["working", "needs_input"].includes(fromStatus) || fromStatus !== toStatus;
+}
+
 function taskOperationError(code, message, task = null) {
   const error = new Error(message);
   error.code = code;
@@ -2009,7 +2023,7 @@ export async function manuallyTransitionTask(
     }
 
     const dispatch = dispatches[index];
-    if (!MANUAL_TRANSITION_STATUSES.has(dispatch.status)) {
+    if (!canManuallyTransition(dispatch.status, normalizedInput.targetStatus)) {
       throw taskOperationError(
         "invalid_transition",
         `task status cannot be changed manually from ${dispatch.status}: ${id}`,