taskchef 7.14.1 → 7.14.2

package/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "taskchef",
-  "version": "7.14.1",
+  "version": "7.14.2",
   "description": "Dispatch work from a data-only workspace to visible Codex project tasks.",
   "author": {
     "name": "Favo Yang",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taskchef",
-  "version": "7.14.1",
+  "version": "7.14.2",
   "description": "A non-blocking interactive dispatcher for visible Codex tasks.",
   "license": "MIT",
   "author": "Favo Yang",

package/src/dashboard/app.js

@@ -16,7 +16,7 @@ import {
   turnPresentation,
 } from "./state.js";
 import { openTaskFromControl } from "./actions.js";
-import { githubReferenceSegments } from "./github-links.js";
+import { referenceSegments } from "./github-links.js";
 import { formatRelativeTime, RelativeTimeController, parsedTimestamp } from "./time.js";
 
 const state = {
@@ -61,28 +61,33 @@ const elements = {
 };
 let notificationDescriptionSerial = 0;
 
-function githubLink(link, { compact = false } = {}) {
+function referenceLink(link, { compact = false } = {}) {
   const anchor = document.createElement("a");
   anchor.className = compact ? "github-link github-link-compact" : "github-link";
   anchor.href = link.url;
   anchor.target = "_blank";
   anchor.rel = "noopener noreferrer";
   anchor.textContent = link.label ?? link.text;
+  const githubKind = link.type === "issue"
+    ? ", GitHub issue"
+    : link.type === "pull"
+      ? ", GitHub pull request"
+      : link.provider === "github" || link.owner ? " on GitHub" : "";
   anchor.setAttribute(
     "aria-label",
-    `${link.label ?? link.text} on GitHub (opens in a new tab)`,
+    `${link.label ?? link.text}${githubKind} (opens in a new tab)`,
   );
   anchor.addEventListener("click", (event) => event.stopPropagation());
   return anchor;
 }
 
-function appendGitHubText(container, text, task) {
-  const children = githubReferenceSegments(text, {
+function appendLinkedText(container, text, task) {
+  const children = referenceSegments(text, {
     projectRepositories: task.project?.githubRepos,
     taskRepository: task.relatedGitHubRepository,
   }).map((segment) => {
     if (segment.kind === "text") return document.createTextNode(segment.text);
-    if (segment.kind === "link") return githubLink(segment);
+    if (segment.kind === "link") return referenceLink(segment);
     const ambiguous = document.createElement("span");
     ambiguous.className = "github-reference-ambiguous";
     ambiguous.textContent = segment.text;
@@ -99,7 +104,7 @@ function relatedGitHubLinks(task, { compact = false } = {}) {
   const container = document.createElement("nav");
   container.className = `github-links${compact ? " github-links-compact" : ""}`;
   container.setAttribute("aria-label", `Related GitHub links for ${task.title}`);
-  const children = links.map((link) => githubLink(link, { compact }));
+  const children = links.map((link) => referenceLink(link, { compact }));
   if (task.relatedGitHubLinksTruncated) {
     const more = document.createElement("span");
     more.className = "github-links-more";
@@ -307,7 +312,7 @@ function turnTimeline(task) {
     requestLabel.textContent = "Request";
     const request = document.createElement("p");
     request.className = "preserve-lines";
-    appendGitHubText(
+    appendLinkedText(
       request,
       turn.requestSummary ?? "Request not recorded by this TaskChef version.",
       task,
@@ -316,7 +321,7 @@ function turnTimeline(task) {
     resultLabel.textContent = "Result";
     const result = document.createElement("p");
     result.className = "preserve-lines";
-    appendGitHubText(result, presentation.summary, task);
+    appendLinkedText(result, presentation.summary, task);
     const turnMetadata = document.createElement("p");
     turnMetadata.className = "result-history-turn";
     turnMetadata.textContent = turn.turnId
@@ -424,12 +429,12 @@ function taskCard(task) {
   requestLabel.textContent = "Request";
   const request = document.createElement("span");
   request.className = "preserve-lines";
-  request.textContent = latest.requestSummary;
+  appendLinkedText(request, latest.requestSummary, task);
   const resultLabel = document.createElement("strong");
   resultLabel.textContent = "Result";
   const result = document.createElement("span");
   result.className = "preserve-lines";
-  result.textContent = latest.resultSummary;
+  appendLinkedText(result, latest.resultSummary, task);
   summary.replaceChildren(requestLabel, request, resultLabel, result);
   const relatedLinks = relatedGitHubLinks(task, { compact: true });
   const time = timestampControl(

package/src/dashboard/github-links.js

@@ -1,5 +1,6 @@
 const GITHUB_REPOSITORY = /^[A-Za-z0-9](?:[A-Za-z0-9-]{0,38})\/[A-Za-z0-9._-]+$/;
-const REFERENCE_PATTERN = /https?:\/\/(?:www\.)?github\.com\/([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9._-]+)\/(issues|pull)\/([1-9]\d*)(?![A-Za-z0-9_])|([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9._-]+)#([1-9]\d*)(?![A-Za-z0-9_])|#([1-9]\d*)(?![A-Za-z0-9_])|https?:\/\/(?:www\.)?github\.com\/([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9](?:[A-Za-z0-9._-]*[A-Za-z0-9_-])?)\/?(?=$|[\s),.;:!?'"\]}>])/gi;
+const REFERENCE_PATTERN = /https?:\/\/(?:www\.)?github\.com\/([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9._-]+)\/(issues|pull)\/([1-9]\d*)(?![A-Za-z0-9_])|([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9._-]+)#([1-9]\d*)(?![A-Za-z0-9_])|#([1-9]\d*)(?![A-Za-z0-9_])|https?:\/\/(?:www\.)?github\.com\/([A-Za-z0-9](?:[A-Za-z0-9-]{0,38}))\/([A-Za-z0-9](?:[A-Za-z0-9._-]*[A-Za-z0-9_-])?)\/?(?=$|[\s#),.;:!?'"\]}>])/gi;
+const ABSOLUTE_HTTP_PATTERN = /https?:\/\/[^\s<>"'`]+/gi;
 export const MAX_RELATED_GITHUB_LINKS = 20;
 
 function canonicalRepository(owner, repository) {
@@ -23,10 +24,35 @@ export function normalizeGitHubRepository(value) {
 
 function rawReferences(text) {
   const value = String(text ?? "");
+  const absoluteRanges = absoluteHttpCandidates(value);
   const references = [];
   for (const match of value.matchAll(REFERENCE_PATTERN)) {
     const start = match.index;
     const preceding = start > 0 ? value[start - 1] : "";
+    let explicitAbsoluteUrl = null;
+    const containingAbsoluteUrl = absoluteRanges.find((range) => (
+      start >= range.start && start < range.end
+    ));
+    if (containingAbsoluteUrl) {
+      const explicitGitHubUrl = Boolean(match[1] || match[9]);
+      let absoluteHost = null;
+      try {
+        absoluteHost = new URL(containingAbsoluteUrl.text).hostname.toLowerCase();
+      } catch {
+        // Invalid absolute URL tokens still block nested shorthand recognition.
+      }
+      const completeGitHubUrl = explicitGitHubUrl
+        && start === containingAbsoluteUrl.start
+        && (absoluteHost === "github.com" || absoluteHost === "www.github.com");
+      if (!completeGitHubUrl) continue;
+      const safeUrl = safeAbsoluteHttpUrl(containingAbsoluteUrl.text);
+      if (!safeUrl) continue;
+      explicitAbsoluteUrl = {
+        end: containingAbsoluteUrl.end,
+        suffix: containingAbsoluteUrl.text.slice(match[0].length),
+        text: containingAbsoluteUrl.text,
+      };
+    }
     if (match[8] && /[\w&#/]/.test(preceding)) continue;
     if ((match[5] || match[1] || match[9]) && /[\w/]/.test(preceding)) continue;
 
@@ -45,14 +71,15 @@ function rawReferences(text) {
       [owner, repository] = normalized.split("/");
     }
     references.push({
-      end: start + match[0].length,
+      end: explicitAbsoluteUrl?.end ?? start + match[0].length,
       explicit,
       number,
       owner,
       repository,
       start,
-      text: match[0],
+      text: explicitAbsoluteUrl?.text ?? match[0],
       type,
+      urlSuffix: explicitAbsoluteUrl?.suffix ?? "",
     });
   }
   return references;
@@ -83,26 +110,111 @@ function resolvedReference(reference, repositoryContext) {
   if (reference.type === "repository") {
     return {
       kind: "link",
+      label: `${owner}/${repositoryName}`,
       number: null,
       owner,
+      provider: "github",
       repository: repositoryName,
       text: reference.text,
       type: reference.type,
-      url: `https://github.com/${owner}/${repositoryName}`,
+      url: `https://github.com/${owner}/${repositoryName}${reference.urlSuffix}`,
     };
   }
   const path = reference.type === "pull" ? "pull" : "issues";
   return {
     kind: "link",
+    label: `${owner}/${repositoryName}#${reference.number}`,
     number: reference.number,
     owner,
+    provider: "github",
     repository: repositoryName,
     text: reference.text,
     type: reference.type,
-    url: `https://github.com/${owner}/${repositoryName}/${path}/${reference.number}`,
+    url: `https://github.com/${owner}/${repositoryName}/${path}/${reference.number}${reference.urlSuffix}`,
   };
 }
 
+function trimAbsoluteUrl(candidate) {
+  let trimmed = candidate;
+  let previous;
+  do {
+    previous = trimmed;
+    trimmed = trimmed.replace(/[.,;:!?]+$/u, "");
+    for (const [opening, closing] of [["(", ")"], ["[", "]"], ["{", "}"]]) {
+      while (trimmed.endsWith(closing)) {
+        const openings = [...trimmed].filter((character) => character === opening).length;
+        const closings = [...trimmed].filter((character) => character === closing).length;
+        if (closings <= openings) break;
+        trimmed = trimmed.slice(0, -1);
+      }
+    }
+  } while (trimmed !== previous);
+  return trimmed;
+}
+
+function absoluteHttpCandidates(text) {
+  const candidates = [];
+  for (const match of String(text ?? "").matchAll(ABSOLUTE_HTTP_PATTERN)) {
+    const candidate = trimAbsoluteUrl(match[0]);
+    if (!candidate) continue;
+    candidates.push({
+      end: match.index + candidate.length,
+      start: match.index,
+      text: candidate,
+    });
+  }
+  return candidates;
+}
+
+function hasDotPathSegment(candidate) {
+  const authorityAndPath = candidate.slice(candidate.indexOf("//") + 2).split(/[?#]/u, 1)[0];
+  const pathStart = authorityAndPath.indexOf("/");
+  if (pathStart < 0) return false;
+  return authorityAndPath.slice(pathStart).split("/").some((segment) => {
+    try {
+      const decoded = decodeURIComponent(segment);
+      return decoded === "." || decoded === "..";
+    } catch {
+      return true;
+    }
+  });
+}
+
+function safeAbsoluteHttpUrl(candidate) {
+  try {
+    const url = new URL(candidate);
+    if (
+      !url.hostname
+      || url.username
+      || url.password
+      || candidate.includes("\\")
+      || hasDotPathSegment(candidate)
+    ) return null;
+    return url.href;
+  } catch {
+    return null;
+  }
+}
+
+function rawAbsoluteHttpReferences(text) {
+  const references = [];
+  for (const candidate of absoluteHttpCandidates(text)) {
+    const url = safeAbsoluteHttpUrl(candidate.text);
+    if (!url) continue;
+    references.push({
+      end: candidate.end,
+      kind: "link",
+      label: candidate.text,
+      provider: "web",
+      start: candidate.start,
+      text: candidate.text,
+      type: "url",
+      url,
+    });
+  }
+  return references;
+}
+
 export function githubReferenceSegments(text, {
   projectRepositories = [],
   taskRepository = null,
@@ -134,6 +246,45 @@ export function githubReferenceSegments(text, {
   return segments;
 }
 
+export function referenceSegments(text, options = {}) {
+  const value = String(text ?? "");
+  const githubSegments = githubReferenceSegments(value, options);
+  const references = [];
+  let cursor = 0;
+  for (const segment of githubSegments) {
+    const start = value.indexOf(segment.text, cursor);
+    if (start < 0) continue;
+    if (segment.kind !== "text") {
+      references.push({ end: start + segment.text.length, segment, start });
+    }
+    cursor = start + segment.text.length;
+  }
+  const absoluteReferences = rawAbsoluteHttpReferences(value).filter((reference) => (
+    !references.some(({ end, start }) => reference.start < end && reference.end > start)
+  ));
+  if (absoluteReferences.length === 0) return githubSegments;
+
+  references.push(...absoluteReferences.map((segment) => ({
+    end: segment.end,
+    segment,
+    start: segment.start,
+  })));
+  references.sort((left, right) => left.start - right.start);
+
+  const segments = [];
+  let offset = 0;
+  for (const reference of references) {
+    if (reference.start < offset) continue;
+    if (reference.start > offset) {
+      segments.push({ kind: "text", text: value.slice(offset, reference.start) });
+    }
+    segments.push(reference.segment);
+    offset = reference.end;
+  }
+  if (offset < value.length) segments.push({ kind: "text", text: value.slice(offset) });
+  return segments;
+}
+
 function taskTexts(task) {
   const texts = [task.instruction];
   for (const turn of task.turns ?? []) {
@@ -146,16 +297,9 @@ function taskTexts(task) {
   return texts.filter((text) => typeof text === "string" && text.length > 0);
 }
 
-function relatedLinkLabel(link, includeRepository, includeOwner) {
+function relatedLinkLabel(link) {
   if (link.type === "repository") return `${link.owner}/${link.repository}`;
-  const reference = link.type === "pull"
-    ? `PR #${link.number}`
-    : link.type === "issue"
-      ? `Issue #${link.number}`
-      : `#${link.number}`;
-  if (!includeRepository) return reference;
-  const repository = includeOwner ? `${link.owner}/${link.repository}` : link.repository;
-  return `${repository} ${reference}`;
+  return `${link.owner}/${link.repository}#${link.number}`;
 }
 
 export function taskGitHubProjection(task) {
@@ -179,7 +323,7 @@ export function taskGitHubProjection(task) {
       taskRepository,
     })) {
       if (segment.kind !== "link") continue;
-      const key = segment.url.toLowerCase();
+      const key = segment.url;
       if (seen.has(key)) continue;
       if (links.length === MAX_RELATED_GITHUB_LINKS) {
         truncated = true;
@@ -189,17 +333,9 @@ export function taskGitHubProjection(task) {
       links.push(segment);
     }
   }
-  const repositories = new Set(links.map(({ owner, repository }) => `${owner}/${repository}`));
-  const repositoryNames = new Map();
-  for (const link of links) {
-    const owners = repositoryNames.get(link.repository) ?? new Set();
-    owners.add(link.owner);
-    repositoryNames.set(link.repository, owners);
-  }
-  const includeRepository = repositories.size > 1;
   return {
     relatedGitHubLinks: links.map((link) => ({
-      label: relatedLinkLabel(link, includeRepository, repositoryNames.get(link.repository).size > 1),
+      label: relatedLinkLabel(link),
       number: link.number,
       owner: link.owner,
       repository: link.repository,