task-manager-logic 0.1.5 → 0.1.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "task-manager-logic",
-  "version": "0.1.5",
+  "version": "0.1.6",
   "private": false,
   "description": "Runtime-first TaskSpace transition processors and backend-neutral in-memory owner",
   "type": "module",

package/src/processors.ts

@@ -497,15 +497,10 @@ export async function replanTask(
     tasks: input.plan.tasks,
     relations: input.plan.relations,
   };
+  assertReplanDurableTasksImmutable(snapshot, definition);
   validateTaskSpaceDefinition(definition, normalizeTaskProcessorConfig(config));
   const artifactBodies = input.artifactBodies ?? [];
   await assertArtifactAuthority(runtime.owner, input.taskSpaceId, definition.tasks.flatMap(({ inputArtifacts }) => inputArtifacts), artifactBodies);
-  const nextIds = new Set(definition.tasks.map(({ taskId }) => taskId));
-  for (const prior of snapshot.tasks) {
-    if (!nextIds.has(prior.taskId) && (isTerminal(prior.status) || prior.activeClaim)) {
-      throw new TaskManagerError('terminal-task-immutable', `replan cannot remove durable task ${prior.taskId}`);
-    }
-  }
   const provisional: TaskRecord[] = definition.tasks.map((nextDefinition) => {
     const prior = taskRecordById(snapshot, nextDefinition.taskId);
     if (prior) return { ...prior, definition: nextDefinition, updatedAt: input.replannedAt };
@@ -714,6 +709,40 @@ function replaceTask(snapshot: TaskSpaceSnapshot, replacement: TaskRecord): Task
   return snapshot.tasks.map((task) => task.taskId === replacement.taskId ? replacement : task);
 }
 
+function assertReplanDurableTasksImmutable(
+  snapshot: TaskSpaceSnapshot,
+  nextDefinition: TaskSpaceDefinition,
+): void {
+  for (const prior of snapshot.tasks) {
+    const next = nextDefinition.tasks.find(({ taskId }) => taskId === prior.taskId);
+    if (!next) {
+      if (isTerminal(prior.status) || prior.activeClaim) {
+        throw new TaskManagerError('terminal-task-immutable', `replan cannot remove durable task ${prior.taskId}`);
+      }
+      continue;
+    }
+    if (!isTerminal(prior.status)) continue;
+    const priorRelations = incidentRelations(snapshot.definition, prior.taskId);
+    const nextRelations = incidentRelations(nextDefinition, prior.taskId);
+    if (canonicalOwnDataDigest(prior.definition) !== canonicalOwnDataDigest(next)
+      || canonicalOwnDataDigest(priorRelations) !== canonicalOwnDataDigest(nextRelations)) {
+      throw new TaskManagerError(
+        'terminal-task-immutable',
+        `replan cannot rewrite terminal task ${prior.taskId} definition, profile, identity or relations`,
+      );
+    }
+  }
+}
+
+function incidentRelations(
+  definition: TaskSpaceDefinition,
+  taskId: TaskId,
+): TaskSpaceDefinition['relations'] {
+  return definition.relations.filter((relation) => relation.kind === 'parent-child'
+    ? relation.parentTaskId === taskId || relation.childTaskId === taskId
+    : relation.predecessorTaskId === taskId || relation.successorTaskId === taskId);
+}
+
 function dependenciesSucceeded(
   completionGraph: TaskCompletionGraph,
   tasks: readonly TaskRecord[],