tarsk 0.5.74 → 0.5.76

package/dist/bundled-skills/skill-creator/scripts/__tests__/quick_validate.test.js

@@ -0,0 +1,79 @@
+const assert = require("node:assert/strict");
+const fs = require("node:fs");
+const os = require("node:os");
+const path = require("node:path");
+const test = require("node:test");
+
+const { validateSkill } = require("../quick_validate.js");
+
+function withSkill(content, callback) {
+  const skillPath = fs.mkdtempSync(path.join(os.tmpdir(), "tarsk-skill-"));
+  try {
+    if (content !== null) fs.writeFileSync(path.join(skillPath, "SKILL.md"), content);
+    return callback(skillPath);
+  } finally {
+    fs.rmSync(skillPath, { recursive: true, force: true });
+  }
+}
+
+test("validates a skill with supported frontmatter", () => {
+  const result = withSkill(
+    "---\nname: example-skill\ndescription: A useful skill\ncompatibility: Works everywhere\n---\n",
+    (skillPath) => validateSkill(skillPath),
+  );
+  assert.deepEqual(result, [true, "Skill is valid!"]);
+});
+
+test("rejects missing and malformed skill files", () => {
+  assert.deepEqual(withSkill(null, validateSkill), [false, "SKILL.md not found"]);
+  assert.deepEqual(withSkill("Skill content", validateSkill), [false, "No YAML frontmatter found"]);
+  assert.deepEqual(withSkill("---\nname: example\n", validateSkill), [
+    false,
+    "Invalid frontmatter format",
+  ]);
+});
+
+test("rejects invalid frontmatter properties and required fields", () => {
+  assert.match(
+    withSkill("---\nname: example\ndescription: test\nunknown: value\n---\n", validateSkill)[1],
+    /Unexpected key\(s\)/,
+  );
+  assert.deepEqual(withSkill("---\ndescription: test\n---\n", validateSkill), [
+    false,
+    "Missing 'name' in frontmatter",
+  ]);
+  assert.deepEqual(withSkill("---\nname: example\n---\n", validateSkill), [
+    false,
+    "Missing 'description' in frontmatter",
+  ]);
+});
+
+test("rejects invalid name, description, and compatibility values", () => {
+  assert.match(
+    withSkill("---\nname: Bad Name\ndescription: test\n---\n", validateSkill)[1],
+    /should be kebab-case/,
+  );
+  assert.match(
+    withSkill("---\nname: -bad\ndescription: test\n---\n", validateSkill)[1],
+    /cannot start\/end with hyphen/,
+  );
+  assert.match(
+    withSkill(`---\nname: ${"a".repeat(65)}\ndescription: test\n---\n`, validateSkill)[1],
+    /Name is too long/,
+  );
+  assert.deepEqual(withSkill("---\nname: example\ndescription: <unsafe>\n---\n", validateSkill), [
+    false,
+    "Description cannot contain angle brackets (< or >)",
+  ]);
+  assert.match(
+    withSkill(`---\nname: example\ndescription: ${"a".repeat(1025)}\n---\n`, validateSkill)[1],
+    /Description is too long/,
+  );
+  assert.match(
+    withSkill(
+      "---\nname: example\ndescription: test\ncompatibility: " + "a".repeat(501) + "\n---\n",
+      validateSkill,
+    )[1],
+    /Compatibility is too long/,
+  );
+});

package/dist/bundled-skills/skill-creator/scripts/quick_validate.js

@@ -34,29 +34,7 @@ function parseSimpleFrontmatter(text) {
   return frontmatter;
 }
 
-function validateSkill(skillPath) {
-  skillPath = path.resolve(skillPath);
-  const skillMd = path.join(skillPath, "SKILL.md");
-
-  if (!fs.existsSync(skillMd)) {
-    return [false, "SKILL.md not found"];
-  }
-
-  const content = fs.readFileSync(skillMd, "utf-8");
-  if (!content.startsWith("---")) {
-    return [false, "No YAML frontmatter found"];
-  }
-
-  const match = content.match(/^---\n([\s\S]*?)\n---/);
-  if (!match) {
-    return [false, "Invalid frontmatter format"];
-  }
-
-  const frontmatter = parseSimpleFrontmatter(match[1]);
-  if (!frontmatter || typeof frontmatter !== "object") {
-    return [false, "Frontmatter must be a YAML dictionary"];
-  }
-
+function validateFrontmatter(frontmatter) {
   const unexpectedKeys = Object.keys(frontmatter).filter((key) => !ALLOWED_PROPERTIES.has(key));
   if (unexpectedKeys.length > 0) {
     return [
@@ -66,56 +44,91 @@ function validateSkill(skillPath) {
     ];
   }
 
-  if (!("name" in frontmatter)) {
-    return [false, "Missing 'name' in frontmatter"];
+  if (!("name" in frontmatter)) return [false, "Missing 'name' in frontmatter"];
+  if (!("description" in frontmatter)) return [false, "Missing 'description' in frontmatter"];
+  return [true, ""];
+}
+
+function validateName(name) {
+  if (!name) return [true, ""];
+  const failure = [
+    [
+      !/^[a-z0-9-]+$/.test(name),
+      `Name '${name}' should be kebab-case (lowercase letters, digits, and hyphens only)`,
+    ],
+    [
+      /^-|-$|--/.test(name),
+      `Name '${name}' cannot start/end with hyphen or contain consecutive hyphens`,
+    ],
+    [name.length > 64, `Name is too long (${name.length} characters). Maximum is 64 characters.`],
+  ].find(function (result) {
+    return result[0];
+  });
+  return failure ? [false, failure[1]] : [true, ""];
+}
+
+function validateDescription(description) {
+  if (!description) return [true, ""];
+  if (description.includes("<") || description.includes(">")) {
+    return [false, "Description cannot contain angle brackets (< or >)"];
   }
-  if (!("description" in frontmatter)) {
-    return [false, "Missing 'description' in frontmatter"];
+  if (description.length > 1024) {
+    return [
+      false,
+      `Description is too long (${description.length} characters). Maximum is 1024 characters.`,
+    ];
   }
+  return [true, ""];
+}
 
-  const name = String(frontmatter.name ?? "").trim();
-  if (name) {
-    if (!/^[a-z0-9-]+$/.test(name)) {
-      return [
-        false,
-        `Name '${name}' should be kebab-case (lowercase letters, digits, and hyphens only)`,
-      ];
-    }
-    if (name.startsWith("-") || name.endsWith("-") || name.includes("--")) {
-      return [false, `Name '${name}' cannot start/end with hyphen or contain consecutive hyphens`];
-    }
-    if (name.length > 64) {
-      return [false, `Name is too long (${name.length} characters). Maximum is 64 characters.`];
-    }
+function validateCompatibility(compatibility) {
+  if (!compatibility) return [true, ""];
+  if (typeof compatibility !== "string") {
+    return [false, `Compatibility must be a string, got ${typeof compatibility}`];
   }
-
-  const description = String(frontmatter.description ?? "").trim();
-  if (description) {
-    if (description.includes("<") || description.includes(">")) {
-      return [false, "Description cannot contain angle brackets (< or >)"];
-    }
-    if (description.length > 1024) {
-      return [
-        false,
-        `Description is too long (${description.length} characters). Maximum is 1024 characters.`,
-      ];
-    }
+  if (compatibility.length > 500) {
+    return [
+      false,
+      `Compatibility is too long (${compatibility.length} characters). Maximum is 500 characters.`,
+    ];
   }
+  return [true, ""];
+}
 
-  const compatibility = frontmatter.compatibility;
-  if (compatibility) {
-    if (typeof compatibility !== "string") {
-      return [false, `Compatibility must be a string, got ${typeof compatibility}`];
-    }
-    if (compatibility.length > 500) {
-      return [
-        false,
-        `Compatibility is too long (${compatibility.length} characters). Maximum is 500 characters.`,
-      ];
-    }
+function readSkillFrontmatter(skillMd) {
+  if (!fs.existsSync(skillMd)) return [false, "SKILL.md not found"];
+
+  const content = fs.readFileSync(skillMd, "utf-8");
+  if (!content.startsWith("---")) return [false, "No YAML frontmatter found"];
+
+  const match = content.match(/^---\n([\s\S]*?)\n---/);
+  if (!match) return [false, "Invalid frontmatter format"];
+
+  const frontmatter = parseSimpleFrontmatter(match[1]);
+  if (!frontmatter || typeof frontmatter !== "object") {
+    return [false, "Frontmatter must be a YAML dictionary"];
   }
+  return [true, frontmatter];
+}
 
-  return [true, "Skill is valid!"];
+function isFailedValidation(result) {
+  return !result[0];
+}
+
+function validateSkill(skillPath) {
+  const skillMd = path.join(path.resolve(skillPath), "SKILL.md");
+  const frontmatterReadResult = readSkillFrontmatter(skillMd);
+  if (!frontmatterReadResult[0]) return frontmatterReadResult;
+
+  const frontmatter = frontmatterReadResult[1];
+  const failedValidation = [
+    validateFrontmatter(frontmatter),
+    validateName(String(frontmatter.name ?? "").trim()),
+    validateDescription(String(frontmatter.description ?? "").trim()),
+    validateCompatibility(frontmatter.compatibility),
+  ].find(isFailedValidation);
+
+  return failedValidation ?? [true, "Skill is valid!"];
 }
 
 if (require.main === module) {