tango-app-api-infra 3.9.5-vms.84 → 3.9.5-vms.86

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "tango-app-api-infra",
-    "version": "3.9.5-vms.84",
+    "version": "3.9.5-vms.86",
     "description": "infra",
     "main": "index.js",
     "type": "module",

package/src/controllers/footfallDirectory.controllers.js

@@ -902,7 +902,11 @@ export async function ticketSummary( req, res ) {
     const userInfo = req.user;
     const ticketsFeature = userInfo?.rolespermission?.some( ( f ) => f.featureName === 'FootfallDirectory' && ( f.modules.find( ( m ) => m.name == 'reviewer' && ( m.isAdd == true || m.isEdit == true ) ) ) );
     const ticketsApproveFeature = userInfo?.rolespermission?.some( ( f ) => f.featureName === 'FootfallDirectory' && ( f.modules.find( ( m ) => m.name == 'approver' && ( m.isAdd == true || m.isEdit == true ) ) ) );
-
+    const getConfig = await findOneClient( { clientId: inputData?.clientId }, { footfallDirectoryConfigs: 1 } );
+    if ( !getConfig || getConfig ==null ) {
+      return res.sendError( 'this client not configured against footfall directory', 400 );
+    }
+    inputData.clientId = inputData?.clientId?.split( ',' );
     // const ticketsApproveFeature = userInfo?.rolespermission?.some( ( f ) => f.featureName === 'FootfallDirectory' && ( f.modules.find( ( m ) => m.name == 'approver' && ( m.isAdd == true || m.isEdit == true ) ) ) );
     if ( req?.user?.userType === 'tango' ) {
       switch ( inputData?.tangoType ) {
@@ -921,6 +925,24 @@ export async function ticketSummary( req, res ) {
                       },
                     },
                   },
+
+                  {
+                    terms: {
+                      'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                        inputData.clientId :
+                        [ inputData.clientId ],
+                    },
+
+                  },
+
+                  {
+                    range: {
+                      reviced: {
+                        lt: parseInt( getConfig?.footfallDirectoryConfigs?.tangoReview ),
+                      }
+                      ,
+                    },
+                  },
                   {
                     nested: {
                       path: 'mappingInfo',
@@ -983,20 +1005,7 @@ export async function ticketSummary( req, res ) {
               size: 0,
               aggs: {
                 avg_value: {
-                  avg: {
-                    script: {
-                      lang: 'painless',
-                      source: `
-            if (doc['revicedPerc.keyword'].size() == 0) return null;
-  String v = doc['revicedPerc.keyword'].value.replace('%','');
-  try {
-    return Double.parseDouble(v);
-  } catch (Exception e) { 
-    return null; 
-  }
-          `,
-                    },
-                  },
+                  avg: 'reviced',
                 },
               },
             };
@@ -1029,11 +1038,10 @@ export async function ticketSummary( req, res ) {
           // openInfraIssues: mappingInfo.status: 'Open Accuracy Issue'
           let openInfraIssues = 0;
 
-          let oiQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open Accuracy Issue' );
+          let oiQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open - Accuracy Issue' );
           oiQ.size = 0;
           const infraResp = await getOpenSearchData( openSearch.footfallDirectory, oiQ );
           openInfraIssues = infraResp?.body?.hits?.total?.value || 0;
-
           // inprogress: mappingInfo.status: 'in-Progress'
           let inprogress = 0;
 
@@ -1063,14 +1071,9 @@ export async function ticketSummary( req, res ) {
           // For this, add a filter on revicedPerc >= 85
           let aboveQ = buildAggStoreQuery( baseStoreQuery, [
             {
-              script: {
-                script: {
-                  lang: 'painless',
-                  source: `
-                    doc['revicedPerc.keyword'].size()!=0 &&
-                    Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) >= params.num
-                  `,
-                  params: { num: 85 },
+              range: {
+                reviced: {
+                  gte: parseInt( getConfig?.footfallDirectoryConfigs?.tangoReview ),
                 },
               },
             },
@@ -1085,14 +1088,9 @@ export async function ticketSummary( req, res ) {
 
           let belowQ = buildAggStoreQuery( baseStoreQuery, [
             {
-              script: {
-                script: {
-                  lang: 'painless',
-                  source: `
-                    doc['revicedPerc.keyword'].size()!=0 &&
-                    Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) < params.num
-                  `,
-                  params: { num: 85 },
+              range: {
+                reviced: {
+                  lt: parseInt( getConfig?.footfallDirectoryConfigs?.tangoReview ),
                 },
               },
             },
@@ -1128,23 +1126,48 @@ export async function ticketSummary( req, res ) {
                       },
                     },
                   },
+                  {
+                    terms: {
+                      'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                        inputData.clientId :
+                        [ inputData.clientId ],
+                    },
+
+                  },
+
+                ],
+              },
+            },
+          };
 
+          const internalOpen = {
+            size: 0,
+            query: {
+              bool: {
+                must: [
                   {
-                    nested: {
-                      path: 'mappingInfo',
-                      query: {
-                        bool: {
-                          must: [
-                            {
-                              terms: {
-                                'mappingInfo.type': [ 'tagging', 'review', 'approve', 'tangoreview' ],
-                              },
-                            },
-                          ],
-                        },
+                    'range': {
+                      'dateString': {
+                        'gte': inputData?.fromDate,
+                        'lte': inputData?.toDate,
+                        'format': 'yyyy-MM-dd',
                       },
                     },
                   },
+                  {
+                    terms: {
+                      'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                        inputData.clientId :
+                        [ inputData.clientId ],
+                    },
+
+                  },
+                  {
+                    terms: {
+                      'status.keyword': [ 'Open', 'Raised' ],
+                    },
+
+                  },
 
                 ],
               },
@@ -1154,20 +1177,32 @@ export async function ticketSummary( req, res ) {
           // Helper function to clone deep and replace mappingInfo.status for openTickets/closed/etc
           function buildInternalQueryWithStatus( baseQuery, statusValue ) {
             let q = JSON.parse( JSON.stringify( baseQuery ) );
-            // Remove any previous mappingInfo.status term
+            // Check if nested query exists, if not create it
             let nested = q.query.bool.must.find( ( m ) => m.nested );
-            if ( nested ) {
-              // filter out all mappingInfo.status
-              nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
-                return !( mustItem.term && mustItem.term['mappingInfo.status'] );
-              } );
-              // add desired status
-              nested.nested.query.bool.must.push( {
-                term: {
-                  'mappingInfo.status': statusValue,
+            if ( !nested ) {
+              // Create nested query structure
+              nested = {
+                nested: {
+                  path: 'mappingInfo',
+                  query: {
+                    bool: {
+                      must: [],
+                    },
+                  },
                 },
-              } );
+              };
+              q.query.bool.must.push( nested );
             }
+            // filter out all mappingInfo.status
+            nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
+              return !( mustItem.term && mustItem.term['mappingInfo.status'] );
+            } );
+            // add desired status
+            nested.nested.query.bool.must.push( {
+              term: {
+                'mappingInfo.status': statusValue,
+              },
+            } );
             return q;
           }
 
@@ -1183,7 +1218,7 @@ export async function ticketSummary( req, res ) {
                 nested.nested.query.bool.must.filter( ( m ) => !( m.term && m.term['mappingInfo.status'] ) );
 
               // add new filters
-              nested.nested.query.bool.must.push( ...filters );
+              q.query.bool.must.push( ...filters );
             }
 
             return {
@@ -1192,18 +1227,7 @@ export async function ticketSummary( req, res ) {
               aggs: {
                 avg_value: {
                   avg: {
-                    script: {
-                      lang: 'painless',
-                      source: `
-            if (doc['revicedPerc.keyword'].size() == 0) return null;
-  String v = doc['revicedPerc.keyword'].value.replace('%','');
-  try {
-    return Double.parseDouble(v);
-  } catch (Exception e) { 
-    return null; 
-  }
-          `,
-                    },
+                    field: 'reviced',
                   },
                 },
               },
@@ -1224,13 +1248,14 @@ export async function ticketSummary( req, res ) {
           allInternalQuery.size = 0;
           const totalInternalResp = await getOpenSearchData( openSearch.footfallDirectory, allInternalQuery );
           totalInternalTickets = totalInternalResp?.body?.hits?.total?.value || 0;
+          logger.info( { totalInternalResp } );
 
           // openTickets: mappingInfo.status: 'Open'
           let openInternalTickets = 0;
 
-          let otQInternal = buildInternalQueryWithStatus( baseInternalQuery, 'Open' );
-          otQInternal.size = 0;
-          const openInternalResp = await getOpenSearchData( openSearch.footfallDirectory, otQInternal );
+          // let otQInternal = buildInternalQueryWithStatus( baseInternalQuery, 'Open' );
+          // otQInternal.size = 0;
+          const openInternalResp = await getOpenSearchData( openSearch.footfallDirectory, internalOpen );
           openInternalTickets = openInternalResp?.body?.hits?.total?.value || 0;
           // logger.info( { msd: '..............2', openResp } );
 
@@ -1238,11 +1263,12 @@ export async function ticketSummary( req, res ) {
           // openInfraIssues: mappingInfo.status: 'Open Accuracy Issue'
           let openInternalInfraIssues = 0;
 
-          let oiQinternal = buildInternalQueryWithStatus( baseInternalQuery, 'Open Accuracy Issue' );
+          let oiQinternal = buildInternalQueryWithStatus( baseInternalQuery, 'Open - Accuracy Issue' );
           oiQinternal.size = 0;
           const infraInternalResp = await getOpenSearchData( openSearch.footfallDirectory, oiQinternal );
           openInternalInfraIssues = infraInternalResp?.body?.hits?.total?.value || 0;
 
+
           // inprogress: mappingInfo.status: 'in-Progress'
           let inprogressIntrenal = 0;
 
@@ -1272,14 +1298,9 @@ export async function ticketSummary( req, res ) {
           // For this, add a filter on revicedPerc >= 85
           let aboveQinternal = buildAggInternalQuery( baseInternalQuery, [
             {
-              script: {
-                script: {
-                  lang: 'painless',
-                  source: `
-                    doc['revicedPerc.keyword'].size()!=0 &&
-                    Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) >= params.num
-                  `,
-                  params: { num: 85 },
+              range: {
+                reviced: {
+                  gte: parseInt( getConfig?.footfallDirectoryConfigs?.tangoReview ),
                 },
               },
             },
@@ -1294,14 +1315,9 @@ export async function ticketSummary( req, res ) {
 
           let belowQIneranl = buildAggInternalQuery( baseInternalQuery, [
             {
-              script: {
-                script: {
-                  lang: 'painless',
-                  source: `
-                    doc['revicedPerc.keyword'].size()!=0 &&
-                    Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) < params.num
-                  `,
-                  params: { num: 85 },
+              range: {
+                reviced: {
+                  lt: parseInt( getConfig?.footfallDirectoryConfigs?.tangoReview ),
                 },
               },
             },
@@ -1324,7 +1340,7 @@ export async function ticketSummary( req, res ) {
           break;
         default: '';
       }
-    } else if ( req?.user?.userType === 'client' ) {
+    } else if ( req?.user?.userType !== 'tango' ) {
       if ( ticketsFeature && !ticketsApproveFeature ) {
         const storeQuery = {
           size: 0,
@@ -1340,6 +1356,14 @@ export async function ticketSummary( req, res ) {
                     },
                   },
                 },
+                {
+                  terms: {
+                    'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                      inputData.clientId :
+                      [ inputData.clientId ],
+                  },
+
+                },
                 {
                   nested: {
                     path: 'mappingInfo',
@@ -1402,20 +1426,7 @@ export async function ticketSummary( req, res ) {
             size: 0,
             aggs: {
               avg_value: {
-                avg: {
-                  script: {
-                    lang: 'painless',
-                    source: `
-          if (doc['revicedPerc.keyword'].size() == 0) return null;
-String v = doc['revicedPerc.keyword'].value.replace('%','');
-try {
-  return Double.parseDouble(v);
-} catch (Exception e) { 
-  return null; 
-}
-        `,
-                  },
-                },
+                avg: 'mappingInfo.reviced',
               },
             },
           };
@@ -1490,48 +1501,44 @@ try {
         const eResp = await getOpenSearchData( openSearch.footfallDirectory, eQ );
         expiredTickets = eResp?.body?.hits?.total?.value || 0;
 
-        let ticketAccuracyAbove = 0;
-        // For this, add a filter on revicedPerc >= 85
-        let aboveQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
+        // Calculate average ticket percentage: avg((reviced/footfallCount)*100) filtered by baseStoreQuery
+
+        // Build aggregation query for ticket percentage
+        let ticketPercentageAvg = 0;
+
+        let avgTicketPercentageQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+        avgTicketPercentageQuery.size = 0;
+        avgTicketPercentageQuery.aggs = {
+          avg_ticket_percentage: {
+            avg: {
               script: {
-                lang: 'painless',
                 source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) >= params.num
+                  if (doc.containsKey('reviced') && doc['reviced'].size()!=0 && 
+                      doc.containsKey('footfallCount') && doc['footfallCount'].size()!=0 && doc['footfallCount'].value != 0) {
+                    return (doc['reviced'].value / doc['footfallCount'].value) * 100;
+                  } else {
+                    return null;
+                  }
                 `,
-                params: { num: 85 },
+                lang: 'painless',
               },
             },
           },
+        };
 
+        const avgTicketPercentageResp = await getOpenSearchData( openSearch.footfallDirectory, avgTicketPercentageQuery );
 
-        ] );
-        const aboveResp = await getOpenSearchData( openSearch.footfallDirectory, aboveQ );
-        ticketAccuracyAbove = aboveResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+        ticketPercentageAvg = avgTicketPercentageResp?.body?.aggregations?.avg_ticket_percentage?.value?.toFixed( 2 ) || '0';
 
+        logger.info( { avgTicketPercentageResp } );
         // ticketAccuracyBelow: avg of revicedPerc < 85%
-        let ticketAccuracyBelow = 0;
-
-        let belowQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
-              script: {
-                lang: 'painless',
-                source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) < params.num
-                `,
-                params: { num: 85 },
-              },
-            },
-          },
-
-        ] );
-        const belowResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
-        ticketAccuracyBelow = belowResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+        let ticketAccuracy = 0;
 
+        let belowQ = buildAggStoreQuery( baseStoreQuery );
+        logger.info( { belowQ } );
+        const accuracyResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
+        ticketAccuracy = accuracyResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+        logger.info( { accuracyResp } );
         // Final result object
         result = {
           totalTickets,
@@ -1540,465 +1547,434 @@ try {
           closedTickets,
           dueToday: dueToday,
           Expired: expiredTickets,
-          avgTicket: ticketAccuracyAbove+'%',
-          avgAccuracy: ticketAccuracyBelow+'%',
+          avgTicket: ticketPercentageAvg+'%',
+          avgAccuracy: ticketAccuracy+'%',
         };
-      }
-    } else if ( ticketsFeature && ticketsApproveFeature ) {
-      if ( inputData?.permissionType === 'review' ) {
-        const storeQuery = {
-          size: 0,
-          query: {
-            bool: {
-              must: [
-                {
-                  'range': {
-                    'dateString': {
-                      'gte': inputData?.fromDate,
-                      'lte': inputData?.toDate,
-                      'format': 'yyyy-MM-dd',
+      } else if ( ticketsFeature && ticketsApproveFeature ) {
+        if ( inputData?.permissionType === 'review' ) {
+          const storeQuery = {
+            size: 0,
+            query: {
+              bool: {
+                must: [
+                  {
+                    'range': {
+                      'dateString': {
+                        'gte': inputData?.fromDate,
+                        'lte': inputData?.toDate,
+                        'format': 'yyyy-MM-dd',
+                      },
                     },
                   },
-                },
-                {
-                  nested: {
-                    path: 'mappingInfo',
-                    query: {
-                      bool: {
-                        must: [
-                          {
-                            term: {
-                              'mappingInfo.type': inputData.permissionType === 'review'? 'review':'approve',
+                  {
+                    terms: {
+                      'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                        inputData.clientId :
+                        [ inputData.clientId ],
+                    },
+
+                  },
+                  {
+                    nested: {
+                      path: 'mappingInfo',
+                      query: {
+                        bool: {
+                          must: [
+                            {
+                              term: {
+                                'mappingInfo.type': 'review',
+                              },
                             },
-                          },
-                        ],
+                          ],
+                        },
                       },
                     },
                   },
-                },
 
-              ],
+                ],
+              },
             },
-          },
-        };
+          };
 
-        // Helper function to clone deep and replace mappingInfo.status for openTickets/closed/etc
-        function buildStoreQueryWithStatus( baseQuery, statusValue ) {
-          let q = JSON.parse( JSON.stringify( baseQuery ) );
-          // Remove any previous mappingInfo.status term
-          let nested = q.query.bool.must.find( ( m ) => m.nested );
-          if ( nested ) {
-            // filter out all mappingInfo.status
-            nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
-              return !( mustItem.term && mustItem.term['mappingInfo.status'] );
-            } );
-            // add desired status
-            nested.nested.query.bool.must.push( {
-              term: {
-                'mappingInfo.status': statusValue,
-              },
-            } );
+          // Helper function to clone deep and replace mappingInfo.status for openTickets/closed/etc
+          function buildStoreQueryWithStatus( baseQuery, statusValue ) {
+            let q = JSON.parse( JSON.stringify( baseQuery ) );
+            // Remove any previous mappingInfo.status term
+            let nested = q.query.bool.must.find( ( m ) => m.nested );
+            if ( nested ) {
+              // filter out all mappingInfo.status
+              nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
+                return !( mustItem.term && mustItem.term['mappingInfo.status'] );
+              } );
+              // add desired status
+              nested.nested.query.bool.must.push( {
+                term: {
+                  'mappingInfo.status': statusValue,
+                },
+              } );
+            }
+            return q;
           }
-          return q;
-        }
 
-        const buildAggStoreQuery = ( baseQuery, filters = [] ) => {
-          const q = JSON.parse( JSON.stringify( baseQuery ) );
+          const buildAggStoreQuery = ( baseQuery, filters = [] ) => {
+            const q = JSON.parse( JSON.stringify( baseQuery ) );
 
-          // locate nested section
-          const nested = q.query.bool.must.find( ( m ) => m.nested );
+            // locate nested section
+            const nested = q.query.bool.must.find( ( m ) => m.nested );
 
-          if ( nested ) {
-            // remove old status filters
-            nested.nested.query.bool.must =
-              nested.nested.query.bool.must.filter( ( m ) => !( m.term && m.term['mappingInfo.status'] ) );
+            if ( nested ) {
+              // remove old status filters
+              nested.nested.query.bool.must =
+                nested.nested.query.bool.must.filter( ( m ) => !( m.term && m.term['mappingInfo.status'] ) );
 
-            // add new filters
-            nested.nested.query.bool.must.push( ...filters );
-          }
+              // add new filters
+              nested.nested.query.bool.must.push( ...filters );
+            }
 
-          return {
-            ...q,
-            size: 0,
-            aggs: {
-              avg_value: {
-                avg: {
-                  script: {
-                    lang: 'painless',
-                    source: `
-          if (doc['revicedPerc.keyword'].size() == 0) return null;
-  String v = doc['revicedPerc.keyword'].value.replace('%','');
-  try {
-  return Double.parseDouble(v);
-  } catch (Exception e) { 
-  return null; 
-  }
-        `,
-                  },
+            return {
+              ...q,
+              size: 0,
+              aggs: {
+                avg_value: {
+                  avg: 'mappingInfo.reviced',
                 },
               },
-            },
+            };
           };
-        };
 
 
-        // Get OpenSearch connection
-
-        const baseStoreQuery = JSON.parse( JSON.stringify( storeQuery ) );
-
-        // Total Tickets (all tickets with mappingInfo.type == tangoreview)
-        let totalTickets = 0;
+          // Get OpenSearch connection
 
-        let allQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          const baseStoreQuery = JSON.parse( JSON.stringify( storeQuery ) );
 
-        allQuery.size = 0;
-        const totalResp = await getOpenSearchData( openSearch.footfallDirectory, allQuery );
-        totalTickets = totalResp?.body?.hits?.total?.value || 0;
+          // Total Tickets (all tickets with mappingInfo.type == tangoreview)
+          let totalTickets = 0;
 
-        // openTickets: mappingInfo.status: 'Open'
-        let openTickets = 0;
+          let allQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
 
-        let otQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open' );
-        otQ.size = 0;
-        const openResp = await getOpenSearchData( openSearch.footfallDirectory, otQ );
-        openTickets = openResp?.body?.hits?.total?.value || 0;
-        // logger.info( { msd: '..............2', openResp } );
+          allQuery.size = 0;
+          const totalResp = await getOpenSearchData( openSearch.footfallDirectory, allQuery );
+          totalTickets = totalResp?.body?.hits?.total?.value || 0;
 
+          // openTickets: mappingInfo.status: 'Open'
+          let openTickets = 0;
 
-        // inprogress: mappingInfo.status: 'in-Progress'
-        let inprogress = 0;
+          let otQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open' );
+          otQ.size = 0;
+          const openResp = await getOpenSearchData( openSearch.footfallDirectory, otQ );
+          openTickets = openResp?.body?.hits?.total?.value || 0;
+          // logger.info( { msd: '..............2', openResp } );
 
-        let ipQ = buildStoreQueryWithStatus( baseStoreQuery, 'In-Progress' );
-        ipQ.size = 0;
-        const ipResp = await getOpenSearchData( openSearch.footfallDirectory, ipQ );
-        inprogress = ipResp?.body?.hits?.total?.value || 0;
 
-        // closedTickets: mappingInfo.status: 'closed'
-        let closedTickets = 0;
+          // inprogress: mappingInfo.status: 'in-Progress'
+          let inprogress = 0;
 
-        let clQ = buildStoreQueryWithStatus( baseStoreQuery, 'Closed' );
-        clQ.size = 0;
-        const clResp = await getOpenSearchData( openSearch.footfallDirectory, clQ );
-        closedTickets = clResp?.body?.hits?.total?.value || 0;
-        // Average revisedPerc (for all tangoreview)
+          let ipQ = buildStoreQueryWithStatus( baseStoreQuery, 'In-Progress' );
+          ipQ.size = 0;
+          const ipResp = await getOpenSearchData( openSearch.footfallDirectory, ipQ );
+          inprogress = ipResp?.body?.hits?.total?.value || 0;
 
-        // dueToday: Tickets whose dueDate is today (format 'yyyy-MM-dd')
-        let dueToday = 0;
-        let todayDateString = new Date().toISOString().slice( 0, 10 );
+          // closedTickets: mappingInfo.status: 'closed'
+          let closedTickets = 0;
 
-        // Build a query for tickets with mappingInfo.dueDate == todayDateString
-        let dueTodayQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
-        // Locate nested mappingInfo query
-        let nestedDue = dueTodayQuery.query.bool.must.find( ( m ) => m.nested );
-        if ( nestedDue ) {
-          // Remove any previous mappingInfo.dueDate term
-          nestedDue.nested.query.bool.must = nestedDue.nested.query.bool.must.filter(
-              ( mustItem ) => !( mustItem.term && mustItem.term['mappingInfo.dueDate'] ),
-          );
-          // Add new dueDate filter
-          nestedDue.nested.query.bool.must.push( {
-            term: { 'mappingInfo.dueDate': todayDateString },
-          } );
-        }
-        dueTodayQuery.size = 0;
-        const dueTodayResp = await getOpenSearchData( openSearch.footfallDirectory, dueTodayQuery );
-        dueToday = dueTodayResp?.body?.hits?.total?.value || 0;
+          let clQ = buildStoreQueryWithStatus( baseStoreQuery, 'Closed' );
+          clQ.size = 0;
+          const clResp = await getOpenSearchData( openSearch.footfallDirectory, clQ );
+          closedTickets = clResp?.body?.hits?.total?.value || 0;
 
+          let dueToday = 0;
+          let todayDateString = new Date().toISOString().slice( 0, 10 );
+
+          // Build a query for tickets with mappingInfo.dueDate == todayDateString
+          let dueTodayQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          // Locate nested mappingInfo query
+          let nestedDue = dueTodayQuery.query.bool.must.find( ( m ) => m.nested );
+          if ( nestedDue ) {
+            // Remove any previous mappingInfo.dueDate term
+            nestedDue.nested.query.bool.must = nestedDue.nested.query.bool.must.filter(
+                ( mustItem ) => !( mustItem.term && mustItem.term['mappingInfo.dueDate'] ),
+            );
+            // Add new dueDate filter
+            nestedDue.nested.query.bool.must.push( {
+              term: { 'mappingInfo.dueDate': todayDateString },
+            } );
+          }
+          dueTodayQuery.size = 0;
+          const dueTodayResp = await getOpenSearchData( openSearch.footfallDirectory, dueTodayQuery );
+          dueToday = dueTodayResp?.body?.hits?.total?.value || 0;
 
-        // filter expired Tickets
-        let expiredTickets = 0;
+          // filter expired Tickets
+          let expiredTickets = 0;
 
-        let eQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
-        eQ.size = 0;
-        const eResp = await getOpenSearchData( openSearch.footfallDirectory, eQ );
-        expiredTickets = eResp?.body?.hits?.total?.value || 0;
+          let eQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
+          eQ.size = 0;
+          const eResp = await getOpenSearchData( openSearch.footfallDirectory, eQ );
+          expiredTickets = eResp?.body?.hits?.total?.value || 0;
 
-        // ticketAccuracyAbove: avg of revicedPerc > 85%
-        let ticketAccuracyAbove = 0;
+          // Calculate average ticket percentage: avg((reviced/footfallCount)*100) filtered by baseStoreQuery
 
+          // Build aggregation query for ticket percentage
+          let ticketPercentageAvg = 0;
 
-        // For this, add a filter on revicedPerc >= 85
-        let aboveQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
-              script: {
-                lang: 'painless',
-                source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) >= params.num
-                `,
-                params: { num: 85 },
+          let avgTicketPercentageQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          avgTicketPercentageQuery.size = 0;
+          avgTicketPercentageQuery.aggs = {
+            avg_ticket_percentage: {
+              avg: {
+                script: {
+                  source: `
+                    if (doc.containsKey('reviced') && doc['reviced'].size()!=0 && 
+                        doc.containsKey('footfallCount') && doc['footfallCount'].size()!=0 && doc['footfallCount'].value != 0) {
+                      return (doc['reviced'].value / doc['footfallCount'].value) * 100;
+                    } else {
+                      return null;
+                    }
+                  `,
+                  lang: 'painless',
+                },
               },
             },
-          },
-
-
-        ] );
-        const aboveResp = await getOpenSearchData( openSearch.footfallDirectory, aboveQ );
-        ticketAccuracyAbove = aboveResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+          };
 
-        // ticketAccuracyBelow: avg of revicedPerc < 85%
-        let ticketAccuracyBelow = 0;
+          const avgTicketPercentageResp = await getOpenSearchData( openSearch.footfallDirectory, avgTicketPercentageQuery );
 
-        let belowQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
-              script: {
-                lang: 'painless',
-                source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) < params.num
-                `,
-                params: { num: 85 },
-              },
-            },
-          },
+          ticketPercentageAvg = avgTicketPercentageResp?.body?.aggregations?.avg_ticket_percentage?.value?.toFixed( 2 ) || '0';
 
-        ] );
-        const belowResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
-        ticketAccuracyBelow = belowResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+          logger.info( { avgTicketPercentageResp } );
+          // ticketAccuracyBelow: avg of revicedPerc < 85%
+          let ticketAccuracy = 0;
 
-        // Final result object
-        result = {
-          totalTickets,
-          openTickets,
-          inprogress,
-          closedTickets,
-          dueToday: dueToday,
-          Expired: expiredTickets,
-          avgTicket: ticketAccuracyAbove+'%',
-          avgAccuracy: ticketAccuracyBelow+'%',
-        };
-      } else {
-        const storeQuery = {
-          size: 0,
-          query: {
-            bool: {
-              must: [
-                {
-                  'range': {
-                    'dateString': {
-                      'gte': inputData?.fromDate,
-                      'lte': inputData?.toDate,
-                      'format': 'yyyy-MM-dd',
+          let belowQ = buildAggStoreQuery( baseStoreQuery );
+          logger.info( { belowQ } );
+          const accuracyResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
+          ticketAccuracy = accuracyResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+          logger.info( { accuracyResp } );
+          // Final result object
+          result = {
+            totalTickets,
+            openTickets,
+            inprogress,
+            closedTickets,
+            dueToday: dueToday,
+            Expired: expiredTickets,
+            avgTicket: ticketPercentageAvg+'%',
+            avgAccuracy: ticketAccuracy+'%',
+          };
+        } else {
+          const storeQuery = {
+            size: 0,
+            query: {
+              bool: {
+                must: [
+                  {
+                    'range': {
+                      'dateString': {
+                        'gte': inputData?.fromDate,
+                        'lte': inputData?.toDate,
+                        'format': 'yyyy-MM-dd',
+                      },
                     },
                   },
-                },
-                {
-                  nested: {
-                    path: 'mappingInfo',
-                    query: {
-                      bool: {
-                        must: [
-                          {
-                            term: {
-                              'mappingInfo.type': inputData.permissionType === 'review'? 'review':'approve',
+                  {
+                    terms: {
+                      'clientId.keyword': Array.isArray( inputData.clientId ) ?
+                        inputData.clientId :
+                        [ inputData.clientId ],
+                    },
+
+                  },
+                  {
+                    nested: {
+                      path: 'mappingInfo',
+                      query: {
+                        bool: {
+                          must: [
+                            {
+                              term: {
+                                'mappingInfo.type': inputData.permissionType === 'review'? 'review':'approve',
+                              },
                             },
-                          },
-                        ],
+                          ],
+                        },
                       },
                     },
                   },
-                },
 
-              ],
+                ],
+              },
             },
-          },
-        };
+          };
 
-        // Helper function to clone deep and replace mappingInfo.status for openTickets/closed/etc
-        function buildStoreQueryWithStatus( baseQuery, statusValue ) {
-          let q = JSON.parse( JSON.stringify( baseQuery ) );
-          // Remove any previous mappingInfo.status term
-          let nested = q.query.bool.must.find( ( m ) => m.nested );
-          if ( nested ) {
-            // filter out all mappingInfo.status
-            nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
-              return !( mustItem.term && mustItem.term['mappingInfo.status'] );
-            } );
-            // add desired status
-            nested.nested.query.bool.must.push( {
-              term: {
-                'mappingInfo.status': statusValue,
-              },
-            } );
+          // Helper function to clone deep and replace mappingInfo.status for openTickets/closed/etc
+          function buildStoreQueryWithStatus( baseQuery, statusValue ) {
+            let q = JSON.parse( JSON.stringify( baseQuery ) );
+            // Remove any previous mappingInfo.status term
+            let nested = q.query.bool.must.find( ( m ) => m.nested );
+            if ( nested ) {
+              // filter out all mappingInfo.status
+              nested.nested.query.bool.must = nested?.nested?.query?.bool?.must.filter( ( mustItem ) => {
+                return !( mustItem.term && mustItem.term['mappingInfo.status'] );
+              } );
+              // add desired status
+              nested.nested.query.bool.must.push( {
+                term: {
+                  'mappingInfo.status': statusValue,
+                },
+              } );
+            }
+            return q;
           }
-          return q;
-        }
 
-        const buildAggStoreQuery = ( baseQuery, filters = [] ) => {
-          const q = JSON.parse( JSON.stringify( baseQuery ) );
+          const buildAggStoreQuery = ( baseQuery, filters = [] ) => {
+            const q = JSON.parse( JSON.stringify( baseQuery ) );
 
-          // locate nested section
-          const nested = q.query.bool.must.find( ( m ) => m.nested );
+            // locate nested section
+            const nested = q.query.bool.must.find( ( m ) => m.nested );
 
-          if ( nested ) {
-            // remove old status filters
-            nested.nested.query.bool.must =
-              nested.nested.query.bool.must.filter( ( m ) => !( m.term && m.term['mappingInfo.status'] ) );
+            if ( nested ) {
+              // remove old status filters
+              nested.nested.query.bool.must =
+                nested.nested.query.bool.must.filter( ( m ) => !( m.term && m.term['mappingInfo.status'] ) );
 
-            // add new filters
-            nested.nested.query.bool.must.push( ...filters );
-          }
+              // add new filters
+              nested.nested.query.bool.must.push( ...filters );
+            }
 
-          return {
-            ...q,
-            size: 0,
-            aggs: {
-              avg_value: {
-                avg: {
-                  script: {
-                    lang: 'painless',
-                    source: `
-          if (doc['revicedPerc.keyword'].size() == 0) return null;
-  String v = doc['revicedPerc.keyword'].value.replace('%','');
-  try {
-  return Double.parseDouble(v);
-  } catch (Exception e) { 
-  return null; 
-  }
-        `,
-                  },
+            return {
+              ...q,
+              size: 0,
+              aggs: {
+                avg_value: {
+                  avg: 'mappingInfp.reviced',
                 },
               },
-            },
+            };
           };
-        };
-
 
-        // Get OpenSearch connection
 
-        const baseStoreQuery = JSON.parse( JSON.stringify( storeQuery ) );
+          // Get OpenSearch connection
 
-        // Total Tickets (all tickets with mappingInfo.type == tangoreview)
-        let totalTickets = 0;
+          const baseStoreQuery = JSON.parse( JSON.stringify( storeQuery ) );
 
-        let allQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          // Total Tickets (all tickets with mappingInfo.type == tangoreview)
+          let totalTickets = 0;
 
-        allQuery.size = 0;
-        const totalResp = await getOpenSearchData( openSearch.footfallDirectory, allQuery );
-        totalTickets = totalResp?.body?.hits?.total?.value || 0;
+          let allQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
 
-        // openTickets: mappingInfo.status: 'Open'
-        let openTickets = 0;
+          allQuery.size = 0;
+          const totalResp = await getOpenSearchData( openSearch.footfallDirectory, allQuery );
+          totalTickets = totalResp?.body?.hits?.total?.value || 0;
 
-        let otQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open' );
-        otQ.size = 0;
-        const openResp = await getOpenSearchData( openSearch.footfallDirectory, otQ );
-        openTickets = openResp?.body?.hits?.total?.value || 0;
-        // logger.info( { msd: '..............2', openResp } );
+          // openTickets: mappingInfo.status: 'Open'
+          let openTickets = 0;
 
+          let otQ = buildStoreQueryWithStatus( baseStoreQuery, 'Open' );
+          otQ.size = 0;
+          const openResp = await getOpenSearchData( openSearch.footfallDirectory, otQ );
+          openTickets = openResp?.body?.hits?.total?.value || 0;
+          // logger.info( { msd: '..............2', openResp } );
 
-        // inprogress: mappingInfo.status: 'in-Progress'
-        let inprogress = 0;
 
-        let ipQ = buildStoreQueryWithStatus( baseStoreQuery, 'In-Progress' );
-        ipQ.size = 0;
-        const ipResp = await getOpenSearchData( openSearch.footfallDirectory, ipQ );
-        inprogress = ipResp?.body?.hits?.total?.value || 0;
+          // inprogress: mappingInfo.status: 'in-Progress'
+          let inprogress = 0;
 
-        // closedTickets: mappingInfo.status: 'closed'
-        let closedTickets = 0;
+          let ipQ = buildStoreQueryWithStatus( baseStoreQuery, 'In-Progress' );
+          ipQ.size = 0;
+          const ipResp = await getOpenSearchData( openSearch.footfallDirectory, ipQ );
+          inprogress = ipResp?.body?.hits?.total?.value || 0;
 
-        let clQ = buildStoreQueryWithStatus( baseStoreQuery, 'Closed' );
-        clQ.size = 0;
-        const clResp = await getOpenSearchData( openSearch.footfallDirectory, clQ );
-        closedTickets = clResp?.body?.hits?.total?.value || 0;
-        // dueToday: Tickets whose dueDate is today (format 'yyyy-MM-dd')
-        let dueToday = 0;
-        let todayDateString = new Date().toISOString().slice( 0, 10 );
+          // closedTickets: mappingInfo.status: 'closed'
+          let closedTickets = 0;
 
-        // Build a query for tickets with mappingInfo.dueDate == todayDateString
-        let dueTodayQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
-        // Locate nested mappingInfo query
-        let nestedDue = dueTodayQuery.query.bool.must.find( ( m ) => m.nested );
-        if ( nestedDue ) {
-          // Remove any previous mappingInfo.dueDate term
-          nestedDue.nested.query.bool.must = nestedDue.nested.query.bool.must.filter(
-              ( mustItem ) => !( mustItem.term && mustItem.term['mappingInfo.dueDate'] ),
-          );
-          // Add new dueDate filter
-          nestedDue.nested.query.bool.must.push( {
-            term: { 'mappingInfo.dueDate': todayDateString },
-          } );
-        }
-        dueTodayQuery.size = 0;
-        const dueTodayResp = await getOpenSearchData( openSearch.footfallDirectory, dueTodayQuery );
-        dueToday = dueTodayResp?.body?.hits?.total?.value || 0;
+          let clQ = buildStoreQueryWithStatus( baseStoreQuery, 'Closed' );
+          clQ.size = 0;
+          const clResp = await getOpenSearchData( openSearch.footfallDirectory, clQ );
+          closedTickets = clResp?.body?.hits?.total?.value || 0;
+          // dueToday: Tickets whose dueDate is today (format 'yyyy-MM-dd')
+          let dueToday = 0;
+          let todayDateString = new Date().toISOString().slice( 0, 10 );
+
+          // Build a query for tickets with mappingInfo.dueDate == todayDateString
+          let dueTodayQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          // Locate nested mappingInfo query
+          let nestedDue = dueTodayQuery.query.bool.must.find( ( m ) => m.nested );
+          if ( nestedDue ) {
+            // Remove any previous mappingInfo.dueDate term
+            nestedDue.nested.query.bool.must = nestedDue.nested.query.bool.must.filter(
+                ( mustItem ) => !( mustItem.term && mustItem.term['mappingInfo.dueDate'] ),
+            );
+            // Add new dueDate filter
+            nestedDue.nested.query.bool.must.push( {
+              term: { 'mappingInfo.dueDate': todayDateString },
+            } );
+          }
+          dueTodayQuery.size = 0;
+          const dueTodayResp = await getOpenSearchData( openSearch.footfallDirectory, dueTodayQuery );
+          dueToday = dueTodayResp?.body?.hits?.total?.value || 0;
 
 
-        // filter expired Tickets
-        let expiredTickets = 0;
+          // filter expired Tickets
+          let expiredTickets = 0;
 
-        let eQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
-        eQ.size = 0;
-        const eResp = await getOpenSearchData( openSearch.footfallDirectory, eQ );
-        expiredTickets = eResp?.body?.hits?.total?.value || 0;
+          let eQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
+          eQ.size = 0;
+          const eResp = await getOpenSearchData( openSearch.footfallDirectory, eQ );
+          expiredTickets = eResp?.body?.hits?.total?.value || 0;
 
-        // filter under tango review
+          // filter under tango review
 
-        let undertangoTickets = 0;
+          let undertangoTickets = 0;
 
-        let utrQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
-        utrQ.size = 0;
-        const utrResp = await getOpenSearchData( openSearch.footfallDirectory, utrQ );
-        undertangoTickets = utrResp?.body?.hits?.total?.value || 0;
+          let utrQ = buildStoreQueryWithStatus( baseStoreQuery, 'Under Tango Review' );
+          utrQ.size = 0;
+          const utrResp = await getOpenSearchData( openSearch.footfallDirectory, utrQ );
+          undertangoTickets = utrResp?.body?.hits?.total?.value || 0;
 
-        // For this, add a filter on revicedPerc >= 85
-        let ticketAccuracyAbove = 0;
-        let aboveQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
-              script: {
-                lang: 'painless',
-                source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) >= params.num
-                `,
-                params: { num: 85 },
+          let ticketPercentageAvg =0;
+          let avgTicketPercentageQuery = JSON.parse( JSON.stringify( baseStoreQuery ) );
+          avgTicketPercentageQuery.size = 0;
+          avgTicketPercentageQuery.aggs = {
+            avg_ticket_percentage: {
+              avg: {
+                script: {
+                  source: `
+                    if (doc.containsKey('reviced') && doc['reviced'].size()!=0 && 
+                        doc.containsKey('footfallCount') && doc['footfallCount'].size()!=0 && doc['footfallCount'].value != 0) {
+                      return (doc['reviced'].value / doc['footfallCount'].value) * 100;
+                    } else {
+                      return null;
+                    }
+                  `,
+                  lang: 'painless',
+                },
               },
             },
-          },
-
-
-        ] );
-
-        const aboveResp = await getOpenSearchData( openSearch.footfallDirectory, aboveQ );
-        ticketAccuracyAbove = aboveResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
-
-        // ticketAccuracyBelow: avg of revicedPerc < 85%
-        let ticketAccuracyBelow = 0;
+          };
 
-        let belowQ = buildAggStoreQuery( baseStoreQuery, [
-          {
-            script: {
-              script: {
-                lang: 'painless',
-                source: `
-                  doc['revicedPerc.keyword'].size()!=0 &&
-                  Integer.parseInt(doc['revicedPerc.keyword'].value.replace('%','')) < params.num
-                `,
-                params: { num: 85 },
-              },
-            },
-          },
+          const avgTicketPercentageResp = await getOpenSearchData( openSearch.footfallDirectory, avgTicketPercentageQuery );
 
-        ] );
-        const belowResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
-        ticketAccuracyBelow = belowResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+          ticketPercentageAvg = avgTicketPercentageResp?.body?.aggregations?.avg_ticket_percentage?.value?.toFixed( 2 ) || '0';
+          logger.info( { avgTicketPercentageResp } );
+          let ticketAccuracy = 0;
 
-        // Final result object
-        result = {
-          totalTickets,
-          openTickets,
-          inprogress,
-          closedTickets,
-          dueToday: dueToday,
-          Expired: expiredTickets,
-          underTangoReview: undertangoTickets,
-          avgTicket: ticketAccuracyAbove+'%',
-          avgAccuracy: ticketAccuracyBelow+'%',
-        };
+          let belowQ = buildAggStoreQuery( baseStoreQuery );
+          logger.info( { belowQ } );
+          const accuracyResp = await getOpenSearchData( openSearch.footfallDirectory, belowQ );
+          ticketAccuracy = accuracyResp?.body?.aggregations?.avg_value?.value?.toFixed( 2 ) || '0';
+          logger.info( { accuracyResp } );
+          // Final result object
+          result = {
+            totalTickets,
+            openTickets,
+            inprogress,
+            closedTickets,
+            dueToday: dueToday,
+            Expired: expiredTickets,
+            underTangoReview: undertangoTickets,
+            avgTicket: ticketPercentageAvg+'%',
+            avgAccuracy: ticketAccuracy+'%',
+          };
+        }
       }
     }
 
@@ -4925,7 +4901,7 @@ export async function updateUserTicketStatus( req, res ) {
 
     const updatePayload = {
       doc: {
-        status: 'In-Progress',
+        status: lastEntry?.type == 'review'? 'Reviewer In progress':lastEntry?.type == 'approve'? 'Approver In progress':ticketSource?.status,
         mappingInfo: updatedMappingInfo,
         updatedAt: currentTime,
       },