talon-agent 5.1.0 → 5.2.1

package/src/core/agents/runner.ts

@@ -0,0 +1,448 @@
+/**
+ * Runner — turns a spawn request into a live isolated run, and a finished
+ * run into a settled record its parent hears about.
+ *
+ * The shape is the heartbeat / cron-job shape, because a sub-agent *is* one
+ * of those: acquire a backend, resolve a model, open a run log, register a
+ * task, and hand `runOneShotAgent` to `runIsolatedAgent` for the hard
+ * timeout → abort → grace → eviction discipline. Nothing here is
+ * backend-specific, which is the whole point: sub-agents work on Claude,
+ * Codex, Kilo, OpenCode and any future backend with a background capability.
+ *
+ * What is specific to agents:
+ *
+ *   - **Identity.** Each run gets `contextLabel: "agent:<id>"`, which the
+ *     backends turn into a per-agent MCP tool session and the gateway reads
+ *     back to know which agent is calling `report_result`.
+ *   - **Result precedence.** The `report_result` tool wins; otherwise the
+ *     run's last assistant text is used; with neither, the run is a failure,
+ *     because a sub-agent that says nothing has not done its job.
+ *   - **Settlement is the delivery trigger.** Every terminal state — done,
+ *     failed, killed, timed out — reaches the parent. Silence is never an
+ *     outcome.
+ *
+ * `spawnAgent` returns as soon as the run is under way: the caller (a chat
+ * turn or another agent) keeps working and hears back through the wake turn
+ * or its mailbox.
+ */
+
+import { dirs } from "../../util/paths.js";
+import { log, logError, logWarn } from "../../util/log.js";
+import {
+  acquireBackendInstance,
+  getBackendIdForChat,
+  isModelValidForBackend,
+} from "../engine/backend-controller/index.js";
+import type {
+  Backend,
+  BackgroundRunner,
+} from "../agent-runtime/capabilities.js";
+import { taskTable } from "../tasks/index.js";
+import type { TaskHandle, TaskUsage } from "../tasks/types.js";
+import type { OneShotAgentParams } from "../types.js";
+import {
+  IsolatedAgentTimeoutError,
+  runIsolatedAgent,
+} from "../background/isolated-agent.js";
+import { openRunLog } from "../background/run-log.js";
+import { agentContextLabel } from "./context.js";
+import {
+  deliverSettlement,
+  initAgentDelivery,
+  type AgentDeliveryDeps,
+} from "./delivery.js";
+import {
+  agentLogHeader,
+  agentLogPath,
+  buildAgentPrompt,
+  buildAgentSystemPrompt,
+} from "./prompt.js";
+import { agentRegistry } from "./registry.js";
+import type {
+  AgentCaps,
+  AgentParent,
+  AgentRecord,
+  AgentSpawnOutcome,
+  AgentSpawnSpec,
+} from "./types.js";
+
+/** Defaults for `config.agents`, applied when the block is absent. */
+export const DEFAULT_AGENT_CAPS: AgentCaps = {
+  maxConcurrent: 6,
+  maxDepth: 2,
+  defaultTimeoutMs: 15 * 60 * 1000,
+};
+
+/** Floor and ceiling the tool boundary clamps a requested `timeout_s` into. */
+const MIN_TIMEOUT_MS = 30_000;
+const MAX_TIMEOUT_MS = 60 * 60 * 1000;
+
+const capsHolder: { caps: AgentCaps } = { caps: DEFAULT_AGENT_CAPS };
+
+/** Wire the sub-agent subsystem. Called once from the composition root. */
+export function initAgents(
+  deps: AgentDeliveryDeps & { caps?: Partial<AgentCaps> },
+): void {
+  capsHolder.caps = { ...DEFAULT_AGENT_CAPS, ...deps.caps };
+  initAgentDelivery({ execute: deps.execute });
+  log(
+    "agents",
+    `Initialized — maxConcurrent=${capsHolder.caps.maxConcurrent} ` +
+      `maxDepth=${capsHolder.caps.maxDepth} ` +
+      `timeout=${Math.round(capsHolder.caps.defaultTimeoutMs / 1000)}s`,
+  );
+}
+
+/** The live caps — read by the tools for their error copy and prompts. */
+export function getAgentCaps(): AgentCaps {
+  return capsHolder.caps;
+}
+
+/**
+ * Clamp a model-supplied timeout into the supported window, or fall back to
+ * the configured default. Applied at the tool boundary — `spawnAgent` itself
+ * honours whatever it is handed, so the runner has one rule and not two.
+ */
+export function clampTimeout(requestedMs: number | undefined): number {
+  if (requestedMs === undefined) return capsHolder.caps.defaultTimeoutMs;
+  return Math.min(MAX_TIMEOUT_MS, Math.max(MIN_TIMEOUT_MS, requestedMs));
+}
+
+/** The backend an agent inherits when the caller didn't pick one. */
+function inheritedBackendId(parent: AgentParent): string | null {
+  if (parent.kind === "chat") return getBackendIdForChat(parent.chatId);
+  return agentRegistry.get(parent.agentId)?.backendId ?? null;
+}
+
+/** The chat a run's task belongs to, for `talon ps`. */
+function taskChatId(parent: AgentParent): string | undefined {
+  if (parent.kind === "chat") return parent.chatId;
+  const root = agentRegistry.get(parent.agentId)?.parent;
+  return root?.kind === "chat" ? root.chatId : undefined;
+}
+
+function errText(err: unknown): string {
+  return err instanceof Error ? err.message : String(err);
+}
+
+/**
+ * Resolve the model for a run: an explicit id is validated against the
+ * backend, an absent one falls back to that backend's own default. Returns
+ * the error text a tool should show instead of throwing.
+ */
+async function resolveRun(
+  backend: Backend,
+  backendId: string,
+  requested: string | undefined,
+): Promise<
+  | { ok: true; model: string; background: BackgroundRunner }
+  | { ok: false; error: string }
+> {
+  const background = backend.background;
+  if (!background) {
+    return {
+      ok: false,
+      error:
+        `Backend "${backendId}" cannot host a sub-agent (it has no ` +
+        `background capability). Pick another backend or leave it unset.`,
+    };
+  }
+  if (requested) {
+    let valid = false;
+    try {
+      valid = await isModelValidForBackend(backend, requested);
+    } catch (err) {
+      return {
+        ok: false,
+        error: `Could not validate model "${requested}" on backend "${backendId}": ${errText(err)}`,
+      };
+    }
+    if (!valid) {
+      return {
+        ok: false,
+        error:
+          `Model "${requested}" is not selectable on backend "${backendId}". ` +
+          `Call list_models to see valid ids, or leave model unset to use ` +
+          `that backend's default.`,
+      };
+    }
+    return { ok: true, model: requested, background };
+  }
+  let fallback: string | null | undefined;
+  try {
+    fallback = await backend.models?.getDefaultModelId();
+  } catch (err) {
+    return {
+      ok: false,
+      error: `Backend "${backendId}" could not report a default model: ${errText(err)}`,
+    };
+  }
+  if (!fallback) {
+    return {
+      ok: false,
+      error:
+        `Backend "${backendId}" has no default model — pass an explicit ` +
+        `model (list_models shows what it offers).`,
+    };
+  }
+  return { ok: true, model: fallback, background };
+}
+
+/**
+ * Spawn a sub-agent. Resolves once the run is under way (or refused) — never
+ * when the agent finishes; that arrives through delivery.
+ */
+export async function spawnAgent(
+  spec: AgentSpawnSpec,
+): Promise<AgentSpawnOutcome> {
+  const backendId = spec.backendId ?? inheritedBackendId(spec.parent);
+  if (!backendId) {
+    return {
+      ok: false,
+      error:
+        "Could not resolve a backend for this agent — pass one explicitly.",
+    };
+  }
+
+  // Register first: the slot and the depth are claimed synchronously, so two
+  // concurrent spawns can never both slip past maxConcurrent while awaiting
+  // the backend. A registration that never starts is discarded without trace.
+  const registered = agentRegistry.register(
+    {
+      label: spec.label,
+      brief: spec.brief,
+      parent: spec.parent,
+      backendId,
+      ...(spec.reasoningEffort
+        ? { reasoningEffort: spec.reasoningEffort }
+        : {}),
+    },
+    capsHolder.caps,
+  );
+  if (!registered.ok) return registered;
+  const record = registered.record;
+
+  let acquired: Awaited<ReturnType<typeof acquireBackendInstance>>;
+  try {
+    acquired = await acquireBackendInstance(backendId);
+  } catch (err) {
+    agentRegistry.discard(record.id);
+    return {
+      ok: false,
+      error: `Backend "${backendId}" is unavailable: ${errText(err)}`,
+    };
+  }
+
+  const resolved = await resolveRun(acquired.backend, backendId, spec.model);
+  if (!resolved.ok) {
+    agentRegistry.discard(record.id);
+    await acquired.release();
+    return resolved;
+  }
+
+  // The run owns the instance from here: `runAgent` releases it on every
+  // path, including the ones that throw.
+  void runAgent(record, spec, resolved, acquired);
+  return { ok: true, agentId: record.id, backendId, model: resolved.model };
+}
+
+/** Build the one-shot params for a run, wired to its log and text capture. */
+async function buildRunParams(
+  record: AgentRecord,
+  spec: AgentSpawnSpec,
+  model: string,
+  abortController: AbortController,
+  capture: { last: string },
+): Promise<OneShotAgentParams> {
+  const appendLog = await openRunLog(
+    agentLogPath(record.id),
+    agentLogHeader(record, model),
+  );
+  return {
+    prompt: buildAgentPrompt(record.brief),
+    systemPrompt: buildAgentSystemPrompt({
+      agentId: record.id,
+      label: record.label,
+      parent: record.parent,
+      depth: record.depth,
+      maxDepth: capsHolder.caps.maxDepth,
+    }),
+    workspace: dirs.workspace,
+    model,
+    contextLabel: agentContextLabel(record.id),
+    abortController,
+    appendLog,
+    onAssistantText: (text) => {
+      const trimmed = text.trim();
+      if (trimmed) capture.last = trimmed;
+    },
+    ...(spec.reasoningEffort ? { reasoningEffort: spec.reasoningEffort } : {}),
+  };
+}
+
+/** Settle a run that returned normally, applying the result precedence. */
+function settleSuccess(
+  id: string,
+  task: TaskHandle,
+  lastText: string,
+  usage: TaskUsage | undefined,
+): AgentRecord | null {
+  if (agentRegistry.hasReported(id)) {
+    task.succeed(usage);
+    return agentRegistry.settle(id, {
+      state: "done",
+      ...(usage ? { usage } : {}),
+    });
+  }
+  if (lastText) {
+    task.succeed(usage);
+    return agentRegistry.settle(id, {
+      state: "done",
+      result: { summary: lastText },
+      ...(usage ? { usage } : {}),
+    });
+  }
+  const error =
+    "the agent finished without calling report_result and produced no text";
+  task.fail(new Error(error), usage);
+  return agentRegistry.settle(id, {
+    state: "failed",
+    error,
+    ...(usage ? { usage } : {}),
+  });
+}
+
+/** Settle a run that threw: timeout, kill, or a genuine failure. */
+function settleFailure(
+  id: string,
+  task: TaskHandle,
+  err: unknown,
+): AgentRecord | null {
+  const state =
+    err instanceof IsolatedAgentTimeoutError
+      ? "timed_out"
+      : agentRegistry.killRequested(id)
+        ? "killed"
+        : "failed";
+  task.fail(err);
+  return agentRegistry.settle(id, { state, error: errText(err) });
+}
+
+/**
+ * Drive one run end to end. Never rejects — it is the tail of a
+ * fire-and-forget spawn, so every failure has to end as a settled record
+ * their parent is told about.
+ */
+async function runAgent(
+  record: AgentRecord,
+  spec: AgentSpawnSpec,
+  resolved: { model: string; background: BackgroundRunner },
+  acquired: Awaited<ReturnType<typeof acquireBackendInstance>>,
+): Promise<void> {
+  const { model, background } = resolved;
+  const { release } = acquired;
+  const id = record.id;
+  const abortController = new AbortController();
+  const capture = { last: "" };
+  const timeoutMs = spec.timeoutMs ?? capsHolder.caps.defaultTimeoutMs;
+
+  // Registered as queued, bound, then started — so a kill arriving in the
+  // gap between the task existing and the abort handle being published still
+  // reaches the run.
+  const chatId = taskChatId(record.parent);
+  const task = taskTable.enqueue({
+    kind: "agent",
+    label: record.label,
+    abort: () => void agentRegistry.requestKill(id),
+    ...(chatId !== undefined ? { chatId } : {}),
+  });
+  task.bind({ model, backendId: record.backendId });
+  agentRegistry.start(id, { model, abort: abortController, taskId: task.id });
+  task.start();
+
+  let settled: AgentRecord | null = null;
+  try {
+    const params = await buildRunParams(
+      record,
+      spec,
+      model,
+      abortController,
+      capture,
+    );
+    if (abortController.signal.aborted) {
+      // A kill that lands during startup — while the backend is being
+      // acquired or the log opened — must not be lost. Handing an
+      // already-aborted signal to a backend relies on it checking, and not
+      // every SDK does; settling here is the one behaviour that always holds.
+      settled = settleFailure(
+        id,
+        task,
+        new Error("aborted before the run started"),
+      );
+    } else {
+      const usage = await runIsolatedAgent({
+        background,
+        params,
+        timeoutMs,
+        logCategory: "agents",
+        // Safe to sweep: the context label is unique to this agent, so no
+        // other context's subprocesses share the tag.
+        evictLabel: agentContextLabel(id),
+      });
+      settled = settleSuccess(id, task, capture.last, usage ?? undefined);
+    }
+  } catch (err) {
+    settled = settleFailure(id, task, err);
+  } finally {
+    await release().catch((err: unknown) =>
+      logError("agents", `failed to release backend for ${id}`, err),
+    );
+  }
+
+  if (!settled) return;
+  log(
+    "agents",
+    `${id} "${settled.label}" → ${settled.state} ` +
+      `(${settled.backendId}/${model}, ${timeoutMs}ms cap)`,
+  );
+  reapChildren(settled);
+  await deliverSettlement(settled).catch((err: unknown) =>
+    logError("agents", `delivery failed for ${id}`, err),
+  );
+}
+
+/**
+ * Kill a settled agent's still-running children. Their reports would have
+ * nowhere to go, so leaving them running only spends tokens.
+ */
+function reapChildren(record: AgentRecord): void {
+  for (const child of agentRegistry.liveChildren(record.id)) {
+    logWarn(
+      "agents",
+      `killing ${child}: its parent ${record.id} settled as ${record.state}`,
+    );
+    killAgent(child);
+  }
+}
+
+/**
+ * Request a kill. Routed through the task table when the run has a task, so
+ * `talon ps` shows it as `killed` rather than `failed` — one kill path, two
+ * surfaces. Returns false when the agent is unknown or already settled.
+ */
+export function killAgent(agentId: string): boolean {
+  const record = agentRegistry.get(agentId);
+  if (!record || !agentRegistry.isLive(agentId)) return false;
+  if (record.taskId !== undefined) return taskTable.kill(record.taskId).ok;
+  return agentRegistry.requestKill(agentId);
+}
+
+/**
+ * Abort every live agent — the shutdown lever, alongside heartbeat's and
+ * cron's. Returns how many kills were requested.
+ */
+export function shutdownAgents(): number {
+  const killed = agentRegistry.killAll();
+  if (killed > 0) log("agents", `Shutdown: aborted ${killed} running agent(s)`);
+  return killed;
+}

package/src/core/agents/types.ts

@@ -0,0 +1,124 @@
+/**
+ * Sub-agent vocabulary — the shapes the registry, runner and delivery share.
+ *
+ * A **sub-agent** is one isolated one-shot run that some other agent work
+ * started: a chat turn delegating a job, or another sub-agent fanning out.
+ * Talon owns the mechanism (not the Claude SDK's own sub-agents) so it works
+ * on every backend — the run is an ordinary `runOneShotAgent` with its own
+ * backend, model, workspace and tool surface.
+ */
+
+import type { ReasoningEffortLevel } from "../types.js";
+import type { TaskUsage } from "../tasks/types.js";
+
+/**
+ * Lifecycle. `done` / `failed` / `killed` / `timed_out` are terminal.
+ *
+ * Wider than `TaskState` on purpose: a task that ran out of wall-clock is
+ * indistinguishable from any other abort in the task table, but the parent
+ * reading a report needs to know whether its agent was cut off.
+ */
+export type AgentState =
+  "queued" | "running" | "done" | "failed" | "killed" | "timed_out";
+
+/**
+ * Who spawned this agent, and therefore where its report goes.
+ *
+ * A chat parent is woken with a synthetic turn (`source: "agent"`), exactly
+ * as a trigger fires; an agent parent gets the report pushed into its
+ * mailbox, which it drains with `check_inbox`.
+ */
+export type AgentParent =
+  | {
+      readonly kind: "chat";
+      /** Canonical string chat id — what every store is keyed on. */
+      readonly chatId: string;
+      /** The frontend's numeric id, needed by the dispatcher. */
+      readonly numericChatId: number;
+    }
+  | { readonly kind: "agent"; readonly agentId: string };
+
+/** What an agent reports back when it finishes. */
+export interface AgentResult {
+  readonly summary: string;
+  readonly details?: string;
+}
+
+/** One message waiting in an agent's mailbox. */
+export interface AgentMessage {
+  /** Chat key or agent id of the sender. */
+  readonly from: string;
+  readonly text: string;
+  readonly at: number;
+}
+
+/** Immutable snapshot of one agent, as returned by the registry. */
+export interface AgentRecord {
+  readonly id: string;
+  /** Short content-free name — safe for task labels, events and `talon ps`. */
+  readonly label: string;
+  /**
+   * The brief the agent was spawned with. Kept for the run log and the
+   * agent's own system prompt only — never in a task label or a bus event,
+   * which are content-free by contract.
+   */
+  readonly brief: string;
+  readonly parent: AgentParent;
+  readonly backendId: string;
+  /**
+   * Absent only in the moment between registration and the run starting —
+   * the model is whatever the backend's catalog resolved, which is an async
+   * answer, while the concurrency slot must be claimed synchronously.
+   */
+  readonly model?: string;
+  readonly reasoningEffort?: ReasoningEffortLevel;
+  readonly state: AgentState;
+  /** 0 for an agent spawned by a chat, +1 per generation below that. */
+  readonly depth: number;
+  readonly createdAt: number;
+  readonly startedAt?: number;
+  readonly endedAt?: number;
+  /** Report tool result, else the run's last assistant text, else null. */
+  readonly result: AgentResult | null;
+  readonly error?: string;
+  readonly usage?: TaskUsage;
+  readonly taskId?: number;
+  /** Ids of the agents this one spawned. */
+  readonly children: readonly string[];
+  /** Messages waiting to be drained by `check_inbox`. */
+  readonly inboxDepth: number;
+}
+
+/** What `spawnAgent` is asked for. */
+export interface AgentSpawnSpec {
+  readonly brief: string;
+  readonly label: string;
+  readonly parent: AgentParent;
+  /** Defaults to the parent's backend. */
+  readonly backendId?: string;
+  /** Defaults to the resolved backend's own default model. */
+  readonly model?: string;
+  readonly reasoningEffort?: ReasoningEffortLevel;
+  /** Hard wall-clock cap. Defaults to `agents.defaultTimeoutMs`. */
+  readonly timeoutMs?: number;
+}
+
+/** `spawnAgent`'s answer — an error here is a tool error, never a throw. */
+export type AgentSpawnOutcome =
+  | {
+      readonly ok: true;
+      readonly agentId: string;
+      readonly backendId: string;
+      readonly model: string;
+    }
+  | { readonly ok: false; readonly error: string };
+
+/** The caps a deployment puts on sub-agent fan-out (config `agents`). */
+export interface AgentCaps {
+  /** Live (queued + running) agents allowed per daemon. */
+  readonly maxConcurrent: number;
+  /** Deepest `depth` an agent may have — 2 means chat → A → B. */
+  readonly maxDepth: number;
+  /** Default hard timeout for one run. */
+  readonly defaultTimeoutMs: number;
+}

package/src/core/background/cron/job-oneshot.ts

@@ -10,10 +10,9 @@
  *
  * This module is deliberately thin: it owns acquisition + log wiring, and
  * delegates the prompt shape to {@link ./job-prompt} and the timeout/abort
- * discipline to {@link ./isolated-agent}.
+ * discipline to {@link ../isolated-agent}.
  */
 
-import { mkdir, appendFile } from "node:fs/promises";
 import { dirs } from "../../../util/paths.js";
 import { log, logWarn } from "../../../util/log.js";
 import {
@@ -22,12 +21,12 @@ import {
 } from "../../engine/backend-controller/index.js";
 import { taskTable } from "../../tasks/index.js";
 import type { OneShotAgentParams } from "../../types.js";
-import { runIsolatedAgent } from "./isolated-agent.js";
+import { runIsolatedAgent } from "../isolated-agent.js";
+import { openRunLog } from "../run-log.js";
 import {
   buildJobSystemPrompt,
   jobLogPath,
   JOB_CONTEXT_LABEL,
-  JOB_LOGS_DIR,
   type JobKind,
 } from "./job-prompt.js";
 
@@ -70,22 +69,17 @@ export type JobOneShotResult =
   { status: "ran" } | { status: "skipped"; reason: string };
 
 /** Open a per-run log file and return an appender bound to it. */
-async function openJobLog(
+function openJobLog(
   kind: JobKind,
   label: string,
   backendId: string,
   model: string,
 ): Promise<(text: string) => Promise<void>> {
-  await mkdir(JOB_LOGS_DIR, { recursive: true }).catch(() => {});
-  const file = jobLogPath(kind, label);
-  const appendLog = async (text: string) => {
-    await appendFile(file, text).catch(() => {});
-  };
-  await appendLog(
+  return openRunLog(
+    jobLogPath(kind, label),
     `# ${kind} job "${label}" — ${new Date().toISOString()}\n` +
       `**Backend:** ${backendId} **Model:** ${model}\n\n`,
   );
-  return appendLog;
 }
 
 // The warning is deferred to runJobOneShot: an attempt that fails here may
@@ -182,6 +176,7 @@ async function attemptJobOneShot(
         background,
         params: oneShot,
         timeoutMs: params.timeoutMs ?? DEFAULT_JOB_TIMEOUT_MS,
+        logCategory: params.kind === "cron" ? "cron" : "triggers",
         // No evictLabel: the job context label is shared with heartbeat, so a
         // sweep here could kill a concurrent heartbeat's subprocess. Bounded
         // abort-grace is enough.

package/src/core/background/cron/job-prompt.ts

@@ -10,7 +10,7 @@ import { dirs } from "../../../util/paths.js";
 export type JobKind = "trigger" | "cron";
 
 /** Where job run logs live. */
-export const JOB_LOGS_DIR = resolve(dirs.logs, "jobs");
+const JOB_LOGS_DIR = resolve(dirs.logs, "jobs");
 
 /**
  * The one context label every backend wires for the full outbound frontend tool