talon-agent 4.3.1 → 4.3.3

package/src/frontend/whatsapp/actions/{shared.ts → send.ts}

@@ -1,111 +1,17 @@
 /**
- * Shared helpers for the WhatsApp action handlers: uniform error
- * capture, media-source resolution, quoted-reply resolution, and the
- * JID coercion the member-facing actions need.
+ * Outbound WhatsApp sends: quoted-reply resolution, the serialized
+ * time-bounded socket queue, and the content/text senders that remember
+ * what went out so later tool calls and history can address it.
  */
 
-import { existsSync, statSync } from "node:fs";
-import { basename, extname } from "node:path";
 import type { AnyMessageContent, WAMessage, WASocket } from "baileys";
-import { expandFsPath } from "../../../util/fs-path.js";
-import { log, logError } from "../../../util/log.js";
+import { log } from "../../../util/log.js";
 import type { ActionResult } from "../../../core/types.js";
 import { toWhatsAppChunks } from "../formatting.js";
 import { lookupMessage, rememberMessage } from "../message-store.js";
 import { pushMessage, type HistoryMessage } from "../../../storage/history.js";
 import type { WhatsAppChatInfo } from "../registry.js";
 
-/** WhatsApp's own ceiling for a media upload. */
-const MAX_MEDIA_BYTES = 64 * 1024 * 1024;
-
-/**
- * Run an action, converting a throw into a structured failure. WhatsApp
- * errors arrive as Boom objects whose message is the useful part; the
- * model gets that text so it can adapt rather than retry blindly.
- */
-export async function tryAction(
-  label: string,
-  fn: () => Promise<ActionResult>,
-): Promise<ActionResult> {
-  try {
-    return await fn();
-  } catch (err) {
-    const msg = err instanceof Error ? err.message : String(err);
-    logError("whatsapp", `${label} failed: ${msg}`);
-    return { ok: false, error: `${label}: ${msg}` };
-  }
-}
-
-/** Baileys accepts a Buffer, a stream, or `{ url }` for local paths and HTTP. */
-export type MediaUpload = { url: string };
-
-/**
- * Resolve one media input to something Baileys can upload. Two sources:
- * a public URL (WhatsApp's uploader fetches it) or a workspace file path
- * (streamed from disk). `file_id` is a Telegram concept with no WhatsApp
- * equivalent — say so instead of failing obscurely.
- */
-export function resolveMediaUpload(
-  src: { file_path?: unknown; url?: unknown; file_id?: unknown },
-  label: string,
-): { media: MediaUpload; fileName: string } | { error: string } {
-  if (src.url) {
-    const url = String(src.url);
-    return {
-      media: { url },
-      fileName: basename(new URL(url).pathname) || "file",
-    };
-  }
-  if (src.file_id) {
-    return {
-      error:
-        `${label}: WhatsApp has no file_id — re-send by url (public) or ` +
-        `file_path (workspace file)`,
-    };
-  }
-  if (!src.file_path) {
-    return {
-      error: `${label}: provide file_path (workspace file) or url (public)`,
-    };
-  }
-  const filePath = expandFsPath(String(src.file_path));
-  if (!existsSync(filePath)) {
-    return {
-      error: `File not found: ${filePath} — check the workspace path, or send by url instead`,
-    };
-  }
-  if (statSync(filePath).size > MAX_MEDIA_BYTES) {
-    return { error: `${label}: file exceeds WhatsApp's 64MB limit` };
-  }
-  return { media: { url: filePath }, fileName: basename(filePath) };
-}
-
-/** Extension → mimetype for the document/audio paths that require one. */
-const MIME_BY_EXT: Record<string, string> = {
-  ".pdf": "application/pdf",
-  ".txt": "text/plain",
-  ".md": "text/markdown",
-  ".json": "application/json",
-  ".csv": "text/csv",
-  ".zip": "application/zip",
-  ".png": "image/png",
-  ".jpg": "image/jpeg",
-  ".jpeg": "image/jpeg",
-  ".gif": "image/gif",
-  ".webp": "image/webp",
-  ".mp4": "video/mp4",
-  ".mov": "video/quicktime",
-  ".mp3": "audio/mpeg",
-  ".m4a": "audio/mp4",
-  ".ogg": "audio/ogg",
-  ".opus": "audio/ogg; codecs=opus",
-  ".wav": "audio/wav",
-};
-
-export function guessMimetype(fileName: string, fallback: string): string {
-  return MIME_BY_EXT[extname(fileName).toLowerCase()] ?? fallback;
-}
-
 /**
  * Resolve a `reply_to` message id into the quoted message Baileys wants.
  * An unknown id quotes nothing rather than failing the send — the reply
@@ -292,29 +198,3 @@ export async function sendText(
   );
   return first ?? { ok: true };
 }
-
-/**
- * Coerce a user reference the model supplied — bare number, JID, or the
- * numeric id from a member listing — into a WhatsApp user JID.
- */
-export function toUserJid(value: unknown): string | null {
-  const raw = String(value ?? "").trim();
-  if (!raw) return null;
-  if (raw.includes("@")) return raw;
-  const digits = raw.replace(/[^0-9]/g, "");
-  return digits ? `${digits}@s.whatsapp.net` : null;
-}
-
-/**
- * Pull the about text out of a `fetchStatus` result. Baileys has
- * returned both a bare object and a one-element array across versions,
- * and the payload itself nests `status` either as a string or as
- * `{ status }` — accept all four shapes rather than guess one.
- */
-export function readStatusText(result: unknown): string | undefined {
-  const entry = (Array.isArray(result) ? result[0] : result) as
-    { status?: string | { status?: string } } | undefined;
-  return typeof entry?.status === "string"
-    ? entry.status
-    : entry?.status?.status;
-}

package/src/frontend/whatsapp/actions/try-action.ts

@@ -0,0 +1,24 @@
+/**
+ * Run a WhatsApp action, converting a throw into a structured failure.
+ */
+
+import { logError } from "../../../util/log.js";
+import type { ActionResult } from "../../../core/types.js";
+
+/**
+ * Run an action, converting a throw into a structured failure. WhatsApp
+ * errors arrive as Boom objects whose message is the useful part; the
+ * model gets that text so it can adapt rather than retry blindly.
+ */
+export async function tryAction(
+  label: string,
+  fn: () => Promise<ActionResult>,
+): Promise<ActionResult> {
+  try {
+    return await fn();
+  } catch (err) {
+    const msg = err instanceof Error ? err.message : String(err);
+    logError("whatsapp", `${label} failed: ${msg}`);
+    return { ok: false, error: `${label}: ${msg}` };
+  }
+}

package/src/frontend/whatsapp/commands.ts

@@ -42,7 +42,7 @@ import {
   type ModelCommandDeps,
   type ModelOverview,
 } from "../shared/model-commands.js";
-import { sendText } from "./actions/shared.js";
+import { sendText } from "./actions/send.js";
 import { identityAllowed, type Identity } from "./identity.js";
 import type { WhatsAppChatInfo } from "./registry.js";
 import type { WhatsAppRuntime } from "./runtime.js";

package/src/frontend/whatsapp/connection.ts

@@ -11,7 +11,7 @@ import makeWASocket, { type AuthenticationState, type WASocket } from "baileys";
 import qrcode from "qrcode-terminal";
 import { log, logError, logWarn } from "../../util/log.js";
 import { dirs } from "../../util/paths.js";
-import { notifyAdmin } from "../../core/notify.js";
+import { notifyAdmin } from "../../core/frontend-runtime/admin-notify.js";
 import { useAtomicAuthState } from "./auth-state.js";
 import { bareId } from "./identity.js";
 import { handleInbound } from "./inbound.js";

package/src/frontend/whatsapp/inbound.ts

@@ -18,7 +18,7 @@ import {
 } from "../../util/watchdog.js";
 import { isAddressedToSelf, isGroupAllowed } from "./access.js";
 import { handleWhatsAppCommand } from "./commands.js";
-import { sendText } from "./actions/shared.js";
+import { sendText } from "./actions/send.js";
 import {
   bareId,
   canonicalId,

package/src/frontend/whatsapp/index.ts

@@ -25,14 +25,14 @@ import type { Gateway } from "../../core/engine/gateway.js";
 import { log, logError, logWarn } from "../../util/log.js";
 import { maxMsgIdForChatPrefix } from "../../storage/history.js";
 import { createWhatsAppActionHandler } from "./actions/index.js";
-import { sendText, setWhatsAppBotName } from "./actions/shared.js";
+import { sendText, setWhatsAppBotName } from "./actions/send.js";
 import { seedMessageStore } from "./message-store.js";
 import {
   maxWhatsAppMsgId,
   pruneWhatsAppMessages,
 } from "../../storage/whatsapp-messages.js";
 import { flushAuthWrites } from "./auth-state.js";
-import { registerPairingProvider } from "../../core/pairing-broker.js";
+import { registerPairingProvider } from "../../core/frontend-runtime/pairing-broker.js";
 import { beginPairingAttempt } from "./pairing-service.js";
 import { runConnectionLoop } from "./connection.js";
 import { lookupWhatsAppChat, type WhatsAppChatInfo } from "./registry.js";

package/src/frontend/whatsapp/pairing-service.ts

@@ -16,7 +16,7 @@ import QRCode from "qrcode";
 import type {
   PairingAttempt,
   PairingOutcome,
-} from "../../core/pairing-broker.js";
+} from "../../core/frontend-runtime/pairing-broker.js";
 import { log, logError } from "../../util/log.js";
 import { dirs } from "../../util/paths.js";
 import { useAtomicAuthState, flushAuthWrites } from "./auth-state.js";

package/src/plugins/github/provision.ts

@@ -9,7 +9,7 @@
  */
 
 import { join } from "node:path";
-import type { DoctorCheck } from "../../core/doctor.js";
+import type { DoctorCheck } from "../../core/doctor/index.js";
 import {
   failDetail,
   loadProvisionState,

package/src/plugins/mempalace/provision.ts

@@ -23,7 +23,7 @@
 import { existsSync } from "node:fs";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
-import type { DoctorCheck } from "../../core/doctor.js";
+import type { DoctorCheck } from "../../core/doctor/index.js";
 import {
   compareVersions,
   expandHome,

package/src/plugins/playwright/provision.ts

@@ -16,7 +16,7 @@
 import { existsSync, readFileSync, readdirSync } from "node:fs";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
-import type { DoctorCheck } from "../../core/doctor.js";
+import type { DoctorCheck } from "../../core/doctor/index.js";
 import {
   failDetail,
   loadProvisionState,

package/src/storage/repositories/cron-repo.ts

@@ -1,7 +1,7 @@
 /**
  * Cron repository — executes the statements in sql/cron.sql against
  * the `cron_jobs` table; no SQL text lives here. The public store
- * (storage/cron-store.ts) holds the domain API and validation; this
+ * (storage/cron.ts) holds the domain API and validation; this
  * module owns statement execution and the row↔domain mapping.
  */
 

package/src/storage/repositories/goals-repo.ts

@@ -1,7 +1,7 @@
 /**
  * Goals repository — executes the statements in sql/goals.sql against
  * the `goals` table; no SQL text lives here. The public store
- * (storage/goal-store.ts) holds the domain API and validation; this
+ * (storage/goals.ts) holds the domain API and validation; this
  * module owns statement execution and the row↔domain mapping.
  */
 

package/src/storage/repositories/scripts-repo.ts

@@ -1,7 +1,7 @@
 /**
  * Scripts repository — executes the statements in sql/scripts.sql
  * against the `scripts` table; no SQL text lives here. The public
- * store (storage/script-store.ts) holds the domain API, validation,
+ * store (storage/scripts.ts) holds the domain API, validation,
  * and the on-disk script files; this module owns statement execution
  * and the row↔domain mapping.
  */

package/src/storage/repositories/triggers-repo.ts

@@ -1,7 +1,7 @@
 /**
  * Triggers repository — executes the statements in sql/triggers.sql
  * against the `triggers` table; no SQL text lives here. The public
- * store (storage/trigger-store.ts) holds the domain API, validation
+ * store (storage/triggers.ts) holds the domain API, validation
  * and the on-disk script/log handling; this module owns statement
  * execution and the row↔domain mapping.
  */

package/src/storage/sql/schema.sql

@@ -140,7 +140,7 @@ CREATE INDEX IF NOT EXISTS idx_goals_chat_status ON goals(chat_id, status, updat
 CREATE INDEX IF NOT EXISTS idx_goals_status ON goals(status, updated_at DESC);
 
 -- Agent-authored scripts. Metadata rows only: the script body lives on
--- disk under ~/.talon/workspace/scripts/ (mirroring the trigger-store
+-- disk under ~/.talon/workspace/scripts/ (mirroring the triggers store
 -- split) so the agent can also Read/Edit a script as a normal workspace
 -- file. Scripts are global capabilities, not chat data — no chat_id
 -- column. `name` is the lookup key; UNIQUE enforces one per name.

package/src/storage/sql/statements.generated.ts

@@ -145,7 +145,7 @@ CREATE INDEX IF NOT EXISTS idx_goals_chat_status ON goals(chat_id, status, updat
 CREATE INDEX IF NOT EXISTS idx_goals_status ON goals(status, updated_at DESC);
 
 -- Agent-authored scripts. Metadata rows only: the script body lives on
--- disk under ~/.talon/workspace/scripts/ (mirroring the trigger-store
+-- disk under ~/.talon/workspace/scripts/ (mirroring the triggers store
 -- split) so the agent can also Read/Edit a script as a normal workspace
 -- file. Scripts are global capabilities, not chat data — no chat_id
 -- column. \`name\` is the lookup key; UNIQUE enforces one per name.
@@ -561,7 +561,7 @@ FROM triggers ORDER BY created_at`,
 SET status = 'terminated',
     pid = NULL,
     ended_at = COALESCE(ended_at, ?),
-    -- Literal must match RESTART_KILL_ERROR in storage/trigger-store.ts.
+    -- Literal must match RESTART_KILL_ERROR in storage/triggers.ts.
     last_error = COALESCE(last_error, 'Talon restarted while trigger was running')
 WHERE status IN ('running', 'pending') AND persistent = 0
 

package/src/storage/sql/triggers.sql

@@ -56,7 +56,7 @@ UPDATE triggers
 SET status = 'terminated',
     pid = NULL,
     ended_at = COALESCE(ended_at, ?),
-    -- Literal must match RESTART_KILL_ERROR in storage/trigger-store.ts.
+    -- Literal must match RESTART_KILL_ERROR in storage/triggers.ts.
     last_error = COALESCE(last_error, 'Talon restarted while trigger was running')
 WHERE status IN ('running', 'pending') AND persistent = 0
 

package/src/frontend/telegram/actions/moderation.ts

@@ -1,255 +0,0 @@
-/**
- * Moderation actions — the `moderate` tool's member/chat/topic operations,
- * plus profile-photo lookup.
- *
- * Handlers call the Bot API directly and let Telegram's own errors surface
- * (missing admin rights come back as descriptive 400s the model can read);
- * pre-checking rights here would just race the real check.
- */
-
-import type { ChatPermissions } from "grammy/types";
-import { toPositiveId } from "./shared.js";
-import { resolveMediaInput } from "./media.js";
-import { clearJoinRequest, listJoinRequests } from "../join-requests.js";
-import type { TelegramActionHandlers } from "./types.js";
-
-/** Seconds-from-now → Telegram until_date, honouring "omit = forever". */
-function untilDate(minutes: unknown): number | undefined {
-  const n = Number(minutes);
-  if (!Number.isFinite(n) || n <= 0) return undefined;
-  return Math.floor(Date.now() / 1000) + Math.round(n * 60);
-}
-
-/**
- * Friendly permission names → ChatPermissions. `send_media` fans out to all
- * the per-kind media flags; raw `can_*` keys pass through untouched so the
- * full API surface stays reachable.
- */
-function toChatPermissions(raw: Record<string, boolean>): ChatPermissions {
-  const out: Record<string, boolean> = {};
-  const alias: Record<string, string[]> = {
-    send_messages: ["can_send_messages"],
-    send_media: [
-      "can_send_audios",
-      "can_send_documents",
-      "can_send_photos",
-      "can_send_videos",
-      "can_send_video_notes",
-      "can_send_voice_notes",
-    ],
-    send_polls: ["can_send_polls"],
-    send_other: ["can_send_other_messages"],
-    web_previews: ["can_add_web_page_previews"],
-    change_info: ["can_change_info"],
-    invite_users: ["can_invite_users"],
-    pin_messages: ["can_pin_messages"],
-    manage_topics: ["can_manage_topics"],
-  };
-  for (const [key, value] of Object.entries(raw)) {
-    if (typeof value !== "boolean") continue;
-    for (const target of alias[key] ?? (key.startsWith("can_") ? [key] : [])) {
-      out[target] = value;
-    }
-  }
-  return out;
-}
-
-/** Everything a mute takes away; unmute grants it back. */
-const FULL_MEMBER_PERMISSIONS: ChatPermissions = toChatPermissions({
-  send_messages: true,
-  send_media: true,
-  send_polls: true,
-  send_other: true,
-  web_previews: true,
-});
-
-/** The workaday admin kit `promote` grants; demote sets all of these false. */
-const DEFAULT_ADMIN_RIGHTS = {
-  can_manage_chat: true,
-  can_delete_messages: true,
-  can_restrict_members: true,
-  can_pin_messages: true,
-  can_invite_users: true,
-  can_change_info: true,
-  can_manage_topics: true,
-  can_manage_video_chats: true,
-};
-
-export const moderationHandlers: TelegramActionHandlers = {
-  moderate: async (body, chatId, ctx) => {
-    const { bot, InputFileClass } = ctx;
-    const op = String(body.op ?? "");
-    const userId = toPositiveId(body.user_id);
-    const needsUser = [
-      "ban",
-      "unban",
-      "mute",
-      "unmute",
-      "promote",
-      "demote",
-      "set_admin_title",
-      "approve_join_request",
-      "decline_join_request",
-    ];
-    if (needsUser.includes(op) && userId === undefined)
-      return { ok: false, error: `${op}: user_id is required` };
-
-    switch (op) {
-      case "ban":
-        await bot.api.banChatMember(chatId, userId!, {
-          until_date: untilDate(body.minutes),
-          revoke_messages: body.delete_messages === true || undefined,
-        });
-        return { ok: true };
-      case "unban":
-        // only_if_banned keeps this from kicking a current member.
-        await bot.api.unbanChatMember(chatId, userId!, {
-          only_if_banned: true,
-        });
-        return { ok: true };
-      case "mute":
-        await bot.api.restrictChatMember(
-          chatId,
-          userId!,
-          { can_send_messages: false },
-          { until_date: untilDate(body.minutes) },
-        );
-        return { ok: true };
-      case "unmute":
-        await bot.api.restrictChatMember(
-          chatId,
-          userId!,
-          FULL_MEMBER_PERMISSIONS,
-        );
-        return { ok: true };
-      case "promote":
-        await bot.api.promoteChatMember(chatId, userId!, DEFAULT_ADMIN_RIGHTS);
-        return { ok: true };
-      case "demote": {
-        const revoked = Object.fromEntries(
-          Object.keys(DEFAULT_ADMIN_RIGHTS).map((k) => [k, false]),
-        );
-        await bot.api.promoteChatMember(chatId, userId!, revoked);
-        return { ok: true };
-      }
-      case "set_admin_title":
-        await bot.api.setChatAdministratorCustomTitle(
-          chatId,
-          userId!,
-          String(body.title ?? ""),
-        );
-        return { ok: true };
-      case "set_permissions": {
-        const raw = body.permissions;
-        if (!raw || typeof raw !== "object")
-          return { ok: false, error: "set_permissions: permissions required" };
-        await bot.api.setChatPermissions(
-          chatId,
-          toChatPermissions(raw as Record<string, boolean>),
-        );
-        return { ok: true };
-      }
-      case "create_invite_link": {
-        const expireMin = Number(body.expire_minutes);
-        const link = await bot.api.createChatInviteLink(chatId, {
-          name: body.title ? String(body.title) : undefined,
-          expire_date:
-            Number.isFinite(expireMin) && expireMin > 0
-              ? Math.floor(Date.now() / 1000) + Math.round(expireMin * 60)
-              : undefined,
-          member_limit: toPositiveId(body.member_limit),
-        });
-        return { ok: true, invite_link: link.invite_link };
-      }
-      case "revoke_invite_link": {
-        if (!body.link)
-          return { ok: false, error: "revoke_invite_link: link required" };
-        await bot.api.revokeChatInviteLink(chatId, String(body.link));
-        return { ok: true };
-      }
-      case "approve_join_request":
-        await bot.api.approveChatJoinRequest(chatId, userId!);
-        clearJoinRequest(chatId, userId!);
-        return { ok: true };
-      case "decline_join_request":
-        await bot.api.declineChatJoinRequest(chatId, userId!);
-        clearJoinRequest(chatId, userId!);
-        return { ok: true };
-      case "list_join_requests":
-        return { ok: true, requests: listJoinRequests(chatId) };
-      case "set_chat_photo": {
-        const resolved = resolveMediaInput(
-          body,
-          "set_chat_photo",
-          InputFileClass,
-        );
-        if ("error" in resolved) return { ok: false, error: resolved.error };
-        if (typeof resolved.file === "string")
-          return {
-            ok: false,
-            error: "set_chat_photo needs a local file_path (no url/file_id)",
-          };
-        await bot.api.setChatPhoto(chatId, resolved.file);
-        return { ok: true };
-      }
-      case "delete_chat_photo":
-        await bot.api.deleteChatPhoto(chatId);
-        return { ok: true };
-      case "unpin_all":
-        await bot.api.unpinAllChatMessages(chatId);
-        return { ok: true };
-      case "leave_chat":
-        await bot.api.leaveChat(chatId);
-        return { ok: true };
-      case "create_topic": {
-        if (!body.title)
-          return { ok: false, error: "create_topic: title required" };
-        const topic = await bot.api.createForumTopic(
-          chatId,
-          String(body.title),
-        );
-        return { ok: true, thread_id: topic.message_thread_id };
-      }
-      case "edit_topic": {
-        const threadId = toPositiveId(body.thread_id);
-        if (threadId === undefined)
-          return { ok: false, error: "edit_topic: thread_id required" };
-        await bot.api.editForumTopic(chatId, threadId, {
-          name: body.title ? String(body.title) : undefined,
-        });
-        return { ok: true };
-      }
-      case "close_topic":
-      case "reopen_topic":
-      case "delete_topic": {
-        const threadId = toPositiveId(body.thread_id);
-        if (threadId === undefined)
-          return { ok: false, error: `${op}: thread_id required` };
-        if (op === "close_topic")
-          await bot.api.closeForumTopic(chatId, threadId);
-        else if (op === "reopen_topic")
-          await bot.api.reopenForumTopic(chatId, threadId);
-        else await bot.api.deleteForumTopic(chatId, threadId);
-        return { ok: true };
-      }
-      default:
-        return { ok: false, error: `Unknown moderation op: ${op}` };
-    }
-  },
-
-  get_user_profile_photos: async (body, _chatId, { bot }) => {
-    const userId = toPositiveId(body.user_id);
-    if (userId === undefined)
-      return { ok: false, error: "user_id is required" };
-    const limit = toPositiveId(body.limit) ?? 5;
-    const photos = await bot.api.getUserProfilePhotos(userId, {
-      limit: Math.min(limit, 100),
-    });
-    return {
-      ok: true,
-      total: photos.total_count,
-      // Largest size of each photo; its file_id sends/downloads like media.
-      file_ids: photos.photos.map((sizes) => sizes[sizes.length - 1].file_id),
-    };
-  },
-};