talon-agent 4.3.0 → 4.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "talon-agent",
-  "version": "4.3.0",
+  "version": "4.3.2",
   "description": "Multi-frontend AI agent with full tool access, streaming, cron jobs, and plugin system",
   "author": "Dylan Neve",
   "license": "MIT",

package/src/app.ts

@@ -23,7 +23,7 @@ import {
   runStartupCatchup,
 } from "./core/background/cron.js";
 import { shutdownTriggers } from "./core/background/triggers/index.js";
-import { pruneSettledTriggers } from "./storage/trigger-store.js";
+import { pruneSettledTriggers } from "./storage/triggers.js";
 import { startWatchdog, stopWatchdog } from "./util/watchdog.js";
 import { spawnSuccessor } from "./util/respawn.js";
 import { log, logError, logWarn } from "./util/log.js";

package/src/bootstrap.ts

@@ -13,8 +13,8 @@ import { loadConfig, rebuildSystemPrompt } from "./util/config.js";
 import { initWorkspace } from "./util/workspace.js";
 import { loadSessions, resetSession } from "./storage/sessions.js";
 import { loadChatSettings } from "./storage/chat-settings.js";
-import { loadCronJobs } from "./storage/cron-store.js";
-import { loadTriggers } from "./storage/trigger-store.js";
+import { loadCronJobs } from "./storage/cron.js";
+import { loadTriggers } from "./storage/triggers.js";
 import { clearHistory, loadHistory } from "./storage/history.js";
 import { loadMediaIndex } from "./storage/media-index.js";
 import { cleanupOldLogs } from "./storage/daily-log.js";
@@ -568,9 +568,12 @@ export async function initBackendAndDispatcher(
     const { crossSendHandlers } =
       await import("./core/engine/gateway-actions/cross-send.js");
     void deliverPendingProvisionReport(async (frontend, target, text) => {
+      // Chat-free: the same "no chat" sentinels handleChatFreeAction passes.
       const result = await crossSendHandlers.send_via(
         { frontend, target, text },
         0,
+        undefined,
+        "0",
       );
       return Boolean(result && (result as { ok?: unknown }).ok === true);
     });

package/src/cli/skill.ts

@@ -2,7 +2,7 @@
  * `talon skill` — install / list / enable / disable / remove SKILL.md
  * workflow bundles.
  *
- * All lifecycle logic lives in storage/skill-store.ts; this module only
+ * All lifecycle logic lives in storage/skills.ts; this module only
  * resolves install sources and renders outcomes. Installs accept a local
  * folder, a git URL, or `owner/repo[/subpath]` (so `talon skill install
  * anthropics/skills/skills/pdf` works). A source folder either IS a skill
@@ -22,7 +22,7 @@ import {
   listSkills,
   setSkillEnabled,
   type Skill,
-} from "../storage/skill-store.js";
+} from "../storage/skills.js";
 import { cloneShallow, resolveSource } from "./install-sources.js";
 
 const USAGE = [

package/src/core/background/cron-spec.ts

@@ -18,7 +18,7 @@ import {
   type CatchupPolicy,
   type CronJob,
   type CronJobType,
-} from "../../storage/cron-store.js";
+} from "../../storage/cron.js";
 
 /** The scheduler ticks once a minute, so sub-minute intervals are meaningless. */
 const MIN_INTERVAL_SECONDS = 60;

package/src/core/background/cron.ts

@@ -31,9 +31,10 @@ import {
   describeSchedule,
   type CronJob,
   type CronRunOutcome,
-} from "../../storage/cron-store.js";
+} from "../../storage/cron.js";
 import { appendDailyLog } from "../../storage/daily-log.js";
 import { log, logError, logWarn } from "../../util/log.js";
+import { numericChatIdFor } from "../../util/chat-id.js";
 import { runJobOneShot } from "./job-oneshot.js";
 import {
   jobAllowsRun,
@@ -464,10 +465,7 @@ const CRON_JOB_TIMEOUT_MS = 10 * 60_000; // 10-minute max per job
 export async function executeJob(job: CronJob): Promise<ExecuteJobResult> {
   if (!deps) return { status: "skipped", reason: "cron is not initialised" };
 
-  const numericChatId = Number(job.chatId);
-  if (!Number.isFinite(numericChatId)) {
-    throw new Error(`Invalid chatId for job "${job.name}": ${job.chatId}`);
-  }
+  const numericChatId = numericChatIdFor(job.chatId);
 
   if (job.type === "message") {
     await deps.sendMessage(numericChatId, job.content, job.chatId);

package/src/core/background/heartbeat/agent.ts

@@ -11,7 +11,7 @@ import { logError, logWarn } from "../../../util/log.js";
 import { toYMD } from "../../../util/time.js";
 import { getDefaultModel } from "../../models/catalog.js";
 import { loadSystemTemplate } from "../../prompt/templates.js";
-import { formatGoal, getOpenGoals } from "../../../storage/goal-store.js";
+import { formatGoal, getOpenGoals } from "../../../storage/goals.js";
 import { taskTable, type TaskHandle } from "../../tasks/index.js";
 import type { Backend } from "../../agent-runtime/capabilities.js";
 import type { OneShotAgentParams } from "../../types.js";

package/src/core/background/triggers/command.ts

@@ -5,7 +5,7 @@
  */
 
 import { spawnSync } from "node:child_process";
-import type { Trigger } from "../../../storage/trigger-store.js";
+import type { Trigger } from "../../../storage/triggers.js";
 import { selfInvocation } from "../../../util/mcp-launcher.js";
 import { LUA_RUN_SUBCOMMAND } from "../../scripting/lua-runner.js";
 

package/src/core/background/triggers/exit.ts

@@ -11,7 +11,7 @@ import {
   SHUTDOWN_KILL_ERROR,
   type Trigger,
   type TriggerStatus,
-} from "../../../storage/trigger-store.js";
+} from "../../../storage/triggers.js";
 import { log, logDebug, logError } from "../../../util/log.js";
 import { appendDailyLog } from "../../../storage/daily-log.js";
 import {

package/src/core/background/triggers/output.ts

@@ -8,7 +8,7 @@ import {
   updateTrigger,
   type TriggerStatus,
   FIRE_PAYLOAD_MAX_BYTES,
-} from "../../../storage/trigger-store.js";
+} from "../../../storage/triggers.js";
 import { logError } from "../../../util/log.js";
 import {
   depsHolder,

package/src/core/background/triggers/resume.ts

@@ -11,7 +11,7 @@ import {
   RESTART_KILL_ERROR,
   SHUTDOWN_KILL_ERROR,
   type Trigger,
-} from "../../../storage/trigger-store.js";
+} from "../../../storage/triggers.js";
 import { log, logError } from "../../../util/log.js";
 import { depsHolder } from "./state.js";
 import { fireWake } from "./output.js";

package/src/core/background/triggers/spawn.ts

@@ -11,7 +11,7 @@ import {
   getTrigger,
   updateTrigger,
   type Trigger,
-} from "../../../storage/trigger-store.js";
+} from "../../../storage/triggers.js";
 import { log, logError, logWarn } from "../../../util/log.js";
 import { spawnWarden, type WardenExitEvent } from "../../../native/warden.js";
 import {

package/src/core/engine/gateway-actions/cron.ts

@@ -11,7 +11,7 @@ import {
   generateCronId,
   describeSchedule,
   nextRunAt,
-} from "../../../storage/cron-store.js";
+} from "../../../storage/cron.js";
 import { runJobNow } from "../../background/cron.js";
 import { parseCronSpec } from "../../background/cron-spec.js";
 import { log } from "../../../util/log.js";
@@ -22,7 +22,7 @@ import {
   acquireBackendInstance,
   isModelValidForBackend,
 } from "../backend-controller/index.js";
-import { validateJobModelOverride } from "./shared.js";
+import { validateJobModelOverride } from "./validation.js";
 import type { SharedActionHandlers } from "./types.js";
 
 /**
@@ -33,19 +33,19 @@ import type { SharedActionHandlers } from "./types.js";
  * Returns an error string, or null when valid.
  */
 async function validateCronModelOverride(
-  chatId: number,
+  chatKey: string,
   model?: string,
   provider?: string,
 ): Promise<string | null> {
-  const chatBackendId = getBackendIdForChat(String(chatId));
+  const chatBackendId = getBackendIdForChat(chatKey);
   if (!provider || provider === chatBackendId) {
     const capabilityErr = validateCronBackgroundCapability(
       chatBackendId,
-      getBackendForChat(String(chatId)),
+      getBackendForChat(chatKey),
     );
     if (capabilityErr) return capabilityErr;
     if (!model) return null;
-    return validateJobModelOverride(chatId, model);
+    return validateJobModelOverride(chatKey, model);
   }
 
   let acquired: Awaited<ReturnType<typeof acquireBackendInstance>> | null =
@@ -85,7 +85,7 @@ function validateCronBackgroundCapability(
 }
 
 export const cronHandlers: SharedActionHandlers = {
-  create_cron_job: async (body, chatId) => {
+  create_cron_job: async (body, chatId, _backend, chatKey) => {
     const parsed = parseCronSpec(body);
     if (!parsed.ok) return { ok: false, error: parsed.error };
     const spec = parsed.effective;
@@ -103,7 +103,7 @@ export const cronHandlers: SharedActionHandlers = {
     // backend is rejected here instead of silently failing at fire time.
     if (jobType === "query") {
       const modelErr = await validateCronModelOverride(
-        chatId,
+        chatKey,
         spec.model,
         spec.provider,
       );
@@ -114,7 +114,7 @@ export const cronHandlers: SharedActionHandlers = {
     addCronJob({
       ...spec,
       id,
-      chatId: String(chatId),
+      chatId: chatKey,
       enabled: true,
       createdAt: Date.now(),
       runCount: 0,
@@ -147,8 +147,8 @@ export const cronHandlers: SharedActionHandlers = {
     };
   },
 
-  list_cron_jobs: (body, chatId) => {
-    const jobs = getCronJobsForChat(String(chatId));
+  list_cron_jobs: (body, chatId, _backend, chatKey) => {
+    const jobs = getCronJobsForChat(chatKey);
     if (jobs.length === 0)
       return { ok: true, text: "No cron jobs in this chat." };
     const fmt = (ms: number) =>
@@ -191,12 +191,12 @@ export const cronHandlers: SharedActionHandlers = {
     };
   },
 
-  edit_cron_job: async (body, chatId) => {
+  edit_cron_job: async (body, chatId, _backend, chatKey) => {
     const jobId = String(body.job_id ?? "");
     if (!jobId) return { ok: false, error: "Missing job_id" };
     const job = getCronJob(jobId);
     if (!job) return { ok: false, error: `Job ${jobId} not found` };
-    if (job.chatId !== String(chatId))
+    if (job.chatId !== chatKey)
       return { ok: false, error: "Job belongs to a different chat" };
 
     const parsed = parseCronSpec(body, job);
@@ -210,7 +210,7 @@ export const cronHandlers: SharedActionHandlers = {
       ("model" in updates || "provider" in updates || "type" in updates)
     ) {
       const modelErr = await validateCronModelOverride(
-        chatId,
+        chatKey,
         effective.model,
         effective.provider,
       );
@@ -233,12 +233,12 @@ export const cronHandlers: SharedActionHandlers = {
     };
   },
 
-  run_cron_job: async (body, chatId) => {
+  run_cron_job: async (body, chatId, _backend, chatKey) => {
     const jobId = String(body.job_id ?? "");
     if (!jobId) return { ok: false, error: "Missing job_id" };
     const job = getCronJob(jobId);
     if (!job) return { ok: false, error: `Job ${jobId} not found` };
-    if (job.chatId !== String(chatId))
+    if (job.chatId !== chatKey)
       return { ok: false, error: "Job belongs to a different chat" };
     const result = await runJobNow(jobId);
     if (!result.ok) return { ok: false, error: result.error ?? "Run failed" };
@@ -246,12 +246,12 @@ export const cronHandlers: SharedActionHandlers = {
     return { ok: true, text: `Ran job "${job.name}" (${jobId}) now.` };
   },
 
-  delete_cron_job: (body, chatId) => {
+  delete_cron_job: (body, chatId, _backend, chatKey) => {
     const jobId = String(body.job_id ?? "");
     if (!jobId) return { ok: false, error: "Missing job_id" };
     const job = getCronJob(jobId);
     if (!job) return { ok: false, error: `Job ${jobId} not found` };
-    if (job.chatId !== String(chatId))
+    if (job.chatId !== chatKey)
       return { ok: false, error: "Job belongs to a different chat" };
     deleteCronJob(jobId);
     return { ok: true, text: `Deleted cron job "${job.name}" (${jobId})` };

package/src/core/engine/gateway-actions/goals.ts

@@ -20,13 +20,13 @@ import {
   OPEN_GOAL_STATUSES,
   type Goal,
   type GoalStatus,
-} from "../../../storage/goal-store.js";
+} from "../../../storage/goals.js";
 import { log } from "../../../util/log.js";
-import { parseDueDate } from "./shared.js";
+import { parseDueDate } from "./validation.js";
 import type { SharedActionHandlers } from "./types.js";
 
 export const goalHandlers: SharedActionHandlers = {
-  add_goal: (body, chatId) => {
+  add_goal: (body, chatId, _backend, chatKey) => {
     const title = String(body.title ?? "").trim();
     const description = body.description ? String(body.description) : undefined;
     const priority = body.priority ?? "normal";
@@ -48,7 +48,7 @@ export const goalHandlers: SharedActionHandlers = {
         };
     }
 
-    const chatIdStr = String(chatId);
+    const chatIdStr = chatKey;
     // No open-goal cap: goals grow freely. The heartbeat re-reads every open
     // goal, so keep them tidy by closing finished ones (completed/abandoned).
 
@@ -75,10 +75,10 @@ export const goalHandlers: SharedActionHandlers = {
     };
   },
 
-  list_goals: (body, chatId) => {
+  list_goals: (body, chatId, _backend, chatKey) => {
     const includeClosed = body.include_closed === true;
     const goals = getGoalsForChat(
-      String(chatId),
+      chatKey,
       includeClosed ? GOAL_STATUSES : OPEN_GOAL_STATUSES,
     );
     if (goals.length === 0)
@@ -94,12 +94,12 @@ export const goalHandlers: SharedActionHandlers = {
     };
   },
 
-  update_goal: (body, chatId) => {
+  update_goal: (body, chatId, _backend, chatKey) => {
     const goalId = String(body.goal_id ?? "");
     if (!goalId) return { ok: false, error: "Missing goal_id" };
     const goal = getGoal(goalId);
     if (!goal) return { ok: false, error: `Goal ${goalId} not found` };
-    if (goal.chatId !== String(chatId))
+    if (goal.chatId !== chatKey)
       return { ok: false, error: "Goal belongs to a different chat" };
 
     const updates: Parameters<typeof updateGoal>[1] = {};
@@ -158,12 +158,12 @@ export const goalHandlers: SharedActionHandlers = {
     };
   },
 
-  delete_goal: (body, chatId) => {
+  delete_goal: (body, chatId, _backend, chatKey) => {
     const goalId = String(body.goal_id ?? "");
     if (!goalId) return { ok: false, error: "Missing goal_id" };
     const goal = getGoal(goalId);
     if (!goal) return { ok: false, error: `Goal ${goalId} not found` };
-    if (goal.chatId !== String(chatId))
+    if (goal.chatId !== chatKey)
       return { ok: false, error: "Goal belongs to a different chat" };
     deleteGoal(goalId);
     return { ok: true, text: `Deleted goal "${goal.title}" (${goalId})` };

package/src/core/engine/gateway-actions/history.ts

@@ -15,9 +15,9 @@ import { formatMediaIndex } from "../../../storage/media-index.js";
 import type { SharedActionHandlers } from "./types.js";
 
 export const historyHandlers: SharedActionHandlers = {
-  read_history: (body, chatId) => {
+  read_history: (body, chatId, _backend, chatKey) => {
     const limit = Math.min(100, Number(body.limit ?? 30));
-    const cid = String(chatId);
+    const cid = chatKey;
     // The tool schema advertises `offset_id` and `before` for paging back;
     // this fallback used to ignore both and hand back the same newest
     // window no matter what the model asked, so "go further back" was a
@@ -36,7 +36,7 @@ export const historyHandlers: SharedActionHandlers = {
     return { ok: true, text: getRecentFormatted(cid, limit) };
   },
 
-  search_history: (body, chatId) => {
+  search_history: (body, chatId, _backend, chatKey) => {
     const limit = Math.min(100, Number(body.limit ?? 20));
     // Optional ISO date bounds; an unparseable one is ignored rather
     // than silently narrowing the search to nothing.
@@ -48,35 +48,28 @@ export const historyHandlers: SharedActionHandlers = {
     };
     return {
       ok: true,
-      text: searchHistory(String(chatId), String(body.query ?? ""), limit, {
+      text: searchHistory(chatKey, String(body.query ?? ""), limit, {
         after: bound(body.after),
         before: bound(body.before),
       }),
     };
   },
 
-  get_user_messages: (body, chatId) => {
+  get_user_messages: (body, chatId, _backend, chatKey) => {
     const limit = Math.min(50, Number(body.limit ?? 20));
     return {
       ok: true,
-      text: getMessagesByUser(
-        String(chatId),
-        String(body.user_name ?? ""),
-        limit,
-      ),
+      text: getMessagesByUser(chatKey, String(body.user_name ?? ""), limit),
     };
   },
 
-  list_known_users: (body, chatId) => ({
+  list_known_users: (body, chatId, _backend, chatKey) => ({
     ok: true,
-    text: getKnownUsers(String(chatId)),
+    text: getKnownUsers(chatKey),
   }),
 
-  list_media: (body, chatId) => ({
+  list_media: (body, chatId, _backend, chatKey) => ({
     ok: true,
-    text: formatMediaIndex(
-      String(chatId),
-      Math.min(20, Number(body.limit ?? 10)),
-    ),
+    text: formatMediaIndex(chatKey, Math.min(20, Number(body.limit ?? 10))),
   }),
 };

package/src/core/engine/gateway-actions/index.ts

@@ -72,15 +72,22 @@ const chatFreeActions: ReadonlySet<string> = new Set([
   ...whatsappAccountChatFreeActions,
 ]);
 
+/**
+ * `chatKey` is the chat's canonical string id (see `SharedActionHandler`).
+ * It defaults to `String(chatId)`, which is exact for Telegram and for the
+ * numeric-only callers (tests, chat-free dispatch); the gateway passes the
+ * real string id it holds for the active turn.
+ */
 export async function handleSharedAction(
   body: Record<string, unknown>,
   chatId: number,
   backend?: Backend | null,
+  chatKey: string = String(chatId),
 ): Promise<ActionResult | null> {
   const action = body.action as string;
   const handler = handlers[action];
   if (!handler) return null; // not a shared action — delegate to frontend
-  return handler(body, chatId, backend);
+  return handler(body, chatId, backend, chatKey);
 }
 
 /**
@@ -104,5 +111,5 @@ export async function handleChatFreeAction(
   if (!isChatFreeAction(action)) return null;
   const handler = handlers[action];
   if (!handler) return null;
-  return handler(body, 0);
+  return handler(body, 0, undefined, "0");
 }

package/src/core/engine/gateway-actions/models.ts

@@ -16,8 +16,8 @@ import {
 import type { SharedActionHandlers } from "./types.js";
 
 export const modelHandlers: SharedActionHandlers = {
-  list_models: async (body, chatId) => {
-    const chatIdStr = String(chatId);
+  list_models: async (body, chatId, _backend, chatKey) => {
+    const chatIdStr = chatKey;
     const currentId = getBackendIdForChat(chatIdStr);
     const requested = body.backend ? String(body.backend).trim() : "";
     const targetId = requested || currentId;
@@ -100,8 +100,8 @@ export const modelHandlers: SharedActionHandlers = {
 
   // Account-level, so it falls back to the pooled Claude backend when
   // another provider is serving this chat.
-  plan_usage: async (_body, chatId) => {
-    const current = getPooledBackend(getBackendIdForChat(String(chatId)));
+  plan_usage: async (_body, chatId, _backend, chatKey) => {
+    const current = getPooledBackend(getBackendIdForChat(chatKey));
     const source = current?.usage?.getPlanUsage
       ? current
       : getPooledBackend("claude");
@@ -131,8 +131,8 @@ export const modelHandlers: SharedActionHandlers = {
     };
   },
 
-  list_backends: (body, chatId) => {
-    const currentId = getBackendIdForChat(String(chatId));
+  list_backends: (body, chatId, _backend, chatKey) => {
+    const currentId = getBackendIdForChat(chatKey);
     const backends = getAvailableBackends().map((b) => ({
       id: b.id,
       label: b.label,

package/src/core/engine/gateway-actions/plugins.ts

@@ -43,7 +43,7 @@ export async function performPluginReload(
 }
 
 export const pluginHandlers: SharedActionHandlers = {
-  reload_plugins: async (body, chatId, backend) => {
+  reload_plugins: async (body, chatId, backend, chatKey) => {
     try {
       const { names } = await performPluginReload(backend);
 
@@ -52,13 +52,7 @@ export const pluginHandlers: SharedActionHandlers = {
       let mcpInfo = "";
       if (backend?.tools?.refreshTools) {
         try {
-          // Prefer body._chatId (string chat ID passed by frontends that use
-          // non-numeric IDs, e.g. Teams/terminal) over the numeric context ID.
-          const refreshChatId =
-            typeof body._chatId === "string" && body._chatId.length > 0
-              ? body._chatId
-              : String(chatId);
-          const result = await backend.tools.refreshTools(refreshChatId);
+          const result = await backend.tools.refreshTools(chatKey);
           if (result) {
             const parts: string[] = [];
             if (result.added.length > 0)

package/src/core/engine/gateway-actions/scripts.ts

@@ -14,7 +14,7 @@ import {
   validateScriptLanguage,
   validateScriptName,
   validateScriptBody,
-} from "../../../storage/script-store.js";
+} from "../../../storage/scripts.js";
 import {
   runScript,
   validateScriptTimeout,

package/src/core/engine/gateway-actions/skills.ts

@@ -15,7 +15,7 @@ import {
   validateSkillBody,
   validateSkillDescription,
   validateSkillName,
-} from "../../../storage/skill-store.js";
+} from "../../../storage/skills.js";
 import { log } from "../../../util/log.js";
 import type { SharedActionHandlers } from "./types.js";