talon-agent 3.32.0 → 3.33.0

package/src/core/tools/mcp-env.ts

@@ -16,15 +16,11 @@
  * talon.json — carried to the subprocess as comma-separated env vars.
  */
 
-import { dirname, resolve } from "node:path";
-import { fileURLToPath, pathToFileURL } from "node:url";
-import { isBunRuntime } from "../../util/runtime.js";
-
 // ── Env-var names (shared constants, not stringly-typed call sites) ────────
 
-export const ENV_BRIDGE_URL = "TALON_BRIDGE_URL";
-export const ENV_CHAT_ID = "TALON_CHAT_ID";
-export const ENV_FRONTEND = "TALON_FRONTEND";
+const ENV_BRIDGE_URL = "TALON_BRIDGE_URL";
+const ENV_CHAT_ID = "TALON_CHAT_ID";
+const ENV_FRONTEND = "TALON_FRONTEND";
 export const ENV_DISABLED_TOOLS = "TALON_DISABLED_TOOLS";
 export const ENV_DISABLED_TOOL_TAGS = "TALON_DISABLED_TOOL_TAGS";
 
@@ -62,32 +58,6 @@ export function buildTalonMcpEnv(
 
 // ── Spawn spec ──────────────────────────────────────────────────────────────
 
-/**
- * The command line that launches Talon's unified MCP tool server.
- *
- * tsx as a Node loader is passed via `--import <file-url>`: Node
- * accepts URLs or absolute paths, but on Windows a raw backslash path
- * is ambiguous between path and URL — `pathToFileURL` always parses
- * as a loader URL. `node --import` (vs spawning `npx`/`tsx` directly)
- * also sidesteps the Node 20.19+ refusal to spawn `.cmd` shims
- * without `shell: true` (CVE-2024-27980 mitigation).
- *
- * Returns a fresh array: callers wrap it in their own supervisor
- * (`wrapMcpServer` / `wrapMcpCommand`) and may mutate it.
- */
-export function talonMcpServerCommand(): string[] {
-  const here = dirname(fileURLToPath(import.meta.url));
-  // Bun executes the TS entry natively — no loader, and use the running
-  // bun binary itself so the child matches the daemon's runtime.
-  if (isBunRuntime()) {
-    return [process.execPath, resolve(here, "mcp-server.ts")];
-  }
-  const tsxImport = pathToFileURL(
-    resolve(here, "../../../node_modules/tsx/dist/esm/index.mjs"),
-  ).href;
-  return ["node", "--import", tsxImport, resolve(here, "mcp-server.ts")];
-}
-
 // ── Parser (server side) ────────────────────────────────────────────────────
 
 /** Parse a comma-separated env var into a trimmed, de-blanked list. */

package/src/core/types.ts

@@ -202,7 +202,7 @@ export interface ContextManager {
  * oversized-message), and a successful one by returning. This keeps
  * the ack settled even when no `onEvent` is supplied at all.
  */
-export type StreamEventSink = {
+type StreamEventSink = {
   onEvent?: (
     event: import("./agent-runtime/events.js").AgentEvent,
   ) => void | Promise<void>;

package/src/core/update/self-update.ts

@@ -41,7 +41,7 @@ export interface UpdateOptions {
 }
 
 /** One executed step in an update run. */
-export interface UpdateStep {
+interface UpdateStep {
   label: string;
   ok: boolean;
   output: string;

package/src/core/vfs/fusefs.ts

@@ -91,7 +91,7 @@ export function namespaceFsStatus(): FuseStatus {
 }
 
 /** Test seam — force a status without a real mount. */
-export function _setNamespaceFsStatusForTesting(next: FuseStatus): void {
+function _setNamespaceFsStatusForTesting(next: FuseStatus): void {
   status = next;
 }
 

package/src/core/vfs/types.ts

@@ -22,7 +22,7 @@
  */
 
 /** What a path points at. */
-export type VfsNodeKind = "dir" | "file";
+type VfsNodeKind = "dir" | "file";
 
 /** Errno-style failure vocabulary — every operation fails with one of these. */
 export type VfsErrorCode =

package/src/core/weaver/index.ts

@@ -1,4 +1,4 @@
-export { Thread, type ThreadSnapshot } from "./thread.js";
+export { Thread } from "./thread.js";
 
 export { Loom, type ContextRegistry } from "./loom.js";
 export { carryTurnEvents } from "./shuttle.js";

package/src/core/weaver/typing-loop.ts

@@ -8,7 +8,7 @@
 import { logWarn } from "../../util/log.js";
 
 /** Platforms expire typing indicators after ~5s; refresh under that. */
-export const TYPING_REFRESH_MS = 4000;
+const TYPING_REFRESH_MS = 4000;
 
 export type SendTyping = (
   numericChatId: number,

package/src/frontend/discord/actions/types.ts

@@ -24,7 +24,7 @@ export interface DiscordActionContext {
   channel: TextBasedChannel | null;
 }
 
-export type DiscordActionHandler = (
+type DiscordActionHandler = (
   body: Record<string, unknown>,
   chatId: number,
   ctx: DiscordActionContext,

package/src/frontend/discord/commands/definitions.ts

@@ -17,7 +17,7 @@ import type { TalonConfig } from "../../../util/config.js";
 import { log, logError, logWarn } from "../../../util/log.js";
 import { getRepoRoot } from "../../../core/update/self-update.js";
 
-export function buildCommandDefinitions(devBuild = false): unknown[] {
+function buildCommandDefinitions(devBuild = false): unknown[] {
   return [
     new SlashCommandBuilder()
       .setName("start")

package/src/frontend/discord/handlers/access.ts

@@ -19,7 +19,6 @@ import {
   userMessageTimestamps,
   RATE_LIMIT_WINDOW_MS,
   RATE_LIMIT_MAX_MESSAGES,
-  type AccessConfig,
 } from "./state.js";
 
 export function setAccessControl(cfg: {
@@ -42,10 +41,6 @@ export function isAdmin(userId: string): boolean {
   return accessState.access.adminUserIds.has(userId);
 }
 
-export function getAccessSnapshot(): AccessConfig {
-  return accessState.access;
-}
-
 export function trackDmUser(
   senderId: string,
   senderName: string,

package/src/frontend/discord/handlers/index.ts

@@ -15,20 +15,7 @@
  * Re-exports the same public surface the old single-file module exposed.
  */
 
-export type { DiscordChatInfo } from "./registry.js";
-export {
-  registerDiscordChat,
-  lookupDiscordChat,
-  lookupDiscordChatByString,
-} from "./registry.js";
-export {
-  setAccessControl,
-  isAdmin,
-  getAccessSnapshot,
-  isAccessAllowed,
-  isInteractionAllowed,
-  shouldHandleInGuild,
-  isUserRateLimited,
-} from "./access.js";
+export { registerDiscordChat, lookupDiscordChat } from "./registry.js";
+export { setAccessControl, isAdmin, isInteractionAllowed } from "./access.js";
 export { getSenderName, sendChunked } from "./context.js";
 export { handleMessage } from "./messages.js";

package/src/frontend/discord/handlers/registry.ts

@@ -21,9 +21,3 @@ export function lookupDiscordChat(
 ): DiscordChatInfo | undefined {
   return chatRegistry.get(numericChatId);
 }
-
-export function lookupDiscordChatByString(
-  chatId: string,
-): DiscordChatInfo | undefined {
-  return chatRegistryByString.get(chatId);
-}

package/src/frontend/native/protocol.ts

@@ -26,7 +26,7 @@ export const BOT_SENDER_ID = 0;
 /** History sender id used for the human on the other end of a native chat. */
 export const USER_SENDER_ID = 1;
 
-export type ClientRole = "user" | "assistant" | "system";
+type ClientRole = "user" | "assistant" | "system";
 
 /** An inline button. `url` opens a link; `data` is an opaque callback token. */
 export type ClientButton = { text: string; url?: string; data?: string };
@@ -238,7 +238,6 @@ export type {
   DeviceCommandResult,
   DeviceInfo,
   DeviceLocation,
-  DevicePlatform,
 } from "../../core/mesh/types.js";
 import type { DeviceCommand as MeshDeviceCommand } from "../../core/mesh/types.js";
 
@@ -323,5 +322,3 @@ export function historyToClientMessage(
     ts: m.timestamp,
   };
 }
-
-export { toDeviceInfo, toDeviceLocation } from "../../core/mesh/types.js";

package/src/frontend/native/server.ts

@@ -48,7 +48,7 @@ import {
 import type { ConfigSnapshot } from "./settings.js";
 
 /** Optional attachment references carried alongside a sent message. */
-export type SendOptions = {
+type SendOptions = {
   /** Relative bridge path to render inline (e.g. `/media?id=…`). */
   imagePath?: string;
   /** Absolute on-disk path handed to the model so it can read the file. */

package/src/frontend/shared/status-context.ts

@@ -292,7 +292,7 @@ export function buildCacheDisplay(input: {
 /** Figures older than this are labelled with their age in /status. */
 const PLAN_STALE_AFTER_MS = 5 * 60_000;
 
-export interface PlanWindowDisplay {
+interface PlanWindowDisplay {
   label: string;
   percent: number;
   bar: string;

package/src/frontend/telegram/actions/types.ts

@@ -20,7 +20,7 @@ export interface TelegramActionContext {
   scheduledMessages: Map<string, ReturnType<typeof setTimeout>>;
 }
 
-export type TelegramActionHandler = (
+type TelegramActionHandler = (
   body: Record<string, unknown>,
   chatId: number,
   ctx: TelegramActionContext,

package/src/frontend/telegram/commands/index.ts

@@ -24,7 +24,7 @@ import { registerSettingsCommands } from "./settings.js";
 import { registerAdminCommands } from "./admin.js";
 import { registerWhatsAppPairingCommand } from "./whatsapp-pairing.js";
 
-export { TELEGRAM_COMMANDS, telegramCommandMenu } from "./definitions.js";
+export { telegramCommandMenu } from "./definitions.js";
 export { setAdminUserId } from "./state.js";
 
 export function registerCommands(

package/src/frontend/telegram/commands/state.ts

@@ -11,7 +11,7 @@ import type { Context } from "grammy";
 import type { Backend } from "../../../core/agent-runtime/capabilities.js";
 
 /** Admin user ID is set via talon.json or TALON_ADMIN_USER_ID env var. */
-export const adminState = { adminUserId: 0 };
+const adminState = { adminUserId: 0 };
 
 /** Set the admin user ID (called from config at startup). */
 export function setAdminUserId(id: number | undefined): void {

package/src/frontend/telegram/handlers/index.ts

@@ -16,7 +16,6 @@
 export {
   setAccessControl,
   shouldHandleInGroup,
-  isAccessAllowed,
   extractUnauthorizedPreview,
 } from "./access.js";
 export {

package/src/frontend/telegram/helpers/menu.ts

@@ -75,7 +75,7 @@ export interface SettingsPager {
  * callback for disabled-edge buttons (Telegram requires every inline
  * button to carry callback data).
  */
-export function renderModelPickerControlRows(
+function renderModelPickerControlRows(
   pager: SettingsPager,
   navPrefix: string,
   noopData: string,

package/src/frontend/terminal/commands.ts

@@ -62,10 +62,7 @@ export type CommandContext = {
   backend?: Backend | null;
 };
 
-export type CommandHandler = (
-  args: string,
-  ctx: CommandContext,
-) => Promise<void>;
+type CommandHandler = (args: string, ctx: CommandContext) => Promise<void>;
 
 export type Command = {
   name: string;

package/src/frontend/terminal/renderer.ts

@@ -11,7 +11,7 @@ import { formatUsd } from "../shared/format.js";
 
 // ── Types ────────────────────────────────────────────────────────────────────
 
-export type StatusBarInfo = {
+type StatusBarInfo = {
   model: string;
   sessionName?: string;
   turns: number;

package/src/frontend/whatsapp/actions/chat-info.ts

@@ -6,7 +6,6 @@
  * assembled from the registry and the profile endpoints.
  */
 
-import { downloadMediaMessage } from "baileys";
 import { lookupMessage } from "../message-store.js";
 import { toUserJid, tryAction } from "./shared.js";
 import type { WhatsAppActionHandlers } from "./types.js";
@@ -224,5 +223,3 @@ export const chatInfoHandlers: WhatsAppActionHandlers = {
           };
     }),
 };
-
-export { downloadMediaMessage };

package/src/frontend/whatsapp/actions/messaging.ts

@@ -11,11 +11,7 @@ import { randomUUID } from "node:crypto";
 import { proto } from "baileys";
 import { log } from "../../../util/log.js";
 import { toWhatsAppText } from "../formatting.js";
-import {
-  lookupMessage,
-  rememberMessage,
-  resolveKey,
-} from "../message-store.js";
+import { lookupMessage, resolveKey } from "../message-store.js";
 import { recordPin, listPins, forgetPin } from "../pins.js";
 import {
   resolveQuoted,
@@ -293,5 +289,3 @@ export const messagingHandlers: WhatsAppActionHandlers = {
     };
   },
 };
-
-export { rememberMessage };

package/src/frontend/whatsapp/actions/shared.ts

@@ -177,7 +177,7 @@ function outboundTextMarker(content: AnyMessageContent): string {
 const SEND_TIMEOUT_MS = 60_000;
 let sendTail: Promise<unknown> = Promise.resolve();
 
-export class WhatsAppSendTimeoutError extends Error {
+class WhatsAppSendTimeoutError extends Error {
   constructor(operation: string) {
     super(
       `WhatsApp ${operation} timed out after ${SEND_TIMEOUT_MS / 1000}s — ` +

package/src/frontend/whatsapp/actions/types.ts

@@ -25,7 +25,7 @@ export interface WhatsAppActionContext {
   scheduledMessages: Map<string, ReturnType<typeof setTimeout>>;
 }
 
-export type WhatsAppActionHandler = (
+type WhatsAppActionHandler = (
   body: Record<string, unknown>,
   chatId: number,
   ctx: WhatsAppActionContext,

package/src/frontend/whatsapp/formatting.ts

@@ -17,7 +17,7 @@ import { marked, type Token, type Tokens } from "marked";
 import { splitMessage } from "../telegram/formatting.js";
 
 /** WhatsApp accepts far more, but long bubbles read badly on a phone. */
-export const WHATSAPP_MAX_TEXT = 4096;
+const WHATSAPP_MAX_TEXT = 4096;
 
 /** Rendered width of a table cell, for the monospace fallback. */
 const MAX_TABLE_CELL = 24;

package/src/frontend/whatsapp/media-store.ts

@@ -31,7 +31,7 @@ export type SavedMedia = {
 };
 
 /** The media kind carried by a message, if any. */
-export function mediaKindOf(
+function mediaKindOf(
   message: WAMessage,
 ): (typeof MEDIA_KINDS)[number] | undefined {
   const content = message.message;

package/src/frontend/whatsapp/pins.ts

@@ -45,8 +45,3 @@ export function forgetPin(chatId: string, msgId: number): void {
 export function listPins(chatId: string): PinnedMessage[] {
   return pinsByChat.get(chatId) ?? [];
 }
-
-/** Test seam: forget every recorded pin. */
-export function resetPins(): void {
-  pinsByChat.clear();
-}

package/src/native/fusefs.ts

@@ -20,7 +20,7 @@ import { createRequire } from "node:module";
 import { fileURLToPath } from "node:url";
 
 /** One root symlink entry the mount serves (a file-backed mount). */
-export interface FuseSymlinkSpec {
+interface FuseSymlinkSpec {
   name: string;
   target: string;
 }
@@ -32,7 +32,7 @@ export interface FuseSymlinkSpec {
  * namespace-relative ("proc/tasks/7"). The reply JSON shapes are
  * defined by `serveNamespaceRequest` in core/vfs/fusefs.ts.
  */
-export type FuseBridgeHandler = (id: number, op: string, path: string) => void;
+type FuseBridgeHandler = (id: number, op: string, path: string) => void;
 
 /** The N-API surface exported by native/talon-fusefs. */
 export interface NativeFuseFs {
@@ -92,6 +92,6 @@ function loadNativeFuseFs(): NativeFuseFs | null {
 }
 
 /** Tests swap addons via TALON_FUSEFS_NODE and need the memo dropped. */
-export function _resetNativeFuseFsForTesting(): void {
+function _resetNativeFuseFsForTesting(): void {
   addon = undefined;
 }

package/src/native/scheduler-core.ts

@@ -37,7 +37,7 @@ export function backoffDelayMs(
 
 // ── Circuit breaker ─────────────────────────────────────────────────────────
 
-export type BreakerState = "closed" | "open" | "half-open";
+type BreakerState = "closed" | "open" | "half-open";
 
 export type Breaker = {
   state: BreakerState;

package/src/native/warden.ts

@@ -28,13 +28,13 @@ import { accessSync, constants } from "node:fs";
 import { createInterface } from "node:readline";
 import { fileURLToPath } from "node:url";
 
-export interface WardenStartEvent {
+interface WardenStartEvent {
   pid: number;
   /** Linux /proc/<pid>/stat field 22 (jiffies since boot); null off-Linux. */
   pidStarttime: number | null;
 }
 
-export interface WardenLineEvent {
+interface WardenLineEvent {
   stream: "stdout" | "stderr";
   text: string;
   /** True when the line exceeded the byte cap and its tail was dropped. */

package/src/plugins/mempalace/provision.ts

@@ -148,11 +148,7 @@ export function classifyExternalInstall(pythonPath: string): string {
  * version, per flavor. Works in both directions (a newer-than-pin
  * install reconciles down), hence the neutral name.
  */
-export function reconcileHint(
-  kind: string,
-  python: string,
-  target: string,
-): string {
+function reconcileHint(kind: string, python: string, target: string): string {
   if (kind === "uv-tool") {
     return `uv tool install --force 'mempalace==${target}'`;
   }

package/src/plugins/playwright/provision.ts

@@ -57,7 +57,7 @@ export interface PlaywrightProvisionDeps {
 }
 
 /** One entry of playwright-core's browsers.json. */
-export interface BrowserDescriptor {
+interface BrowserDescriptor {
   name: string;
   revision: string;
   /** Per-host-platform revisions (e.g. webkit on older macOS). */

package/src/storage/db.ts

@@ -37,7 +37,7 @@ import { SCHEMA, dbSql } from "./sql/statements.generated.js";
  * statements with positional params, identical row object shapes,
  * multi-statement exec, FTS5 virtual tables).
  */
-export type SqlStatement = {
+type SqlStatement = {
   get(...params: unknown[]): unknown;
   all(...params: unknown[]): unknown[];
   run(...params: unknown[]): unknown;

package/src/storage/goal-store.ts

@@ -34,11 +34,7 @@ export const GOAL_STATUSES: readonly GoalStatus[] = [
   "completed",
   "abandoned",
 ];
-export const GOAL_PRIORITIES: readonly GoalPriority[] = [
-  "low",
-  "normal",
-  "high",
-];
+const GOAL_PRIORITIES: readonly GoalPriority[] = ["low", "normal", "high"];
 
 /** Statuses that count as "open" — shown to the heartbeat and listings. */
 export const OPEN_GOAL_STATUSES: readonly GoalStatus[] = ["active", "paused"];

package/src/storage/metrics.ts

@@ -24,11 +24,6 @@ export function incrementCounter(name: string, amount = 1): void {
   legacyCounters.set(name, (legacyCounters.get(name) ?? 0) + amount);
 }
 
-export function recordHistogram(_name: string, _value: number): void {
-  // The old global histogram ring is intentionally gone. Chat-turn
-  // histograms are now latency aggregates on SessionMetrics.
-}
-
 function addCounter(
   counters: Record<string, number>,
   name: string,

package/src/storage/repositories/scripts-repo.ts

@@ -79,11 +79,6 @@ export function all(): Script[] {
   return rows.map(rowToScript);
 }
 
-export function count(): number {
-  const row = getDatabase().prepare(scriptsSql.count).get() as { n: number };
-  return row.n;
-}
-
 export function recordUse(name: string, when: number): void {
   getDatabase().prepare(scriptsSql.recordUse).run(when, name);
 }

package/src/storage/scheduled-store.ts

@@ -24,7 +24,7 @@ const KEY = "scheduled.messages";
  * "dinner in an hour" reminder is noise, not delivery. */
 export const MAX_OVERDUE_MS = 24 * 60 * 60 * 1000;
 
-export type ScheduledButtonRow = Array<{
+type ScheduledButtonRow = Array<{
   text: string;
   url?: string;
   callback_data?: string;
@@ -67,10 +67,6 @@ export function deleteScheduled(id: string): boolean {
   return true;
 }
 
-export function getScheduled(id: string): ScheduledMessage | undefined {
-  return readAll()[id];
-}
-
 /** All pending entries for a frontend, soonest first. */
 export function listScheduled(frontend: string): ScheduledMessage[] {
   return Object.values(readAll())

package/src/storage/script-store.ts

@@ -25,11 +25,7 @@ import * as repo from "./repositories/scripts-repo.js";
 export type { Script, ScriptLanguage } from "./repositories/scripts-repo.js";
 import type { Script, ScriptLanguage } from "./repositories/scripts-repo.js";
 
-export const SCRIPT_LANGUAGES: readonly ScriptLanguage[] = [
-  "bash",
-  "python",
-  "node",
-];
+const SCRIPT_LANGUAGES: readonly ScriptLanguage[] = ["bash", "python", "node"];
 
 /**
  * Stricter than the trigger name rule: a script name doubles as its
@@ -81,16 +77,16 @@ export function validateScriptDescription(description: string): string | null {
 
 // ── Script files ────────────────────────────────────────────────────────────
 
-export function scriptsDir(): string {
+function scriptsDir(): string {
   return dirs.scripts;
 }
 
-export function scriptFilePath(name: string, lang: ScriptLanguage): string {
+function scriptFilePath(name: string, lang: ScriptLanguage): string {
   return resolve(scriptsDir(), `${name}.${EXTENSIONS[lang]}`);
 }
 
 /** Write a script's body, creating the scripts dir as needed. */
-export function writeScriptFile(
+function writeScriptFile(
   name: string,
   lang: ScriptLanguage,
   body: string,
@@ -104,7 +100,7 @@ export function writeScriptFile(
 
 // ── CRUD ────────────────────────────────────────────────────────────────────
 
-export function generateScriptId(): string {
+function generateScriptId(): string {
   return `script_${randomUUID()}`;
 }
 
@@ -152,10 +148,6 @@ export function getAllScripts(): Script[] {
   return repo.all();
 }
 
-export function countScripts(): number {
-  return repo.count();
-}
-
 export function recordScriptUse(name: string): void {
   repo.recordUse(name, Date.now());
 }

package/src/storage/sessions.ts

@@ -28,11 +28,8 @@ export type {
   MetricsCounterSet,
   MetricsGrain,
   MetricsLatencyAgg,
-  SessionMetrics,
   SessionState,
-  SessionUsage,
 } from "./session-record.js";
-export { emptyMetrics, normaliseMetrics } from "./session-record.js";
 import {
   emptyCounters,
   emptyGrain,

package/src/storage/skill-store.ts

@@ -66,15 +66,15 @@ const BODY_MAX_BYTES = 128 * 1024;
 const PROMPT_LIST_LIMIT = 25;
 const SEARCH_RESULT_LIMIT = 10;
 
-export function skillsDir(): string {
+function skillsDir(): string {
   return dirs.skills;
 }
 
-export function skillDir(name: string): string {
+function skillDir(name: string): string {
   return resolve(skillsDir(), name);
 }
 
-export function skillFilePath(name: string): string {
+function skillFilePath(name: string): string {
   return resolve(skillDir(name), SKILL_FILE);
 }
 

package/src/util/exec-output.ts

@@ -11,7 +11,7 @@
  */
 
 /** In-memory cap while capturing one child-process output stream. */
-export const MAX_EXEC_CAPTURE_BYTES = 4 * 1024 * 1024;
+const MAX_EXEC_CAPTURE_BYTES = 4 * 1024 * 1024;
 
 /** Ceiling on each rendered exec stream (stdout, stderr independently). */
 export const MAX_EXEC_RENDER_CHARS = 30_000;

package/src/util/mcp-launcher.ts

@@ -83,6 +83,9 @@ export const MCP_LAUNCH_SUBCOMMAND = "_mcp-launch";
  * `[command, ...argsPrefix]` that launches an entry which DOES dispatch
  * (e.g. `["node", "--import", "<tsx esm url>",
  * "<abs path to src/cli.ts>"]`).
+ *
+ * @public — consumed by embedders (and the integration probe), not by
+ * Talon's own graph, so knip must not report it.
  */
 export const SUPERVISOR_CMD_ENV = "TALON_MCP_SUPERVISOR_CMD";