talon-agent 3.0.3 → 3.0.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "talon-agent",
-  "version": "3.0.3",
+  "version": "3.0.5",
   "description": "Multi-frontend AI agent with full tool access, streaming, cron jobs, and plugin system",
   "author": "Dylan Neve",
   "license": "MIT",

package/src/backend/claude-sdk/models/discovery.ts

@@ -52,6 +52,10 @@ async function probeSupportedModels(
           reject(new Error("aborted")),
         );
       });
+      // Unreachable — the promise above only ever rejects. The yield* both
+      // satisfies require-yield and documents that this stream produces
+      // nothing by design (streaming-input mode with no user message).
+      yield* [] as never[];
     };
 
     const q = query({

package/src/backend/claude-sdk/warm.ts

@@ -43,6 +43,10 @@ export async function warmSession(chatId: string): Promise<void> {
           reject(new Error("aborted")),
         );
       });
+      // Unreachable — the promise above only ever rejects. The yield* both
+      // satisfies require-yield and documents that this stream produces
+      // nothing by design (streaming-input mode with no user message).
+      yield* [] as never[];
     };
 
     const q = query({

package/src/backend/remote-server/mcp.ts

@@ -133,7 +133,8 @@ export async function ensureChatMcpServer<TClient extends RemoteAgentClient>(
   // Rotate out other chat servers BEFORE registering this one. The
   // heartbeat sentinel server is exempt (it has no real chat to leak
   // into and stays connected for cron / trigger paths).
-  for (const other of [...state.registeredMcpServers]) {
+  // Snapshot: rotation removes entries from the live set mid-iteration.
+  for (const other of Array.from(state.registeredMcpServers)) {
     if (
       !other.startsWith(`${TALON_MCP_SERVER_NAME}-`) ||
       other === serverName ||

package/src/core/engine/gateway-actions/native.ts

@@ -672,6 +672,16 @@ async function edit(
     }
   }
 
+  // Binary guard: decoding binary as UTF-8 is lossy (invalid sequences
+  // become U+FFFD), so a read→replace→write round-trip would corrupt every
+  // non-text byte — even when old_string matches a clean region.
+  if (content.includes("\0")) {
+    return {
+      ok: false,
+      text: `${shown} looks binary — refusing a text edit that would corrupt it. Use bash for byte-level changes.`,
+    };
+  }
+
   const count = from ? content.split(from).length - 1 : 0;
   if (count === 0) {
     return {
@@ -693,13 +703,14 @@ async function edit(
     replaceAll === true
       ? content.split(from).join(to)
       : spliceOnce(content, from, to);
+  const firstLine = content.slice(0, content.indexOf(from)).split("\n").length;
 
   if (active) {
     const res = await svc.writeFileToDevice(active.deviceId, p, updated);
     return res.ok
       ? {
           ok: true,
-          text: `Edited ${shown} [${active.deviceName}] (${count} replacement${count === 1 ? "" : "s"}).`,
+          text: `Edited ${shown} [${active.deviceName}] (${count} replacement${count === 1 ? "" : "s"}, first at line ${firstLine}).`,
         }
       : res;
   }
@@ -713,7 +724,7 @@ async function edit(
   }
   return {
     ok: true,
-    text: `Edited ${shown} [local] (${count} replacement${count === 1 ? "" : "s"}).`,
+    text: `Edited ${shown} [local] (${count} replacement${count === 1 ? "" : "s"}, first at line ${firstLine}).`,
   };
 }
 
@@ -733,8 +744,8 @@ async function glob(
     // -name, path patterns via -path). `command -v` gates the choice so a
     // no-match rg exit (1) isn't misread as "rg missing, run find too".
     const findExpr = pat.includes("/")
-      ? `-path ${shellQuote(`*${pat}`)}`
-      : `-name ${shellQuote(pat)}`;
+      ? `-type f -path ${shellQuote(`*${pat}`)}`
+      : `-type f -name ${shellQuote(pat)}`;
     const cmd =
       `if command -v rg >/dev/null 2>&1; ` +
       `then rg --files -g ${shellQuote(pat)} ${shellQuote(root)}; ` +

package/src/core/mesh/service.ts

@@ -193,7 +193,9 @@ export class MeshService {
     // Stamp arrival against our own clock so waitForFreshLocation is immune
     // to device clock skew.
     this.receivedAt.set(loc.deviceId, Date.now());
-    for (const notify of [...this.waiters]) notify();
+    // Snapshot: a notified waiter removes itself (and new waiters may be
+    // added) mid-iteration — iterate a copy, not the live set.
+    for (const notify of Array.from(this.waiters)) notify();
     return loc;
   }
 
@@ -372,11 +374,11 @@ export class MeshService {
 
   /** `ring_device`: make the device sound/vibrate so it can be found. */
   ringDevice(query?: unknown, message?: unknown): Promise<MeshToolResult> {
-    return this.commandTool(query, "ring", {
-      ...(typeof message === "string" && message.trim()
-        ? { message: message.trim().slice(0, 200) }
-        : {}),
-    });
+    const note =
+      typeof message === "string" && message.trim()
+        ? message.trim().slice(0, 200)
+        : undefined;
+    return this.commandTool(query, "ring", note ? { message: note } : {});
   }
 
   /**

package/src/core/plugin/manage.ts

@@ -77,7 +77,7 @@ export function setPluginEnabled(
   if (!name) return { ok: false, error: "A plugin name is required." };
 
   if (isBuiltinPlugin(name)) {
-    const section = { ...(builtinSection(config, name) ?? {}), enabled };
+    const section = { ...builtinSection(config, name), enabled };
     (config as unknown as Record<string, unknown>)[name] = section;
     return { ok: true, name, persist: { [name]: section } };
   }

package/src/core/soul/centrality.ts

@@ -48,7 +48,7 @@ export function pagerank(
   const idx = new Map(nodes.map((h, i) => [h, i]));
 
   // Weighted out-adjacency over coactivation edges (only among value nodes).
-  const outWeight = new Array<number>(n).fill(0);
+  const outWeight = Array.from({ length: n }, () => 0);
   const edges: { from: number; to: number; w: number }[] = [];
   for (const from of nodes) {
     for (const e of dag.edgesFrom(from, "coactivation")) {
@@ -61,7 +61,7 @@ export function pagerank(
   }
 
   // Teleport / personalization vector.
-  const teleport = new Array<number>(n).fill(1 / n);
+  const teleport = Array.from({ length: n }, () => 1 / n);
   if (opts.personalization && opts.personalization.size > 0) {
     let total = 0;
     for (const [, w] of opts.personalization) total += Math.max(0, w);
@@ -74,7 +74,7 @@ export function pagerank(
     }
   }
 
-  let rank = new Array<number>(n).fill(1 / n);
+  let rank = Array.from({ length: n }, () => 1 / n);
   for (let it = 0; it < iterations; it++) {
     const next = teleport.map((t) => (1 - damping) * t);
 

package/src/core/soul/critic.ts

@@ -66,7 +66,10 @@ const SYCOPHANCY = [
 
 // Emoji detection without a heavy dependency: pictographic + symbol ranges.
 const EMOJI_RE =
-  /[\u{1F300}-\u{1FAFF}\u{2600}-\u{27BF}\u{2190}-\u{21FF}\u{2B00}-\u{2BFF}\u{FE00}-\u{FE0F}\u{1F000}-\u{1F0FF}]/gu;
+  // Variation selectors are combining marks — alternated separately so the
+  // character class holds only standalone pictographic ranges
+  // (no-misleading-character-class).
+  /[\u{1F300}-\u{1FAFF}\u{2600}-\u{27BF}\u{2190}-\u{21FF}\u{2B00}-\u{2BFF}\u{1F000}-\u{1F0FF}]|[\u{FE00}-\u{FE0F}]/gu;
 
 function countOccurrences(
   haystack: string,

package/src/core/soul/embedder.ts

@@ -63,7 +63,7 @@ export function cosineDistance(
 export function centroid(vectors: readonly (readonly number[])[]): number[] {
   if (vectors.length === 0) return [];
   const dim = vectors[0]!.length;
-  const acc = new Array<number>(dim).fill(0);
+  const acc = Array.from({ length: dim }, () => 0);
   for (const v of vectors) {
     for (let i = 0; i < dim; i++) acc[i]! += v[i]!;
   }
@@ -110,7 +110,7 @@ export class HashingEmbedder implements Embedder {
   }
 
   private embedOne(text: string): number[] {
-    const vec = new Array<number>(this.dim).fill(0);
+    const vec = Array.from({ length: this.dim }, () => 0);
     const lower = text.toLowerCase();
     const add = (feature: string): void => {
       const h = createHash("md5").update(feature).digest();

package/src/core/soul/talon-embedder.ts

@@ -67,7 +67,7 @@ export class TalonEmbedder implements Embedder {
       }
     }
 
-    const vec = new Array<number>(this.dim).fill(0);
+    const vec = Array.from({ length: this.dim }, () => 0);
     for (const [feature, count] of counts) {
       const h = createHash("md5").update(feature).digest();
       const idx = ((h[0]! << 16) | (h[1]! << 8) | h[2]!) % this.dim;

package/src/frontend/telegram/formatting.ts

@@ -69,24 +69,29 @@ export function markdownToTelegramHtml(text: string): string {
   );
   // Italic: _text_ (surrounded by non-word or start/end)
   processed = processed.replace(/(?<!\w)_(.+?)_(?!\w)/g, "<i>$1</i>");
-  // Links: [text](url) — only allow safe URL schemes; escape the URL to
-  // prevent HTML attribute injection (e.g. href="url" onmouseover="x")
+  // Links: [text](url) — only safe URL schemes become anchors. Both text
+  // and url were already HTML-escaped by step 3 (quotes included, so the
+  // href attribute can't be broken out of); escaping again here corrupted
+  // every & in a query string into &amp;amp;.
   processed = processed.replace(/\[([^\]]+)\]\(([^)]+)\)/g, (_, text, url) =>
-    /^https?:\/\//i.test(url)
-      ? `<a href="${escapeHtml(url)}">${escapeHtml(text)}</a>`
-      : text,
+    /^https?:\/\//i.test(url) ? `<a href="${url}">${text}</a>` : text,
   );
   // Strikethrough: ~~text~~
   processed = processed.replace(/~~(.+?)~~/g, "<s>$1</s>");
 
-  // Step 5: Restore inline code spans.
+  // Steps 5+6: Restore code spans and fenced blocks. The replacement MUST
+  // go through a function: with a string, String.replace interprets $-
+  // substitution patterns in the *code content* ($& re-inserts the
+  // placeholder, $\` splices the whole preceding message), which is how
+  // \`$&\` in a code span used to leak a stranded INLINECODEn into chat.
   for (let i = 0; i < inlineCode.length; i++) {
-    processed = processed.replace(`\x00INLINECODE${i}\x00`, inlineCode[i]);
+    processed = processed.replace(
+      `\x00INLINECODE${i}\x00`,
+      () => inlineCode[i],
+    );
   }
-
-  // Step 6: Restore fenced code blocks.
   for (let i = 0; i < codeBlocks.length; i++) {
-    processed = processed.replace(`\x00CODEBLOCK${i}\x00`, codeBlocks[i]);
+    processed = processed.replace(`\x00CODEBLOCK${i}\x00`, () => codeBlocks[i]);
   }
 
   return processed;

package/src/plugins/github/index.ts

@@ -98,9 +98,9 @@ export function createGitHubPlugin(config: { token?: string }): TalonPlugin {
     },
 
     getEnvVars() {
-      return {
-        ...(token ? { GITHUB_PERSONAL_ACCESS_TOKEN: token } : {}),
-      };
+      const vars: Record<string, string> = {};
+      if (token) vars.GITHUB_PERSONAL_ACCESS_TOKEN = token;
+      return vars;
     },
   };
 }