talon-agent 1.2.0 → 1.4.0

package/src/__tests__/gateway-actions.test.ts

@@ -125,9 +125,6 @@ describe("gateway shared actions", () => {
     originalFetch = globalThis.fetch;
     originalEnv = { ...process.env };
     vi.clearAllMocks();
-    // Reset env vars used by web_search
-    delete process.env.TALON_BRAVE_API_KEY;
-    delete process.env.TALON_SEARXNG_URL;
   });
 
   afterEach(() => {
@@ -276,377 +273,6 @@ describe("gateway shared actions", () => {
     });
   });
 
-  // ════════════════════════════════════════════════════════════════════════
-  // web_search
-  // ════════════════════════════════════════════════════════════════════════
-
-  describe("web_search", () => {
-    it("returns error for missing query", async () => {
-      const result = await handleSharedAction({ action: "web_search" }, 123);
-      expect(result).toEqual({ ok: false, error: "Missing query" });
-    });
-
-    it("returns error for empty query string", async () => {
-      const result = await handleSharedAction(
-        { action: "web_search", query: "" },
-        123,
-      );
-      expect(result).toEqual({ ok: false, error: "Missing query" });
-    });
-
-    it("uses Brave API when key is configured", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-brave-key";
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          contentType: "application/json",
-          json: {
-            web: {
-              results: [
-                {
-                  title: "Result 1",
-                  url: "https://example.com/1",
-                  description: "Description 1",
-                },
-                {
-                  title: "Result 2",
-                  url: "https://example.com/2",
-                  description: "Description 2",
-                },
-              ],
-            },
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "test query" },
-        123,
-      );
-
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toContain("via Brave");
-      expect(result?.text).toContain("Result 1");
-      expect(result?.text).toContain("https://example.com/1");
-      expect(result?.text).toContain("Description 1");
-      expect(result?.text).toContain("Result 2");
-
-      // Verify Brave API was called correctly
-      expect(mockFetch).toHaveBeenCalledTimes(1);
-      const [url, opts] = mockFetch.mock.calls[0];
-      expect(url).toContain("api.search.brave.com");
-      expect(url).toContain("q=test%20query");
-      expect(url).toContain("count=5");
-      expect(opts.headers["X-Subscription-Token"]).toBe("test-brave-key");
-    });
-
-    it("respects custom limit for Brave API", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-brave-key";
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            web: {
-              results: [{ title: "R", url: "https://r.com", description: "d" }],
-            },
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      await handleSharedAction(
-        { action: "web_search", query: "test", limit: 8 },
-        123,
-      );
-      const [url] = mockFetch.mock.calls[0];
-      expect(url).toContain("count=8");
-    });
-
-    it("clamps search limit to 10", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-brave-key";
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            web: {
-              results: [{ title: "R", url: "https://r.com", description: "d" }],
-            },
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      await handleSharedAction(
-        { action: "web_search", query: "test", limit: 50 },
-        123,
-      );
-      const [url] = mockFetch.mock.calls[0];
-      expect(url).toContain("count=10");
-    });
-
-    it("falls back to SearXNG when Brave returns non-ok", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-brave-key";
-      const mockFetch = vi
-        .fn()
-        .mockResolvedValueOnce(mockResponse({ ok: false, status: 429 })) // Brave fails
-        .mockResolvedValueOnce(
-          mockResponse({
-            ok: true,
-            json: {
-              results: [
-                {
-                  title: "SearX Result",
-                  url: "https://searx.example.com",
-                  content: "SearX snippet",
-                },
-              ],
-            },
-          }),
-        );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "fallback test" },
-        123,
-      );
-
-      expect(mockFetch).toHaveBeenCalledTimes(2);
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toContain("via SearXNG");
-      expect(result?.text).toContain("SearX Result");
-    });
-
-    it("falls back to SearXNG when Brave throws an error", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-brave-key";
-      const mockFetch = vi
-        .fn()
-        .mockRejectedValueOnce(new Error("network error")) // Brave throws
-        .mockResolvedValueOnce(
-          mockResponse({
-            ok: true,
-            json: {
-              results: [
-                {
-                  title: "Fallback",
-                  url: "https://fb.com",
-                  content: "snippet",
-                },
-              ],
-            },
-          }),
-        );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "test" },
-        123,
-      );
-
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toContain("via SearXNG");
-    });
-
-    it("uses SearXNG directly when no Brave key", async () => {
-      // No TALON_BRAVE_API_KEY set
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            results: [
-              {
-                title: "Direct SearX",
-                url: "https://searx.com/r",
-                content: "content here",
-              },
-            ],
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "direct" },
-        123,
-      );
-
-      expect(mockFetch).toHaveBeenCalledTimes(1);
-      const [url] = mockFetch.mock.calls[0];
-      expect(url).toContain("localhost:8080");
-      expect(url).toContain("format=json");
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toContain("via SearXNG");
-    });
-
-    it("uses custom SearXNG URL from env", async () => {
-      process.env.TALON_SEARXNG_URL = "http://my-searx:9090";
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            results: [{ title: "T", url: "https://t.com", content: "c" }],
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      await handleSharedAction({ action: "web_search", query: "custom" }, 123);
-
-      const [url] = mockFetch.mock.calls[0];
-      expect(url).toContain("my-searx:9090");
-    });
-
-    it("returns 'no results' when both providers fail", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const mockFetch = vi
-        .fn()
-        .mockRejectedValueOnce(new Error("brave fail"))
-        .mockRejectedValueOnce(new Error("searx fail"));
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "nothing" },
-        123,
-      );
-
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toBe('No results for "nothing".');
-    });
-
-    it("returns 'no results' when both return non-ok", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const mockFetch = vi
-        .fn()
-        .mockResolvedValueOnce(mockResponse({ ok: false, status: 500 }))
-        .mockResolvedValueOnce(mockResponse({ ok: false, status: 503 }));
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "failing" },
-        123,
-      );
-
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toBe('No results for "failing".');
-    });
-
-    it("returns 'no results' when Brave returns empty results array", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const mockFetch = vi
-        .fn()
-        .mockResolvedValueOnce(
-          mockResponse({ ok: true, json: { web: { results: [] } } }),
-        )
-        .mockResolvedValueOnce(
-          mockResponse({ ok: true, json: { results: [] } }),
-        );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "empty" },
-        123,
-      );
-
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toBe('No results for "empty".');
-    });
-
-    it("handles Brave response with missing web field", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const mockFetch = vi
-        .fn()
-        .mockResolvedValueOnce(mockResponse({ ok: true, json: {} })) // no web field
-        .mockResolvedValueOnce(
-          mockResponse({
-            ok: true,
-            json: {
-              results: [
-                { title: "FallbackR", url: "https://f.com", content: "fb" },
-              ],
-            },
-          }),
-        );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "test" },
-        123,
-      );
-      expect(result?.text).toContain("via SearXNG");
-    });
-
-    it("truncates long snippets to 200 chars", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const longDesc = "A".repeat(500);
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            web: {
-              results: [
-                { title: "Long", url: "https://l.com", description: longDesc },
-              ],
-            },
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "long" },
-        123,
-      );
-      // The snippet should be sliced to 200 chars
-      expect(result?.text).not.toContain("A".repeat(201));
-      expect(result?.text).toContain("A".repeat(200));
-    });
-
-    it("handles missing description in Brave results", async () => {
-      process.env.TALON_BRAVE_API_KEY = "test-key";
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            web: { results: [{ title: "NoDesc", url: "https://nd.com" }] },
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "nodesc" },
-        123,
-      );
-      expect(result?.ok).toBe(true);
-      expect(result?.text).toContain("NoDesc");
-    });
-
-    it("slices SearXNG results to limit", async () => {
-      const mockFetch = vi.fn().mockResolvedValueOnce(
-        mockResponse({
-          ok: true,
-          json: {
-            results: Array.from({ length: 20 }, (_, i) => ({
-              title: `R${i}`,
-              url: `https://r${i}.com`,
-              content: `c${i}`,
-            })),
-          },
-        }),
-      );
-      vi.stubGlobal("fetch", mockFetch);
-
-      const result = await handleSharedAction(
-        { action: "web_search", query: "many", limit: 3 },
-        123,
-      );
-      // Should only contain 3 results (numbered 1-3)
-      expect(result?.text).toContain("1. R0");
-      expect(result?.text).toContain("3. R2");
-      expect(result?.text).not.toContain("4. R3");
-    });
-  });
-
   // ════════════════════════════════════════════════════════════════════════
   // fetch_url
   // ════════════════════════════════════════════════════════════════════════
@@ -2082,14 +1708,13 @@ describe("gateway shared actions", () => {
   });
 });
 
-// ── Additional branch coverage for fetch_url and web_search ──────────────
+// ── Additional branch coverage for fetch_url ──────────────────────────────
 
 describe("gateway-actions — additional branch coverage", () => {
   let originalFetch: typeof globalThis.fetch;
 
   beforeEach(() => {
     originalFetch = globalThis.fetch;
-    delete process.env.TALON_BRAVE_API_KEY;
   });
 
   afterEach(() => {
@@ -2144,51 +1769,4 @@ describe("gateway-actions — additional branch coverage", () => {
     // Should succeed (downloaded as bin), covering ct ?? "" right side and ct.split("/")[1] ?? "file" right side
     expect(result?.ok).toBe(true);
   });
-
-  it("handles search result with missing content field (line 113 r.content ?? '' branch)", async () => {
-    const mockFetch = vi.fn().mockResolvedValueOnce({
-      ok: true,
-      status: 200,
-      headers: new Headers(),
-      json: async () => ({
-        results: [
-          { title: "Result", url: "https://example.com", content: undefined },
-        ],
-      }),
-      text: async () => "",
-      arrayBuffer: async () => new ArrayBuffer(0),
-    } as unknown as Response);
-    vi.stubGlobal("fetch", mockFetch);
-    process.env.TALON_SEARXNG_URL = "http://localhost:8080";
-
-    const result = await handleSharedAction(
-      { action: "web_search", query: "test" },
-      123,
-    );
-    expect(result?.ok).toBe(true);
-    // snippet should be "" (from ?? "")
-    expect(result?.text).toBeDefined();
-  });
-
-  it("handles search response with no results array (line 113 data.results ?? [] branch)", async () => {
-    const mockFetch = vi.fn().mockResolvedValueOnce({
-      ok: true,
-      status: 200,
-      headers: new Headers(),
-      json: async () => ({
-        /* no results property */
-      }),
-      text: async () => "",
-      arrayBuffer: async () => new ArrayBuffer(0),
-    } as unknown as Response);
-    vi.stubGlobal("fetch", mockFetch);
-    process.env.TALON_SEARXNG_URL = "http://localhost:8080";
-
-    const result = await handleSharedAction(
-      { action: "web_search", query: "empty" },
-      123,
-    );
-    expect(result?.ok).toBe(true);
-    expect(result?.text).toContain("No results for");
-  });
 });

package/src/__tests__/gateway-retry.test.ts

@@ -244,10 +244,8 @@ describe("withRetry", () => {
 
   describe("exhausting all retries", () => {
     it("throws the last error after 3 total attempts for retryable errors", async () => {
-      let calls = 0;
       const networkErr = talonErr("network");
       const fn = vi.fn(async () => {
-        calls++;
         throw networkErr;
       });
 
@@ -257,9 +255,7 @@ describe("withRetry", () => {
     });
 
     it("throws the last error after 3 total attempts for overloaded errors", async () => {
-      let calls = 0;
       const fn = vi.fn(async () => {
-        calls++;
         throw talonErr("overloaded");
       });
 

package/src/__tests__/handlers.test.ts

@@ -533,8 +533,6 @@ describe("handleTextMessage — integration via mock Context", () => {
 });
 
 describe("handlePhotoMessage — downloads and enqueues photo", () => {
-  let restoreFetch: () => void;
-
   beforeEach(() => {
     // Mock bot.api.getFile for file download
     mockBot.api.getFile = vi.fn(async () => ({ file_path: "photos/test.jpg" }));
@@ -547,7 +545,6 @@ describe("handlePhotoMessage — downloads and enqueues photo", () => {
       headers: { get: (_name: string) => null },
       arrayBuffer: async () => jpegBuf.buffer,
     }));
-    restoreFetch = () => {};
     vi.stubGlobal("fetch", mockFetch);
 
     executeMock.mockResolvedValue({
@@ -795,7 +792,6 @@ describe("rate limiting — isUserRateLimited via handleTextMessage", () => {
     }
 
     // 16th message should be rate limited (return early without enqueuing)
-    const before = executeMock.mock.calls.length;
     await handleTextMessage(makeCtx(15), mockBot, mockConfig);
 
     // Wait to confirm no debounce fires for the 16th chat

package/src/__tests__/heartbeat.test.ts

@@ -197,6 +197,7 @@ describe("forceHeartbeat", () => {
 
     // Make agent throw
     queryMock.mockImplementationOnce(async function* () {
+      yield; // satisfy require-yield
       throw new Error("Agent exploded");
     });
 
@@ -217,6 +218,7 @@ describe("forceHeartbeat", () => {
     existsSyncMock.mockReturnValue(false);
 
     queryMock.mockImplementationOnce(async function* () {
+      yield; // satisfy require-yield
       throw new Error("Boom");
     });
 
@@ -340,6 +342,7 @@ describe("awaitCurrentRun", () => {
     });
 
     queryMock.mockImplementationOnce(async function* () {
+      yield; // satisfy require-yield
       await agentPromise;
     });