talon-agent 1.0.0 → 1.2.0

package/src/core/gateway-actions.ts

@@ -57,19 +57,35 @@ export async function handleSharedAction(
 
     case "search_history": {
       const limit = Math.min(100, Number(body.limit ?? 20));
-      return { ok: true, text: searchHistory(String(chatId), String(body.query ?? ""), limit) };
+      return {
+        ok: true,
+        text: searchHistory(String(chatId), String(body.query ?? ""), limit),
+      };
     }
 
     case "get_user_messages": {
       const limit = Math.min(50, Number(body.limit ?? 20));
-      return { ok: true, text: getMessagesByUser(String(chatId), String(body.user_name ?? ""), limit) };
+      return {
+        ok: true,
+        text: getMessagesByUser(
+          String(chatId),
+          String(body.user_name ?? ""),
+          limit,
+        ),
+      };
     }
 
     case "list_known_users":
       return { ok: true, text: getKnownUsers(String(chatId)) };
 
     case "list_media":
-      return { ok: true, text: formatMediaIndex(String(chatId), Math.min(20, Number(body.limit ?? 10))) };
+      return {
+        ok: true,
+        text: formatMediaIndex(
+          String(chatId),
+          Math.min(20, Number(body.limit ?? 10)),
+        ),
+      };
 
     // ── Web search (SearXNG) ────────────────────────────────────────────
 
@@ -91,14 +107,34 @@ export async function handleSharedAction(
         try {
           const resp = await fetch(
             `https://api.search.brave.com/res/v1/web/search?q=${encodeURIComponent(query)}&count=${limit}`,
-            { signal: AbortSignal.timeout(8_000), headers: { "X-Subscription-Token": braveKey, Accept: "application/json" } },
+            {
+              signal: AbortSignal.timeout(8_000),
+              headers: {
+                "X-Subscription-Token": braveKey,
+                Accept: "application/json",
+              },
+            },
           );
           if (resp.ok) {
-            const data = await resp.json() as { web?: { results?: Array<{ title: string; url: string; description: string }> } };
-            results = (data.web?.results ?? []).map((r) => ({ title: r.title, url: r.url, snippet: r.description ?? "" }));
+            const data = (await resp.json()) as {
+              web?: {
+                results?: Array<{
+                  title: string;
+                  url: string;
+                  description: string;
+                }>;
+              };
+            };
+            results = (data.web?.results ?? []).map((r) => ({
+              title: r.title,
+              url: r.url,
+              snippet: r.description ?? "",
+            }));
             provider = "Brave";
           }
-        } catch { /* fall through to SearXNG */ }
+        } catch {
+          /* fall through to SearXNG */
+        }
       }
 
       // SearXNG fallback
@@ -109,18 +145,33 @@ export async function handleSharedAction(
             { signal: AbortSignal.timeout(10_000) },
           );
           if (resp.ok) {
-            const data = await resp.json() as { results?: Array<{ title: string; url: string; content: string }> };
-            results = (data.results ?? []).slice(0, limit).map((r) => ({ title: r.title, url: r.url, snippet: r.content ?? "" }));
+            const data = (await resp.json()) as {
+              results?: Array<{ title: string; url: string; content: string }>;
+            };
+            results = (data.results ?? []).slice(0, limit).map((r) => ({
+              title: r.title,
+              url: r.url,
+              snippet: r.content ?? "",
+            }));
             provider = "SearXNG";
           }
-        } catch { /* both failed */ }
+        } catch {
+          /* both failed */
+        }
       }
 
-      if (results.length === 0) return { ok: true, text: `No results for "${query}".` };
-      const formatted = results.map((r, i) =>
-        `${i + 1}. ${r.title}\n   ${r.url}\n   ${r.snippet.slice(0, 200)}`
-      ).join("\n\n");
-      return { ok: true, text: `Search results for "${query}" (via ${provider}):\n\n${formatted}` };
+      if (results.length === 0)
+        return { ok: true, text: `No results for "${query}".` };
+      const formatted = results
+        .map(
+          (r, i) =>
+            `${i + 1}. ${r.title}\n   ${r.url}\n   ${r.snippet.slice(0, 200)}`,
+        )
+        .join("\n\n");
+      return {
+        ok: true,
+        text: `Search results for "${query}" (via ${provider}):\n\n${formatted}`,
+      };
     }
 
     // ── Web fetch ────────────────────────────────────────────────────────
@@ -145,46 +196,92 @@ export async function handleSharedAction(
         if (!resp.ok) return { ok: false, error: `HTTP ${resp.status}` };
         const ct = resp.headers.get("content-type") ?? "";
 
+        // Reject oversized responses before downloading the body.
+        // The Content-Length header is advisory but saves bandwidth when present.
+        const MAX_BYTES = 20 * 1024 * 1024; // 20 MB
+        const contentLength = resp.headers.get("content-length");
+        if (contentLength && Number(contentLength) > MAX_BYTES) {
+          return {
+            ok: false,
+            error: `File too large (${(Number(contentLength) / 1024 / 1024).toFixed(0)}MB, max 20MB)`,
+          };
+        }
+
         // Binary content: download and save to workspace
         const mimeType = ct.split(";")[0].trim().toLowerCase();
-        const isText = mimeType.startsWith("text/") || mimeType === "application/json";
+        const isText =
+          mimeType.startsWith("text/") || mimeType === "application/json";
         if (!isText) {
           const buffer = Buffer.from(await resp.arrayBuffer());
-          if (buffer.length > 20 * 1024 * 1024) return { ok: false, error: "File too large (max 20MB)" };
-          if (buffer.length === 0) return { ok: false, error: "Empty response (0 bytes)" };
+          if (buffer.length > MAX_BYTES)
+            return { ok: false, error: "File too large (max 20MB)" };
+          if (buffer.length === 0)
+            return { ok: false, error: "Empty response (0 bytes)" };
 
           // Validate magic bytes — prevent saving HTML error pages as images
           // (servers can return error pages with image content-type headers)
           const magic = buffer.subarray(0, 16);
           const isRealImage =
-            (magic[0] === 0xFF && magic[1] === 0xD8) || // JPEG
-            (magic[0] === 0x89 && magic[1] === 0x50 && magic[2] === 0x4E && magic[3] === 0x47) || // PNG
+            (magic[0] === 0xff && magic[1] === 0xd8) || // JPEG
+            (magic[0] === 0x89 &&
+              magic[1] === 0x50 &&
+              magic[2] === 0x4e &&
+              magic[3] === 0x47) || // PNG
             (magic[0] === 0x47 && magic[1] === 0x49 && magic[2] === 0x46) || // GIF
-            (magic[0] === 0x52 && magic[1] === 0x49 && magic[2] === 0x46 && magic[3] === 0x46 &&
-             magic[8] === 0x57 && magic[9] === 0x45 && magic[10] === 0x42 && magic[11] === 0x50); // WebP
+            (magic[0] === 0x52 &&
+              magic[1] === 0x49 &&
+              magic[2] === 0x46 &&
+              magic[3] === 0x46 &&
+              magic[8] === 0x57 &&
+              magic[9] === 0x45 &&
+              magic[10] === 0x42 &&
+              magic[11] === 0x50); // WebP
 
           // If content-type says image but bytes say otherwise, treat as text
           if (ct.startsWith("image/") && !isRealImage) {
             const text = extractText(buffer.toString("utf-8"), 500);
-            return { ok: false, error: `Server returned an error page instead of an image. Content: ${text}` };
+            return {
+              ok: false,
+              error: `Server returned an error page instead of an image. Content: ${text}`,
+            };
           }
 
           const ext = isRealImage
-            ? ((magic[0] === 0xFF) ? "jpg" : (magic[0] === 0x89) ? "png" : (magic[0] === 0x47) ? "gif" : "webp")
-            : ct.includes("pdf") ? "pdf" : ct.includes("zip") ? "zip" : "bin";
+            ? magic[0] === 0xff
+              ? "jpg"
+              : magic[0] === 0x89
+                ? "png"
+                : magic[0] === 0x47
+                  ? "gif"
+                  : "webp"
+            : ct.includes("pdf")
+              ? "pdf"
+              : ct.includes("zip")
+                ? "zip"
+                : "bin";
           const uploadsDir = dirs.uploads;
-          if (!existsSync(uploadsDir)) mkdirSync(uploadsDir, { recursive: true });
+          if (!existsSync(uploadsDir))
+            mkdirSync(uploadsDir, { recursive: true });
           const filePath = resolve(uploadsDir, `${Date.now()}-fetched.${ext}`);
           writeFileSync(filePath, buffer);
-          const typeLabel = isRealImage ? "image" : ct.split("/")[1]?.split(";")[0] ?? "file";
-          return { ok: true, text: `Downloaded ${typeLabel} (${(buffer.length / 1024).toFixed(0)}KB) to: ${filePath}\nRead it with the Read tool or send it with send(type="file", file_path="${filePath}").` };
+          const typeLabel = isRealImage
+            ? "image"
+            : (ct.split("/")[1]?.split(";")[0] ?? "file");
+          return {
+            ok: true,
+            text: `Downloaded ${typeLabel} (${(buffer.length / 1024).toFixed(0)}KB) to: ${filePath}\nRead it with the Read tool or send it with send(type="file", file_path="${filePath}").`,
+          };
         }
         const raw = await resp.text();
         const text = extractText(raw);
-        if (text.length < 20) return { ok: true, text: "(Page has no readable content)" };
+        if (text.length < 20)
+          return { ok: true, text: "(Page has no readable content)" };
         return { ok: true, text };
       } catch (err) {
-        return { ok: false, error: `Fetch failed: ${err instanceof Error ? err.message : err}` };
+        return {
+          ok: false,
+          error: `Fetch failed: ${err instanceof Error ? err.message : err}`,
+        };
       }
     }
 
@@ -199,33 +296,62 @@ export async function handleSharedAction(
 
       if (!schedule) return { ok: false, error: "Missing schedule expression" };
       if (!content) return { ok: false, error: "Missing content" };
-      if (content.length > 10_000) return { ok: false, error: "Content too long (max 10,000 chars)" };
+      if (content.length > 10_000)
+        return { ok: false, error: "Content too long (max 10,000 chars)" };
 
       const validation = validateCronExpression(schedule, timezone);
-      if (!validation.valid) return { ok: false, error: `Invalid cron expression: ${validation.error}` };
+      if (!validation.valid)
+        return {
+          ok: false,
+          error: `Invalid cron expression: ${validation.error}`,
+        };
 
       const id = generateCronId();
-      addCronJob({ id, chatId: String(chatId), schedule, type: jobType, content, name, enabled: true, createdAt: Date.now(), runCount: 0, timezone });
+      addCronJob({
+        id,
+        chatId: String(chatId),
+        schedule,
+        type: jobType,
+        content,
+        name,
+        enabled: true,
+        createdAt: Date.now(),
+        runCount: 0,
+        timezone,
+      });
       log("gateway", `create_cron_job: "${name}" [${schedule}]`);
-      return { ok: true, text: `Created cron job "${name}" (id: ${id})\nSchedule: ${schedule}\nType: ${jobType}\nNext run: ${validation.next ?? "unknown"}` };
+      return {
+        ok: true,
+        text: `Created cron job "${name}" (id: ${id})\nSchedule: ${schedule}\nType: ${jobType}\nNext run: ${validation.next ?? "unknown"}`,
+      };
     }
 
     case "list_cron_jobs": {
       const jobs = getCronJobsForChat(String(chatId));
-      if (jobs.length === 0) return { ok: true, text: "No cron jobs in this chat." };
+      if (jobs.length === 0)
+        return { ok: true, text: "No cron jobs in this chat." };
       const lines = jobs.map((j) => {
         const status = j.enabled ? "enabled" : "disabled";
-        const lastRun = j.lastRunAt ? new Date(j.lastRunAt).toISOString().slice(0, 16).replace("T", " ") : "never";
+        const lastRun = j.lastRunAt
+          ? new Date(j.lastRunAt).toISOString().slice(0, 16).replace("T", " ")
+          : "never";
         const v = validateCronExpression(j.schedule, j.timezone);
-        const nextRun = v.next ? new Date(v.next).toISOString().slice(0, 16).replace("T", " ") : "unknown";
+        const nextRun = v.next
+          ? new Date(v.next).toISOString().slice(0, 16).replace("T", " ")
+          : "unknown";
         return [
-          `- ${j.name} (${status})`, `  ID: ${j.id}`,
+          `- ${j.name} (${status})`,
+          `  ID: ${j.id}`,
           `  Schedule: ${j.schedule}${j.timezone ? ` (${j.timezone})` : ""}`,
-          `  Type: ${j.type}`, `  Content: ${j.content.slice(0, 100)}${j.content.length > 100 ? "..." : ""}`,
+          `  Type: ${j.type}`,
+          `  Content: ${j.content.slice(0, 100)}${j.content.length > 100 ? "..." : ""}`,
           `  Runs: ${j.runCount} | Last: ${lastRun} | Next: ${nextRun}`,
         ].join("\n");
       });
-      return { ok: true, text: `Cron jobs (${jobs.length}):\n\n${lines.join("\n\n")}` };
+      return {
+        ok: true,
+        text: `Cron jobs (${jobs.length}):\n\n${lines.join("\n\n")}`,
+      };
     }
 
     case "edit_cron_job": {
@@ -233,22 +359,31 @@ export async function handleSharedAction(
       if (!jobId) return { ok: false, error: "Missing job_id" };
       const job = getCronJob(jobId);
       if (!job) return { ok: false, error: `Job ${jobId} not found` };
-      if (job.chatId !== String(chatId)) return { ok: false, error: "Job belongs to a different chat" };
+      if (job.chatId !== String(chatId))
+        return { ok: false, error: "Job belongs to a different chat" };
 
       const updates: Record<string, unknown> = {};
       if (body.name !== undefined) updates.name = String(body.name);
       if (body.content !== undefined) updates.content = String(body.content);
       if (body.enabled !== undefined) updates.enabled = Boolean(body.enabled);
       if (body.type !== undefined) updates.type = String(body.type);
-      if (body.timezone !== undefined) updates.timezone = body.timezone ? String(body.timezone) : undefined;
+      if (body.timezone !== undefined)
+        updates.timezone = body.timezone ? String(body.timezone) : undefined;
       if (body.schedule !== undefined) {
-        const v = validateCronExpression(String(body.schedule), (updates.timezone as string | undefined) ?? job.timezone);
-        if (!v.valid) return { ok: false, error: `Invalid cron expression: ${v.error}` };
+        const v = validateCronExpression(
+          String(body.schedule),
+          (updates.timezone as string | undefined) ?? job.timezone,
+        );
+        if (!v.valid)
+          return { ok: false, error: `Invalid cron expression: ${v.error}` };
         updates.schedule = String(body.schedule);
       }
 
       const updated = updateCronJob(jobId, updates);
-      return { ok: true, text: `Updated job "${updated?.name ?? jobId}". Fields changed: ${Object.keys(updates).join(", ")}` };
+      return {
+        ok: true,
+        text: `Updated job "${updated?.name ?? jobId}". Fields changed: ${Object.keys(updates).join(", ")}`,
+      };
     }
 
     case "delete_cron_job": {
@@ -256,7 +391,8 @@ export async function handleSharedAction(
       if (!jobId) return { ok: false, error: "Missing job_id" };
       const job = getCronJob(jobId);
       if (!job) return { ok: false, error: `Job ${jobId} not found` };
-      if (job.chatId !== String(chatId)) return { ok: false, error: "Job belongs to a different chat" };
+      if (job.chatId !== String(chatId))
+        return { ok: false, error: "Job belongs to a different chat" };
       deleteCronJob(jobId);
       return { ok: true, text: `Deleted cron job "${job.name}" (${jobId})` };
     }

package/src/core/gateway.ts

@@ -13,6 +13,7 @@ import {
   type IncomingMessage,
   type ServerResponse,
 } from "node:http";
+import pRetry, { AbortError } from "p-retry";
 import { classify } from "./errors.js";
 import { getActiveCount } from "./dispatcher.js";
 import { getHealthStatus } from "../util/watchdog.js";
@@ -24,27 +25,51 @@ import type { FrontendActionHandler } from "./types.js";
 
 // ── Per-chat context state ───────────────────────────────────────────────────
 
-type ChatContext = { refCount: number; messagesSent: number; stringId?: string };
+type ChatContext = {
+  refCount: number;
+  messagesSent: number;
+  stringId?: string;
+};
 
 // ── Retry helper (stateless — standalone export) ─────────────────────────────
 
+/**
+ * Retry a function up to 3 times with classified error inspection.
+ * Non-retryable errors (auth, bad_request, context_length) are thrown immediately.
+ * Uses p-retry for proper exponential backoff with jitter.
+ */
 export async function withRetry<T>(fn: () => Promise<T>): Promise<T> {
-  let lastError: unknown;
-  for (let attempt = 0; attempt < 3; attempt++) {
-    try {
-      return await fn();
-    } catch (err) {
-      lastError = err;
-      const classified = classify(err);
-      if (!classified.retryable) throw err;
-      if (attempt < 2) {
-        const delayMs = classified.retryAfterMs ?? 1000 * Math.pow(2, attempt);
-        log("gateway", `Retry ${attempt + 1}/3 (${classified.reason}) after ${delayMs}ms`);
-        await new Promise((r) => setTimeout(r, delayMs));
+  return pRetry(
+    async (attempt) => {
+      try {
+        return await fn();
+      } catch (err) {
+        const classified = classify(err);
+        if (!classified.retryable) {
+          // Wrap in AbortError to prevent further retries
+          throw new AbortError(classified);
+        }
+        const delayMs =
+          classified.retryAfterMs ?? 1000 * Math.pow(2, attempt - 1);
+        log(
+          "gateway",
+          `Retry ${attempt}/3 (${classified.reason}) after ${delayMs}ms`,
+        );
+        throw classified; // rethrow to trigger p-retry delay
       }
-    }
-  }
-  throw lastError;
+    },
+    {
+      retries: 2, // 3 total attempts
+      minTimeout: 1000,
+      maxTimeout: 60_000,
+      factor: 2,
+      onFailedAttempt: (err) => {
+        if (err.retriesLeft === 0) {
+          logError("gateway", `All retries exhausted: ${err.error.message}`);
+        }
+      },
+    },
+  );
 }
 
 // ── Gateway class ────────────────────────────────────────────────────────────
@@ -57,7 +82,7 @@ export class Gateway {
 
   // ── Frontend handler registration ────────────────────────────────────────
 
-  setFrontendHandler(handler: FrontendActionHandler): void {
+  setFrontendHandler(handler: FrontendActionHandler | null): void {
     this.frontendHandler = handler;
   }
 
@@ -67,10 +92,16 @@ export class Gateway {
     const ctx = this.chatContexts.get(chatId);
     if (ctx) {
       ctx.refCount++;
-      log("gateway", `Context ref++ for chat ${chatId} (refCount=${ctx.refCount})`);
+      log(
+        "gateway",
+        `Context ref++ for chat ${chatId} (refCount=${ctx.refCount})`,
+      );
     } else {
       this.chatContexts.set(chatId, { refCount: 1, messagesSent: 0, stringId });
-      log("gateway", `Context acquired for chat ${chatId}${stringId ? ` (${stringId})` : ""}`);
+      log(
+        "gateway",
+        `Context acquired for chat ${chatId}${stringId ? ` (${stringId})` : ""}`,
+      );
     }
   }
 
@@ -87,7 +118,9 @@ export class Gateway {
     if (chatId === undefined) return;
     const parsed = typeof chatId === "number" ? chatId : Number(chatId);
     // For non-numeric IDs (e.g. Teams "19:abc..."), Number() returns NaN — look up by string
-    const numId = !isNaN(parsed) ? parsed : this.findContextByStringId(String(chatId));
+    const numId = !isNaN(parsed)
+      ? parsed
+      : this.findContextByStringId(String(chatId));
     if (numId === null) return;
     const ctx = this.chatContexts.get(numId);
     if (!ctx) return;
@@ -128,9 +161,10 @@ export class Gateway {
     // then fall back to searching active contexts.
     const rawChatId = body._chatId ? String(body._chatId) : "";
     const numericId = Number(rawChatId);
-    const chatId = !isNaN(numericId) && this.chatContexts.has(numericId)
-      ? numericId
-      : this.findContextByStringId(rawChatId);
+    const chatId =
+      !isNaN(numericId) && this.chatContexts.has(numericId)
+        ? numericId
+        : this.findContextByStringId(rawChatId);
     if (!chatId) {
       return { ok: false, error: "No active chat context" };
     }
@@ -153,14 +187,20 @@ export class Gateway {
       // Try plugin actions (loaded from external plugin packages)
       const pluginResult = await handlePluginAction(body, String(chatId));
       if (pluginResult) {
-        logDebug("gateway", `${action} chat=${chatId} ${Date.now() - t0}ms (plugin)`);
+        logDebug(
+          "gateway",
+          `${action} chat=${chatId} ${Date.now() - t0}ms (plugin)`,
+        );
         return pluginResult;
       }
 
       // Shared actions last — provides in-memory fallbacks for history, cron, etc.
       const shared = await handleSharedAction(body, chatId);
       if (shared) {
-        logDebug("gateway", `${action} chat=${chatId} ${Date.now() - t0}ms (shared)`);
+        logDebug(
+          "gateway",
+          `${action} chat=${chatId} ${Date.now() - t0}ms (shared)`,
+        );
         return shared;
       }
 
@@ -182,19 +222,22 @@ export class Gateway {
         if (req.method === "GET" && req.url === "/health") {
           const w = getHealthStatus();
           res.writeHead(200, { "Content-Type": "application/json" });
-          res.end(JSON.stringify({
-            ok: w.healthy,
-            uptime: Math.round(process.uptime()),
-            memory: Math.round(process.memoryUsage().heapUsed / 1024 / 1024),
-            bridge: { activeChats: this.chatContexts.size },
-            queue: getActiveCount(),
-            sessions: getActiveSessionCount(),
-            messages: w.totalMessagesProcessed,
-            errors: w.recentErrorCount,
-            lastActivity: w.msSinceLastMessage < 60000
-              ? "just now"
-              : `${Math.round(w.msSinceLastMessage / 60000)}m ago`,
-          }));
+          res.end(
+            JSON.stringify({
+              ok: w.healthy,
+              uptime: Math.round(process.uptime()),
+              memory: Math.round(process.memoryUsage().heapUsed / 1024 / 1024),
+              bridge: { activeChats: this.chatContexts.size },
+              queue: getActiveCount(),
+              sessions: getActiveSessionCount(),
+              messages: w.totalMessagesProcessed,
+              errors: w.recentErrorCount,
+              lastActivity:
+                w.msSinceLastMessage < 60000
+                  ? "just now"
+                  : `${Math.round(w.msSinceLastMessage / 60000)}m ago`,
+            }),
+          );
           return;
         }
 
@@ -216,9 +259,11 @@ export class Gateway {
             return;
           }
           const result = await this.handleAction(body);
+          const json = JSON.stringify(result);
           res.writeHead(200, { "Content-Type": "application/json" });
-          res.end(JSON.stringify(result));
+          res.end(json);
         } catch (err) {
+          if (res.headersSent) return;
           const msg = err instanceof Error ? err.message : String(err);
           res.writeHead(500, { "Content-Type": "application/json" });
           res.end(JSON.stringify({ ok: false, error: msg }));
@@ -251,8 +296,15 @@ export class Gateway {
 
   async stop(): Promise<void> {
     return new Promise((resolve) => {
-      if (!this.server) { resolve(); return; }
-      this.server.close(() => { this.server = null; this.port = 0; resolve(); });
+      if (!this.server) {
+        resolve();
+        return;
+      }
+      this.server.close(() => {
+        this.server = null;
+        this.port = 0;
+        resolve();
+      });
     });
   }
 }