takt 0.49.0 → 0.51.0

package/builtins/en/workflows/default-peer-review.yaml

@@ -1,5 +1,5 @@
 name: default-peer-review
-description: default series Phase 2. Parallel reviewers (arch + ai-antipattern-2nd + pure-review + coding-review + supervise) ⇄ fix loop.
+description: default series Phase 2. Specialist parallel reviewers (arch + ai-antipattern-2nd + coding-review) ⇄ fix loop, followed by a parallel merge-readiness/supervise final gate.
 subworkflow:
   callable: true
   visibility: internal
@@ -16,6 +16,7 @@ initial_step: reviewers
 loop_monitors:
   - cycle:
       - reviewers
+      - final-gate
       - fix
     threshold: 3
     judge:
@@ -78,29 +79,6 @@ steps:
           report:
             - name: ai-antipattern-review.md
               format: ai-antipattern-review
-      - name: pure-review
-        tags:
-          - review
-        edit: false
-        persona: pure-reviewer
-        policy: review
-        provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
-        rules:
-          - condition: approved
-          - condition: needs_fix
-        instruction: review-pure
-        output_contracts:
-          report:
-            - name: pure-review.md
-              format: pure-review
       - name: coding-review
         tags:
           - review
@@ -127,37 +105,23 @@ steps:
           report:
             - name: coding-review.md
               format: coding-review
-      - name: supervise
-        tags:
-          - review
-        edit: false
-        persona: supervisor
-        policy: review
-        provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
-        instruction: supervise
-        rules:
-          - condition: All checks passed
-          - condition: Requirements unmet, tests failing, build errors
-        output_contracts:
-          report:
-            - name: supervisor-validation.md
-              format: supervisor-validation
-            - name: summary.md
-              format: summary
-              use_judge: false
     rules:
-      - condition: all("approved", "No AI-specific issues", "approved", "approved", "All checks passed")
+      - condition: all("approved", "No AI-specific issues", "approved")
+        next: final-gate
+      - condition: any("needs_fix", "AI-specific issues found", "needs_fix")
+        next: fix
+  - name: final-gate
+    kind: workflow_call
+    call: merge-readiness-final-gate
+    rules:
+      - condition: COMPLETE
         next: COMPLETE
-      - condition: any("needs_fix", "AI-specific issues found", "needs_fix", "needs_fix", "Requirements unmet, tests failing, build errors")
+      - condition: needs_fix
         next: fix
+      - condition: need_replan
+        return: need_replan
+      - condition: ABORT
+        next: ABORT
   - name: fix
     tags:
       - coding

package/builtins/en/workflows/default.yaml

@@ -1,5 +1,5 @@
 name: default
-description: Test-first development workflow (plan -> write tests -> draft (implement + AI self-review) -> peer-review (3 parallel) -> COMPLETE).
+description: Test-first development workflow (plan -> write tests -> draft (implement + AI self-review) -> peer-review (specialist reviewers + merge-readiness + supervise) -> COMPLETE).
 workflow_config:
   provider_options:
     codex:
@@ -43,6 +43,7 @@ steps:
   - name: write_tests
     tags:
       - coding
+      - test-planning
     edit: true
     persona: coder
     policy:

package/builtins/en/workflows/draft.yaml

@@ -49,7 +49,6 @@ steps:
     policy:
       - coding
       - testing
-    session: refresh
     knowledge:
       $param: impl_knowledge
     provider_options:

package/builtins/en/workflows/dual-cqrs-mini.yaml

@@ -131,6 +131,7 @@ steps:
       - name: supervise
         tags:
           - review
+          - supervise
         edit: false
         persona: dual-supervisor
         policy: review

package/builtins/en/workflows/dual-cqrs.yaml

@@ -23,6 +23,7 @@ loop_monitors:
           next: ai-antipattern-no-fix
   - cycle:
       - reviewers
+      - final-gate
       - fix
     threshold: 3
     judge:
@@ -32,7 +33,7 @@ loop_monitors:
         - condition: Healthy (findings decreasing, fixes applied)
           next: reviewers
         - condition: Unproductive (same findings repeating)
-          next: supervise
+          next: final-gate
 steps:
   - name: plan
     tags:
@@ -317,29 +318,6 @@ steps:
           report:
             - name: ai-antipattern-review.md
               format: ai-antipattern-review
-      - name: pure-review
-        tags:
-          - review
-        edit: false
-        persona: pure-reviewer
-        policy: review
-        provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
-        rules:
-          - condition: approved
-          - condition: needs_fix
-        instruction: review-pure
-        output_contracts:
-          report:
-            - name: pure-review.md
-              format: pure-review
       - name: coding-review
         tags:
           - review
@@ -367,9 +345,34 @@ steps:
           - condition: needs_fix
     rules:
       - condition: all("approved")
-        next: supervise
+        next: final-gate
       - condition: any("needs_fix")
         next: fix
+  - name: final-gate
+    kind: workflow_call
+    call: merge-readiness-dual-final-gate
+    args:
+      merge_readiness_knowledge:
+        - frontend
+        - backend
+        - cqrs-es
+        - security
+        - architecture
+      supervise_knowledge:
+        - frontend
+        - backend
+        - cqrs-es
+        - security
+        - architecture
+    rules:
+      - condition: COMPLETE
+        next: COMPLETE
+      - condition: needs_fix
+        next: fix
+      - condition: need_replan
+        next: plan
+      - condition: ABORT
+        next: ABORT
   - name: fix
     tags:
       - coding
@@ -405,65 +408,3 @@ steps:
       - condition: Cannot proceed, insufficient info
         next: plan
     instruction: fix
-  - name: supervise
-    tags:
-      - review
-    edit: false
-    persona: dual-supervisor
-    policy: review
-    provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - WebSearch
-          - WebFetch
-    instruction: supervise
-    pass_previous_response: false
-    rules:
-      - condition: All validations pass and ready to merge
-        next: COMPLETE
-      - condition: Issues detected during final review
-        next: fix_supervisor
-    output_contracts:
-      report:
-        - name: supervisor-validation.md
-          format: supervisor-validation
-        - name: summary.md
-          format: summary
-          use_judge: false
-  - name: fix_supervisor
-    tags:
-      - coding
-    edit: true
-    persona: coder
-    policy:
-      - coding
-      - testing
-      - design-fidelity
-      - screen-api
-    knowledge:
-      - frontend
-      - backend
-      - cqrs-es
-      - security
-      - architecture
-    provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - Edit
-          - Write
-          - Bash
-          - WebSearch
-          - WebFetch
-    instruction: fix-supervisor
-    pass_previous_response: false
-    rules:
-      - condition: Supervisor's issues have been fixed
-        next: supervise
-      - condition: Unable to proceed with fixes
-        next: plan

package/builtins/en/workflows/dual-for-local-llm.yaml

@@ -0,0 +1,312 @@
+name: dual-for-local-llm
+description: Full-stack development workflow for local LLMs. Five parallel specialist reviewers plus the Finding Contract build discipline for weak models structurally
+finding_contract:
+  ledger_path: .takt/findings/dual-for-local-llm.json
+  raw_findings_path: .takt/findings/dual-for-local-llm/raw
+  manager:
+    persona: findings-manager
+    instruction: findings-manager
+    output_contract: findings-manager
+max_steps: 50
+initial_step: plan
+workflow_config:
+  provider_options:
+    codex:
+      network_access: true
+    opencode:
+      network_access: true
+
+loop_monitors:
+  - cycle:
+      - plan
+      - write_tests
+      - implement
+      - reviewers
+      - fix
+    threshold: 2
+    judge:
+      persona: supervisor
+      instruction: loop-monitor-fix-replan
+      rules:
+        - condition: The latest fix ended with fixes complete (not a dead end)
+          next: reviewers
+        - condition: Healthy (each replan moves the blocker toward resolution)
+          next: plan
+        - condition: Unproductive (the same dead end repeats)
+          next: ABORT
+  - cycle:
+      - reviewers
+      - fix
+    threshold: 3
+    judge:
+      persona: supervisor
+      instruction: loop-monitor-reviewers-fix
+      rules:
+        - condition: converging (findings decreasing, fixes applied)
+          next: reviewers
+        - condition: unproductive (the same findings repeat), but replanning could break the deadlock
+          next: plan
+        - condition: unproductive (the same findings repeat), and replanning is unlikely to help
+          next: ABORT
+  - cycle:
+      - reviewers
+      - final-gate
+      - fix
+    threshold: 3
+    judge:
+      persona: supervisor
+      instruction: loop-monitor-reviewers-fix
+      rules:
+        - condition: converging (findings decreasing, fixes applied)
+          next: reviewers
+        - condition: unproductive (the same findings repeat), but replanning could break the deadlock
+          next: plan
+        - condition: unproductive (the same findings repeat), and replanning is unlikely to help
+          next: ABORT
+
+steps:
+  - name: plan
+    tags:
+      - plan
+    edit: false
+    persona: planner
+    knowledge:
+      - frontend
+      - react
+      - backend
+      - architecture
+    provider_options:
+      extends: review-readonly
+    instruction: plan
+    rules:
+      - condition: Task analysis and planning is complete
+        next: write_tests
+      - condition: The user is asking a question (not an implementation task)
+        next: COMPLETE
+      - condition: Requirements are unclear and planning cannot proceed
+        next: ABORT
+    output_contracts:
+      report:
+        - name: plan.md
+          format: plan-frontend
+
+  - name: write_tests
+    tags:
+      - coding
+      - test-planning
+    edit: true
+    persona: coder
+    policy:
+      - coding
+      - testing
+    knowledge:
+      - frontend
+      - react
+      - backend
+      - architecture
+      - unit-testing
+      - e2e-testing
+      - implementation-semantics
+    provider_options:
+      extends: edit
+    required_permission_mode: edit
+    instruction: write-tests-first
+    rules:
+      - condition: Test creation is complete
+        next: implement
+      - condition: Skipping test creation as target is not yet implemented
+        next: implement
+      - condition: Cannot proceed with test creation
+        next: plan
+      - condition: User input required for clarification
+        next: write_tests
+        requires_user_input: true
+        interactive_only: true
+    output_contracts:
+      report:
+        - name: test-report.md
+          format: test-report
+
+  - name: implement
+    tags:
+      - coding
+    edit: true
+    persona: coder
+    policy:
+      - coding
+    knowledge:
+      - frontend
+      - react
+      - backend
+      - architecture
+      - implementation-semantics
+    provider_options:
+      extends: edit
+    required_permission_mode: edit
+    instruction: implement
+    rules:
+      - condition: Implementation is complete
+        next: reviewers
+      - condition: Cannot proceed with implementation (environment issue or missing information)
+        next: plan
+
+  - name: reviewers
+    tags:
+      - review
+    parallel:
+      - name: arch-review
+        tags:
+          - review
+        edit: false
+        persona: architecture-reviewer
+        policy:
+          - review
+        knowledge:
+          - architecture
+        instruction: review-arch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        output_contracts:
+          report:
+            - name: architect-review.md
+              format: architecture-review-finding-contract
+
+      - name: frontend-review
+        tags:
+          - review
+        edit: false
+        persona: frontend-reviewer
+        policy:
+          - review
+        knowledge:
+          - frontend
+          - react
+        pass_previous_response: false
+        instruction: review-frontend
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        output_contracts:
+          report:
+            - name: frontend-review.md
+              format: frontend-review-finding-contract
+
+      - name: ai-antipattern-review
+        tags:
+          - review
+        edit: false
+        persona: ai-antipattern-reviewer
+        policy:
+          - review
+          - ai-antipattern
+        pass_previous_response: false
+        instruction: ai-antipattern-review
+        rules:
+          - condition: No AI-specific issues
+          - condition: AI-specific issues found
+        output_contracts:
+          report:
+            - name: ai-antipattern-review.md
+              format: ai-antipattern-review-finding-contract
+
+      - name: coding-review
+        tags:
+          - review
+        edit: false
+        persona: coding-reviewer
+        policy:
+          - review
+          - coding
+        pass_previous_response: false
+        instruction: review-coding
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        output_contracts:
+          report:
+            - name: coding-review.md
+              format: coding-review-finding-contract
+
+      - name: implementation-semantics-review
+        tags:
+          - review
+        edit: false
+        persona: implementation-semantics-reviewer
+        policy:
+          - review
+        knowledge:
+          - implementation-semantics
+        pass_previous_response: false
+        instruction: review-implementation-semantics
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        output_contracts:
+          report:
+            - name: implementation-semantics-review.md
+              format: implementation-semantics-review-finding-contract
+    rules:
+      - condition: all("approved", "approved", "No AI-specific issues", "approved", "approved") && when(findings.open.count == 0 && findings.conflicts.count == 0)
+        next: final-gate
+      - condition: any("needs_fix", "needs_fix", "AI-specific issues found", "needs_fix", "needs_fix") && when(findings.conflicts.count == 0)
+        next: fix
+      - condition: when(findings.conflicts.count == 0 && findings.open.count > 0)
+        next: fix
+      - condition: ai("There are unadjudicated findings.conflicts. Choose fix only when a concrete code change by the coder can resolve them. Do not choose it for reviewer disagreements or anything requiring human judgment.")
+        next: fix
+      - condition: when(findings.conflicts.count > 0)
+        next: ABORT
+
+  - name: final-gate
+    tags:
+      - review
+      - final-gate
+    edit: false
+    persona: merge-readiness-reviewer
+    policy: review
+    pass_previous_response: false
+    instruction: review-merge-readiness
+    output_contracts:
+      report:
+        - name: merge-readiness-review.md
+          format: merge-readiness-review-finding-contract
+    rules:
+      - condition: approved && when(findings.open.count == 0 && findings.conflicts.count == 0)
+        next: COMPLETE
+      - condition: needs_fix && when(findings.conflicts.count == 0)
+        next: fix
+      - condition: when(findings.conflicts.count == 0 && findings.open.count > 0)
+        next: fix
+      - condition: ai("There are unadjudicated findings.conflicts. Choose fix only when a concrete code change by the coder can resolve them. Do not choose it for reviewer disagreements or anything requiring human judgment.")
+        next: fix
+      - condition: when(findings.conflicts.count > 0)
+        next: ABORT
+
+  - name: fix
+    tags:
+      - coding
+    edit: true
+    persona: coder
+    policy:
+      - coding
+    knowledge:
+      - frontend
+      - react
+      - backend
+      - architecture
+      - implementation-semantics
+    provider_options:
+      extends: edit
+    required_permission_mode: edit
+    instruction: fix
+    rules:
+      - condition: Fixes are complete
+        next: reviewers
+      - condition: Cannot proceed with fixes, or human judgment is required
+        next: plan
+        appendix: |
+          The fix attempt is stuck. Read the rejection details and the stated
+          blocker, decompose the work again, and replan. Declare planning
+          impossible only if human judgment is genuinely required, with the
+          reasons stated explicitly.

package/builtins/en/workflows/dual-mini.yaml

@@ -129,6 +129,7 @@ steps:
       - name: supervise
         tags:
           - review
+          - supervise
         edit: false
         persona: dual-supervisor
         policy: review