takt 0.49.0 → 0.50.0

package/builtins/en/workflows/merge-readiness-final-gate.yaml

@@ -0,0 +1,79 @@
+name: merge-readiness-final-gate
+description: Parallel final gate that checks merge readiness and supervision independently, then returns the required next action.
+subworkflow:
+  callable: true
+  visibility: internal
+  returns:
+    - needs_fix
+    - need_replan
+  params:
+    supervise_knowledge:
+      type: facet_ref[]
+      facet_kind: knowledge
+      default:
+        - architecture
+workflow_config:
+  provider_options:
+    codex:
+      network_access: true
+    opencode:
+      network_access: true
+max_steps: 5
+initial_step: final_gate
+steps:
+  - name: final_gate
+    tags:
+      - review
+      - final-gate
+    parallel:
+      - name: merge-readiness-review
+        tags:
+          - review
+          - final-gate
+          - merge-readiness
+        edit: false
+        persona: merge-readiness-reviewer
+        policy: review
+        provider_options:
+          extends: review-readonly
+        pass_previous_response: false
+        instruction: review-merge-readiness
+        output_contracts:
+          report:
+            - name: merge-readiness-review.md
+              format: merge-readiness-review
+        rules:
+          - condition: approved
+          - condition: needs_fix
+      - name: supervise
+        tags:
+          - review
+          - final-gate
+          - supervise
+        edit: false
+        persona: supervisor
+        policy: review
+        knowledge:
+          $param: supervise_knowledge
+        provider_options:
+          extends: review-readonly
+        pass_previous_response: false
+        instruction: supervise
+        output_contracts:
+          report:
+            - name: supervisor-validation.md
+              format: supervisor-validation
+            - name: summary.md
+              format: summary
+              use_judge: false
+        rules:
+          - condition: approved
+          - condition: needs_fix
+          - condition: need_replan
+    rules:
+      - condition: all("approved")
+        next: COMPLETE
+      - condition: any("need_replan")
+        return: need_replan
+      - condition: any("needs_fix")
+        return: needs_fix

package/builtins/en/workflows/{peer-review-with-fc.yaml → peer-review-for-local-llm.yaml}

@@ -1,12 +1,5 @@
-name: peer-review-with-fc
-description: Experimental Finding Contract peer review. Six parallel peer reviewers (+ ai-antipattern-review-2nd) ⇄ fix loop.
-finding_contract:
-  ledger_path: .takt/findings/peer-review-with-fc.json
-  raw_findings_path: .takt/findings/peer-review-with-fc/raw
-  manager:
-    persona: findings-manager
-    instruction: findings-manager
-    output_contract: findings-manager
+name: peer-review-for-local-llm
+description: peer-review with an added implementation-semantics reviewer for deeper coverage. Specialist parallel reviewers ⇄ fix loop, followed by a parallel merge-readiness/supervise final gate.
 subworkflow:
   callable: true
   visibility: internal
@@ -19,6 +12,13 @@ subworkflow:
       default:
         - architecture
         - takt
+    fix_knowledge:
+      type: facet_ref[]
+      facet_kind: knowledge
+      default:
+        - takt
+        - architecture
+        - implementation-semantics
 workflow_config:
   provider_options:
     codex:
@@ -30,6 +30,7 @@ initial_step: reviewers
 loop_monitors:
   - cycle:
       - reviewers
+      - final-gate
       - fix
     threshold: 5
     judge:
@@ -62,7 +63,7 @@ steps:
         output_contracts:
           report:
             - name: architect-review.md
-              format: architecture-review-finding-contract
+              format: architecture-review
       - name: security-review
         tags:
           - review
@@ -79,7 +80,7 @@ steps:
         output_contracts:
           report:
             - name: security-review.md
-              format: security-review-finding-contract
+              format: security-review
       - name: qa-review
         tags:
           - review
@@ -97,7 +98,7 @@ steps:
         output_contracts:
           report:
             - name: qa-review.md
-              format: qa-review-finding-contract
+              format: qa-review
       - name: testing-review
         tags:
           - review
@@ -118,42 +119,44 @@ steps:
         output_contracts:
           report:
             - name: testing-review.md
-              format: testing-review-finding-contract
-      - name: pure-review
+              format: testing-review
+      - name: coding-review
         tags:
           - review
         edit: false
-        persona: pure-reviewer
-        policy: review
+        persona: coding-reviewer
+        policy:
+          - review
+          - coding
+        pass_previous_response: false
         provider_options:
           extends: review-readonly
+        instruction: review-coding
         rules:
           - condition: approved
           - condition: needs_fix
-        instruction: review-pure
         output_contracts:
           report:
-            - name: pure-review.md
-              format: pure-review-finding-contract
-      - name: coding-review
+            - name: coding-review.md
+              format: coding-review
+      - name: implementation-semantics-review
         tags:
           - review
         edit: false
-        persona: coding-reviewer
-        policy:
-          - review
-          - coding
+        persona: implementation-semantics-reviewer
+        policy: review
+        knowledge: implementation-semantics
         pass_previous_response: false
         provider_options:
           extends: review-readonly
-        instruction: review-coding
+        instruction: review-implementation-semantics
         rules:
           - condition: approved
           - condition: needs_fix
         output_contracts:
           report:
-            - name: coding-review.md
-              format: coding-review-finding-contract
+            - name: implementation-semantics-review.md
+              format: implementation-semantics-review
       - name: ai-antipattern-review-2nd
         tags:
           - review
@@ -171,18 +174,27 @@ steps:
         output_contracts:
           report:
             - name: ai-antipattern-review.md
-              format: ai-antipattern-review-finding-contract
+              format: ai-antipattern-review
     rules:
-      - condition: all("approved") && findings.open.count == 0 && findings.conflicts.count == 0
-        next: COMPLETE
-      - condition: any("needs_fix") && findings.conflicts.count == 0
+      - condition: all("approved")
+        next: final-gate
+      - condition: any("needs_fix")
         next: fix
-      - condition: findings.conflicts.count == 0 && findings.open.count > 0
-        next: fix
-      - condition: ai("There are unadjudicated findings.conflicts. Choose fix only when a concrete code change by the coder can resolve the conflict. Do not choose it for reviewer disagreement or cases that need human adjudication.")
+  - name: final-gate
+    kind: workflow_call
+    call: merge-readiness-final-gate
+    args:
+      supervise_knowledge:
+        $param: arch_knowledge
+    rules:
+      - condition: COMPLETE
+        next: COMPLETE
+      - condition: needs_fix
         next: fix
-      - condition: findings.conflicts.count > 0
+      - condition: need_replan
         return: need_replan
+      - condition: ABORT
+        next: ABORT
   - name: fix
     tags:
       - coding
@@ -192,8 +204,7 @@ steps:
       - coding
       - testing
     knowledge:
-      - takt
-      - architecture
+      $param: fix_knowledge
     provider_options:
       extends: edit
     required_permission_mode: edit

package/builtins/en/workflows/peer-review.yaml

@@ -1,5 +1,5 @@
 name: peer-review
-description: Six parallel peer reviewers (+ ai-antipattern-review-2nd) ⇄ fix loop.
+description: Specialist parallel peer reviewers (+ ai-antipattern-review-2nd) ⇄ fix loop, followed by a parallel merge-readiness/supervise final gate.
 subworkflow:
   callable: true
   visibility: internal
@@ -12,6 +12,12 @@ subworkflow:
       default:
         - architecture
         - takt
+    fix_knowledge:
+      type: facet_ref[]
+      facet_kind: knowledge
+      default:
+        - takt
+        - architecture
 workflow_config:
   provider_options:
     codex:
@@ -23,6 +29,7 @@ initial_step: reviewers
 loop_monitors:
   - cycle:
       - reviewers
+      - final-gate
       - fix
     threshold: 5
     judge:
@@ -112,22 +119,6 @@ steps:
           report:
             - name: testing-review.md
               format: testing-review
-      - name: pure-review
-        tags:
-          - review
-        edit: false
-        persona: pure-reviewer
-        policy: review
-        provider_options:
-          extends: review-readonly
-        rules:
-          - condition: approved
-          - condition: needs_fix
-        instruction: review-pure
-        output_contracts:
-          report:
-            - name: pure-review.md
-              format: pure-review
       - name: coding-review
         tags:
           - review
@@ -167,9 +158,24 @@ steps:
               format: ai-antipattern-review
     rules:
       - condition: all("approved")
-        next: COMPLETE
+        next: final-gate
       - condition: any("needs_fix")
         next: fix
+  - name: final-gate
+    kind: workflow_call
+    call: merge-readiness-final-gate
+    args:
+      supervise_knowledge:
+        $param: arch_knowledge
+    rules:
+      - condition: COMPLETE
+        next: COMPLETE
+      - condition: needs_fix
+        next: fix
+      - condition: need_replan
+        return: need_replan
+      - condition: ABORT
+        next: ABORT
   - name: fix
     tags:
       - coding
@@ -179,8 +185,7 @@ steps:
       - coding
       - testing
     knowledge:
-      - takt
-      - architecture
+      $param: fix_knowledge
     provider_options:
       extends: edit
     required_permission_mode: edit

package/builtins/en/workflows/research.yaml

@@ -43,6 +43,7 @@ steps:
   - name: supervise
     tags:
       - review
+      - supervise
     persona: research-supervisor
     policy: research
     knowledge: research

package/builtins/en/workflows/review-backend-cqrs.yaml

@@ -140,12 +140,14 @@ steps:
           - condition: approved
           - condition: needs_fix
 
-      - name: pure-review
+      - name: coding-review
         tags:
           - review
         edit: false
-        persona: pure-reviewer
-        policy: review
+        persona: coding-reviewer
+        policy:
+          - review
+          - coding
         provider_options:
           claude:
             allowed_tools:
@@ -155,22 +157,34 @@ steps:
               - Bash
               - WebSearch
               - WebFetch
+        instruction: review-coding
+        output_contracts:
+          report:
+            - name: coding-review.md
+              format: coding-review
         rules:
           - condition: approved
           - condition: needs_fix
-        instruction: review-pure
-        output_contracts:
-          report:
-            - name: pure-review.md
-              format: pure-review
-      - name: coding-review
+
+    rules:
+      - condition: all("approved")
+        next: final-gate
+      - condition: any("needs_fix")
+        next: supervise
+
+  - name: final-gate
+    tags:
+      - review
+      - final-gate
+    parallel:
+      - name: merge-readiness-review
         tags:
           - review
+          - final-gate
+          - merge-readiness
         edit: false
-        persona: coding-reviewer
-        policy:
-          - review
-          - coding
+        persona: merge-readiness-reviewer
+        policy: review
         provider_options:
           claude:
             allowed_tools:
@@ -180,44 +194,58 @@ steps:
               - Bash
               - WebSearch
               - WebFetch
-        instruction: review-coding
+        instruction: review-merge-readiness
         output_contracts:
           report:
-            - name: coding-review.md
-              format: coding-review
+            - name: merge-readiness-review.md
+              format: merge-readiness-review
         rules:
           - condition: approved
           - condition: needs_fix
-
+      - name: review-synthesis
+        tags:
+          - review
+          - final-gate
+          - supervise
+        edit: false
+        persona: supervisor
+        policy: review
+        provider_options: &review_synthesis_provider_options
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - WebSearch
+              - WebFetch
+        pass_previous_response: false
+        instruction: &review_synthesis_instruction supervise
+        output_contracts: &review_synthesis_output_contracts
+          report:
+            - name: supervisor-validation.md
+              format: supervisor-validation
+            - name: summary.md
+              format: summary
+              use_judge: false
+        rules:
+          - condition: approved
     rules:
       - condition: all("approved")
-        next: supervise
+        next: COMPLETE
       - condition: any("needs_fix")
-        next: supervise
+        next: COMPLETE
 
   - name: supervise
     tags:
       - review
+      - supervise
     edit: false
     persona: supervisor
     policy: review
-    provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - WebSearch
-          - WebFetch
+    provider_options: *review_synthesis_provider_options
     pass_previous_response: false
-    instruction: supervise
-    output_contracts:
-      report:
-        - name: supervisor-validation.md
-          format: supervisor-validation
-        - name: summary.md
-          format: summary
-          use_judge: false
+    instruction: *review_synthesis_instruction
+    output_contracts: *review_synthesis_output_contracts
     rules:
       - condition: Review integration complete
         next: COMPLETE

package/builtins/en/workflows/review-backend.yaml

@@ -114,12 +114,14 @@ steps:
           - condition: approved
           - condition: needs_fix
 
-      - name: pure-review
+      - name: coding-review
         tags:
           - review
         edit: false
-        persona: pure-reviewer
-        policy: review
+        persona: coding-reviewer
+        policy:
+          - review
+          - coding
         provider_options:
           claude:
             allowed_tools:
@@ -129,22 +131,34 @@ steps:
               - Bash
               - WebSearch
               - WebFetch
+        instruction: review-coding
+        output_contracts:
+          report:
+            - name: coding-review.md
+              format: coding-review
         rules:
           - condition: approved
           - condition: needs_fix
-        instruction: review-pure
-        output_contracts:
-          report:
-            - name: pure-review.md
-              format: pure-review
-      - name: coding-review
+
+    rules:
+      - condition: all("approved")
+        next: final-gate
+      - condition: any("needs_fix")
+        next: supervise
+
+  - name: final-gate
+    tags:
+      - review
+      - final-gate
+    parallel:
+      - name: merge-readiness-review
         tags:
           - review
+          - final-gate
+          - merge-readiness
         edit: false
-        persona: coding-reviewer
-        policy:
-          - review
-          - coding
+        persona: merge-readiness-reviewer
+        policy: review
         provider_options:
           claude:
             allowed_tools:
@@ -154,44 +168,58 @@ steps:
               - Bash
               - WebSearch
               - WebFetch
-        instruction: review-coding
+        instruction: review-merge-readiness
         output_contracts:
           report:
-            - name: coding-review.md
-              format: coding-review
+            - name: merge-readiness-review.md
+              format: merge-readiness-review
         rules:
           - condition: approved
           - condition: needs_fix
-
+      - name: review-synthesis
+        tags:
+          - review
+          - final-gate
+          - supervise
+        edit: false
+        persona: supervisor
+        policy: review
+        provider_options: &review_synthesis_provider_options
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - WebSearch
+              - WebFetch
+        pass_previous_response: false
+        instruction: &review_synthesis_instruction supervise
+        output_contracts: &review_synthesis_output_contracts
+          report:
+            - name: supervisor-validation.md
+              format: supervisor-validation
+            - name: summary.md
+              format: summary
+              use_judge: false
+        rules:
+          - condition: approved
     rules:
       - condition: all("approved")
-        next: supervise
+        next: COMPLETE
       - condition: any("needs_fix")
-        next: supervise
+        next: COMPLETE
 
   - name: supervise
     tags:
       - review
+      - supervise
     edit: false
     persona: supervisor
     policy: review
-    provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - WebSearch
-          - WebFetch
+    provider_options: *review_synthesis_provider_options
     pass_previous_response: false
-    instruction: supervise
-    output_contracts:
-      report:
-        - name: supervisor-validation.md
-          format: supervisor-validation
-        - name: summary.md
-          format: summary
-          use_judge: false
+    instruction: *review_synthesis_instruction
+    output_contracts: *review_synthesis_output_contracts
     rules:
       - condition: Review integration complete
         next: COMPLETE