takt 0.46.0 → 0.48.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +66 -2
- package/builtins/en/config.yaml +28 -12
- package/builtins/en/facets/instructions/findings-manager.md +13 -0
- package/builtins/en/facets/instructions/fix-maintenance.md +1 -1
- package/builtins/en/facets/instructions/fix.md +9 -4
- package/builtins/en/facets/instructions/implement-maintenance.md +5 -34
- package/builtins/en/facets/instructions/loop-monitor-reviewers-fix.md +5 -1
- package/builtins/en/facets/instructions/plan-maintenance.md +3 -3
- package/builtins/en/facets/instructions/plan-test.md +4 -3
- package/builtins/en/facets/instructions/review-coding.md +13 -6
- package/builtins/en/facets/instructions/review-pure.md +8 -0
- package/builtins/en/facets/instructions/review-qa.md +2 -1
- package/builtins/en/facets/instructions/review-test.md +7 -1
- package/builtins/en/facets/instructions/supervise-maintenance.md +3 -75
- package/builtins/en/facets/instructions/supervise.md +8 -68
- package/builtins/en/facets/instructions/write-tests-first.md +1 -0
- package/builtins/en/facets/knowledge/architecture.md +31 -0
- package/builtins/en/facets/knowledge/backend.md +27 -1
- package/builtins/en/facets/knowledge/cqrs-es.md +69 -0
- package/builtins/en/facets/knowledge/e2e-testing.md +13 -0
- package/builtins/en/facets/knowledge/existing-system.md +2 -2
- package/builtins/en/facets/knowledge/takt.md +11 -0
- package/builtins/en/facets/output-contracts/ai-antipattern-review-finding-contract.md +31 -0
- package/builtins/en/facets/output-contracts/architecture-review-finding-contract.md +35 -0
- package/builtins/en/facets/output-contracts/coding-review-finding-contract.md +25 -0
- package/builtins/en/facets/output-contracts/coding-review.md +11 -4
- package/builtins/en/facets/output-contracts/cqrs-es-review-finding-contract.md +31 -0
- package/builtins/en/facets/output-contracts/findings-manager.md +45 -0
- package/builtins/en/facets/output-contracts/frontend-review-finding-contract.md +30 -0
- package/builtins/en/facets/output-contracts/pure-review-finding-contract.md +45 -0
- package/builtins/en/facets/output-contracts/pure-review.md +6 -6
- package/builtins/en/facets/output-contracts/qa-review-finding-contract.md +35 -0
- package/builtins/en/facets/output-contracts/qa-review.md +10 -3
- package/builtins/en/facets/output-contracts/security-review-finding-contract.md +36 -0
- package/builtins/en/facets/output-contracts/supervisor-validation.md +34 -10
- package/builtins/en/facets/output-contracts/terraform-review-finding-contract.md +31 -0
- package/builtins/en/facets/output-contracts/testing-review-finding-contract.md +41 -0
- package/builtins/en/facets/personas/findings-manager.md +18 -0
- package/builtins/en/facets/policies/ai-antipattern.md +31 -0
- package/builtins/en/facets/policies/existing-system-respect.md +17 -16
- package/builtins/en/facets/policies/review.md +64 -16
- package/builtins/en/facets/policies/testing.md +52 -0
- package/builtins/en/workflow-categories.yaml +2 -0
- package/builtins/en/workflows/audit-architecture-backend.yaml +8 -0
- package/builtins/en/workflows/audit-architecture-dual.yaml +8 -0
- package/builtins/en/workflows/audit-architecture-frontend.yaml +8 -0
- package/builtins/en/workflows/audit-architecture.yaml +8 -0
- package/builtins/en/workflows/audit-e2e.yaml +8 -0
- package/builtins/en/workflows/audit-security.yaml +8 -0
- package/builtins/en/workflows/audit-unit.yaml +8 -0
- package/builtins/en/workflows/auto-improvement-loop.yaml +6 -0
- package/builtins/en/workflows/backend-cqrs-mini.yaml +20 -0
- package/builtins/en/workflows/backend-cqrs.yaml +39 -1
- package/builtins/en/workflows/backend-maintenance.yaml +540 -0
- package/builtins/en/workflows/backend-mini.yaml +20 -0
- package/builtins/en/workflows/backend.yaml +39 -1
- package/builtins/en/workflows/compound-eye.yaml +8 -0
- package/builtins/en/workflows/deep-research.yaml +8 -0
- package/builtins/en/workflows/default-draft.yaml +6 -0
- package/builtins/en/workflows/default-high.yaml +6 -0
- package/builtins/en/workflows/default-mini.yaml +2 -0
- package/builtins/en/workflows/default-peer-review.yaml +17 -1
- package/builtins/en/workflows/default.yaml +4 -0
- package/builtins/en/workflows/draft.yaml +14 -4
- package/builtins/en/workflows/dual-cqrs-mini.yaml +20 -0
- package/builtins/en/workflows/dual-cqrs.yaml +35 -1
- package/builtins/en/workflows/dual-mini.yaml +20 -0
- package/builtins/en/workflows/dual.yaml +39 -1
- package/builtins/en/workflows/frontend-maintenance.yaml +42 -2
- package/builtins/en/workflows/frontend-mini.yaml +20 -0
- package/builtins/en/workflows/frontend.yaml +42 -2
- package/builtins/en/workflows/magi.yaml +6 -0
- package/builtins/en/workflows/peer-review-with-fc.yaml +206 -0
- package/builtins/en/workflows/peer-review.yaml +30 -10
- package/builtins/en/workflows/research.yaml +6 -0
- package/builtins/en/workflows/review-backend-cqrs.yaml +21 -1
- package/builtins/en/workflows/review-backend.yaml +19 -1
- package/builtins/en/workflows/review-default.yaml +21 -1
- package/builtins/en/workflows/review-dual-cqrs.yaml +23 -1
- package/builtins/en/workflows/review-dual.yaml +21 -1
- package/builtins/en/workflows/review-fix-backend-cqrs.yaml +25 -1
- package/builtins/en/workflows/review-fix-backend.yaml +23 -1
- package/builtins/en/workflows/review-fix-default.yaml +25 -1
- package/builtins/en/workflows/review-fix-dual-cqrs.yaml +27 -1
- package/builtins/en/workflows/review-fix-dual.yaml +25 -1
- package/builtins/en/workflows/review-fix-frontend.yaml +25 -1
- package/builtins/en/workflows/review-fix-takt-default.yaml +33 -1
- package/builtins/en/workflows/review-frontend.yaml +21 -1
- package/builtins/en/workflows/review-takt-default.yaml +23 -1
- package/builtins/en/workflows/takt-default-refresh-all.yaml +30 -0
- package/builtins/en/workflows/takt-default-refresh-fast.yaml +30 -0
- package/builtins/en/workflows/takt-default-with-fc.yaml +110 -0
- package/builtins/en/workflows/takt-default.yaml +9 -3
- package/builtins/en/workflows/terraform.yaml +29 -1
- package/builtins/ja/config.yaml +28 -12
- package/builtins/ja/facets/instructions/findings-manager.md +13 -0
- package/builtins/ja/facets/instructions/fix-maintenance.md +1 -1
- package/builtins/ja/facets/instructions/fix.md +9 -4
- package/builtins/ja/facets/instructions/implement-maintenance.md +5 -34
- package/builtins/ja/facets/instructions/loop-monitor-reviewers-fix.md +5 -1
- package/builtins/ja/facets/instructions/plan-maintenance.md +3 -3
- package/builtins/ja/facets/instructions/plan-test.md +4 -3
- package/builtins/ja/facets/instructions/review-coding.md +13 -6
- package/builtins/ja/facets/instructions/review-pure.md +8 -0
- package/builtins/ja/facets/instructions/review-qa.md +2 -1
- package/builtins/ja/facets/instructions/review-test.md +7 -1
- package/builtins/ja/facets/instructions/supervise-maintenance.md +3 -75
- package/builtins/ja/facets/instructions/supervise.md +8 -69
- package/builtins/ja/facets/instructions/write-tests-first.md +1 -0
- package/builtins/ja/facets/knowledge/architecture.md +31 -0
- package/builtins/ja/facets/knowledge/backend.md +27 -1
- package/builtins/ja/facets/knowledge/cqrs-es.md +43 -0
- package/builtins/ja/facets/knowledge/e2e-testing.md +13 -0
- package/builtins/ja/facets/knowledge/existing-system.md +2 -2
- package/builtins/ja/facets/knowledge/takt.md +11 -0
- package/builtins/ja/facets/output-contracts/ai-antipattern-review-finding-contract.md +31 -0
- package/builtins/ja/facets/output-contracts/architecture-review-finding-contract.md +35 -0
- package/builtins/ja/facets/output-contracts/coding-review-finding-contract.md +25 -0
- package/builtins/ja/facets/output-contracts/coding-review.md +11 -4
- package/builtins/ja/facets/output-contracts/cqrs-es-review-finding-contract.md +31 -0
- package/builtins/ja/facets/output-contracts/findings-manager.md +45 -0
- package/builtins/ja/facets/output-contracts/frontend-review-finding-contract.md +30 -0
- package/builtins/ja/facets/output-contracts/pure-review-finding-contract.md +45 -0
- package/builtins/ja/facets/output-contracts/pure-review.md +6 -6
- package/builtins/ja/facets/output-contracts/qa-review-finding-contract.md +35 -0
- package/builtins/ja/facets/output-contracts/qa-review.md +10 -3
- package/builtins/ja/facets/output-contracts/security-review-finding-contract.md +36 -0
- package/builtins/ja/facets/output-contracts/supervisor-validation.md +34 -10
- package/builtins/ja/facets/output-contracts/terraform-review-finding-contract.md +31 -0
- package/builtins/ja/facets/output-contracts/testing-review-finding-contract.md +41 -0
- package/builtins/ja/facets/personas/findings-manager.md +18 -0
- package/builtins/ja/facets/policies/ai-antipattern.md +15 -0
- package/builtins/ja/facets/policies/existing-system-respect.md +17 -16
- package/builtins/ja/facets/policies/review.md +62 -16
- package/builtins/ja/facets/policies/testing.md +52 -0
- package/builtins/ja/workflow-categories.yaml +2 -0
- package/builtins/ja/workflows/audit-architecture-backend.yaml +8 -0
- package/builtins/ja/workflows/audit-architecture-dual.yaml +8 -0
- package/builtins/ja/workflows/audit-architecture-frontend.yaml +8 -0
- package/builtins/ja/workflows/audit-architecture.yaml +8 -0
- package/builtins/ja/workflows/audit-e2e.yaml +8 -0
- package/builtins/ja/workflows/audit-security.yaml +8 -0
- package/builtins/ja/workflows/audit-unit.yaml +8 -0
- package/builtins/ja/workflows/auto-improvement-loop.yaml +6 -0
- package/builtins/ja/workflows/backend-cqrs-mini.yaml +20 -0
- package/builtins/ja/workflows/backend-cqrs.yaml +39 -1
- package/builtins/ja/workflows/backend-maintenance.yaml +540 -0
- package/builtins/ja/workflows/backend-mini.yaml +20 -0
- package/builtins/ja/workflows/backend.yaml +39 -1
- package/builtins/ja/workflows/compound-eye.yaml +8 -0
- package/builtins/ja/workflows/deep-research.yaml +8 -0
- package/builtins/ja/workflows/default-draft.yaml +6 -0
- package/builtins/ja/workflows/default-high.yaml +6 -0
- package/builtins/ja/workflows/default-mini.yaml +2 -0
- package/builtins/ja/workflows/default-peer-review.yaml +17 -1
- package/builtins/ja/workflows/default.yaml +4 -0
- package/builtins/ja/workflows/draft.yaml +14 -4
- package/builtins/ja/workflows/dual-cqrs-mini.yaml +20 -0
- package/builtins/ja/workflows/dual-cqrs.yaml +35 -1
- package/builtins/ja/workflows/dual-mini.yaml +20 -0
- package/builtins/ja/workflows/dual.yaml +39 -1
- package/builtins/ja/workflows/frontend-maintenance.yaml +42 -2
- package/builtins/ja/workflows/frontend-mini.yaml +20 -0
- package/builtins/ja/workflows/frontend.yaml +42 -2
- package/builtins/ja/workflows/magi.yaml +6 -0
- package/builtins/ja/workflows/peer-review-with-fc.yaml +206 -0
- package/builtins/ja/workflows/peer-review.yaml +30 -10
- package/builtins/ja/workflows/research.yaml +6 -0
- package/builtins/ja/workflows/review-backend-cqrs.yaml +21 -1
- package/builtins/ja/workflows/review-backend.yaml +19 -1
- package/builtins/ja/workflows/review-default.yaml +21 -1
- package/builtins/ja/workflows/review-dual-cqrs.yaml +23 -1
- package/builtins/ja/workflows/review-dual.yaml +21 -1
- package/builtins/ja/workflows/review-fix-backend-cqrs.yaml +25 -1
- package/builtins/ja/workflows/review-fix-backend.yaml +23 -1
- package/builtins/ja/workflows/review-fix-default.yaml +25 -1
- package/builtins/ja/workflows/review-fix-dual-cqrs.yaml +27 -1
- package/builtins/ja/workflows/review-fix-dual.yaml +25 -1
- package/builtins/ja/workflows/review-fix-frontend.yaml +25 -1
- package/builtins/ja/workflows/review-fix-takt-default.yaml +33 -1
- package/builtins/ja/workflows/review-frontend.yaml +21 -1
- package/builtins/ja/workflows/review-takt-default.yaml +23 -1
- package/builtins/ja/workflows/takt-default-refresh-all.yaml +30 -0
- package/builtins/ja/workflows/takt-default-refresh-fast.yaml +30 -0
- package/builtins/ja/workflows/takt-default-with-fc.yaml +110 -0
- package/builtins/ja/workflows/takt-default.yaml +9 -3
- package/builtins/ja/workflows/terraform.yaml +29 -1
- package/builtins/skill/references/yaml-schema.md +4 -0
- package/builtins/skill-codex/references/yaml-schema.md +4 -0
- package/dist/agents/decompose-task-usecase.d.ts +3 -1
- package/dist/agents/decompose-task-usecase.d.ts.map +1 -1
- package/dist/agents/decompose-task-usecase.js +2 -2
- package/dist/agents/decompose-task-usecase.js.map +1 -1
- package/dist/agents/runner.js +4 -4
- package/dist/agents/runner.js.map +1 -1
- package/dist/agents/structured-caller/capability-aware-structured-caller.d.ts +2 -2
- package/dist/agents/structured-caller/capability-aware-structured-caller.d.ts.map +1 -1
- package/dist/agents/structured-caller/capability-aware-structured-caller.js.map +1 -1
- package/dist/agents/structured-caller/contracts.d.ts +2 -2
- package/dist/agents/structured-caller/contracts.d.ts.map +1 -1
- package/dist/agents/structured-caller/default-structured-caller.d.ts +2 -2
- package/dist/agents/structured-caller/default-structured-caller.d.ts.map +1 -1
- package/dist/agents/structured-caller/default-structured-caller.js.map +1 -1
- package/dist/agents/structured-caller/prompt-based-structured-caller.d.ts +2 -2
- package/dist/agents/structured-caller/prompt-based-structured-caller.d.ts.map +1 -1
- package/dist/agents/structured-caller/prompt-based-structured-caller.js +2 -2
- package/dist/agents/structured-caller/prompt-based-structured-caller.js.map +1 -1
- package/dist/agents/team-leader-structured-output.d.ts +2 -2
- package/dist/agents/team-leader-structured-output.d.ts.map +1 -1
- package/dist/agents/team-leader-structured-output.js +42 -9
- package/dist/agents/team-leader-structured-output.js.map +1 -1
- package/dist/app/cli/routing-inputs.d.ts +1 -0
- package/dist/app/cli/routing-inputs.d.ts.map +1 -1
- package/dist/app/cli/routing-inputs.js +5 -2
- package/dist/app/cli/routing-inputs.js.map +1 -1
- package/dist/app/cli/routing.d.ts.map +1 -1
- package/dist/app/cli/routing.js +14 -0
- package/dist/app/cli/routing.js.map +1 -1
- package/dist/commands/repertoire/add.d.ts.map +1 -1
- package/dist/commands/repertoire/add.js +47 -7
- package/dist/commands/repertoire/add.js.map +1 -1
- package/dist/commands/repertoire/remove.d.ts.map +1 -1
- package/dist/commands/repertoire/remove.js +19 -3
- package/dist/commands/repertoire/remove.js.map +1 -1
- package/dist/core/models/config-schemas.d.ts +797 -0
- package/dist/core/models/config-schemas.d.ts.map +1 -1
- package/dist/core/models/config-schemas.js +6 -0
- package/dist/core/models/config-schemas.js.map +1 -1
- package/dist/core/models/config-types.d.ts +8 -0
- package/dist/core/models/config-types.d.ts.map +1 -1
- package/dist/core/models/finding-schemas.d.ts +447 -0
- package/dist/core/models/finding-schemas.d.ts.map +1 -0
- package/dist/core/models/finding-schemas.js +234 -0
- package/dist/core/models/finding-schemas.js.map +1 -0
- package/dist/core/models/finding-types.d.ts +146 -0
- package/dist/core/models/finding-types.d.ts.map +1 -0
- package/dist/core/models/finding-types.js +5 -0
- package/dist/core/models/finding-types.js.map +1 -0
- package/dist/core/models/index.d.ts +1 -1
- package/dist/core/models/index.d.ts.map +1 -1
- package/dist/core/models/index.js.map +1 -1
- package/dist/core/models/part.d.ts +7 -0
- package/dist/core/models/part.d.ts.map +1 -1
- package/dist/core/models/schema-base.d.ts +10 -0
- package/dist/core/models/schema-base.d.ts.map +1 -1
- package/dist/core/models/schema-base.js +2 -0
- package/dist/core/models/schema-base.js.map +1 -1
- package/dist/core/models/types.d.ts +2 -2
- package/dist/core/models/types.d.ts.map +1 -1
- package/dist/core/models/workflow-condition-expression.d.ts +3 -0
- package/dist/core/models/workflow-condition-expression.d.ts.map +1 -1
- package/dist/core/models/workflow-condition-expression.js +223 -4
- package/dist/core/models/workflow-condition-expression.js.map +1 -1
- package/dist/core/models/workflow-provider-options.d.ts +2 -0
- package/dist/core/models/workflow-provider-options.d.ts.map +1 -1
- package/dist/core/models/workflow-provider-options.js.map +1 -1
- package/dist/core/models/workflow-schemas.d.ts +124 -36
- package/dist/core/models/workflow-schemas.d.ts.map +1 -1
- package/dist/core/models/workflow-schemas.js +13 -6
- package/dist/core/models/workflow-schemas.js.map +1 -1
- package/dist/core/models/workflow-system-schemas.d.ts.map +1 -1
- package/dist/core/models/workflow-system-schemas.js +1 -0
- package/dist/core/models/workflow-system-schemas.js.map +1 -1
- package/dist/core/models/workflow-types.d.ts +13 -0
- package/dist/core/models/workflow-types.d.ts.map +1 -1
- package/dist/core/models/workflow-types.js.map +1 -1
- package/dist/core/workflow/engine/OptionsBuilder.d.ts +4 -1
- package/dist/core/workflow/engine/OptionsBuilder.d.ts.map +1 -1
- package/dist/core/workflow/engine/OptionsBuilder.js +21 -8
- package/dist/core/workflow/engine/OptionsBuilder.js.map +1 -1
- package/dist/core/workflow/engine/ParallelRunner.d.ts +14 -0
- package/dist/core/workflow/engine/ParallelRunner.d.ts.map +1 -1
- package/dist/core/workflow/engine/ParallelRunner.js +152 -18
- package/dist/core/workflow/engine/ParallelRunner.js.map +1 -1
- package/dist/core/workflow/engine/StepExecutor.d.ts +4 -2
- package/dist/core/workflow/engine/StepExecutor.d.ts.map +1 -1
- package/dist/core/workflow/engine/StepExecutor.js +10 -3
- package/dist/core/workflow/engine/StepExecutor.js.map +1 -1
- package/dist/core/workflow/engine/TeamLeaderRunner.d.ts.map +1 -1
- package/dist/core/workflow/engine/TeamLeaderRunner.js +6 -6
- package/dist/core/workflow/engine/TeamLeaderRunner.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowCallExecutor.d.ts +3 -1
- package/dist/core/workflow/engine/WorkflowCallExecutor.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowCallExecutor.js +23 -5
- package/dist/core/workflow/engine/WorkflowCallExecutor.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowCallRunner.d.ts +1 -0
- package/dist/core/workflow/engine/WorkflowCallRunner.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowCallRunner.js +5 -1
- package/dist/core/workflow/engine/WorkflowCallRunner.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowEngine.d.ts +7 -1
- package/dist/core/workflow/engine/WorkflowEngine.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowEngine.js +63 -9
- package/dist/core/workflow/engine/WorkflowEngine.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowEngineSetup.d.ts +3 -0
- package/dist/core/workflow/engine/WorkflowEngineSetup.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowEngineSetup.js +27 -1
- package/dist/core/workflow/engine/WorkflowEngineSetup.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowRunLoop.d.ts +10 -7
- package/dist/core/workflow/engine/WorkflowRunLoop.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowRunLoop.js +63 -33
- package/dist/core/workflow/engine/WorkflowRunLoop.js.map +1 -1
- package/dist/core/workflow/engine/WorkflowValidator.d.ts.map +1 -1
- package/dist/core/workflow/engine/WorkflowValidator.js +78 -1
- package/dist/core/workflow/engine/WorkflowValidator.js.map +1 -1
- package/dist/core/workflow/engine/engine-provider-options.d.ts +1 -0
- package/dist/core/workflow/engine/engine-provider-options.d.ts.map +1 -1
- package/dist/core/workflow/engine/engine-provider-options.js +27 -0
- package/dist/core/workflow/engine/engine-provider-options.js.map +1 -1
- package/dist/core/workflow/engine/team-leader-common.d.ts +1 -0
- package/dist/core/workflow/engine/team-leader-common.d.ts.map +1 -1
- package/dist/core/workflow/engine/team-leader-common.js +23 -0
- package/dist/core/workflow/engine/team-leader-common.js.map +1 -1
- package/dist/core/workflow/engine/team-leader-part-runner.d.ts.map +1 -1
- package/dist/core/workflow/engine/team-leader-part-runner.js +22 -1
- package/dist/core/workflow/engine/team-leader-part-runner.js.map +1 -1
- package/dist/core/workflow/evaluation/AggregateEvaluator.d.ts.map +1 -1
- package/dist/core/workflow/evaluation/AggregateEvaluator.js +7 -4
- package/dist/core/workflow/evaluation/AggregateEvaluator.js.map +1 -1
- package/dist/core/workflow/evaluation/RuleEvaluator.d.ts +1 -0
- package/dist/core/workflow/evaluation/RuleEvaluator.d.ts.map +1 -1
- package/dist/core/workflow/evaluation/RuleEvaluator.js +15 -1
- package/dist/core/workflow/evaluation/RuleEvaluator.js.map +1 -1
- package/dist/core/workflow/evaluation/rule-utils.d.ts +5 -1
- package/dist/core/workflow/evaluation/rule-utils.d.ts.map +1 -1
- package/dist/core/workflow/evaluation/rule-utils.js +34 -1
- package/dist/core/workflow/evaluation/rule-utils.js.map +1 -1
- package/dist/core/workflow/evaluation/when-evaluator.d.ts.map +1 -1
- package/dist/core/workflow/evaluation/when-evaluator.js +4 -1
- package/dist/core/workflow/evaluation/when-evaluator.js.map +1 -1
- package/dist/core/workflow/findings/context.d.ts +5 -0
- package/dist/core/workflow/findings/context.d.ts.map +1 -0
- package/dist/core/workflow/findings/context.js +82 -0
- package/dist/core/workflow/findings/context.js.map +1 -0
- package/dist/core/workflow/findings/ledger-validation.d.ts +3 -0
- package/dist/core/workflow/findings/ledger-validation.d.ts.map +1 -0
- package/dist/core/workflow/findings/ledger-validation.js +26 -0
- package/dist/core/workflow/findings/ledger-validation.js.map +1 -0
- package/dist/core/workflow/findings/manager-output-validation.d.ts +15 -0
- package/dist/core/workflow/findings/manager-output-validation.d.ts.map +1 -0
- package/dist/core/workflow/findings/manager-output-validation.js +221 -0
- package/dist/core/workflow/findings/manager-output-validation.js.map +1 -0
- package/dist/core/workflow/findings/manager-runner.d.ts +89 -0
- package/dist/core/workflow/findings/manager-runner.d.ts.map +1 -0
- package/dist/core/workflow/findings/manager-runner.js +291 -0
- package/dist/core/workflow/findings/manager-runner.js.map +1 -0
- package/dist/core/workflow/findings/reconciler.d.ts +10 -0
- package/dist/core/workflow/findings/reconciler.d.ts.map +1 -0
- package/dist/core/workflow/findings/reconciler.js +413 -0
- package/dist/core/workflow/findings/reconciler.js.map +1 -0
- package/dist/core/workflow/findings/schemas.d.ts +2 -0
- package/dist/core/workflow/findings/schemas.d.ts.map +1 -0
- package/dist/core/workflow/findings/schemas.js +2 -0
- package/dist/core/workflow/findings/schemas.js.map +1 -0
- package/dist/core/workflow/findings/store.d.ts +33 -0
- package/dist/core/workflow/findings/store.d.ts.map +1 -0
- package/dist/core/workflow/findings/store.js +169 -0
- package/dist/core/workflow/findings/store.js.map +1 -0
- package/dist/core/workflow/findings/types.d.ts +3 -0
- package/dist/core/workflow/findings/types.d.ts.map +1 -0
- package/dist/core/workflow/findings/types.js +2 -0
- package/dist/core/workflow/findings/types.js.map +1 -0
- package/dist/core/workflow/instruction/InstructionBuilder.d.ts +1 -0
- package/dist/core/workflow/instruction/InstructionBuilder.d.ts.map +1 -1
- package/dist/core/workflow/instruction/InstructionBuilder.js +35 -11
- package/dist/core/workflow/instruction/InstructionBuilder.js.map +1 -1
- package/dist/core/workflow/instruction/ReportInstructionBuilder.d.ts +4 -0
- package/dist/core/workflow/instruction/ReportInstructionBuilder.d.ts.map +1 -1
- package/dist/core/workflow/instruction/ReportInstructionBuilder.js +22 -1
- package/dist/core/workflow/instruction/ReportInstructionBuilder.js.map +1 -1
- package/dist/core/workflow/instruction/fenced-json.d.ts +2 -0
- package/dist/core/workflow/instruction/fenced-json.d.ts.map +1 -0
- package/dist/core/workflow/instruction/fenced-json.js +11 -0
- package/dist/core/workflow/instruction/fenced-json.js.map +1 -0
- package/dist/core/workflow/instruction/instruction-context.d.ts +8 -0
- package/dist/core/workflow/instruction/instruction-context.d.ts.map +1 -1
- package/dist/core/workflow/instruction/instruction-context.js.map +1 -1
- package/dist/core/workflow/observability/traceDiscovery.d.ts +33 -0
- package/dist/core/workflow/observability/traceDiscovery.d.ts.map +1 -0
- package/dist/core/workflow/observability/traceDiscovery.js +104 -0
- package/dist/core/workflow/observability/traceDiscovery.js.map +1 -0
- package/dist/core/workflow/observability/workflowSpans.d.ts +5 -2
- package/dist/core/workflow/observability/workflowSpans.d.ts.map +1 -1
- package/dist/core/workflow/observability/workflowSpans.js +35 -5
- package/dist/core/workflow/observability/workflowSpans.js.map +1 -1
- package/dist/core/workflow/phase-runner.d.ts +2 -0
- package/dist/core/workflow/phase-runner.d.ts.map +1 -1
- package/dist/core/workflow/phase-runner.js.map +1 -1
- package/dist/core/workflow/promotion/promotion-runtime.d.ts.map +1 -1
- package/dist/core/workflow/promotion/promotion-runtime.js +3 -2
- package/dist/core/workflow/promotion/promotion-runtime.js.map +1 -1
- package/dist/core/workflow/provider-options-trace.d.ts +3 -2
- package/dist/core/workflow/provider-options-trace.d.ts.map +1 -1
- package/dist/core/workflow/provider-resolution.d.ts +11 -3
- package/dist/core/workflow/provider-resolution.d.ts.map +1 -1
- package/dist/core/workflow/provider-resolution.js +68 -2
- package/dist/core/workflow/provider-resolution.js.map +1 -1
- package/dist/core/workflow/providerOptionsRedaction.d.ts +4 -0
- package/dist/core/workflow/providerOptionsRedaction.d.ts.map +1 -0
- package/dist/core/workflow/providerOptionsRedaction.js +18 -0
- package/dist/core/workflow/providerOptionsRedaction.js.map +1 -0
- package/dist/core/workflow/report-phase-runner.d.ts.map +1 -1
- package/dist/core/workflow/report-phase-runner.js +59 -44
- package/dist/core/workflow/report-phase-runner.js.map +1 -1
- package/dist/core/workflow/report-writer.d.ts +2 -0
- package/dist/core/workflow/report-writer.d.ts.map +1 -0
- package/dist/core/workflow/report-writer.js +42 -0
- package/dist/core/workflow/report-writer.js.map +1 -0
- package/dist/core/workflow/run/run-meta.d.ts +5 -0
- package/dist/core/workflow/run/run-meta.d.ts.map +1 -1
- package/dist/core/workflow/run/run-meta.js.map +1 -1
- package/dist/core/workflow/state/workflow-state-access.d.ts +2 -2
- package/dist/core/workflow/state/workflow-state-access.d.ts.map +1 -1
- package/dist/core/workflow/state/workflow-state-access.js +17 -2
- package/dist/core/workflow/state/workflow-state-access.js.map +1 -1
- package/dist/core/workflow/types.d.ts +25 -1
- package/dist/core/workflow/types.d.ts.map +1 -1
- package/dist/features/analytics/events.d.ts +1 -1
- package/dist/features/analytics/events.d.ts.map +1 -1
- package/dist/features/analytics/index.d.ts +1 -1
- package/dist/features/analytics/index.d.ts.map +1 -1
- package/dist/features/analytics/index.js +1 -1
- package/dist/features/analytics/index.js.map +1 -1
- package/dist/features/analytics/report-parser.d.ts +5 -3
- package/dist/features/analytics/report-parser.d.ts.map +1 -1
- package/dist/features/analytics/report-parser.js +42 -7
- package/dist/features/analytics/report-parser.js.map +1 -1
- package/dist/features/interactive/clipboardImage.js +2 -2
- package/dist/features/interactive/clipboardImage.js.map +1 -1
- package/dist/features/pipeline/execute.d.ts.map +1 -1
- package/dist/features/pipeline/execute.js +2 -3
- package/dist/features/pipeline/execute.js.map +1 -1
- package/dist/features/pipeline/steps.d.ts +4 -3
- package/dist/features/pipeline/steps.d.ts.map +1 -1
- package/dist/features/pipeline/steps.js +46 -8
- package/dist/features/pipeline/steps.js.map +1 -1
- package/dist/features/repertoire/file-filter.d.ts +3 -3
- package/dist/features/repertoire/file-filter.d.ts.map +1 -1
- package/dist/features/repertoire/file-filter.js +3 -3
- package/dist/features/repertoire/file-filter.js.map +1 -1
- package/dist/features/repertoire/pack-summary.d.ts +21 -7
- package/dist/features/repertoire/pack-summary.d.ts.map +1 -1
- package/dist/features/repertoire/pack-summary.js +156 -24
- package/dist/features/repertoire/pack-summary.js.map +1 -1
- package/dist/features/repertoire/remove.d.ts +5 -2
- package/dist/features/repertoire/remove.d.ts.map +1 -1
- package/dist/features/repertoire/remove.js +9 -2
- package/dist/features/repertoire/remove.js.map +1 -1
- package/dist/features/repertoire/takt-repertoire-config.d.ts +3 -3
- package/dist/features/repertoire/takt-repertoire-config.d.ts.map +1 -1
- package/dist/features/repertoire/takt-repertoire-config.js +31 -16
- package/dist/features/repertoire/takt-repertoire-config.js.map +1 -1
- package/dist/features/tasks/add/index.d.ts +1 -0
- package/dist/features/tasks/add/index.d.ts.map +1 -1
- package/dist/features/tasks/add/index.js +1 -0
- package/dist/features/tasks/add/index.js.map +1 -1
- package/dist/features/tasks/execute/analyticsEmitter.d.ts +4 -1
- package/dist/features/tasks/execute/analyticsEmitter.d.ts.map +1 -1
- package/dist/features/tasks/execute/analyticsEmitter.js +30 -3
- package/dist/features/tasks/execute/analyticsEmitter.js.map +1 -1
- package/dist/features/tasks/execute/runAllTasks.d.ts.map +1 -1
- package/dist/features/tasks/execute/runAllTasks.js +2 -2
- package/dist/features/tasks/execute/runAllTasks.js.map +1 -1
- package/dist/features/tasks/execute/runMeta.d.ts +5 -1
- package/dist/features/tasks/execute/runMeta.d.ts.map +1 -1
- package/dist/features/tasks/execute/runMeta.js +6 -1
- package/dist/features/tasks/execute/runMeta.js.map +1 -1
- package/dist/features/tasks/execute/selectAndExecute.d.ts.map +1 -1
- package/dist/features/tasks/execute/selectAndExecute.js +12 -0
- package/dist/features/tasks/execute/selectAndExecute.js.map +1 -1
- package/dist/features/tasks/execute/sessionLoggerRecordFactory.d.ts.map +1 -1
- package/dist/features/tasks/execute/sessionLoggerRecordFactory.js +2 -1
- package/dist/features/tasks/execute/sessionLoggerRecordFactory.js.map +1 -1
- package/dist/features/tasks/execute/slackSummaryAdapter.d.ts +0 -1
- package/dist/features/tasks/execute/slackSummaryAdapter.d.ts.map +1 -1
- package/dist/features/tasks/execute/slackSummaryAdapter.js +0 -5
- package/dist/features/tasks/execute/slackSummaryAdapter.js.map +1 -1
- package/dist/features/tasks/execute/taskExecution.d.ts.map +1 -1
- package/dist/features/tasks/execute/taskExecution.js +9 -0
- package/dist/features/tasks/execute/taskExecution.js.map +1 -1
- package/dist/features/tasks/execute/taskWorkflowExecution.d.ts.map +1 -1
- package/dist/features/tasks/execute/taskWorkflowExecution.js +20 -1
- package/dist/features/tasks/execute/taskWorkflowExecution.js.map +1 -1
- package/dist/features/tasks/execute/traceTaskMetadata.d.ts +20 -0
- package/dist/features/tasks/execute/traceTaskMetadata.d.ts.map +1 -0
- package/dist/features/tasks/execute/traceTaskMetadata.js +54 -0
- package/dist/features/tasks/execute/traceTaskMetadata.js.map +1 -0
- package/dist/features/tasks/execute/types.d.ts +13 -1
- package/dist/features/tasks/execute/types.d.ts.map +1 -1
- package/dist/features/tasks/execute/workflowExecution.d.ts.map +1 -1
- package/dist/features/tasks/execute/workflowExecution.js +14 -1
- package/dist/features/tasks/execute/workflowExecution.js.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionBootstrap.d.ts +2 -0
- package/dist/features/tasks/execute/workflowExecutionBootstrap.d.ts.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionBootstrap.js +20 -2
- package/dist/features/tasks/execute/workflowExecutionBootstrap.js.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionEvents.d.ts +2 -0
- package/dist/features/tasks/execute/workflowExecutionEvents.d.ts.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionEvents.js +19 -2
- package/dist/features/tasks/execute/workflowExecutionEvents.js.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionReporting.d.ts +3 -2
- package/dist/features/tasks/execute/workflowExecutionReporting.d.ts.map +1 -1
- package/dist/features/tasks/execute/workflowExecutionReporting.js +14 -2
- package/dist/features/tasks/execute/workflowExecutionReporting.js.map +1 -1
- package/dist/features/tasks/index.d.ts +1 -1
- package/dist/features/tasks/index.d.ts.map +1 -1
- package/dist/features/tasks/index.js.map +1 -1
- package/dist/features/tasks/resume/index.d.ts.map +1 -1
- package/dist/features/tasks/resume/index.js +5 -0
- package/dist/features/tasks/resume/index.js.map +1 -1
- package/dist/infra/claude/client.d.ts.map +1 -1
- package/dist/infra/claude/client.js +1 -0
- package/dist/infra/claude/client.js.map +1 -1
- package/dist/infra/claude/mcp-config.d.ts.map +1 -1
- package/dist/infra/claude/mcp-config.js +2 -2
- package/dist/infra/claude/mcp-config.js.map +1 -1
- package/dist/infra/claude/options-builder.d.ts.map +1 -1
- package/dist/infra/claude/options-builder.js +3 -0
- package/dist/infra/claude/options-builder.js.map +1 -1
- package/dist/infra/claude/types.d.ts +4 -0
- package/dist/infra/claude/types.d.ts.map +1 -1
- package/dist/infra/claude-headless/headless-spawn.d.ts.map +1 -1
- package/dist/infra/claude-headless/headless-spawn.js +3 -0
- package/dist/infra/claude-headless/headless-spawn.js.map +1 -1
- package/dist/infra/claude-headless/types.d.ts +2 -0
- package/dist/infra/claude-headless/types.d.ts.map +1 -1
- package/dist/infra/codex/client.d.ts.map +1 -1
- package/dist/infra/codex/client.js +1 -0
- package/dist/infra/codex/client.js.map +1 -1
- package/dist/infra/codex/types.d.ts +2 -0
- package/dist/infra/codex/types.d.ts.map +1 -1
- package/dist/infra/config/configNormalizers.d.ts +19 -7
- package/dist/infra/config/configNormalizers.d.ts.map +1 -1
- package/dist/infra/config/configNormalizers.js +59 -16
- package/dist/infra/config/configNormalizers.js.map +1 -1
- package/dist/infra/config/env/global-current-env-specs.d.ts.map +1 -1
- package/dist/infra/config/env/global-current-env-specs.js +1 -0
- package/dist/infra/config/env/global-current-env-specs.js.map +1 -1
- package/dist/infra/config/env/project-current-env-specs.d.ts.map +1 -1
- package/dist/infra/config/env/project-current-env-specs.js +1 -0
- package/dist/infra/config/env/project-current-env-specs.js.map +1 -1
- package/dist/infra/config/global/globalConfigCore.d.ts.map +1 -1
- package/dist/infra/config/global/globalConfigCore.js +4 -2
- package/dist/infra/config/global/globalConfigCore.js.map +1 -1
- package/dist/infra/config/global/globalConfigSerializer.d.ts.map +1 -1
- package/dist/infra/config/global/globalConfigSerializer.js +5 -1
- package/dist/infra/config/global/globalConfigSerializer.js.map +1 -1
- package/dist/infra/config/loaders/namedResourceResolver.d.ts +18 -0
- package/dist/infra/config/loaders/namedResourceResolver.d.ts.map +1 -0
- package/dist/infra/config/loaders/namedResourceResolver.js +49 -0
- package/dist/infra/config/loaders/namedResourceResolver.js.map +1 -0
- package/dist/infra/config/loaders/providerOptionsLookupDirectories.d.ts +13 -0
- package/dist/infra/config/loaders/providerOptionsLookupDirectories.d.ts.map +1 -0
- package/dist/infra/config/loaders/providerOptionsLookupDirectories.js +61 -0
- package/dist/infra/config/loaders/providerOptionsLookupDirectories.js.map +1 -0
- package/dist/infra/config/loaders/workflowParser.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowParser.js +64 -3
- package/dist/infra/config/loaders/workflowParser.js.map +1 -1
- package/dist/infra/config/loaders/workflowPreview.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowPreview.js +29 -12
- package/dist/infra/config/loaders/workflowPreview.js.map +1 -1
- package/dist/infra/config/loaders/workflowProviderOptionsResolver.d.ts +20 -2
- package/dist/infra/config/loaders/workflowProviderOptionsResolver.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowProviderOptionsResolver.js +122 -34
- package/dist/infra/config/loaders/workflowProviderOptionsResolver.js.map +1 -1
- package/dist/infra/config/loaders/workflowRuleNormalizer.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowRuleNormalizer.js +5 -16
- package/dist/infra/config/loaders/workflowRuleNormalizer.js.map +1 -1
- package/dist/infra/config/loaders/workflowStepFeaturesNormalizer.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowStepFeaturesNormalizer.js +32 -1
- package/dist/infra/config/loaders/workflowStepFeaturesNormalizer.js.map +1 -1
- package/dist/infra/config/loaders/workflowStepNormalizer.d.ts +3 -2
- package/dist/infra/config/loaders/workflowStepNormalizer.d.ts.map +1 -1
- package/dist/infra/config/loaders/workflowStepNormalizer.js +33 -12
- package/dist/infra/config/loaders/workflowStepNormalizer.js.map +1 -1
- package/dist/infra/config/paths.d.ts +4 -0
- package/dist/infra/config/paths.d.ts.map +1 -1
- package/dist/infra/config/paths.js +13 -0
- package/dist/infra/config/paths.js.map +1 -1
- package/dist/infra/config/project/projectConfig.d.ts.map +1 -1
- package/dist/infra/config/project/projectConfig.js +23 -6
- package/dist/infra/config/project/projectConfig.js.map +1 -1
- package/dist/infra/config/providerOptions.d.ts +29 -10
- package/dist/infra/config/providerOptions.d.ts.map +1 -1
- package/dist/infra/config/providerOptions.js +166 -18
- package/dist/infra/config/providerOptions.js.map +1 -1
- package/dist/infra/config/providerOptionsContract.d.ts +4 -3
- package/dist/infra/config/providerOptionsContract.d.ts.map +1 -1
- package/dist/infra/config/providerOptionsContract.js +11 -0
- package/dist/infra/config/providerOptionsContract.js.map +1 -1
- package/dist/infra/config/providerReference.d.ts +3 -2
- package/dist/infra/config/providerReference.d.ts.map +1 -1
- package/dist/infra/config/providerReference.js +6 -6
- package/dist/infra/config/providerReference.js.map +1 -1
- package/dist/infra/config/resolveConfigValue.d.ts.map +1 -1
- package/dist/infra/config/resolveConfigValue.js +95 -25
- package/dist/infra/config/resolveConfigValue.js.map +1 -1
- package/dist/infra/config/traced/tracedConfigLoader.d.ts +3 -2
- package/dist/infra/config/traced/tracedConfigLoader.d.ts.map +1 -1
- package/dist/infra/config/traced/tracedConfigLoader.js +28 -4
- package/dist/infra/config/traced/tracedConfigLoader.js.map +1 -1
- package/dist/infra/config/traced/tracedConfigRuntimeBridge.d.ts.map +1 -1
- package/dist/infra/config/traced/tracedConfigRuntimeBridge.js +2 -2
- package/dist/infra/config/traced/tracedConfigRuntimeBridge.js.map +1 -1
- package/dist/infra/config/traced/tracedConfigSchema.d.ts.map +1 -1
- package/dist/infra/config/traced/tracedConfigSchema.js +8 -0
- package/dist/infra/config/traced/tracedConfigSchema.js.map +1 -1
- package/dist/infra/copilot/client.d.ts.map +1 -1
- package/dist/infra/copilot/client.js +3 -3
- package/dist/infra/copilot/client.js.map +1 -1
- package/dist/infra/cursor/client.d.ts.map +1 -1
- package/dist/infra/cursor/client.js +113 -47
- package/dist/infra/cursor/client.js.map +1 -1
- package/dist/infra/opencode/client.d.ts.map +1 -1
- package/dist/infra/opencode/client.js +21 -0
- package/dist/infra/opencode/client.js.map +1 -1
- package/dist/infra/opencode/unavailable-tool-loop.d.ts +7 -0
- package/dist/infra/opencode/unavailable-tool-loop.d.ts.map +1 -0
- package/dist/infra/opencode/unavailable-tool-loop.js +33 -0
- package/dist/infra/opencode/unavailable-tool-loop.js.map +1 -0
- package/dist/infra/providers/claude-headless.d.ts +1 -1
- package/dist/infra/providers/claude-headless.d.ts.map +1 -1
- package/dist/infra/providers/claude-headless.js +2 -1
- package/dist/infra/providers/claude-headless.js.map +1 -1
- package/dist/infra/providers/claude-terminal.d.ts +1 -1
- package/dist/infra/providers/claude-terminal.d.ts.map +1 -1
- package/dist/infra/providers/claude-terminal.js +1 -1
- package/dist/infra/providers/claude-terminal.js.map +1 -1
- package/dist/infra/providers/claude.d.ts +1 -1
- package/dist/infra/providers/claude.d.ts.map +1 -1
- package/dist/infra/providers/claude.js +2 -1
- package/dist/infra/providers/claude.js.map +1 -1
- package/dist/infra/providers/codex.d.ts +1 -1
- package/dist/infra/providers/codex.d.ts.map +1 -1
- package/dist/infra/providers/codex.js +2 -1
- package/dist/infra/providers/codex.js.map +1 -1
- package/dist/infra/providers/copilot.d.ts +1 -1
- package/dist/infra/providers/copilot.d.ts.map +1 -1
- package/dist/infra/providers/copilot.js +1 -1
- package/dist/infra/providers/copilot.js.map +1 -1
- package/dist/infra/providers/cursor.d.ts +1 -1
- package/dist/infra/providers/cursor.d.ts.map +1 -1
- package/dist/infra/providers/cursor.js +1 -1
- package/dist/infra/providers/cursor.js.map +1 -1
- package/dist/infra/providers/kiro.d.ts +1 -1
- package/dist/infra/providers/kiro.d.ts.map +1 -1
- package/dist/infra/providers/kiro.js +1 -1
- package/dist/infra/providers/kiro.js.map +1 -1
- package/dist/infra/providers/mock.d.ts +1 -1
- package/dist/infra/providers/mock.d.ts.map +1 -1
- package/dist/infra/providers/mock.js +1 -1
- package/dist/infra/providers/mock.js.map +1 -1
- package/dist/infra/providers/opencode.d.ts +1 -1
- package/dist/infra/providers/opencode.d.ts.map +1 -1
- package/dist/infra/providers/opencode.js +4 -1
- package/dist/infra/providers/opencode.js.map +1 -1
- package/dist/infra/providers/provider-capabilities.d.ts.map +1 -1
- package/dist/infra/providers/provider-capabilities.js +0 -1
- package/dist/infra/providers/provider-capabilities.js.map +1 -1
- package/dist/infra/providers/types.d.ts +1 -1
- package/dist/infra/providers/types.d.ts.map +1 -1
- package/dist/infra/task/clone-base-branch.d.ts +1 -0
- package/dist/infra/task/clone-base-branch.d.ts.map +1 -1
- package/dist/infra/task/clone-base-branch.js +22 -14
- package/dist/infra/task/clone-base-branch.js.map +1 -1
- package/dist/infra/task/clone.d.ts +2 -0
- package/dist/infra/task/clone.d.ts.map +1 -1
- package/dist/infra/task/clone.js +7 -1
- package/dist/infra/task/clone.js.map +1 -1
- package/dist/infra/task/index.d.ts +1 -1
- package/dist/infra/task/index.d.ts.map +1 -1
- package/dist/infra/task/index.js +1 -1
- package/dist/infra/task/index.js.map +1 -1
- package/dist/infra/task/mapper.d.ts.map +1 -1
- package/dist/infra/task/mapper.js +1 -0
- package/dist/infra/task/mapper.js.map +1 -1
- package/dist/infra/task/projectLocalTaktSync.d.ts +1 -0
- package/dist/infra/task/projectLocalTaktSync.d.ts.map +1 -1
- package/dist/infra/task/projectLocalTaktSync.js +40 -0
- package/dist/infra/task/projectLocalTaktSync.js.map +1 -1
- package/dist/infra/task/taskExecutionSchemas.d.ts +3 -3
- package/dist/infra/task/taskRecordSchemas.d.ts +2 -2
- package/dist/infra/task/types.d.ts +1 -0
- package/dist/infra/task/types.d.ts.map +1 -1
- package/dist/shared/prompts/en/perform_phase2_message.md +1 -0
- package/dist/shared/prompts/ja/perform_phase2_message.md +1 -0
- package/dist/shared/team-leader-inspect-tools.d.ts +5 -0
- package/dist/shared/team-leader-inspect-tools.d.ts.map +1 -0
- package/dist/shared/team-leader-inspect-tools.js +8 -0
- package/dist/shared/team-leader-inspect-tools.js.map +1 -0
- package/dist/shared/ui/StreamDisplay.js +1 -1
- package/dist/shared/ui/StreamDisplay.js.map +1 -1
- package/dist/shared/utils/index.d.ts +2 -0
- package/dist/shared/utils/index.d.ts.map +1 -1
- package/dist/shared/utils/index.js +2 -0
- package/dist/shared/utils/index.js.map +1 -1
- package/dist/shared/utils/runId.d.ts +2 -0
- package/dist/shared/utils/runId.d.ts.map +1 -0
- package/dist/shared/utils/runId.js +18 -0
- package/dist/shared/utils/runId.js.map +1 -0
- package/dist/shared/utils/tmpdir.d.ts +2 -0
- package/dist/shared/utils/tmpdir.d.ts.map +1 -0
- package/dist/shared/utils/tmpdir.js +8 -0
- package/dist/shared/utils/tmpdir.js.map +1 -0
- package/package.json +33 -16
- /package/builtins/en/{workflows/provider-options → provider-options}/edit.yaml +0 -0
- /package/builtins/en/{workflows/provider-options → provider-options}/review-files.yaml +0 -0
- /package/builtins/en/{workflows/provider-options → provider-options}/review-readonly.yaml +0 -0
- /package/builtins/en/{workflows/provider-options → provider-options}/review-web.yaml +0 -0
- /package/builtins/ja/{workflows/provider-options → provider-options}/edit.yaml +0 -0
- /package/builtins/ja/{workflows/provider-options → provider-options}/review-files.yaml +0 -0
- /package/builtins/ja/{workflows/provider-options → provider-options}/review-readonly.yaml +0 -0
- /package/builtins/ja/{workflows/provider-options → provider-options}/review-web.yaml +0 -0
|
@@ -7,25 +7,39 @@
|
|
|
7
7
|
|
|
8
8
|
Extract requirements from the task spec and verify each one individually against actual code.
|
|
9
9
|
|
|
10
|
-
| # | Decomposed requirement | Met | Evidence (file:line) |
|
|
11
|
-
|
|
12
|
-
| 1 | {requirement 1} | ✅/❌ | `src/file.ts:42` |
|
|
13
|
-
| 2 | {requirement 2} | ✅/❌ | `src/file.ts:55` |
|
|
10
|
+
| # | Decomposed requirement | Original Requirement Source | Met | Evidence (file:line) | Exception / Optionalization Evidence |
|
|
11
|
+
|---|------------------------|-----------------------------|-----|----------------------|------------------------------------|
|
|
12
|
+
| 1 | {requirement 1} | `order.md:10` | ✅/❌ | `src/file.ts:42` | none |
|
|
13
|
+
| 2 | {requirement 2} | `order.md:11` | ✅/❌ | `src/file.ts:55` | none |
|
|
14
14
|
|
|
15
15
|
- If a sentence contains multiple conditions, split it into the smallest independently verifiable rows
|
|
16
16
|
- Do not combine parallel conditions such as `A/B`, `global/project`, `JSON/leaf`, `allow/deny`, or `read/write` into one row
|
|
17
17
|
- If any ❌ exists, REJECT is mandatory
|
|
18
18
|
- ✅ without evidence is invalid (must verify against actual code)
|
|
19
19
|
- Do not mark a row as ✅ when the evidence covers only part of the cases
|
|
20
|
+
- Treat optionalization, exclusion, or exception not present in the task spec as unmet
|
|
20
21
|
- Do not rely on plan report's judgment; independently verify mergeability
|
|
21
22
|
|
|
22
23
|
## Re-evaluation of Prior Findings
|
|
23
|
-
| finding_id | Prior Status | Re-evaluation | Evidence |
|
|
24
|
-
|
|
25
|
-
| {id} | new / persists / resolved | valid / false_positive / overreach | `src/file.ts:42`, `reports/plan.md` |
|
|
24
|
+
| finding_id | Prior Status | Original Expected Result | Re-evaluation | Evidence |
|
|
25
|
+
|------------|--------------|--------------------------|---------------|----------|
|
|
26
|
+
| {id} | new / persists / resolved | {Original finding acceptance criteria} | valid / false_positive / overreach | `src/file.ts:42`, `reports/plan.md` |
|
|
26
27
|
|
|
27
28
|
- If final judgment differs from prior review conclusions, explain why with evidence
|
|
29
|
+
- Treat `resolved` as valid only when it satisfies the original expected result and original requirement
|
|
28
30
|
- If marking `false_positive` or `overreach`, state whether it conflicts with the task objective, the plan, or both
|
|
31
|
+
- If overturning a pure-review conclusion, explain why with concrete evidence
|
|
32
|
+
|
|
33
|
+
## Maintenance Scope Check (maintenance workflows only)
|
|
34
|
+
|
|
35
|
+
| Check | Result | Evidence |
|
|
36
|
+
|-------|--------|----------|
|
|
37
|
+
| Only required changes remain | ✅/❌ | {Evidence} |
|
|
38
|
+
| Related changes have clear reasons | ✅/❌ | {Evidence} |
|
|
39
|
+
| No unnecessary changes remain | ✅/❌ | {Evidence} |
|
|
40
|
+
| No out-of-scope comment deletion occurred | ✅/❌ | {Evidence} |
|
|
41
|
+
| Type names, file placement, and public APIs did not change out of scope | ✅/❌ | {Evidence} |
|
|
42
|
+
| UI copy, accessible names, and test expectations did not change out of scope | ✅/❌ | {Evidence} |
|
|
29
43
|
|
|
30
44
|
## Validation Summary
|
|
31
45
|
| Item | Status | Verification Method |
|
|
@@ -38,6 +52,11 @@ Extract requirements from the task spec and verify each one individually against
|
|
|
38
52
|
- When using `⚠️`, explain the missing evidence and the verified scope in the method column
|
|
39
53
|
- If report text conflicts with execution evidence, treat that inconsistency itself as a finding
|
|
40
54
|
|
|
55
|
+
## Unverified Scope
|
|
56
|
+
| Item | Impact | Treatment |
|
|
57
|
+
|------|--------|-----------|
|
|
58
|
+
| {Unverified scope, or "none"} | {Primary or supporting requirement} | APPROVE allowed / REJECT reason |
|
|
59
|
+
|
|
41
60
|
## Current Iteration Findings (new)
|
|
42
61
|
| # | finding_id | Item | Evidence | Reason | Required Action |
|
|
43
62
|
|---|------------|------|----------|--------|-----------------|
|
|
@@ -49,14 +68,19 @@ Extract requirements from the task spec and verify each one individually against
|
|
|
49
68
|
| 1 | VAL-PERSIST-src-file-L77 | `file:line` | `file:line` | Still unresolved | Apply fix |
|
|
50
69
|
|
|
51
70
|
## Resolved Findings (resolved)
|
|
52
|
-
| finding_id | Resolution Evidence |
|
|
53
|
-
|
|
54
|
-
| VAL-RESOLVED-src-file-L10 | `file:line` now passes validation |
|
|
71
|
+
| finding_id | Original Expected Result | Resolution Evidence |
|
|
72
|
+
|------------|--------------------------|---------------------|
|
|
73
|
+
| VAL-RESOLVED-src-file-L10 | {Original finding acceptance criteria} | `file:line` now passes validation |
|
|
55
74
|
|
|
56
75
|
## Deliverables
|
|
57
76
|
- Created: {Created files}
|
|
58
77
|
- Modified: {Modified files}
|
|
59
78
|
|
|
79
|
+
## Outstanding Items (if REJECT)
|
|
80
|
+
| # | Item | Reason |
|
|
81
|
+
|---|------|--------|
|
|
82
|
+
| 1 | {Item} | {Reason} |
|
|
83
|
+
|
|
60
84
|
## Rejection Gate
|
|
61
85
|
- REJECT is valid only when at least one finding exists in `new` or `persists`
|
|
62
86
|
- Findings without `finding_id` are invalid
|
|
@@ -0,0 +1,31 @@
|
|
|
1
|
+
```markdown
|
|
2
|
+
# Terraform Convention Review
|
|
3
|
+
|
|
4
|
+
## Result: APPROVE / REJECT
|
|
5
|
+
|
|
6
|
+
## Summary
|
|
7
|
+
{Summarize the result in 1-2 sentences}
|
|
8
|
+
|
|
9
|
+
## Reviewed Aspects
|
|
10
|
+
- [x] Variable declarations (type, description, sensitive)
|
|
11
|
+
- [x] Resource naming (name_prefix pattern)
|
|
12
|
+
- [x] File structure (one concern per file)
|
|
13
|
+
- [x] Security settings
|
|
14
|
+
- [x] Tag management
|
|
15
|
+
- [x] lifecycle rules
|
|
16
|
+
- [x] Cost trade-off documentation
|
|
17
|
+
|
|
18
|
+
## Observed Findings
|
|
19
|
+
| # | family_tag | Severity | Scope | Location | Issue | Impact | Fix Suggestion |
|
|
20
|
+
|---|------------|----------|-------|----------|-------|--------|----------------|
|
|
21
|
+
| 1 | tf-convention | High / Medium / Low | In-scope | `modules/example/main.tf:42` | Issue description | Operations, security, or maintainability impact | Fix approach |
|
|
22
|
+
|
|
23
|
+
Scope: "In-scope" (fixable in this change) / "Out-of-scope" (existing issue, non-blocking)
|
|
24
|
+
|
|
25
|
+
## Rejection Gate
|
|
26
|
+
- REJECT only when at least one blocking finding is observed
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
**Cognitive load reduction rules:**
|
|
30
|
+
- APPROVE → Summary only (5 lines or fewer)
|
|
31
|
+
- REJECT → Include only relevant finding rows (30 lines or fewer)
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
```markdown
|
|
2
|
+
# Testing Review
|
|
3
|
+
|
|
4
|
+
## Result: APPROVE / REJECT
|
|
5
|
+
|
|
6
|
+
## Summary
|
|
7
|
+
{Summarize the result in 1-2 sentences}
|
|
8
|
+
|
|
9
|
+
## Reviewed Aspects
|
|
10
|
+
| Aspect | Result | Notes |
|
|
11
|
+
|--------|--------|-------|
|
|
12
|
+
| Test coverage | ✅ | - |
|
|
13
|
+
| Test structure (Given-When-Then) | ✅ | - |
|
|
14
|
+
| Test naming | ✅ | - |
|
|
15
|
+
| Test independence & reproducibility | ✅ | - |
|
|
16
|
+
| Mocks & fixtures | ✅ | - |
|
|
17
|
+
| Test strategy (unit/integration/E2E) | ✅ | - |
|
|
18
|
+
| Contract input location (body/query/path) | ✅ | - |
|
|
19
|
+
|
|
20
|
+
## Observed Findings
|
|
21
|
+
| # | family_tag | Category | Severity | Location | Issue | Fix Suggestion |
|
|
22
|
+
|---|------------|----------|----------|----------|-------|----------------|
|
|
23
|
+
| 1 | test-structure | Coverage | high / medium / low | `src/test.ts:42` | Issue description | Fix suggestion |
|
|
24
|
+
|
|
25
|
+
## Verification Evidence
|
|
26
|
+
- Build: {Verified target, what was checked, and observed result; or state that it was unverified}
|
|
27
|
+
- Tests: {Verified target, what was checked, and observed result; or state that it was unverified}
|
|
28
|
+
- Functional check: {Verified target, what was checked, and observed result; or state that it was unverified}
|
|
29
|
+
|
|
30
|
+
## Unverified Scope
|
|
31
|
+
| Item | Reason | Impact on Decision |
|
|
32
|
+
|------|--------|--------------------|
|
|
33
|
+
| {Unverified scope, or "none"} | {Reason it was not verified} | {APPROVE allowed / REJECT reason} |
|
|
34
|
+
|
|
35
|
+
## Rejection Gate
|
|
36
|
+
- REJECT is valid only when at least one blocking finding is observed
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
**Cognitive load reduction rules:**
|
|
40
|
+
- APPROVE: Summary and unverified scope only (8 lines or fewer)
|
|
41
|
+
- REJECT: Only relevant findings in tables (30 lines or fewer)
|
|
@@ -0,0 +1,18 @@
|
|
|
1
|
+
# Findings Manager
|
|
2
|
+
|
|
3
|
+
You manage Finding Contract reconciliation.
|
|
4
|
+
|
|
5
|
+
Compare reviewer raw findings with the existing ledger, then classify each issue as an existing match, new finding, resolved finding, or reopened finding. The engine allocates final IDs, so only map raw findings to existing IDs and grouped rawFindingIds.
|
|
6
|
+
|
|
7
|
+
Responsibilities:
|
|
8
|
+
- Reconcile the prior integrated ledger with current raw findings.
|
|
9
|
+
- Classify raw findings as existing matches, new findings, resolved findings, or reopened findings.
|
|
10
|
+
- Group rawFindingIds into structured data that lets the engine allocate final IDs.
|
|
11
|
+
|
|
12
|
+
Rules:
|
|
13
|
+
- Do not make semantic severity or priority judgments.
|
|
14
|
+
- Do not merge findings with different `family_tag`, location, or issue meaning.
|
|
15
|
+
- Do not blame reviewers.
|
|
16
|
+
- Do not allocate final `finding_id` values.
|
|
17
|
+
- Treat identical location + `family_tag` + issue meaning as the existing-match standard.
|
|
18
|
+
- Treat ambiguous or merely similar findings as distinct.
|
|
@@ -1,5 +1,20 @@
|
|
|
1
1
|
# AI Antipattern Detection Criteria
|
|
2
2
|
|
|
3
|
+
Detect assumptions, over-implementation, and superficial fixes that AI-generated changes commonly introduce.
|
|
4
|
+
|
|
5
|
+
## Principles
|
|
6
|
+
|
|
7
|
+
| Principle | Criteria |
|
|
8
|
+
|-----------|----------|
|
|
9
|
+
| Requirement fit | Verify that the implementation answers the actual request |
|
|
10
|
+
| Reality check | Do not infer APIs, settings, fields, or wiring paths |
|
|
11
|
+
| Context fit | Match existing naming, structure, error handling, logging, and tests |
|
|
12
|
+
| Minimal diff | Do not mix in unnecessary features, abstractions, settings, or compatibility code |
|
|
13
|
+
| Contract preservation | Do not change UI copy, public APIs, return values, errors, or test expectations out of scope |
|
|
14
|
+
| Direct fixes | Do not replace a fix with tests or documentation explaining the issue |
|
|
15
|
+
| Reachability | Confirm that added or retained code is used by current call paths |
|
|
16
|
+
| Verifiability | Check code paths, usage sites, and execution results instead of explanations |
|
|
17
|
+
|
|
3
18
|
## Assumption Verification
|
|
4
19
|
|
|
5
20
|
AI often makes assumptions. Verify them.
|
|
@@ -136,6 +151,22 @@ Questions to ask:
|
|
|
136
151
|
- Does it feel like it belongs here?
|
|
137
152
|
- Are there unexplained deviations from project conventions?
|
|
138
153
|
|
|
154
|
+
## Integration Pattern Consistency
|
|
155
|
+
|
|
156
|
+
Check whether the same kind of API connection, such as REST calls, is implemented in inconsistent ways within the project.
|
|
157
|
+
|
|
158
|
+
| Pattern | Example | Verdict |
|
|
159
|
+
|---------|---------|---------|
|
|
160
|
+
| Mixed generated and hand-written clients | Screen A uses Orval-generated hooks, screen B calls axiosInstance directly | REJECT |
|
|
161
|
+
| Different implementations for the same data-fetching pattern | Screen A uses useQuery + axios, screen B uses generated hooks | REJECT |
|
|
162
|
+
| Mixed data type definition styles | Screen A uses generated types, screen B uses hand-written types | REJECT |
|
|
163
|
+
|
|
164
|
+
Verification approach:
|
|
165
|
+
1. Check the API calling style in the diff
|
|
166
|
+
2. Grep existing code for the style used by code with the same purpose
|
|
167
|
+
3. Check whether the project has API generation config, such as orval.config.ts
|
|
168
|
+
4. If inconsistent, flag unification to the project standard pattern
|
|
169
|
+
|
|
139
170
|
## Scope Creep Detection
|
|
140
171
|
|
|
141
172
|
AI tends to over-deliver. Check for unnecessary additions.
|
|
@@ -1,19 +1,19 @@
|
|
|
1
1
|
# Existing System Respect Policy
|
|
2
2
|
|
|
3
|
-
For released or operational systems, make
|
|
3
|
+
For released or operational systems, make changes that are causally related to the request and do not change existing contracts that lack that relationship.
|
|
4
4
|
|
|
5
5
|
## Principles
|
|
6
6
|
|
|
7
7
|
| Principle | Criteria |
|
|
8
8
|
|-----------|----------|
|
|
9
9
|
| Existing contracts first | Preserve contracts relied on by users, tests, and operations |
|
|
10
|
-
|
|
|
10
|
+
| Causal diff | Make changes causally related to the request; exclude changes without causal relationship |
|
|
11
11
|
| Necessity over proximity | Do not use nearby code as a reason to change it |
|
|
12
|
-
| Respect existing structure | Do not change file placement, type names, public APIs, or responsibility boundaries without
|
|
12
|
+
| Respect existing structure | Do not change file placement, type names, public APIs, or responsibility boundaries without causal relationship to the request |
|
|
13
13
|
| Preserve comments | Do not delete comments that explain intent, constraints, or calculation rationale |
|
|
14
14
|
| Tests are contracts | Do not treat behavior asserted by existing tests as incidental |
|
|
15
|
-
|
|
|
16
|
-
|
|
|
15
|
+
| Causal improvement judgment | Perform style improvements and refactoring when causally related to the request. Do not mix improvements without causal relationship |
|
|
16
|
+
| Protect unrelated code | Prioritize preserving existing behavior and structure that is not causally related to the request |
|
|
17
17
|
|
|
18
18
|
## Change Boundary
|
|
19
19
|
|
|
@@ -22,21 +22,22 @@ For released or operational systems, make only the minimum changes required by t
|
|
|
22
22
|
| Change required to satisfy the request | OK |
|
|
23
23
|
| Call-site update required to wire a necessary change | OK |
|
|
24
24
|
| Local fix required to prevent side effects of a necessary change | OK |
|
|
25
|
+
| Structural change or refactoring causally related to the request | OK |
|
|
25
26
|
| Cleanup justified only because the file was touched | REJECT |
|
|
26
|
-
| Moving files, renaming types, or changing public APIs without
|
|
27
|
-
| Mixing framework-style improvements
|
|
28
|
-
| Including improvements
|
|
27
|
+
| Moving files, renaming types, or changing public APIs without causal relationship to the request | REJECT |
|
|
28
|
+
| Mixing framework-style improvements not causally related to the request | REJECT |
|
|
29
|
+
| Including improvements not causally related to the request | REJECT |
|
|
29
30
|
|
|
30
31
|
## Priority Against Other Policies
|
|
31
32
|
|
|
32
|
-
In existing-system maintenance, apply general quality policies such as coding, frontend, design-fidelity, and testing
|
|
33
|
+
In existing-system maintenance, apply general quality policies such as coding, frontend, design-fidelity, and testing within the scope causally related to the request.
|
|
33
34
|
|
|
34
35
|
| Conflict | Verdict |
|
|
35
36
|
|----------|---------|
|
|
36
|
-
| General quality criteria suggest an improvement, but
|
|
37
|
-
| Existing structure is imperfect, but
|
|
37
|
+
| General quality criteria suggest an improvement, but it is not causally related to the request | Do not change |
|
|
38
|
+
| Existing structure is imperfect, but not causally related to the request | Preserve existing structure |
|
|
38
39
|
| Satisfying a quality criterion requires changing an existing contract | Requires an explicit user request or plan-level rationale |
|
|
39
|
-
|
|
|
40
|
+
| Structural change causally related to the request | Make it with reason and impact scope documented |
|
|
40
41
|
|
|
41
42
|
## Observable Contracts
|
|
42
43
|
|
|
@@ -44,11 +45,11 @@ UI, accessibility, tests, logs, APIs, types, file placement, and comments can be
|
|
|
44
45
|
|
|
45
46
|
| Contract | Change condition |
|
|
46
47
|
|----------|------------------|
|
|
47
|
-
| UI copy, accessible names, role/state | Change only when
|
|
48
|
-
| Hook return values, Props type names, public function names | Change only when caller updates
|
|
48
|
+
| UI copy, accessible names, role/state | Change only when causally related to the request |
|
|
49
|
+
| Hook return values, Props type names, public function names | Change only when required for caller updates causally related to the request |
|
|
49
50
|
| Test expectations | Change only when the requested behavior changes |
|
|
50
51
|
| Comments | Change only when correcting inaccurate comments or when code makes them truly obsolete |
|
|
51
|
-
| File placement | Change only when
|
|
52
|
+
| File placement | Change only when causally related to the request |
|
|
52
53
|
|
|
53
54
|
## Test Changes
|
|
54
55
|
|
|
@@ -70,4 +71,4 @@ Before completion, classify the full diff as required changes, related changes,
|
|
|
70
71
|
|----------------|----------|
|
|
71
72
|
| Required change | The request fails without it |
|
|
72
73
|
| Related change | Needed to connect, verify, or keep a required change consistent |
|
|
73
|
-
| Unnecessary change |
|
|
74
|
+
| Unnecessary change | Not causally related to the request; justified only by readability, style, cleanup, or future extensibility |
|
|
@@ -11,6 +11,11 @@ Define the shared judgment criteria and behavioral principles for all reviewers.
|
|
|
11
11
|
| Fact-check | Verify against actual code before raising issues. Do not speculate |
|
|
12
12
|
| Practical fixes | Propose implementable solutions, not theoretical ideals |
|
|
13
13
|
| State consistency | For side effects and state changes, verify that success, failure, and interruption paths have no missing, duplicated, or inconsistent effects |
|
|
14
|
+
| Contract coverage | Verify new contracts across normal entries, derived conditions, validation, evaluation, output, and re-injection paths |
|
|
15
|
+
| Contract consistency | Verify that contracts carried by consolidation or abstraction are applied to existing equivalent branches by the same standard |
|
|
16
|
+
| Specification completeness | When changing a user-facing contract, verify that implementation, tests, and documentation describe the same lookup order, override rules, special syntax, and failure conditions |
|
|
17
|
+
| Requirement anchoring | Do not reinterpret required task items as optional, out of scope, or different requirements for implementation convenience |
|
|
18
|
+
| Resolution judgment | Judge `resolved` against the original finding acceptance criteria and original task requirements, not merely against the presence of a fix |
|
|
14
19
|
| Behavior evidence | Verify what behavior the tests or logs prove, not merely that they exist |
|
|
15
20
|
| Boy Scout | Have problems fixed within the task scope when they are in changed code or in areas directly affecting correctness, contracts, or wiring of the change |
|
|
16
21
|
|
|
@@ -48,7 +53,10 @@ REJECT without exception if any of the following apply.
|
|
|
48
53
|
- Internal implementation exported from public API (infrastructure functions or internal classes exposed publicly)
|
|
49
54
|
- Replaced code/exports surviving after refactoring
|
|
50
55
|
- Missing cross-validation of related fields (invariants of semantically coupled config values left unverified)
|
|
51
|
-
- Missing caller, producer,
|
|
56
|
+
- Missing caller, producer, consumer, validator, test data, or derived-entry updates after a contract change
|
|
57
|
+
- User-facing contract changes for configuration, CLI, or file formats where documentation or examples omit priority, first-match/merge behavior, inline overrides, scoped/special references, or failure conditions
|
|
58
|
+
- Existing branches with the same contract remain on the old implementation after adding or changing a shared helper, normalizer, builder, or adapter
|
|
59
|
+
- Fields, attributes, outputs, settings, or identifiers requested by the task are treated as optional, unset, out of scope, or missing for some entry point or execution mode without explicit evidence
|
|
52
60
|
- Missing, duplicated, or incorrectly ordered effects in side-effect or state-change paths
|
|
53
61
|
- Sensitive data exposed in logs, error responses, or test output
|
|
54
62
|
|
|
@@ -129,12 +137,39 @@ Every issue raised must include the following.
|
|
|
129
137
|
|
|
130
138
|
To prevent circular rejections, track findings by ID.
|
|
131
139
|
|
|
140
|
+
Finding Contract applies to the whole review workflow, not to individual findings.
|
|
141
|
+
Treat a workflow as using Finding Contract only when it is declared at workflow level
|
|
142
|
+
with `finding_contract` configuration. A `findings-ledger.json` file, a dedicated
|
|
143
|
+
"Finding Contract" section in the instruction template, or an `Observed Findings`
|
|
144
|
+
table in the output contract is supporting evidence inside an already configured
|
|
145
|
+
Finding Contract workflow; none of these artifacts enables Finding Contract by itself.
|
|
146
|
+
|
|
147
|
+
When Finding Contract is in use, reviewers must not allocate new final `finding_id`
|
|
148
|
+
values and must not classify lifecycle as `new`, `persists`, `resolved`, or
|
|
149
|
+
`reopened`. Report observed problems as raw findings in the `Observed Findings`
|
|
150
|
+
table. Refer to existing IDs only when they are present in the ledger. ID assignment
|
|
151
|
+
and lifecycle matching belong to the findings-manager and engine.
|
|
152
|
+
|
|
153
|
+
When a workflow is configured with Finding Contract and a parseable ledger is available,
|
|
154
|
+
the ledger is the authoritative source for tracked findings. Individual reports and raw
|
|
155
|
+
finding details are supporting evidence. If a ledger exists but is incomplete, follow
|
|
156
|
+
mapped findings from the ledger and treat unmapped raw findings as potential new entries
|
|
157
|
+
pending findings-manager reconciliation. If no parseable ledger is available in a
|
|
158
|
+
configured Finding Contract workflow, use report history only as supporting evidence for
|
|
159
|
+
observed raw findings. Do not assign final `finding_id` values or lifecycle states and
|
|
160
|
+
do not apply the legacy rules; wait for ledger regeneration or findings-manager
|
|
161
|
+
reconciliation.
|
|
162
|
+
|
|
163
|
+
### Legacy Finding ID Rules (for workflows without Finding Contract)
|
|
164
|
+
|
|
165
|
+
When a workflow does not use `finding_contract` configuration, follow these legacy rules.
|
|
166
|
+
|
|
132
167
|
- Every issue raised in a REJECT must include a `finding_id`
|
|
133
168
|
- If the same issue is raised again, reuse the same `finding_id`
|
|
134
169
|
- For repeated issues, set status to `persists` and include concrete evidence (file/line) that it remains unresolved
|
|
135
170
|
- New issues must use status `new`
|
|
136
171
|
- Resolved issues must be listed with status `resolved`
|
|
137
|
-
- Issues without `finding_id` are invalid (cannot be used as rejection grounds)
|
|
172
|
+
- Issues without `finding_id` are invalid (cannot be used as rejection grounds). This legacy rule does not apply to Finding Contract workflows.
|
|
138
173
|
- REJECT is allowed only when there is at least one `new` or `persists` issue
|
|
139
174
|
- Before treating a prior finding as resolved, verify that the fix did not introduce a different structural or contract problem
|
|
140
175
|
|
|
@@ -240,6 +275,7 @@ The review target is the entire cumulative diff from the task's starting point (
|
|
|
240
275
|
- Use `order.md`, `plan.md`, and the actual code as primary sources
|
|
241
276
|
- Treat decisions from earlier steps (prior review results, planning decisions) as supplementary
|
|
242
277
|
- When information conflicts, prioritize `order.md` / `plan.md` / actual code
|
|
278
|
+
- When a user-facing specification changes, treat documentation and configuration examples as part of the contract and verify that every behavior listed in the requirements is present
|
|
243
279
|
|
|
244
280
|
### Referring to Design Decisions
|
|
245
281
|
|
|
@@ -247,6 +283,19 @@ The review target is the entire cumulative diff from the task's starting point (
|
|
|
247
283
|
- Do not dismiss intentional decisions as false positives just because they were recorded. Evaluate validity against `order.md` / `plan.md` / actual code
|
|
248
284
|
- If the design decision itself is flawed, raise it
|
|
249
285
|
|
|
286
|
+
### Full Entry Review for Contract Additions and Changes
|
|
287
|
+
|
|
288
|
+
When the diff adds or changes a contract such as a config value, state, condition expression, file format, event, builder, adapter, or state-transition function, enumerate and reconcile every entry, exit, and re-injection path that can carry that contract.
|
|
289
|
+
|
|
290
|
+
- Verify that definition, production, normalization, validation, evaluation, persistence, output, and event emission all apply the same contract
|
|
291
|
+
- Check derived paths as well as the normal entry: derived conditions, aggregate conditions, parent/child workflows, loop decisions, early exits, and exception paths
|
|
292
|
+
- When persisted data or externally supplied data is re-injected into JSON, Markdown, logs, events, or later instructions, include escaping, boundary handling, and failure behavior in the contract
|
|
293
|
+
- Search for existing returns, throws, catches, early returns, branches, and call sites with the same responsibility
|
|
294
|
+
- If an existing branch does not satisfy the new contract, treat it as related code even if the code itself predates the change
|
|
295
|
+
- If tests cover only the new path and do not verify existing equivalent branches or derived entries, treat it as a coverage gap
|
|
296
|
+
- Treating a required contract as optional, excluded, or a different requirement requires evidence from the task spec, specification, or explicit user instruction
|
|
297
|
+
- "Not explicitly stated in the task requirements" is not a valid reason to mark a contract inconsistency introduced by the diff as non-blocking
|
|
298
|
+
|
|
250
299
|
### Reviewing Side Effects and State Transitions
|
|
251
300
|
|
|
252
301
|
When a change involves side effects or state changes such as external calls, configuration application, sessions, queues, locks, subscriptions, caches, or temporary resources, do not judge from the happy path alone.
|
|
@@ -259,11 +308,18 @@ When a change involves side effects or state changes such as external calls, con
|
|
|
259
308
|
|
|
260
309
|
### Tracking Findings from Previous Reviews
|
|
261
310
|
|
|
262
|
-
|
|
263
|
-
|
|
264
|
-
- `
|
|
265
|
-
|
|
266
|
-
|
|
311
|
+
**Precedence:**
|
|
312
|
+
|
|
313
|
+
1. If a parseable Finding Contract ledger / `findings-ledger.json` is available in a workflow configured with Finding Contract, use the ledger as the authoritative source for tracked findings. Fix only open findings from the ledger (`new`, `persists`, or `reopened`); ignore resolved or closed findings. Treat individual reports as supporting evidence reachable from the ledger.
|
|
314
|
+
2. If a ledger exists but is incomplete, follow mapped findings from the ledger and treat unmapped raw findings as potential new entries pending findings-manager reconciliation.
|
|
315
|
+
3. If the workflow is configured with Finding Contract but no parseable ledger is available, use the latest review reports in the Report Directory only as supporting evidence for observed raw findings. Do not assign final `finding_id` values or lifecycle states and do not apply the legacy rules; wait for ledger regeneration or findings-manager reconciliation.
|
|
316
|
+
4. If the workflow does not use `finding_contract` configuration, use the latest review reports in the Report Directory as the primary evidence and apply the legacy rules:
|
|
317
|
+
- Look in the Report Directory for review reports this step has previously produced, along with their timestamped history
|
|
318
|
+
- Treat the unsuffixed file as the latest result and the most recent `{report-name}.{timestamp}` as the previous result
|
|
319
|
+
- `Previous Response` may be used as supplementary information, but finding state determinations must prioritize the report history
|
|
320
|
+
- Do not drop open findings from the previous report when producing the new report
|
|
321
|
+
- Apply the `finding_id` management rules when classifying each finding as `new` / `persists` / `resolved` / `reopened`
|
|
322
|
+
- Mark `resolved` only when the original expected result and original requirement are satisfied, not merely because a patch exists
|
|
267
323
|
|
|
268
324
|
### Final Decision Steps
|
|
269
325
|
|
|
@@ -273,12 +329,4 @@ When a change involves side effects or state changes such as external calls, con
|
|
|
273
329
|
|
|
274
330
|
## Detecting Circular Arguments
|
|
275
331
|
|
|
276
|
-
When the same kind of issue keeps recurring, reconsider the approach itself rather than repeating
|
|
277
|
-
|
|
278
|
-
### When the Same Problem Recurs
|
|
279
|
-
|
|
280
|
-
1. Check if the same kind of issue is being repeated
|
|
281
|
-
2. If so, propose an alternative approach instead of granular fix instructions
|
|
282
|
-
3. Even when rejecting, include the perspective of "a different approach should be considered"
|
|
283
|
-
|
|
284
|
-
Rather than repeating "fix this again," stop and suggest a different path.
|
|
332
|
+
When the same kind of issue keeps recurring, reconsider the approach itself rather than repeating granular fix instructions.
|
|
@@ -13,6 +13,7 @@ Every behavior change requires a corresponding test, and every bug fix requires
|
|
|
13
13
|
| Type safety | Code must pass the build (type check) |
|
|
14
14
|
| Reproducibility | Do not depend on time or randomness. Same result every run |
|
|
15
15
|
| Do not freeze non-executable assets | Do not make prose or section structure that does not define runtime behavior a CI failure condition |
|
|
16
|
+
| Verify negative contracts at observable units | Do not pass prohibition, rejection, non-inheritance, or unsupported cases by exact-string absence alone |
|
|
16
17
|
|
|
17
18
|
## Coverage Criteria
|
|
18
19
|
|
|
@@ -22,6 +23,8 @@ Every behavior change requires a corresponding test, and every bug fix requires
|
|
|
22
23
|
| Bug fix | Regression test required. REJECT if missing |
|
|
23
24
|
| Behavior change | Test update required. REJECT if missing |
|
|
24
25
|
| Side-effect or state-transition change | Successful path and representative failure paths must be verified. REJECT if failure paths are untested |
|
|
26
|
+
| Contract changes through consolidation or abstraction | Must verify that the contract holds on existing equivalent branches, not only on the new shared path |
|
|
27
|
+
| Parser or configuration boundary changes | Must verify syntactically valid inputs with unexpected shapes, missing values, and isolation from personal configuration |
|
|
25
28
|
| Build (type check) | Build must succeed. REJECT if it fails |
|
|
26
29
|
| Edge cases / boundary values | Test recommended (Warning) |
|
|
27
30
|
|
|
@@ -100,6 +103,55 @@ Changes involving side effects or state transitions are not sufficiently verifie
|
|
|
100
103
|
| Mock-verified behavior is not distinguished from unverified real-integration scope | Warning. REJECT when it is a primary requirement |
|
|
101
104
|
| Successful path, representative failure paths, and boundary state transitions are each verified | OK |
|
|
102
105
|
|
|
106
|
+
## Testing Contract Changes and Existing Branches
|
|
107
|
+
|
|
108
|
+
When a change standardizes a contract through a shared helper, normalizer, builder, or adapter, testing only the newly added path is not sufficient. Verify that existing equivalent branches satisfy the same contract.
|
|
109
|
+
|
|
110
|
+
| Criteria | Verdict |
|
|
111
|
+
|----------|---------|
|
|
112
|
+
| Only the new shared path is tested, while existing equivalent branches are not verified for the same return value, side effect, or error contract | REJECT |
|
|
113
|
+
| An existing branch is treated as "preserved behavior" without verifying that it does not conflict with the contract introduced by the diff | REJECT |
|
|
114
|
+
| Return / throw / catch / early return paths in the changed function are not enumerated, causing representative failure paths to be missed | REJECT |
|
|
115
|
+
| Existing branches with the same responsibility have tests for return values, side effects, events, and error classification contracts | OK |
|
|
116
|
+
|
|
117
|
+
## Contract Test Sufficiency
|
|
118
|
+
|
|
119
|
+
When adding or changing a config value, runtime-selected capability, backend, option, permission, or output contract, tests must prove the branch conditions that change the contract, not merely that a value exists.
|
|
120
|
+
|
|
121
|
+
| Criteria | Verdict |
|
|
122
|
+
|----------|---------|
|
|
123
|
+
| Only the happy path for a new option is verified | Warning |
|
|
124
|
+
| Requirement-relevant branches among unset, set, invalid value, inherited, non-inherited, override, and unsupported target are not verified | REJECT |
|
|
125
|
+
| A user-facing display or validation entry is not verified to follow the same contract as the primary execution path | REJECT |
|
|
126
|
+
| A test only checks displayed values without verifying they match the resolution input used during execution | REJECT |
|
|
127
|
+
| Absence is verified only by exact string matching, missing order, case, whitespace, or partial-leak differences | REJECT |
|
|
128
|
+
| Boundary values that may be normalized at configuration boundaries, such as empty strings, whitespace-only strings, empty arrays, or case variants, are not tested | Warning. REJECT when this is a primary contract branch |
|
|
129
|
+
| The path from entry point to final call verifies happy, rejection, and non-inheritance cases | OK |
|
|
130
|
+
|
|
131
|
+
## Testing Negative, Non-Inheritance, and Rejection Contracts
|
|
132
|
+
|
|
133
|
+
Tests for prohibition, rejection, non-inheritance, unsupported targets, and isolation must not rely only on a specific string being absent from the whole output.
|
|
134
|
+
Extract observable units such as output lines, records, fields, or call arguments, then verify each forbidden value cannot leak through order, case, whitespace, delimiter, or partial-match differences.
|
|
135
|
+
|
|
136
|
+
| Criteria | Verdict |
|
|
137
|
+
|----------|---------|
|
|
138
|
+
| Exact-string absence alone is used to conclude that a forbidden or non-inherited value was not used | REJECT |
|
|
139
|
+
| Only allowed-value presence is checked, without proving rejected, forbidden, or non-inherited values do not reach final processing | REJECT |
|
|
140
|
+
| Observable units such as output lines, events, records, fields, or call arguments are extracted and checked per forbidden value | OK |
|
|
141
|
+
| Allowed vs rejected and inherited vs non-inherited cases are tested as pairs | OK |
|
|
142
|
+
| A new E2E test does not follow existing same-kind conventions for timeout, cleanup, and forced termination | Warning. REJECT when it can cause process leaks or flakes |
|
|
143
|
+
|
|
144
|
+
## Parser and Configuration Boundary Tests
|
|
145
|
+
|
|
146
|
+
At boundaries that read external files, configuration, YAML/JSON, or CLI input, testing only the ideal typed input is not sufficient.
|
|
147
|
+
|
|
148
|
+
| Criteria | Verdict |
|
|
149
|
+
|----------|---------|
|
|
150
|
+
| Array-like fields are not tested with object/null/missing values | REJECT |
|
|
151
|
+
| File/directory checks are not tested with an existing regular file, broken link, or permission error | REJECT |
|
|
152
|
+
| Tests that can inherit existing user or machine configuration do not isolate with an empty config directory or temporary HOME | REJECT |
|
|
153
|
+
| Syntactically valid but contract-invalid shapes are pinned to ignore, normalize, or explicit-error behavior | OK |
|
|
154
|
+
|
|
103
155
|
## Test Data and Fixtures
|
|
104
156
|
|
|
105
157
|
Test data should explicitly generate the minimum facts needed by each test. Mutating shared fixtures or using mocks that drift from real contracts reduces test reliability.
|
|
@@ -24,6 +24,7 @@ workflow_categories:
|
|
|
24
24
|
workflows:
|
|
25
25
|
- backend
|
|
26
26
|
- backend-mini
|
|
27
|
+
- backend-maintenance
|
|
27
28
|
- backend-cqrs
|
|
28
29
|
- backend-cqrs-mini
|
|
29
30
|
🔧 Dual:
|
|
@@ -61,6 +62,7 @@ workflow_categories:
|
|
|
61
62
|
🎵 TAKT Development:
|
|
62
63
|
workflows:
|
|
63
64
|
- takt-default
|
|
65
|
+
- takt-default-with-fc
|
|
64
66
|
- takt-default-refresh-all
|
|
65
67
|
- takt-default-refresh-fast
|
|
66
68
|
- auto-improvement-loop
|
|
@@ -23,6 +23,8 @@ loop_monitors:
|
|
|
23
23
|
|
|
24
24
|
steps:
|
|
25
25
|
- name: plan
|
|
26
|
+
tags:
|
|
27
|
+
- plan
|
|
26
28
|
persona: planner
|
|
27
29
|
knowledge:
|
|
28
30
|
- backend
|
|
@@ -40,6 +42,8 @@ steps:
|
|
|
40
42
|
next: ABORT
|
|
41
43
|
|
|
42
44
|
- name: audit
|
|
45
|
+
tags:
|
|
46
|
+
- review
|
|
43
47
|
persona: architecture-reviewer
|
|
44
48
|
policy: review
|
|
45
49
|
knowledge:
|
|
@@ -60,6 +64,8 @@ steps:
|
|
|
60
64
|
next: supervise
|
|
61
65
|
|
|
62
66
|
- name: supervise
|
|
67
|
+
tags:
|
|
68
|
+
- review
|
|
63
69
|
persona: supervisor
|
|
64
70
|
policy: review
|
|
65
71
|
knowledge:
|
|
@@ -75,6 +81,8 @@ steps:
|
|
|
75
81
|
next: review
|
|
76
82
|
|
|
77
83
|
- name: review
|
|
84
|
+
tags:
|
|
85
|
+
- review
|
|
78
86
|
persona: architecture-reviewer
|
|
79
87
|
policy: review
|
|
80
88
|
knowledge:
|
|
@@ -23,6 +23,8 @@ loop_monitors:
|
|
|
23
23
|
|
|
24
24
|
steps:
|
|
25
25
|
- name: plan
|
|
26
|
+
tags:
|
|
27
|
+
- plan
|
|
26
28
|
persona: planner
|
|
27
29
|
knowledge:
|
|
28
30
|
- frontend
|
|
@@ -41,6 +43,8 @@ steps:
|
|
|
41
43
|
next: ABORT
|
|
42
44
|
|
|
43
45
|
- name: audit
|
|
46
|
+
tags:
|
|
47
|
+
- review
|
|
44
48
|
persona: architecture-reviewer
|
|
45
49
|
policy: review
|
|
46
50
|
knowledge:
|
|
@@ -62,6 +66,8 @@ steps:
|
|
|
62
66
|
next: supervise
|
|
63
67
|
|
|
64
68
|
- name: supervise
|
|
69
|
+
tags:
|
|
70
|
+
- review
|
|
65
71
|
persona: supervisor
|
|
66
72
|
policy: review
|
|
67
73
|
knowledge:
|
|
@@ -78,6 +84,8 @@ steps:
|
|
|
78
84
|
next: review
|
|
79
85
|
|
|
80
86
|
- name: review
|
|
87
|
+
tags:
|
|
88
|
+
- review
|
|
81
89
|
persona: architecture-reviewer
|
|
82
90
|
policy: review
|
|
83
91
|
knowledge:
|
|
@@ -23,6 +23,8 @@ loop_monitors:
|
|
|
23
23
|
|
|
24
24
|
steps:
|
|
25
25
|
- name: plan
|
|
26
|
+
tags:
|
|
27
|
+
- plan
|
|
26
28
|
persona: planner
|
|
27
29
|
knowledge:
|
|
28
30
|
- frontend
|
|
@@ -41,6 +43,8 @@ steps:
|
|
|
41
43
|
next: ABORT
|
|
42
44
|
|
|
43
45
|
- name: audit
|
|
46
|
+
tags:
|
|
47
|
+
- review
|
|
44
48
|
persona: frontend-reviewer
|
|
45
49
|
policy: review
|
|
46
50
|
knowledge:
|
|
@@ -62,6 +66,8 @@ steps:
|
|
|
62
66
|
next: supervise
|
|
63
67
|
|
|
64
68
|
- name: supervise
|
|
69
|
+
tags:
|
|
70
|
+
- review
|
|
65
71
|
persona: supervisor
|
|
66
72
|
policy: review
|
|
67
73
|
knowledge:
|
|
@@ -78,6 +84,8 @@ steps:
|
|
|
78
84
|
next: review
|
|
79
85
|
|
|
80
86
|
- name: review
|
|
87
|
+
tags:
|
|
88
|
+
- review
|
|
81
89
|
persona: frontend-reviewer
|
|
82
90
|
policy: review
|
|
83
91
|
knowledge:
|