takt 0.45.0 → 0.46.0

package/builtins/en/facets/policies/testing.md

@@ -21,6 +21,7 @@ Every behavior change requires a corresponding test, and every bug fix requires
 | New behavior | Test required. REJECT if missing |
 | Bug fix | Regression test required. REJECT if missing |
 | Behavior change | Test update required. REJECT if missing |
+| Side-effect or state-transition change | Successful path and representative failure paths must be verified. REJECT if failure paths are untested |
 | Build (type check) | Build must succeed. REJECT if it fails |
 | Edge cases / boundary values | Test recommended (Warning) |
 
@@ -51,6 +52,18 @@ These assets change often during wording improvements and reorganization, so mak
 
 Verify non-executable asset changes with review, Markdown lint, link checks, or sample command execution when needed.
 
+## Tests for Replaced Old Specifications
+
+When a specification change replaces elements of an old design (UI, API, events, state, labels, etc.) with a new design, tests must positively verify the new behavior. Do not freeze only the absence of the old specification.
+
+| Criteria | Verdict |
+|----------|---------|
+| Adding a test that only verifies elements of the old specification are not present or not called | REJECT |
+| Keeping an absence-only test from the old specification in an implementation unit that no longer owns the responsibility | REJECT |
+| Changing only tests in a file whose production code has no final diff, solely to negate the old specification | REJECT |
+| Positively verifying the new specification in the layer that owns the new responsibility (upper module, service, integration flow, etc.) | OK |
+| Deleting obsolete tests for removed old behavior and replacing them with regression tests for the new specification | OK |
+
 ## Test Structure: Given-When-Then
 
 ```typescript
@@ -75,6 +88,18 @@ test('should return NotFound error when user does not exist', async () => {
 | Clarity | Failure cause is obvious | Failure cause is unclear |
 | Focus | One test, one concept | Multiple concerns mixed |
 
+## Testing Side Effects and State Transitions
+
+Changes involving side effects or state transitions are not sufficiently verified by successful-path coverage alone.
+
+| Criteria | Verdict |
+|----------|---------|
+| Only the successful path is tested, with no verification of state after failure, interruption, or early exit | REJECT |
+| Cleanup or duplicate execution for acquired, started, registered, or applied state is not verified | REJECT |
+| A change affects shared state or downstream execution but does not verify rerun behavior after partial failure | Warning. REJECT when it affects a primary path |
+| Mock-verified behavior is not distinguished from unverified real-integration scope | Warning. REJECT when it is a primary requirement |
+| Successful path, representative failure paths, and boundary state transitions are each verified | OK |
+
 ## Test Data and Fixtures
 
 Test data should explicitly generate the minimum facts needed by each test. Mutating shared fixtures or using mocks that drift from real contracts reduces test reliability.

package/builtins/en/workflows/backend-cqrs.yaml

@@ -335,6 +335,27 @@ steps:
           report:
             - name: qa-review.md
               format: qa-review
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/backend.yaml

@@ -331,6 +331,27 @@ steps:
           report:
             - name: qa-review.md
               format: qa-review
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/default-high.yaml

@@ -1,5 +1,5 @@
 name: default-high
-description: Full-spec development workflow (plan -> write tests -> draft (team-leader implement + AI self-review) -> peer-review (5 parallel + AP-2nd) -> supervise -> COMPLETE).
+description: Full-spec development workflow (plan -> write tests -> draft (team-leader implement + AI self-review) -> peer-review (parallel review + AP-2nd) -> supervise -> COMPLETE).
 workflow_config:
   provider_options:
     codex:

package/builtins/en/workflows/default-peer-review.yaml

@@ -1,5 +1,5 @@
 name: default-peer-review
-description: default series Phase 2. Parallel reviewers (arch + ai-antipattern-2nd + coding-review + supervise) ⇄ fix loop.
+description: default series Phase 2. Parallel reviewers (arch + ai-antipattern-2nd + pure-review + coding-review + supervise) ⇄ fix loop.
 subworkflow:
   callable: true
   visibility: internal
@@ -72,6 +72,27 @@ steps:
           report:
             - name: ai-antipattern-review.md
               format: ai-antipattern-review
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer
@@ -119,9 +140,9 @@ steps:
               format: summary
               use_judge: false
     rules:
-      - condition: all("approved", "No AI-specific issues", "approved", "All checks passed")
+      - condition: all("approved", "No AI-specific issues", "approved", "approved", "All checks passed")
         next: COMPLETE
-      - condition: any("needs_fix", "AI-specific issues found", "needs_fix", "Requirements unmet, tests failing, build errors")
+      - condition: any("needs_fix", "AI-specific issues found", "needs_fix", "needs_fix", "Requirements unmet, tests failing, build errors")
         next: fix
   - name: fix
     edit: true

package/builtins/en/workflows/draft.yaml

@@ -51,16 +51,7 @@ steps:
     knowledge:
       $param: impl_knowledge
     provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - Edit
-          - Write
-          - Bash
-          - WebSearch
-          - WebFetch
+      $ref: provider-options/edit.yaml
     required_permission_mode: edit
     team_leader:
       max_parts: 2
@@ -101,13 +92,7 @@ steps:
       - review
       - ai-antipattern
     provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - WebSearch
-          - WebFetch
+      $ref: provider-options/review-web.yaml
     rules:
       - condition: No AI-specific issues
         next: COMPLETE
@@ -128,16 +113,7 @@ steps:
     knowledge:
       $param: fix_knowledge
     provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - Edit
-          - Write
-          - Bash
-          - WebSearch
-          - WebFetch
+      $ref: provider-options/edit.yaml
     required_permission_mode: edit
     pass_previous_response: false
     rules:
@@ -153,11 +129,7 @@ steps:
     persona: architecture-reviewer
     policy: review
     provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
+      $ref: provider-options/review-files.yaml
     rules:
       - condition: ai-antipattern-review-1st's findings are valid (fix required)
         next: ai-antipattern-fix

package/builtins/en/workflows/dual-cqrs.yaml

@@ -295,6 +295,27 @@ steps:
           report:
             - name: ai-antipattern-review.md
               format: ai-antipattern-review
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/dual.yaml

@@ -400,9 +400,9 @@ steps:
           report:
             - name: qa-review.md
               format: qa-review
-      - name: requirements-review
+      - name: pure-review
         edit: false
-        persona: requirements-reviewer
+        persona: pure-reviewer
         policy: review
         provider_options:
           claude:
@@ -416,11 +416,11 @@ steps:
         rules:
           - condition: approved
           - condition: needs_fix
-        instruction: review-requirements
+        instruction: review-pure
         output_contracts:
           report:
-            - name: requirements-review.md
-              format: requirements-review
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/frontend-maintenance.yaml

@@ -397,6 +397,27 @@ steps:
               format: qa-review
         knowledge:
           - existing-system
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/frontend.yaml

@@ -365,6 +365,27 @@ steps:
           report:
             - name: qa-review.md
               format: qa-review
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/peer-review.yaml

@@ -43,14 +43,7 @@ steps:
         knowledge:
           $param: arch_knowledge
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         rules:
           - condition: approved
           - condition: needs_fix
@@ -65,14 +58,7 @@ steps:
         policy: review
         knowledge: security
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         rules:
           - condition: approved
           - condition: needs_fix
@@ -88,14 +74,7 @@ steps:
           - review
           - qa
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         rules:
           - condition: approved
           - condition: needs_fix
@@ -114,14 +93,7 @@ steps:
           - unit-testing
           - e2e-testing
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         rules:
           - condition: approved
           - condition: needs_fix
@@ -130,41 +102,27 @@ steps:
           report:
             - name: testing-review.md
               format: testing-review
-      - name: requirements-review
+      - name: pure-review
         edit: false
-        persona: requirements-reviewer
+        persona: pure-reviewer
         policy: review
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         rules:
           - condition: approved
           - condition: needs_fix
-        instruction: review-requirements
+        instruction: review-pure
         output_contracts:
           report:
-            - name: requirements-review.md
-              format: requirements-review
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer
         policy: review
         pass_previous_response: false
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - Bash
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-readonly.yaml
         instruction: review-coding
         rules:
           - condition: approved
@@ -180,13 +138,7 @@ steps:
           - review
           - ai-antipattern
         provider_options:
-          claude:
-            allowed_tools:
-              - Read
-              - Glob
-              - Grep
-              - WebSearch
-              - WebFetch
+          $ref: provider-options/review-web.yaml
         instruction: ai-antipattern-review
         rules:
           - condition: approved
@@ -210,16 +162,7 @@ steps:
       - takt
       - architecture
     provider_options:
-      claude:
-        allowed_tools:
-          - Read
-          - Glob
-          - Grep
-          - Edit
-          - Write
-          - Bash
-          - WebSearch
-          - WebFetch
+      $ref: provider-options/edit.yaml
     required_permission_mode: edit
     pass_previous_response: false
     rules:

package/builtins/en/workflows/provider-options/edit.yaml

@@ -0,0 +1,21 @@
+claude:
+  allowed_tools:
+    - Read
+    - Glob
+    - Grep
+    - Edit
+    - Write
+    - Bash
+    - WebSearch
+    - WebFetch
+opencode:
+  allowed_tools:
+    - read
+    - glob
+    - grep
+    - edit
+    - write
+    - bash
+    - todowrite
+    - websearch
+    - webfetch

package/builtins/en/workflows/provider-options/review-files.yaml

@@ -0,0 +1,10 @@
+claude:
+  allowed_tools:
+    - Read
+    - Glob
+    - Grep
+opencode:
+  allowed_tools:
+    - read
+    - glob
+    - grep

package/builtins/en/workflows/provider-options/review-readonly.yaml

@@ -0,0 +1,16 @@
+claude:
+  allowed_tools:
+    - Read
+    - Glob
+    - Grep
+    - Bash
+    - WebSearch
+    - WebFetch
+opencode:
+  allowed_tools:
+    - read
+    - glob
+    - grep
+    - bash
+    - websearch
+    - webfetch

package/builtins/en/workflows/provider-options/review-web.yaml

@@ -0,0 +1,14 @@
+claude:
+  allowed_tools:
+    - Read
+    - Glob
+    - Grep
+    - WebSearch
+    - WebFetch
+opencode:
+  allowed_tools:
+    - read
+    - glob
+    - grep
+    - websearch
+    - webfetch

package/builtins/en/workflows/review-backend-cqrs.yaml

@@ -128,6 +128,27 @@ steps:
           - condition: approved
           - condition: needs_fix
 
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/review-backend.yaml

@@ -104,6 +104,27 @@ steps:
           - condition: approved
           - condition: needs_fix
 
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer

package/builtins/en/workflows/review-default.yaml

@@ -136,9 +136,9 @@ steps:
           - condition: approved
           - condition: needs_fix
 
-      - name: requirements-review
+      - name: pure-review
         edit: false
-        persona: requirements-reviewer
+        persona: pure-reviewer
         policy: review
         provider_options:
           claude:
@@ -149,11 +149,11 @@ steps:
               - Bash
               - WebSearch
               - WebFetch
-        instruction: review-requirements
+        instruction: review-pure
         output_contracts:
           report:
-            - name: requirements-review.md
-              format: requirements-review
+            - name: pure-review.md
+              format: pure-review
         rules:
           - condition: approved
           - condition: needs_fix
@@ -216,7 +216,7 @@ steps:
          - `02-security-review.md` (Security review)
          - `03-qa-review.md` (QA review)
          - `04-testing-review.md` (Testing review)
-         - `05-requirements-review.md` (Requirements review)
+         - `05-pure-review.md` (Requirements review)
          - `06-coding-review.md` (Coding review)
       2. Synthesize the 6 review results
       3. Produce a consolidated review summary with overall verdict

package/builtins/en/workflows/review-dual-cqrs.yaml

@@ -153,6 +153,27 @@ steps:
           - condition: approved
           - condition: needs_fix
 
+      - name: pure-review
+        edit: false
+        persona: pure-reviewer
+        policy: review
+        provider_options:
+          claude:
+            allowed_tools:
+              - Read
+              - Glob
+              - Grep
+              - Bash
+              - WebSearch
+              - WebFetch
+        rules:
+          - condition: approved
+          - condition: needs_fix
+        instruction: review-pure
+        output_contracts:
+          report:
+            - name: pure-review.md
+              format: pure-review
       - name: coding-review
         edit: false
         persona: coding-reviewer