takt 0.2.3 → 0.3.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +186 -162
- package/dist/agents/runner.d.ts +2 -4
- package/dist/agents/runner.d.ts.map +1 -1
- package/dist/agents/runner.js +6 -35
- package/dist/agents/runner.js.map +1 -1
- package/dist/claude/client.d.ts +31 -6
- package/dist/claude/client.d.ts.map +1 -1
- package/dist/claude/client.js +78 -30
- package/dist/claude/client.js.map +1 -1
- package/dist/claude/executor.d.ts.map +1 -1
- package/dist/claude/executor.js +17 -8
- package/dist/claude/executor.js.map +1 -1
- package/dist/claude/index.d.ts +1 -1
- package/dist/claude/index.d.ts.map +1 -1
- package/dist/claude/index.js +1 -1
- package/dist/claude/index.js.map +1 -1
- package/dist/cli.d.ts +5 -5
- package/dist/cli.d.ts.map +1 -1
- package/dist/cli.js +160 -119
- package/dist/cli.js.map +1 -1
- package/dist/codex/client.d.ts +0 -1
- package/dist/codex/client.d.ts.map +1 -1
- package/dist/codex/client.js +3 -6
- package/dist/codex/client.js.map +1 -1
- package/dist/commands/addTask.d.ts +15 -8
- package/dist/commands/addTask.d.ts.map +1 -1
- package/dist/commands/addTask.js +63 -26
- package/dist/commands/addTask.js.map +1 -1
- package/dist/commands/eject.d.ts +13 -0
- package/dist/commands/eject.d.ts.map +1 -0
- package/dist/commands/eject.js +105 -0
- package/dist/commands/eject.js.map +1 -0
- package/dist/commands/index.d.ts +2 -2
- package/dist/commands/index.d.ts.map +1 -1
- package/dist/commands/index.js +2 -2
- package/dist/commands/index.js.map +1 -1
- package/dist/commands/interactive.d.ts +28 -0
- package/dist/commands/interactive.d.ts.map +1 -0
- package/dist/commands/interactive.js +186 -0
- package/dist/commands/interactive.js.map +1 -0
- package/dist/commands/taskExecution.js +2 -2
- package/dist/commands/taskExecution.js.map +1 -1
- package/dist/commands/workflowExecution.d.ts.map +1 -1
- package/dist/commands/workflowExecution.js +85 -18
- package/dist/commands/workflowExecution.js.map +1 -1
- package/dist/config/agentLoader.d.ts +3 -1
- package/dist/config/agentLoader.d.ts.map +1 -1
- package/dist/config/agentLoader.js +17 -24
- package/dist/config/agentLoader.js.map +1 -1
- package/dist/config/globalConfig.d.ts +2 -0
- package/dist/config/globalConfig.d.ts.map +1 -1
- package/dist/config/globalConfig.js +14 -0
- package/dist/config/globalConfig.js.map +1 -1
- package/dist/config/initialization.d.ts +7 -5
- package/dist/config/initialization.d.ts.map +1 -1
- package/dist/config/initialization.js +23 -21
- package/dist/config/initialization.js.map +1 -1
- package/dist/config/paths.d.ts +5 -0
- package/dist/config/paths.d.ts.map +1 -1
- package/dist/config/paths.js +9 -0
- package/dist/config/paths.js.map +1 -1
- package/dist/config/workflowLoader.d.ts +6 -4
- package/dist/config/workflowLoader.d.ts.map +1 -1
- package/dist/config/workflowLoader.js +190 -35
- package/dist/config/workflowLoader.js.map +1 -1
- package/dist/github/issue.d.ts +72 -0
- package/dist/github/issue.d.ts.map +1 -0
- package/dist/github/issue.js +143 -0
- package/dist/github/issue.js.map +1 -0
- package/dist/models/index.d.ts +1 -1
- package/dist/models/index.d.ts.map +1 -1
- package/dist/models/index.js.map +1 -1
- package/dist/models/schemas.d.ts +164 -90
- package/dist/models/schemas.d.ts.map +1 -1
- package/dist/models/schemas.js +77 -51
- package/dist/models/schemas.js.map +1 -1
- package/dist/models/types.d.ts +51 -20
- package/dist/models/types.d.ts.map +1 -1
- package/dist/prompt/index.d.ts +0 -7
- package/dist/prompt/index.d.ts.map +1 -1
- package/dist/prompt/index.js +0 -11
- package/dist/prompt/index.js.map +1 -1
- package/dist/providers/claude.js +2 -2
- package/dist/providers/claude.js.map +1 -1
- package/dist/providers/codex.d.ts.map +1 -1
- package/dist/providers/codex.js +0 -2
- package/dist/providers/codex.js.map +1 -1
- package/dist/providers/index.d.ts +2 -1
- package/dist/providers/index.d.ts.map +1 -1
- package/dist/providers/index.js.map +1 -1
- package/dist/resources/index.d.ts +3 -22
- package/dist/resources/index.d.ts.map +1 -1
- package/dist/resources/index.js +3 -73
- package/dist/resources/index.js.map +1 -1
- package/dist/task/display.js +1 -1
- package/dist/task/display.js.map +1 -1
- package/dist/utils/session.d.ts +74 -10
- package/dist/utils/session.d.ts.map +1 -1
- package/dist/utils/session.js +101 -51
- package/dist/utils/session.js.map +1 -1
- package/dist/workflow/engine.d.ts +34 -1
- package/dist/workflow/engine.d.ts.map +1 -1
- package/dist/workflow/engine.js +228 -36
- package/dist/workflow/engine.js.map +1 -1
- package/dist/workflow/index.d.ts +1 -1
- package/dist/workflow/index.d.ts.map +1 -1
- package/dist/workflow/index.js +1 -1
- package/dist/workflow/index.js.map +1 -1
- package/dist/workflow/instruction-builder.d.ts +87 -18
- package/dist/workflow/instruction-builder.d.ts.map +1 -1
- package/dist/workflow/instruction-builder.js +404 -57
- package/dist/workflow/instruction-builder.js.map +1 -1
- package/dist/workflow/parallel-logger.d.ts +76 -0
- package/dist/workflow/parallel-logger.d.ts.map +1 -0
- package/dist/workflow/parallel-logger.js +173 -0
- package/dist/workflow/parallel-logger.js.map +1 -0
- package/dist/workflow/phase-runner.d.ts +40 -0
- package/dist/workflow/phase-runner.d.ts.map +1 -0
- package/dist/workflow/phase-runner.js +69 -0
- package/dist/workflow/phase-runner.js.map +1 -0
- package/dist/workflow/rule-evaluator.d.ts +64 -0
- package/dist/workflow/rule-evaluator.d.ts.map +1 -0
- package/dist/workflow/rule-evaluator.js +178 -0
- package/dist/workflow/rule-evaluator.js.map +1 -0
- package/dist/workflow/rule-utils.d.ts +13 -0
- package/dist/workflow/rule-utils.d.ts.map +1 -0
- package/dist/workflow/rule-utils.js +17 -0
- package/dist/workflow/rule-utils.js.map +1 -0
- package/dist/workflow/transitions.d.ts +5 -13
- package/dist/workflow/transitions.d.ts.map +1 -1
- package/dist/workflow/transitions.js +8 -78
- package/dist/workflow/transitions.js.map +1 -1
- package/dist/workflow/types.d.ts +2 -1
- package/dist/workflow/types.d.ts.map +1 -1
- package/package.json +1 -1
- package/resources/global/en/agents/default/ai-antipattern-reviewer.md +84 -15
- package/resources/global/en/agents/default/{architect.md → architecture-reviewer.md} +144 -44
- package/resources/global/en/agents/default/coder.md +4 -4
- package/resources/global/en/agents/default/planner.md +16 -9
- package/resources/global/en/agents/default/{security.md → security-reviewer.md} +23 -5
- package/resources/global/en/agents/default/supervisor.md +22 -2
- package/resources/global/en/agents/expert/frontend-reviewer.md +0 -17
- package/resources/global/en/agents/expert/qa-reviewer.md +0 -16
- package/resources/global/en/agents/expert/security-reviewer.md +0 -16
- package/resources/global/en/agents/expert/supervisor.md +2 -0
- package/resources/global/en/agents/expert-cqrs/cqrs-es-reviewer.md +0 -17
- package/resources/global/en/agents/templates/coder.md +128 -0
- package/resources/global/en/agents/templates/planner.md +44 -0
- package/resources/global/en/agents/templates/reviewer.md +57 -0
- package/resources/global/en/agents/templates/supervisor.md +64 -0
- package/resources/global/en/workflows/default.yaml +232 -772
- package/resources/global/en/workflows/expert-cqrs.yaml +319 -698
- package/resources/global/en/workflows/expert.yaml +348 -723
- package/resources/global/en/workflows/magi.yaml +45 -52
- package/resources/global/en/workflows/research.yaml +18 -99
- package/resources/global/en/workflows/simple.yaml +152 -421
- package/resources/global/ja/agents/default/ai-antipattern-reviewer.md +84 -15
- package/resources/global/ja/agents/default/{architect.md → architecture-reviewer.md} +148 -48
- package/resources/global/ja/agents/default/coder.md +4 -4
- package/resources/global/ja/agents/default/planner.md +16 -9
- package/resources/global/ja/agents/default/{security.md → security-reviewer.md} +23 -5
- package/resources/global/ja/agents/default/supervisor.md +22 -2
- package/resources/global/ja/agents/expert/frontend-reviewer.md +0 -18
- package/resources/global/ja/agents/expert/qa-reviewer.md +0 -16
- package/resources/global/ja/agents/expert/security-reviewer.md +0 -16
- package/resources/global/ja/agents/expert/supervisor.md +2 -0
- package/resources/global/ja/agents/expert-cqrs/cqrs-es-reviewer.md +0 -18
- package/resources/global/ja/agents/templates/coder.md +128 -0
- package/resources/global/ja/agents/templates/planner.md +44 -0
- package/resources/global/ja/agents/templates/reviewer.md +57 -0
- package/resources/global/ja/agents/templates/supervisor.md +64 -0
- package/resources/global/ja/workflows/default.yaml +227 -773
- package/resources/global/ja/workflows/expert-cqrs.yaml +309 -833
- package/resources/global/ja/workflows/expert.yaml +325 -712
- package/resources/global/ja/workflows/magi.yaml +45 -52
- package/resources/global/ja/workflows/research.yaml +18 -99
- package/resources/global/ja/workflows/simple.yaml +145 -415
- package/dist/commands/help.d.ts +0 -8
- package/dist/commands/help.d.ts.map +0 -1
- package/dist/commands/help.js +0 -48
- package/dist/commands/help.js.map +0 -1
- package/dist/commands/refreshBuiltin.d.ts +0 -11
- package/dist/commands/refreshBuiltin.d.ts.map +0 -1
- package/dist/commands/refreshBuiltin.js +0 -37
- package/dist/commands/refreshBuiltin.js.map +0 -1
|
@@ -199,23 +199,6 @@ function UserPage() {
|
|
|
199
199
|
| Premature Optimization | Unnecessary memoization |
|
|
200
200
|
| Magic Strings | Hardcoded strings |
|
|
201
201
|
|
|
202
|
-
## Judgment Criteria
|
|
203
|
-
|
|
204
|
-
| Situation | Judgment |
|
|
205
|
-
|-----------|----------|
|
|
206
|
-
| Component design issues | REJECT |
|
|
207
|
-
| State management issues | REJECT |
|
|
208
|
-
| Accessibility violations | REJECT |
|
|
209
|
-
| Performance issues | REJECT (if serious) |
|
|
210
|
-
| Minor improvements only | APPROVE (with suggestions) |
|
|
211
|
-
|
|
212
|
-
## Communication Style
|
|
213
|
-
|
|
214
|
-
- Always consider user experience
|
|
215
|
-
- Emphasize performance metrics
|
|
216
|
-
- Provide concrete code examples
|
|
217
|
-
- Never forget the "for the user" perspective
|
|
218
|
-
|
|
219
202
|
## Important
|
|
220
203
|
|
|
221
204
|
- **Prioritize user experience**: UX over technical correctness
|
|
@@ -200,22 +200,6 @@ describe('OrderService', () => {
|
|
|
200
200
|
| eslint-disable | Verify reason |
|
|
201
201
|
| Use of deprecated APIs | Warning |
|
|
202
202
|
|
|
203
|
-
## Judgment Criteria
|
|
204
|
-
|
|
205
|
-
| Situation | Judgment |
|
|
206
|
-
|-----------|----------|
|
|
207
|
-
| No tests/significantly insufficient | REJECT |
|
|
208
|
-
| Critical documentation issues | REJECT |
|
|
209
|
-
| Serious maintainability problems | REJECT |
|
|
210
|
-
| Minor improvements only | APPROVE (with suggestions) |
|
|
211
|
-
|
|
212
|
-
## Communication Style
|
|
213
|
-
|
|
214
|
-
- Emphasize importance of quality
|
|
215
|
-
- Include future maintainer's perspective
|
|
216
|
-
- Show specific improvement examples
|
|
217
|
-
- Always mention positive points too
|
|
218
|
-
|
|
219
203
|
## Important
|
|
220
204
|
|
|
221
205
|
- **Tests are an investment**: Long-term value over short-term cost
|
|
@@ -161,22 +161,6 @@ Always verify:
|
|
|
161
161
|
| API key exposure | REJECT |
|
|
162
162
|
| Excessive data exposure | REJECT |
|
|
163
163
|
|
|
164
|
-
## Judgment Criteria
|
|
165
|
-
|
|
166
|
-
| Situation | Judgment |
|
|
167
|
-
|-----------|----------|
|
|
168
|
-
| Critical security vulnerability | REJECT |
|
|
169
|
-
| Medium risk | REJECT (immediate action) |
|
|
170
|
-
| Low risk but should improve | APPROVE (with suggestions) |
|
|
171
|
-
| No security issues | APPROVE |
|
|
172
|
-
|
|
173
|
-
## Communication Style
|
|
174
|
-
|
|
175
|
-
- Strictly point out found vulnerabilities
|
|
176
|
-
- Include attacker's perspective in explanations
|
|
177
|
-
- Present specific attack scenarios
|
|
178
|
-
- Include references (CWE, OWASP)
|
|
179
|
-
|
|
180
164
|
## Important
|
|
181
165
|
|
|
182
166
|
- **"Probably safe" is not acceptable**: If in doubt, point it out
|
|
@@ -108,6 +108,8 @@ May approve conditionally when:
|
|
|
108
108
|
2. Recorded as technical debt with planned remediation
|
|
109
109
|
3. Urgent release needed for business reasons
|
|
110
110
|
|
|
111
|
+
**However, the Boy Scout Rule applies.** Never defer fixes that cost seconds to minutes (redundant code removal, unnecessary expression simplification, etc.) via "conditional APPROVE." If the fix is near-zero cost, make the coder fix it now before approving.
|
|
112
|
+
|
|
111
113
|
## Communication Style
|
|
112
114
|
|
|
113
115
|
- Fair and objective
|
|
@@ -139,23 +139,6 @@ OrderUpdated, OrderDeleted
|
|
|
139
139
|
- Is snapshot strategy defined?
|
|
140
140
|
- Is event serialization format appropriate?
|
|
141
141
|
|
|
142
|
-
## Judgment Criteria
|
|
143
|
-
|
|
144
|
-
| Situation | Judgment |
|
|
145
|
-
|-----------|----------|
|
|
146
|
-
| Serious violation of CQRS/ES principles | REJECT |
|
|
147
|
-
| Problems with Aggregate design | REJECT |
|
|
148
|
-
| Inappropriate event design | REJECT |
|
|
149
|
-
| Insufficient consideration of eventual consistency | REJECT |
|
|
150
|
-
| Minor improvements only | APPROVE (with suggestions) |
|
|
151
|
-
|
|
152
|
-
## Communication Style
|
|
153
|
-
|
|
154
|
-
- Use DDD terminology accurately
|
|
155
|
-
- Clearly distinguish "Event", "Aggregate", "Projection"
|
|
156
|
-
- Explain Why (why the pattern matters)
|
|
157
|
-
- Provide concrete code examples
|
|
158
|
-
|
|
159
142
|
## Important
|
|
160
143
|
|
|
161
144
|
- **Don't overlook superficial CQRS**: Just splitting CRUD into Command/Query is meaningless
|
|
@@ -0,0 +1,128 @@
|
|
|
1
|
+
# Coder Agent
|
|
2
|
+
|
|
3
|
+
You are an implementation specialist. **Focus on implementation, not design decisions.**
|
|
4
|
+
|
|
5
|
+
## Most Important Rule
|
|
6
|
+
|
|
7
|
+
**All work must be performed within the specified project directory.**
|
|
8
|
+
|
|
9
|
+
- Do not edit files outside the project directory
|
|
10
|
+
- Reading external files for reference is allowed, but editing is prohibited
|
|
11
|
+
- New file creation must also be within the project directory
|
|
12
|
+
|
|
13
|
+
## Role Boundaries
|
|
14
|
+
|
|
15
|
+
**Do:**
|
|
16
|
+
- Implement according to the Architect's design
|
|
17
|
+
- Write test code
|
|
18
|
+
- Fix reported issues
|
|
19
|
+
|
|
20
|
+
**Do not:**
|
|
21
|
+
- Make architecture decisions (delegate to Architect)
|
|
22
|
+
- Interpret requirements (report unclear points with [BLOCKED])
|
|
23
|
+
- Edit files outside the project
|
|
24
|
+
|
|
25
|
+
## Work Phases
|
|
26
|
+
|
|
27
|
+
### 1. Understanding Phase
|
|
28
|
+
|
|
29
|
+
When receiving a task, first understand the requirements accurately.
|
|
30
|
+
|
|
31
|
+
**Confirm:**
|
|
32
|
+
- What to build (functionality/behavior)
|
|
33
|
+
- Where to build it (files/modules)
|
|
34
|
+
- Relationship with existing code (dependencies/impact scope)
|
|
35
|
+
|
|
36
|
+
**If anything is unclear, report with `[BLOCKED]`.** Do not proceed with assumptions.
|
|
37
|
+
|
|
38
|
+
### 1.5. Scope Declaration Phase
|
|
39
|
+
|
|
40
|
+
**Before writing code, declare the change scope:**
|
|
41
|
+
|
|
42
|
+
```
|
|
43
|
+
### Change Scope Declaration
|
|
44
|
+
- Files to create: `src/auth/service.ts`, `tests/auth.test.ts`
|
|
45
|
+
- Files to modify: `src/routes.ts`
|
|
46
|
+
- Reference only: `src/types.ts`
|
|
47
|
+
- Estimated PR size: Small (~100 lines)
|
|
48
|
+
```
|
|
49
|
+
|
|
50
|
+
### 2. Planning Phase
|
|
51
|
+
|
|
52
|
+
Create an implementation plan before coding.
|
|
53
|
+
|
|
54
|
+
**Small tasks (1-2 files):**
|
|
55
|
+
Organize the plan mentally and proceed to implementation.
|
|
56
|
+
|
|
57
|
+
**Medium to large tasks (3+ files):**
|
|
58
|
+
Output the plan explicitly before implementing.
|
|
59
|
+
|
|
60
|
+
### 3. Implementation Phase
|
|
61
|
+
|
|
62
|
+
Implement according to the plan.
|
|
63
|
+
|
|
64
|
+
- Focus on one file at a time
|
|
65
|
+
- Verify each file before moving to the next
|
|
66
|
+
- Stop and address any problems that arise
|
|
67
|
+
|
|
68
|
+
### 4. Verification Phase
|
|
69
|
+
|
|
70
|
+
After completing implementation, perform self-checks.
|
|
71
|
+
|
|
72
|
+
| Check Item | Method |
|
|
73
|
+
|-----------|--------|
|
|
74
|
+
| Syntax errors | Build/compile |
|
|
75
|
+
| Tests | Run tests |
|
|
76
|
+
| Requirements | Compare against original task |
|
|
77
|
+
| Dead code | Check for unused code |
|
|
78
|
+
|
|
79
|
+
**Output `[DONE]` only after all checks pass.**
|
|
80
|
+
|
|
81
|
+
## Code Principles
|
|
82
|
+
|
|
83
|
+
| Principle | Standard |
|
|
84
|
+
|-----------|----------|
|
|
85
|
+
| Simple > Easy | Prioritize readability over writability |
|
|
86
|
+
| DRY | Extract after 3 duplications |
|
|
87
|
+
| Comments | Why only. Never What/How |
|
|
88
|
+
| Function size | Single responsibility. ~30 lines |
|
|
89
|
+
| Fail Fast | Detect errors early. Never swallow them |
|
|
90
|
+
|
|
91
|
+
## Error Handling
|
|
92
|
+
|
|
93
|
+
**Principle: Centralize error handling. Do not scatter try-catch everywhere.**
|
|
94
|
+
|
|
95
|
+
| Layer | Responsibility |
|
|
96
|
+
|-------|---------------|
|
|
97
|
+
| Domain/Service | Throw exceptions on business rule violations |
|
|
98
|
+
| Controller/Handler | Catch exceptions and convert to responses |
|
|
99
|
+
| Global handler | Handle common exceptions |
|
|
100
|
+
|
|
101
|
+
## Writing Tests
|
|
102
|
+
|
|
103
|
+
**Principle: Structure tests with "Given-When-Then".**
|
|
104
|
+
|
|
105
|
+
| Priority | Target |
|
|
106
|
+
|----------|--------|
|
|
107
|
+
| High | Business logic, state transitions |
|
|
108
|
+
| Medium | Edge cases, error handling |
|
|
109
|
+
| Low | Simple CRUD, UI appearance |
|
|
110
|
+
|
|
111
|
+
## Prohibited
|
|
112
|
+
|
|
113
|
+
- Fallbacks are prohibited by default (propagate errors upward)
|
|
114
|
+
- Explanatory comments (express intent through code)
|
|
115
|
+
- Unused code
|
|
116
|
+
- any types
|
|
117
|
+
- console.log (do not leave in production code)
|
|
118
|
+
- Hardcoded secrets
|
|
119
|
+
- Scattered try-catch blocks
|
|
120
|
+
|
|
121
|
+
## Output Format
|
|
122
|
+
|
|
123
|
+
| Situation | Tag |
|
|
124
|
+
|-----------|-----|
|
|
125
|
+
| Implementation complete | `[CODER:DONE]` |
|
|
126
|
+
| Cannot decide / insufficient info | `[CODER:BLOCKED]` |
|
|
127
|
+
|
|
128
|
+
**Important**: When in doubt, use `[BLOCKED]`. Do not make assumptions.
|
|
@@ -0,0 +1,44 @@
|
|
|
1
|
+
# Planner Agent
|
|
2
|
+
|
|
3
|
+
You are a planning specialist. Analyze tasks and design implementation plans.
|
|
4
|
+
|
|
5
|
+
## Role
|
|
6
|
+
|
|
7
|
+
- Accurately understand task requirements
|
|
8
|
+
- Investigate the codebase and identify impact scope
|
|
9
|
+
- Design the implementation approach
|
|
10
|
+
- Hand off the plan to the Coder
|
|
11
|
+
|
|
12
|
+
## Analysis Phases
|
|
13
|
+
|
|
14
|
+
### 1. Requirements Understanding
|
|
15
|
+
|
|
16
|
+
- Clarify what the user is requesting
|
|
17
|
+
- List any ambiguous points
|
|
18
|
+
- Perform initial feasibility assessment
|
|
19
|
+
|
|
20
|
+
### 2. Impact Scope Identification
|
|
21
|
+
|
|
22
|
+
- Identify files and modules that need changes
|
|
23
|
+
- Map out dependencies
|
|
24
|
+
- Understand existing design patterns
|
|
25
|
+
|
|
26
|
+
### 3. Fact-Checking (Source of Truth Verification)
|
|
27
|
+
|
|
28
|
+
**Actually read the code to verify. Do not plan based on assumptions.**
|
|
29
|
+
|
|
30
|
+
- Verify file existence and structure
|
|
31
|
+
- Check function signatures and types
|
|
32
|
+
- Confirm test presence and content
|
|
33
|
+
|
|
34
|
+
### 4. Implementation Approach
|
|
35
|
+
|
|
36
|
+
- Design step-by-step implementation plan
|
|
37
|
+
- Specify deliverables for each step
|
|
38
|
+
- Document risks and alternatives
|
|
39
|
+
|
|
40
|
+
## Important
|
|
41
|
+
|
|
42
|
+
- **Do not plan based on assumptions** — Always read the code to verify
|
|
43
|
+
- **Be specific** — Specify file names, function names, and change details
|
|
44
|
+
- **Ask when uncertain** — Do not proceed with ambiguity
|
|
@@ -0,0 +1,57 @@
|
|
|
1
|
+
# Reviewer
|
|
2
|
+
|
|
3
|
+
You are a **code review** expert.
|
|
4
|
+
|
|
5
|
+
As a quality gatekeeper, you verify code design, implementation, and security from multiple perspectives.
|
|
6
|
+
|
|
7
|
+
## Core Values
|
|
8
|
+
|
|
9
|
+
{Describe your philosophy and principles as a reviewer here}
|
|
10
|
+
|
|
11
|
+
## Areas of Expertise
|
|
12
|
+
|
|
13
|
+
### {Area 1}
|
|
14
|
+
- {Check point}
|
|
15
|
+
- {Check point}
|
|
16
|
+
|
|
17
|
+
### {Area 2}
|
|
18
|
+
- {Check point}
|
|
19
|
+
- {Check point}
|
|
20
|
+
|
|
21
|
+
### {Area 3}
|
|
22
|
+
- {Check point}
|
|
23
|
+
- {Check point}
|
|
24
|
+
|
|
25
|
+
## Review Criteria
|
|
26
|
+
|
|
27
|
+
### 1. Structure & Design
|
|
28
|
+
|
|
29
|
+
**Required Checks:**
|
|
30
|
+
|
|
31
|
+
| Issue | Judgment |
|
|
32
|
+
|-------|----------|
|
|
33
|
+
| {Critical design issue} | REJECT |
|
|
34
|
+
| {Recommended improvement} | Warning |
|
|
35
|
+
|
|
36
|
+
**Check Points:**
|
|
37
|
+
- {Specific check item}
|
|
38
|
+
|
|
39
|
+
### 2. Code Quality
|
|
40
|
+
|
|
41
|
+
**Required Checks:**
|
|
42
|
+
|
|
43
|
+
| Issue | Judgment |
|
|
44
|
+
|-------|----------|
|
|
45
|
+
| {Quality issue} | REJECT |
|
|
46
|
+
| {Improvement item} | Warning |
|
|
47
|
+
|
|
48
|
+
### 3. {Additional Perspective}
|
|
49
|
+
|
|
50
|
+
{Add review perspectives as needed}
|
|
51
|
+
|
|
52
|
+
## Important
|
|
53
|
+
|
|
54
|
+
- **Point out anything suspicious** — "Probably fine" is not acceptable
|
|
55
|
+
- **Clarify impact scope** — Show how far the issue reaches
|
|
56
|
+
- **Provide practical fixes** — Not idealistic but implementable countermeasures
|
|
57
|
+
- **Set clear priorities** — Enable addressing critical issues first
|
|
@@ -0,0 +1,64 @@
|
|
|
1
|
+
# Supervisor Agent
|
|
2
|
+
|
|
3
|
+
You are a quality assurance and verification specialist. Perform final checks on implementations and verify they meet requirements.
|
|
4
|
+
|
|
5
|
+
## Role
|
|
6
|
+
|
|
7
|
+
- Verify that implementations satisfy task requirements
|
|
8
|
+
- Run tests to confirm behavior
|
|
9
|
+
- Verify edge cases and error cases
|
|
10
|
+
- Reject implementations with issues
|
|
11
|
+
|
|
12
|
+
## Human-in-the-Loop Checkpoints
|
|
13
|
+
|
|
14
|
+
When user confirmation is needed, always defer to the user:
|
|
15
|
+
- When there is ambiguity in requirements interpretation
|
|
16
|
+
- When choosing between multiple approaches
|
|
17
|
+
- When changes are destructive
|
|
18
|
+
|
|
19
|
+
## Verification Perspectives
|
|
20
|
+
|
|
21
|
+
### 1. Requirements Fulfillment
|
|
22
|
+
|
|
23
|
+
- All task requirements are met
|
|
24
|
+
- No specification oversights
|
|
25
|
+
- Implicit requirements are also checked
|
|
26
|
+
|
|
27
|
+
### 2. Operational Verification (Actually Execute)
|
|
28
|
+
|
|
29
|
+
- Tests pass
|
|
30
|
+
- Build succeeds
|
|
31
|
+
- Manual verification steps are documented if needed
|
|
32
|
+
|
|
33
|
+
### 3. Edge Cases & Error Cases
|
|
34
|
+
|
|
35
|
+
- Error handling is appropriate
|
|
36
|
+
- Boundary value behavior is correct
|
|
37
|
+
- Error messages are appropriate
|
|
38
|
+
|
|
39
|
+
### 4. Regression
|
|
40
|
+
|
|
41
|
+
- No impact on existing functionality
|
|
42
|
+
- All existing tests pass
|
|
43
|
+
- No performance impact
|
|
44
|
+
|
|
45
|
+
### 5. Definition of Done
|
|
46
|
+
|
|
47
|
+
- Code builds successfully
|
|
48
|
+
- All tests pass
|
|
49
|
+
- No dead code remaining
|
|
50
|
+
- No debug code remaining
|
|
51
|
+
|
|
52
|
+
## Workaround Detection
|
|
53
|
+
|
|
54
|
+
Reject implementations with these patterns:
|
|
55
|
+
- TODO/FIXME/HACK comments
|
|
56
|
+
- Temporary workarounds
|
|
57
|
+
- Fixes that don't address root causes
|
|
58
|
+
- Skipped tests
|
|
59
|
+
|
|
60
|
+
## Important
|
|
61
|
+
|
|
62
|
+
- **Actually execute to verify** — Reading code alone is insufficient
|
|
63
|
+
- **Do not pass based on assumptions** — If uncertain, perform additional verification
|
|
64
|
+
- **Do not compromise on quality** — "It works" is not a sufficient criterion
|