takt 0.1.1 → 0.1.2

package/resources/global/en/workflows/default.yaml

@@ -1,47 +1,168 @@
 # Default TAKT Workflow
-# Coder -> Architect Review -> Security Review -> Supervisor Approval
+# Plan -> Coder -> Architect Review -> AI Review -> Security Review -> Supervisor Approval
 
 name: default
-description: Standard development workflow with code review
+description: Standard development workflow with planning and specialized reviews
 
-max_iterations: 10
+max_iterations: 20
+
+initial_step: plan
 
 steps:
+  - name: plan
+    agent: ~/.takt/agents/default/planner.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Bash
+      - WebSearch
+      - WebFetch
+    instruction_template: |
+      ## Workflow Context
+      - Iteration: {iteration}/{max_iterations}
+      - Step: plan (Task Analysis)
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report File: .takt/reports/{report_dir}/00-plan.md
+
+      ## User Request
+      {task}
+
+      ## Previous Response (when returned from implement)
+      {previous_response}
+
+      ## Instructions
+      Analyze the task and create an implementation plan.
+
+      **Note:** If returned from implement step (Previous Response exists),
+      review and revise the plan based on that feedback (replan).
+
+      **Tasks:**
+      1. Understand the requirements
+      2. Identify impact scope
+      3. Decide implementation approach
+
+      **Report output:** Output to the `Report File` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Report format:**
+      ```markdown
+      # Task Plan
+
+      ## Original Request
+      {User's request as-is}
+
+      ## Analysis Results
+
+      ### Objective
+      {What needs to be achieved}
+
+      ### Scope
+      {Impact scope}
+
+      ### Implementation Approach
+      {How to proceed}
+
+      ## Clarifications Needed (if any)
+      - {Unclear points or items requiring confirmation}
+      ```
+
+      Output [PLANNER:DONE] when complete.
+      Output [PLANNER:BLOCKED] if requirements are unclear.
+    pass_previous_response: true
+    transitions:
+      - condition: done
+        next_step: implement
+      - condition: blocked
+        next_step: ABORT
+
   - name: implement
     agent: ~/.takt/agents/default/coder.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Edit
+      - Write
+      - Bash
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
       - Step: implement
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report Files:
+        - Scope: .takt/reports/{report_dir}/01-coder-scope.md
+        - Decisions: .takt/reports/{report_dir}/02-coder-decisions.md
 
-      ## Original User Request (This is the original request from workflow start, not the latest instruction)
+      ## User Request
       {task}
 
-      ## Additional User Inputs (Information added during workflow)
+      ## Additional User Inputs
       {user_inputs}
 
       ## Instructions
-      **Important**: The "Original User Request" above is the initial request from workflow start.
-      If this is iteration 2 or later, research and investigation should already be completed.
-      Review the session conversation history and continue from where you left off.
+      Follow the plan from the plan step and implement.
+      Refer to the plan report (00-plan.md) and proceed with implementation.
+
+      **Report output:** Output to the `Report Files` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Scope report format (create at implementation start):**
+      ```markdown
+      # Change Scope Declaration
+
+      ## Task
+      {One-line task summary}
+
+      ## Planned Changes
+      | Type | File |
+      |------|------|
+      | Create | `src/example.ts` |
+      | Modify | `src/routes.ts` |
 
-      - Iteration 1: Understand the requirements, conduct research if needed
-      - Iteration 2+: Continue implementation based on previous work
+      ## Estimated Size
+      Small / Medium / Large
+
+      ## Impact Scope
+      - {Affected modules or features}
+      ```
+
+      **Decisions report format (on completion, only if decisions were made):**
+      ```markdown
+      # Decision Log
+
+      ## 1. {Decision Content}
+      - **Background**: {Why the decision was needed}
+      - **Options Considered**: {List of options}
+      - **Reason**: {Why this option was chosen}
+      ```
 
       Include [CODER:DONE] when complete.
-      Include [CODER:BLOCKED] if you cannot proceed.
+      Include [CODER:BLOCKED] if you cannot proceed (returns to plan).
     transitions:
       - condition: done
         next_step: review
       - condition: blocked
-        next_step: implement
+        next_step: plan
 
   - name: review
     agent: ~/.takt/agents/default/architect.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
-      - Step: review
+      - Step: review (Architecture Review)
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report File: .takt/reports/{report_dir}/03-architect-review.md
 
       ## Original User Request (Initial request from workflow start)
       {task}
@@ -52,21 +173,222 @@ steps:
       ```
 
       ## Instructions
-      Review the changes and provide feedback. Include:
-      - [ARCHITECT:APPROVE] if the code is ready
-      - [ARCHITECT:REJECT] if changes are needed (list specific issues)
+      Focus on **architecture and design** review. Do NOT review AI-specific issues (that's the next step).
+
+      Review the changes and provide feedback:
+      - [ARCHITECT:APPROVE] if no issues
+      - [ARCHITECT:IMPROVE] if minor improvements needed
+      - [ARCHITECT:REJECT] if structural changes are needed (list specific issues)
+
+      **Report output:** Output to the `Report File` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Report format:**
+      ```markdown
+      # Architecture Review
+
+      ## Result: APPROVE / IMPROVE / REJECT
+
+      ## Summary
+      {1-2 sentences summarizing result}
+
+      ## Reviewed Perspectives
+      - [x] Structure & Design
+      - [x] Code Quality
+      - [x] Change Scope
+
+      ## Issues (if REJECT)
+      | # | Location | Issue | Fix |
+      |---|----------|-------|-----|
+      | 1 | `src/file.ts:42` | Issue description | Fix method |
+
+      ## Improvement Suggestions (optional, non-blocking)
+      - {Future improvement suggestions}
+      ```
+
+      **Cognitive load reduction rules:**
+      - APPROVE + no issues → Summary only (5 lines or less)
+      - APPROVE + minor suggestions → Summary + suggestions (15 lines or less)
+      - REJECT → Issues in table format (30 lines or less)
     transitions:
       - condition: approved
-        next_step: security_review
+        next_step: ai_review
+      - condition: improve
+        next_step: improve
       - condition: rejected
         next_step: fix
 
+  - name: improve
+    agent: ~/.takt/agents/default/coder.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Edit
+      - Write
+      - Bash
+      - WebSearch
+      - WebFetch
+    instruction_template: |
+      ## Workflow Context
+      - Iteration: {iteration}/{max_iterations}
+      - Step: improve
+
+      ## Architect Feedback (This is the latest instruction - prioritize this)
+      {previous_response}
+
+      ## Original User Request (Initial request from workflow start - for reference)
+      {task}
+
+      ## Additional User Inputs
+      {user_inputs}
+
+      ## Instructions
+      **Important**: Address the Architect's improvement suggestions.
+      These are minor improvements, not major design issues.
+
+      Make improvements such as:
+      - Naming improvements
+      - Small refactoring
+      - Adding/fixing comments
+      - Code organization
+
+      Include [CODER:DONE] when complete.
+      Include [CODER:BLOCKED] if you cannot proceed.
+    pass_previous_response: true
+    transitions:
+      - condition: done
+        next_step: review
+      - condition: blocked
+        next_step: plan
+
+  - name: ai_review
+    agent: ~/.takt/agents/default/ai-reviewer.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - WebSearch
+      - WebFetch
+    instruction_template: |
+      ## Workflow Context
+      - Iteration: {iteration}/{max_iterations}
+      - Step: ai_review (AI-Generated Code Review)
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report File: .takt/reports/{report_dir}/04-ai-review.md
+
+      ## Original User Request (Initial request from workflow start)
+      {task}
+
+      ## Git Diff
+      ```diff
+      {git_diff}
+      ```
+
+      ## Instructions
+      Review the code for AI-specific issues:
+      - Assumption validation
+      - Plausible but wrong patterns
+      - Context fit with existing codebase
+      - Scope creep detection
+
+      Include:
+      - [AI_REVIEW:APPROVE] if no AI-specific issues found
+      - [AI_REVIEW:REJECT] if issues detected (list specific problems)
+
+      **Report output:** Output to the `Report File` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Report format:**
+      ```markdown
+      # AI-Generated Code Review
+
+      ## Result: APPROVE / REJECT
+
+      ## Summary
+      {One sentence summarizing result}
+
+      ## Verified Items
+      | Aspect | Result | Notes |
+      |--------|--------|-------|
+      | Assumption validity | ✅ | - |
+      | API/Library existence | ✅ | - |
+      | Context fit | ✅ | - |
+      | Scope | ✅ | - |
+
+      ## Issues (if REJECT)
+      | # | Category | Location | Issue |
+      |---|----------|----------|-------|
+      | 1 | Hallucinated API | `src/file.ts:23` | Non-existent method |
+      ```
+
+      **Cognitive load reduction rules:**
+      - No issues → Summary 1 line + check table only (10 lines or less)
+      - Issues found → + Issues in table format (25 lines or less)
+    transitions:
+      - condition: approved
+        next_step: security_review
+      - condition: rejected
+        next_step: ai_fix
+
+  - name: ai_fix
+    agent: ~/.takt/agents/default/coder.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Edit
+      - Write
+      - Bash
+      - WebSearch
+      - WebFetch
+    instruction_template: |
+      ## Workflow Context
+      - Iteration: {iteration}/{max_iterations}
+      - Step: ai_fix
+
+      ## AI Review Feedback (This is the latest instruction - prioritize this)
+      {previous_response}
+
+      ## Original User Request (Initial request from workflow start - for reference)
+      {task}
+
+      ## Additional User Inputs
+      {user_inputs}
+
+      ## Instructions
+      **Important**: Address the AI Reviewer's feedback.
+      Focus on:
+      - Correcting incorrect assumptions
+      - Fixing plausible-but-wrong implementations
+      - Aligning with existing codebase patterns
+      - Removing scope creep
+
+      Include [CODER:DONE] when complete.
+      Include [CODER:BLOCKED] if you cannot proceed.
+    pass_previous_response: true
+    transitions:
+      - condition: done
+        next_step: review
+      - condition: blocked
+        next_step: plan
+
   - name: security_review
     agent: ~/.takt/agents/default/security.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
       - Step: security_review
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report File: .takt/reports/{report_dir}/05-security-review.md
 
       ## Original User Request (Initial request from workflow start)
       {task}
@@ -86,6 +408,40 @@ steps:
       Include:
       - [SECURITY:APPROVE] if no security issues found
       - [SECURITY:REJECT] if vulnerabilities detected (list specific issues)
+
+      **Report output:** Output to the `Report File` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Report format:**
+      ```markdown
+      # Security Review
+
+      ## Result: APPROVE / REJECT
+
+      ## Severity: None / Low / Medium / High / Critical
+
+      ## Check Results
+      | Category | Result | Notes |
+      |----------|--------|-------|
+      | Injection | ✅ | - |
+      | Auth/Authz | ✅ | - |
+      | Data Protection | ✅ | - |
+      | Dependencies | ✅ | - |
+
+      ## Vulnerabilities (if REJECT)
+      | # | Severity | Type | Location | Fix |
+      |---|----------|------|----------|-----|
+      | 1 | High | SQLi | `src/db.ts:42` | Use parameterized query |
+
+      ## Warnings (non-blocking)
+      - {Security recommendations}
+      ```
+
+      **Cognitive load reduction rules:**
+      - No issues → Check table only (10 lines or less)
+      - Warnings → + Warnings 1-2 lines (15 lines or less)
+      - Vulnerabilities → + Table format (30 lines or less)
     transitions:
       - condition: approved
         next_step: supervise
@@ -94,6 +450,15 @@ steps:
 
   - name: security_fix
     agent: ~/.takt/agents/default/coder.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Edit
+      - Write
+      - Bash
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
@@ -119,10 +484,19 @@ steps:
       - condition: done
         next_step: security_review
       - condition: blocked
-        next_step: security_fix
+        next_step: plan
 
   - name: fix
     agent: ~/.takt/agents/default/coder.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Edit
+      - Write
+      - Bash
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
@@ -149,14 +523,25 @@ steps:
       - condition: done
         next_step: review
       - condition: blocked
-        next_step: fix
+        next_step: plan
 
   - name: supervise
     agent: ~/.takt/agents/default/supervisor.md
+    allowed_tools:
+      - Read
+      - Glob
+      - Grep
+      - Bash
+      - WebSearch
+      - WebFetch
     instruction_template: |
       ## Workflow Context
       - Iteration: {iteration}/{max_iterations}
       - Step: supervise (final verification)
+      - Report Directory: .takt/reports/{report_dir}/
+      - Report Files:
+        - Validation: .takt/reports/{report_dir}/06-supervisor-validation.md
+        - Summary: .takt/reports/{report_dir}/summary.md
 
       ## Original User Request
       {task}
@@ -168,10 +553,78 @@ steps:
 
       ## Instructions
       Run tests, verify the build, and perform final approval.
+
+      **Workflow Overall Review:**
+      1. Does the implementation match the plan (00-plan.md)?
+      2. Were all review step issues addressed?
+      3. Was the original task objective achieved?
+
+      **Review Reports:** Read all reports in Report Directory and
+      check for any unaddressed improvement suggestions.
+
+      **Report output:** Output to the `Report Files` specified above.
+      - If file does not exist: Create new file
+      - If file exists: Append with `## Iteration {iteration}` section
+
+      **Validation report format:**
+      ```markdown
+      # Final Validation Results
+
+      ## Result: APPROVE / REJECT
+
+      ## Validation Summary
+      | Item | Status | Verification Method |
+      |------|--------|---------------------|
+      | Requirements met | ✅ | Matched against requirements list |
+      | Tests | ✅ | `npm test` (N passed) |
+      | Build | ✅ | `npm run build` succeeded |
+      | Functional check | ✅ | Main flows verified |
+
+      ## Deliverables
+      - Created: {Created files}
+      - Modified: {Modified files}
+
+      ## Incomplete Items (if REJECT)
+      | # | Item | Reason |
+      |---|------|--------|
+      | 1 | {Item} | {Reason} |
+      ```
+
+      **Summary report format (only if APPROVE):**
+      ```markdown
+      # Task Completion Summary
+
+      ## Task
+      {Original request in 1-2 sentences}
+
+      ## Result
+      ✅ Complete
+
+      ## Changes
+      | Type | File | Summary |
+      |------|------|---------|
+      | Create | `src/file.ts` | Summary description |
+
+      ## Review Results
+      | Review | Result |
+      |--------|--------|
+      | Architect | ✅ APPROVE |
+      | AI Review | ✅ APPROVE |
+      | Security | ✅ APPROVE |
+      | Supervisor | ✅ APPROVE |
+
+      ## Verification Commands
+      ```bash
+      npm test
+      npm run build
+      ```
+      ```
+
+      Output:
       - [SUPERVISOR:APPROVE] if ready to merge
-      - [SUPERVISOR:REJECT] if issues found
+      - [SUPERVISOR:REJECT] if issues found (specify the issues)
     transitions:
       - condition: approved
         next_step: COMPLETE
       - condition: rejected
-        next_step: fix
+        next_step: plan