tabulator-tables 5.3.0 → 5.3.3

package/src/js/modules/History/History.js

@@ -46,7 +46,7 @@ class History extends Module{
 
 		if(this.table.options.groupBy){
 
-			rows = row.getComponent().getGroup().rows;
+			rows = row.getComponent().getGroup()._getSelf().rows;
 			index = rows.indexOf(row);
 
 			if(index){

package/src/js/modules/Interaction/Interaction.js

@@ -128,7 +128,7 @@ class Interaction extends Module{
 		var range;
 
 		if(this.table.modExists("edit")){
-			if (this.table.modules.edit.currentCell === this){
+			if (this.table.modules.edit.currentCell === cell){
 				return; //prevent instant selection of editor content
 			}
 		}
@@ -138,11 +138,11 @@ class Interaction extends Module{
 		try{
 			if (document.selection) { // IE
 				range = document.body.createTextRange();
-				range.moveToElementText(this.element);
+				range.moveToElementText(cell.getElement());
 				range.select();
 			} else if (window.getSelection) {
 				range = document.createRange();
-				range.selectNode(this.element);
+				range.selectNode(cell.getElement());
 				window.getSelection().removeAllRanges();
 				window.getSelection().addRange(range);
 			}

package/src/js/modules/Layout/defaults/modes/fitColumns.js

@@ -1,6 +1,6 @@
 //resize columns to fit
 export default function(columns, forced){
-	var totalWidth = this.table.element.clientWidth; //table element width
+	var totalWidth = this.table.rowManager.element.getBoundingClientRect().width; //table element width
 	var fixedWidth = 0; //total width of columns with a defined width
 	var flexWidth = 0; //total width available to flexible columns
 	var flexGrowUnits = 0; //total number of widthGrow blocks across all columns
@@ -77,9 +77,7 @@ export default function(columns, forced){
 
 			nextColWidth = changeUnits ? Math.floor(remainingSpace/changeUnits) : remainingSpace;
 
-			gap = remainingSpace - (nextColWidth * changeUnits);
-
-			gap += scaleColumns(undersizeCols, remainingSpace, nextColWidth, shrinkCols);
+			gap = scaleColumns(undersizeCols, remainingSpace, nextColWidth, shrinkCols);
 		}else{
 			gap = changeUnits ? freeSpace - (Math.floor(freeSpace/changeUnits) * changeUnits) : freeSpace;
 
@@ -143,7 +141,7 @@ export default function(columns, forced){
 
 	//increase width of last column to account for rounding errors
 	if(flexColumns.length && gapFill > 0){
-		flexColumns[flexColumns.length-1].width += + gapFill;
+		flexColumns[flexColumns.length-1].width += gapFill;
 	}
 
 	//calculate space for columns to be shrunk into
@@ -159,7 +157,7 @@ export default function(columns, forced){
 	}
 
 	//decrease width of last column to account for rounding errors
-	if(fixedShrinkColumns.length){
+	if(gapFill && fixedShrinkColumns.length){
 		fixedShrinkColumns[fixedShrinkColumns.length-1].width -= gapFill;
 	}
 

package/src/js/modules/Page/Page.js

@@ -21,8 +21,6 @@ class Page extends Module{
 
 		this.remoteRowCountEstimate = null;
 		
-		this.displayIndex = 0; //index in display pipeline
-		
 		this.initialLoad = true;
 		this.dataChanging = false; //flag to check if data is being changed by this module
 		
@@ -470,14 +468,6 @@ class Page extends Module{
 		this.dispatch("page-changed");
 	}
 	
-	setDisplayIndex(index){
-		this.displayIndex = index;
-	}
-	
-	getDisplayIndex(){
-		return this.displayIndex;
-	}
-	
 	//calculate maximum page from number of rows
 	setMaxRows(rowCount){
 		if(!rowCount){
@@ -544,9 +534,9 @@ class Page extends Module{
 	}
 	
 	setPageToRow(row){
-		var rows = this.table.rowManager.getDisplayRows(this.displayIndex - 1);
+		var rows = this.displayRows(-1);
 		var index = rows.indexOf(row);
-		
+	
 		if(index > -1){
 			var page = this.size === true ? 1 : Math.ceil((index + 1) / this.size);
 			

package/src/js/modules/Persistence/Persistence.js

@@ -211,9 +211,10 @@ class Persistence extends Module{
 			keys.forEach((key)=>{
 				var props = Object.getOwnPropertyDescriptor(def, key);
 				var value = def[key];
+
 				if(props){
 					Object.defineProperty(def, key, {
-						set: function(newValue){
+						set: (newValue) => {
 							value = newValue;
 
 							if(!this.defWatcherBlock){
@@ -224,7 +225,7 @@ class Persistence extends Module{
 								props.set(newValue);
 							}
 						},
-						get:function(){
+						get:() => {
 							if(props.get){
 								props.get();
 							}

package/src/js/modules/ResponsiveLayout/ResponsiveLayout.js

@@ -33,8 +33,9 @@ class ResponsiveLayout extends Module{
 			this.subscribe("column-delete", this.initializeResponsivity.bind(this));
 
 			this.subscribe("table-redrawing", this.tableRedraw.bind(this));
-
+			
 			if(this.table.options.responsiveLayout === "collapse"){
+				this.subscribe("row-data-changed", this.generateCollapsedRowContent.bind(this));
 				this.subscribe("row-init", this.initializeRow.bind(this));
 				this.subscribe("row-layout", this.layoutRow.bind(this));
 			}
@@ -341,4 +342,4 @@ class ResponsiveLayout extends Module{
 
 ResponsiveLayout.moduleName = "responsiveLayout";
 
-export default ResponsiveLayout;
+export default ResponsiveLayout;

package/src/js/modules/SelectRow/SelectRow.js

@@ -216,18 +216,22 @@ class SelectRow extends Module{
 				break;
 			
 			case "string":
-			
 				rowMatch = this.table.rowManager.findRow(rows);
 			
 				if(rowMatch){
 					this._selectRow(rowMatch, true, true);
+					this._rowSelectionChanged();
 				}else{
-					this.table.rowManager.getRows(rows).forEach((row) => {
+					rowMatch = this.table.rowManager.getRows(rows);
+					
+					rowMatch.forEach((row) => {
 						this._selectRow(row, true, true);
 					});
+
+					if(rowMatch.length){
+						this._rowSelectionChanged();
+					}
 				}
-			
-				this._rowSelectionChanged();
 				break;
 			
 			default:

package/src/js/modules/Sort/Sort.js

@@ -169,7 +169,6 @@ class Sort extends Module{
 						}
 					}
 
-
 					if (this.table.options.columnHeaderSortMulti && (e.shiftKey || e.ctrlKey)) {
 						sorters = this.getSort();
 
@@ -180,11 +179,9 @@ class Sort extends Module{
 						if(match > -1){
 							sorters[match].dir = dir;
 
-							if(match != sorters.length -1){
-								match = sorters.splice(match, 1)[0];
-								if(dir != "none"){
-									sorters.push(match);
-								}
+							match = sorters.splice(match, 1)[0];
+							if(dir != "none"){
+								sorters.push(match);
 							}
 						}else{
 							if(dir != "none"){
@@ -399,7 +396,7 @@ class Sort extends Module{
 		var sortEl = column.modules.sort.element,
 		arrowEl;
 
-		if(typeof this.table.options.headerSortElement === "function"){
+		if(column.definition.headerSort && typeof this.table.options.headerSortElement === "function"){
 			while(sortEl.firstChild) sortEl.removeChild(sortEl.firstChild);
 
 			arrowEl = this.table.options.headerSortElement.call(this.table, column.getComponent(), dir);

package/src/scss/themes/bootstrap/tabulator_bootstrap3.scss

@@ -99,7 +99,7 @@ $footerActiveColor:#d00 !default; //footer bottom active text color
 
 	&.table-striped{
 		.tabulator-row{
-			&:nth-child(even){
+			&.tabulator-row-even{
 				background-color: $rowAltBackgroundColor;
 			}
 		}

package/src/scss/themes/bootstrap/tabulator_bootstrap4.scss

@@ -234,7 +234,7 @@ $table-cell-padding-sm: 5px;
 	&.table-striped{
 		&:not(.table-dark){
 			.tabulator-row{
-				&:nth-child(even){
+				&.tabulator-row-even{
 					background-color: $rowAltBackgroundColor;
 
 					&.tabulator-selected{

package/src/scss/themes/bootstrap/tabulator_bootstrap5.scss

@@ -235,7 +235,7 @@ $table-cell-padding-sm: 5px;
 	&.table-striped{
 		&:not(.table){
 			.tabulator-row{
-				&:nth-child(even){
+				&.tabulator-row-even{
 					background-color: $rowAltBackgroundColor;
 
 					&.tabulator-selected{