tabulator-tables 5.2.7 → 5.3.2

package/src/js/modules/Accessor/Accessor.js

@@ -1,14 +1,14 @@
 import Module from '../../core/Module.js';
 import Helpers from '../../core/tools/Helpers.js';
 
-import defautlAccessors from './defaults/accessors.js';
+import defaultAccessors from './defaults/accessors.js';
 
 class Accessor extends Module{
 
 	constructor(table){
 		super(table);
 
-		this.allowedTypes = ["", "data", "download", "clipboard", "print", "htmlOutput"] //list of accessor types
+		this.allowedTypes = ["", "data", "download", "clipboard", "print", "htmlOutput"]; //list of accessor types
 
 		this.registerColumnOption("accessor");
 		this.registerColumnOption("accessorParams");
@@ -47,7 +47,7 @@ class Accessor extends Module{
 					config[key] = {
 						accessor:accessor,
 						params: column.definition[key + "Params"] || {},
-					}
+					};
 				}
 			}
 		});
@@ -63,16 +63,16 @@ class Accessor extends Module{
 		//set column accessor
 		switch(typeof value){
 			case "string":
-			if(Accessor.accessors[value]){
-				accessor = Accessor.accessors[value]
-			}else{
-				console.warn("Accessor Error - No such accessor found, ignoring: ", value);
-			}
-			break;
+				if(Accessor.accessors[value]){
+					accessor = Accessor.accessors[value];
+				}else{
+					console.warn("Accessor Error - No such accessor found, ignoring: ", value);
+				}
+				break;
 
 			case "function":
-			accessor = value;
-			break;
+				accessor = value;
+				break;
 		}
 
 		return accessor;
@@ -87,7 +87,7 @@ class Accessor extends Module{
 		var data = Helpers.deepClone(row.data || {});
 
 		this.table.columnManager.traverse(function(column){
-			var value, accessor, params, colCompnent;
+			var value, accessor, params, colComponent;
 
 			if(column.modules.accessor){
 
@@ -97,9 +97,9 @@ class Accessor extends Module{
 					value = column.getFieldValue(data);
 
 					if(value != "undefined"){
-						colCompnent = column.getComponent();
-						params = typeof accessor.params === "function" ? accessor.params(value, data, type, colCompnent, rowComponent) : accessor.params;
-						column.setFieldValue(data, accessor.accessor(value, data, type, params, colCompnent, rowComponent));
+						colComponent = column.getComponent();
+						params = typeof accessor.params === "function" ? accessor.params(value, data, type, colComponent, rowComponent) : accessor.params;
+						column.setFieldValue(data, accessor.accessor(value, data, type, params, colComponent, rowComponent));
 					}
 				}
 			}
@@ -111,6 +111,6 @@ class Accessor extends Module{
 
 //load defaults
 Accessor.moduleName = "accessor";
-Accessor.accessors = defautlAccessors;
+Accessor.accessors = defaultAccessors;
 
 export default Accessor;

package/src/js/modules/Accessor/defaults/accessors.js

@@ -1 +1 @@
-export default {}
+export default {};

package/src/js/modules/Ajax/Ajax.js

@@ -95,7 +95,7 @@ class Ajax extends Module{
 	
 	//load config object
 	generateConfig(config = {}){
-		var ajaxConfig = Object.assign({}, this.config)
+		var ajaxConfig = Object.assign({}, this.config);
 		
 		if(typeof config == "string"){
 			ajaxConfig.method = config;
@@ -120,13 +120,13 @@ class Ajax extends Module{
 	sendRequest(url, params, config){
 		if(this.table.options.ajaxRequesting.call(this.table, url, params) !== false){
 			return this.loaderPromise(url, config, params)
-			.then((data)=>{
-				if(this.table.options.ajaxResponse){
-					data = this.table.options.ajaxResponse.call(this.table, url, params, data);
-				}
+				.then((data)=>{
+					if(this.table.options.ajaxResponse){
+						data = this.table.options.ajaxResponse.call(this.table, url, params, data);
+					}
 				
-				return data;
-			});
+					return data;
+				});
 		}else{
 			return Promise.reject();
 		}

package/src/js/modules/Ajax/defaults/loaderPromise.js

@@ -61,27 +61,27 @@ export default function(url, config, params){
 
 			//send request
 			fetch(url, config)
-			.then((response)=>{
-				if(response.ok) {
-					response.json()
-					.then((data)=>{
-						resolve(data);
-					}).catch((error)=>{
-						reject(error);
-						console.warn("Ajax Load Error - Invalid JSON returned", error);
-					});
-				}else{
-					console.error("Ajax Load Error - Connection Error: " + response.status, response.statusText);
-					reject(response);
-				}
-			})
-			.catch((error)=>{
-				console.error("Ajax Load Error - Connection Error: ", error);
-				reject(error);
-			});
+				.then((response)=>{
+					if(response.ok) {
+						response.json()
+							.then((data)=>{
+								resolve(data);
+							}).catch((error)=>{
+								reject(error);
+								console.warn("Ajax Load Error - Invalid JSON returned", error);
+							});
+					}else{
+						console.error("Ajax Load Error - Connection Error: " + response.status, response.statusText);
+						reject(response);
+					}
+				})
+				.catch((error)=>{
+					console.error("Ajax Load Error - Connection Error: ", error);
+					reject(error);
+				});
 		}else{
 			console.warn("Ajax Load Error - No URL Set");
 			resolve([]);
 		}
 	});
-};
+}

package/src/js/modules/Ajax/defaults/urlGenerator.js

@@ -41,4 +41,4 @@ export default function(url, config, params){
 	}
 
 	return url;
-};
+}

package/src/js/modules/Clipboard/Clipboard.js

@@ -18,7 +18,7 @@ class Clipboard extends Module{
 		this.registerTableOption("clipboard", false); //enable clipboard
 		this.registerTableOption("clipboardCopyStyled", true); //formatted table data
 		this.registerTableOption("clipboardCopyConfig", false); //clipboard config
-		this.registerTableOption("clipboardCopyFormatter", false); //DEPRICATED - REMOVE in 5.0
+		this.registerTableOption("clipboardCopyFormatter", false); //DEPRECATED - REMOVE in 5.0
 		this.registerTableOption("clipboardCopyRowRange", "active"); //restrict clipboard to visible rows only
 		this.registerTableOption("clipboardPasteParser", "table"); //convert pasted clipboard data to rows
 		this.registerTableOption("clipboardPasteAction", "insert"); //how to insert pasted data into the table
@@ -47,9 +47,9 @@ class Clipboard extends Module{
 						}
 					}else{
 
-						var list = this.table.modules.export.generateExportList(this.table.options.clipboardCopyConfig, this.table.options.clipboardCopyStyled, this.rowRange, "clipboard");
+						list = this.table.modules.export.generateExportList(this.table.options.clipboardCopyConfig, this.table.options.clipboardCopyStyled, this.rowRange, "clipboard");
 
-						html = this.table.modules.export.genereateHTMLTable(list);
+						html = this.table.modules.export.generateHTMLTable(list);
 						plain = html ? this.generatePlainContent(list) : "";
 
 						if(this.table.options.clipboardCopyFormatter){
@@ -116,15 +116,15 @@ class Clipboard extends Module{
 					}else{
 						switch(typeof col.value){
 							case "object":
-							value = JSON.stringify(col.value);
-							break;
+								value = JSON.stringify(col.value);
+								break;
 
 							case "undefined":
-							value = "";
-							break;
+								value = "";
+								break;
 
 							default:
-							value = col.value;
+								value = col.value;
 						}
 					}
 				}
@@ -139,7 +139,7 @@ class Clipboard extends Module{
 	}
 
 	copy (range, internal) {
-		var range, sel, textRange;
+		var sel, textRange;
 		this.blocked = false;
 		this.customSelection = false;
 
@@ -177,32 +177,32 @@ class Clipboard extends Module{
 
 		switch(typeof action){
 			case "string":
-			this.pasteAction = Clipboard.pasteActions[action];
+				this.pasteAction = Clipboard.pasteActions[action];
 
-			if(!this.pasteAction){
-				console.warn("Clipboard Error - No such paste action found:", action);
-			}
-			break;
+				if(!this.pasteAction){
+					console.warn("Clipboard Error - No such paste action found:", action);
+				}
+				break;
 
 			case "function":
-			this.pasteAction = action;
-			break;
+				this.pasteAction = action;
+				break;
 		}
 	}
 
 	setPasteParser(parser){
 		switch(typeof parser){
 			case "string":
-			this.pasteParser = Clipboard.pasteParsers[parser];
+				this.pasteParser = Clipboard.pasteParsers[parser];
 
-			if(!this.pasteParser){
-				console.warn("Clipboard Error - No such paste parser found:", parser);
-			}
-			break;
+				if(!this.pasteParser){
+					console.warn("Clipboard Error - No such paste parser found:", parser);
+				}
+				break;
 
 			case "function":
-			this.pasteParser = parser;
-			break;
+				this.pasteParser = parser;
+				break;
 		}
 	}
 

package/src/js/modules/Clipboard/defaults/pasteParsers.js

@@ -1,7 +1,6 @@
 export default {
 	table:function(clipboard){
 		var data = [],
-		success = false,
 		headerFindSuccess = true,
 		columns = this.table.columnManager.columns,
 		columnMap = [],
@@ -15,7 +14,6 @@ export default {
 		});
 
 		if(data.length && !(data.length === 1 && data[0].length < 2)){
-			success = true;
 
 			//check if headers are present by title
 			data[0].forEach(function(value){

package/src/js/modules/ColumnCalcs/CalcComponent.js

@@ -7,10 +7,10 @@ class CalcComponent{
 				if (typeof target[name] !== "undefined") {
 					return target[name];
 				}else{
-					return target._row.table.componentFunctionBinder.handle("row", target._row, name)
+					return target._row.table.componentFunctionBinder.handle("row", target._row, name);
 				}
 			}
-		})
+		});
 	}
 
 	getData(transform){

package/src/js/modules/ColumnCalcs/ColumnCalcs.js

@@ -93,7 +93,7 @@ class ColumnCalcs extends Module{
 
 	rowsUpdated(row){
 		if(this.table.options.groupBy){
-			this.recalcRowGroup(this);
+			this.recalcRowGroup(row);
 		}else{
 			this.recalcActiveRows();
 		}
@@ -135,7 +135,7 @@ class ColumnCalcs extends Module{
 
 	//initialize column calcs
 	initializeColumn(column){
-		var def = column.definition
+		var def = column.definition;
 
 		var config = {
 			topCalcParams:def.topCalcParams || {},
@@ -146,16 +146,16 @@ class ColumnCalcs extends Module{
 
 			switch(typeof def.topCalc){
 				case "string":
-				if(ColumnCalcs.calculations[def.topCalc]){
-					config.topCalc = ColumnCalcs.calculations[def.topCalc]
-				}else{
-					console.warn("Column Calc Error - No such calculation found, ignoring: ", def.topCalc);
-				}
-				break;
+					if(ColumnCalcs.calculations[def.topCalc]){
+						config.topCalc = ColumnCalcs.calculations[def.topCalc];
+					}else{
+						console.warn("Column Calc Error - No such calculation found, ignoring: ", def.topCalc);
+					}
+					break;
 
 				case "function":
-				config.topCalc = def.topCalc;
-				break
+					config.topCalc = def.topCalc;
+					break;
 
 			}
 
@@ -173,16 +173,16 @@ class ColumnCalcs extends Module{
 		if(def.bottomCalc){
 			switch(typeof def.bottomCalc){
 				case "string":
-				if(ColumnCalcs.calculations[def.bottomCalc]){
-					config.botCalc = ColumnCalcs.calculations[def.bottomCalc]
-				}else{
-					console.warn("Column Calc Error - No such calculation found, ignoring: ", def.bottomCalc);
-				}
-				break;
+					if(ColumnCalcs.calculations[def.bottomCalc]){
+						config.botCalc = ColumnCalcs.calculations[def.bottomCalc];
+					}else{
+						console.warn("Column Calc Error - No such calculation found, ignoring: ", def.bottomCalc);
+					}
+					break;
 
 				case "function":
-				config.botCalc = def.bottomCalc;
-				break
+					config.botCalc = def.bottomCalc;
+					break;
 
 			}
 
@@ -199,7 +199,7 @@ class ColumnCalcs extends Module{
 	}
 
 	//dummy functions to handle being mock column manager
-	registerColumnField(){};
+	registerColumnField(){}
 
 	removeCalcs(){
 		var changed = false;
@@ -237,7 +237,11 @@ class ColumnCalcs extends Module{
 
 	scrollHorizontal(left){
 		if(this.botInitialized && this.botRow){
-			this.botRow.getElement().style.marginLeft = (-left) + "px";
+			if(this.table.rtl){
+				this.botRow.getElement().style.marginRight = (left) + "px";
+			}else{
+				this.botRow.getElement().style.marginLeft = (-left) + "px";
+			}	
 		}
 	}
 
@@ -252,7 +256,7 @@ class ColumnCalcs extends Module{
 					this.topRow.deleteCells();
 				}
 
-				row = this.generateRow("top", this.rowsToData(rows))
+				row = this.generateRow("top", data);
 				this.topRow = row;
 				while(this.topElement.firstChild) this.topElement.removeChild(this.topElement.firstChild);
 				this.topElement.appendChild(row.getElement());
@@ -264,7 +268,7 @@ class ColumnCalcs extends Module{
 					this.botRow.deleteCells();
 				}
 
-				row = this.generateRow("bottom", this.rowsToData(rows))
+				row = this.generateRow("bottom", data);
 				this.botRow = row;
 				while(this.botElement.firstChild) this.botElement.removeChild(this.botElement.firstChild);
 				this.botElement.appendChild(row.getElement());
@@ -384,38 +388,38 @@ class ColumnCalcs extends Module{
 
 			this.table.columnManager.columnsByIndex.forEach((column) => {
 
-					//set field name of mock column
-					this.genColumn.setField(column.getField());
-					this.genColumn.hozAlign = column.hozAlign;
+				//set field name of mock column
+				this.genColumn.setField(column.getField());
+				this.genColumn.hozAlign = column.hozAlign;
 
-					if(column.definition[pos + "CalcFormatter"] && this.table.modExists("format")){
-						this.genColumn.modules.format = {
-							formatter: this.table.modules.format.getFormatter(column.definition[pos + "CalcFormatter"]),
-							params: column.definition[pos + "CalcFormatterParams"] || {},
-						};
-					}else{
-						this.genColumn.modules.format = {
-							formatter: this.table.modules.format.getFormatter("plaintext"),
-							params:{}
-						};
-					}
+				if(column.definition[pos + "CalcFormatter"] && this.table.modExists("format")){
+					this.genColumn.modules.format = {
+						formatter: this.table.modules.format.getFormatter(column.definition[pos + "CalcFormatter"]),
+						params: column.definition[pos + "CalcFormatterParams"] || {},
+					};
+				}else{
+					this.genColumn.modules.format = {
+						formatter: this.table.modules.format.getFormatter("plaintext"),
+						params:{}
+					};
+				}
 
-					//ensure css class defintion is replicated to calculation cell
-					this.genColumn.definition.cssClass = column.definition.cssClass;
+				//ensure css class definition is replicated to calculation cell
+				this.genColumn.definition.cssClass = column.definition.cssClass;
 
-					//generate cell and assign to correct column
-					var cell = new Cell(this.genColumn, row);
-					cell.getElement();
-					cell.column = column;
-					cell.setWidth();
+				//generate cell and assign to correct column
+				var cell = new Cell(this.genColumn, row);
+				cell.getElement();
+				cell.column = column;
+				cell.setWidth();
 
-					column.cells.push(cell);
-					cells.push(cell);
+				column.cells.push(cell);
+				cells.push(cell);
 
-					if(!column.visible){
-						cell.hide();
-					}
-				});
+				if(!column.visible){
+					cell.hide();
+				}
+			});
 
 			row.cells = cells;
 		};
@@ -481,7 +485,7 @@ class ColumnCalcs extends Module{
 			results = {
 				top: this.topRow ? this.topRow.getData() : {},
 				bottom: this.botRow ? this.botRow.getData() : {},
-			}
+			};
 		}
 
 		return results;
@@ -502,7 +506,7 @@ class ColumnCalcs extends Module{
 			top: groupObj.calcs.top ? groupObj.calcs.top.getData() : {},
 			bottom: groupObj.calcs.bottom ? groupObj.calcs.bottom.getData() : {},
 			groups: subGroupResults,
-		}
+		};
 
 		return results;
 	}

package/src/js/modules/ColumnCalcs/defaults/calculations.js

@@ -1,7 +1,7 @@
 export default {
 	"avg":function(values, data, calcParams){
 		var output = 0,
-		precision = typeof calcParams.precision !== "undefined" ? calcParams.precision : 2
+		precision = typeof calcParams.precision !== "undefined" ? calcParams.precision : 2;
 
 		if(values.length){
 			output = values.reduce(function(sum, value){

package/src/js/modules/DataTree/DataTree.js

@@ -2,6 +2,8 @@ import Module from '../../core/Module.js';
 
 import Row from '../../core/row/Row.js';
 
+import RowComponent from '../../core/row/RowComponent.js';
+
 class DataTree extends Module{
 
 	constructor(table){
@@ -29,7 +31,7 @@ class DataTree extends Module{
 		this.registerTableOption("dataTreeExpandElement", false);//data tree row expand element
 		this.registerTableOption("dataTreeStartExpanded", false);
 		this.registerTableOption("dataTreeChildColumnCalcs", false);//include visible data tree rows in column calculations
-		this.registerTableOption("dataTreeSelectPropagate", false);//seleccting a parent row selects its children
+		this.registerTableOption("dataTreeSelectPropagate", false);//selecting a parent row selects its children
 
 		//register component functions
 		this.registerComponentFunction("row", "treeCollapse", this.collapseRow.bind(this));
@@ -49,6 +51,10 @@ class DataTree extends Module{
 			this.field = options.dataTreeChildField;
 			this.indent = options.dataTreeChildIndent;
 
+			if(this.options("movableRows")){
+				console.warn("The movableRows option is not available with dataTree enabled, moving of child rows could result in unpredictable behavior");
+			}
+
 			if(options.dataTreeBranchElement){
 
 				if(options.dataTreeBranchElement === true){
@@ -98,20 +104,20 @@ class DataTree extends Module{
 
 			switch(typeof options.dataTreeStartExpanded){
 				case "boolean":
-				this.startOpen = function(row, index){
-					return options.dataTreeStartExpanded;
-				};
-				break;
+					this.startOpen = function(row, index){
+						return options.dataTreeStartExpanded;
+					};
+					break;
 
 				case "function":
-				this.startOpen = options.dataTreeStartExpanded;
-				break;
+					this.startOpen = options.dataTreeStartExpanded;
+					break;
 
 				default:
-				this.startOpen = function(row, index){
-					return options.dataTreeStartExpanded[index];
-				};
-				break;
+					this.startOpen = function(row, index){
+						return options.dataTreeStartExpanded[index];
+					};
+					break;
 			}
 
 			this.subscribe("row-init", this.initializeRow.bind(this));
@@ -257,9 +263,10 @@ class DataTree extends Module{
 
 	generateControlElement(row, el){
 		var config = row.modules.dataTree,
-		el = el || row.getCells()[0].getElement(),
 		oldControl = config.controlEl;
 
+		el = el || row.getCells()[0].getElement();
+
 		if(config.children !== false){
 
 			if(config.open){
@@ -433,7 +440,7 @@ class DataTree extends Module{
 	}
 
 	getTreeParentRoot(row){
-		return row.modules.dataTree.parent ? this.getTreeParentRoot(row.modules.dataTree.parent) : row;
+		return row.modules.dataTree && row.modules.dataTree.parent ? this.getTreeParentRoot(row.modules.dataTree.parent) : row;
 	}
 
 	getFilteredTreeChildren(row){
@@ -540,10 +547,12 @@ class DataTree extends Module{
 						match = match.data;
 					}
 				}
+			}else if(subject === null){
+				match = false;
 			}
 
-		}else if(typeof subject == "undefined" || subject === null){
-			match = false
+		}else if(typeof subject == "undefined"){
+			match = false;
 		}else{
 			//subject should be treated as the index of the row
 			match = parent.data[this.field].find((row) => {

package/src/js/modules/Download/Download.js

@@ -7,7 +7,10 @@ class Download extends Module{
 	constructor(table){
 		super(table);
 
-		this.registerTableOption("downloadReady", function(data, blob){return blob;}); //function to manipulate download data
+		this.registerTableOption("downloadEncoder", function(data, mimeType){
+			return new Blob([data],{type:mimeType});
+		}); //function to manipulate download data
+		this.registerTableOption("downloadReady", undefined); //warn of function deprecation
 		this.registerTableOption("downloadConfig", {}); //download config
 		this.registerTableOption("downloadRowRange", "active"); //restrict download to active rows only
 
@@ -16,10 +19,16 @@ class Download extends Module{
 	}
 
 	initialize(){
+		this.deprecatedOptionsCheck();
+
 		this.registerTableFunction("download", this.download.bind(this));
 		this.registerTableFunction("downloadToTab", this.downloadToTab.bind(this));
 	}
 
+	deprecatedOptionsCheck(){
+		this.deprecationCheck("downloadReady", "downloadEncoder");
+	}	
+
 	///////////////////////////////////
 	///////// Table Functions /////////
 	///////////////////////////////////
@@ -93,16 +102,14 @@ class Download extends Module{
 
 	triggerDownload(data, mime, type, filename, newTab){
 		var element = document.createElement('a'),
-		blob = new Blob([data],{type:mime}),
-		filename = filename || "Tabulator." + (typeof type === "function" ? "txt" : type);
-
-		blob = this.table.options.downloadReady(data, blob);
+		blob = this.table.options.downloadEncoder(data, mime);
 
 		if(blob){
-
 			if(newTab){
 				window.open(window.URL.createObjectURL(blob));
 			}else{
+				filename = filename || "Tabulator." + (typeof type === "function" ? "txt" : type);
+				
 				if(navigator.msSaveOrOpenBlob){
 					navigator.msSaveOrOpenBlob(blob, filename);
 				}else{
@@ -128,8 +135,8 @@ class Download extends Module{
 	commsReceived(table, action, data){
 		switch(action){
 			case "intercept":
-			this.download(data.type, "", data.options, data.active, data.intercept);
-			break;
+				this.download(data.type, "", data.options, data.active, data.intercept);
+				break;
 		}
 	}
 }