tabulator-tables 5.2.4 → 5.2.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tabulator-tables",
-  "version": "5.2.4",
+  "version": "5.2.7",
   "description": "Interactive table generation JavaScript library",
   "style": "dist/css/tabulator.css",
   "main": "dist/js/tabulator.js",

package/src/js/core/RowManager.js

@@ -51,7 +51,7 @@ export default class RowManager extends CoreFeature{
 		
 		el.classList.add("tabulator-tableholder");
 		el.setAttribute("tabindex", 0);
-		el.setAttribute("role", "rowgroup");
+		// el.setAttribute("role", "rowgroup");
 		
 		return el;
 	}

package/src/js/core/Tabulator.js

@@ -50,6 +50,7 @@ class Tabulator {
 		this.optionsList = new OptionsList(this, "table constructor");
 		
 		this.initialized = false;
+		this.destroyed = false;
 		
 		if(this.initializeElement(element)){
 			
@@ -279,6 +280,8 @@ class Tabulator {
 	destroy(){
 		var element = this.element;
 		
+		this.destroyed = true;
+		
 		TableRegistry.deregister(this); //deregister table from inter-device communication
 		
 		this.eventBus.dispatch("table-destroy");

package/src/js/core/cell/Cell.js

@@ -118,7 +118,6 @@ export default class Cell extends CoreFeature{
 			}
 			break;
 			case "undefined":
-			case "null":
 			this.element.innerHTML = "";
 			break;
 			default:
@@ -294,4 +293,4 @@ export default class Cell extends CoreFeature{
 
 		return this.component;
 	}
-}
+}

package/src/js/core/column/Column.js

@@ -158,8 +158,6 @@ class Column extends CoreFeature{
 			}
 		}
 
-		this.contentElement = this._bindEvents();
-
 		this.contentElement = this._buildColumnHeaderContent();
 
 		this.element.appendChild(this.contentElement);
@@ -173,83 +171,6 @@ class Column extends CoreFeature{
 		this.dispatch("column-init", this);
 	}
 
-	_bindEvents(){
-		var def = this.definition,
-		dblTap,	tapHold, tap;
-
-		//setup header click event bindings
-		if(typeof(def.headerClick) == "function"){
-			this.element.addEventListener("click", (e) => {def.headerClick(e, this.getComponent());});
-		}
-
-		if(typeof(def.headerDblClick) == "function"){
-			this.element.addEventListener("dblclick", (e) => {def.headerDblClick(e, this.getComponent());});
-		}
-
-		if(typeof(def.headerContext) == "function"){
-			this.element.addEventListener("contextmenu", (e) => {def.headerContext(e, this.getComponent());});
-		}
-
-		//setup header tap event bindings
-		if(typeof(def.headerTap) == "function"){
-			tap = false;
-
-			this.element.addEventListener("touchstart", (e) => {
-				tap = true;
-			}, {passive: true});
-
-			this.element.addEventListener("touchend", (e) => {
-				if(tap){
-					def.headerTap(e, this.getComponent());
-				}
-
-				tap = false;
-			});
-		}
-
-		if(typeof(def.headerDblTap) == "function"){
-			dblTap = null;
-
-			this.element.addEventListener("touchend", (e) => {
-
-				if(dblTap){
-					clearTimeout(dblTap);
-					dblTap = null;
-
-					def.headerDblTap(e, this.getComponent());
-				}else{
-
-					dblTap = setTimeout(() => {
-						clearTimeout(dblTap);
-						dblTap = null;
-					}, 300);
-				}
-
-			});
-		}
-
-		if(typeof(def.headerTapHold) == "function"){
-			tapHold = null;
-
-			this.element.addEventListener("touchstart", (e) => {
-				clearTimeout(tapHold);
-
-				tapHold = setTimeout(function(){
-					clearTimeout(tapHold);
-					tapHold = null;
-					tap = false;
-					def.headerTapHold(e, this.getComponent());
-				}, 1000);
-
-			}, {passive: true});
-
-			this.element.addEventListener("touchend", (e) => {
-				clearTimeout(tapHold);
-				tapHold = null;
-			});
-		}
-	}
-
 	//build header element for header
 	_buildColumnHeader(){
 		var def = this.definition,
@@ -377,7 +298,6 @@ class Column extends CoreFeature{
 			}
 			break;
 			case "undefined":
-			case "null":
 			el.innerHTML = "";
 			break;
 			default:
@@ -999,4 +919,4 @@ class Column extends CoreFeature{
 
 Column.defaultOptionList = defaultOptions;
 
-export default Column;
+export default Column;

package/src/js/core/rendering/Renderer.js

@@ -186,6 +186,8 @@ export default class Renderer extends CoreFeature{
 						this.elementVertical.scrollTop = this.elementVertical.scrollTop - this.elementVertical.clientHeight + rowEl.offsetHeight;
 					}
 
+					break;
+
 					case "top":
 					this.elementVertical.scrollTop = rowEl.offsetTop;					
 					break;

package/src/js/core/tools/Popup.js

@@ -22,6 +22,14 @@ export default class Popup extends CoreFeature{
         
         this.blurEvent = this.hide.bind(this, false);
         this.escEvent = this._escapeCheck.bind(this);
+
+        this.destroyBinding = this.tableDestroyed;
+        this.destroyed = false;
+    }
+
+    tableDestroyed(){
+        this.destroyed = true;
+        this.hide(true);
     }
     
     _lookupContainer(){
@@ -105,6 +113,10 @@ export default class Popup extends CoreFeature{
     
     show(origin, position){
         var x, y, parentEl, parentOffset, containerOffset, coords;
+
+        if(this.destroyed || this.table.destroyed){
+            return this;
+        }
         
         if(origin instanceof HTMLElement){
             parentEl = origin;
@@ -139,6 +151,12 @@ export default class Popup extends CoreFeature{
         this._fitToScreen(x, y, parentEl, parentOffset, position);
         
         this.visible = true;
+
+        this.subscribe("table-destroy", this.destroyBinding);
+
+        this.element.addEventListener("mousedown", (e) => {
+            e.stopPropagation();
+        })
         
         return this;
     }
@@ -190,8 +208,10 @@ export default class Popup extends CoreFeature{
                 this.subscribe("cell-editing", this.blurEvent);
                 document.body.addEventListener("click", this.blurEvent);
                 document.body.addEventListener("contextmenu", this.blurEvent);
+                document.body.addEventListener("mousedown", this.blurEvent);
                 window.addEventListener("resize", this.blurEvent);
                 document.body.addEventListener("keydown", this.escEvent);
+
             }, 100);
             
             this.blurCallback = callback;
@@ -212,6 +232,7 @@ export default class Popup extends CoreFeature{
                 document.body.removeEventListener("keydown", this.escEvent);
                 document.body.removeEventListener("click", this.blurEvent);
                 document.body.removeEventListener("contextmenu", this.blurEvent);
+                document.body.removeEventListener("mousedown", this.blurEvent);
                 window.removeEventListener("resize", this.blurEvent);
                 this.table.rowManager.element.removeEventListener("scroll", this.blurEvent);
                 this.unsubscribe("cell-editing", this.blurEvent);
@@ -234,6 +255,8 @@ export default class Popup extends CoreFeature{
             if(this.blurCallback && !silent){
                 this.blurCallback();
             }
+
+            this.unsubscribe("table-destroy", this.destroyBinding);
         }
         
         return this;

package/src/js/modules/Download/defaults/downloaders/csv.js

@@ -30,11 +30,10 @@ export default function(list, options, setFileContents){
 
 					switch(typeof col.value){
 						case "object":
-						col.value = JSON.stringify(col.value);
+						col.value = col.value !== null ? JSON.stringify(col.value) : "";
 						break;
 
 						case "undefined":
-						case "null":
 						col.value = "";
 						break;
 					}
@@ -59,4 +58,4 @@ export default function(list, options, setFileContents){
 	}
 
 	setFileContents(fileContents, "text/csv");
-};
+};

package/src/js/modules/Download/defaults/downloaders/pdf.js

@@ -57,11 +57,10 @@ export default function(list, options, setFileContents){
 			if(col){
 				switch(typeof col.value){
 					case "object":
-					col.value = JSON.stringify(col.value);
+					col.value = col.value !== null ? JSON.stringify(col.value) : "";
 					break;
 
 					case "undefined":
-					case "null":
 					col.value = "";
 					break;
 				}
@@ -111,4 +110,4 @@ export default function(list, options, setFileContents){
 	}
 
 	setFileContents(doc.output("arraybuffer"), "application/pdf");
-};
+};

package/src/js/modules/Edit/List.js

@@ -29,6 +29,8 @@ export default class Edit{
         
         this.listIteration = 0;
         
+        this.lastAction="";
+        
         this.blurable = true;
         
         this.actions = {
@@ -70,7 +72,7 @@ export default class Edit{
         this.initialValues = this.params.multiselect ? initialValue : [initialValue];
         
         if(this.isFilter){
-            this.input.value = this.initialValues.join(",");
+            this.input.value = this.initialValues ? this.initialValues.join(",") : "";
             this.headerFilterInitialListGen();            
         }
     }
@@ -159,7 +161,7 @@ export default class Edit{
     _initializeParams(params){
         var valueKeys = ["values", "valuesURL", "valuesLookup"],
         valueCheck;
-
+        
         params = Object.assign({}, params);
         
         params.verticalNavigation = params.verticalNavigation || "editor";
@@ -168,9 +170,9 @@ export default class Edit{
         params.filterDelay = typeof params.filterDelay === "undefined" ? 300 : params.filterDelay;
         
         params.emptyValue = Object.keys(params).includes("emptyValue") ? params.emptyValue : "";
-
+        
         valueCheck = Object.keys(params).filter(key => valueKeys.includes(key)).length;
-
+        
         if(!valueCheck){
             console.warn("list editor config error - either the values, valuesURL, or valuesLookup option must be set")
         }else if(valueCheck > 1){
@@ -370,10 +372,12 @@ export default class Edit{
     }
     
     _keyEnter(e){
-        if(this.focusedItem){
-            this._chooseItem(this.focusedItem);
+        if(this.params.autocomplete && this.lastAction === "typing"){
+            this._resolveValue(true);
         }else{
-            this._cancel();
+            if(this.focusedItem){
+                this._chooseItem(this.focusedItem);
+            }
         }
     }
     
@@ -402,6 +406,7 @@ export default class Edit{
     
     _keyAutoCompLetter(e){
         this._filter();
+        this.lastAction = "typing";
         this.typing = true;
     }
     
@@ -426,6 +431,8 @@ export default class Edit{
     }
     
     _focusItem(item){
+        this.lastAction = "focus";
+        
         if(this.focusedItem && this.focusedItem.element){
             this.focusedItem.element.classList.remove("focused");
         }
@@ -595,6 +602,12 @@ export default class Edit{
             
             this._parseListItem(value, data, 0);
         });
+
+        if(!this.currentItems.length && this.params.freetext){
+            this.input.value = this.initialValues;
+            this.typing = true;
+            this.lastAction = "typing";
+        }
         
         this.data = data;
         
@@ -939,6 +952,8 @@ export default class Edit{
         }else{
             this.currentItems = [item];
             item.selected = true;
+
+            console.log("choose")
             
             this.input.value = item.label;
             

package/src/js/modules/Export/Export.js

@@ -510,11 +510,10 @@ class Export extends Module{
 				}else{
 					switch(typeof value){
 						case "object":
-						value = JSON.stringify(value);
+						value = value !== null ? JSON.stringify(value) : "";
 						break;
 
 						case "undefined":
-						case "null":
 						value = "";
 						break;
 

package/src/js/modules/Interaction/Interaction.js

@@ -1,8 +1,8 @@
 import Module from '../../core/Module.js';
 import Helpers from '../../core/tools/Helpers.js';
 
-import Cell from '../../core/cell/Cell';
-import Column from '../../core/column/Column';
+import Cell from '../../core/cell/Cell.js';
+import Column from '../../core/column/Column.js';
 
 class Interaction extends Module{
 
@@ -311,4 +311,4 @@ class Interaction extends Module{
 
 Interaction.moduleName = "interaction";
 
-export default Interaction;
+export default Interaction;

package/src/js/modules/Page/Page.js

@@ -609,7 +609,6 @@ class Page extends Module{
 				}
 				break;
 				case "undefined":
-				case "null":
 				this.pageCounterElement.innerHTML = "";
 				break;
 				default:
@@ -895,4 +894,4 @@ Page.moduleName = "page";
 //load defaults
 Page.pageCounters = defaultPageCounters;
 
-export default Page;
+export default Page;

package/src/js/modules/ResizeColumns/ResizeColumns.js

@@ -156,7 +156,7 @@ class ResizeColumns extends Module{
 			
 			config.handleEl = handle;
 			
-			if(element.parentNode){
+			if(element.parentNode && column.visible){
 				element.after(handle);			
 			}
 		}

package/src/js/modules/Sort/Sort.js

@@ -378,7 +378,7 @@ class Sort extends Module{
 	//set the column header sort direction
 	setColumnHeader(column, dir){
 		column.modules.sort.dir = dir;
-		column.getElement().setAttribute("aria-sort", dir);
+		column.getElement().setAttribute("aria-sort", dir === "asc" ? "ascending" : "descending");
 	}
 
 	//sort each item in sort list

package/src/scss/tabulator.scss

@@ -244,7 +244,7 @@ $footerActiveColor:#d00 !default; //footer bottom active text color
 					}
 				}
 				
-				&[aria-sort="asc"]{
+				&[aria-sort="ascending"]{
 					.tabulator-col-content .tabulator-col-sorter{
 						color: $sortArrowActive;
 						
@@ -256,7 +256,7 @@ $footerActiveColor:#d00 !default; //footer bottom active text color
 					}
 				}
 				
-				&[aria-sort="desc"]{
+				&[aria-sort="descending"]{
 					.tabulator-col-content .tabulator-col-sorter{
 						color: $sortArrowActive;