tabletcommand-location 2.4.0 → 2.4.1

package/src/test/mock.ts

@@ -1,6 +1,7 @@
 import * as mongoose from "mongoose";
 import {
   BackendModels,
+  AccountIndustry,
   Agency,
   Department,
   convertToObjectId as ObjectId
@@ -15,11 +16,16 @@ export default function(modelsModule: typeof import("tabletcommand-backend-model
     _id: ObjectId(departmentId),
     department: "Test Department",
     accountType: "production",
+    industry: AccountIndustry.Utility,
     shareAVL: {
       enabled: true,
       opAreaName: "Test Area",
       opAreaCode: "TEST",
       fadeZoomLevel: 45000,
+      area: {
+        type: "Polygon",
+        coordinates: [],
+      },
     },
     signupDomains: [],
     signupKey: "abcd",

package/src/test/query.ts

@@ -0,0 +1,209 @@
+import { assert } from "chai";
+import { describe, it, describe as context } from "node:test";
+import {
+  adminListLocations,
+  adminListPersonLocations,
+  adminListUAVLocations,
+  adminListAircraftLocations,
+  adminListSharedLocations,
+  adminListFocusedLocations,
+  syncListSharedLocations,
+  syncListLocations,
+  syncListPersonLocations,
+  syncListAircraftLocations,
+  syncListUAVLocations,
+  metersToRadians,
+} from "../query";
+
+const departmentId = "5195426cc4e016a988000969";
+const movedAt = new Date("2024-01-01T00:00:00.000Z");
+const modifiedDate = new Date("2024-01-02T00:00:00.000Z");
+const longitude = -119.0669;
+const latitude = 34.35264;
+const diagonal = 5000;
+
+describe("query", () => {
+  context("adminListLocations", () => {
+    it("Scopes to the department, excludes uav and person/transponder-tracked records", () => {
+      const { list } = adminListLocations({ departmentId, movedAt });
+      assert.equal(list.active, true);
+      assert.equal(list.departmentId, departmentId);
+      assert.deepEqual(list.kindType, { $ne: "uav" });
+    });
+
+    it("Drops the active filter when showAll is true", () => {
+      const { list } = adminListLocations({ departmentId, movedAt, showAll: true });
+      assert.isUndefined(list.active);
+    });
+
+    it("Keeps the active filter when showAll is not set", () => {
+      const { list } = adminListLocations({ departmentId, movedAt });
+      assert.property(list, "active");
+    });
+  });
+
+  context("adminListPersonLocations", () => {
+    it("Scopes to the department and person kindType", () => {
+      const { list } = adminListPersonLocations({ departmentId, movedAt });
+      assert.equal(list.active, true);
+      assert.equal(list.departmentId, departmentId);
+      assert.equal(list.kindType, "person");
+      assert.deepEqual(list.movedAt, { $gte: movedAt });
+    });
+
+    it("Drops the active filter when showAll is true", () => {
+      const { list } = adminListPersonLocations({ departmentId, movedAt, showAll: true });
+      assert.isUndefined(list.active);
+    });
+  });
+
+  context("adminListUAVLocations", () => {
+    it("Scopes to the department and uav kindType", () => {
+      const { list } = adminListUAVLocations({ departmentId, movedAt });
+      assert.equal(list.active, true);
+      assert.equal(list.departmentId, departmentId);
+      assert.equal(list.kindType, "uav");
+      assert.deepEqual(list.movedAt, { $gte: movedAt });
+    });
+
+    it("Drops the active filter when showAll is true", () => {
+      const { list } = adminListUAVLocations({ departmentId, movedAt, showAll: true });
+      assert.isUndefined(list.active);
+    });
+  });
+
+  context("adminListAircraftLocations", () => {
+    it("Excludes the caller's department and matches shared ADSB aircraft", () => {
+      const { list } = adminListAircraftLocations({ departmentId, movedAt, longitude, latitude, diagonal });
+      assert.equal(list.shared, true);
+      assert.equal(list.active, true);
+      assert.equal(list.source, "ADSB");
+      assert.deepEqual(list.kindType, { $in: ["fixed-wing", "helicopter"] });
+      assert.deepEqual(list.departmentId, { $ne: departmentId });
+    });
+
+    it("Sends movedAt as an ISO string", () => {
+      const { list } = adminListAircraftLocations({ departmentId, movedAt, longitude, latitude, diagonal });
+      assert.deepEqual(list.movedAt, { $gte: movedAt.toISOString() });
+    });
+
+    it("Builds a $centerSphere filter as [longitude, latitude] with the diagonal converted to radians", () => {
+      const { list } = adminListAircraftLocations({ departmentId, movedAt, longitude, latitude, diagonal });
+      assert.deepEqual(list.locationGeoJSON.$geoWithin.$centerSphere, [
+        [longitude, latitude],
+        diagonal / metersToRadians,
+      ]);
+    });
+  });
+
+  context("adminListSharedLocations", () => {
+    it("Excludes the caller's department, ADSB source, and uav kindType", () => {
+      const { list } = adminListSharedLocations({ departmentId, movedAt, longitude, latitude, diagonal });
+      assert.equal(list.shared, true);
+      assert.equal(list.active, true);
+      assert.deepEqual(list.source, { $ne: "ADSB" });
+      assert.deepEqual(list.kindType, { $ne: "uav" });
+      assert.deepEqual(list.departmentId, { $ne: departmentId });
+    });
+  });
+
+  context("adminListFocusedLocations", () => {
+    it("Scopes to the caller's department with a geo filter", () => {
+      const { list } = adminListFocusedLocations({ departmentId, movedAt, longitude, latitude, diagonal });
+      assert.equal(list.active, true);
+      assert.equal(list.departmentId, departmentId);
+      assert.property(list, "locationGeoJSON");
+    });
+
+    it("Drops the geo filter (not active) when showAll is true", () => {
+      const { list } = adminListFocusedLocations({ departmentId, movedAt, longitude, latitude, diagonal, showAll: true });
+      assert.isUndefined(list.locationGeoJSON);
+      assert.equal(list.active, true);
+    });
+  });
+
+  context("syncListSharedLocations", () => {
+    it("Excludes the caller's department and ADSB/DroneSense sources", () => {
+      const { list } = syncListSharedLocations({ departmentId, movedAt, modifiedDate, longitude, latitude, diagonal });
+      assert.equal(list.shared, true);
+      assert.deepEqual(list.source, { $nin: ["ADSB", "DroneSense"] });
+      assert.deepEqual(list.departmentId, { $ne: departmentId });
+      assert.deepEqual(list.modified, { $gte: modifiedDate.toISOString() });
+      assert.deepEqual(list.movedAt, { $gte: movedAt.toISOString() });
+    });
+  });
+
+  context("syncListLocations", () => {
+    it("Scopes to the department, excludes uav and person/transponder-tracked records", () => {
+      const { list } = syncListLocations({ departmentId, movedAt, modifiedDate });
+      assert.equal(list.departmentId, departmentId);
+      assert.deepEqual(list.kindType, { $ne: "uav" });
+      assert.deepEqual(list.modified, { $gte: modifiedDate.toISOString() });
+      assert.deepEqual(list.movedAt, { $gte: movedAt.toISOString() });
+      assert.deepEqual(list.$and, [
+        { $or: [{ personnelUUID: "" }, { personnelUUID: { $exists: false } }] },
+        { $or: [{ transponderUUID: "" }, { transponderUUID: { $exists: false } }] },
+      ]);
+    });
+  });
+
+  context("syncListPersonLocations", () => {
+    it("Scopes to the department and person kindType", () => {
+      const { list } = syncListPersonLocations({ departmentId, movedAt, modifiedDate });
+      assert.equal(list.departmentId, departmentId);
+      assert.equal(list.kindType, "person");
+      assert.deepEqual(list.modified, { $gte: modifiedDate.toISOString() });
+      assert.deepEqual(list.movedAt, { $gte: movedAt.toISOString() });
+    });
+  });
+
+  context("syncListUAVLocations", () => {
+    it("Scopes to the department and uav kindType", () => {
+      const { list } = syncListUAVLocations({ departmentId, movedAt, modifiedDate });
+      assert.equal(list.departmentId, departmentId);
+      assert.equal(list.kindType, "uav");
+      assert.deepEqual(list.modified, { $gte: modifiedDate.toISOString() });
+      assert.deepEqual(list.movedAt, { $gte: movedAt.toISOString() });
+    });
+  });
+
+  context("syncListAircraftLocations", () => {
+    const base = { departmentId, movedAt, modifiedDate };
+
+    it("Matches shared ADSB aircraft, scoped away from the caller's department", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude, latitude, diagonal });
+      assert.equal(list.shared, true);
+      assert.equal(list.source, "ADSB");
+      assert.deepEqual(list.kindType, { $in: ["fixed-wing", "helicopter"] });
+      assert.deepEqual(list.departmentId, { $ne: departmentId });
+    });
+
+    it("Adds a geo filter when given valid, non-zero coordinates", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude, latitude, diagonal });
+      assert.deepEqual(list.locationGeoJSON.$geoWithin.$centerSphere, [
+        [longitude, latitude],
+        diagonal / metersToRadians,
+      ]);
+    });
+
+    it("Omits the geo filter when coordinates are at the origin", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude: 0, latitude: 0, diagonal });
+      assert.isUndefined(list.locationGeoJSON);
+    });
+
+    it("Omits the geo filter when coordinates are within the origin (<= 0.01)", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude: 0.01, latitude: 0.01, diagonal });
+      assert.isUndefined(list.locationGeoJSON);
+    });
+
+    it("Omits the geo filter when latitude is out of range", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude, latitude: 90, diagonal });
+      assert.isUndefined(list.locationGeoJSON);
+    });
+
+    it("Omits the geo filter when longitude is out of range", () => {
+      const { list } = syncListAircraftLocations({ ...base, longitude: 180, latitude, diagonal });
+      assert.isUndefined(list.locationGeoJSON);
+    });
+  });
+});

package/test.sh

@@ -17,7 +17,7 @@ if hash brew 2>/dev/null; then
     fi
 fi
 
-NODE_VERSION="v24.13.0"
+NODE_VERSION="v24.15.0"
 
 nvm use $NODE_VERSION || nvm install $NODE_VERSION