tabby-tabbyspaces 0.0.1 → 0.1.0

package/src/services/workspaceEditor.service.ts

@@ -11,22 +11,31 @@ import {
   TabbySplitLayoutProfile,
 } from '../models/workspace.model'
 import { CONFIG_KEY, DISPLAY_NAME } from '../build-config'
+import { PendingCommand } from './startupCommand.service'
 
 @Injectable({ providedIn: 'root' })
 export class WorkspaceEditorService {
+  private cachedProfiles: TabbyProfile[] = []
+
   constructor(
     private config: ConfigService,
     private notifications: NotificationsService,
     private profilesService: ProfilesService
   ) {}
 
+  private async cacheProfiles(): Promise<void> {
+    this.cachedProfiles = (await this.profilesService.getProfiles()) as TabbyProfile[]
+  }
+
   getWorkspaces(): Workspace[] {
-    return this.config.store[CONFIG_KEY]?.workspaces ?? []
+    return this.config.store?.[CONFIG_KEY]?.workspaces ?? []
   }
 
   async saveWorkspaces(workspaces: Workspace[]): Promise<boolean> {
+    if (!this.config.store?.[CONFIG_KEY]) {
+      return false
+    }
     this.config.store[CONFIG_KEY].workspaces = workspaces
-    this.syncTabbyProfiles(workspaces)
     return await this.saveConfig()
   }
 
@@ -60,28 +69,32 @@ export class WorkspaceEditorService {
   async getAvailableProfiles(): Promise<TabbyProfile[]> {
     const allProfiles = await this.profilesService.getProfiles()
     return allProfiles.filter(
-      (p) => p.type === 'local' && !p.id?.startsWith('split-layout:')
+      (p) =>
+        (p.type === 'local' || p.type?.startsWith('local:')) &&
+        !p.id?.startsWith('split-layout:')
     ) as TabbyProfile[]
   }
 
-  private syncTabbyProfiles(workspaces: Workspace[]): void {
-    const profiles: (TabbyProfile | TabbySplitLayoutProfile)[] = this.config.store.profiles ?? []
-
-    // Remove old plugin profiles (mutate in place)
-    for (let i = profiles.length - 1; i >= 0; i--) {
-      if (profiles[i].id?.startsWith(`split-layout:${CONFIG_KEY}:`)) {
-        profiles.splice(i, 1)
-      }
+  /**
+   * Cleanup orphaned profiles from previous plugin versions.
+   * Call this once on plugin init.
+   */
+  cleanupOrphanedProfiles(): void {
+    if (!this.config.store?.profiles) {
+      return
     }
-
-    // Add new workspace profiles
-    for (const workspace of workspaces) {
-      const tabbyProfile = this.generateTabbyProfile(workspace)
-      profiles.push(tabbyProfile)
+    const profiles: TabbyProfile[] = this.config.store.profiles
+    const prefix = `split-layout:${CONFIG_KEY}:`
+    const filtered = profiles.filter((p) => !p.id?.startsWith(prefix))
+    if (filtered.length !== profiles.length) {
+      this.config.store.profiles = filtered
+      this.config.save()
+      console.log(`[${DISPLAY_NAME}] Cleaned up ${profiles.length - filtered.length} orphaned profiles`)
     }
   }
 
-  generateTabbyProfile(workspace: Workspace): TabbySplitLayoutProfile {
+  async generateTabbyProfile(workspace: Workspace): Promise<TabbySplitLayoutProfile> {
+    await this.cacheProfiles()
     const safeName = this.sanitizeForProfileId(workspace.name)
     return {
       id: `split-layout:${CONFIG_KEY}:${safeName}:${workspace.id}`,
@@ -138,19 +151,8 @@ export class WorkspaceEditorService {
       runAsAdministrator: false,
     }
 
-    // Handle startup command for different shells
-    if (pane.startupCommand) {
-      const cmd = baseProfile.options?.command || ''
-      if (cmd.includes('nu.exe') || baseProfile.name?.toLowerCase().includes('nushell')) {
-        options.args = ['-e', pane.startupCommand]
-      } else if (cmd.includes('powershell') || cmd.includes('pwsh')) {
-        options.args = ['-NoExit', '-Command', pane.startupCommand]
-      } else if (cmd.includes('cmd.exe')) {
-        options.args = ['/K', pane.startupCommand]
-      } else {
-        options.args = ['-c', pane.startupCommand]
-      }
-    }
+    // Note: startupCommand is handled via sendInput() in StartupCommandService
+    // to avoid re-execution when Tabby splits the pane
 
     const profile = {
       id: baseProfile.id,
@@ -168,13 +170,17 @@ export class WorkspaceEditorService {
       behaviorOnSessionEnd: 'auto',
     }
 
+    // Use pane.id for matching in StartupCommandService
+    // Original title will be restored after command execution
+    const cwd = pane.cwd || baseProfile.options?.cwd || ''
     return {
       type: 'app:local-tab',
       profile,
       savedState: false,
-      tabTitle: pane.title || '',
-      tabCustomTitle: pane.title || '',
-      disableDynamicTitle: !!pane.title,
+      tabTitle: pane.id,
+      tabCustomTitle: pane.id,
+      disableDynamicTitle: false,
+      cwd,
     }
   }
 
@@ -182,7 +188,7 @@ export class WorkspaceEditorService {
     const clone = JSON.parse(JSON.stringify(workspace)) as Workspace
     clone.id = generateUUID()
     clone.name = `${workspace.name} (Copy)`
-    clone.isDefault = false
+    clone.launchOnStartup = false
     this.regenerateIds(clone.root)
     return clone
   }
@@ -207,12 +213,38 @@ export class WorkspaceEditorService {
   }
 
   private getProfileById(profileId: string): TabbyProfile | undefined {
-    const profiles: TabbyProfile[] = this.config.store.profiles ?? []
-    return profiles.find((p) => p.id === profileId && p.type === 'local')
+    const isLocalType = (type: string) => type === 'local' || type?.startsWith('local:')
+
+    // First: check user profiles in config
+    const userProfiles: TabbyProfile[] = this.config.store?.profiles ?? []
+    const found = userProfiles.find((p) => p.id === profileId && isLocalType(p.type))
+    if (found) return found
+
+    // Fallback: check cached profiles (includes built-ins)
+    return this.cachedProfiles.find((p) => p.id === profileId && isLocalType(p.type))
+  }
+
+  collectStartupCommands(workspace: Workspace): PendingCommand[] {
+    const commands: PendingCommand[] = []
+    this.collectCommandsFromNode(workspace.root, commands)
+    return commands
   }
 
-  getProfileName(profileId: string): string | undefined {
-    return this.getProfileById(profileId)?.name
+  private collectCommandsFromNode(
+    node: WorkspacePane | WorkspaceSplit,
+    commands: PendingCommand[]
+  ): void {
+    if (isWorkspaceSplit(node)) {
+      for (const child of node.children) {
+        this.collectCommandsFromNode(child, commands)
+      }
+    } else if (node.startupCommand) {
+      commands.push({
+        paneId: node.id,
+        command: node.startupCommand,
+        originalTitle: node.title || '',
+      })
+    }
   }
 
   private async saveConfig(): Promise<boolean> {

package/test_cdp.py

@@ -0,0 +1,50 @@
+"""Test CDP connection to Tabby - click on TabbySpaces settings"""
+import pychrome
+import time
+
+# Connect to Tabby
+browser = pychrome.Browser(url="http://localhost:9222")
+tabs = browser.list_tab()
+print(f"Found {len(tabs)} tabs")
+
+# Get the first tab (main Tabby window)
+tab = tabs[0]
+print(f"Using first tab")
+tab.start()
+
+# Click on TabbySpaces link
+print("\nClicking on 'TabbySpaces' link...")
+result = tab.Runtime.evaluate(expression="""
+    const link = Array.from(document.querySelectorAll('a.nav-link'))
+        .find(a => a.innerText.trim() === 'TabbySpaces');
+    if (link) {
+        link.click();
+        'Clicked TabbySpaces!';
+    } else {
+        'TabbySpaces link not found';
+    }
+""")
+print(f"Result: {result.get('result', {}).get('value')}")
+
+time.sleep(0.3)
+
+# Verify we're on TabbySpaces page - look for workspace elements
+result = tab.Runtime.evaluate(expression="""
+    // Check for TabbySpaces specific content
+    const content = document.body.innerText;
+    const hasWorkspaces = content.includes('Workspace') || content.includes('workspace');
+    const activeLink = document.querySelector('a.nav-link.active');
+    ({
+        activePage: activeLink ? activeLink.innerText.trim() : 'unknown',
+        hasWorkspaceContent: hasWorkspaces,
+        pageSnippet: content.substring(0, 500)
+    });
+""", returnByValue=True)
+
+data = result.get('result', {}).get('value', {})
+print(f"\nActive page: {data.get('activePage')}")
+print(f"Has workspace content: {data.get('hasWorkspaceContent')}")
+print(f"\nPage snippet:\n{data.get('pageSnippet', '')[:300]}...")
+
+tab.stop()
+print("\nDone!")

package/RELEASE_PLAN.md

@@ -1,161 +0,0 @@
-# TabbySpaces - Public Release Plan
-
-## Cilj
-
-Napraviti public repo koji omogućava:
-1. Korisnicima da instaliraju plugin iz Tabby Plugin Manager-a
-2. Developerima da doprinose (fork → develop → PR)
-3. Maintaineru (Igor) da testira i dev i production verziju istovremeno
-
----
-
-## 1. Package.json izmene
-
-- [x] Verzija: `1.0.0` → `0.0.1`
-- [x] Dodaj `repository` polje
-- [x] Dodaj `homepage` polje
-- [x] Dodaj `bugs` polje
-- [x] Sredi `scripts` sekciju - uklonjena TABBY_PLUGINS zavisnost
-
----
-
-## 2. Dev Workflow
-
-**Pristup:** build:dev + instalacija u plugins folder
-
-**Radi:**
-- [x] `npm run build:dev` - kreira dist-dev/ sa izolovanim package-om
-- [x] Instalacija u plugins folder
-
-**Poznati problemi:**
-- [x] ~~Prod i dev plugin imaju isto ime u Tabby UI~~ (REŠENO)
-
-**TODO:**
-- [x] ~~Popraviti izolaciju imena u UI~~ (DONE - toolbar, settings, profile groups)
-- [ ] Testirati watch mode
-- [ ] Dokumentovati u README
-
----
-
-## 3. Testiranje
-
-**Koegzistencija (maintainer)** ✅ RADI
-```
-tabby-tabbyspaces (prod) + tabby-tabbyspaces-dev (dev) u plugins folderu
-Različiti config keys, različita imena u UI
-```
-
-**Napomene:**
-- Contributor workflow će biti dokumentovan u CONTRIBUTING.md
-- Production test će biti live npm publish
-
----
-
-## 4. Potrebni fajlovi
-
-| Fajl | Status | Prioritet |
-|------|--------|-----------|
-| `README.md` | DONE | P0 |
-| `LICENSE` | DONE | P0 |
-| `CHANGELOG.md` | DONE | P0 |
-| `CONTRIBUTING.md` | DONE | P0 |
-| `.github/ISSUE_TEMPLATE/*` | DONE | P0 |
-| `CLAUDE.md` | DONE (EN) | P0 |
-| `screenshots/` | DONE | P0 |
-
----
-
-## 5. Distribucija
-
-**Metod:** npm publish (jedini način da se pojavi u Tabby Plugin Manager-u)
-
-**Proces:**
-```bash
-# Setup (jednom)
-npm login
-
-# Release
-npm version patch  # ili minor/major
-npm publish
-```
-
-**Pre-publish checklist:**
-- [ ] Verzija bump-ovana
-- [ ] Build radi (`npm run build`)
-- [ ] README ažuriran
-- [ ] CHANGELOG ažuriran
-
----
-
-## 6. GitHub Repo Setup
-
-- [ ] Kreiraj repo: `github.com/halilc4/tabbyspaces`
-- [ ] Dodaj opis
-- [ ] Dodaj topics: `tabby`, `tabby-plugin`, `terminal`, `workspace`
-- [ ] Uključi Issues
-- [ ] Push koda
-
----
-
-## 7. Redosled akcija
-
-```
-1. [x] Reši dev workflow → build:dev pristup
-2. [x] Popravi dev vs prod izolaciju (ime u UI)
-3. [x] Testiraj koegzistenciju (maintainer scenario)
-4. [x] Napravi LICENSE (MIT, engleski)
-5. [x] Napravi README.md (engleski, Claude Code attribution, screenshots)
-6. [x] Napravi CHANGELOG.md
-7. [x] Napravi CONTRIBUTING.md
-8. [x] Napravi .github/ISSUE_TEMPLATE/*
-9. [x] Prevedi CLAUDE.md na engleski
-10. [ ] Kreiraj GitHub repo (halilc4/tabbyspaces)
-11. [ ] Push
-12. [ ] npm publish
-13. [ ] Testiraj instalaciju iz Tabby Plugin Manager-a
-```
-
----
-
-## Odluke
-
-1. **GitHub username** - `halilc4` → `github.com/halilc4/tabbyspaces`
-2. **CHANGELOG** - DA, vodimo ga
-3. **Jezici** - README i LICENSE na engleskom
-4. **Attribution** - README mora jasno naglasiti:
-   - Kod 100% napisan od Claude Code-a
-   - Igor = ideja i product vision
-   - Igor toliko mrzi Angular da nije ni pogledao kod
-
----
-
-## Otvorena pitanja
-
-~~1. **CLAUDE.md jezik** - Prevesti na engleski za contributore?~~ → DA, engleski
-
----
-
-## 8. Final Review (2026-01-03)
-
-**Status:** ✅ PASS
-
-**Pregledano:**
-- [x] Struktura projekta - čista, standardni Angular pattern
-- [x] Kod - tipiziran, bez `any`, čitljiv
-- [x] README.md - jasan, sa screenshotovima
-- [x] LICENSE, CONTRIBUTING.md, CHANGELOG.md - kompletno
-- [x] package.json metapodaci - repo, bugs, homepage
-- [x] .github/ISSUE_TEMPLATE/* - bug report, feature request
-- [x] Dev/Prod izolacija - radi
-
-**Zaključak:** Projekat je spreman za public release.
-
-**Sledeća sesija:** Full publish (GitHub repo + npm publish)
-
----
-
-## Stil dokumentacije
-
-- Bez mainstream GitHub corporate stila
-- Bez AI slop-a (generic, over-polished)
-- Direktno, iskreno, sa karakterom