tabby-rdp 0.6.2 → 0.6.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +26 -0
- package/README.md +16 -11
- package/bin/SHA256SUMS +8 -8
- package/bin/darwin-arm64/tabby-rdp-proxy +0 -0
- package/bin/darwin-x64/tabby-rdp-proxy +0 -0
- package/bin/linux-arm/tabby-rdp-proxy +0 -0
- package/bin/linux-arm64/tabby-rdp-proxy +0 -0
- package/bin/linux-x64/tabby-rdp-proxy +0 -0
- package/bin/win32-arm64/tabby-rdp-proxy.exe +0 -0
- package/bin/win32-x64/tabby-rdp-proxy.exe +0 -0
- package/dist/audio.js +26 -5
- package/dist/clipboard.js +8 -2
- package/dist/desktop.service.js +60 -14
- package/dist/desktopForm.js +1 -1
- package/dist/fileTransfer.js +41 -8
- package/dist/freerdp.js +36 -14
- package/dist/freerdpClipboard.js +39 -9
- package/dist/freerdpFiles.js +183 -0
- package/dist/freerdpWasm.js +183 -0
- package/dist/freerdpWasmSocket.js +28 -0
- package/dist/freerdpWasmWorker.js +174 -0
- package/dist/pduTrace.js +27 -5
- package/dist/rdpClient.js +2 -2
- package/dist/rdpProfile.js +2 -2
- package/dist/settingsPage.js +6 -6
- package/dist/ui.js +2 -2
- package/dist/zgfx.js +33 -18
- package/native/README.md +64 -32
- package/package.json +6 -18
- package/vendor/SHA256SUMS +16 -5
- package/vendor/iron-remote-desktop-rdp.js +301 -301
- package/vendor/iron-remote-desktop.js +770 -736
- package/vendor/ironrdp-factory.js +301 -301
- package/vendor/ironrdp_web_bg.wasm +0 -0
- package/wasm/freerdp/BUILD.json +63 -0
- package/wasm/freerdp/licenses/Emscripten-LICENSE +102 -0
- package/wasm/freerdp/licenses/FreeRDP-LICENSE +202 -0
- package/wasm/freerdp/licenses/FreeRDP-NOTICE +13 -0
- package/wasm/freerdp/licenses/LibreSSL-LICENSE +133 -0
- package/wasm/freerdp/licenses/Unicode-NOTICE +21 -0
- package/wasm/freerdp/licenses/zlib-LICENSE +22 -0
- package/wasm/freerdp/tabby-freerdp.js +2 -0
- package/wasm/freerdp/tabby-freerdp.wasm +0 -0
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,31 @@
|
|
|
1
1
|
# Changelog
|
|
2
2
|
|
|
3
|
+
## 0.6.4
|
|
4
|
+
|
|
5
|
+
**Added**
|
|
6
|
+
- Copy files and folders with FreeRDP: paste copied files into the remote desktop, drop files onto it, and save files copied remotely through the download notification. Transfers respect clipboard direction and view-only settings.
|
|
7
|
+
|
|
8
|
+
**Changed**
|
|
9
|
+
- Bundle FreeRDP 3.33.1 as WebAssembly for macOS, Windows and Linux. Existing FreeRDP selections use it on reconnect; separate native FreeRDP npm packages are no longer required. The client is named **FreeRDP** throughout the interface; IronRDP remains the default.
|
|
10
|
+
- FreeRDP authentication now uses NTLM on every platform. The WASM build does not provide the earlier native Windows client's SSPI authentication or Kerberos. A Windows comparison found similar frame rates and input latency, with higher CPU and memory use; see the [comparison results](https://github.com/meanaverage/tabby-rdp/blob/v0.6.4/test/fixtures/performance/README.md#windows-comparison-2026-11-16).
|
|
11
|
+
- Update Angular to 22.2.4, Playwright to 1.65.0 and the WebSocket transport library `ws` to 8.22.1. The FreeRDP build uses Emscripten 6.0.12 and LibreSSL 4.3.3.
|
|
12
|
+
- Verify both bundled WASM clients against independent source builds before release staging. Native FreeRDP comparison builds remain available from CI and the build scripts.
|
|
13
|
+
|
|
14
|
+
**Fixed**
|
|
15
|
+
- Keep FreeRDP’s pinned version when building from a tagged Tabby checkout, preventing incorrect ABI names and release-build mismatches.
|
|
16
|
+
- Stop clipboard sharing in both directions during view only, including uploads and clipboard reads that finish after view only starts.
|
|
17
|
+
- Match FreeRDP file-clipboard acknowledgements to their offers, recover when the remote clipboard process restarts, fail unavailable clipboard channels promptly and release expired transfer requests.
|
|
18
|
+
- Bound FreeRDP upload buffering, preserve final connection output and stop workers when their owning tab or input disappears. Avoid a shutdown exception when Electron supplies browser timers.
|
|
19
|
+
- Align the retained IronRDP patches with final upstream drive-name, dynamic-channel, licensing-log, audio-training, clipboard-lifecycle and graphics-state corrections while retaining the 0.6.x IronRDP base.
|
|
20
|
+
- Retain IronRDP server volume changes received before playback starts and apply separate left/right channel volume.
|
|
21
|
+
- Bound diagnostic graphics parsing and close the underlying video decoder when the traced decoder is released.
|
|
22
|
+
|
|
23
|
+
FreeRDP still does not support clipboard images, sound/microphone, shared folders, H.264 or Hyper-V VMConnect; these were also absent from the native integration. File transfers have live Windows coverage; live Linux file transfers and real Senhasegura MFA/policy/handoff behavior remain unqualified. Empty folders are omitted; uploads must be smaller than 4 GiB and downloads are limited to 2 GiB. See [client capabilities and test coverage](https://github.com/meanaverage/tabby-rdp/blob/v0.6.4/native/README.md).
|
|
24
|
+
|
|
25
|
+
## 0.6.3 (not published; included in 0.6.4)
|
|
26
|
+
|
|
27
|
+
Release validation caught a build-version lookup that used the enclosing Tabby tag for FreeRDP. No npm package was published; 0.6.4 includes the corrected build and the changes above.
|
|
28
|
+
|
|
3
29
|
## 0.6.2
|
|
4
30
|
|
|
5
31
|
**Fixed**
|
package/README.md
CHANGED
|
@@ -66,14 +66,14 @@ desktop separately after its GNOME desktop has been opened.
|
|
|
66
66
|
|
|
67
67
|
| Remote OS / desktop | RDP server | Setup and coverage |
|
|
68
68
|
|---|---|---|
|
|
69
|
-
| Windows 10/11 Pro and Windows Server | Windows Remote Desktop | Enable Remote Desktop; connect directly or through SSH / RD Gateway. Windows 11 has visual QA coverage;
|
|
69
|
+
| Windows 10/11 Pro and Windows Server | Windows Remote Desktop | Enable Remote Desktop; connect directly or through SSH / RD Gateway. Windows 11 has visual QA coverage; FreeRDP has live Windows Server 2022 clipboard coverage from a Windows Server 2025 client. |
|
|
70
70
|
| Linux: Xfce, KDE Plasma, MATE, Cinnamon and others | xrdp | Uses the desktop configured for xrdp sessions. Rocky Linux 9 with Xfce is tested; other desktop combinations need their own qualification. |
|
|
71
71
|
| Linux: GNOME | GNOME Remote Desktop 46+ | Automatic headless setup for the SSH user. Ubuntu, Debian and Fedora have visual QA coverage. |
|
|
72
72
|
| Linux: KDE Plasma through KRDP | KRDP | Experimental: the tested Fedora stack needs server patches; stock KRDP and live monitor resize remain unqualified. |
|
|
73
73
|
|
|
74
74
|
The client runs on **macOS, Windows and Linux**. These are separate from the OS of the remote desktop.
|
|
75
75
|
See [requirements, exact test environments and limitations](docs/compatibility.md) for server versions, optional
|
|
76
|
-
channels and pending coverage.
|
|
76
|
+
channels and pending coverage. FreeRDP supports fewer optional channels than IronRDP; each client’s coverage is documented separately.
|
|
77
77
|
|
|
78
78
|
<a id="windows-and-other-desktops-behind-a-host"></a>
|
|
79
79
|
<a id="remote-desktop-profiles"></a>
|
|
@@ -104,7 +104,7 @@ explains what happens to saved passwords and certificates.
|
|
|
104
104
|
|
|
105
105
|
## Features
|
|
106
106
|
|
|
107
|
-
These features describe the default **IronRDP** client.
|
|
107
|
+
These features describe the default **IronRDP** client. FreeRDP’s supported features and limits are [below](#rdp-clients).
|
|
108
108
|
|
|
109
109
|
| Feature | What you can do |
|
|
110
110
|
|---|---|
|
|
@@ -125,9 +125,11 @@ See [sharing and controls](docs/sharing.md) and [accounts and certificate trust]
|
|
|
125
125
|
With **desk** enabled, typing `desk` in an SSH console moves the same shell, history and running jobs into a terminal
|
|
126
126
|
on the GNOME desktop. It is optional and off by default. [How desk works](docs/desk.md).
|
|
127
127
|
|
|
128
|
-
|
|
128
|
+
<a id="rdp-client-preview"></a>
|
|
129
129
|
|
|
130
|
-
|
|
130
|
+
## RDP clients
|
|
131
|
+
|
|
132
|
+
**Settings › Remote Desktop › Settings › RDP client** selects **IronRDP** or **FreeRDP**. Profiles and
|
|
131
133
|
behind-host desktops can override the default. Changes apply on the next connection.
|
|
132
134
|
|
|
133
135
|
In an RDP profile tab's **…** menu, choose **RDP client** to switch that profile and optionally **Reconnect to apply**.
|
|
@@ -135,10 +137,11 @@ In an RDP profile tab's **…** menu, choose **RDP client** to switch that profi
|
|
|
135
137
|
| Client | Availability | Capabilities |
|
|
136
138
|
|---|---|---|
|
|
137
139
|
| IronRDP (default) | macOS, Windows and Linux | The features above, subject to the server's capabilities |
|
|
138
|
-
| FreeRDP
|
|
140
|
+
| FreeRDP | Bundled for macOS, Windows and Linux | In-tab display, keyboard/mouse, clipboard text and files/folders, scaling, resize, view only, screenshots and reconnect. Pictures, audio, shared folders, Hyper-V and H.264 are pending. No separate FreeRDP package is needed. |
|
|
141
|
+
|
|
142
|
+
FreeRDP 3.33.1 is bundled as WebAssembly. Existing FreeRDP selections use it on reconnect; no separate native FreeRDP npm package is required. It uses NTLM on every platform and does not provide the previous native Windows client’s SSPI authentication or Kerberos. Sound and microphone still require IronRDP, as they did before this change.
|
|
139
143
|
|
|
140
|
-
Windows
|
|
141
|
-
To try the preview, open **Settings › Remote Desktop › Updates**, choose **Preview**, and install the offered version.
|
|
144
|
+
A [Windows VM comparison](test/fixtures/performance/README.md#windows-comparison-2026-11-16) found similar frame rates and input latency, with higher WASM CPU and memory use. Live Linux file transfers and real PAM appliance behavior remain unqualified. See [FreeRDP builds, licensing and capability notes](native/README.md). Both clients are included in the normal plugin installation; select one using **RDP client** above.
|
|
142
145
|
|
|
143
146
|
<a id="settings"></a>
|
|
144
147
|
<a id="saved-accounts"></a>
|
|
@@ -160,7 +163,7 @@ To try the preview, open **Settings › Remote Desktop › Updates**, choose **P
|
|
|
160
163
|
## Development
|
|
161
164
|
|
|
162
165
|
IronRDP is a Rust RDP client compiled to WebAssembly. We ship a reviewed patch series and contribute fixes upstream;
|
|
163
|
-
see [IronRDP and contributions](docs/ironrdp.md). The
|
|
166
|
+
see [IronRDP and contributions](docs/ironrdp.md). The portable FreeRDP build has its own pinned toolchain and source records.
|
|
164
167
|
|
|
165
168
|
```sh
|
|
166
169
|
npm ci --ignore-scripts
|
|
@@ -186,8 +189,10 @@ names and addresses; check those before attaching one.
|
|
|
186
189
|
|
|
187
190
|
## License
|
|
188
191
|
|
|
189
|
-
[MIT](LICENSE). IronRDP is MIT or Apache-2.0 ([license](vendor/IRONRDP-LICENSE)); FreeRDP
|
|
190
|
-
|
|
192
|
+
[MIT](LICENSE). IronRDP is MIT or Apache-2.0 ([license](vendor/IRONRDP-LICENSE)); FreeRDP and WinPR are Apache-2.0.
|
|
193
|
+
The bundled WebAssembly includes their license notices, WinPR's Unicode conversion notice, and LibreSSL, zlib and
|
|
194
|
+
Emscripten notices. Native development builds additionally include OpenSSL 3's Apache-2.0 license.
|
|
195
|
+
See [FreeRDP licensing](native/README.md#licensing).
|
|
191
196
|
Header icons are from [Font Awesome Free](https://fontawesome.com) (CC BY 4.0).
|
|
192
197
|
|
|
193
198
|
tabby-rdp is an independent project, not affiliated with Tabby, Devolutions or the GNOME Project.
|
package/bin/SHA256SUMS
CHANGED
|
@@ -1,8 +1,8 @@
|
|
|
1
|
-
# The network helpers, built from helper/ with go1.27.1 by scripts/build-helper.mjs (tabby-rdp 0.6.
|
|
2
|
-
|
|
3
|
-
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
1
|
+
# The network helpers, built from helper/ with go1.27.1 by scripts/build-helper.mjs (tabby-rdp 0.6.4).
|
|
2
|
+
118bb6f2d70c4380eec4b720329aec25ed9cac295e06f71f1a1a9fa13a1ef469 bin/darwin-arm64/tabby-rdp-proxy
|
|
3
|
+
30e77eba05fe68791dbbe16e5287c5af5ff902da369eac63163e8d71c4655dd7 bin/darwin-x64/tabby-rdp-proxy
|
|
4
|
+
3b5b192164a3503efe8215b378ac2998eb5464f9b39559b2aa643125a363de20 bin/linux-x64/tabby-rdp-proxy
|
|
5
|
+
d225e2d933e3feec4bbe7f5821d8e277a54367f60ec935d6c004e3bf9bf7dddb bin/linux-arm64/tabby-rdp-proxy
|
|
6
|
+
c9561b011e9e56cd8cc90628cc1db2445131507f1ba7ccb89792af6798aa3cf7 bin/linux-arm/tabby-rdp-proxy
|
|
7
|
+
e3ab32d84f48235ea6fdce54a2dd6f0b30c7cc2f15b2ce52bc95863ee3eeb286 bin/win32-x64/tabby-rdp-proxy.exe
|
|
8
|
+
3d12f79d7ff2ede3c78d88f06cd8327aa9c25518265095dd3cfc71c787f3985a bin/win32-arm64/tabby-rdp-proxy.exe
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
package/dist/audio.js
CHANGED
|
@@ -10,6 +10,8 @@ class AudioPlayer {
|
|
|
10
10
|
constructor() {
|
|
11
11
|
this.context = null;
|
|
12
12
|
this.gain = null;
|
|
13
|
+
this.channels = [];
|
|
14
|
+
this.levels = [1, 1];
|
|
13
15
|
/** Web Audio time at which the next block starts. */
|
|
14
16
|
this.next = 0;
|
|
15
17
|
/** Seconds of audio received and scheduled (for tests and troubleshooting). */
|
|
@@ -23,7 +25,7 @@ class AudioPlayer {
|
|
|
23
25
|
this.play(message.sampleRate, message.channels, message.data);
|
|
24
26
|
}
|
|
25
27
|
else if (message?.type === 'volume') {
|
|
26
|
-
this.volume(
|
|
28
|
+
this.volume(Number(message.left), Number(message.right));
|
|
27
29
|
}
|
|
28
30
|
else if (message?.type === 'close') {
|
|
29
31
|
this.next = 0;
|
|
@@ -42,7 +44,20 @@ class AudioPlayer {
|
|
|
42
44
|
this.context ??= new AudioContext({ latencyHint: 'interactive' });
|
|
43
45
|
if (!this.gain) {
|
|
44
46
|
this.gain = this.context.createGain();
|
|
45
|
-
|
|
47
|
+
// Upmix mono before splitting so both speaker gains also apply to mono streams.
|
|
48
|
+
this.gain.channelCount = 2;
|
|
49
|
+
this.gain.channelCountMode = 'explicit';
|
|
50
|
+
const split = this.context.createChannelSplitter(2);
|
|
51
|
+
const merge = this.context.createChannelMerger(2);
|
|
52
|
+
this.gain.connect(split);
|
|
53
|
+
this.channels = this.levels.map((level, channel) => {
|
|
54
|
+
const gain = this.context.createGain();
|
|
55
|
+
gain.gain.value = level;
|
|
56
|
+
split.connect(gain, channel);
|
|
57
|
+
gain.connect(merge, 0, channel);
|
|
58
|
+
return gain;
|
|
59
|
+
});
|
|
60
|
+
merge.connect(this.context.destination);
|
|
46
61
|
}
|
|
47
62
|
if (this.context.state === 'suspended') {
|
|
48
63
|
this.context.resume().catch(() => null);
|
|
@@ -70,15 +85,21 @@ class AudioPlayer {
|
|
|
70
85
|
this.next += buffer.duration;
|
|
71
86
|
this.received += buffer.duration;
|
|
72
87
|
}
|
|
73
|
-
volume(
|
|
74
|
-
if (
|
|
75
|
-
|
|
88
|
+
volume(left, right) {
|
|
89
|
+
if (![left, right].every(Number.isFinite)) {
|
|
90
|
+
return;
|
|
76
91
|
}
|
|
92
|
+
// MS-RDPEA 2.2.2.2 specifies logarithmic levels, without a required dB span.
|
|
93
|
+
// Use a 60 dB range with exact silence at zero and unity at full volume.
|
|
94
|
+
this.levels = [left, right].map(level => level <= 0 ? 0 : 10 ** (3 * (Math.min(1, level) - 1)));
|
|
95
|
+
this.channels.forEach((gain, channel) => { gain.gain.value = this.levels[channel]; });
|
|
77
96
|
}
|
|
78
97
|
close() {
|
|
79
98
|
this.context?.close().catch(() => null);
|
|
80
99
|
this.context = null;
|
|
81
100
|
this.gain = null;
|
|
101
|
+
this.channels = [];
|
|
102
|
+
this.next = 0;
|
|
82
103
|
}
|
|
83
104
|
}
|
|
84
105
|
exports.AudioPlayer = AudioPlayer;
|
package/dist/clipboard.js
CHANGED
|
@@ -16,6 +16,10 @@
|
|
|
16
16
|
* connection: see RemoteDesktopService.applyClipboard); the plugin's own sending (paste to all, files) checks the
|
|
17
17
|
* ways as well.
|
|
18
18
|
* The other way only, from this computer to the remote desktop, isn't offered.
|
|
19
|
+
*
|
|
20
|
+
* View only (see DesktopSession.pauseClipboard) pauses the component's clipboard: nothing goes either way meanwhile,
|
|
21
|
+
* what the remote copies is dropped, and what this computer offered is withdrawn if it is still the latest there. A
|
|
22
|
+
* component that can't pause it gets no clipboard at all, as one that can't stop its reading.
|
|
19
23
|
*/
|
|
20
24
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
21
25
|
exports.CLIPBOARD_LABELS = void 0;
|
|
@@ -73,8 +77,10 @@ function setUpClipboard(ui, provider, mode, sending) {
|
|
|
73
77
|
ui.enableFileTransfer(provider);
|
|
74
78
|
const stop = provider.onUploadStarted;
|
|
75
79
|
const resume = provider.onUploadFinished;
|
|
76
|
-
// Without the hooks composed (a component that doesn't), its reading can't be stopped
|
|
77
|
-
|
|
80
|
+
// Without the hooks composed (a component that doesn't), its reading can't be stopped, nor without the pause can
|
|
81
|
+
// view only keep the clipboard out: nothing goes either way.
|
|
82
|
+
const applied = typeof stop === 'function' && typeof resume === 'function' && stop !== own &&
|
|
83
|
+
typeof ui.setClipboardPaused === 'function' ? mode : 'off';
|
|
78
84
|
provider.onUploadFinished = () => {
|
|
79
85
|
if (sending()) {
|
|
80
86
|
resume?.call(provider);
|
package/dist/desktop.service.js
CHANGED
|
@@ -59,7 +59,9 @@ const audio_1 = require("./audio");
|
|
|
59
59
|
const ironrdp_1 = require("./ironrdp");
|
|
60
60
|
const rdpClient_1 = require("./rdpClient");
|
|
61
61
|
const freerdp_1 = require("./freerdp");
|
|
62
|
+
const freerdpFiles_1 = require("./freerdpFiles");
|
|
62
63
|
const freerdpClipboard_1 = require("./freerdpClipboard");
|
|
64
|
+
const freerdpWasm_1 = require("./freerdpWasm");
|
|
63
65
|
const freerdpView_1 = require("./freerdpView");
|
|
64
66
|
const h264_1 = require("./h264");
|
|
65
67
|
const clipboard_1 = require("./clipboard");
|
|
@@ -308,7 +310,10 @@ class DesktopSession {
|
|
|
308
310
|
this.drives = null;
|
|
309
311
|
/** Decodes H.264 for the graphics pipeline (IronRDP's WebCodecsH264Decoder), when this connection uses it. */
|
|
310
312
|
this.h264 = null;
|
|
311
|
-
/**
|
|
313
|
+
/**
|
|
314
|
+
* No keyboard or mouse input goes to the remote (keys: see keyboard.ts; the mouse: a layer over the picture), and
|
|
315
|
+
* no clipboard either way (see pauseClipboard).
|
|
316
|
+
*/
|
|
312
317
|
this.viewOnly = false;
|
|
313
318
|
/** The host's own desktop: the certificate its setup reported for this connection. */
|
|
314
319
|
this.pinnedCertificate = null;
|
|
@@ -366,7 +371,7 @@ class DesktopSession {
|
|
|
366
371
|
this.overlay.className = 'trd-overlay';
|
|
367
372
|
this.overlay.innerHTML = `
|
|
368
373
|
<div class="trd-host"></div>
|
|
369
|
-
<div class="trd-view-only" title="View only: no keyboard or mouse input goes to the remote desktop"></div>
|
|
374
|
+
<div class="trd-view-only" title="View only: no keyboard or mouse input goes to the remote desktop, and no clipboard either way"></div>
|
|
370
375
|
<div class="trd-mic"><i class="fas fa-microphone"></i></div>
|
|
371
376
|
<div class="trd-osd"></div>
|
|
372
377
|
<div class="trd-status"><div class="trd-status-text"></div><div class="trd-status-actions"></div><a class="trd-status-help">What does this mean?</a></div>`;
|
|
@@ -417,9 +422,25 @@ class DesktopSession {
|
|
|
417
422
|
setViewOnly(viewOnly) {
|
|
418
423
|
this.viewOnly = viewOnly;
|
|
419
424
|
this.ui?.setReadOnly?.(viewOnly);
|
|
425
|
+
this.pauseClipboard();
|
|
420
426
|
this.overlay.classList.toggle('trd-view-only-on', viewOnly);
|
|
421
427
|
this.log.push(`view only: ${viewOnly ? 'on' : 'off'}`);
|
|
422
428
|
}
|
|
429
|
+
/**
|
|
430
|
+
* No clipboard goes either way in view only. IronRDP's component pauses its clipboard for it: what this computer
|
|
431
|
+
* offered is withdrawn if it is still the latest on the remote's clipboard, and what the remote copies is dropped
|
|
432
|
+
* (setUpClipboard leaves out the clipboard of a component that can't). FreeRDP's clipboard pauses itself (see
|
|
433
|
+
* freerdpClipboard.ts), and files don't go meanwhile (see FileTransfer).
|
|
434
|
+
*/
|
|
435
|
+
pauseClipboard() {
|
|
436
|
+
if (typeof this.ui?.setClipboardPaused !== 'function') {
|
|
437
|
+
return;
|
|
438
|
+
}
|
|
439
|
+
const viewOnly = this.viewOnly;
|
|
440
|
+
Promise.resolve(this.ui.setClipboardPaused(viewOnly)).catch((e) => {
|
|
441
|
+
this.log.push(`clipboard: not ${viewOnly ? 'paused' : 'resumed'} for view only: ${e?.backtrace?.() ?? e?.message ?? e}`);
|
|
442
|
+
});
|
|
443
|
+
}
|
|
423
444
|
/** Shows which desktop this is, for a moment (see osd.ts). */
|
|
424
445
|
flashLabel(name, sub, settings) {
|
|
425
446
|
const osd = this.overlay.querySelector('.trd-osd');
|
|
@@ -1060,7 +1081,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
1060
1081
|
}
|
|
1061
1082
|
effectiveClient(override, hyperv = false) {
|
|
1062
1083
|
const own = (0, rdpClient_1.ownRDPClient)(override), preferred = own ?? this.settings().client;
|
|
1063
|
-
return !own && (hyperv || preferred === 'freerdp' && !(0,
|
|
1084
|
+
return !own && (hyperv || preferred === 'freerdp' && !(0, freerdpWasm_1.hasFreeRDPWasm)()) ? 'ironrdp' : preferred;
|
|
1064
1085
|
}
|
|
1065
1086
|
/** The profile's next-connection choice, with the currently running client shown separately. */
|
|
1066
1087
|
rdpClientChoice(pane) {
|
|
@@ -2689,7 +2710,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
2689
2710
|
isViewOnly(pane) {
|
|
2690
2711
|
return !!this.sessions.get(pane)?.viewOnly;
|
|
2691
2712
|
}
|
|
2692
|
-
/** View only: the pane's desktop gets no keyboard or mouse input (the picture
|
|
2713
|
+
/** View only: the pane's desktop gets no keyboard or mouse input and no clipboard (the picture and sound go on). */
|
|
2693
2714
|
setViewOnly(pane, viewOnly) {
|
|
2694
2715
|
const session = this.sessions.get(pane);
|
|
2695
2716
|
if (session) {
|
|
@@ -2869,6 +2890,10 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
2869
2890
|
session.mic?.turnOff();
|
|
2870
2891
|
this.changed$.next();
|
|
2871
2892
|
}
|
|
2893
|
+
/** Whether this connection's client supports microphone redirection. */
|
|
2894
|
+
canUseMicrophone(pane) {
|
|
2895
|
+
return this.sessions.get(pane)?.client === 'ironrdp';
|
|
2896
|
+
}
|
|
2872
2897
|
/** Whether the microphone was stopped for the pane's desktop (see stopMicrophone). */
|
|
2873
2898
|
microphoneStoppedFor(pane) {
|
|
2874
2899
|
const session = this.sessions.get(pane);
|
|
@@ -3082,7 +3107,10 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3082
3107
|
if (!this.clipboardWaysOf(session).toRemote) {
|
|
3083
3108
|
return false;
|
|
3084
3109
|
}
|
|
3085
|
-
|
|
3110
|
+
// FreeRDP's generation-tagged acknowledgements are for file offers only. Text keeps
|
|
3111
|
+
// the original short settling delay instead of waiting for an unrelated file event.
|
|
3112
|
+
const answered = (session.client !== 'freerdp' ? session.files?.clipboardAnswered() : undefined)
|
|
3113
|
+
?? new Promise(resolve => setTimeout(() => resolve(true), 300));
|
|
3086
3114
|
try {
|
|
3087
3115
|
await session.ui.sendClipboardData();
|
|
3088
3116
|
}
|
|
@@ -3333,11 +3361,11 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3333
3361
|
session.log.push('client: using IronRDP because the global FreeRDP default is unavailable for this desktop on this computer');
|
|
3334
3362
|
}
|
|
3335
3363
|
session.client = client;
|
|
3336
|
-
if (client
|
|
3364
|
+
if (client !== 'ironrdp') {
|
|
3337
3365
|
if (spec.hyperv) {
|
|
3338
3366
|
throw new Error('FreeRDP does not support Hyper-V consoles in Tabby yet. Choose IronRDP for this desktop.');
|
|
3339
3367
|
}
|
|
3340
|
-
(0,
|
|
3368
|
+
(0, freerdpWasm_1.requireFreeRDPWasm)();
|
|
3341
3369
|
}
|
|
3342
3370
|
const gateway = spec.gateway ? (0, gateway_1.parseGateway)(spec.gateway) : null;
|
|
3343
3371
|
if (spec.gateway && !gateway) {
|
|
@@ -3353,7 +3381,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3353
3381
|
// Signing in to a Windows account can take a few tries; a GNOME desktop the plugin set up can't fail that way.
|
|
3354
3382
|
for (let attempt = 0;; attempt++) {
|
|
3355
3383
|
// Resolve availability before opening a credential form; a missing native build asks for no password.
|
|
3356
|
-
const backend = client
|
|
3384
|
+
const backend = client !== 'ironrdp' ? Promise.resolve({ client }) : this.loadIronRDP(session);
|
|
3357
3385
|
const [asked, rdp] = await Promise.all([endpoint ?? this.endpointFor(pane, target, spec, session, automatic, retryError), backend]);
|
|
3358
3386
|
if (!alive()) {
|
|
3359
3387
|
return;
|
|
@@ -3397,7 +3425,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3397
3425
|
session.proxy.close();
|
|
3398
3426
|
session.proxy = null;
|
|
3399
3427
|
}
|
|
3400
|
-
if (!session.proxy && client
|
|
3428
|
+
if (!session.proxy && client === 'ironrdp') {
|
|
3401
3429
|
const proxy = await (0, rdcleanpath_1.startRDCleanPathProxy)(
|
|
3402
3430
|
// A desktop connected to directly is reached by the proxy's own connection; one behind an SSH host
|
|
3403
3431
|
// through a channel of the SSH connection, carried to the proxy.
|
|
@@ -4057,7 +4085,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4057
4085
|
session.plainSignIn = false;
|
|
4058
4086
|
const settings = this.settingsFor(session);
|
|
4059
4087
|
const size = session.initialSize ?? remoteSizeFor(session.overlay.getBoundingClientRect(), settings);
|
|
4060
|
-
const native = new freerdp_1.FreeRDPProcess();
|
|
4088
|
+
const native = new freerdp_1.FreeRDPProcess('wasm');
|
|
4061
4089
|
const ui = new freerdpView_1.FreeRDPView(native, session.host);
|
|
4062
4090
|
ui.setReadOnly(session.viewOnly);
|
|
4063
4091
|
session.ui = ui;
|
|
@@ -4065,14 +4093,14 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4065
4093
|
const stop = () => ui.shutdown();
|
|
4066
4094
|
signal.addEventListener('abort', stop, { once: true });
|
|
4067
4095
|
session.onConnectionEnd(stop);
|
|
4068
|
-
session.log.push(`client: ${rdpClient_1.RDP_CLIENT_LABELS.freerdp}`);
|
|
4096
|
+
session.log.push(`client: ${rdpClient_1.RDP_CLIENT_LABELS[session.client ?? 'freerdp']}`);
|
|
4069
4097
|
const relaxOrderChecks = spec.relaxOrderChecks ?? this.settingsFor(session).relaxOrderChecks;
|
|
4070
4098
|
const glyphCache = spec.glyphCache ?? settings.glyphCache;
|
|
4071
4099
|
session.log.push(`FreeRDP glyph caching: ${glyphCache ? 'enabled (experimental)' : 'disabled'}`);
|
|
4072
4100
|
const bitmapCache = spec.bitmapCache ?? settings.bitmapCache;
|
|
4073
4101
|
session.log.push(`FreeRDP bitmap caching: ${bitmapCache ? 'enabled (experimental)' : 'disabled'}`);
|
|
4074
4102
|
session.log.push(`FreeRDP drawing order checks: ${relaxOrderChecks ? 'relaxed' : 'strict'}`);
|
|
4075
|
-
session.log.push('FreeRDP
|
|
4103
|
+
session.log.push('FreeRDP: pictures on the clipboard, audio, microphone and shared folders are unavailable');
|
|
4076
4104
|
// Text through the clipboard channel, the ways the settings let it go as they are now, for this connection.
|
|
4077
4105
|
session.clipboard = settings.clipboard;
|
|
4078
4106
|
session.log.push((0, freerdpClipboard_1.freeRDPClipboardLog)(session.clipboard));
|
|
@@ -4088,6 +4116,16 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4088
4116
|
},
|
|
4089
4117
|
narrow: ways => native.narrowClipboard(ways),
|
|
4090
4118
|
}, () => this.clipboardWaysOf(session), { focused: () => ui.isFocused(), viewOnly: () => ui.isViewOnly() });
|
|
4119
|
+
const fileModule = await importESM(vendor('iron-remote-desktop-rdp.js'));
|
|
4120
|
+
if (!alive()) {
|
|
4121
|
+
clipboard.stop();
|
|
4122
|
+
native.shutdown();
|
|
4123
|
+
return { connected: false };
|
|
4124
|
+
}
|
|
4125
|
+
session.files?.dispose();
|
|
4126
|
+
const Provider = (0, freerdpFiles_1.freeRDPFileProvider)(fileModule.RdpFileTransferProvider, (type, data) => native.send(type, data), () => session.viewOnly ? { toRemote: false, fromRemote: false } : this.clipboardWaysOf(session), () => clipboard.localFiles());
|
|
4127
|
+
session.files = new fileTransfer_1.FileTransfer({ RdpFileTransferProvider: Provider }, session.overlay, message => session.log.push(message), () => session.viewOnly ? { toRemote: false, fromRemote: false } : this.clipboardWaysOf(session));
|
|
4128
|
+
clipboard.filesPending = () => session.files?.provider.isUploadInProgress() ?? false;
|
|
4091
4129
|
ui.clipboardSender = () => clipboard.sendNow();
|
|
4092
4130
|
const { username, domain } = (0, accounts_1.signInParts)(endpoint.credentials.username, endpoint.domain ?? spec.domain ?? '');
|
|
4093
4131
|
const gateway = spec.gateway ? (0, gateway_1.parseGateway)(spec.gateway) : null;
|
|
@@ -4107,6 +4145,12 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4107
4145
|
bitmapCache,
|
|
4108
4146
|
clipboard: (0, clipboard_1.clipboardWays)(session.clipboard),
|
|
4109
4147
|
remoteText: text => clipboard.remote(text),
|
|
4148
|
+
clipboardFiles: (type, data) => {
|
|
4149
|
+
if (type === 'l') {
|
|
4150
|
+
clipboard.remoteChanged();
|
|
4151
|
+
}
|
|
4152
|
+
session.files?.provider.receive(type, data);
|
|
4153
|
+
},
|
|
4110
4154
|
open: async (abort) => {
|
|
4111
4155
|
const stream = gateway ? await this.throughGatewayStream(target, spec, session, gateway, endpoint, abort) : await target.openTcp(endpoint.host, endpoint.port);
|
|
4112
4156
|
if (abort.aborted) {
|
|
@@ -4131,7 +4175,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4131
4175
|
onConnected(Date.now());
|
|
4132
4176
|
clipboard.start();
|
|
4133
4177
|
session.remoteSize = { ...info, scale: 100 };
|
|
4134
|
-
session.graphics = 'FreeRDP
|
|
4178
|
+
session.graphics = 'FreeRDP WebAssembly bitmaps';
|
|
4135
4179
|
ui.setVisibility(session.visible);
|
|
4136
4180
|
this.applyKeyboardMode(session);
|
|
4137
4181
|
if (size.scale !== 100 || spec.kind === 'windows') {
|
|
@@ -4235,10 +4279,12 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4235
4279
|
// clipboard goes only the ways the settings let it, as they are now, for this connection (see clipboard.ts).
|
|
4236
4280
|
session.files?.dispose();
|
|
4237
4281
|
// What it reads for the remote waits for room in the connection (see ServerFlow).
|
|
4238
|
-
session.files = new fileTransfer_1.FileTransfer(rdp, session.overlay, m => session.log.push(m), () => this.clipboardWaysOf(session), session.proxy ?? undefined);
|
|
4282
|
+
session.files = new fileTransfer_1.FileTransfer(rdp, session.overlay, m => session.log.push(m), () => this.clipboardWaysOf(session), session.proxy ?? undefined, () => session.viewOnly);
|
|
4239
4283
|
const clipboard = (0, clipboard_1.setUpClipboard)(session.ui, session.files.provider, this.settingsFor(session).clipboard, () => this.clipboardWaysOf(session).toRemote);
|
|
4240
4284
|
session.clipboard = clipboard.mode;
|
|
4241
4285
|
session.stopSending = clipboard.stopSending;
|
|
4286
|
+
// A desktop in view only connects with its clipboard paused.
|
|
4287
|
+
session.pauseClipboard();
|
|
4242
4288
|
session.log.push(`clipboard: ${clipboard.mode === 'both' ? 'both ways'
|
|
4243
4289
|
: clipboard.mode === 'fromRemote' ? 'only from the remote desktop (this computer\'s is neither read nor sent)' : 'off (no clipboard channel)'}`);
|
|
4244
4290
|
// The component outlines itself while it has the keyboard; the desktop should look like the
|
package/dist/desktopForm.js
CHANGED
|
@@ -54,7 +54,7 @@ function askDesktop(pane, options) {
|
|
|
54
54
|
<option value="gnome">GNOME Remote Desktop (needs the graphics pipeline)</option>
|
|
55
55
|
</select>
|
|
56
56
|
<select class="form-control" name="client" aria-label="RDP client" title="RDP client. Applies on the next connection."></select>
|
|
57
|
-
<div class="text-muted small">FreeRDP
|
|
57
|
+
<div class="text-muted small">FreeRDP supports display, input and clipboard text/files. Clipboard images, sound, microphone and shared folders require IronRDP.</div>` + `
|
|
58
58
|
<select class="form-control" name="account" title="Saved accounts are added in Settings › Remote Desktop › Accounts"></select>
|
|
59
59
|
<input class="form-control" name="username" placeholder="User name (optional; asked when connecting)" spellcheck="false">
|
|
60
60
|
<input class="form-control" name="domain" placeholder="Domain (optional)" spellcheck="false">` + `
|
package/dist/fileTransfer.js
CHANGED
|
@@ -466,12 +466,14 @@ class FileTransfer {
|
|
|
466
466
|
/**
|
|
467
467
|
* `ways`: the ways the clipboard goes with this desktop right now (see RemoteDesktopService.clipboardWaysOf).
|
|
468
468
|
* `flow`: the room in the connection for what is read for the remote (the desktop's proxy, see ServerFlow).
|
|
469
|
+
* `viewOnly`: whether the desktop is in view only now, where no files go either way.
|
|
469
470
|
*/
|
|
470
|
-
constructor(rdp, overlay, log, ways, flow) {
|
|
471
|
+
constructor(rdp, overlay, log, ways, flow, viewOnly = () => false) {
|
|
471
472
|
this.overlay = overlay;
|
|
472
473
|
this.log = log;
|
|
473
474
|
this.ways = ways;
|
|
474
475
|
this.flow = flow;
|
|
476
|
+
this.viewOnly = viewOnly;
|
|
475
477
|
this.toastEl = null;
|
|
476
478
|
/** Files the remote offered last (for tests: saveAll). */
|
|
477
479
|
this.offered = [];
|
|
@@ -523,10 +525,13 @@ class FileTransfer {
|
|
|
523
525
|
/** Whether an answer for a request that is no more was dropped (logged once: see the constructor). */
|
|
524
526
|
this.stray = false;
|
|
525
527
|
this.provider = new rdp.RdpFileTransferProvider({ storageBackend: new diskStorage_1.DiskStorage() });
|
|
528
|
+
// The FreeRDP adapter checks duplicate wire stream IDs before handing a request here.
|
|
529
|
+
// Expire old reads first so its bookkeeping cannot refuse a reused stream forever.
|
|
530
|
+
this.provider.beforeFileContentsRequest = () => this.expire();
|
|
526
531
|
// The remote can ask again, later, for files offered from here: their contents go only while this computer's
|
|
527
532
|
// clipboard goes there. The provider's extensions call the method on it, so this one takes its place.
|
|
528
533
|
this.serve = this.provider.handleFileContentsRequest.bind(this.provider);
|
|
529
|
-
this.provider.handleFileContentsRequest = (request) => this.
|
|
534
|
+
this.provider.handleFileContentsRequest = (request) => this.goesThere() ? this.request(request) : this.refuse(request);
|
|
530
535
|
// The provider answers each request under the number it was handed it as (see read), and this goes with it to
|
|
531
536
|
// the connection under the remote's own number, and lets the room that request took go, which lets the requests
|
|
532
537
|
// waiting be read (see release). What it hands the connection takes room there as it goes (see ServerFlow). An
|
|
@@ -546,6 +551,10 @@ class FileTransfer {
|
|
|
546
551
|
return;
|
|
547
552
|
}
|
|
548
553
|
this.served.delete(number);
|
|
554
|
+
if (!this.goesThere()) {
|
|
555
|
+
isError = true;
|
|
556
|
+
data = new Uint8Array();
|
|
557
|
+
}
|
|
549
558
|
this.submit(served.streamId, isError, data);
|
|
550
559
|
if (!isError && data?.length) {
|
|
551
560
|
this.flow?.spend(data.length);
|
|
@@ -595,11 +604,19 @@ class FileTransfer {
|
|
|
595
604
|
});
|
|
596
605
|
}, true);
|
|
597
606
|
}
|
|
607
|
+
/** Whether files may go to the remote now: this computer's clipboard goes there, and not in view only. */
|
|
608
|
+
goesThere() {
|
|
609
|
+
return this.ways().toRemote && !this.viewOnly();
|
|
610
|
+
}
|
|
598
611
|
/**
|
|
599
|
-
* Whether files may go to the remote now
|
|
600
|
-
* the desktop.
|
|
612
|
+
* Whether files may go to the remote now (see goesThere); when not, says so over the desktop.
|
|
601
613
|
*/
|
|
602
614
|
mayGoThere() {
|
|
615
|
+
if (this.viewOnly()) {
|
|
616
|
+
this.log('files: not sent: the desktop is in view only');
|
|
617
|
+
this.toast('Not sent: this desktop is in view only.');
|
|
618
|
+
return false;
|
|
619
|
+
}
|
|
603
620
|
const ways = this.ways();
|
|
604
621
|
if (!ways.toRemote) {
|
|
605
622
|
this.log('files: not sent: this computer\'s clipboard doesn\'t go to the remote');
|
|
@@ -630,7 +647,8 @@ class FileTransfer {
|
|
|
630
647
|
}
|
|
631
648
|
}
|
|
632
649
|
/**
|
|
633
|
-
* The remote asked for files offered before the clipboard narrowed
|
|
650
|
+
* The remote asked for files offered before the clipboard narrowed, or while the desktop is in view only: it gets
|
|
651
|
+
* an error instead of their contents.
|
|
634
652
|
* `reading`: the request is one being read, which the error answers (see fail).
|
|
635
653
|
*/
|
|
636
654
|
refuse(request, reading) {
|
|
@@ -705,7 +723,7 @@ class FileTransfer {
|
|
|
705
723
|
return;
|
|
706
724
|
}
|
|
707
725
|
const request = this.waiting.shift();
|
|
708
|
-
if (!this.
|
|
726
|
+
if (!this.goesThere()) {
|
|
709
727
|
this.refuse(request);
|
|
710
728
|
continue;
|
|
711
729
|
}
|
|
@@ -747,7 +765,7 @@ class FileTransfer {
|
|
|
747
765
|
answer();
|
|
748
766
|
}
|
|
749
767
|
};
|
|
750
|
-
part.then(data => settled(() => this.
|
|
768
|
+
part.then(data => settled(() => this.goesThere() ? file.serving(start, end, data, () => this.read(request, reading)) : this.refuse(request, reading)), (e) => settled(() => this.unreadable(request, e?.message ?? String(e), reading)));
|
|
751
769
|
}
|
|
752
770
|
/**
|
|
753
771
|
* An error for the remote's request on `streamId`, from the plugin itself rather than the provider: it goes to the
|
|
@@ -775,6 +793,9 @@ class FileTransfer {
|
|
|
775
793
|
if (r.number !== null) {
|
|
776
794
|
this.served.delete(r.number);
|
|
777
795
|
}
|
|
796
|
+
// Drop adapter bookkeeping without sending a late error that could be mistaken
|
|
797
|
+
// for a reply to the server's new request on this stream.
|
|
798
|
+
this.provider.discardFileContentsRequest?.(r.streamId);
|
|
778
799
|
}
|
|
779
800
|
return live;
|
|
780
801
|
});
|
|
@@ -987,9 +1008,21 @@ class FileTransfer {
|
|
|
987
1008
|
const files = await this.provider.showFilePicker({ multiple: true });
|
|
988
1009
|
this.send(files);
|
|
989
1010
|
}
|
|
990
|
-
/**
|
|
1011
|
+
/**
|
|
1012
|
+
* Remote → Mac: the remote copied files; offer saving them, where the remote's clipboard comes here. Not in view
|
|
1013
|
+
* only, where what the remote copies is dropped (files offered before it can still be saved: the user asks for it).
|
|
1014
|
+
*/
|
|
991
1015
|
offer(files) {
|
|
1016
|
+
if (!files.length) {
|
|
1017
|
+
this.offered = [];
|
|
1018
|
+
this.toastEl?.remove();
|
|
1019
|
+
this.toastEl = null;
|
|
1020
|
+
}
|
|
992
1021
|
const count = files.filter(f => !f.isDirectory).length;
|
|
1022
|
+
if (this.viewOnly()) {
|
|
1023
|
+
this.log(`files: the remote copied ${count}; not offered: the desktop is in view only`);
|
|
1024
|
+
return;
|
|
1025
|
+
}
|
|
993
1026
|
if (!this.ways().fromRemote) {
|
|
994
1027
|
this.log(`files: the remote copied ${count}; not offered: its clipboard doesn't come here`);
|
|
995
1028
|
return;
|