tabby-rdp 0.6.0-rc.4 → 0.6.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +51 -0
- package/README.md +1 -1
- package/TROUBLESHOOTING.md +6 -0
- package/bin/SHA256SUMS +8 -0
- package/bin/darwin-arm64/tabby-rdp-proxy +0 -0
- package/bin/darwin-x64/tabby-rdp-proxy +0 -0
- package/bin/linux-arm/tabby-rdp-proxy +0 -0
- package/bin/linux-arm64/tabby-rdp-proxy +0 -0
- package/bin/linux-x64/tabby-rdp-proxy +0 -0
- package/bin/win32-arm64/tabby-rdp-proxy.exe +0 -0
- package/bin/win32-x64/tabby-rdp-proxy.exe +0 -0
- package/dist/accounts.js +17 -0
- package/dist/authorities.js +122 -1
- package/dist/desktop.service.js +114 -30
- package/dist/desktopForm.js +24 -7
- package/dist/desktops.js +3 -1
- package/dist/diagnosticLog.js +36 -3
- package/dist/diskStorage.js +36 -3
- package/dist/drives.js +35 -2
- package/dist/fileTransfer.js +40 -5
- package/dist/freerdp.js +19 -3
- package/dist/freerdpClipboard.js +124 -0
- package/dist/freerdpView.js +21 -0
- package/dist/gateway.js +34 -1
- package/dist/header.js +1 -7
- package/dist/headerVisibility.js +1 -3
- package/dist/index.js +4 -1
- package/dist/keyboard.js +2 -5
- package/dist/proxyHelper.js +611 -0
- package/dist/rdcleanpath.js +233 -852
- package/dist/rdpProfile.js +40 -21
- package/dist/releases.js +34 -1
- package/dist/remoteSetup.js +35 -2
- package/dist/settingsPage.js +27 -30
- package/dist/sshChannelStream.js +8 -1
- package/dist/targets.js +37 -2
- package/dist/ui.js +5 -6
- package/native/README.md +13 -4
- package/package.json +9 -9
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,56 @@
|
|
|
1
1
|
# Changelog
|
|
2
2
|
|
|
3
|
+
## 0.6.1
|
|
4
|
+
|
|
5
|
+
**Added**
|
|
6
|
+
- Clipboard text with the experimental FreeRDP client: both ways, only from the remote desktop, or off, as the clipboard setting (or a desktop's own) says. As with IronRDP, this computer's clipboard is read only while the desktop has the focus, and turning the clipboard off leaves the clipboard channel out of the connection. Unlike IronRDP, view only shares no clipboard in either direction. **Paste to all desktops** includes FreeRDP desktops, with text. Pictures and files on the clipboard still need IronRDP.
|
|
7
|
+
- A default-off **Bitmap caching (experimental)** setting for FreeRDP, next to glyph caching and relaxed drawing order checks, with the same per-connection overrides. It may help a PAM login screen where a picture, such as a logo, stays blank: some proxies draw pictures from cached bitmaps even when the client did not announce support for them. Not yet verified against a PAM proxy.
|
|
8
|
+
|
|
9
|
+
**Fixed**
|
|
10
|
+
- A PAM proxy's bracketed user name, such as senhasegura's `vault-user[DOMAIN\target-user@device]`, now reaches the proxy whole, with both clients ([#122](https://github.com/meanaverage/tabby-rdp/issues/122)). It was split at the backslash inside the brackets, so the proxy received a domain of `vault-user[DOMAIN` and a user name of `target-user@device]`, and couldn't find its target. `DOMAIN\user` is still split as before. With Network Level Authentication, IronRDP's NTLM or Kerberos sign-in still splits such a name at its backslash, and refuses one whose rest still has a `@` or backslash; PAM proxies that route by user name usually sign in without NLA. Not yet verified against a senhasegura proxy.
|
|
11
|
+
- A user name starting with a backslash now names no domain: everything after that backslash is sent as typed, without the domain field. This gives a way to send a proxy's user name that has a backslash outside brackets, such as WALLIX Bastion's `DOMAIN\user@target:login`, without it being split. The leading backslash was previously sent as part of the user name.
|
|
12
|
+
|
|
13
|
+
**Changed**
|
|
14
|
+
- Update build and QA dependencies, including Angular and Node declarations, TypeScript 7 with its compiler-API compatibility package, Playwright, WebSocket test fixtures and standalone Electron checks. These development tools are excluded from plugin installations.
|
|
15
|
+
|
|
16
|
+
## 0.6.0
|
|
17
|
+
|
|
18
|
+
**Added**
|
|
19
|
+
- Choose IronRDP or the experimental FreeRDP client globally or for an individual RDP profile or configured desktop. IronRDP remains the default. FreeRDP supports display and input; clipboard, audio, shared folders, Hyper-V consoles and H.264 decoding remain unavailable in that client.
|
|
20
|
+
- Automatically hide the window's title/tab header for a single connected desktop, with optional minimum window dimensions. Never and Always modes are also available. Hover reveals the header without resizing the desktop.
|
|
21
|
+
- Default-off FreeRDP compatibility settings for glyph caching and relaxed drawing-order checks, with independent per-connection overrides. Glyph caching may help missing text on older servers or PAM login screens but can cause display artifacts. Individual PAM proxies remain unverified.
|
|
22
|
+
- Optional PDU traces alongside diagnostic logs, with a viewer for connection, resize and graphics timing. Traces record protocol structure and sizes, omitting credentials, keystrokes, clipboard contents and bitmap data.
|
|
23
|
+
|
|
24
|
+
**Fixed**
|
|
25
|
+
- Windows' default self-signed RDP certificates connect through IronRDP with forward-secret TLS 1.2 and ECDHE, while retaining certificate authority/fingerprint checks before sign-in ([#102](https://github.com/meanaverage/tabby-rdp/issues/102)). RSA key exchange is no longer offered; servers requiring it cannot connect. Logs show the negotiated TLS version and cipher. RD Gateway HTTPS may use TLS 1.3.
|
|
26
|
+
- Preserve the bitmap cache and Progressive tile state across Windows desktop resizes, preventing stale picture fragments, black bars and taskbar corruption ([#115](https://github.com/meanaverage/tabby-rdp/issues/115)).
|
|
27
|
+
- Tab-switch shortcuts no longer send their digit to the previously active remote desktop. macOS file pastes work when Electron omits native filesystem path resolution.
|
|
28
|
+
- Cancelling RD Gateway setup waits for its transport to close. FreeRDP also handles Unicode shortcuts, international keys, mouse-button chords, display-control resize and bounded input queues; it requires CredSSP version 5 or newer before authentication.
|
|
29
|
+
- Header auto-hide settles after resize reconnects, preserves native menu visibility and keeps revealed controls usable. Remote Desktop settings use Tabby's native toggle controls.
|
|
30
|
+
|
|
31
|
+
**Changed**
|
|
32
|
+
- Group settings by connection, display, keyboard, sound, sharing, SSH integration, compatibility and diagnostics, with everyday controls first.
|
|
33
|
+
- Run IronRDP connections through the bundled Go network helper on supported macOS, Windows and Linux architectures. Each desktop owns its helper and closes it when the connection ends.
|
|
34
|
+
- Install FreeRDP through optional platform-specific helper packages for macOS ARM64, Linux ARM64/x64 and Windows ARM64/x64. Intel Macs continue to use IronRDP. A synchronized global FreeRDP default falls back to IronRDP when the native helper is unavailable; an explicit per-connection choice reports the missing helper.
|
|
35
|
+
- Update the locked WinRM and QA download dependencies, and add scheduled dependency monitoring. These tools are excluded from plugin installations.
|
|
36
|
+
|
|
37
|
+
Requires Tabby 1.0.236 or later. Desktop qualification covers macOS, Linux and Windows ARM64 clients against Windows 11, Windows Server 2022/2025, GNOME and xrdp, plus the documented experimental KRDP setup. Additional Windows x64 direct and gateway checks passed. See the [compatibility guide](docs/compatibility.md) for client and server limitations.
|
|
38
|
+
|
|
39
|
+
## 0.6.0-rc.5 (not published; included in 0.6.0)
|
|
40
|
+
|
|
41
|
+
**Added**
|
|
42
|
+
- Default-off experimental glyph caching for FreeRDP, with independent overrides in RDP profiles and configured desktops. It can help older RDP servers or PAM login screens with missing text; support for individual proxies still needs validation.
|
|
43
|
+
|
|
44
|
+
**Fixed**
|
|
45
|
+
- Cancelling RD Gateway setup closes its transport before returning, including when TLS shutdown and setup failure overlap.
|
|
46
|
+
- Pasting files copied on macOS works when Electron's filesystem wrapper omits native path resolution. Links inside a copied folder remain restricted to that folder.
|
|
47
|
+
- A Tabby shortcut that switches tabs no longer sends its key to the desktop being left while that desktop still has DOM focus.
|
|
48
|
+
- Windows' default self-signed RDP certificate now connects with forward-secret TLS in IronRDP ([#102](https://github.com/meanaverage/tabby-rdp/issues/102)). The RDP connection runs in the plugin's Go network helper, which accepts that certificate's key usage while still checking its fingerprint or authority before sign-in. RDP uses TLS 1.2 with ECDHE; RD Gateway HTTPS may use TLS 1.3. RSA key exchange is no longer offered, so a server that only offers it cannot connect. The negotiated version and cipher are shown in the connection log.
|
|
49
|
+
|
|
50
|
+
**Changed**
|
|
51
|
+
- Group Remote Desktop settings by connection, display, keyboard, sharing, SSH integration, compatibility and diagnostics. FreeRDP compatibility controls follow the everyday settings.
|
|
52
|
+
- The plugin package includes the network helper for supported macOS, Windows and Linux architectures. Tabby starts one per open IronRDP desktop and stops it when the desktop closes. FreeRDP remains an optional, experimental client with its own helper package.
|
|
53
|
+
|
|
3
54
|
## 0.6.0-rc.4
|
|
4
55
|
|
|
5
56
|
**Added**
|
package/README.md
CHANGED
|
@@ -135,7 +135,7 @@ In an RDP profile tab's **…** menu, choose **RDP client** to switch that profi
|
|
|
135
135
|
| Client | Availability | Capabilities |
|
|
136
136
|
|---|---|---|
|
|
137
137
|
| IronRDP (default) | macOS, Windows and Linux | The features above, subject to the server's capabilities |
|
|
138
|
-
| FreeRDP (experimental) | macOS ARM64; Windows and Linux ARM64/x64 native helpers | In-tab display, keyboard/mouse, scaling, resize, view only, screenshots and reconnect. Clipboard
|
|
138
|
+
| FreeRDP (experimental) | macOS ARM64; Windows and Linux ARM64/x64 native helpers | In-tab display, keyboard/mouse, clipboard text, scaling, resize, view only, screenshots and reconnect. Clipboard pictures and files, file transfer, audio, shared folders, Hyper-V and H.264 are pending. |
|
|
139
139
|
|
|
140
140
|
Windows Server performance has **not been benchmarked**. See [FreeRDP builds, licensing and capability notes](native/README.md).
|
|
141
141
|
To try the preview, open **Settings › Remote Desktop › Updates**, choose **Preview**, and install the offered version.
|
package/TROUBLESHOOTING.md
CHANGED
|
@@ -68,6 +68,12 @@ In an SSH tab (or a split pane) where you typed `ssh` on to another machine, **D
|
|
|
68
68
|
|
|
69
69
|
GNOME Remote Desktop's headless mode gives each connection a screen of its own: a second computer, or another Tabby window, connected to the same account gets an empty extra screen rather than the same one. So when the desktop is open somewhere else already, you choose. **Take it over** disconnects the other connection, as Windows does; the session and its apps carry on, on this screen. **Open a second screen** keeps both, each with a screen of its own. A desktop taken over from here doesn't take itself back: it says so, and offers the same two choices.
|
|
70
70
|
|
|
71
|
+
<a id="helper"></a>
|
|
72
|
+
|
|
73
|
+
## "The network helper …" in a desktop's error
|
|
74
|
+
|
|
75
|
+
From 0.6.0, connections run in a small program of the plugin's own, `tabby-rdp-proxy` (in the plugin's folder, under `bin/`), which Tabby starts for each open desktop and stops with it. It needs no installation of its own: it comes in the package, for macOS, Windows and Linux on x64 and ARM. "No network helper for …" means the package lacks this computer's (a system or processor it doesn't ship for, or a copy that lost it): reinstall the plugin. "Stopped unexpectedly" names how it ended and its last words, in the desktop's log; the desktop's next try starts a new one. Security software that blocks programs it doesn't know can stop it starting, or close its connections: allow `tabby-rdp-proxy` from Tabby's plugins folder. It listens on 127.0.0.1 only, for the desktop's own client, and connects to the desktops and gateways you open (through SSH, its bytes go through Tabby's own connection instead).
|
|
76
|
+
|
|
71
77
|
<a id="recovery"></a>
|
|
72
78
|
|
|
73
79
|
## Recover a version, disable the plugin, or remove it
|
package/bin/SHA256SUMS
ADDED
|
@@ -0,0 +1,8 @@
|
|
|
1
|
+
# The network helpers, built from helper/ with go1.27.1 by scripts/build-helper.mjs (tabby-rdp 0.6.1).
|
|
2
|
+
b04dceab864fec7f66d6a2d6c9ebbcf8d91b5d1444d5d276ff418d3c14e61332 bin/darwin-arm64/tabby-rdp-proxy
|
|
3
|
+
c04d13b951dc296ec93aec010bdab646457ffc0ad829ee1cfa01721636538d09 bin/darwin-x64/tabby-rdp-proxy
|
|
4
|
+
5f7189fdcc43f1d70639f0d45a3e46a13737f721fd1433fac9ba2d7aa73caab4 bin/linux-x64/tabby-rdp-proxy
|
|
5
|
+
542978de52b0ecddce6ff4344c7fe33de9017c813ea71faa41b5fc235476d2dc bin/linux-arm64/tabby-rdp-proxy
|
|
6
|
+
76d631cfc627fdf0436e218b3ebf6d8eec3a7d81031f317322375fb78485d2ad bin/linux-arm/tabby-rdp-proxy
|
|
7
|
+
2fffe2f2954ffcec47452e934f452b4fcb15de6a4d4f2d0493735207b6ceaf29 bin/win32-x64/tabby-rdp-proxy.exe
|
|
8
|
+
4259dc5bb840d899d77f5f69b61483ecb7d5747d4515bd2a4a3b13ac7cd651ea bin/win32-arm64/tabby-rdp-proxy.exe
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
|
Binary file
|
package/dist/accounts.js
CHANGED
|
@@ -4,6 +4,7 @@ exports.ASK_GATEWAY_ACCOUNT = void 0;
|
|
|
4
4
|
exports.accountsOf = accountsOf;
|
|
5
5
|
exports.newAccountId = newAccountId;
|
|
6
6
|
exports.signInName = signInName;
|
|
7
|
+
exports.signInParts = signInParts;
|
|
7
8
|
exports.accountKey = accountKey;
|
|
8
9
|
/** A separate gateway sign-in prompt. The '@' cannot occur in a saved account's id. */
|
|
9
10
|
exports.ASK_GATEWAY_ACCOUNT = '@ask';
|
|
@@ -36,6 +37,22 @@ function newAccountId(taken) {
|
|
|
36
37
|
function signInName(account) {
|
|
37
38
|
return account.domain && !/[\\@]/.test(account.username) ? `${account.domain}\\${account.username}` : account.username;
|
|
38
39
|
}
|
|
40
|
+
/**
|
|
41
|
+
* The user name and domain a sign-in goes to the server with, for either client: DOMAIN\user split at its backslash,
|
|
42
|
+
* and any other name as typed, with `domain` (the desktop's) beside it. A PAM proxy's name keeps its backslash inside
|
|
43
|
+
* square brackets (senhasegura's `vault-user[DOMAIN\target-user@device]`) and is read whole by the proxy, which finds
|
|
44
|
+
* its target there, so a name with a bracket before its backslash goes as typed too. A leading backslash names no
|
|
45
|
+
* domain at all (as other RDP clients read it): the rest goes as typed, without one, for a proxy whose name has a
|
|
46
|
+
* backslash of its own outside brackets (WALLIX's `DOMAIN\user@target:login`).
|
|
47
|
+
*/
|
|
48
|
+
function signInParts(username, domain) {
|
|
49
|
+
const bare = /^\\(.+)$/.exec(username);
|
|
50
|
+
if (bare) {
|
|
51
|
+
return { username: bare[1], domain: '' };
|
|
52
|
+
}
|
|
53
|
+
const split = /^([^\\[\]]+)\\(.+)$/.exec(username);
|
|
54
|
+
return split ? { username: split[2], domain: split[1] } : { username, domain };
|
|
55
|
+
}
|
|
39
56
|
/** Where the keychain keeps an account's password (next to the desktops' own entries, which are session keys). */
|
|
40
57
|
function accountKey(id) {
|
|
41
58
|
return `account#${id}`;
|
package/dist/authorities.js
CHANGED
|
@@ -1,9 +1,45 @@
|
|
|
1
1
|
"use strict";
|
|
2
|
+
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
|
|
3
|
+
if (k2 === undefined) k2 = k;
|
|
4
|
+
var desc = Object.getOwnPropertyDescriptor(m, k);
|
|
5
|
+
if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
|
|
6
|
+
desc = { enumerable: true, get: function() { return m[k]; } };
|
|
7
|
+
}
|
|
8
|
+
Object.defineProperty(o, k2, desc);
|
|
9
|
+
}) : (function(o, m, k, k2) {
|
|
10
|
+
if (k2 === undefined) k2 = k;
|
|
11
|
+
o[k2] = m[k];
|
|
12
|
+
}));
|
|
13
|
+
var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
|
|
14
|
+
Object.defineProperty(o, "default", { enumerable: true, value: v });
|
|
15
|
+
}) : function(o, v) {
|
|
16
|
+
o["default"] = v;
|
|
17
|
+
});
|
|
18
|
+
var __importStar = (this && this.__importStar) || (function () {
|
|
19
|
+
var ownKeys = function(o) {
|
|
20
|
+
ownKeys = Object.getOwnPropertyNames || function (o) {
|
|
21
|
+
var ar = [];
|
|
22
|
+
for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
|
|
23
|
+
return ar;
|
|
24
|
+
};
|
|
25
|
+
return ownKeys(o);
|
|
26
|
+
};
|
|
27
|
+
return function (mod) {
|
|
28
|
+
if (mod && mod.__esModule) return mod;
|
|
29
|
+
var result = {};
|
|
30
|
+
if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
|
|
31
|
+
__setModuleDefault(result, mod);
|
|
32
|
+
return result;
|
|
33
|
+
};
|
|
34
|
+
})();
|
|
2
35
|
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
36
|
exports.certificateAuthorities = certificateAuthorities;
|
|
4
37
|
exports.chainStanding = chainStanding;
|
|
5
38
|
exports.whyNotValid = whyNotValid;
|
|
6
39
|
exports.certificateDetails = certificateDetails;
|
|
40
|
+
exports.authoritiesPem = authoritiesPem;
|
|
41
|
+
exports.peerCertificate = peerCertificate;
|
|
42
|
+
exports.validity = validity;
|
|
7
43
|
exports.describeCertificate = describeCertificate;
|
|
8
44
|
exports.vouched = vouched;
|
|
9
45
|
/**
|
|
@@ -12,7 +48,7 @@ exports.vouched = vouched;
|
|
|
12
48
|
* pass, and what a certificate says of itself, in words for the user.
|
|
13
49
|
*/
|
|
14
50
|
const crypto_1 = require("crypto");
|
|
15
|
-
const tls = require("tls");
|
|
51
|
+
const tls = __importStar(require("tls"));
|
|
16
52
|
const unshowable_1 = require("./unshowable");
|
|
17
53
|
let authorities = null;
|
|
18
54
|
let systemRead = false;
|
|
@@ -298,6 +334,91 @@ function certificateDetails(certificate, checked) {
|
|
|
298
334
|
...chain === 'authority' && !READ_REASONS.has(checked?.reason ?? '') ? { unchecked: true } : {},
|
|
299
335
|
};
|
|
300
336
|
}
|
|
337
|
+
/** A `ca` list (PEM, as TLS options take it), or Node's own list without one, as the PEM text of all of it. */
|
|
338
|
+
function authoritiesPem(authorities) {
|
|
339
|
+
return [authorities ?? certificateAuthorities() ?? tls.rootCertificates].flat().map(item => String(item)).join('\n');
|
|
340
|
+
}
|
|
341
|
+
/** The certificates of a `ca` list, parsed, by the list they were read from. */
|
|
342
|
+
const parsedByList = new WeakMap();
|
|
343
|
+
function parsedAuthorities(authorities) {
|
|
344
|
+
const cached = typeof authorities === 'object' && authorities ? parsedByList.get(authorities) : undefined;
|
|
345
|
+
if (cached) {
|
|
346
|
+
return cached;
|
|
347
|
+
}
|
|
348
|
+
const parsed = [];
|
|
349
|
+
for (const pem of authoritiesPem(authorities).matchAll(/-----BEGIN CERTIFICATE-----[^-]+-----END CERTIFICATE-----/g)) {
|
|
350
|
+
try {
|
|
351
|
+
parsed.push(new crypto_1.X509Certificate(pem[0]));
|
|
352
|
+
}
|
|
353
|
+
catch { }
|
|
354
|
+
}
|
|
355
|
+
if (typeof authorities === 'object' && authorities) {
|
|
356
|
+
parsedByList.set(authorities, parsed);
|
|
357
|
+
}
|
|
358
|
+
return parsed;
|
|
359
|
+
}
|
|
360
|
+
/**
|
|
361
|
+
* A server's certificate as Node's TLS read it (TLSSocket.getPeerCertificate(true)), from the chain it sent (DER, its
|
|
362
|
+
* own certificate first) and the authorities its connection was checked against, now that the network helper does
|
|
363
|
+
* the TLS: each certificate's issuer is the next one the server sent that issued it, else one of the authorities that
|
|
364
|
+
* did (as OpenSSL takes a certificate for another's issuer: by name, key identifiers and key usage), up to one that is
|
|
365
|
+
* its own issuer, which is its own issuerCertificate, as Node has it. Undefined without a certificate it can read.
|
|
366
|
+
*/
|
|
367
|
+
function peerCertificate(chain, authorities) {
|
|
368
|
+
const sent = [];
|
|
369
|
+
for (const der of chain) {
|
|
370
|
+
try {
|
|
371
|
+
sent.push(new crypto_1.X509Certificate(der));
|
|
372
|
+
}
|
|
373
|
+
catch {
|
|
374
|
+
if (!sent.length) {
|
|
375
|
+
return undefined;
|
|
376
|
+
}
|
|
377
|
+
}
|
|
378
|
+
}
|
|
379
|
+
if (!sent.length) {
|
|
380
|
+
return undefined;
|
|
381
|
+
}
|
|
382
|
+
const legacy = (c) => c.toLegacyObject();
|
|
383
|
+
const anchors = parsedAuthorities(authorities ?? certificateAuthorities() ?? tls.rootCertificates);
|
|
384
|
+
const leaf = legacy(sent[0]);
|
|
385
|
+
const used = new Set([sent[0]]);
|
|
386
|
+
let current = leaf;
|
|
387
|
+
let currentX = sent[0];
|
|
388
|
+
// A chain is a few certificates long; a server can send more, which go unused.
|
|
389
|
+
for (let depth = 0; depth < 16; depth++) {
|
|
390
|
+
if (currentX.checkIssued(currentX)) {
|
|
391
|
+
current.issuerCertificate = current;
|
|
392
|
+
break;
|
|
393
|
+
}
|
|
394
|
+
const next = sent.find(c => !used.has(c) && currentX.checkIssued(c)) ?? anchors.find(c => !used.has(c) && currentX.checkIssued(c));
|
|
395
|
+
if (!next) {
|
|
396
|
+
break;
|
|
397
|
+
}
|
|
398
|
+
used.add(next);
|
|
399
|
+
const issuer = legacy(next);
|
|
400
|
+
current.issuerCertificate = issuer;
|
|
401
|
+
current = issuer;
|
|
402
|
+
currentX = next;
|
|
403
|
+
}
|
|
404
|
+
return leaf;
|
|
405
|
+
}
|
|
406
|
+
/**
|
|
407
|
+
* Whether a certificate is valid for `name`, and why not: from the network helper's check of its chain against the
|
|
408
|
+
* authorities (`chainOk`, and OpenSSL's reason where it doesn't lead to one), then, as Node checks a name once the
|
|
409
|
+
* chain has passed, by Node's own rule for names (tls.checkServerIdentity). Without a name, never valid, and no reason
|
|
410
|
+
* (the desktops reached through an SSH host, whose names are that host's).
|
|
411
|
+
*/
|
|
412
|
+
function validity(name, chainOk, reason, peer) {
|
|
413
|
+
if (!name) {
|
|
414
|
+
return { valid: false, reason: '' };
|
|
415
|
+
}
|
|
416
|
+
if (!chainOk || !peer) {
|
|
417
|
+
return { valid: false, reason: reason || 'UNABLE_TO_VERIFY_LEAF_SIGNATURE' };
|
|
418
|
+
}
|
|
419
|
+
const wrong = tls.checkServerIdentity(name, peer);
|
|
420
|
+
return wrong ? { valid: false, reason: wrong.code ?? wrong.message } : { valid: true, reason: '' };
|
|
421
|
+
}
|
|
301
422
|
/**
|
|
302
423
|
* A certificate's details in a line: "Issued to <name> (<names>) by <issuer>, valid <from> to <to>." The server chose
|
|
303
424
|
* all of it, so what could reorder or hide part of it shows as U+FFFD, and each part is cut short. `unchecked`: no
|
package/dist/desktop.service.js
CHANGED
|
@@ -1,10 +1,43 @@
|
|
|
1
1
|
"use strict";
|
|
2
|
+
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
|
|
3
|
+
if (k2 === undefined) k2 = k;
|
|
4
|
+
var desc = Object.getOwnPropertyDescriptor(m, k);
|
|
5
|
+
if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
|
|
6
|
+
desc = { enumerable: true, get: function() { return m[k]; } };
|
|
7
|
+
}
|
|
8
|
+
Object.defineProperty(o, k2, desc);
|
|
9
|
+
}) : (function(o, m, k, k2) {
|
|
10
|
+
if (k2 === undefined) k2 = k;
|
|
11
|
+
o[k2] = m[k];
|
|
12
|
+
}));
|
|
13
|
+
var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
|
|
14
|
+
Object.defineProperty(o, "default", { enumerable: true, value: v });
|
|
15
|
+
}) : function(o, v) {
|
|
16
|
+
o["default"] = v;
|
|
17
|
+
});
|
|
2
18
|
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
|
|
3
19
|
var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
|
|
4
20
|
if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
|
|
5
21
|
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
|
|
6
22
|
return c > 3 && r && Object.defineProperty(target, key, r), r;
|
|
7
23
|
};
|
|
24
|
+
var __importStar = (this && this.__importStar) || (function () {
|
|
25
|
+
var ownKeys = function(o) {
|
|
26
|
+
ownKeys = Object.getOwnPropertyNames || function (o) {
|
|
27
|
+
var ar = [];
|
|
28
|
+
for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
|
|
29
|
+
return ar;
|
|
30
|
+
};
|
|
31
|
+
return ownKeys(o);
|
|
32
|
+
};
|
|
33
|
+
return function (mod) {
|
|
34
|
+
if (mod && mod.__esModule) return mod;
|
|
35
|
+
var result = {};
|
|
36
|
+
if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
|
|
37
|
+
__setModuleDefault(result, mod);
|
|
38
|
+
return result;
|
|
39
|
+
};
|
|
40
|
+
})();
|
|
8
41
|
var __metadata = (this && this.__metadata) || function (k, v) {
|
|
9
42
|
if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
|
|
10
43
|
};
|
|
@@ -15,9 +48,9 @@ exports.installStyle = installStyle;
|
|
|
15
48
|
const core_1 = require("@angular/core");
|
|
16
49
|
const rxjs_1 = require("rxjs");
|
|
17
50
|
const tabby_core_1 = require("tabby-core");
|
|
18
|
-
const fs = require("fs");
|
|
19
|
-
const os = require("os");
|
|
20
|
-
const path = require("path");
|
|
51
|
+
const fs = __importStar(require("fs"));
|
|
52
|
+
const os = __importStar(require("os"));
|
|
53
|
+
const path = __importStar(require("path"));
|
|
21
54
|
const net_1 = require("net");
|
|
22
55
|
const url_1 = require("url");
|
|
23
56
|
const targets_1 = require("./targets");
|
|
@@ -26,6 +59,7 @@ const audio_1 = require("./audio");
|
|
|
26
59
|
const ironrdp_1 = require("./ironrdp");
|
|
27
60
|
const rdpClient_1 = require("./rdpClient");
|
|
28
61
|
const freerdp_1 = require("./freerdp");
|
|
62
|
+
const freerdpClipboard_1 = require("./freerdpClipboard");
|
|
29
63
|
const freerdpView_1 = require("./freerdpView");
|
|
30
64
|
const h264_1 = require("./h264");
|
|
31
65
|
const clipboard_1 = require("./clipboard");
|
|
@@ -2392,6 +2426,8 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
2392
2426
|
headerMinWidth: this.headerSize(store.headerMinWidth),
|
|
2393
2427
|
headerMinHeight: this.headerSize(store.headerMinHeight),
|
|
2394
2428
|
client: (0, rdpClient_1.rdpClient)(store.client),
|
|
2429
|
+
glyphCache: store.glyphCache === true,
|
|
2430
|
+
bitmapCache: store.bitmapCache === true,
|
|
2395
2431
|
relaxOrderChecks: store.relaxOrderChecks === true,
|
|
2396
2432
|
resize: ['live', 'reconnect', 'off'].includes(store.resize) ? store.resize : 'live',
|
|
2397
2433
|
sharpness: store.sharpness === 'retina' ? 'retina' : 'standard',
|
|
@@ -3354,9 +3390,19 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3354
3390
|
}
|
|
3355
3391
|
asked.gatewayAccount = signIn;
|
|
3356
3392
|
}
|
|
3357
|
-
// The proxy outlives an attempt: it reads the sign-in of the attempt it serves.
|
|
3393
|
+
// The proxy outlives an attempt: it reads the sign-in of the attempt it serves. One whose network helper
|
|
3394
|
+
// stopped (it failed, or was killed) is replaced: nothing connects there any more.
|
|
3395
|
+
if (session.proxy?.ended) {
|
|
3396
|
+
session.log.push('proxy: its network helper has stopped; starting another');
|
|
3397
|
+
session.proxy.close();
|
|
3398
|
+
session.proxy = null;
|
|
3399
|
+
}
|
|
3358
3400
|
if (!session.proxy && client !== 'freerdp') {
|
|
3359
|
-
const proxy = await (0, rdcleanpath_1.startRDCleanPathProxy)(
|
|
3401
|
+
const proxy = await (0, rdcleanpath_1.startRDCleanPathProxy)(
|
|
3402
|
+
// A desktop connected to directly is reached by the proxy's own connection; one behind an SSH host
|
|
3403
|
+
// through a channel of the SSH connection, carried to the proxy.
|
|
3404
|
+
async (_destination, signal) => gateway ? this.throughGateway(target, spec, session, gateway, endpoint, signal)
|
|
3405
|
+
: target.direct ? { direct: { host: asked.host, port: asked.port } } : target.openTcp(asked.host, asked.port), (fingerprint, valid, reason, details) => this.checkCertificate(session, fingerprint, valid, reason, details), m => session.log.push(m), {
|
|
3360
3406
|
autologon: spec.kind === 'xrdp',
|
|
3361
3407
|
withoutNla: () => this.checkWithoutNla(session),
|
|
3362
3408
|
// Let through before TLS: the permission is held to the certificate the server then shows.
|
|
@@ -3476,8 +3522,9 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3476
3522
|
return entered && { ...signIn, credentials: entered, remember: !!signIn && entered.remember };
|
|
3477
3523
|
}
|
|
3478
3524
|
/**
|
|
3479
|
-
* The proxy's
|
|
3480
|
-
* computer) reaches it, signed in with the gateway's own account or else the desktop's, then on to the desktop.
|
|
3525
|
+
* The proxy's way to a desktop behind an RD Gateway (see GatewayUpstream): to the gateway as the SSH host (or this
|
|
3526
|
+
* computer) reaches it, signed in with the gateway's own account or else the desktop's, then on to the desktop. The
|
|
3527
|
+
* account goes to the proxy only once the gateway's certificate is accepted.
|
|
3481
3528
|
*/
|
|
3482
3529
|
async throughGateway(target, spec, session, gateway, endpoint, signal) {
|
|
3483
3530
|
session.gatewayRefused = null;
|
|
@@ -3485,21 +3532,41 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
3485
3532
|
if (spec.gatewayAccount && !own) {
|
|
3486
3533
|
throw new Error('A separate gateway sign-in is required before connecting.');
|
|
3487
3534
|
}
|
|
3535
|
+
if (signal?.aborted) {
|
|
3536
|
+
throw new Error('the desktop was closed meanwhile');
|
|
3537
|
+
}
|
|
3488
3538
|
const credentials = own?.credentials ?? endpoint.credentials;
|
|
3489
3539
|
session.log.push(`gateway: ${gateway.host}:${gateway.port}, signing in with ${own ? 'its separate account' : 'the desktop\'s sign-in'}`);
|
|
3540
|
+
return {
|
|
3541
|
+
gateway: { host: gateway.host, port: gateway.port },
|
|
3542
|
+
target: { host: endpoint.host, port: endpoint.port },
|
|
3543
|
+
via: target.direct ? { direct: { host: gateway.host, port: gateway.port } } : () => target.openTcp(gateway.host, gateway.port),
|
|
3544
|
+
clientName: os.hostname(),
|
|
3545
|
+
checkCertificate: (fingerprint, valid, reason, details) => this.checkGatewayCertificate(session, gateway, fingerprint, valid, reason, details),
|
|
3546
|
+
account: () => ({ username: credentials.username, password: credentials.password, domain: (own ? own.domain : endpoint.domain ?? spec.domain) || undefined }),
|
|
3547
|
+
// The gateway refused the account (its sign-in, or its connection authorization policy).
|
|
3548
|
+
refused: message => { session.gatewayRefused = message; },
|
|
3549
|
+
opened: () => {
|
|
3550
|
+
// Entered a moment ago and taken by the gateway: kept, while the account is still what it was signed in as.
|
|
3551
|
+
if (own?.remember && own.saveKey) {
|
|
3552
|
+
own.remember = false;
|
|
3553
|
+
const saveKey = own.saveKey;
|
|
3554
|
+
(0, signin_1.saveCredentialsIf)(saveKey, own.credentials, () => this.accountCurrent(saveKey, own.saveFor, own.accountRevision), own.saveLabel).then(saved => session.log.push(saved ? `gateway: saved as the account's password in ${(0, signin_1.storeName)()}` : 'gateway: not saved: the account changed meanwhile'), e => session.log.push(`gateway: ${(0, signin_1.storeName)()}: ${e?.message ?? e}`));
|
|
3555
|
+
}
|
|
3556
|
+
},
|
|
3557
|
+
};
|
|
3558
|
+
}
|
|
3559
|
+
/** FreeRDP still uses the plugin's stream-based gateway while IronRDP's helper owns its tunnel. */
|
|
3560
|
+
async throughGatewayStream(target, spec, session, gateway, endpoint, signal) {
|
|
3561
|
+
const route = await this.throughGateway(target, spec, session, gateway, endpoint, signal);
|
|
3490
3562
|
try {
|
|
3491
|
-
const stream = await (0, gateway_1.openThroughGateway)(() => target.openTcp(gateway.host, gateway.port), gateway,
|
|
3492
|
-
|
|
3493
|
-
if (own?.remember && own.saveKey) {
|
|
3494
|
-
own.remember = false;
|
|
3495
|
-
const saveKey = own.saveKey;
|
|
3496
|
-
(0, signin_1.saveCredentialsIf)(saveKey, own.credentials, () => this.accountCurrent(saveKey, own.saveFor, own.accountRevision), own.saveLabel).then(saved => session.log.push(saved ? `gateway: saved as the account's password in ${(0, signin_1.storeName)()}` : 'gateway: not saved: the account changed meanwhile'), e => session.log.push(`gateway: ${(0, signin_1.storeName)()}: ${e?.message ?? e}`));
|
|
3497
|
-
}
|
|
3563
|
+
const stream = await (0, gateway_1.openThroughGateway)(() => target.openTcp(gateway.host, gateway.port), gateway, await route.account(), route.target, route.checkCertificate, { log: m => session.log.push(m), clientName: route.clientName, signal });
|
|
3564
|
+
route.opened?.();
|
|
3498
3565
|
return stream;
|
|
3499
3566
|
}
|
|
3500
3567
|
catch (e) {
|
|
3501
3568
|
if (e instanceof gateway_1.GatewaySignInError) {
|
|
3502
|
-
|
|
3569
|
+
route.refused?.(e.message);
|
|
3503
3570
|
}
|
|
3504
3571
|
throw e;
|
|
3505
3572
|
}
|
|
@@ -4000,10 +4067,29 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4000
4067
|
session.onConnectionEnd(stop);
|
|
4001
4068
|
session.log.push(`client: ${rdpClient_1.RDP_CLIENT_LABELS.freerdp}`);
|
|
4002
4069
|
const relaxOrderChecks = spec.relaxOrderChecks ?? this.settingsFor(session).relaxOrderChecks;
|
|
4070
|
+
const glyphCache = spec.glyphCache ?? settings.glyphCache;
|
|
4071
|
+
session.log.push(`FreeRDP glyph caching: ${glyphCache ? 'enabled (experimental)' : 'disabled'}`);
|
|
4072
|
+
const bitmapCache = spec.bitmapCache ?? settings.bitmapCache;
|
|
4073
|
+
session.log.push(`FreeRDP bitmap caching: ${bitmapCache ? 'enabled (experimental)' : 'disabled'}`);
|
|
4003
4074
|
session.log.push(`FreeRDP drawing order checks: ${relaxOrderChecks ? 'relaxed' : 'strict'}`);
|
|
4004
|
-
session.log.push('FreeRDP preview: clipboard, audio, microphone and shared folders are unavailable');
|
|
4005
|
-
|
|
4006
|
-
|
|
4075
|
+
session.log.push('FreeRDP preview: pictures and files on the clipboard, audio, microphone and shared folders are unavailable');
|
|
4076
|
+
// Text through the clipboard channel, the ways the settings let it go as they are now, for this connection.
|
|
4077
|
+
session.clipboard = settings.clipboard;
|
|
4078
|
+
session.log.push((0, freerdpClipboard_1.freeRDPClipboardLog)(session.clipboard));
|
|
4079
|
+
const clipboard = new freerdpClipboard_1.FreeRDPClipboard({
|
|
4080
|
+
read: () => this.platform.readClipboard(),
|
|
4081
|
+
write: text => this.platform.setClipboard({ text }),
|
|
4082
|
+
send: text => {
|
|
4083
|
+
// Refused: what the helper held before is withdrawn too, so that a paste there doesn't get older text.
|
|
4084
|
+
if (!native.sendClipboardText(text)) {
|
|
4085
|
+
native.sendClipboardText('');
|
|
4086
|
+
session.log.push('clipboard: text larger than 1 MiB, or with a NUL character in it, is not sent');
|
|
4087
|
+
}
|
|
4088
|
+
},
|
|
4089
|
+
narrow: ways => native.narrowClipboard(ways),
|
|
4090
|
+
}, () => this.clipboardWaysOf(session), { focused: () => ui.isFocused(), viewOnly: () => ui.isViewOnly() });
|
|
4091
|
+
ui.clipboardSender = () => clipboard.sendNow();
|
|
4092
|
+
const { username, domain } = (0, accounts_1.signInParts)(endpoint.credentials.username, endpoint.domain ?? spec.domain ?? '');
|
|
4007
4093
|
const gateway = spec.gateway ? (0, gateway_1.parseGateway)(spec.gateway) : null;
|
|
4008
4094
|
session.status(`Connecting to ${spec.name} with FreeRDP…`);
|
|
4009
4095
|
let connected = false;
|
|
@@ -4017,8 +4103,12 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4017
4103
|
pipeline: spec.kind === 'gnome' || process.env.TRD_FREERDP_PIPELINE === '1',
|
|
4018
4104
|
autologon: spec.kind === 'xrdp',
|
|
4019
4105
|
relaxOrderChecks,
|
|
4106
|
+
glyphCache,
|
|
4107
|
+
bitmapCache,
|
|
4108
|
+
clipboard: (0, clipboard_1.clipboardWays)(session.clipboard),
|
|
4109
|
+
remoteText: text => clipboard.remote(text),
|
|
4020
4110
|
open: async (abort) => {
|
|
4021
|
-
const stream = gateway ? await this.
|
|
4111
|
+
const stream = gateway ? await this.throughGatewayStream(target, spec, session, gateway, endpoint, abort) : await target.openTcp(endpoint.host, endpoint.port);
|
|
4022
4112
|
if (abort.aborted) {
|
|
4023
4113
|
stream.destroy();
|
|
4024
4114
|
throw new Error('Connection cancelled');
|
|
@@ -4039,6 +4129,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4039
4129
|
}
|
|
4040
4130
|
connected = true;
|
|
4041
4131
|
onConnected(Date.now());
|
|
4132
|
+
clipboard.start();
|
|
4042
4133
|
session.remoteSize = { ...info, scale: 100 };
|
|
4043
4134
|
session.graphics = 'FreeRDP native bitmaps';
|
|
4044
4135
|
ui.setVisibility(session.visible);
|
|
@@ -4067,6 +4158,7 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4067
4158
|
}
|
|
4068
4159
|
finally {
|
|
4069
4160
|
signal.removeEventListener('abort', stop);
|
|
4161
|
+
clipboard.stop();
|
|
4070
4162
|
native.shutdown();
|
|
4071
4163
|
}
|
|
4072
4164
|
}
|
|
@@ -4162,8 +4254,8 @@ let RemoteDesktopService = RemoteDesktopService_1 = class RemoteDesktopService {
|
|
|
4162
4254
|
const settings = this.settingsFor(session);
|
|
4163
4255
|
const size = session.initialSize ?? remoteSizeFor(session.overlay.getBoundingClientRect(), settings);
|
|
4164
4256
|
const { width, height } = size;
|
|
4165
|
-
// DOMAIN\user
|
|
4166
|
-
const
|
|
4257
|
+
// DOMAIN\user is split; user@domain, a PAM proxy's bracketed name and a name after a leading \ go as typed.
|
|
4258
|
+
const { username, domain } = (0, accounts_1.signInParts)(credentials.username, endpoint.domain ?? spec.domain ?? '');
|
|
4167
4259
|
session.status(spec.id === desktops_1.OWN_DESKTOP ? `Connecting to ${target.label}…`
|
|
4168
4260
|
: target.direct ? `Connecting to ${spec.name}…` : `Connecting to ${spec.name} via ${target.label}…`);
|
|
4169
4261
|
// The name the server is signed in to as: the SSH host's for its own desktop, and for its VMs' consoles.
|
|
@@ -4333,15 +4425,7 @@ RemoteDesktopService.STABLE_MS = 30000;
|
|
|
4333
4425
|
RemoteDesktopService.RECLAIMED_AGAIN_MS = 10 * 60000;
|
|
4334
4426
|
exports.RemoteDesktopService = RemoteDesktopService = RemoteDesktopService_1 = __decorate([
|
|
4335
4427
|
(0, core_1.Injectable)({ providedIn: 'root' }),
|
|
4336
|
-
__metadata("design:paramtypes", [tabby_core_1.AppService,
|
|
4337
|
-
targets_1.RemoteTargets,
|
|
4338
|
-
tabby_core_1.NotificationsService,
|
|
4339
|
-
tabby_core_1.ConfigService,
|
|
4340
|
-
core_1.NgZone,
|
|
4341
|
-
tabby_core_1.ProfilesService,
|
|
4342
|
-
help_1.RemoteDesktopHelp,
|
|
4343
|
-
tabby_core_1.SelectorService,
|
|
4344
|
-
tabby_core_1.PlatformService])
|
|
4428
|
+
__metadata("design:paramtypes", [tabby_core_1.AppService, targets_1.RemoteTargets, tabby_core_1.NotificationsService, tabby_core_1.ConfigService, core_1.NgZone, tabby_core_1.ProfilesService, help_1.RemoteDesktopHelp, tabby_core_1.SelectorService, tabby_core_1.PlatformService])
|
|
4345
4429
|
], RemoteDesktopService);
|
|
4346
4430
|
/** A desktop's `who` (see DesktopSession) as compared: in any case for Windows, whose user names and domains are. */
|
|
4347
4431
|
function whoOf(spec, who) {
|
package/dist/desktopForm.js
CHANGED
|
@@ -55,11 +55,6 @@ function askDesktop(pane, options) {
|
|
|
55
55
|
</select>
|
|
56
56
|
<select class="form-control" name="client" aria-label="RDP client" title="RDP client. Applies on the next connection."></select>
|
|
57
57
|
<div class="text-muted small">FreeRDP preview: display and input; clipboard, sound and shared folders are unavailable.</div>` + `
|
|
58
|
-
<select class="form-control" name="relaxOrderChecks" aria-label="Relax drawing order checks (FreeRDP)" title="For a black screen or unannounced drawing order from a server or PAM proxy. Applies on the next FreeRDP connection.">
|
|
59
|
-
<option value="">Drawing order checks: as in Settings</option>
|
|
60
|
-
<option value="on">Relax drawing order checks (FreeRDP)</option>
|
|
61
|
-
<option value="off">Keep strict drawing order checks</option>
|
|
62
|
-
</select>` + `
|
|
63
58
|
<select class="form-control" name="account" title="Saved accounts are added in Settings › Remote Desktop › Accounts"></select>
|
|
64
59
|
<input class="form-control" name="username" placeholder="User name (optional; asked when connecting)" spellcheck="false">
|
|
65
60
|
<input class="form-control" name="domain" placeholder="Domain (optional)" spellcheck="false">` + `
|
|
@@ -67,6 +62,22 @@ function askDesktop(pane, options) {
|
|
|
67
62
|
<select class="form-control" name="gatewayAccount" title="A gateway that takes another account than the desktop: a saved account for it"></select>` + `
|
|
68
63
|
<input class="form-control" name="wake" placeholder="Start it when off (optional): libvirt VM name, or MAC address" title="A libvirt VM on the host, started with virsh; or a MAC address to wake over the network from the host" spellcheck="false">
|
|
69
64
|
<select class="form-control" name="clipboard" title="Which ways text, pictures and files copied on either side go between this computer and the desktop. Applies on the next connection"></select>
|
|
65
|
+
<h5>FreeRDP compatibility</h5>
|
|
66
|
+
<select class="form-control" name="glyphCache" aria-label="Glyph caching (FreeRDP)" title="Experimental glyph caching for older RDP servers or PAM login screens with missing text. May cause display artifacts; applies on reconnect.">
|
|
67
|
+
<option value="">Glyph caching: as in Settings</option>
|
|
68
|
+
<option value="on">Enable glyph caching (experimental)</option>
|
|
69
|
+
<option value="off">Disable glyph caching</option>
|
|
70
|
+
</select>` + `
|
|
71
|
+
<select class="form-control" name="bitmapCache" aria-label="Bitmap caching (FreeRDP)" title="Experimental bitmap caching for servers or PAM login screens with missing pictures or logos. May cause display artifacts; applies on reconnect.">
|
|
72
|
+
<option value="">Bitmap caching: as in Settings</option>
|
|
73
|
+
<option value="on">Enable bitmap caching (experimental)</option>
|
|
74
|
+
<option value="off">Disable bitmap caching</option>
|
|
75
|
+
</select>` + `
|
|
76
|
+
<select class="form-control" name="relaxOrderChecks" aria-label="Relax drawing order checks (FreeRDP)" title="For a black screen or unannounced drawing order from a server or PAM proxy. Applies on the next FreeRDP connection.">
|
|
77
|
+
<option value="">Drawing order checks: as in Settings</option>
|
|
78
|
+
<option value="on">Relax drawing order checks (FreeRDP)</option>
|
|
79
|
+
<option value="off">Keep strict drawing order checks</option>
|
|
80
|
+
</select>` + `
|
|
70
81
|
<div class="trd-signin-buttons">
|
|
71
82
|
<button type="button" class="btn btn-secondary" name="cancel">Cancel</button>
|
|
72
83
|
<button type="submit" class="btn btn-primary"></button>
|
|
@@ -92,7 +103,9 @@ function askDesktop(pane, options) {
|
|
|
92
103
|
const client = field('client');
|
|
93
104
|
client.append(new Option('RDP client: as in Settings', ''), ...Object.entries(rdpClient_1.RDP_CLIENT_LABELS).map(([id, label]) => new Option(label, id)));
|
|
94
105
|
client.value = (0, rdpClient_1.ownRDPClient)(initial.client) ?? '';
|
|
95
|
-
|
|
106
|
+
for (const key of ['glyphCache', 'bitmapCache', 'relaxOrderChecks']) {
|
|
107
|
+
field(key).value = initial[key] === true ? 'on' : initial[key] === false ? 'off' : '';
|
|
108
|
+
}
|
|
96
109
|
// A VM saved from the host's list is xrdp on the host's word (see xrdpFromHost), which is a choice of its own here:
|
|
97
110
|
// kept as long as it is chosen, so that the desktop still asks before signing in without NLA. Any kind picked is
|
|
98
111
|
// the user's, xrdp included.
|
|
@@ -219,10 +232,14 @@ function askDesktop(pane, options) {
|
|
|
219
232
|
gatewayAccount: gatewayText && gatewayAccount.value || undefined,
|
|
220
233
|
clipboard: clipboard.value || undefined,
|
|
221
234
|
client: (0, rdpClient_1.ownRDPClient)(client.value),
|
|
235
|
+
glyphCache: field('glyphCache').value === 'on' ? true
|
|
236
|
+
: field('glyphCache').value === 'off' ? false : undefined,
|
|
237
|
+
bitmapCache: field('bitmapCache').value === 'on' ? true
|
|
238
|
+
: field('bitmapCache').value === 'off' ? false : undefined,
|
|
222
239
|
relaxOrderChecks: field('relaxOrderChecks').value === 'on' ? true
|
|
223
240
|
: field('relaxOrderChecks').value === 'off' ? false : undefined,
|
|
224
241
|
};
|
|
225
|
-
for (const key of ['username', 'domain', 'account', 'wake', 'gateway', 'gatewayAccount', 'clipboard', 'client', 'relaxOrderChecks']) {
|
|
242
|
+
for (const key of ['username', 'domain', 'account', 'wake', 'gateway', 'gatewayAccount', 'clipboard', 'client', 'glyphCache', 'bitmapCache', 'relaxOrderChecks']) {
|
|
226
243
|
if (entry[key] === undefined) {
|
|
227
244
|
delete entry[key];
|
|
228
245
|
}
|
package/dist/desktops.js
CHANGED
|
@@ -61,7 +61,9 @@ function specOf(extra) {
|
|
|
61
61
|
const clipboard = (0, clipboard_1.ownClipboard)(extra?.clipboard);
|
|
62
62
|
const client = (0, rdpClient_1.ownRDPClient)(extra?.client);
|
|
63
63
|
const own = { ...clipboard ? { clipboard } : {}, ...client ? { client } : {},
|
|
64
|
-
...typeof extra?.relaxOrderChecks === 'boolean' ? { relaxOrderChecks: extra.relaxOrderChecks } : {}
|
|
64
|
+
...typeof extra?.relaxOrderChecks === 'boolean' ? { relaxOrderChecks: extra.relaxOrderChecks } : {},
|
|
65
|
+
...typeof extra?.glyphCache === 'boolean' ? { glyphCache: extra.glyphCache } : {},
|
|
66
|
+
...typeof extra?.bitmapCache === 'boolean' ? { bitmapCache: extra.bitmapCache } : {} };
|
|
65
67
|
const hyperv = (0, hyperv_1.vmId)(extra?.hyperv);
|
|
66
68
|
if (hyperv) {
|
|
67
69
|
return hyperVSpec(hyperv, configText(extra.name) || hyperv, {
|