tabby-rdp 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,5 +1,54 @@
 # Changelog
 
+## 0.5.3
+
+**Added**
+- **Each desktop connection has its own WebAssembly instance**, while sharing compiled IronRDP code. Reconnecting
+  or recovering from an instance fault creates a fresh backend for that desktop without replacing other desktops.
+- **Instance lifecycle checks** cover independent memories, cleanup, reconnects and collection after disposal,
+  with a browser smoke test and a live two-desktop isolation suite.
+
+**Security** (a review of 0.5.3-rc.1; all of these were in 0.5.2 too)
+- **Moving the pointer over a desktop no longer gives it the keyboard and the clipboard.** IronRDP's canvas took the
+  focus without a click, so keys typed into the terminal next to it (a password at a prompt that doesn't echo
+  included) and this computer's clipboard went to that remote server; also from behind a maximized pane. A desktop
+  now takes the keyboard only in the pane in front, and gives it back to where it came from otherwise.
+- **A desktop lets go of the keyboard when its tab is left by keyboard** for one that takes no focus (Settings, the
+  welcome tab): it went on taking the keys typed and the clipboard copied, view only included. Keys that reach a
+  desktop not in front now stop at the plugin. The shortcut's modifier, still down as the tab goes, is let go of on
+  the remote too, whichever tab is left for: its keyup goes where the user went, and IronRDP lets go of nothing as its
+  canvas loses the focus, so the modifier stayed held there until it was pressed again (a held Alt has the next key
+  open a menu on Windows).
+- **A crafted .rdp file can't hang Tabby's window**: a line of whitespace took time that grew with the cube of its
+  length to parse (seconds for a few thousand spaces). Files over 1 MB are refused unread.
+
+**Fixed**
+- **Removing a profile without an address no longer forgets what was saved for 127.0.0.1:3389.**
+- **The architecture document gives the update check's real limit** (4 MB for the version catalog, not 256 KB).
+- **Tabby's window no longer crashes when a desktop reached directly is refused after TLS** (#69): on Linux, the
+  first connection to any desktop in a remote desktop tab (a profile, quick connect, an .rdp file), whose certificate
+  is asked about before anything of the sign-in goes to it, closed the window and left Tabby running in the
+  background. A changed certificate did the same. The plugin now closes TLS before the socket under it. Desktops
+  behind an SSH host were not affected.
+- **Removing a saved gateway account keeps gateway credentials separate.** Inherited gateway uses are listed in
+  the removal confirmation; affected desktops and group defaults ask for a gateway account on the next connection.
+  Missing named gateway accounts also ask separately instead of silently using the destination credentials.
+- **The desktop inventory shows effective profile settings**, including inherited gateway routing, gateway accounts,
+  SSH profiles, sign-in names and connection kinds.
+- **Ended connections release their backend and browser resources**, including timers, global listeners, media,
+  and the statistics indicator's canvas hook, while retaining the last picture for the disconnected pane.
+- **Profile Save validates the address and RD Gateway before committing either field.** Invalid edits keep the
+  editor open and focus the field to correct, instead of saving an invalid gateway or silently keeping an old address.
+  Blank destinations preserve custom and inherited default ports when saving unrelated changes.
+
+**Changed**
+- **The rollback minimum is 0.5.3.** Updates persists this minimum to protect saved separate gateway prompts
+  from older versions that would reuse desktop credentials, and records a target release's minimum on installation.
+- **Preview publishing uses npm's beta tag** for both beta and release-candidate versions. GitHub release drafts
+  remain unpublished until the staged npm package is approved and verified.
+
+Qualification and remaining stable-release checks are tracked in [#49](https://github.com/meanaverage/tabby-rdp/issues/49).
+
 ## 0.5.2
 
 **Added**

package/README.md

@@ -86,7 +86,8 @@ Open **Settings › Remote Desktop › Updates** to manage the installed version
 - **Stable** is the default. **Preview** also offers beta releases and release candidates when available.
 - Automatic checks look for updates once a day. **Check now** checks manually; installation is always your choice.
 - Choose an exact compatible version, **Return to stable**, or **Restore previous version** after an installation
-  from this page. Version changes currently support **0.5.1 or newer**.
+  from this page. After running **0.5.3**, version changes require **0.5.3 or newer** to preserve separate
+  gateway sign-in prompts; returning to an older stable release is blocked.
 - **Uninstall plugin…** removes the package. **Manage in Tabby…** opens Tabby's plugin controls to disable it.
   Saved connections, settings, passwords and remote setup are kept.
 

package/TROUBLESHOOTING.md

@@ -64,12 +64,17 @@ In **0.5.2 or newer**, open **Settings › Remote Desktop › Updates**. **Stabl
 
 The confirmation dialog stays open through progress and the verified result. If installation fails, the dialog shows the cause. After success, close remote desktops and restart Tabby; Updates shows the running version and the installed version waiting for restart until then.
 
-Use **0.5.1 or newer** with current account and certificate settings, and respect any higher minimum documented by a later data migration.
+After running **0.5.3**, use **0.5.3 or newer**, including after uninstalling and reinstalling. This version
+can save a separate gateway sign-in prompt (`@ask`) in desktops, profiles and defaults, including when a saved gateway
+account is removed. Versions **0.5.1 and 0.5.2** can silently use the desktop's credentials for that gateway instead.
+Updates records this minimum on startup even if update checks are paused, and retains the highest recorded minimum.
+The safeguard applies to this computer's Updates page; manual npm installation, Tabby's plugin controls and older
+installations on other computers can bypass it. Use the same minimum wherever this configuration is copied or synced.
 
 If the plugin cannot load:
 
 1. Open **Tabby › Settings › Plugins**. Disable **tabby-rdp** to stop it loading, or uninstall and reinstall it there. Restart Tabby after changing plugins. Tabby’s [configuration locations](https://github.com/Eugeny/tabby/wiki/Config-file) help locate your profile when the application cannot open.
-2. For a specific known compatible version, open a terminal in **Tabby's plugin folder** (the folder containing the plugin installation's `package.json`, with `node_modules/tabby-rdp` below it). Run `npm install tabby-rdp@0.5.1`, replacing `0.5.1` with your known compatible exact version. Do not run this in the tabby-rdp source checkout, the application bundle, or inside `node_modules/tabby-rdp` itself. Fully quit and reopen Tabby afterwards.
+2. For a specific known compatible version, open a terminal in **Tabby's plugin folder** (the folder containing the plugin installation's `package.json`, with `node_modules/tabby-rdp` below it). Run `npm install tabby-rdp@0.5.3`, replacing `0.5.3` with your known compatible exact version at or above the minimum above. Do not run this in the tabby-rdp source checkout, the application bundle, or inside `node_modules/tabby-rdp` itself. Fully quit and reopen Tabby afterwards.
 3. If a later version has migrated saved data, respect that version's documented minimum. Reinstall a compatible stable version or the last working preview; do not force an older version across a migration boundary.
 
 Disabling or uninstalling keeps desktops, profiles, settings, remembered certificates and saved credentials. It also leaves any remote helpers and remote applications in place. To remove saved entries, use **Remote Desktop › Desktops** and **Accounts**, and **Profiles & connections** for profiles, before uninstalling. Unlock the credential store first if required; check any reported failure rather than assuming a credential was deleted. Data synced to other computers may need attention there too.

package/dist/accounts.js

@@ -1,9 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.ASK_GATEWAY_ACCOUNT = void 0;
 exports.accountsOf = accountsOf;
 exports.newAccountId = newAccountId;
 exports.signInName = signInName;
 exports.accountKey = accountKey;
+/** A separate gateway sign-in prompt. The '@' cannot occur in a saved account's id. */
+exports.ASK_GATEWAY_ACCOUNT = '@ask';
 /** The usable entries of `remoteDesktop.accounts` (hand-written ones may lack fields). */
 function accountsOf(store) {
     const list = Array.isArray(store?.accounts) ? store.accounts : [];

package/dist/connectionStatus.js

@@ -34,7 +34,7 @@ class ConnectionStatus {
         this.ticks = 0;
         this.last = null;
         this.frames = 0;
-        this.hooked = null;
+        this.frameHook = null;
         this.latency = null;
         this.pinging = false;
         this.active = false;
@@ -57,6 +57,9 @@ class ConnectionStatus {
         if (active && canvas) {
             this.countFrames(canvas);
         }
+        else if (!active) {
+            this.releaseCanvas();
+        }
         if (active === this.active) {
             return;
         }
@@ -90,13 +93,16 @@ class ConnectionStatus {
      */
     countFrames(canvas) {
         const ctx = canvas.getContext('2d');
-        if (!ctx || ctx === this.hooked) {
+        if (ctx === this.frameHook?.context) {
+            return;
+        }
+        this.releaseCanvas();
+        if (!ctx) {
             return;
         }
-        this.hooked = ctx;
         const original = ctx.putImageData;
         let batch = false;
-        ctx.putImageData = ((...args) => {
+        const wrapped = ((...args) => {
             if (!batch) {
                 batch = true;
                 this.frames++;
@@ -104,6 +110,17 @@ class ConnectionStatus {
             }
             return original.apply(ctx, args);
         });
+        ctx.putImageData = wrapped;
+        this.frameHook = { context: ctx, original, wrapped };
+    }
+    /** A detached canvas's handlers retain its backend, even after its component has been removed. */
+    releaseCanvas() {
+        const hook = this.frameHook;
+        this.frameHook = null;
+        // Leave a later owner's replacement alone.
+        if (hook && hook.context.putImageData === hook.wrapped) {
+            hook.context.putImageData = hook.original;
+        }
     }
     tick() {
         const now = performance.now();